Magisk General Support / Discussion

Search This thread

meric57

Senior Member
Oct 2, 2017
94
18
Hettange Grand
Hello, I have tried with magisk canary 5f4cd50c 23017, falsified odin 3.14 with AP correction under android 12 nothing this fact must not be restarted once I had to do a factory reset. re installed magisk and patched a magisk 23017 image, if not if anyone successfully rooted their non 5G s10 G973F on android 12 DBT GVA4 who faced a tutorial thanks
 

Homeboy76

Senior Member
Aug 24, 2012
3,161
1,722
Google Pixel XL
Curious
I Installed
- Magisk 761a8dde-alpha
- SafetyNet 2.2.1
- Shamiko-v0.3.0-73
It hid the Magisk app. Could this be caused by the denylist being enabled?
When I checked settings, Hide the Magisk app is not enabled.:oops:
It passed SafetyNet and the device is certified.
 
Last edited:

pndwal

Senior Member
FWIW, I gave this response in a TG thread to a user who commented about TJW's recent employment and its implications for current Magisk: "...it was the restrictiveness that alarmed me". It may be of interest to some here. -
But what restrictions?...

John originally envisioned Zygisk as a framework for more powerful hiding in addition to enhanced module capability (some 2+ years ago now?) and he HAS DELIVERED! ...

Google has NOT stymied this, have publicly stated that they NEVER opposed root, only deliberate subversion of their security model (read SafetyNet API, incoming Play Integrity API etc) and have their own weapon that doesn't involve TJW to ensure this inevitably...

They've been strengthening Hardware Key Attestation for many years now - an early form of it predates Android 6 - and, as John has said, this will surely mean the end of hiding root as we know it; we will still have ability to hide root / magisk in userspace, but not unlocked bootloader / spoof Verified Boot Status which is the start of chain-of-trust for HKA.

Until Google swing their 'Big Hammer' (in deference to Devs who want assurance / to allow their code to run only in a TEE) however, we now have the structure to allow more powerful hiding as I said, and as John said 'Its time for others to start doing their job'...

He won't / can't do it, but neither he nor Google are preventing others; note that we already have Universal Safety net Fix, WIP Shamiko and LSPosed (with hiding solutions like Hide My Applist) powered by Zygisk now...

It must be said that John has done very little to strengthen MagiskHide aside from maintaining / adapting basic SafetyNet passing and Hide the Magisk app compatibility in new devices for several years now anyway, and even these have needed 3rd party fixes (MagiskHide Props Config fingerprint prop, force basic HKA fix and so on) for some time; much work was already being done by other Devs / researchers (hiding isolated process leaks, app intent queries, ID detections etc) long before John's Google tenure... And the SN hiding he did maintain is, as he puts it, 'trivial' for others to pick up...

Note also that Google is well aware of these efforts, and while they are bound to end them all w/ HKA at any tick of the clock, they are not meantime wasting time stopping modders beat Safety net etc. as they view these (especially Magisk users) as 'a healthy White Hat community' who's efforts actually benefit Google (help them identify / fix vulns) and not as people with 'nefarious goals' (summary of Reddit comments by Android Hardware-backed security team leader)...

We can thus have fun while the sun shines, and Google is actually facilitating this to the extent that they allow it / turn a blind eye (on purpose), ENCOURAGE modding efforts etc.

The refs for everything stated above are in XDA Magisk General Discussion Thread...

I hope this summary dispells some misinformation and also helps make clear how a symbiotic relationship with a healthy modding community makes Google's Android mobile platform and IOS two completely different animals...

I trust that both modders and corporate Big G value this difference... If either party dont, they're nuts in my book. PW
The way I see it, Google are our benefactors and Android custom modders are theirs... or vice versa... if you prefer... 🙃

...Why else would they employ the likes of John Wu? And there's got to be more in it for him than money! (wait, didn't he say that too?)... Viewed from this perspective there's no conflict of interest either!... (Nb. qualifyer 'from this perspective' before you argue. 😉) PW
 
Last edited:

pndwal

Senior Member
Latest Unofficial Alpha Magisk
(Chinese translated):

# alpha changelog

## Magisk (256d7156-alpha)
- [App] Support SharedUserId
- [App] Delete backup file after restoring boot image
- [App] Built-in current version update log
- [General] no longer automatically unlock device blocks
- [General] Use MagiskHide to hide when Zygisk is closed
- [App] Compatible with Android 12L
- [MagiskInit] Refactor the processing method of two-step startup
- [MagiskBoot] Speed up zopfli compression
- [General] Update to NDK 23

### how to install?
Install and uninstall Magisk through the Magisk application. Generally, it should be done directly in the application. In special cases such as the first installation, you should use the fastboot/odin tool to flash it after patching the image.
By customizing Recovery is not a supported way.

# Upstream changelog

## Magisk (cbe97cdf) (23018)

- [Zygisk] Show warning in app UI to indicate incompatible Zygisk modules
- [App] Allow modules to specify an update URL for in-app update + install

## Diffs to v23.0

- [General] MagiskHide is removed from Magisk
- [General] Support 64-bit only systems
- [General] Support Android 12
- [General] Update BusyBox to 1.34.1
- [Zygisk] Introduce new feature: Zygisk
- [Zygisk] Introduce DenyList feature to revert Magisk features in user selected processes
- [MagiskBoot] Support patching 32-bit kernel zImages
- [MagiskBoot] Support boot image header v4
- [MagiskBoot] Support patching out `skip_initramfs` from dtb bootargs
- [MagiskBoot] Add new env variable `PATCHVBMETAFLAG` to configure whether vbmeta flags should be patched
- [MagiskInit] Support loading fstab from `/system/etc` (required for Pixel 6)
- [MagiskInit] Support `/proc/bootconfig` for loading boot configurations
- [MagiskInit] Better support for some Meizu devices
- [MagiskInit] Better support for some OnePlus/Oppo/Realme devices
- [MagiskInit] Support `init.real` on some Sony devices
- [MagiskInit] Skip loading Magisk when detecting DSU
- [MagiskPolicy] Load `*_compat_cil_file` from system_ext
- [MagiskSU] Use isolated devpts if the kernel supports it
- [MagiskSU] Fix root shell if isolated mount namespace is set
- [resetprop] Deleted properties are now wiped from memory instead of just unlinking
- [App] Build a single APK for all ABIs
- [App] Switch to use standard bottom navigation bar
- [App] Downloading modules from the centralized Magisk-Modules-Repo is removed
- [App] Support user configuration of boot image vbmeta patching
- [App] Restore the ability to install Magisk on the other slot on some A/B devices
- [App] Allow modules to specify an update URL for in-app update + install

👍 PW
 

meric57

Senior Member
Oct 2, 2017
94
18
Hettange Grand
Hi, well I think these are good there c I have Sygisk with a yes and no return version. I even installed shamiko and safetynet fix v2.2.1 and play store and certified.
updated done
 
  • Like
Reactions: pndwal

pndwal

Senior Member
What is shamiko? I do not know what it is. weird
If you're into Manga she's The Demon Girl Next Door, a 15 year old high school student w/ horns and tail...
shamiko.jpeg

Dev explaination:
https://t.me/c/1414270883/37349 🤪

... However I think you want this:
https://forum.xda-developers.com/t/magisk-general-support-discussion.3432382/post-86306355

😜 PW
 
Last edited:
  • Like
Reactions: rodken

pndwal

Senior Member
Latest Shamiko:
(Bit late with this, sorry)

# Shamiko

こっっ… これで勝ったと思うなよ―――!!
[This ... I don't think I won with this --- !!]?​

### Introduction
Shamiko is a Zygisk module to hide Magisk root, Zygisk itself and Zygisk modules like riru hide.
Shamiko read the list of apps to hide from Magisk's denylist for simplicity but it requires denylist to be disabled first.
### Usage
1. Install Shamiko and enable Zygisk and reboot
1. Turn on denylist to configure denylist.
1. Once denylist is configured, disable it to activate Shamiko

### Changelog
#### 0.2.0
1. Support font modules since Android S
1. Fix module's description

#### 0.3.0
1. Support whitelist (enable by creating an empty file `/data/adb/shamiko/whitelist`)
1. Always unshare (useful for old platforms and isolated processes in new platforms)
1. Request Magisk 23017+, which allows us to strip Java daemon and change denylist regardless of enforcement status
1. Temporarily disable showing status in module description (need to find a new way for it)
1. Support module update since Magisk 23017

https://t.me/magiskalpha/411

👍 PW
 

zgfg

Senior Member
Oct 10, 2016
7,167
4,618
Xiaomi 11 Lite 5g NE (Lisa): root, challenges

Long story short:
I actually ordered Renoir (omit "NE" from the name above) but 5nm Snapdragon 980 is out of stock and Xiaomi introduced Lisa instead with 6nm Snapdragon 978 (little lower Antutu and little longer battery endurance)

Thus Lisa is new, released first in Sep in India and now selling worldwide.
EEA MIUI 12.5.7, A11, updated to 12.5.8 upon unboxing (sh.., I forgot filming the happy unboxing to publish to YT 😁)

I'm still waiting for BL to be unlocked (cca 150 hrs to go), but started to research about 'rooting'

There is no TWRP yet for Lisa (there is the official 3.6.0 fot the six months older sibling Renoir), and I only found a PitchBlack recovery but based on TWRP 3.5.2 (hence not supporting A11 Data encryption).
And LOS 18.1 whose recovery (again, via ADB sideloading, SD card or OTG stick, since encryption is not supported) some also used to install ArrowOS.
So far about the custom ROMs and recoveries

Well, I downloaded the official EEA 12.5.8 and unzipped - however, there are no img files inside (as they used to be) but instead a 3.2 GB payload.bin
I tried to patch, it failed claiming that format was not recognized

However, Xiaomi.eu ('debloated' MIUI ROMs) did release Stable 12.7.0
Since there is no TWRP yet it must be flashed from Fastboot - but their zip contains the boot img that can be patched (just tested with Alpha) hence installing the Magisk is possible (to Xiaomi.eu)

MIUI 13, A12: already in Beta for Renoir (Chinna weekly betas and debloated Xiaomi.eu weeklies on the go), but still awaiting for Lisa
 

pndwal

Senior Member

Latest Canary Magisk:​

Magisk (cbe97cdf) (23018)​

  • [Zygisk] Show warning in app UI to indicate incompatible Zygisk modules
  • [App] Allow modules to specify an update URL for in-app update + install

Diffs to v23.0​

  • [General] MagiskHide is removed from Magisk
  • [General] Support 64-bit only systems
  • [General] Support Android 12
  • [General] Update BusyBox to 1.34.1
  • [Zygisk] Introduce new feature: Zygisk
  • [Zygisk] Introduce DenyList feature to revert Magisk features in user selected processes
  • [MagiskBoot] Support patching 32-bit kernel zImages
  • [MagiskBoot] Support boot image header v4
  • [MagiskBoot] Support patching out skip_initramfs from dtb bootargs
  • [MagiskBoot] Add new env variable PATCHVBMETAFLAG to configure whether vbmeta flags should be patched
  • [MagiskInit] Support loading fstab from /system/etc (required for Pixel 6)
  • [MagiskInit] Support /proc/bootconfig for loading boot configurations
  • [MagiskInit] Better support for some Meizu devices
  • [MagiskInit] Better support for some OnePlus/Oppo/Realme devices
  • [MagiskInit] Support init.real on some Sony devices
  • [MagiskInit] Skip loading Magisk when detecting DSU
  • [MagiskPolicy] Load *_compat_cil_file from system_ext
  • [MagiskSU] Use isolated devpts if the kernel supports it
  • [MagiskSU] Fix root shell if isolated mount namespace is set
  • [resetprop] Deleted properties are now wiped from memory instead of just unlinking
  • [App] Build a single APK for all ABIs
  • [App] Switch to use standard bottom navigation bar
  • [App] Downloading modules from the centralized Magisk-Modules-Repo is removed
  • [App] Support user configuration of boot image vbmeta patching
  • [App] Restore the ability to install Magisk on the other slot on some A/B devices
  • [App] Allow modules to specify an update URL for in-app update + install
https://github.com/topjohnwu/magisk-files/blob/26d8423b5883336d4853c238919dc66cb3b9f810/notes.md

👍 PW
 
Last edited:
Jul 26, 2012
23
1

Latest Canary Magisk:​

Magisk (cbe97cdf) (23018)​

  • [Zygisk] Show warning in app UI to indicate incompatible Zygisk modules
  • [App] Allow modules to specify an update URL for in-app update + install

Diffs to v23.0​

  • [General] MagiskHide is removed from Magisk
  • [General] Support 64-bit only systems
  • [General] Support Android 12
  • [General] Update BusyBox to 1.34.1
  • [Zygisk] Introduce new feature: Zygisk
  • [Zygisk] Introduce DenyList feature to revert Magisk features in user selected processes
  • [MagiskBoot] Support patching 32-bit kernel zImages
  • [MagiskBoot] Support boot image header v4
  • [MagiskBoot] Support patching out skip_initramfs from dtb bootargs
  • [MagiskBoot] Add new env variable PATCHVBMETAFLAG to configure whether vbmeta flags should be patched
  • [MagiskInit] Support loading fstab from /system/etc (required for Pixel 6)
  • [MagiskInit] Support /proc/bootconfig for loading boot configurations
  • [MagiskInit] Better support for some Meizu devices
  • [MagiskInit] Better support for some OnePlus/Oppo/Realme devices
  • [MagiskInit] Support init.real on some Sony devices
  • [MagiskInit] Skip loading Magisk when detecting DSU
  • [MagiskPolicy] Load *_compat_cil_file from system_ext
  • [MagiskSU] Use isolated devpts if the kernel supports it
  • [MagiskSU] Fix root shell if isolated mount namespace is set
  • [resetprop] Deleted properties are now wiped from memory instead of just unlinking
  • [App] Build a single APK for all ABIs
  • [App] Switch to use standard bottom navigation bar
  • [App] Downloading modules from the centralized Magisk-Modules-Repo is removed
  • [App] Support user configuration of boot image vbmeta patching
  • [App] Restore the ability to install Magisk on the other slot on some A/B devices
  • [App] Allow modules to specify an update URL for in-app update + install

👍 PW
I Got Bootloop After Update It.. Huhu
 

zgfg

Senior Member
Oct 10, 2016
7,167
4,618
Updated to all the latest:

- Alpha 256d7156 (23018) - screenshot "0"
- Shamiko 0.3.0 (73)
- LSposed-Zygisk 1.6.5 (6317)

All functionalities working fine

Observations:

Shamiko does no more display status but in Changelog it says it is temporarily disabled (screenshot "4")

Update for modules (Download/Install) works fine but it requires a new field "changelog" in json.
And changelog must be the URL to the changelog text file - i.e., changelog text must not be embedded to the json (screenshots "1", "2", "3")

LSPosed does not have a proper json, hence evengrayed-out Update is not displyed

Experiment (use root explorer like MiXPlorer):

- Go to /data/adb/modules/zygisk_shamiko
- Open module.prop (text file)
- Downgrade "versionCode" to 71

Reopen Modules page in Magisk app - now the Update for Shamiko will become active (no more grayed-out)

Click to Update, and you will be able to just Download or install ('update') Shamiko - you don't need since you already have (73), it was just the trick to downgrade versionCode to(71) to enable the Update button

However, "changelog" in Shamiko json is text itself, not a link to the text file - hence some garbage will be displayed instead of the real changelog (don't worry, just a cosmetics) - screenshot "5"
 

Attachments

  • 0.jpg
    0.jpg
    164.6 KB · Views: 74
  • 1.jpg
    1.jpg
    184.1 KB · Views: 62
  • 2.jpg
    2.jpg
    209.8 KB · Views: 65
  • 3.jpg
    3.jpg
    222.1 KB · Views: 67
  • 4.jpg
    4.jpg
    492.9 KB · Views: 70
  • 5.jpg
    5.jpg
    370.1 KB · Views: 73
  • Like
Reactions: rodken and ipdev

ipdev

Recognized Contributor
Feb 14, 2016
1,746
1
2,947
Google Nexus 10
Nexus 7 (2013)
To add to what @zgfg noted. ^^

The update json file needs to include a link to a change log file.

module.prop
Code:
id=zipbin
name=Zip Binary
version=Module (v4)
versionCode=40
author=ip
description=Simple module that will add a zip binary into system/bin
support=https://github.com/ipdev99/mModule_zipbin
updateJson=https://raw.githubusercontent.com/ipdev99/mModule_zipbin/master/zipbin.json

zipbin.json
Code:
{
  "versionCode": "40",
  "version": "Module (v4)",
  "zipUrl": "https://github.com/ipdev99/mModule_zipbin/releases/download/v4/ZipBin-v4.zip",
  "changelog": "https://github.com/ipdev99/mModule_zipbin/releases/download/v4/v4.md"
}
Cheers all. :cowboy:

Edit:
Magisk (canary) shows a download error when the changelog is not a link. ;)
 

Attachments

  • Screenshot_20220123-134615.png
    Screenshot_20220123-134615.png
    158.5 KB · Views: 101
  • Screenshot_20220123-151237.png
    Screenshot_20220123-151237.png
    176.6 KB · Views: 101
  • Screenshot_20220123-172208.png
    Screenshot_20220123-172208.png
    154.2 KB · Views: 102
Last edited:
  • Like
Reactions: rodken and zgfg

Top Liked Posts

  • There are no posts matching your filters.
  • 7
    Latest Shamiko:

    Shamiko v0.5.0

    0.5.0​

    • Better hiding Zygisk
    "... Momo enjoys helping Shamiko become stronger in all aspects despite Shamiko's goal of defeating her..."

    👍 PW
    6

    Latest Official TJW debug Canary Magisk:​

    Magisk (cc79a96f) (24307)​

    • [App] Update libsu with 100% new I/O layer
    • [MagiskInit] Mock enforce file with regular file to prevent possible race condition
    • Switch normal NDK with ONDK, preparing the toolchain to introduce Rust

    Diffs to v24.3​

    • [MagiskInit] Update 2SI implementation, significantly increase device compatibility (e.g. Sony Xperia devices)
    • [MagiskInit] Introduce new sepolicy injection mechanism
    • [MagiskInit] Support Oculus Go
    • [App] [MagiskSU] Properly support apps using shared UID
    • [MagiskSU] Fix a possible crash in magiskd
    • [Zygisk] Fix function hooking on devices running Android 12 with old kernels
    • [BusyBox] Add workaround for devices running old kernels
    https://github.com/topjohnwu/magisk-files/blob/a66dfce1bf88a70e86bf86c5427b1c58e71a4fc2/notes.md

    👍 PW
    6
    Looks like major libsu release is now imminent; most fixes are now merged.

    Should see major stability improvements in Magisk and root app implementation... Should see new commits for Magisk proper again soon too!

    John has made some major libsu changes (see libsu GitHub).

    Here are extra comments on vvb2060 fixes from her TG (Chinese translated....


    👀 PW
    libsu 5.0.0 is out!

    libsu/CHANGELOG.md

    5.0.0​

    Check the updated Javadoc and the example app for details on how to use the remote file system in the new nio module.

    New Features​

    • Introduce a new module: nio
      • Includes file system implementations for local and remote processes
      • New FileSystemManager class to access either local or remote file system implementations
      • New ExtendedFile class to extend functionality of the old Java File API
    • [core] New API Shell.isAppGrantedRoot() returns a nullable Boolean:
      • true if a root shell has been created
      • false if it has been determined that root access is impossible to get
      • null if the library has not, or could not determine the current root grant state. Future invocations of this method may return a non-null value if the library gained more information during shell creation.
    • [core] New API Shell.Builder.setContext(context): allow the developer to explicitly provide a Context object
    • [io] SuFile is updated to also extend ExtendedFile, which adds some new features and APIs

    Deprecation​

    • Version 5.0.0 will be the final release of the busybox module. If you cannot remove the usage of the module, you can pin the busybox module to version 5.0.0, as it is updated to be fully self contained, making it guaranteed to work with future libsu versions.
    • Usage of SuFile/SuFileOutputStream/SuFileInputStream/SuRandomAccessFile is discouraged. Although these APIs will remain for the foreseeable future, please migrate to use RootService + the nio module for all root I/O operations.
    • Shell.rootAccess() is deprecated. Please switch to use the more accurate Shell.isAppGrantedRoot() API

    John Wu, 2h

    Major libsu update 5.0.0!

    Introduces a new module "nio" to perform I/O operations through root services, moving away from the error prone, inefficient shell command backed I/O the library used to provide.

    It's already using splice under-the-hood. There is already some Linux magic!

    New readme etc. Read how you can Attach Debugger to Android Process in Root Services and more!
    https://github.com/topjohnwu/libsu

    👏👍🥳

    ... Back to regular Magisk programming... PW
    6
    Latest Official TJW debug Canary Magisk:

    Magisk (985249c3) (24309)​

    Pixel 6 Android 13 Beta 2 support is here!

    • [App] Support requesting root from non app process
    • [App] Fix deadlocking a background thread on non-root devices
    • [MagiskInit] Support GKIs with no ramdisk (Pixel 6 Android 13)

    Diffs to v24.3​

    • [MagiskInit] Update 2SI implementation, significantly increase device compatibility (e.g. Sony Xperia devices)
    • [MagiskInit] Introduce new sepolicy injection mechanism
    • [MagiskInit] Support Oculus Go
    • [MagiskInit] Support GKIs with no ramdisk (Pixel 6 Android 13)
    • [App] [MagiskSU] Properly support apps using shared UID
    • [MagiskSU] Fix a possible crash in magiskd
    • [Zygisk] Fix function hooking on devices running Android 12 with old kernels
    • [BusyBox] Add workaround for devices running old kernels
    https://github.com/topjohnwu/magisk-files/blob/56da1fe5430b2c04701ce73d1658ba698ee92283/notes.md

    👍 PW
    5
    Yep, trying to install/run 24308. unfortunately I don't recall the version I had running prior to the factory reset
    Confirms my theory...

    I was asking about wipe type as this issue occurs when root is lost... It may occur with root if app cannot detect it too, eg you installed Magisk app, ran Hide the Magisk app function, subsequently updated the app or manually installed another and it didn't detect / remove the hidden (obfuscated) one and subsequently you have a case of DCAS* which results in Magisk Installed = N/A

    [*Dual Conflicting App Syndrome]

    Since you indicated you had rooted boot image and factory reset (?) only, root loss does seem unlikely, but could be explained by DCAS if you did in fact play with Hide the Magisk app, or actually flashed images since factory reset, or even ran Magisk in-app Uninstall before doing f reset / wipe...

    However If my deductions are correct you seem to have this issue:
    Magisk app ANR on non-root devices #5787

    Fix is already merged but not built yet:
    0ac19e3 Fix app running without root

    I mentioned this here:
    https://forum.xda-developers.com/t/magisk-general-support-discussion.3432382/post-86856305

    If you think I'm right, until next Canary release you can either 1) locate and uninstall conflicting hidden app ('System' or whatever you renamed it) in device settings, apps [if this accounts for Canary app not finding root], then 24308 should work, or 2) install either this test build: https://github.com/topjohnwu/Magisk/actions/runs/2285778144 (extract from artifacts), 24306 or earlier Canary, or 24.3 Stable [if hroot has really been lost / boot image restored etc], then use working Magisk App to do initial patching again...

    Hope I'm on the money...

    🤠 PW
  • 1077
    This is the place for general support and discussion regarding "Public Releases", which includes both stable and beta releases.
    All information, including troubleshoot guides and notes, are in the Announcement Thread
    156
    Hello, I haven't given much support on XDA lately. It can be resulted from
    • University started and I have limited free time. In fact, I mostly develop during midnight
    • I live in Taiwan, which has large time zone differences between my European/American contributors/testers, which usually forces me to stay up late at night to discuss/test stuffs.
    • The new version is about to come, I don't want to spend effort on supporting old releases
    The planned update is delayed again and again, to some point I think I'll shed some light about what has been happening lately, also along with some announcements.

    New Forum!
    As you might have already discovered, Magisk got its own subforum on XDA! Many thanks to all the support you gave me, and much more information/features/support is about to come!
    **For developers supporting all the devices that are not using standard Android boot format, feel free to create threads in this section (actually, PLEASE do so) for your favorite devices after v7 is out. As I currently know, Asus devices require signing the boot image before flashing, and is model dependant; Sony devices seems to use ELF kernel that is unpatchable, or some has two ramdisks (inner + outer), both requires different workarounds; LG bootloader locked devices has to manually "BUMP" the boot image after flashing Magisk..... and there may be lots of other crazy boot image formats that haven't come up to my attention yet.
    It is impossible for me to support all these non-standard boot images, and I hope the community can collaborate to make Magisk running across all the devices. Overall, community collaboration is what XDA about :D

    The Pixel Phone
    Some of you might already know this news, that the next Pixel Phone right around the corner seems like it does not have ramdisk in boot image, which pretty much wrecked Magisk in all ways. However, it pretty much doomed root itself too. Kernel modifications is inevitable IMO, so I'll try to migrate my scripts to C programs that could possibly be included into the kernel itself. Note that I'm not familiar with linux kernel, I'm not even sure if my idea and concept is correct or not. But once the device is available, I think developers will find a way to bypass all the difficulties, and I'll do my best to learn things ;)

    Current Progress
    In the past month, I've spent quite some time learning SELinux, so that I can avoid using SuperSU's sepolicy patches. Thanks to the helps and tips from @phhusson and @Chainfire, I finally have a much clearer understanding of how SELinux works. The Magisk core parts (the scripts, boot image patches, new features, more supports) are actually done some time ago. What is causing all the delays is the Magisk Manager.
    To be completely honest, although I can code in Java without much issues, Magisk Manager is actually my first Android application, I had to reach out for assistance, and fortunately awesome developers like @DVDandroid and @digitalhigh contributed a lot, which makes the current Manager awesome.
    After the repo system and module management is mostly done, I was about to do some adjustments and release, but what we really done is decided to add another feature: auto-unroot with per-app settings. I decided to wait for it to be finished, and then do my adjustments. Due to reasons that'll be mentioned later, this feature will likely not be available for the next release (should come in future updates)

    Safety Net Disaster
    Those who are using Magisk for Safety Net bypass purposes must have known that Google recently updated the detection method of my Systemless Xposed. I still have no idea what Safety Net is detecting, so currently I cannot fix it on my side (also because I'm busy working on the next update). However, suhide developed by @Chainfire is able to hide Xposed and worked fine.
    However, only my Systemless Xposed v86.2, which is based on SuperSU's su.d, is supported using that method. v86.2 and v86.5 (latest, Magisk based) have nearly identical binaries, and the only difference is the path where the binaries are stored.
    I'm still not sure what's the real issue for it not being supported, I just hope it is not done intentionally.

    Conclusion
    Due to the fact that my Safety Net bypass is not 100% perfect now, I do not want to spend any more time waiting for auto-unroot to be polished. What I'm doing now is finishing up all the things I'd like to change in Magisk Manager (it has been a while since I last contributed to Manager, my fellow developers are doing all the heavy job), which might take a little more time, after that, packed with tons of information to be announced in Magisk Section, I'll release the long awaited update.

    Hope this lengthy post gives you the idea of the whole situation, and again thanks for all your support!!
    121
    Ah, some Chainfire bashing, I hope it is not too late for me to exercise additional villainy.

    First, let me make clear I have nothing against @topjohnwu, nor against Magisk. Magisk is an interesting project and it certainly displays @topjohnwu ingenuity and persistence. I don't doubt we will see more interesting things from his hands.

    -------------------------

    What has happened here is not all that dark and complicated, from either end. I returned from holidays, and someone pointed me at Magisk. My first thought: interesting!

    Among other things, the thread lists some issues with SuperSU, which in combination with the phrase The developer also requests users to not bug Chainfire with compatibility requests for SuperSU with Magisk from the portal article, raised my left eyebrow by nigh half an inch. The popular systemless xposed mod is apparently now based on it, and apparently it now no longer works with SuperSU, and apparently I'm not supposed to fix that, nor any of the other found issues. I found that a bit weird. So yes, I have told @topjohnwu that I was a bit surprised he was posting about issues with SuperSU without notifying me about them (I can't fix or help fix issues I'm not aware of, after all).

    He's also spreading a modified version of the SuperSU package, which is not all that uncommon, nor necessarily a problem. I have not looked into what he modified, I only ran a few quick tests on one of my devices, and found some commonly used commands run as root to be broken. I have informed him of this as well.

    It appears the tool of choice for Magisk is phh's Superuser, because of some of the mentioned issues with SuperSU. That's fine by itself, but fixing issues in that superuser by incorporating SuperSU's binaries into it is a somewhat questionable practise. After all, SuperSU is a commercial closed-source package that helps pay for my dinner, and superuser is a direct competitor. I have informed him that I was surprised he did this without asking for permission. I have expressed similar surprise on him spreading a modified version of LiveBoot (which helps pay for a snack now and then).
    @topjohnwu has also stated that Magisk's scripts are largely influenced by mine (I have not checked). Scripts based on mine are used all over the place on XDA, some people have crafted amazing things based on them, I have never made an issue of this (otherwise I would have just made them binaries). But yes, I have also stated to him that I don't think it's very nice to base something on one program, and then using that to (almost exclusively) push something directly competing with that program.

    tl;dr Towards @topjohnwu, I have:
    - expressed surprise he has issues getting Magisk to work with SuperSU, and has chosen not to inform me about those
    - expressed surprise he is using SuperSU binaries in a competing superuser without permission
    - expressed surprise he is posting a modified LiveBoot without permission
    - informed him of issues with the modified SuperSU he has posted
    - let him know I thought it wasn't very nice to be applying my scripts to benefit seemingly exclusively that same competing superuser

    To be crystal clear:
    - I have not asked for an apology
    - I have not asked for Magisk to be abandoned, neither the root hiding nor systemless module parts, and certainly not systemless xposed
    - I have not made an issue of any of this anywhere, until this post
    - I have not even specifically asked for anything to be taken down (though obviously in my opinion the other superuser package mixed with SuperSU's binaries, as well as the LiveBoot package, should go)
    - I have not reported this thread to XDA moderators for copyright violations or otherwise

    While my conversation with @topjohnwu may not win any awards for being friendly (though it may win some for brevity), I think all things considered my response has been rather mild. To be perfectly honest, until the apology post, I thought this was over with already. I think the apology post was triggered because I haven't replied to his last PM for a while - I was in the zone, it happens.

    To emphasize again, I have nothing against @topjohnwu, Magisk, or systemless xposed, and it is certainly not my goal to see any of them go. If it can be made to work together with SuperSU, great.

    I get it though: you think of something, you want to see if you can make it work, you finally get it to work, you publish it, it takes off - enthusiasm gets the better of you. Maybe in the rush some mistakes are made. That doesn't mean you have to just drop it and run. None of my stuff would make it past 0.1 if I stopped at the first big mistake :)

    Aside from said being in the zone coding, I usually regret actually responding to these sort of things the day after, which has made me hesitant to reply. Surprise me.
    76
    Thread temporarily closed so everyone sees this.

    The flood of "SafetyNet isn't working for me either!" posts are not helpful, at all. Please refrain from posting further, it will be looked into. Please do not forget that not passing SafetyNet is 100% NORMAL AND INTENDED when you have an unlocked booloader or running custom firmware. These are workarounds and they will be worked around in turn.

    The Flash
    Forum Moderator

    EDIT: Thread is reopened... I will be cleaning any SafetyNet posts for a while to keep the thread clean for real issues.
    75
    Hello everyone!

    I am aware that Google has updated Safety Net that makes Magisk itself a no go for Android Pay. In fact, I witnessed the change live while I am developing the new magiskhide, which should hide all Magisk modules and Magisk installed root.

    Google is serious about Safety Net now, clearly hunting down all possibility to run Xposed with Safety Net passed. I spend quite some time examining the new security measures last midnight, and fortunately it seems that it is possible to run Magisk and root along with Safety Net if no Xposed is running. I'm glad I removed the old root toggle at the right time lol, that is no longer feasible with the latest detection.

    So stay tuned for the next update, it will come with bug fixes, along with the new magiskhide to bypass that Safety Net.

    Google, how will a few systemless mods do any harm :p:p