Magisk General Support / Discussion

Search This thread

pndwal

Senior Member
Same issue that I've been having with OOS 11 [OnePlus 8] which I suspect could be ROM related or an issue with Zygisk.

Only time will tell as Zygisk moves further in development.
Nb. Issue in my post above was closed by user on assumption it wasn't Magisk's fault...

I'd say it would be worth / helpful to open a similar issue again as it seems it is still affecting various devices... And it appears likely to me that it is a Magisk issue in fact.

Nb. Magisk issues are often assigned / fixed by LSPosed Devs (girls club? 😛) whether in Magisk or LSP. PW
 
Last edited:

ipdev

Recognized Contributor
Feb 14, 2016
1,749
1
2,963
Google Nexus 10
Nexus 7 (2013)
Samsung Note9
Android 10, official Samsung ROM
Magisk Canary 23019

Safetynet v2.2.1 (Zygisk)​

in magisk module it says Zygisk isn't active.
But in magisk setting Zygisk beta is toggled.
so i've made a mistake ?
is it a bug ?
I ran into that issue once.
I do not remember the device or Magisk version.
(Might have been my OnePlus 6T or Poco F2 Pro. :unsure:)

After updating Magisk, Zygisk would not enable (after reboot) even though it was turned on in settings.
Magisk patched boot image found, patching boot image.​

I wiped Magisk but, that did not solve the problem.
Wiped Data and Cache of the Magisk app and uninstalled it.
Deleted the magisk.db file.
Reinstalled the Magisk app and rebooted.​

I ended up patching the stock boot image clean with the new version of Magisk.
Stock boot image found, patching boot image.​

I am not sure if deleting the magisk.db file did anything to help. :unsure:
Some odd setting that the new version of Magisk did not like?

Not sure if it will help but, I would suggest patching you stock (current rom) boot image and try again.

Good luck. (y)

Cheers. :cowboy:
 

zputnyq

Senior Member
Apr 19, 2013
617
277
Hi all,
I'm on TJW's canary 23019.
Does anyone know/could explain what is/are the difference(s) with enforce denylist activated and not activated ?
 

pndwal

Senior Member
Hi all,
I'm on TJW's canary 23019.
Does anyone know/could explain what is/are the difference(s) with enforce denylist activated and not activated ?
denylist (which preserves some of MagiskHide infrastructure) is active, or not active...

Nb. For Zy-Shamiko hiding module solution to work, this needs to be deactivated for Shamiko to do the hiding itself; Shamiko just uses the same list for convenience / simplicity... PW
 

pndwal

Senior Member
Forwarding this:

John Wu, 49m

🚨🚨 Last canary before release 🚨🚨

Calling for translators around the globe to submit translations before the imminent release 😇

Also, Zygisk API v2 is finalized and published. There are some new interesting and handy APIs added, go check it out!

https://github.com/topjohnwu/zygisk-module-sample

From www.twitter.com/topjohnwu/status/1485962760185794569

😜 PW
Updated translations just gone in; Italian, Japanese, see PR for French too...

French too hard (French trop dur)?

["The trouble with the French is that they have no word for entrepreneur”.
- George W. Bush

Edit: this may have been mis-attributed to Bush...]

May be stalled on 'missing strings' PR for Catalan, Spanish, Romanian also. 😉

😛 PW
 
Last edited:

zgfg

Senior Member
Oct 10, 2016
7,193
4,647
Hi all,
I'm on TJW's canary 23019.
Does anyone know/could explain what is/are the difference(s) with enforce denylist activated and not activated ?
As per Changelog and endless discussion in the thread, DenyList essentially replaces the old MagiskHide. However you have to open Configure DenyList and configure for Google Play Services yourself

1. Enable Zygisk and reboot
2. DenyList and reboot
 
  • Like
Reactions: zputnyq

meric57

Senior Member
Oct 2, 2017
102
18
Hettange Grand
Hello, I tried to make JW with adb I think it must be good. See screenshots put the 2 modules just to know for shamiko you have to do as explained in this topic with explorer root demoted version 72 to 71.
I can flash with odin TRWP 3.6.0_9-0-u3 or I have to modify it with magisk before flashing.
 

Attachments

  • Screenshot_20220126-080325.jpg
    Screenshot_20220126-080325.jpg
    378.4 KB · Views: 70
  • Screenshot_20220126-080345.jpg
    Screenshot_20220126-080345.jpg
    231 KB · Views: 65

zgfg

Senior Member
Oct 10, 2016
7,193
4,647
is it really necessary to add google play services in the denylist? i did not and google services work just fine including google pay and safetynet.

zygisk+shamiko
Enable Enforce DenyList and check In Confugure DenyList if gms and gms.unstable processes are checked in. Disable again Enforce DenyList

Maybe enabled from previously, maybe new Shamiko does (or USNF 2.2.1 takes care)
 

meric57

Senior Member
Oct 2, 2017
102
18
Hettange Grand
Hello dohanin, you are talking about play store certified me it is certified with shimako and safetynet fix 2.1.1.
Just emptied cache and given in application in S10 device parameter, then open play store and these certified.
 

kramer04

Senior Member
Jan 15, 2011
602
232
France
I ran into that issue once.
I do not remember the device or Magisk version.
(Might have been my OnePlus 6T or Poco F2 Pro. :unsure:)

After updating Magisk, Zygisk would not enable (after reboot) even though it was turned on in settings.
Magisk patched boot image found, patching boot image.​

I wiped Magisk but, that did not solve the problem.
Wiped Data and Cache of the Magisk app and uninstalled it.​
Deleted the magisk.db file.​
Reinstalled the Magisk app and rebooted.​

I ended up patching the stock boot image clean with the new version of Magisk.
Stock boot image found, patching boot image.​

I am not sure if deleting the magisk.db file did anything to help. :unsure:
Some odd setting that the new version of Magisk did not like?

Not sure if it will help but, I would suggest patching you stock (current rom) boot image and try again.

Good luck. (y)

Cheers. :cowboy:
After many tries and clean all, same issue.
wait until a new update of magisk
 
  • Like
Reactions: ipdev

shadowstep

Forum Moderator
Staff member
Jun 6, 2014
6,002
13,914
31
Ambala
OnePlus 9R

v24.0​

  • [General] MagiskHide is removed from Magisk
  • [General] Support 64-bit only systems
  • [General] Support Android 12
  • [General] Update BusyBox to 1.34.1
  • [Zygisk] Introduce new feature: Zygisk
  • [Zygisk] Introduce DenyList feature to revert Magisk features in user selected processes
  • [MagiskBoot] Support patching 32-bit kernel zImages
  • [MagiskBoot] Support boot image header v4
  • [MagiskBoot] Support patching out skip_initramfs from dtb bootargs
  • [MagiskBoot] Add new env variable PATCHVBMETAFLAG to configure whether vbmeta flags should be patched
  • [MagiskInit] Support loading fstab from /system/etc (required for Pixel 6)
  • [MagiskInit] Support /proc/bootconfig for loading boot configurations
  • [MagiskInit] Better support for some Meizu devices
  • [MagiskInit] Better support for some OnePlus/Oppo/Realme devices
  • [MagiskInit] Support init.real on some Sony devices
  • [MagiskInit] Skip loading Magisk when detecting DSU
  • [MagiskPolicy] Load *_compat_cil_file from system_ext
  • [MagiskSU] Use isolated devpts if the kernel supports it
  • [MagiskSU] Fix root shell if isolated mount namespace is set
  • [resetprop] Deleted properties are now wiped from memory instead of just unlinking
  • [App] Build a single APK for all ABIs
  • [App] Switch to use standard bottom navigation bar
  • [App] Downloading modules from the centralized Magisk-Modules-Repo is removed
  • [App] Support user configuration of boot image vbmeta patching
  • [App] Restore the ability to install Magisk on the other slot on some A/B devices
  • [App] Allow modules to specify an update URL for in-app update + install
https://topjohnwu.github.io/Magisk/changes.html#v240

👀 PW
It's out now: https://github.com/topjohnwu/Magisk/releases/tag/v24.0
 

heinhuiz

Senior Member
Nov 26, 2011
1,115
868
Xiaomi Mi A1
Redmi K20 / Xiaomi Mi 9T
"The trouble with the French is that they have no word for entrepreneur”.
- George W. Bush
</TOPIC>
<TOPIC>
 
  • Like
Reactions: pndwal

Top Liked Posts

  • 4
    NP but did you resolve?
    Yes, I removed the modules in /data/adb and it worked, thanks to you!
    2
    @ipdev Yes, I am using Mi A1 with latest LOS. Thanks for the info about LOS OTA. The OTA method in the magisk guide has always worked for me however. Uninstall restore images, then flash to inactive slot after installing ota, however this was on older magisk versions. I don't know why it's like this now. Maybe I fat fingered the complete uninstall button instead of restore images. And to be honest, these options shouldn't be on top of each other, but left and right.
    2
    View attachment 5623771

    i'm just wondering, does my device doesn't support the current version of magisk? because i can't open the menu to download the magic modules at all. i had to download it manually from external site and i read the solution online and it said i should downgrade it to version 21.4

    i just wondering if there's a way to access the menu without downgrading it
    As has been mentioned many, many times here, the module repository was closed long ago. Use this instead:

    https://github.com/Fox2Code/FoxMagiskModuleManager
    2
    When did Magisk Manager app stop displaying some mention of "A/B"-ness? I do not see any mention in @lindsaysxda's screenshot.
    Yeah, I noticed this too, but some time back; doubt you'll see it for any device now... Maybe changed in this?:
    https://github.com/topjohnwu/Magisk/commit/ca9f9fee9a9197b6a56f4bf5ed3d4ae26a7a6dd7

    ... did we lose encryption (cryptotype) info even earlier?

    Seems John likes to simplify Magisk (for good reasons). My guess is that SAR, A/B, Crypto etc. states may now be considered confusing and largely irrelevant for Magisk purposes, and have been dispensed with in favour of Ramdisk and Zygisk state info... PW
    2
    I need help, I just upgraded my Oneplus 6 from lineage 18 to 19 (Android 12) and when I want to flash magisk, I always end up in a bootloop with the both of the methods, the one with apk renamed as zip and the one with the recovery flashed as boot (I followed this tutorial btw)
    Probably you have Magisk modules, not compatible with A12, that you didn't disable/uninstall before upgrading. They are installed at /dara/adb, hence they were not removed if you didn't ask for Factory reset

    This problem has been discussed here several times, you can check in the previous posts
    Actually, on Magisk GitHub, Wiki, there is a chapter on how to resolve
  • 7
    Latest Shamiko:

    Shamiko v0.5.0

    0.5.0​

    • Better hiding Zygisk
    "... Momo enjoys helping Shamiko become stronger in all aspects despite Shamiko's goal of defeating her..."

    👍 PW
    6

    Latest Official TJW debug Canary Magisk:​

    Magisk (cc79a96f) (24307)​

    • [App] Update libsu with 100% new I/O layer
    • [MagiskInit] Mock enforce file with regular file to prevent possible race condition
    • Switch normal NDK with ONDK, preparing the toolchain to introduce Rust

    Diffs to v24.3​

    • [MagiskInit] Update 2SI implementation, significantly increase device compatibility (e.g. Sony Xperia devices)
    • [MagiskInit] Introduce new sepolicy injection mechanism
    • [MagiskInit] Support Oculus Go
    • [App] [MagiskSU] Properly support apps using shared UID
    • [MagiskSU] Fix a possible crash in magiskd
    • [Zygisk] Fix function hooking on devices running Android 12 with old kernels
    • [BusyBox] Add workaround for devices running old kernels
    https://github.com/topjohnwu/magisk-files/blob/a66dfce1bf88a70e86bf86c5427b1c58e71a4fc2/notes.md

    👍 PW
    6
    Latest Official TJW debug Canary Magisk:

    Magisk (985249c3) (24309)​

    Pixel 6 Android 13 Beta 2 support is here!

    • [App] Support requesting root from non app process
    • [App] Fix deadlocking a background thread on non-root devices
    • [MagiskInit] Support GKIs with no ramdisk (Pixel 6 Android 13)

    Diffs to v24.3​

    • [MagiskInit] Update 2SI implementation, significantly increase device compatibility (e.g. Sony Xperia devices)
    • [MagiskInit] Introduce new sepolicy injection mechanism
    • [MagiskInit] Support Oculus Go
    • [MagiskInit] Support GKIs with no ramdisk (Pixel 6 Android 13)
    • [App] [MagiskSU] Properly support apps using shared UID
    • [MagiskSU] Fix a possible crash in magiskd
    • [Zygisk] Fix function hooking on devices running Android 12 with old kernels
    • [BusyBox] Add workaround for devices running old kernels
    https://github.com/topjohnwu/magisk-files/blob/56da1fe5430b2c04701ce73d1658ba698ee92283/notes.md

    👍 PW
    6
    Looks like major libsu release is now imminent; most fixes are now merged.

    Should see major stability improvements in Magisk and root app implementation... Should see new commits for Magisk proper again soon too!

    John has made some major libsu changes (see libsu GitHub).

    Here are extra comments on vvb2060 fixes from her TG (Chinese translated....


    👀 PW
    libsu 5.0.0 is out!

    libsu/CHANGELOG.md

    5.0.0​

    Check the updated Javadoc and the example app for details on how to use the remote file system in the new nio module.

    New Features​

    • Introduce a new module: nio
      • Includes file system implementations for local and remote processes
      • New FileSystemManager class to access either local or remote file system implementations
      • New ExtendedFile class to extend functionality of the old Java File API
    • [core] New API Shell.isAppGrantedRoot() returns a nullable Boolean:
      • true if a root shell has been created
      • false if it has been determined that root access is impossible to get
      • null if the library has not, or could not determine the current root grant state. Future invocations of this method may return a non-null value if the library gained more information during shell creation.
    • [core] New API Shell.Builder.setContext(context): allow the developer to explicitly provide a Context object
    • [io] SuFile is updated to also extend ExtendedFile, which adds some new features and APIs

    Deprecation​

    • Version 5.0.0 will be the final release of the busybox module. If you cannot remove the usage of the module, you can pin the busybox module to version 5.0.0, as it is updated to be fully self contained, making it guaranteed to work with future libsu versions.
    • Usage of SuFile/SuFileOutputStream/SuFileInputStream/SuRandomAccessFile is discouraged. Although these APIs will remain for the foreseeable future, please migrate to use RootService + the nio module for all root I/O operations.
    • Shell.rootAccess() is deprecated. Please switch to use the more accurate Shell.isAppGrantedRoot() API

    John Wu, 2h

    Major libsu update 5.0.0!

    Introduces a new module "nio" to perform I/O operations through root services, moving away from the error prone, inefficient shell command backed I/O the library used to provide.

    It's already using splice under-the-hood. There is already some Linux magic!

    New readme etc. Read how you can Attach Debugger to Android Process in Root Services and more!
    https://github.com/topjohnwu/libsu

    👏👍🥳

    ... Back to regular Magisk programming... PW
    5

    Latest Official TJW debug Canary Magisk:​

    Magisk (42e5f515) (24308)​

    • Several minor bug fixes

    Diffs to v24.3​

    • [MagiskInit] Update 2SI implementation, significantly increase device compatibility (e.g. Sony Xperia devices)
    • [MagiskInit] Introduce new sepolicy injection mechanism
    • [MagiskInit] Support Oculus Go
    • [App] [MagiskSU] Properly support apps using shared UID
    • [MagiskSU] Fix a possible crash in magiskd
    • [Zygisk] Fix function hooking on devices running Android 12 with old kernels
    • [BusyBox] Add workaround for devices running old kernels
    https://github.com/topjohnwu/magisk-files/blob/ba1cf1081e1fe6fce7fda626dfdb0a0faab27d4e/notes.md

    👍 PW
  • 1077
    This is the place for general support and discussion regarding "Public Releases", which includes both stable and beta releases.
    All information, including troubleshoot guides and notes, are in the Announcement Thread
    156
    Hello, I haven't given much support on XDA lately. It can be resulted from
    • University started and I have limited free time. In fact, I mostly develop during midnight
    • I live in Taiwan, which has large time zone differences between my European/American contributors/testers, which usually forces me to stay up late at night to discuss/test stuffs.
    • The new version is about to come, I don't want to spend effort on supporting old releases
    The planned update is delayed again and again, to some point I think I'll shed some light about what has been happening lately, also along with some announcements.

    New Forum!
    As you might have already discovered, Magisk got its own subforum on XDA! Many thanks to all the support you gave me, and much more information/features/support is about to come!
    **For developers supporting all the devices that are not using standard Android boot format, feel free to create threads in this section (actually, PLEASE do so) for your favorite devices after v7 is out. As I currently know, Asus devices require signing the boot image before flashing, and is model dependant; Sony devices seems to use ELF kernel that is unpatchable, or some has two ramdisks (inner + outer), both requires different workarounds; LG bootloader locked devices has to manually "BUMP" the boot image after flashing Magisk..... and there may be lots of other crazy boot image formats that haven't come up to my attention yet.
    It is impossible for me to support all these non-standard boot images, and I hope the community can collaborate to make Magisk running across all the devices. Overall, community collaboration is what XDA about :D

    The Pixel Phone
    Some of you might already know this news, that the next Pixel Phone right around the corner seems like it does not have ramdisk in boot image, which pretty much wrecked Magisk in all ways. However, it pretty much doomed root itself too. Kernel modifications is inevitable IMO, so I'll try to migrate my scripts to C programs that could possibly be included into the kernel itself. Note that I'm not familiar with linux kernel, I'm not even sure if my idea and concept is correct or not. But once the device is available, I think developers will find a way to bypass all the difficulties, and I'll do my best to learn things ;)

    Current Progress
    In the past month, I've spent quite some time learning SELinux, so that I can avoid using SuperSU's sepolicy patches. Thanks to the helps and tips from @phhusson and @Chainfire, I finally have a much clearer understanding of how SELinux works. The Magisk core parts (the scripts, boot image patches, new features, more supports) are actually done some time ago. What is causing all the delays is the Magisk Manager.
    To be completely honest, although I can code in Java without much issues, Magisk Manager is actually my first Android application, I had to reach out for assistance, and fortunately awesome developers like @DVDandroid and @digitalhigh contributed a lot, which makes the current Manager awesome.
    After the repo system and module management is mostly done, I was about to do some adjustments and release, but what we really done is decided to add another feature: auto-unroot with per-app settings. I decided to wait for it to be finished, and then do my adjustments. Due to reasons that'll be mentioned later, this feature will likely not be available for the next release (should come in future updates)

    Safety Net Disaster
    Those who are using Magisk for Safety Net bypass purposes must have known that Google recently updated the detection method of my Systemless Xposed. I still have no idea what Safety Net is detecting, so currently I cannot fix it on my side (also because I'm busy working on the next update). However, suhide developed by @Chainfire is able to hide Xposed and worked fine.
    However, only my Systemless Xposed v86.2, which is based on SuperSU's su.d, is supported using that method. v86.2 and v86.5 (latest, Magisk based) have nearly identical binaries, and the only difference is the path where the binaries are stored.
    I'm still not sure what's the real issue for it not being supported, I just hope it is not done intentionally.

    Conclusion
    Due to the fact that my Safety Net bypass is not 100% perfect now, I do not want to spend any more time waiting for auto-unroot to be polished. What I'm doing now is finishing up all the things I'd like to change in Magisk Manager (it has been a while since I last contributed to Manager, my fellow developers are doing all the heavy job), which might take a little more time, after that, packed with tons of information to be announced in Magisk Section, I'll release the long awaited update.

    Hope this lengthy post gives you the idea of the whole situation, and again thanks for all your support!!
    121
    Ah, some Chainfire bashing, I hope it is not too late for me to exercise additional villainy.

    First, let me make clear I have nothing against @topjohnwu, nor against Magisk. Magisk is an interesting project and it certainly displays @topjohnwu ingenuity and persistence. I don't doubt we will see more interesting things from his hands.

    -------------------------

    What has happened here is not all that dark and complicated, from either end. I returned from holidays, and someone pointed me at Magisk. My first thought: interesting!

    Among other things, the thread lists some issues with SuperSU, which in combination with the phrase The developer also requests users to not bug Chainfire with compatibility requests for SuperSU with Magisk from the portal article, raised my left eyebrow by nigh half an inch. The popular systemless xposed mod is apparently now based on it, and apparently it now no longer works with SuperSU, and apparently I'm not supposed to fix that, nor any of the other found issues. I found that a bit weird. So yes, I have told @topjohnwu that I was a bit surprised he was posting about issues with SuperSU without notifying me about them (I can't fix or help fix issues I'm not aware of, after all).

    He's also spreading a modified version of the SuperSU package, which is not all that uncommon, nor necessarily a problem. I have not looked into what he modified, I only ran a few quick tests on one of my devices, and found some commonly used commands run as root to be broken. I have informed him of this as well.

    It appears the tool of choice for Magisk is phh's Superuser, because of some of the mentioned issues with SuperSU. That's fine by itself, but fixing issues in that superuser by incorporating SuperSU's binaries into it is a somewhat questionable practise. After all, SuperSU is a commercial closed-source package that helps pay for my dinner, and superuser is a direct competitor. I have informed him that I was surprised he did this without asking for permission. I have expressed similar surprise on him spreading a modified version of LiveBoot (which helps pay for a snack now and then).
    @topjohnwu has also stated that Magisk's scripts are largely influenced by mine (I have not checked). Scripts based on mine are used all over the place on XDA, some people have crafted amazing things based on them, I have never made an issue of this (otherwise I would have just made them binaries). But yes, I have also stated to him that I don't think it's very nice to base something on one program, and then using that to (almost exclusively) push something directly competing with that program.

    tl;dr Towards @topjohnwu, I have:
    - expressed surprise he has issues getting Magisk to work with SuperSU, and has chosen not to inform me about those
    - expressed surprise he is using SuperSU binaries in a competing superuser without permission
    - expressed surprise he is posting a modified LiveBoot without permission
    - informed him of issues with the modified SuperSU he has posted
    - let him know I thought it wasn't very nice to be applying my scripts to benefit seemingly exclusively that same competing superuser

    To be crystal clear:
    - I have not asked for an apology
    - I have not asked for Magisk to be abandoned, neither the root hiding nor systemless module parts, and certainly not systemless xposed
    - I have not made an issue of any of this anywhere, until this post
    - I have not even specifically asked for anything to be taken down (though obviously in my opinion the other superuser package mixed with SuperSU's binaries, as well as the LiveBoot package, should go)
    - I have not reported this thread to XDA moderators for copyright violations or otherwise

    While my conversation with @topjohnwu may not win any awards for being friendly (though it may win some for brevity), I think all things considered my response has been rather mild. To be perfectly honest, until the apology post, I thought this was over with already. I think the apology post was triggered because I haven't replied to his last PM for a while - I was in the zone, it happens.

    To emphasize again, I have nothing against @topjohnwu, Magisk, or systemless xposed, and it is certainly not my goal to see any of them go. If it can be made to work together with SuperSU, great.

    I get it though: you think of something, you want to see if you can make it work, you finally get it to work, you publish it, it takes off - enthusiasm gets the better of you. Maybe in the rush some mistakes are made. That doesn't mean you have to just drop it and run. None of my stuff would make it past 0.1 if I stopped at the first big mistake :)

    Aside from said being in the zone coding, I usually regret actually responding to these sort of things the day after, which has made me hesitant to reply. Surprise me.
    76
    Thread temporarily closed so everyone sees this.

    The flood of "SafetyNet isn't working for me either!" posts are not helpful, at all. Please refrain from posting further, it will be looked into. Please do not forget that not passing SafetyNet is 100% NORMAL AND INTENDED when you have an unlocked booloader or running custom firmware. These are workarounds and they will be worked around in turn.

    The Flash
    Forum Moderator

    EDIT: Thread is reopened... I will be cleaning any SafetyNet posts for a while to keep the thread clean for real issues.
    75
    Hello everyone!

    I am aware that Google has updated Safety Net that makes Magisk itself a no go for Android Pay. In fact, I witnessed the change live while I am developing the new magiskhide, which should hide all Magisk modules and Magisk installed root.

    Google is serious about Safety Net now, clearly hunting down all possibility to run Xposed with Safety Net passed. I spend quite some time examining the new security measures last midnight, and fortunately it seems that it is possible to run Magisk and root along with Safety Net if no Xposed is running. I'm glad I removed the old root toggle at the right time lol, that is no longer feasible with the latest detection.

    So stay tuned for the next update, it will come with bug fixes, along with the new magiskhide to bypass that Safety Net.

    Google, how will a few systemless mods do any harm :p:p