Magisk General Support / Discussion

Search This thread

heinhuiz

Senior Member
Nov 26, 2011
1,102
839
Xiaomi Mi A1
Redmi K20 / Xiaomi Mi 9T
"The trouble with the French is that they have no word for entrepreneur”.
- George W. Bush
</TOPIC>
<TOPIC>
 
  • Like
Reactions: pndwal

zgfg

Senior Member
Oct 10, 2016
7,153
4,609
Show will begin, I tried to put some short help for probably the posts/questions soon to expect

===

Please carefully read Changelog

Study the Magisk documentation available from the official Magisk Github page - particularly about installing Magisk (if you are not familiar with patching the image in Magisk app and flashing the patched img from Fastboot- i.e, not the old school about Magisk zip through TWRP)

Everything bellow has already been discussed in this thread since Canary 2301x started to roll out - hence more details can be found in the older posts in this thread

a) No more MagiskHide. New technology instead (for the same - to help hiding root): Zygisk+DenyList

b) No more built in SafetyNet checker. Install from PlayStore e g: YASNAC

c) Modules window does no more connect to the (now frozen) old Modules repository.
You must download module zip files manually and "Install from local storage".
Or search for and install Fox Magisk Module Manager (Fox Mmm) app - it will connect to the new, alternative repository

---

0) Always before upgrading Magisk, go to your Magisk app/manager and if you previously did "Hide Magisk app/mngr", do "Restore Magisk app/mngr"

1) Make sure that both Magisk app and Magisk are installed and updated to the new version. Inspect version numbers on the main Magisk window/page

2) Make sure to uninstall all Riru modules (not compatible with Zygisk)

3) Settings, Enable Zygisk and reboot.
Then check on the main window does it show Zygisk Yes

4) Settings, enable Enforce DenyList.
Configure DenyList, enable filters to Show OS and System apps
Find Google Play Services and check-in only the two processes ending with gms and gms.unstable.
You will have to check in all your banking apps and so as you used with MagiskHide.
Always reboot upon reconfiguring DenyList

5) If SafetyNet does not pass, install USNF 2.2.1 and test again.
Always reboot upon installing a module, also if/when you enable Systemless Hosts

---

Intentionally, I didn't want to complicate with Shamiko for the new Magisk 24 users 👍

PS: See the new thread:
 
Last edited:

meric57

Senior Member
Oct 2, 2017
90
16
Hettange Grand
hello ,updated to 24 more rooting.

Screenshot_20220126-121642.jpg
 

kramer04

Senior Member
Jan 15, 2011
597
230
France
Always same issue with magisk 24 canary
Zygisk : no
 

Attachments

  • Screenshot_20220126-123321.jpg
    Screenshot_20220126-123321.jpg
    432.5 KB · Views: 110
  • Screenshot_20220126-123334.jpg
    Screenshot_20220126-123334.jpg
    381.8 KB · Views: 110

pndwal

Senior Member
Guess I can advertise @ipdev's new WIP

[Discussion] Magisk - The Age of Zygisk​

thread now that public 24.0 release is out:

First 5 posts have a good summation of new Magisk changes / direction / tips. 👍 PW
 

pndwal

Senior Member
No, I did not. As said, zygisk + shamiko + usnf works fine for me. I never had to add Google Play Services in Denylist since using zygisk. I'm on Android 12 with stock rom.
Sorry, I didn't correct that post quickly enough; wrong user!...

I meant to ping @kramer04 here:
https://forum.xda-developers.com/t/magisk-general-support-discussion.3432382/post-86321651
not you. 🤪

But I can add (for you) that before Zygisk based USNF it was necessary to manually add Google Play Services SafetyNet process (and main process w/ Android 11+) to denylist in Canary w/ Zygisk... (Pre Zygisk this happened automatically on toggling on MagiskHide.)

For most users this is no longer needed as Zy-USNF uses its own hiding functions for these processes to target Play Services specifically as explained in USNF GitHub (see changelogs).

It's worth noting that USNF will often fix hiding issues even for devices w/o hardware for HKA (Hardware Key Attestation), ie w/ release versions of Android 6 and earlier, as this solution also adds back mechanism to change sensitive props where needed (formerly handled by MagiskHide). This function is often needed for legacy devices to pass SafetyNet. 🙃 PW
 
Last edited:

dohanin

Senior Member
Sorry, I didn't correct that post quickly enough; wrong user!...

I meant to ping @kramer04 here:
https://forum.xda-developers.com/t/magisk-general-support-discussion.3432382/post-86321651
not you. 🤪

But I can add (for you) that before Zygisk based USNF it was necessary to manually add Google Play Services SafetyNet process (and main process w/ Android 11+) to denylist in Canary w/ Zygisk... (Pre Zygisk this happened automatically on toggling on MagiskHide.)

For most users this is no longer needed as Zy-USNF uses its own hiding functions for these processes to target Play Services specifically as explained in USNF GitHub (see changelogs).

It's worth noting that USNF will often fix hiding issues even for devices w/o hardware for HKA (Hardware Key Attestation), ie w/ release versions of Android 6 and earlier, as this solution also adds back mechanism to change sensitive props where needed (formerly handled by MagiskHide). This function is often needed for legacy devices to pass SafetyNet. 🙃 PW
Thanks a lot for the explanation.
 
  • Like
Reactions: pndwal

pndwal

Senior Member
  • Haha
Reactions: heinhuiz

pndwal

Senior Member
Latest Unofficial vvb2060 Alpha Magisk
(Chinese Translated):

# alpha changelog

## Magisk (54ee63a4-alpha)
- [App] Support SharedUserId
- [App] Delete backup file after restoring boot image
- [App] Built-in current version update log
- [General] no longer automatically unlock device blocks
- [General] Use MagiskHide to hide when Zygisk is closed
- [App] Compatible with Android 12L
- [MagiskInit] Refactor the processing method of two-step startup
- [General] Update to NDK 23
- [App] Added crash statistics

### how to install?
Install and uninstall Magisk through the Magisk application. Generally, it should be done directly in the application. In special cases such as the first installation, you should use the fastboot/odin tool to flash it after patching the image.
By customizing Recovery is not a supported way.

# Upstream changelog

It has been a while since the last public release, long time no see! A personal update for those unaware: I am now working at Google on the Android Platform Security team. Without further ado, let's jump right into it!

### MagiskHide Removal

I have lost interest in fighting this battle for quite a while; plus, the existing MagiskHide implementation is flawed in so many ways. Decoupling Magisk from root hiding is, in my opinion, beneficial to the community. Ever since my announcement on Twitter months ago , highly effective "root hiding" modules (much **MUCH** better than MagiskHide) has been flourishing, which again shows that people are way more capable than I am on this subject. So why not give those determined their time to shine, and let me focus on improving Magisk instead of drowning in the everlasting cat-and-mouse game 😉.

### Sunset Magisk-Modules-Repo

Due to lack of time and maintenance, the centralized Magisk-Modules-Repo was frozen, and the functionality to download modules from the repo is removed in v24.0. As a supplement, module developers can now specify an `updateJson` URL in their modules. The Magisk app will use that to check, download, and install module updates.

### Introducing Zygisk

Zygisk is **Magisk in Zygote**, the next big thing for Magisk! When this feature is enabled, a part of Magisk will run in the `Zygote` daemon process, allowing module developers to run code directly in every Android apps' processes . If you've heard of [Riru](https://github.com/RikkaApps/Riru), then Zygisk is inspired by that project and is functionally similar, though the implementation is quite different internally. I cannot wait to see what module developers can achieve using Zygisk!

### Documentation

For developers, details about `updateJson` and building Zygisk modules can all be found in the updated [documentation](https://topjohnwu.github.io/Magisk/guides.html#magisk-modules).

### v24.0 Full Changelog

- [General] MagiskHide is removed from Magisk
- [General] Support 64-bit only systems
- [General] Support Android 12
- [General] Update BusyBox to 1.34.1
- [Zygisk] Introduce new feature: Zygisk
- [Zygisk] Introduce DenyList feature to revert Magisk features in user selected processes
- [MagiskBoot] Support patching 32-bit kernel zImages
- [MagiskBoot] Support boot image header v4
- [MagiskBoot] Support patching out `skip_initramfs` from dtb bootargs
- [MagiskBoot] Add new env variable `PATCHVBMETAFLAG` to configure whether vbmeta flags should be patched
- [MagiskInit] Support loading fstab from `/system/etc` (required for Pixel 6)
- [MagiskInit] Support `/proc/bootconfig` for loading boot configurations
- [MagiskInit] Better support for some Meizu devices
- [MagiskInit] Better support for some OnePlus/Oppo/Realme devices
- [MagiskInit] Support `init.real` on some Sony devices
- [MagiskInit] Skip loading Magisk when detecting DSU
- [MagiskPolicy] Load `*_compat_cil_file` from system_ext
- [MagiskSU] Use isolated devpts if the kernel supports it
- [MagiskSU] Fix root shell if isolated mount namespace is set
- [resetprop] Deleted properties are now wiped from memory instead of just unlinking
- [App] Build a single APK for all ABIs
- [App] Switch to use standard bottom navigation bar
- [App] Downloading modules from the centralized Magisk-Modules-Repo is removed
- [App] Support user configuration of boot image vbmeta patching
- [App] Restore the ability to install Magisk on the other slot on some A/B devices
- [App] Allow modules to specify an update URL for in-app update + install

👍 PW
 

pndwal

Senior Member
Many Chinese Magisk users (incl. TJW collaborators) were expecting new public Beta 24.0 as traditional Chinese New Year present... Looks like John surprised them by releasing this a few days before...

I wonder if public Stable 24.0 / 24.x will arrive by Feb. 1? ...
John Wu, 3h

Published Magisk v24.0 🎉🎉

Available on the public beta channel. Will wait for a few days, and if all is good, I'll release it to the stable channel.

Oh and BTW, I have revised the installation guide with additional info and updated instructions.
www.twitter.com/topjohnwu/status/1486284286927859712

😛 PW
 
Last edited:

vandyman

Senior Member
Jul 30, 2012
820
424
S.Jersey
Google Pixel 5
Google Pixel 6
Now that there is a new Magisk V24 stable thread.
Will it be it be ruined like this thread?

I really hope not. Who can post the most in the new thread does not count like it does here in this thread.
Sorry for the off topic rant and being an a*s.
 

pndwal

Senior Member
Now that there is a new Magisk V24 stable thread.
Will it be it be ruined like this thread?

I really hope not. Who can post the most in the new thread does not count like it does here in this thread.
Sorry for the off topic rant and being an a*s.
Nb. It's a 24.0+ thread, but we haven't yet got stable! 😉

Preventing a new thread from expanding fast has been my concern too, and @ipdev and I have discussed this over the last few weeks (he may have done so with others also).

I can't / couldn't see an easy solution to this for a discussion / help thread... We did discuss a wiki style site / thread to supplement @Didgeridoohan's excellent database of solutions to cover use of new hiding modules and other more loosely magisk related topics / issues... This is what we've got - Ipdev stepped up to maintain it and I salute him for his efforts!

Nb. It will likely help a lot if users read the first 5 posts before asking questions though... The intention is to keep these updated to cover the most commonly needed information...

I don't think that this thread ruined however. It may be burgeoning, but it is / has always been a very valuable resource as a General Discussion thread, especially for those knowing what to search for / how to search... And as long as some who keep up with recent development are happy to help others, it seems to work well for all AFAICS... 😜 PW
 
Last edited:

heinhuiz

Senior Member
Nov 26, 2011
1,102
839
Xiaomi Mi A1
Redmi K20 / Xiaomi Mi 9T
Now that there is a new Magisk V24 stable thread.
Will it be it be ruined like this thread?

I really hope not. Who can post the most in the new thread does not count like it does here in this thread.
Sorry for the off topic rant and being an a*s.
No, you're right. What might help is when some of the most helpful contributers like @pndwal and @zgfg and others could have rights to simply delete posts.

I mean, what does a post like:
Any magisk hider, please?
add in the middle of a discussion about hiding Magisk? 🙄
Or would it be better to just report such posts, or (dis)like them with a sad 🙁 or angry 😡 face?
 
  • Like
  • Love
Reactions: vandyman and pndwal

Top Liked Posts

  • 3
    Latest Official TJW debug Canary Magisk:

    Magisk (756d8356) (24312)​

    • Introduce new debug channel. Canary builds are now built in release mode, and debug builds are now required for bug reports.
    I'm guessing that this paves the way for John to integrate this rather controversial debugging tool c/o vvb2060 -
    Add appcenter #5291 otherwise known as Microsoft AppCentre aka telemetry (ie debug-Magisk phone home)*...

    Rather nice solution allowing users wanting to be on the leading (cutting) edge of Magisk to continue updating Canary without app 'phoning home' with magisk logging data, as well as builds being more compact (lacking verbose (debug) logging Canary had previously, while implementing a great tool (timesaver / data collection for speedy fixes) in separate Debug builds...

    This will mean users must migrate to latest Debug build before submitting bug reports (making GitHub issues), and other users experiencing the same issue will be able to help without even commenting on GitHub simply by installing.Debug build themselves to allow automatic data collection...

    IMG_20220516_004432.jpg

    IMG_20220516_004552.jpg


    * Watch this space! 👀

    What's not to like? 😛 ... 😬 PW
    1
    Latest Official TJW debug Canary Magisk:

    Magisk (756d8356) (24312)​

    • Introduce new debug channel. Canary builds are now built in release mode, and debug builds are now required for bug reports.

    Diffs to v24.3​

    • [MagiskInit] Update 2SI implementation, significantly increase device compatibility (e.g. Sony Xperia devices)
    • [MagiskInit] Introduce new sepolicy injection mechanism
    • [MagiskInit] Support Oculus Go
    • [MagiskInit] Support GKIs with no ramdisk (Pixel 6 Android 13)
    • [MagiskBoot] Fix vbmeta extraction implementation
    • [App] [MagiskSU] Properly support apps using shared UID
    • [MagiskSU] Fix a possible crash in magiskd
    • [Zygisk] Fix function hooking on devices running Android 12 with old kernels
    • [BusyBox] Add workaround for devices running old kernels
    https://github.com/topjohnwu/magisk-files/blob/eb166b87765ad8755df859e1e6d8749a28cc06cb/notes.md

    This includes minor fix:
    Show canary channel option on canary builds

    👍 PW
    1
    Sounds like the domain of Rikka's 'Srorage Isolation' (formerly StorageRedirect)
    https://sr.rikka.app/
    (See guide in menu), or 'sandboxing' apps like Island, Shelter, Insular...

    Nb. I haven't used any of these solutions myself. Those with experience may be of more help.

    Seems mileage for hiding Zygisk w/ Shamiko varies with device...

    👀 PW
    Yeah I tried Storage Isolation it doesn't even want to let me enable it for Momo since it doesn't use the storage permission (yet still has file access? that part confuses me) and even if I enable it for Momo it still detects :/. Plus it's a free trial I'd have to pay 30$ for nothing (no thanks on subscriptions, lifetime license please), pass.
  • 7
    Latest Shamiko:

    Shamiko v0.5.0

    0.5.0​

    • Better hiding Zygisk
    "... Momo enjoys helping Shamiko become stronger in all aspects despite Shamiko's goal of defeating her..."

    👍 PW
    6

    Latest Official TJW debug Canary Magisk:​

    Magisk (cc79a96f) (24307)​

    • [App] Update libsu with 100% new I/O layer
    • [MagiskInit] Mock enforce file with regular file to prevent possible race condition
    • Switch normal NDK with ONDK, preparing the toolchain to introduce Rust

    Diffs to v24.3​

    • [MagiskInit] Update 2SI implementation, significantly increase device compatibility (e.g. Sony Xperia devices)
    • [MagiskInit] Introduce new sepolicy injection mechanism
    • [MagiskInit] Support Oculus Go
    • [App] [MagiskSU] Properly support apps using shared UID
    • [MagiskSU] Fix a possible crash in magiskd
    • [Zygisk] Fix function hooking on devices running Android 12 with old kernels
    • [BusyBox] Add workaround for devices running old kernels
    https://github.com/topjohnwu/magisk-files/blob/a66dfce1bf88a70e86bf86c5427b1c58e71a4fc2/notes.md

    👍 PW
    6
    Looks like major libsu release is now imminent; most fixes are now merged.

    Should see major stability improvements in Magisk and root app implementation... Should see new commits for Magisk proper again soon too!

    John has made some major libsu changes (see libsu GitHub).

    Here are extra comments on vvb2060 fixes from her TG (Chinese translated....


    👀 PW
    libsu 5.0.0 is out!

    libsu/CHANGELOG.md

    5.0.0​

    Check the updated Javadoc and the example app for details on how to use the remote file system in the new nio module.

    New Features​

    • Introduce a new module: nio
      • Includes file system implementations for local and remote processes
      • New FileSystemManager class to access either local or remote file system implementations
      • New ExtendedFile class to extend functionality of the old Java File API
    • [core] New API Shell.isAppGrantedRoot() returns a nullable Boolean:
      • true if a root shell has been created
      • false if it has been determined that root access is impossible to get
      • null if the library has not, or could not determine the current root grant state. Future invocations of this method may return a non-null value if the library gained more information during shell creation.
    • [core] New API Shell.Builder.setContext(context): allow the developer to explicitly provide a Context object
    • [io] SuFile is updated to also extend ExtendedFile, which adds some new features and APIs

    Deprecation​

    • Version 5.0.0 will be the final release of the busybox module. If you cannot remove the usage of the module, you can pin the busybox module to version 5.0.0, as it is updated to be fully self contained, making it guaranteed to work with future libsu versions.
    • Usage of SuFile/SuFileOutputStream/SuFileInputStream/SuRandomAccessFile is discouraged. Although these APIs will remain for the foreseeable future, please migrate to use RootService + the nio module for all root I/O operations.
    • Shell.rootAccess() is deprecated. Please switch to use the more accurate Shell.isAppGrantedRoot() API

    John Wu, 2h

    Major libsu update 5.0.0!

    Introduces a new module "nio" to perform I/O operations through root services, moving away from the error prone, inefficient shell command backed I/O the library used to provide.

    It's already using splice under-the-hood. There is already some Linux magic!

    New readme etc. Read how you can Attach Debugger to Android Process in Root Services and more!
    https://github.com/topjohnwu/libsu

    👏👍🥳

    ... Back to regular Magisk programming... PW
    6
    Latest Official TJW debug Canary Magisk:

    Magisk (985249c3) (24309)​

    Pixel 6 Android 13 Beta 2 support is here!

    • [App] Support requesting root from non app process
    • [App] Fix deadlocking a background thread on non-root devices
    • [MagiskInit] Support GKIs with no ramdisk (Pixel 6 Android 13)

    Diffs to v24.3​

    • [MagiskInit] Update 2SI implementation, significantly increase device compatibility (e.g. Sony Xperia devices)
    • [MagiskInit] Introduce new sepolicy injection mechanism
    • [MagiskInit] Support Oculus Go
    • [MagiskInit] Support GKIs with no ramdisk (Pixel 6 Android 13)
    • [App] [MagiskSU] Properly support apps using shared UID
    • [MagiskSU] Fix a possible crash in magiskd
    • [Zygisk] Fix function hooking on devices running Android 12 with old kernels
    • [BusyBox] Add workaround for devices running old kernels
    https://github.com/topjohnwu/magisk-files/blob/56da1fe5430b2c04701ce73d1658ba698ee92283/notes.md

    👍 PW
    5
    Yep, trying to install/run 24308. unfortunately I don't recall the version I had running prior to the factory reset
    Confirms my theory...

    I was asking about wipe type as this issue occurs when root is lost... It may occur with root if app cannot detect it too, eg you installed Magisk app, ran Hide the Magisk app function, subsequently updated the app or manually installed another and it didn't detect / remove the hidden (obfuscated) one and subsequently you have a case of DCAS* which results in Magisk Installed = N/A

    [*Dual Conflicting App Syndrome]

    Since you indicated you had rooted boot image and factory reset (?) only, root loss does seem unlikely, but could be explained by DCAS if you did in fact play with Hide the Magisk app, or actually flashed images since factory reset, or even ran Magisk in-app Uninstall before doing f reset / wipe...

    However If my deductions are correct you seem to have this issue:
    Magisk app ANR on non-root devices #5787

    Fix is already merged but not built yet:
    0ac19e3 Fix app running without root

    I mentioned this here:
    https://forum.xda-developers.com/t/magisk-general-support-discussion.3432382/post-86856305

    If you think I'm right, until next Canary release you can either 1) locate and uninstall conflicting hidden app ('System' or whatever you renamed it) in device settings, apps [if this accounts for Canary app not finding root], then 24308 should work, or 2) install either this test build: https://github.com/topjohnwu/Magisk/actions/runs/2285778144 (extract from artifacts), 24306 or earlier Canary, or 24.3 Stable [if hroot has really been lost / boot image restored etc], then use working Magisk App to do initial patching again...

    Hope I'm on the money...

    🤠 PW
  • 1077
    This is the place for general support and discussion regarding "Public Releases", which includes both stable and beta releases.
    All information, including troubleshoot guides and notes, are in the Announcement Thread
    156
    Hello, I haven't given much support on XDA lately. It can be resulted from
    • University started and I have limited free time. In fact, I mostly develop during midnight
    • I live in Taiwan, which has large time zone differences between my European/American contributors/testers, which usually forces me to stay up late at night to discuss/test stuffs.
    • The new version is about to come, I don't want to spend effort on supporting old releases
    The planned update is delayed again and again, to some point I think I'll shed some light about what has been happening lately, also along with some announcements.

    New Forum!
    As you might have already discovered, Magisk got its own subforum on XDA! Many thanks to all the support you gave me, and much more information/features/support is about to come!
    **For developers supporting all the devices that are not using standard Android boot format, feel free to create threads in this section (actually, PLEASE do so) for your favorite devices after v7 is out. As I currently know, Asus devices require signing the boot image before flashing, and is model dependant; Sony devices seems to use ELF kernel that is unpatchable, or some has two ramdisks (inner + outer), both requires different workarounds; LG bootloader locked devices has to manually "BUMP" the boot image after flashing Magisk..... and there may be lots of other crazy boot image formats that haven't come up to my attention yet.
    It is impossible for me to support all these non-standard boot images, and I hope the community can collaborate to make Magisk running across all the devices. Overall, community collaboration is what XDA about :D

    The Pixel Phone
    Some of you might already know this news, that the next Pixel Phone right around the corner seems like it does not have ramdisk in boot image, which pretty much wrecked Magisk in all ways. However, it pretty much doomed root itself too. Kernel modifications is inevitable IMO, so I'll try to migrate my scripts to C programs that could possibly be included into the kernel itself. Note that I'm not familiar with linux kernel, I'm not even sure if my idea and concept is correct or not. But once the device is available, I think developers will find a way to bypass all the difficulties, and I'll do my best to learn things ;)

    Current Progress
    In the past month, I've spent quite some time learning SELinux, so that I can avoid using SuperSU's sepolicy patches. Thanks to the helps and tips from @phhusson and @Chainfire, I finally have a much clearer understanding of how SELinux works. The Magisk core parts (the scripts, boot image patches, new features, more supports) are actually done some time ago. What is causing all the delays is the Magisk Manager.
    To be completely honest, although I can code in Java without much issues, Magisk Manager is actually my first Android application, I had to reach out for assistance, and fortunately awesome developers like @DVDandroid and @digitalhigh contributed a lot, which makes the current Manager awesome.
    After the repo system and module management is mostly done, I was about to do some adjustments and release, but what we really done is decided to add another feature: auto-unroot with per-app settings. I decided to wait for it to be finished, and then do my adjustments. Due to reasons that'll be mentioned later, this feature will likely not be available for the next release (should come in future updates)

    Safety Net Disaster
    Those who are using Magisk for Safety Net bypass purposes must have known that Google recently updated the detection method of my Systemless Xposed. I still have no idea what Safety Net is detecting, so currently I cannot fix it on my side (also because I'm busy working on the next update). However, suhide developed by @Chainfire is able to hide Xposed and worked fine.
    However, only my Systemless Xposed v86.2, which is based on SuperSU's su.d, is supported using that method. v86.2 and v86.5 (latest, Magisk based) have nearly identical binaries, and the only difference is the path where the binaries are stored.
    I'm still not sure what's the real issue for it not being supported, I just hope it is not done intentionally.

    Conclusion
    Due to the fact that my Safety Net bypass is not 100% perfect now, I do not want to spend any more time waiting for auto-unroot to be polished. What I'm doing now is finishing up all the things I'd like to change in Magisk Manager (it has been a while since I last contributed to Manager, my fellow developers are doing all the heavy job), which might take a little more time, after that, packed with tons of information to be announced in Magisk Section, I'll release the long awaited update.

    Hope this lengthy post gives you the idea of the whole situation, and again thanks for all your support!!
    121
    Ah, some Chainfire bashing, I hope it is not too late for me to exercise additional villainy.

    First, let me make clear I have nothing against @topjohnwu, nor against Magisk. Magisk is an interesting project and it certainly displays @topjohnwu ingenuity and persistence. I don't doubt we will see more interesting things from his hands.

    -------------------------

    What has happened here is not all that dark and complicated, from either end. I returned from holidays, and someone pointed me at Magisk. My first thought: interesting!

    Among other things, the thread lists some issues with SuperSU, which in combination with the phrase The developer also requests users to not bug Chainfire with compatibility requests for SuperSU with Magisk from the portal article, raised my left eyebrow by nigh half an inch. The popular systemless xposed mod is apparently now based on it, and apparently it now no longer works with SuperSU, and apparently I'm not supposed to fix that, nor any of the other found issues. I found that a bit weird. So yes, I have told @topjohnwu that I was a bit surprised he was posting about issues with SuperSU without notifying me about them (I can't fix or help fix issues I'm not aware of, after all).

    He's also spreading a modified version of the SuperSU package, which is not all that uncommon, nor necessarily a problem. I have not looked into what he modified, I only ran a few quick tests on one of my devices, and found some commonly used commands run as root to be broken. I have informed him of this as well.

    It appears the tool of choice for Magisk is phh's Superuser, because of some of the mentioned issues with SuperSU. That's fine by itself, but fixing issues in that superuser by incorporating SuperSU's binaries into it is a somewhat questionable practise. After all, SuperSU is a commercial closed-source package that helps pay for my dinner, and superuser is a direct competitor. I have informed him that I was surprised he did this without asking for permission. I have expressed similar surprise on him spreading a modified version of LiveBoot (which helps pay for a snack now and then).
    @topjohnwu has also stated that Magisk's scripts are largely influenced by mine (I have not checked). Scripts based on mine are used all over the place on XDA, some people have crafted amazing things based on them, I have never made an issue of this (otherwise I would have just made them binaries). But yes, I have also stated to him that I don't think it's very nice to base something on one program, and then using that to (almost exclusively) push something directly competing with that program.

    tl;dr Towards @topjohnwu, I have:
    - expressed surprise he has issues getting Magisk to work with SuperSU, and has chosen not to inform me about those
    - expressed surprise he is using SuperSU binaries in a competing superuser without permission
    - expressed surprise he is posting a modified LiveBoot without permission
    - informed him of issues with the modified SuperSU he has posted
    - let him know I thought it wasn't very nice to be applying my scripts to benefit seemingly exclusively that same competing superuser

    To be crystal clear:
    - I have not asked for an apology
    - I have not asked for Magisk to be abandoned, neither the root hiding nor systemless module parts, and certainly not systemless xposed
    - I have not made an issue of any of this anywhere, until this post
    - I have not even specifically asked for anything to be taken down (though obviously in my opinion the other superuser package mixed with SuperSU's binaries, as well as the LiveBoot package, should go)
    - I have not reported this thread to XDA moderators for copyright violations or otherwise

    While my conversation with @topjohnwu may not win any awards for being friendly (though it may win some for brevity), I think all things considered my response has been rather mild. To be perfectly honest, until the apology post, I thought this was over with already. I think the apology post was triggered because I haven't replied to his last PM for a while - I was in the zone, it happens.

    To emphasize again, I have nothing against @topjohnwu, Magisk, or systemless xposed, and it is certainly not my goal to see any of them go. If it can be made to work together with SuperSU, great.

    I get it though: you think of something, you want to see if you can make it work, you finally get it to work, you publish it, it takes off - enthusiasm gets the better of you. Maybe in the rush some mistakes are made. That doesn't mean you have to just drop it and run. None of my stuff would make it past 0.1 if I stopped at the first big mistake :)

    Aside from said being in the zone coding, I usually regret actually responding to these sort of things the day after, which has made me hesitant to reply. Surprise me.
    76
    Thread temporarily closed so everyone sees this.

    The flood of "SafetyNet isn't working for me either!" posts are not helpful, at all. Please refrain from posting further, it will be looked into. Please do not forget that not passing SafetyNet is 100% NORMAL AND INTENDED when you have an unlocked booloader or running custom firmware. These are workarounds and they will be worked around in turn.

    The Flash
    Forum Moderator

    EDIT: Thread is reopened... I will be cleaning any SafetyNet posts for a while to keep the thread clean for real issues.
    75
    Hello everyone!

    I am aware that Google has updated Safety Net that makes Magisk itself a no go for Android Pay. In fact, I witnessed the change live while I am developing the new magiskhide, which should hide all Magisk modules and Magisk installed root.

    Google is serious about Safety Net now, clearly hunting down all possibility to run Xposed with Safety Net passed. I spend quite some time examining the new security measures last midnight, and fortunately it seems that it is possible to run Magisk and root along with Safety Net if no Xposed is running. I'm glad I removed the old root toggle at the right time lol, that is no longer feasible with the latest detection.

    So stay tuned for the next update, it will come with bug fixes, along with the new magiskhide to bypass that Safety Net.

    Google, how will a few systemless mods do any harm :p:p