Magisk General Support / Discussion

Search This thread
By:
Advanced…
P

pndwal

Senior Member
Jun 23, 2016
4,250
4,325
Sydney
Redmi Note 8
Xiaomi Redmi Note 8 (2021)
heinhuiz said:
No, you're right. What might help is when some of the most helpful contributers like @pndwal and @zgfg and others could have rights to simply delete posts.

I mean, what does a post like:

add in the middle of a discussion about hiding Magisk? 🙄
Or would it be better to just report such posts, or (dis)like them with a sad 🙁 or angry 😡 face?
Click to expand...
Click to collapse
That will be one advantage of the new @ipdev 24.0+ thread; as an active OP he can delete posts / do housekeeping.

With @topjohnwu as OP, this thread relies on moderators to do housekeeping as John is no longer active here... PW
 
  • Like
Reactions: tramp20 and heinhuiz
VD171

VD171

Senior Member
Jun 21, 2012
2,593
2
1,914
127.0.0.1
LG K10
Samsung Galaxy J7
heinhuiz said:
No, you're right. What might help is when some of the most helpful contributers like @pndwal and @zgfg and others could have rights to simply delete posts.

I mean, what does a post like:

add in the middle of a discussion about hiding Magisk? 🙄
Or would it be better to just report such posts, or (dis)like them with a sad 🙁 or angry 😡 face?
Click to expand...
Click to collapse
I love reports.
But I love more useful discussions.
Just read the description for the latest magisk version and you will see the middle of this discussion.
 
mrjuniork

mrjuniork

Forum Moderator
Staff member
Aug 29, 2015
1,480
2,705
OnePlus 9 Pro
pndwal said:
With @topjohnwu as OP, this thread relies on moderators to do housekeeping as John is no longer active here... PW
Click to expand...
Click to collapse
Exactly. People of this thread should report posts, if they deem it necessary and we'll take care of it, as usual.

General info:
No need to make a post about someone else's post being offtopic etc..
 
Last edited:
  • Like
Reactions: ipdev, BillGoss, Eng.Raman and 1 other person
P

pndwal

Senior Member
Jun 23, 2016
4,250
4,325
Sydney
Redmi Note 8
Xiaomi Redmi Note 8 (2021)
VD171 said:
I love reports.
But I love more useful discussions.
Just read the description for the latest magisk version and you will see the middle of this discussion.
Click to expand...
Click to collapse
Sure... But users should really read OP and subsequent posts from OP (first five in that thread) before asking questions in any XDA thread! Your question indicates that you didn't do this minimum preparation as the basic answer is covered by OP. 😜

Edit: Actually, I may be being a bit tough on you here; It may be a bit unclear in OP's (@ipdev) Opening Posts that Universal SafetyNet Fix is now the defacto MagiskHide(er) solution (allows SafetyNet passing). A better description might help, and you could be excused for not knowing the significance of USNF...

Also, there is no mention yet of Shamiko as a solution to further hide traces of Magisk root including Zygisk, modules, isolated process leaks etc. This may be a supplementary answer to your question. 😜 PW
 
Last edited:
VD171

VD171

Senior Member
Jun 21, 2012
2,593
2
1,914
127.0.0.1
LG K10
Samsung Galaxy J7
pndwal said:
Sure... But users should really read OP and subsequent posts from OP (first five in that thread) before asking questions in any XDA thread! Your question indicates that you didn't do this minimum preparation as the basic answer is covered by OP. 😜 PW
Click to expand...
Click to collapse
I just want to catch a fire on this, my friend.
If I'm bothering you, I don't care.
Edit: About how hiding root actually?
I've installed Magisk v24.1, LSPosed v1.7.2, Shamiko v0.4.3, XPrivacyLua v1.30 and everything is working perfectly.
I can hide root, xposed and zygisk, using it, please read my reply:
forum.xda-developers.com

[APP][v1.10] VD Infos (Package: com.vitaodoidao.vdinfos)

(Para quem fala PORTUGUÊS, o próximo post está totalmente traduzido !) VD Infos v1.10 As we all know, Android is a super powerful and super versatile operating system. What nobody tells you is that all your personal details and confidential...
forum.xda-developers.com forum.xda-developers.com
 
Last edited:
P

pndwal

Senior Member
Jun 23, 2016
4,250
4,325
Sydney
Redmi Note 8
Xiaomi Redmi Note 8 (2021)
VD171 said:
I just want to catch a fire on this, my friend.
If I'm bothering you, I don't care.
Click to expand...
Click to collapse
Edited / reconsidered post above (cos really I do care. - and as mod noted above, there was no need for member to single you out for a mention. And your post was not even Off Topic).

Sorry if a bit tough / quick to criticise. Please check edit. PW
 
Last edited:
meric57

meric57

Senior Member
Oct 2, 2017
90
16
Hettange Grand
Good evening, as I have the blow 2 or 3 times to lose the rooting of magisk following the update.
Is it possible to flash the image of magisk or to create it for flashing, then put the image of the last version on the discussion page on magisk which saw the day yesterday.
How to remove the security message at startup of the smartphone, I can remove it with a patch with TRWP by flashing it, but just with magisk there may be a module that can do it.
Thank you
 
Last edited:
P

pndwal

Senior Member
Jun 23, 2016
4,250
4,325
Sydney
Redmi Note 8
Xiaomi Redmi Note 8 (2021)
Latest Unofficial vvb2060 Alpha Magisk
(Chinese Translated):

# alpha changelog

## Magisk (3c7e7921-alpha)
- [App] Support SharedUserId
- [App] Delete backup file after restoring boot image
- [App] Built-in current version update log
- [General] no longer automatically unlock device blocks
- [General] Use MagiskHide to hide when Zygisk is closed
- [App] Compatible with Android 12L
- [MagiskInit] Refactor the processing method of two-step startup
- [General] Update to NDK 23
- [App] Added crash statistics
- [App] Fixed some reported crashes
- [App] built-in module_installer.sh

### how to install?
Install and uninstall Magisk through the Magisk application. Generally, it should be done directly in the application. In special cases such as the first installation, you should use the fastboot/odin tool to flash it after patching the image.
By customizing Recovery is not a supported way.

👍 PW
 
  • Like
Reactions: rodken, belair56, jons99 and 1 other person
J

J.Michael

Recognized Contributor
Jan 20, 2018
1,101
1,043
Samsung Galaxy Tab A series
meric57 said:
Good evening, as I have the blow 2 or 3 times to lose the rooting of magisk following the update.
Is it possible to flash the image of magisk or to create it for flashing, then put the image of the last version on the discussion page on magisk which saw the day yesterday.
How to remove the security message at startup of the smartphone, I can remove it with a patch with TRWP by flashing it, but just with magisk there may be a module that can do it.
Thank you
Click to expand...
Click to collapse
You can not remove the security message at startup.
Not with a Magisk module.
Not easily.
That message comes from the thing that boots before Android. It is related to the thing that boots Android. It is earlier than anything that can be affected by a Magisk module. It is earlier than anything that can be affected by Magisk.
I do not understand how you can remove the security message with a patch with TWRP. I'm not sure what you mean by "a patch with TWRP".
 
A

An68

Senior Member
Mar 20, 2017
54
7
Please help me. I want to root my Poco X3 Pro with Magisk 2400, after flash Lineage 18.1 and Gapps,
patch the boot.img, move it not with ADB from SD to the PC, rename to magisk_patched.img,
but after flash and reboot I haven't root .
Where I wrong? Thanks
1643347767538.png
 
Rumplestilzken

Rumplestilzken

New member
Jun 25, 2008
2
1
I am working on getting the Unihertz Titan up and running with TWRP (from scratch) and Magisk.

I have tried both Magisk v23 & 24. Both show i am rooted by root checkers however both give errors which i need a little bit of help to diagnose.

v23 - In Magisk apk after patching and flashing the patched rom Installed shows N/a. I can run su in adb shell however i get a message saying no daemon is running.

v24 - In Magisk apk after patching with both vbmeta checked and not checked it shows as Installed 24. However, when i used adb shell and try and execute su i am greeted with Permission Denied.

I would greatly appreciate any sort of constructive advice, i have made a lot of progress in the last few days, but i am at a standstill now. TWRP cannot continue development because it cannot mount any partitions and do its thing.
 
J

J.Michael

Recognized Contributor
Jan 20, 2018
1,101
1,043
Samsung Galaxy Tab A series
Rumplestilzken said:
I am working on getting the Unihertz Titan up and running with TWRP (from scratch) and Magisk.

I have tried both Magisk v23 & 24. Both show i am rooted by root checkers however both give errors which i need a little bit of help to diagnose.

v23 - In Magisk apk after patching and flashing the patched rom Installed shows N/a. I can run su in adb shell however i get a message saying no daemon is running.

v24 - In Magisk apk after patching with both vbmeta checked and not checked it shows as Installed 24. However, when i used adb shell and try and execute su i am greeted with Permission Denied.

I would greatly appreciate any sort of constructive advice, i have made a lot of progress in the last few days, but i am at a standstill now. TWRP cannot continue development because it cannot mount any partitions and do its thing.
Click to expand...
Click to collapse
With version 24 installed, with the Magisk Manager app admitting that Magisk is installed:

What happens if you open a terminal emulator and type "su" at the command prompt?

I do not believe that there is any connection between successfully installing Magisk, and successfully implementing TWRP. I understand that if you had a working TWRP, you would have another way to try to install Magisk. I am saying I do not understand how a lack of Magisk and it's associated "su" is blocking the development of TWRP.
 
Rumplestilzken

Rumplestilzken

New member
Jun 25, 2008
2
1
J.Michael said:
With version 24 installed, with the Magisk Manager app admitting that Magisk is installed:

What happens if you open a terminal emulator and type "su" at the command prompt?

I do not believe that there is any connection between successfully installing Magisk, and successfully implementing TWRP. I understand that if you had a working TWRP, you would have another way to try to install Magisk. I am saying I do not understand how a lack of Magisk and it's associated "su" is blocking the development of TWRP.
Click to expand...
Click to collapse
From a terminal, i am asked to grant permission and it executes as neccesary. Thanks for that avenue.

TWRP works on the EMMC version of the Titan, but not on the UFS version which was release about a year after launch. EMMC users are free to use it, but UFS devices do not allow you to mount anything, the block devices are not registered. The only thing that i could find of use was the sd card. I'm drawing at straws to try and figure out why none of the devices are active. When i saw that su wouldn't run in 24 in adb but gave a different response in 23 i thought i might have stumbled onto something about the root not taking.

I'm thinking potentially the kernel source will have been updated, they haven't released the source yet but are apparently working on preparing it for release.

I did find an interesting build option. BOARD_BUILD_SYSTEM_ROOT_IMAGE, i think the kernel that they built was before they updated the kernel when the UFS devices came out. I have a hunch that once we get the source this will be put to rest but until then, i would like other options.
 
Last edited:
  • Like
Reactions: J.Michael
A

amk316

Senior Member
Dec 14, 2011
98
19
Samsung Galaxy S20
hi
just update my s20 to A12 with magisk 24001 everything work OK
i added safetynet-fix-v2.2.1 and Shamiko-v0.3.0-73-release and they work OK
p.s. "do not add SmaliPatcher it will boot loop"
the only problem i have is when booting the phone on lock screen the phone will reboot in seconds every time, i have to unlock the phone to stop the reboot.
anyone know what i can do to solve this.

thanks.
 

Attachments

  • Screenshot_20220128-101254_Momo.jpg
    Screenshot_20220128-101254_Momo.jpg
    300.9 KB · Views: 79
  • Screenshot_20220128-101309_RootBeer Sample.jpg
    Screenshot_20220128-101309_RootBeer Sample.jpg
    322.4 KB · Views: 77
  • Screenshot_20220128-111056_SafetyNet Test.jpg
    Screenshot_20220128-111056_SafetyNet Test.jpg
    230 KB · Views: 76
zgfg

zgfg

Senior Member
Oct 10, 2016
7,156
4,610
amk316 said:
hi
just update my s20 to A12 with magisk 24001 everything work OK
i added safetynet-fix-v2.2.1 and Shamiko-v0.3.0-73-release and they work OK
p.s. "do not add SmaliPatcher it will boot loop"
the only problem i have is when booting the phone on lock screen the phone will reboot in seconds every time, i have to unlock the phone to stop the reboot.
anyone know what i can do to solve this.

thanks.
Click to expand...
Click to collapse
Upon updating your system, you must run SmaliPatcher again to create new module zip

Still, maybe all patches do not work for your phone and A12
 
  • Like
Reactions: J.Michael
meric57

meric57

Senior Member
Oct 2, 2017
90
16
Hettange Grand
Hello,good me
 

Attachments

  • Screenshot_20220128-102612_RootBeer Sample.jpg
    Screenshot_20220128-102612_RootBeer Sample.jpg
    311.5 KB · Views: 57
  • Screenshot_20220128-102405_Root Checker.jpg
    Screenshot_20220128-102405_Root Checker.jpg
    351.4 KB · Views: 58
P

pndwal

Senior Member
Jun 23, 2016
4,250
4,325
Sydney
Redmi Note 8
Xiaomi Redmi Note 8 (2021)
amk316 said:
hi
just update my s20 to A12 with magisk 24001 everything work OK
i added safetynet-fix-v2.2.1 and Shamiko-v0.3.0-73-release and they work OK
p.s. "do not add SmaliPatcher it will boot loop"
the only problem i have is when booting the phone on lock screen the phone will reboot in seconds every time, i have to unlock the phone to stop the reboot.
anyone know what i can do to solve this.

thanks.
Click to expand...
Click to collapse
Does issue persist after reboot with all modules disabled?

Did you take A12 update by downloading complete A12 ROM, patching AP with Magisk in old OS, then flashing w/ Odin: patched AP + BL + CP + HOME_CSC? PW
 
  • Like
Reactions: J.Michael
P

pndwal

Senior Member
Jun 23, 2016
4,250
4,325
Sydney
Redmi Note 8
Xiaomi Redmi Note 8 (2021)
An68 said:
Please help me. I want to root my Poco X3 Pro with Magisk 2400, after flash Lineage 18.1 and Gapps,
patch the boot.img, move it not with ADB from SD to the PC, rename to magisk_patched.img,
but after flash and reboot I haven't root .
Where I wrong? Thanks
View attachment 5520987
Click to expand...
Click to collapse
I've never seen anyone use MiFlash to install Magisk! 🤔 - Why are you doing that rather than following official instructions (install ADB drivers and flash with Fastboot command)?

Tip: on Xiaomi devices, generally Recovery mode option should be unchecked if it appears as Xiaomi bootloaders are compatible with ramdisk in boot partition and magisk will install one even when OEM hasn't. 😜 PW
 
Last edited:
  • Like
Reactions: J.Michael
You must log in or register to reply here.

Similar threads

T
  • Locked
  • Sticky
Magisk - The Magic Mask for Android
Replies
56
Views
6M
T
topjohnwu
T
  • Locked
[CLOSED][BETA][2018.7.19] Magisk v16.7 (1671)
Replies
7K
Views
3M
T
topjohnwu
Heisenberg
[Discussion] PokeMon Go Magisk Discussion Thread
Replies
5K
Views
624K
djkrish5610
djkrish5610
yochananmarqos
  • Sticky
Collection of Magisk Modules v2
Replies
1K
Views
1M
SigmundDroid
SigmundDroid
Didgeridoohan
[Discussion] Google Pay Magisk Discussion Thread
Replies
2K
Views
431K
Fishawy
Fishawy

Top Liked Posts

24 Hours 30 Days All time
  • There are no posts matching your filters.
  • 7
    P
    pndwal
    Latest Shamiko:

    Shamiko v0.5.0​

    0.5.0​

    • Better hiding Zygisk
    pndwal said:
    "... Momo enjoys helping Shamiko become stronger in all aspects despite Shamiko's goal of defeating her..."
    Click to expand...
    Click to collapse

    👍 PW
    View
    6
    P
    pndwal
    pndwal said:
    Looks like major libsu release is now imminent; most fixes are now merged.

    Should see major stability improvements in Magisk and root app implementation... Should see new commits for Magisk proper again soon too!

    John has made some major libsu changes (see libsu GitHub).

    Here are extra comments on vvb2060 fixes from her TG (Chinese translated....


    👀 PW
    Click to expand...
    Click to collapse
    libsu 5.0.0 is out!

    libsu/CHANGELOG.md​

    5.0.0​

    Check the updated Javadoc and the example app for details on how to use the remote file system in the new nio module.

    New Features​

    • Introduce a new module: nio
      • Includes file system implementations for local and remote processes
      • New FileSystemManager class to access either local or remote file system implementations
      • New ExtendedFile class to extend functionality of the old Java File API
    • [core] New API Shell.isAppGrantedRoot() returns a nullable Boolean:
      • true if a root shell has been created
      • false if it has been determined that root access is impossible to get
      • null if the library has not, or could not determine the current root grant state. Future invocations of this method may return a non-null value if the library gained more information during shell creation.
    • [core] New API Shell.Builder.setContext(context): allow the developer to explicitly provide a Context object
    • [io] SuFile is updated to also extend ExtendedFile, which adds some new features and APIs

    Deprecation​

    • Version 5.0.0 will be the final release of the busybox module. If you cannot remove the usage of the module, you can pin the busybox module to version 5.0.0, as it is updated to be fully self contained, making it guaranteed to work with future libsu versions.
    • Usage of SuFile/SuFileOutputStream/SuFileInputStream/SuRandomAccessFile is discouraged. Although these APIs will remain for the foreseeable future, please migrate to use RootService + the nio module for all root I/O operations.
    • Shell.rootAccess() is deprecated. Please switch to use the more accurate Shell.isAppGrantedRoot() API

    John Wu, 2h

    Major libsu update 5.0.0!

    Introduces a new module "nio" to perform I/O operations through root services, moving away from the error prone, inefficient shell command backed I/O the library used to provide.

    It's already using splice under-the-hood. There is already some Linux magic!
    Click to expand...
    Click to collapse

    New readme etc. Read how you can Attach Debugger to Android Process in Root Services and more!
    https://github.com/topjohnwu/libsu

    👏👍🥳

    ... Back to regular Magisk programming... PW
    View
    6
    P
    pndwal
    Latest Official TJW debug Canary Magisk:

    Magisk (985249c3) (24309)​

    Pixel 6 Android 13 Beta 2 support is here!

    • [App] Support requesting root from non app process
    • [App] Fix deadlocking a background thread on non-root devices
    • [MagiskInit] Support GKIs with no ramdisk (Pixel 6 Android 13)

    Diffs to v24.3​

    • [MagiskInit] Update 2SI implementation, significantly increase device compatibility (e.g. Sony Xperia devices)
    • [MagiskInit] Introduce new sepolicy injection mechanism
    • [MagiskInit] Support Oculus Go
    • [MagiskInit] Support GKIs with no ramdisk (Pixel 6 Android 13)
    • [App] [MagiskSU] Properly support apps using shared UID
    • [MagiskSU] Fix a possible crash in magiskd
    • [Zygisk] Fix function hooking on devices running Android 12 with old kernels
    • [BusyBox] Add workaround for devices running old kernels
    https://github.com/topjohnwu/magisk-files/blob/56da1fe5430b2c04701ce73d1658ba698ee92283/notes.md

    👍 PW
    View
    6
    P
    pndwal

    Latest Official TJW debug Canary Magisk:​

    Magisk (cc79a96f) (24307)​

    • [App] Update libsu with 100% new I/O layer
    • [MagiskInit] Mock enforce file with regular file to prevent possible race condition
    • Switch normal NDK with ONDK, preparing the toolchain to introduce Rust

    Diffs to v24.3​

    • [MagiskInit] Update 2SI implementation, significantly increase device compatibility (e.g. Sony Xperia devices)
    • [MagiskInit] Introduce new sepolicy injection mechanism
    • [MagiskInit] Support Oculus Go
    • [App] [MagiskSU] Properly support apps using shared UID
    • [MagiskSU] Fix a possible crash in magiskd
    • [Zygisk] Fix function hooking on devices running Android 12 with old kernels
    • [BusyBox] Add workaround for devices running old kernels
    https://github.com/topjohnwu/magisk-files/blob/a66dfce1bf88a70e86bf86c5427b1c58e71a4fc2/notes.md

    👍 PW
    View
    5
    P
    pndwal

    Latest Official TJW debug Canary Magisk:​

    Magisk (42e5f515) (24308)​

    • Several minor bug fixes

    Diffs to v24.3​

    • [MagiskInit] Update 2SI implementation, significantly increase device compatibility (e.g. Sony Xperia devices)
    • [MagiskInit] Introduce new sepolicy injection mechanism
    • [MagiskInit] Support Oculus Go
    • [App] [MagiskSU] Properly support apps using shared UID
    • [MagiskSU] Fix a possible crash in magiskd
    • [Zygisk] Fix function hooking on devices running Android 12 with old kernels
    • [BusyBox] Add workaround for devices running old kernels
    https://github.com/topjohnwu/magisk-files/blob/ba1cf1081e1fe6fce7fda626dfdb0a0faab27d4e/notes.md

    👍 PW
    View
  • 1077
    T
    topjohnwu
    This is the place for general support and discussion regarding "Public Releases", which includes both stable and beta releases.
    All information, including troubleshoot guides and notes, are in the Announcement Thread
    View
    156
    T
    topjohnwu
    Hello, I haven't given much support on XDA lately. It can be resulted from
    • University started and I have limited free time. In fact, I mostly develop during midnight
    • I live in Taiwan, which has large time zone differences between my European/American contributors/testers, which usually forces me to stay up late at night to discuss/test stuffs.
    • The new version is about to come, I don't want to spend effort on supporting old releases
    The planned update is delayed again and again, to some point I think I'll shed some light about what has been happening lately, also along with some announcements.

    New Forum!
    As you might have already discovered, Magisk got its own subforum on XDA! Many thanks to all the support you gave me, and much more information/features/support is about to come!
    **For developers supporting all the devices that are not using standard Android boot format, feel free to create threads in this section (actually, PLEASE do so) for your favorite devices after v7 is out. As I currently know, Asus devices require signing the boot image before flashing, and is model dependant; Sony devices seems to use ELF kernel that is unpatchable, or some has two ramdisks (inner + outer), both requires different workarounds; LG bootloader locked devices has to manually "BUMP" the boot image after flashing Magisk..... and there may be lots of other crazy boot image formats that haven't come up to my attention yet.
    It is impossible for me to support all these non-standard boot images, and I hope the community can collaborate to make Magisk running across all the devices. Overall, community collaboration is what XDA about :D

    The Pixel Phone
    Some of you might already know this news, that the next Pixel Phone right around the corner seems like it does not have ramdisk in boot image, which pretty much wrecked Magisk in all ways. However, it pretty much doomed root itself too. Kernel modifications is inevitable IMO, so I'll try to migrate my scripts to C programs that could possibly be included into the kernel itself. Note that I'm not familiar with linux kernel, I'm not even sure if my idea and concept is correct or not. But once the device is available, I think developers will find a way to bypass all the difficulties, and I'll do my best to learn things ;)

    Current Progress
    In the past month, I've spent quite some time learning SELinux, so that I can avoid using SuperSU's sepolicy patches. Thanks to the helps and tips from @phhusson and @Chainfire, I finally have a much clearer understanding of how SELinux works. The Magisk core parts (the scripts, boot image patches, new features, more supports) are actually done some time ago. What is causing all the delays is the Magisk Manager.
    To be completely honest, although I can code in Java without much issues, Magisk Manager is actually my first Android application, I had to reach out for assistance, and fortunately awesome developers like @DVDandroid and @digitalhigh contributed a lot, which makes the current Manager awesome.
    After the repo system and module management is mostly done, I was about to do some adjustments and release, but what we really done is decided to add another feature: auto-unroot with per-app settings. I decided to wait for it to be finished, and then do my adjustments. Due to reasons that'll be mentioned later, this feature will likely not be available for the next release (should come in future updates)

    Safety Net Disaster
    Those who are using Magisk for Safety Net bypass purposes must have known that Google recently updated the detection method of my Systemless Xposed. I still have no idea what Safety Net is detecting, so currently I cannot fix it on my side (also because I'm busy working on the next update). However, suhide developed by @Chainfire is able to hide Xposed and worked fine.
    However, only my Systemless Xposed v86.2, which is based on SuperSU's su.d, is supported using that method. v86.2 and v86.5 (latest, Magisk based) have nearly identical binaries, and the only difference is the path where the binaries are stored.
    I'm still not sure what's the real issue for it not being supported, I just hope it is not done intentionally.

    Conclusion
    Due to the fact that my Safety Net bypass is not 100% perfect now, I do not want to spend any more time waiting for auto-unroot to be polished. What I'm doing now is finishing up all the things I'd like to change in Magisk Manager (it has been a while since I last contributed to Manager, my fellow developers are doing all the heavy job), which might take a little more time, after that, packed with tons of information to be announced in Magisk Section, I'll release the long awaited update.

    Hope this lengthy post gives you the idea of the whole situation, and again thanks for all your support!!
    View
    121
    Chainfire
    Chainfire
    Ah, some Chainfire bashing, I hope it is not too late for me to exercise additional villainy.

    First, let me make clear I have nothing against @topjohnwu, nor against Magisk. Magisk is an interesting project and it certainly displays @topjohnwu ingenuity and persistence. I don't doubt we will see more interesting things from his hands.

    -------------------------

    What has happened here is not all that dark and complicated, from either end. I returned from holidays, and someone pointed me at Magisk. My first thought: interesting!

    Among other things, the thread lists some issues with SuperSU, which in combination with the phrase The developer also requests users to not bug Chainfire with compatibility requests for SuperSU with Magisk from the portal article, raised my left eyebrow by nigh half an inch. The popular systemless xposed mod is apparently now based on it, and apparently it now no longer works with SuperSU, and apparently I'm not supposed to fix that, nor any of the other found issues. I found that a bit weird. So yes, I have told @topjohnwu that I was a bit surprised he was posting about issues with SuperSU without notifying me about them (I can't fix or help fix issues I'm not aware of, after all).

    He's also spreading a modified version of the SuperSU package, which is not all that uncommon, nor necessarily a problem. I have not looked into what he modified, I only ran a few quick tests on one of my devices, and found some commonly used commands run as root to be broken. I have informed him of this as well.

    It appears the tool of choice for Magisk is phh's Superuser, because of some of the mentioned issues with SuperSU. That's fine by itself, but fixing issues in that superuser by incorporating SuperSU's binaries into it is a somewhat questionable practise. After all, SuperSU is a commercial closed-source package that helps pay for my dinner, and superuser is a direct competitor. I have informed him that I was surprised he did this without asking for permission. I have expressed similar surprise on him spreading a modified version of LiveBoot (which helps pay for a snack now and then).
    @topjohnwu has also stated that Magisk's scripts are largely influenced by mine (I have not checked). Scripts based on mine are used all over the place on XDA, some people have crafted amazing things based on them, I have never made an issue of this (otherwise I would have just made them binaries). But yes, I have also stated to him that I don't think it's very nice to base something on one program, and then using that to (almost exclusively) push something directly competing with that program.

    tl;dr Towards @topjohnwu, I have:
    - expressed surprise he has issues getting Magisk to work with SuperSU, and has chosen not to inform me about those
    - expressed surprise he is using SuperSU binaries in a competing superuser without permission
    - expressed surprise he is posting a modified LiveBoot without permission
    - informed him of issues with the modified SuperSU he has posted
    - let him know I thought it wasn't very nice to be applying my scripts to benefit seemingly exclusively that same competing superuser

    To be crystal clear:
    - I have not asked for an apology
    - I have not asked for Magisk to be abandoned, neither the root hiding nor systemless module parts, and certainly not systemless xposed
    - I have not made an issue of any of this anywhere, until this post
    - I have not even specifically asked for anything to be taken down (though obviously in my opinion the other superuser package mixed with SuperSU's binaries, as well as the LiveBoot package, should go)
    - I have not reported this thread to XDA moderators for copyright violations or otherwise

    While my conversation with @topjohnwu may not win any awards for being friendly (though it may win some for brevity), I think all things considered my response has been rather mild. To be perfectly honest, until the apology post, I thought this was over with already. I think the apology post was triggered because I haven't replied to his last PM for a while - I was in the zone, it happens.

    To emphasize again, I have nothing against @topjohnwu, Magisk, or systemless xposed, and it is certainly not my goal to see any of them go. If it can be made to work together with SuperSU, great.

    I get it though: you think of something, you want to see if you can make it work, you finally get it to work, you publish it, it takes off - enthusiasm gets the better of you. Maybe in the rush some mistakes are made. That doesn't mean you have to just drop it and run. None of my stuff would make it past 0.1 if I stopped at the first big mistake :)

    Aside from said being in the zone coding, I usually regret actually responding to these sort of things the day after, which has made me hesitant to reply. Surprise me.
    View
    76
    nathanchance
    nathanchance
    Thread temporarily closed so everyone sees this.

    The flood of "SafetyNet isn't working for me either!" posts are not helpful, at all. Please refrain from posting further, it will be looked into. Please do not forget that not passing SafetyNet is 100% NORMAL AND INTENDED when you have an unlocked booloader or running custom firmware. These are workarounds and they will be worked around in turn.

    The Flash
    Forum Moderator

    EDIT: Thread is reopened... I will be cleaning any SafetyNet posts for a while to keep the thread clean for real issues.
    View
    75
    T
    topjohnwu
    Hello everyone!

    I am aware that Google has updated Safety Net that makes Magisk itself a no go for Android Pay. In fact, I witnessed the change live while I am developing the new magiskhide, which should hide all Magisk modules and Magisk installed root.

    Google is serious about Safety Net now, clearly hunting down all possibility to run Xposed with Safety Net passed. I spend quite some time examining the new security measures last midnight, and fortunately it seems that it is possible to run Magisk and root along with Safety Net if no Xposed is running. I'm glad I removed the old root toggle at the right time lol, that is no longer feasible with the latest detection.

    So stay tuned for the next update, it will come with bug fixes, along with the new magiskhide to bypass that Safety Net.

    Google, how will a few systemless mods do any harm :p:p
    View

New posts