Magisk General Support / Discussion

Search This thread

zgfg

Senior Member
Oct 10, 2016
7,371
4,761
I see. Have you tried it using with magisk deny list procedure?
Just tested the following:
- Enabled Enforce DenyList
- Added Chrome to DenyList
- Disabled Enforce DenyList (since I'm using Shamiko that reads DenyList but acts instead of the built-in DenyList)
- Rebooted
- Opened Chrome, Incognito mode and took a screenshot (Incognito mode prevents you taking screenshots without the Secure Screenshots patch)
 

amit_coolcampus

Senior Member
Mar 30, 2013
330
46
Delhi
Samsung Galaxy Note 9
Can
Just tested the following:
- Enabled Enforce DenyList
- Added Chrome to DenyList
- Disabled Enforce DenyList (since I'm using Shamiko that reads DenyList but acts instead of the built-in DenyList)
- Rebooted
- Opened Chrome, Incognito mode and took a screenshot (Incognito mode prevents you taking screenshots without the Secure Screenshots patch)
Got it. This should ideally work then. Can you please also try any banking app for me if thats not a big trouble for you?
 

zgfg

Senior Member
Oct 10, 2016
7,371
4,761
Can

Got it. This should ideally work then. Can you please also try any banking app for me if thats not a big trouble for you?
Maybe tomorrow but give me the banking app. Btw, on my Xiaomi I cannot pass for S-PushTAN, hence I would never be able to take a screenshot there - S-PushTAB drives me immediately to the Web page saying that my phone is not secure

Better try yourself Smali Patcher - it's not prohibited like LP, there is a Smali Patcher thread on XDA

Also, for some phones and ROMs patching (preparing a zip module) fails - in that case, it would not be applicable, you must better test yourself
 
  • Like
Reactions: amit_coolcampus

amit_coolcampus

Senior Member
Mar 30, 2013
330
46
Delhi
Samsung Galaxy Note 9
Maybe tomorrow but give me the banking app. Btw, on my Xiaomi I cannot pass for S-PushTAN, hence I would never be able to take a screenshot there - S-PushTAB drives me immediately to the Web page saying that my phone is not secure

Better try yourself Smali Patcher - it's not prohibited like LP, there is a Smali Patcher thread on XDA

Also, for some phones and ROMs patching (preparing a zip module) fails - in that case, it would not be applicable, you must better test yourself
Yeah, in that case I would give a try myself. I have jasi patches and I think that should work as well if small patches works for you, however I will try and get back.
 

Cronoss

Senior Member
Jul 23, 2013
149
37
Guys, so how are we supposed to hide magisk now from Google Play and stuff like that?
With version 23 I was able to hide magisk ticking all the boxes on Google Play until the blue bar was completely full, and my bank app worked.
What are these "modules" to hide magisk that @topjohnwu is talking about when he announced v24?
 
  • Like
Reactions: access9

amit_coolcampus

Senior Member
Mar 30, 2013
330
46
Delhi
Samsung Galaxy Note 9
Ok here are the findings.
Magisk enforce deny list doesn't allow you to use xposed modules for the apps added in deny list. Means shamiko+ zygisk is the key. Just adding the secured app in the deny list and then use shamiko module. After that you can any patches or stand alone module to disable secure flag, its good to go to use any xposed module.
 

m0han

Senior Member
Apr 30, 2012
4,897
1,970
....- Opened Chrome, Incognito mode and took a screenshot (Incognito mode prevents you taking screenshots without the Secure Screenshots patch)
tried this (did everything as you wrote), but i couldn't get a screenshot. is it because i don't have 'smali patcher for secure flag' module at all? i was thinking you had disabled the module to try the denylist procedure, so reckoned it would work for me without the module. is it a must to have 'smali patcher for secure flag' module installed and enabled, for getting screenshots in secure apps?
 

m0han

Senior Member
Apr 30, 2012
4,897
1,970

yasnac and network_error

not able to get yasnac to work since morning (everything else seems fine atm). anyone else face this issue? not sure if there is a connection, but this issue surfaced (was noticed) after i updated to the latest alpha. what could be the reason? tips to get this resolved would be nice.
 

Attachments

  • Screenshot_20220129-085549_YASNAC.png
    Screenshot_20220129-085549_YASNAC.png
    101.3 KB · Views: 70
  • Screenshot_20220129-093602_MyJisk.png
    Screenshot_20220129-093602_MyJisk.png
    139.2 KB · Views: 67

Homeboy76

Senior Member
Aug 24, 2012
3,228
1,773
Google Pixel XL

yasnac and network_error

not able to get yasnac to work since morning (everything else seems fine atm). anyone else face this issue? not sure if there is a connection, but this issue surfaced (was noticed) after i updated to the latest alpha. what could be the reason? tips to get this resolved would be nice.
 
  • Like
Reactions: m0han

zgfg

Senior Member
Oct 10, 2016
7,371
4,761
tried this (did everything as you wrote), but i couldn't get a screenshot. is it because i don't have 'smali patcher for secure flag' module at all? i was thinking you had disabled the module to try the denylist procedure, so reckoned it would work for me without the module. is it a must to have 'smali patcher for secure flag' module installed and enabled, for getting screenshots in secure apps?
There are apps that don't allow screenshots - like Chrome in Incognito mode, and there are solutions to trick them (to allow the so called Secure screenshots) - like Smali patcher (check-box Secure screenshots while patching)
 

kamild_

Senior Member
Trying to get a certain paranoid game to run, but it keep detecting root access.
I have updated to Magisk 24.1, got the SafetyNet Fix module (v2.2.1) as well as Shamiko (v0.3.0 (73)). Zygisk is enabled, DenyList is not enforced but I have ticked the necessary apps in the DenyList. There are two things that Momo still detects - "running a custom ROM" and "bootloader unlocked".
The first one is I assume due to part of the fingerprint that Momo is showing, which reveals the custom ROM maintainer:
POCO/vayu_global/vayu:11/RKQ1.200826.002/V12.5.7.0.RJUMIXM:user/release-keys
POCO/vayu/vayu:11/RQ3A.211001.001/eng.neobud.20220122.185029:user/release-keys 30
but I'm not sure how to modify the second part of the fingerprint, I've tried using MagiskHide Props for that.
Also not sure about the "bootloader unlocked" part, isn't that something the Universal SafetyNet Fix was supposed to help hide?
Is there anything I can do about these two detections?
 

Top Liked Posts

  • 2
    Or boosted, actually :D
    Yup... But boost = catalyst for Oxidation... he's excited about Rust... 😛

    2 commits in his CXX (interop) repo, 1 in ONDK (w/ rust tool-chain), and 6 in Rust (Programming language) Custom and fix-lid branches in last 10 hrs...

    Of course this is all still relevant!:
    John Wu, Jun 19

    Magisk v25.1 published to public stable 🎉🎉
    www.twitter.com/topjohnwu/status/1534117522424811520/photo/1

    This marks the official start of v26's development cycle, which also starts the Oxidation Project (adding Rust to Magisk). So excited!
    www.twitter.com/topjohnwu/status/1538462758332575744

    ... and he's been studying Rust for more than a year... good to see such commitment being distilled now for Android modders benefit!

    Seems open source & equally committed contributors / collaborators have also allowed him to do this...
    https://forum.xda-developers.com/t/magisk-general-support-discussion.3432382/post-84827781

    Linus says Rust is coming to the Linux kernel "real soon now... Rust is a way to try something new. And hopefully, it works out, and people have been working on it a lot, so I really hope it works out because otherwise they'll be bummed."
    https://www.theregister.com/2022/06/23/linus_torvalds_rust_linux_kernel/

    Seems Rust is coming to Magisk injection for kernels 'real soon now' too... If Rust is a way to try something new, hopefully it works out for Magisk too... John's clearly been working on it a lot, so I really hope it works out... because we don't want to be given the bum's rush...

    😷 PW
    1
    I've flashed recently CSC file and lost the root.
    I'm guessing flash CSC = factory reset? Did you do this in Odin w/ other needed binaries incl. AP?...
    I updated MAgisk app up to 25.1 version (not a zip file just apk) but still no root. I have flashed Magisk 25.1.zip file in TWRP recovery. Now the phone is rooted, but I unable to start Magisk app. It just stuck on the start (The Mask).
    Strange issue... Do you have issues starting other apps? Tried clearing its app data?...

    Also, try deleting everything in /data/adb and rebooting to rebuild Magisk config files... Use TWRP if you can't use a root explorer...
    I tried to uninstall Magisk app via Application manager, and reinstall it following by reboot. Still Magisk unable to start. I don't remember whether MAgisk was unhidden before the update and zip installation. What should I do next?
    Hidden app would be gone if did factory reset...

    If installed since, check in device settings, Apps for 'Settings' (default name) or whatever you named it. Uninstall if found...
    Should I rename the Magisk.apk to uninstall.zip and run this file in TWRP. Then install Magisk apk and install zip file from within Magisk App? If so, what the best way to install MAgisk App; via TWRP or File Manager?
    Install app like any other .apk from 'unknown aources'...
    Samsung Galaxy S5
    Marshmallow 6.0.1
    👍 PW
    1
    Hi all, just some sharing on my experience in the past week.

    I updated Magisk from stable 24.3 to 25.1, everything seemed fine.
    Then noticed there were updates of USNF and Shamiko, which are the only modules I use, then I updated both.
    Then the latest Momo reported nothing found (only bootloader unlocked), so all looked good.

    However, in my Work profile, Zimperium zIPS detected ROOT! This is the last thing I want because it will automatically reports to my company that I'm using a rooted device to access company mails, etc. :_(

    I reverted USNF and Shamiko to the previous versions, still no luck.
    Then a full uninstall of Magisk, followed by installing 24.3. Then latest versions of USNF and Shamiko.

    Well, Momo this time reported Zygisk found. Then zIPS only reported App Tampering instead of ROOT.
    Ok, reverted Shamiko from 0.5.1 to 0.5.0, then App Tampering is gone too. So, everything back to normal for me (except Momo reporting Zygisk, which I don't care!)

    So Magisk 24.3, USNF latest, Shamiko previous (0.5.0) works for my device to defeat zIPS.

    Just some sharing :)
    1
    I had never done the Hide the Magisk app, but the issue does seem to involve remnants of something. The first time i tried to uninstall it (using Settings / Apps / Magisk), I then attempted to install via adb, and received a warning the app already existed. I then uninstalled via adb, and attempted to install after that (no warnings, but something still not working).

    Later, with 25.1 supposedly installed again, I noticed in F-Droid (I have never used F-Droid to install Magistk, but of couse it reports the existence of any app with the same name as one in its repository) that it still reported 24.3 installed. So, I used F-Droid to uninstall Magisk (why not?), but then, after reloading F-Droid, it still reported version "1.0" as installed. So, I uninstalled that as well, and F-Droid no longer reported any Magisk on the system. I searched through System / Apps (even with Show system enabled), and saw nothing that I did not recognize. I installed the 25.1 apk downloaded from github again, flashed the patched boot image again, and... same result (Magisk just shows as N/A).

    I do notice that if I attempt to install Magisk 25.1, I get the full app (Settings / Apps shows Magisk as 23.42 MB), but if I install 24.3 (working perfectly until a few hours ago), it initially shows as 22.80 MB, but the first time I attempt to start it, it crashes immediately, and then the icon changes to the generic Android icon, and the size in Settings / Apps changes to 224 KB.
    Assuming 25.1 binary is installed, this seems to be intended behaviour for 25.1+ daemon:
    • [General] Enforce the Magisk app to always match or be newer than magiskd
    (Commit:
    Force app version not lower than daemon)

    The device (a Teclast T10 tablet with the exact model number of E3C5) has the latest stock firmware (1.05_20180306) built from Android 7.0.
    This issue seems strange however, and may warrant a GitHub issue ticket... Do what you can to ensure no stub is installed first however...

    Type Magisk -c in terminal emulator to see Magisk binary version installed, or Magisk -v to see daemon version running...

    Note that since 16.6 we had
    • [Daemon] Check whether a valid Magisk Manager is installed on boot, if not, install stub APK embedded in magiskinit
    This has been working in older Magisk, but seems to be removed / broken in 25.x on my device... I'm guessing you've been getting stub installation on boot after removing full app w/ 24.3 binary installed...

    Anyway, check you are installing full app matching installed binary and stub is not present...

    Nb. There have be many recent tweaks for app loading, signature checks, stub functions etc, so you are ikely experiencing some regression... More changes are coming too, eg this is already merged in TJW master but not yet built in a release:
    Build dynamic stub resource APK at runtime ...
    Close #6013
    Co-authored-by: vvb2060
    topjohnwu and vvb2060 committed 8 days ago

    🤠 PW
    1
    Seems Rust is coming to Magisk injection for kernels 'real soon now' too... If Rust is a way to try something new, hopefully it works out for Magisk too... John's clearly been working on it a lot, so I really hope it works out... because we don't want to be given the bum's rush...

    😷 PW
    ... nor the bum's Rust.

    (Sorry, couldn't resist!)
  • 9
    Latest Official TJW Beta (release) Magisk build:

    Magisk

    2022.6.7 Magisk v25.0​

    Another major release! A lot of the changes aren’t visible at the surface, but v25 is actually a really substantial upgrade!

    MagiskInit Rewrite​

    A significant portion of magiskinit (the critical software that runs before your device boots up) is completely rewritten from scratch. Ever since Android introduced Project Treble in Android 8.0, Magisk has been constantly fighting against the increasingly complex partitioning and early mount setups of all kinds of devices, sometimes with weird OEM specific implementations. It got to a point that magiskinit had become so complicated that few people (including myself!) were aware of every detail, and maintaining this piece of software like this was clearly not sustainable. After many months of planning (yes, this whole re-architecture has been in my head for a long time) and some help from external contributors, a whole new sepolicy injection mechanism is introduced into Magisk, solving the “SELinux Problem” once and for all.

    Since this is a full paradigm shift on how Magisk hot-patch the device at boot, several behaviors that many developers implicitly relied on might not exist. For example, Magisk no longer patches fstabs in most scenarios, which means AVB will remain intact; some custom kernels rely on AVB being stripped out for them by Magisk.

    MagiskSU Security Enhancements​

    The superuser functionality of Magisk has not seen much changes ever since its introduction. v25 focuses on making root permission management more accurate and secure:

    • Add a whole new package tracking system to ensure malicious UID reuse attack cannot be performed
    • Properly support and implement the UX in the Magisk app for packages using sharedUserId
    • Enforce root manager APK signature verification to combat the rampant unofficial Magisk app “mods”
    Many might not realize, but using a trusted, unmodified Magisk app is really important. Magisk’s root daemon treats the Magisk app differently and gives it blanket root access without any restrictions. A modded Magisk app can potentially backdoor your device.

    And in case some of you are about to put on your tin foil hats, this is not designed to “vendor lock-in”; the goal is to make sure your root management app comes from the same developer of the underlying root implementation. Magisk’s build system allows custom distributors to use its own signing keys, and in addition, I am also providing official debug builds which skips any signature verification for development.

    Full Changelog: here

    Magisk Changelog​

    v25.0​

    • [MagiskInit] Update 2SI implementation, significantly increase device compatibility (e.g. Sony Xperia devices)
    • [MagiskInit] Introduce new sepolicy injection mechanism
    • [MagiskInit] Support Oculus Go
    • [MagiskInit] Support Android 13 GKIs (Pixel 6)
    • [MagiskBoot] Fix vbmeta extraction implementation
    • [App] Fix stub app on older Android versions
    • [App] [MagiskSU] Properly support apps using sharedUserId
    • [MagiskSU] Fix a possible crash in magiskd
    • [MagiskSU] Prune unused UIDs as soon as system_server restarts to prevent UID reuse attacks
    • [MagiskSU] Verify and enforce the installed Magisk app’s certificate to match the distributor’s signature
    • [MagiskSU] [Zygisk] Proper package management and detection
    • [Zygisk] Fix function hooking on devices running Android 12 with old kernels
    • [Zygisk] Fix Zygisk’s self code unloading implementation
    • [DenyList] Fix DenyList on shared UID apps
    • [BusyBox] Add workaround for devices running old kernels
    https://topjohnwu.github.io/Magisk/releases/25000.html

    🎉🎉 👍 PW
    7
    Latest Official TJW public Stable (release) Magisk build:

    Magisk

    Magisk Changelog​

    v25.1​

    • [MagiskBoot] Fix ramdisk backup being incorrectly skipped
    • [MagiskBoot] Add new feature to detect unsupported dtb and abort during installation
    • [Zygisk] Change binary hijack paths
    • [App] Fix incorrect recovery mode detection and installation
    • [MagiskInit] Fix config not properly exported in legacy SAR devices
    • [General] Enforce the Magisk app to always match or be newer than magiskd

    Release Notes:
    https://topjohnwu.github.io/Magisk/releases/25100.html

    For remaining diffs to public Stable 24.3, see Changelog for public Beta 25.0:
    https://forum.xda-developers.com/t/magisk-general-support-discussion.3432382/post-86993241

    🎉🎉 👍 PW
    6
    Thank you @zgfg and @ipdev . I have a fully working and automated script to both update my phone and patch & flash the magisk boot.img file. The only thing thats missing is the autoreboot after sideload but i guess TWRP has to implement this feature.

    The script can both be used as standalone or class to modify it for custom stuff. Ill continue to work on the repo and make everything neat, as well as working on windows and linux binarys & a gui for people that have no idea how to use scripts.

    Thank you guys for your help, this will save so much time for me and maybe even other people (at least i hope it will be used). :)

    Here it is on github
    6
    I've bought a Motorola Moto G71 5G. Unfortunately i cannot find a single thread about it on XDA. If i find it's stock ROM, what's the next steps to install magisk? How can i know that patching boot.img with magisk would work and not result in bootloop?
    You could opt for temporary root and check if it works or not. For that, boot your device via the Magisk patched boot file using the command-
    Code:
    fastboot boot magisk-patched-boot.img
    If everything's well and good, then open the Magisk app and select Direct Install. It will permanently root your device.
    However, if your device doesn't boot up, then retry with a force restart, it will be booted to the standard non-rooted OS.
    If you are still unable to boot to the OS, then flash the stock boot.img via
    Code:
    fastboot flash boot boot.img
    6
    Latest Official TJW Canary (release) & Debug (debug) Magisk builds:

    Magisk (34b2f525) (24316)​

    • [App] Fix stub app on older Android versions

    Diffs to v24.3​

    • [MagiskInit] Update 2SI implementation, significantly increase device compatibility (e.g. Sony Xperia devices)
    • [MagiskInit] Introduce new sepolicy injection mechanism
    • [MagiskInit] Support Oculus Go
    • [MagiskInit] Support Android 13 GKIs (Pixel 6)
    • [MagiskBoot] Fix vbmeta extraction implementation
    • [App] [MagiskSU] Properly support apps using shared UID
    • [App] Fix stub app on older Android versions
    • [MagiskSU] Fix a possible crash in magiskd
    • [MagiskSU] Prune unused UIDs as soon as possible to prevent UID reuse attacks
    • [MagiskSU] Verify and enforce the installed Magisk app's certificate to match the distributor's signature
    • [MagiskSU] Handle system_server restarts to prevent UID reuse abuse
    • [MagiskSU] [Zygisk] Proper package management and detection
    • [Zygisk] Fix function hooking on devices running Android 12 with old kernels
    • [Zygisk] Fix Zygisk's self code unloading implementation
    • [DenyList] Fix DenyList on shared UID apps
    • [BusyBox] Add workaround for devices running old kernels
    https://github.com/topjohnwu/magisk-files/blob/b4869a2d900721c508c974e5288edf29aee25e01/notes.md

    👍 PW
  • 1080
    This is the place for general support and discussion regarding "Public Releases", which includes both stable and beta releases.
    All information, including troubleshoot guides and notes, are in the Announcement Thread
    156
    Hello, I haven't given much support on XDA lately. It can be resulted from
    • University started and I have limited free time. In fact, I mostly develop during midnight
    • I live in Taiwan, which has large time zone differences between my European/American contributors/testers, which usually forces me to stay up late at night to discuss/test stuffs.
    • The new version is about to come, I don't want to spend effort on supporting old releases
    The planned update is delayed again and again, to some point I think I'll shed some light about what has been happening lately, also along with some announcements.

    New Forum!
    As you might have already discovered, Magisk got its own subforum on XDA! Many thanks to all the support you gave me, and much more information/features/support is about to come!
    **For developers supporting all the devices that are not using standard Android boot format, feel free to create threads in this section (actually, PLEASE do so) for your favorite devices after v7 is out. As I currently know, Asus devices require signing the boot image before flashing, and is model dependant; Sony devices seems to use ELF kernel that is unpatchable, or some has two ramdisks (inner + outer), both requires different workarounds; LG bootloader locked devices has to manually "BUMP" the boot image after flashing Magisk..... and there may be lots of other crazy boot image formats that haven't come up to my attention yet.
    It is impossible for me to support all these non-standard boot images, and I hope the community can collaborate to make Magisk running across all the devices. Overall, community collaboration is what XDA about :D

    The Pixel Phone
    Some of you might already know this news, that the next Pixel Phone right around the corner seems like it does not have ramdisk in boot image, which pretty much wrecked Magisk in all ways. However, it pretty much doomed root itself too. Kernel modifications is inevitable IMO, so I'll try to migrate my scripts to C programs that could possibly be included into the kernel itself. Note that I'm not familiar with linux kernel, I'm not even sure if my idea and concept is correct or not. But once the device is available, I think developers will find a way to bypass all the difficulties, and I'll do my best to learn things ;)

    Current Progress
    In the past month, I've spent quite some time learning SELinux, so that I can avoid using SuperSU's sepolicy patches. Thanks to the helps and tips from @phhusson and @Chainfire, I finally have a much clearer understanding of how SELinux works. The Magisk core parts (the scripts, boot image patches, new features, more supports) are actually done some time ago. What is causing all the delays is the Magisk Manager.
    To be completely honest, although I can code in Java without much issues, Magisk Manager is actually my first Android application, I had to reach out for assistance, and fortunately awesome developers like @DVDandroid and @digitalhigh contributed a lot, which makes the current Manager awesome.
    After the repo system and module management is mostly done, I was about to do some adjustments and release, but what we really done is decided to add another feature: auto-unroot with per-app settings. I decided to wait for it to be finished, and then do my adjustments. Due to reasons that'll be mentioned later, this feature will likely not be available for the next release (should come in future updates)

    Safety Net Disaster
    Those who are using Magisk for Safety Net bypass purposes must have known that Google recently updated the detection method of my Systemless Xposed. I still have no idea what Safety Net is detecting, so currently I cannot fix it on my side (also because I'm busy working on the next update). However, suhide developed by @Chainfire is able to hide Xposed and worked fine.
    However, only my Systemless Xposed v86.2, which is based on SuperSU's su.d, is supported using that method. v86.2 and v86.5 (latest, Magisk based) have nearly identical binaries, and the only difference is the path where the binaries are stored.
    I'm still not sure what's the real issue for it not being supported, I just hope it is not done intentionally.

    Conclusion
    Due to the fact that my Safety Net bypass is not 100% perfect now, I do not want to spend any more time waiting for auto-unroot to be polished. What I'm doing now is finishing up all the things I'd like to change in Magisk Manager (it has been a while since I last contributed to Manager, my fellow developers are doing all the heavy job), which might take a little more time, after that, packed with tons of information to be announced in Magisk Section, I'll release the long awaited update.

    Hope this lengthy post gives you the idea of the whole situation, and again thanks for all your support!!
    121
    Ah, some Chainfire bashing, I hope it is not too late for me to exercise additional villainy.

    First, let me make clear I have nothing against @topjohnwu, nor against Magisk. Magisk is an interesting project and it certainly displays @topjohnwu ingenuity and persistence. I don't doubt we will see more interesting things from his hands.

    -------------------------

    What has happened here is not all that dark and complicated, from either end. I returned from holidays, and someone pointed me at Magisk. My first thought: interesting!

    Among other things, the thread lists some issues with SuperSU, which in combination with the phrase The developer also requests users to not bug Chainfire with compatibility requests for SuperSU with Magisk from the portal article, raised my left eyebrow by nigh half an inch. The popular systemless xposed mod is apparently now based on it, and apparently it now no longer works with SuperSU, and apparently I'm not supposed to fix that, nor any of the other found issues. I found that a bit weird. So yes, I have told @topjohnwu that I was a bit surprised he was posting about issues with SuperSU without notifying me about them (I can't fix or help fix issues I'm not aware of, after all).

    He's also spreading a modified version of the SuperSU package, which is not all that uncommon, nor necessarily a problem. I have not looked into what he modified, I only ran a few quick tests on one of my devices, and found some commonly used commands run as root to be broken. I have informed him of this as well.

    It appears the tool of choice for Magisk is phh's Superuser, because of some of the mentioned issues with SuperSU. That's fine by itself, but fixing issues in that superuser by incorporating SuperSU's binaries into it is a somewhat questionable practise. After all, SuperSU is a commercial closed-source package that helps pay for my dinner, and superuser is a direct competitor. I have informed him that I was surprised he did this without asking for permission. I have expressed similar surprise on him spreading a modified version of LiveBoot (which helps pay for a snack now and then).
    @topjohnwu has also stated that Magisk's scripts are largely influenced by mine (I have not checked). Scripts based on mine are used all over the place on XDA, some people have crafted amazing things based on them, I have never made an issue of this (otherwise I would have just made them binaries). But yes, I have also stated to him that I don't think it's very nice to base something on one program, and then using that to (almost exclusively) push something directly competing with that program.

    tl;dr Towards @topjohnwu, I have:
    - expressed surprise he has issues getting Magisk to work with SuperSU, and has chosen not to inform me about those
    - expressed surprise he is using SuperSU binaries in a competing superuser without permission
    - expressed surprise he is posting a modified LiveBoot without permission
    - informed him of issues with the modified SuperSU he has posted
    - let him know I thought it wasn't very nice to be applying my scripts to benefit seemingly exclusively that same competing superuser

    To be crystal clear:
    - I have not asked for an apology
    - I have not asked for Magisk to be abandoned, neither the root hiding nor systemless module parts, and certainly not systemless xposed
    - I have not made an issue of any of this anywhere, until this post
    - I have not even specifically asked for anything to be taken down (though obviously in my opinion the other superuser package mixed with SuperSU's binaries, as well as the LiveBoot package, should go)
    - I have not reported this thread to XDA moderators for copyright violations or otherwise

    While my conversation with @topjohnwu may not win any awards for being friendly (though it may win some for brevity), I think all things considered my response has been rather mild. To be perfectly honest, until the apology post, I thought this was over with already. I think the apology post was triggered because I haven't replied to his last PM for a while - I was in the zone, it happens.

    To emphasize again, I have nothing against @topjohnwu, Magisk, or systemless xposed, and it is certainly not my goal to see any of them go. If it can be made to work together with SuperSU, great.

    I get it though: you think of something, you want to see if you can make it work, you finally get it to work, you publish it, it takes off - enthusiasm gets the better of you. Maybe in the rush some mistakes are made. That doesn't mean you have to just drop it and run. None of my stuff would make it past 0.1 if I stopped at the first big mistake :)

    Aside from said being in the zone coding, I usually regret actually responding to these sort of things the day after, which has made me hesitant to reply. Surprise me.
    76
    Thread temporarily closed so everyone sees this.

    The flood of "SafetyNet isn't working for me either!" posts are not helpful, at all. Please refrain from posting further, it will be looked into. Please do not forget that not passing SafetyNet is 100% NORMAL AND INTENDED when you have an unlocked booloader or running custom firmware. These are workarounds and they will be worked around in turn.

    The Flash
    Forum Moderator

    EDIT: Thread is reopened... I will be cleaning any SafetyNet posts for a while to keep the thread clean for real issues.
    75
    Hello everyone!

    I am aware that Google has updated Safety Net that makes Magisk itself a no go for Android Pay. In fact, I witnessed the change live while I am developing the new magiskhide, which should hide all Magisk modules and Magisk installed root.

    Google is serious about Safety Net now, clearly hunting down all possibility to run Xposed with Safety Net passed. I spend quite some time examining the new security measures last midnight, and fortunately it seems that it is possible to run Magisk and root along with Safety Net if no Xposed is running. I'm glad I removed the old root toggle at the right time lol, that is no longer feasible with the latest detection.

    So stay tuned for the next update, it will come with bug fixes, along with the new magiskhide to bypass that Safety Net.

    Google, how will a few systemless mods do any harm :p:p