There are apps that don't allow screenshots - like Chrome in Incognito mode, and there are solutions to trick them (to allow the so called Secure screenshots) - like Smali patcher (check-box Secure screenshots while patching)
Magisk General Support / Discussion
- Thread starter topjohnwu
- Start date
Trying to get a certain paranoid game to run, but it keep detecting root access.
I have updated to Magisk 24.1, got the SafetyNet Fix module (v2.2.1) as well as Shamiko (v0.3.0 (73)). Zygisk is enabled, DenyList is not enforced but I have ticked the necessary apps in the DenyList. There are two things that Momo still detects - "running a custom ROM" and "bootloader unlocked".
The first one is I assume due to part of the fingerprint that Momo is showing, which reveals the custom ROM maintainer:
Also not sure about the "bootloader unlocked" part, isn't that something the Universal SafetyNet Fix was supposed to help hide?
Is there anything I can do about these two detections?
I have updated to Magisk 24.1, got the SafetyNet Fix module (v2.2.1) as well as Shamiko (v0.3.0 (73)). Zygisk is enabled, DenyList is not enforced but I have ticked the necessary apps in the DenyList. There are two things that Momo still detects - "running a custom ROM" and "bootloader unlocked".
The first one is I assume due to part of the fingerprint that Momo is showing, which reveals the custom ROM maintainer:
but I'm not sure how to modify the second part of the fingerprint, I've tried using MagiskHide Props for that.
Also not sure about the "bootloader unlocked" part, isn't that something the Universal SafetyNet Fix was supposed to help hide?
Is there anything I can do about these two detections?
It's been discussed many,.many times.
Ib short, install e.g. YASNAC from Playstore (SN checker) and Fox Magisk Module Manager (search on Github)
E.g., scroll back to the post #50304 from last week
Last edited:
magisk hide has been replaced by shamiko
Magisk alpha
Releases · Fox2Code/FoxMagiskModuleManager
A module manager for Magisk because the official app dropped support for it - Fox2Code/FoxMagiskModuleManager
github.com
Hello J.Michael,sorry getting on TRWP which is off topic.As TRWP there is a version compatible with android 12 and I'm a little afraid of losing rooting of magisk,as is the case with the updates. has days of magisk currently.
Magisk can flash file images not like the modules, on my sd card on my s 10 I have this G97X_Splash_Screen_Changer_by_SoLdieR9312_black.zip which must be flashed with TRWP, can have to do the same for magisk as in this zip there are only images which covers the security messages at startup. If necessary, I put the zip files in attachments and you modify it.
Thank you
i'll take your reply to mean it is a must to have 'smali patcher for secure flag' module installed and enabled for getting screenshots in secure apps, regardless of denylist configuration.
Hi,
I've got stock rom Android 8 on my S7 edge and installed Magisk with TWRP (about a year ago). I restored apps from another phone with Migrate app, and I do not remember any particular problems. I also enabled some apps like total commander, termux, apps2sd to use superuser. (AFAIR there were pop-ups to grant them su access.)
However, recently after reboots there are messages that "MAgisk stops constantly: X Close". The registered apps seem to work properly, but the other apps (e.g. X-plore filemanager, Migrate) that would require root access don't. And there isn't ANY pop-ups to enable or register them for superuser access. They just report "root permission denied" or "the device seems not to be rooted".
The Magisk Manager log shows `su: cannot find manager` and `su: request rejected` messages.
Magisk was updated to 23.0 using direct install, and the Manager's version is 23.0, too.
Every hints are welcome...
EDIT: I removed everything completely from Magisk App and reboot to TWRP. Installed a saved magisk-22.0 zip and after reboot the apk of version 22.0. Finally, I have upgraded the app to 22.1 from the app itself. This seems to solve my problem.
EDIT2: It seems that v23.0 is working, too, (i.e. the root granting message pop-ups and the applications get registered into the Superuser list), if the Magisk App itself isn't "camouflage-ed" (see Settings).
I've got stock rom Android 8 on my S7 edge and installed Magisk with TWRP (about a year ago). I restored apps from another phone with Migrate app, and I do not remember any particular problems. I also enabled some apps like total commander, termux, apps2sd to use superuser. (AFAIR there were pop-ups to grant them su access.)
However, recently after reboots there are messages that "MAgisk stops constantly: X Close". The registered apps seem to work properly, but the other apps (e.g. X-plore filemanager, Migrate) that would require root access don't. And there isn't ANY pop-ups to enable or register them for superuser access. They just report "root permission denied" or "the device seems not to be rooted".
The Magisk Manager log shows `su: cannot find manager` and `su: request rejected` messages.
Magisk was updated to 23.0 using direct install, and the Manager's version is 23.0, too.
Every hints are welcome...
EDIT: I removed everything completely from Magisk App and reboot to TWRP. Installed a saved magisk-22.0 zip and after reboot the apk of version 22.0. Finally, I have upgraded the app to 22.1 from the app itself. This seems to solve my problem.
EDIT2: It seems that v23.0 is working, too, (i.e. the root granting message pop-ups and the applications get registered into the Superuser list), if the Magisk App itself isn't "camouflage-ed" (see Settings).
Last edited:
Latest -2109121100_Shamiko-v0.4.0-81-release
# Shamiko
<center>こっっ… これで勝ったと思うなよ―――!!</center>
### Introduction
Shamiko is a Zygisk module to hide Magisk root, Zygisk itself and Zygisk modules like riru hide.
Shamiko read the list of apps to hide from Magisk's denylist for simplicity but it requires denylist to be disabled first.
### Usage
1. Install Shamiko and enable Zygisk and reboot
1. Turn on denylist to configure denylist.
1. Once denylist is configured, disable it to activate Shamiko
### Changelog
#### 0.2.0
1. Support font modules since Android S
1. Fix module's description
#### 0.3.0
1. Support whitelist (enable by creating an empty file `/data/adb/shamiko/whitelist`)
1. Always unshare (useful for old platforms and isolated processes in new platforms)
1. Request Magisk 23017+, which allows us to strip Java daemon and change denylist regardless of enforcement status
1. Temporarily disable showing status in module description (need to find a new way for it)
1. Support module update since Magisk 23017
#### 0.4.0
1. Add module files checksum
1. Bring status show back
1. Add running status file at `/data/adb/shamiko/.tmp/status`
PW
# Shamiko
<center>こっっ… これで勝ったと思うなよ―――!!</center>
### Introduction
Shamiko is a Zygisk module to hide Magisk root, Zygisk itself and Zygisk modules like riru hide.
Shamiko read the list of apps to hide from Magisk's denylist for simplicity but it requires denylist to be disabled first.
### Usage
1. Install Shamiko and enable Zygisk and reboot
1. Turn on denylist to configure denylist.
1. Once denylist is configured, disable it to activate Shamiko
### Changelog
#### 0.2.0
1. Support font modules since Android S
1. Fix module's description
#### 0.3.0
1. Support whitelist (enable by creating an empty file `/data/adb/shamiko/whitelist`)
1. Always unshare (useful for old platforms and isolated processes in new platforms)
1. Request Magisk 23017+, which allows us to strip Java daemon and change denylist regardless of enforcement status
1. Temporarily disable showing status in module description (need to find a new way for it)
1. Support module update since Magisk 23017
#### 0.4.0
1. Add module files checksum
1. Bring status show back
1. Add running status file at `/data/adb/shamiko/.tmp/status`
PWwhere has it been releases? neither in TG group nor in Github if I am not wrong..Latest -2109121100_Shamiko-v0.4.0-81-release
# Shamiko
<center>こっっ… これで勝ったと思うなよ―――!!</center>
### Introduction
Shamiko is a Zygisk module to hide Magisk root, Zygisk itself and Zygisk modules like riru hide.
Shamiko read the list of apps to hide from Magisk's denylist for simplicity but it requires denylist to be disabled first.
### Usage
1. Install Shamiko and enable Zygisk and reboot
1. Turn on denylist to configure denylist.
1. Once denylist is configured, disable it to activate Shamiko
### Changelog
#### 0.2.0
1. Support font modules since Android S
1. Fix module's description
#### 0.3.0
1. Support whitelist (enable by creating an empty file `/data/adb/shamiko/whitelist`)
1. Always unshare (useful for old platforms and isolated processes in new platforms)
1. Request Magisk 23017+, which allows us to strip Java daemon and change denylist regardless of enforcement status
1. Temporarily disable showing status in module description (need to find a new way for it)
1. Support module update since Magisk 23017
#### 0.4.0
1. Add module files checksum
1. Bring status show back
1. Add running status file at `/data/adb/shamiko/.tmp/status`
I've just updated to the newest Magisk 24.1
And I've noticed that a banking app acted diffrently after. There was no option again to unlock it with fingerprint, and after opening in mentioned that the device was removed.
So I checked Magisk. And I noted that some things had changed (not paying attention to the changelog).
- Check SaftyNet is gone
- Magisk Hide is gone (but found out about this in the changelog already)
- And I had the possibility to search for modules in the app itself. But it seems I can not look for them annymore now and I can only install them from phone storage now?
I was not using Magisk that much, only to maintain some app functionalities that were gone by rooting. So it's looks a bit confusing to me now.
And I've noticed that a banking app acted diffrently after. There was no option again to unlock it with fingerprint, and after opening in mentioned that the device was removed.
So I checked Magisk. And I noted that some things had changed (not paying attention to the changelog).
- Check SaftyNet is gone
- Magisk Hide is gone (but found out about this in the changelog already)
- And I had the possibility to search for modules in the app itself. But it seems I can not look for them annymore now and I can only install them from phone storage now?
I was not using Magisk that much, only to maintain some app functionalities that were gone by rooting. So it's looks a bit confusing to me now.
Has anyone tried the whitelist option? Is it working like it defaults to hide all apps except those in the list (denylist)? So basically I just need to put those apps which need root access to the list?
I recall in the early implemetion of MagiskHide, people were saying that putting all apps in the hide list would make the system unstable, so would i'm a bit sceptical about this whilte list concept.
Any installation guide for oneplus 5 lineageOS 18.1?
I install the apk then exported the patched img file and flash through flashboot but magisk app still said was not installed.
I install the apk then exported the patched img file and flash through flashboot but magisk app still said was not installed.
Yup, I said that, and there are definitely limitations on passive timing for Magisk Daemon to hide many processes w/ MagiskHide... I also said I don't know if Zygisk overcomes this... It appears it does as these devs are not dumb!
Haven't tried whitelist in Shamiko; please report any successes...
PW
Sorry but 'good morning'. Changes are also written in the Changelog. Anyway, read the OP posts, also post #14 may help you
The game is changing. Now higher dimension of hiding the stuff
Attachments
Tested now Smali patcher, Secure screenshots, working in all combinations:
- Shamiko
- Enforce DenyList instead of Shamiko
- neither of them
Similar threads
Top Liked Posts
-
3Follow up to the @lindsaysxda case/discussion, some general comments, just to make things clear:
- Magisk app, formerly named Magisk Manager is still just a manager app or some kind of user interface for the Magisk
Therefore, it is possible to have Magisk app installed, but without Magisk. Ie, installing only the Magisk app does not mean that Magisk was installed
In the normal circumstances one would install in parallel both Magisk app and Magisk of the SAME version (like BOTH Stable 24300 or BOTH Canary 24313 or so)
Anyway, Magisk app displays both the version of Magisk (at the top) and Magisk app version below.
One SHOULD pay attention that they both show the same version (it doesn't display are they Stable, Canary etc, but it clearly displays the full version number like 24313 with the hex build like 8bfb30fe) - hence, MAKE SURE they both display the same version (and the same hex build id, although in fact they come in diff pairs)
It's possible to run with diff versions but no guarantee what kind of problems may happen if one would be substantially older than the other
Wen patching/direct installing/installing to inactive slot, Magisk app also clearly displays what is the target version - PAY ATTENTION that it prints the same target version as for your Magisk app running
---
If Magisk app displays N/A for the Magisk version it means that app (think again about as for the "manager') cannot find Magisk
It usually means that Magisk is not installed (yet or no more) - hence again, always PAY ATTENTION to that N/A case
There is also a possibility that Magisk is installed but user has two Magisk apps, ie also an old one, that was previously hidden/renamed but was not restored or deleted before updating to the new Magisk app - then only one of them can 'communicate' with Magisk and the other would display Magisk N/A - again something to be AWARE about and to be immediately resolved
---
Finally, if Magisk app displays Magisk N/A, it means that either Magisk is not installed or that app does not 'communicate' with - in either case the Magisk app has no root grant for itself and CANNOT do Direct install neither Install to inactive slots (hence it doesn't even display those options) - because ONLY with root, the app could patch the (live) boot partition (the active one or inactive one in case of A/B devices)
Without root, Magisk app can ONLY patch the boot image (file). User then has to flash himself the patched boot img:
- through Fastboot (recommended)
- through TWRP (applicable only to devices and Android versions with the TWRP available and 'fully'' working)
---
Btw, to cut-off my time and to avoid unnecessary booting the PC and device in Fastboot or TWRP mode, I usually flash my patched boot img through the Terminal app with:
Code:su dd if=/sdcard/Download/patched-boot.img of=/dev/block/bootdevice/by-name/boot reboot
Here, to make it easier and to be able to always copy/paste that same command (dd if=...), I first rename the every-time different patched boot img to always the same name: patched-boot.img
Also, on A/B device you would need to specify for of= to be boot_a or boot_b (you must know which one is active and do you want to patch the active or inactive boot partition)
Ofc, disk-dump (dd) requires root (su), hence this is not applicable to the Magisk N/A case2
Just to clarify this point:
Update Channel no longer controls Magisk (mask) installations... To change target Magisk version, App must be changed / updated first.
Since we got Single package Magisk distribution (22.0), Magisk (mask itself) is not affected by Update channel and will always patch image or direct install/install to inactive slot using embedded (build specific) binaries. Ie. App Installed is always the target version for Magisk Install and this is regardless of Update channel...
This is also because we now also have entirely offline installation; Magisk doesn't call web hosted Magisk binaries any more and the APK package binaries are always called. Each APK only contains one corresponding set of binaries, so even if Debug channel is set and App Installed is 24313 for instance, Magisk Install will still call Canary 24313 binaries if Canary App was/is installed AFAIK... Users need to take Install App first if changing channel... An issue here is that knowing whether Debug or Canary is installed depends on users memory ATM AFAICS; a better naming convention may be needed to differentiate new Debug from Canary UIMS (unless I'm missing something).
This does mean that for in-app installation at least, Magisk (mask) will always match installed App if updated property as user now needs to update App before taking a Magisk (mask) update. (App will always be same version as Magisk (mask) or a later later version (if only App is updated), unless an app is downloaded and installed manually).
PW2@lindsaysxda
Hi.
I spent tonight testing something completely different on my Pixel 5a.
boot-looping and/or running into RED-boot.
Since I have been borking my Pixel 5a all night, I decided to give it a try.
I normally update manually. Only use OTA(s) when I have to.
I clean flashed Lineage 19.1 20220505 (barbet).
Installed Magisk (app) and patched the boot image.
Pulled the patched boot image.
Rebooted into fastboot (bootloader), flashed the patched boot image and rebooted.
Hid (renamed) the Magisk app and then took the newest Lineage OTA for barbet (20220519).
Download was quick but, it took longer than I expected to install.Once done, I opened the Magisk (app) and used the patch-other-slot option.
I closed the Magisk (app) and went back to the OTA update and selected reboot.
It rebooted and I was on the 20220519 build with Magisk active (the new boot image was patched).
Magisk (app) was still hidden (renamed) and all was good.
At least one test I did tonight worked.
---
I might be wrong but, I thought you only had to uninstall/restore images for Factory/OEM ROM(s).
OnePlus used to download the full OTA instead of a partial OTA when "root" was detected.
Not sure if that is still the case.
Custom ROM(s) like Lineage, normally are not affected by root (Magisk).
Sorry if I missed it but, what device are you using?
Cheers.
1
Why are you just being difficult?
We are trying to help you to analyse a curly issue... You should admit that your own understanding has been somewhat lacking (sufficiently understated?) and try to understand what others are telling you...
I'd actually like to understand you issue too, but I don't like dealing with attitude, so I'm loosing interest... PW1@pndwal
Meanwhile i borked the latest update...temporarily - totally self inflicted and my fault, hence qualifies for a Spanner Award
Unhid the Magisk app
Updated app
Direct Installed magisk
Rebooted
Went to hide the app, gave it a shortcut name (i just call mine App) and hit the button, and just at that moment a notification popped up and lost the Magisk app window
Went back to drawer - nova can stay on page if you like it to, i do...but on this occasion as you will see if i hadnt had this turned on i might have noticed i had an issue and figured it out earlier and just deleted the duplicate (explanation coming)
Still had a Magisk app in the drawer, so assumed it had failed, so repeated the process....worked ...and no more Magisk app.
So i go to look for "App" and theres two...
One opens and looks normal apart from the Zygisk: No
The other prompts to complete full install of Magisk
Well thats fun....
Unhid the one that opened, uninstalled the remaining "App" and rebooted
Waited a few minutes
Hid the proper remaining Magisk to "App" and rebooted
Zygisk said : Yes
Happy Days!
Takeaway/Moral of this story:
Kids, dont do what daddy did and try and hide the Magisk app immediately after reboot, let the system settle, because this was entirely my fault for rushing things
Sometimes life really is like a box of Ponkles, you never know what youre going to get.... -
76
Latest Official TJW debug Canary Magisk:
Magisk (cc79a96f) (24307)
- [App] Update libsu with 100% new I/O layer
- [MagiskInit] Mock enforce file with regular file to prevent possible race condition
- Switch normal NDK with ONDK, preparing the toolchain to introduce Rust
Diffs to v24.3
- [MagiskInit] Update 2SI implementation, significantly increase device compatibility (e.g. Sony Xperia devices)
- [MagiskInit] Introduce new sepolicy injection mechanism
- [MagiskInit] Support Oculus Go
- [App] [MagiskSU] Properly support apps using shared UID
- [MagiskSU] Fix a possible crash in magiskd
- [Zygisk] Fix function hooking on devices running Android 12 with old kernels
- [BusyBox] Add workaround for devices running old kernels
PW6Latest Official TJW debug Canary Magisk:
Magisk (985249c3) (24309)
Pixel 6 Android 13 Beta 2 support is here!
- [App] Support requesting root from non app process
- [App] Fix deadlocking a background thread on non-root devices
- [MagiskInit] Support GKIs with no ramdisk (Pixel 6 Android 13)
Diffs to v24.3
- [MagiskInit] Update 2SI implementation, significantly increase device compatibility (e.g. Sony Xperia devices)
- [MagiskInit] Introduce new sepolicy injection mechanism
- [MagiskInit] Support Oculus Go
- [MagiskInit] Support GKIs with no ramdisk (Pixel 6 Android 13)
- [App] [MagiskSU] Properly support apps using shared UID
- [MagiskSU] Fix a possible crash in magiskd
- [Zygisk] Fix function hooking on devices running Android 12 with old kernels
- [BusyBox] Add workaround for devices running old kernels
PW6
libsu 5.0.0 is out!Looks like major libsu release is now imminent; most fixes are now merged.
Should see major stability improvements in Magisk and root app implementation... Should see new commits for Magisk proper again soon too!
John has made some major libsu changes (see libsu GitHub).
Here are extra comments on vvb2060 fixes from her TG (Chinese translated....
PW
libsu/CHANGELOG.md
5.0.0
Check the updated Javadoc and the example app for details on how to use the remote file system in the new nio module.
New Features
- Introduce a new module: nio
- Includes file system implementations for local and remote processes
- New FileSystemManager class to access either local or remote file system implementations
- New ExtendedFile class to extend functionality of the old Java File API
- [core] New API Shell.isAppGrantedRoot() returns a nullable Boolean:
- true if a root shell has been created
- false if it has been determined that root access is impossible to get
- null if the library has not, or could not determine the current root grant state. Future invocations of this method may return a non-null value if the library gained more information during shell creation.
- [core] New API Shell.Builder.setContext(context): allow the developer to explicitly provide a Context object
- [io] SuFile is updated to also extend ExtendedFile, which adds some new features and APIs
Deprecation
- Version 5.0.0 will be the final release of the busybox module. If you cannot remove the usage of the module, you can pin the busybox module to version 5.0.0, as it is updated to be fully self contained, making it guaranteed to work with future libsu versions.
- Usage of SuFile/SuFileOutputStream/SuFileInputStream/SuRandomAccessFile is discouraged. Although these APIs will remain for the foreseeable future, please migrate to use RootService + the nio module for all root I/O operations.
- Shell.rootAccess() is deprecated. Please switch to use the more accurate Shell.isAppGrantedRoot() API
New readme etc. Read how you can Attach Debugger to Android Process in Root Services and more!
https://github.com/topjohnwu/libsu
... Back to regular Magisk programming... PW5Latest Official TJW debug Canary Magisk:
Magisk (42e5f515) (24308)
- Several minor bug fixes
Diffs to v24.3
- [MagiskInit] Update 2SI implementation, significantly increase device compatibility (e.g. Sony Xperia devices)
- [MagiskInit] Introduce new sepolicy injection mechanism
- [MagiskInit] Support Oculus Go
- [App] [MagiskSU] Properly support apps using shared UID
- [MagiskSU] Fix a possible crash in magiskd
- [Zygisk] Fix function hooking on devices running Android 12 with old kernels
- [BusyBox] Add workaround for devices running old kernels
PW -
1077This is the place for general support and discussion regarding "Public Releases", which includes both stable and beta releases.
All information, including troubleshoot guides and notes, are in the Announcement Thread156Hello, I haven't given much support on XDA lately. It can be resulted from
- University started and I have limited free time. In fact, I mostly develop during midnight
- I live in Taiwan, which has large time zone differences between my European/American contributors/testers, which usually forces me to stay up late at night to discuss/test stuffs.
- The new version is about to come, I don't want to spend effort on supporting old releases
New Forum!
As you might have already discovered, Magisk got its own subforum on XDA! Many thanks to all the support you gave me, and much more information/features/support is about to come!
**For developers supporting all the devices that are not using standard Android boot format, feel free to create threads in this section (actually, PLEASE do so) for your favorite devices after v7 is out. As I currently know, Asus devices require signing the boot image before flashing, and is model dependant; Sony devices seems to use ELF kernel that is unpatchable, or some has two ramdisks (inner + outer), both requires different workarounds; LG bootloader locked devices has to manually "BUMP" the boot image after flashing Magisk..... and there may be lots of other crazy boot image formats that haven't come up to my attention yet.
It is impossible for me to support all these non-standard boot images, and I hope the community can collaborate to make Magisk running across all the devices. Overall, community collaboration is what XDA about
The Pixel Phone
Some of you might already know this news, that the next Pixel Phone right around the corner seems like it does not have ramdisk in boot image, which pretty much wrecked Magisk in all ways. However, it pretty much doomed root itself too. Kernel modifications is inevitable IMO, so I'll try to migrate my scripts to C programs that could possibly be included into the kernel itself. Note that I'm not familiar with linux kernel, I'm not even sure if my idea and concept is correct or not. But once the device is available, I think developers will find a way to bypass all the difficulties, and I'll do my best to learn things
Current Progress
In the past month, I've spent quite some time learning SELinux, so that I can avoid using SuperSU's sepolicy patches. Thanks to the helps and tips from @phhusson and @Chainfire, I finally have a much clearer understanding of how SELinux works. The Magisk core parts (the scripts, boot image patches, new features, more supports) are actually done some time ago. What is causing all the delays is the Magisk Manager.
To be completely honest, although I can code in Java without much issues, Magisk Manager is actually my first Android application, I had to reach out for assistance, and fortunately awesome developers like @DVDandroid and @digitalhigh contributed a lot, which makes the current Manager awesome.
After the repo system and module management is mostly done, I was about to do some adjustments and release, but what we really done is decided to add another feature: auto-unroot with per-app settings. I decided to wait for it to be finished, and then do my adjustments. Due to reasons that'll be mentioned later, this feature will likely not be available for the next release (should come in future updates)
Safety Net Disaster
Those who are using Magisk for Safety Net bypass purposes must have known that Google recently updated the detection method of my Systemless Xposed. I still have no idea what Safety Net is detecting, so currently I cannot fix it on my side (also because I'm busy working on the next update). However, suhide developed by @Chainfire is able to hide Xposed and worked fine.
However, only my Systemless Xposed v86.2, which is based on SuperSU's su.d, is supported using that method. v86.2 and v86.5 (latest, Magisk based) have nearly identical binaries, and the only difference is the path where the binaries are stored.
I'm still not sure what's the real issue for it not being supported, I just hope it is not done intentionally.
Conclusion
Due to the fact that my Safety Net bypass is not 100% perfect now, I do not want to spend any more time waiting for auto-unroot to be polished. What I'm doing now is finishing up all the things I'd like to change in Magisk Manager (it has been a while since I last contributed to Manager, my fellow developers are doing all the heavy job), which might take a little more time, after that, packed with tons of information to be announced in Magisk Section, I'll release the long awaited update.
Hope this lengthy post gives you the idea of the whole situation, and again thanks for all your support!!121Ah, some Chainfire bashing, I hope it is not too late for me to exercise additional villainy.
First, let me make clear I have nothing against @topjohnwu, nor against Magisk. Magisk is an interesting project and it certainly displays @topjohnwu ingenuity and persistence. I don't doubt we will see more interesting things from his hands.
-------------------------
What has happened here is not all that dark and complicated, from either end. I returned from holidays, and someone pointed me at Magisk. My first thought: interesting!
Among other things, the thread lists some issues with SuperSU, which in combination with the phrase The developer also requests users to not bug Chainfire with compatibility requests for SuperSU with Magisk from the portal article, raised my left eyebrow by nigh half an inch. The popular systemless xposed mod is apparently now based on it, and apparently it now no longer works with SuperSU, and apparently I'm not supposed to fix that, nor any of the other found issues. I found that a bit weird. So yes, I have told @topjohnwu that I was a bit surprised he was posting about issues with SuperSU without notifying me about them (I can't fix or help fix issues I'm not aware of, after all).
He's also spreading a modified version of the SuperSU package, which is not all that uncommon, nor necessarily a problem. I have not looked into what he modified, I only ran a few quick tests on one of my devices, and found some commonly used commands run as root to be broken. I have informed him of this as well.
It appears the tool of choice for Magisk is phh's Superuser, because of some of the mentioned issues with SuperSU. That's fine by itself, but fixing issues in that superuser by incorporating SuperSU's binaries into it is a somewhat questionable practise. After all, SuperSU is a commercial closed-source package that helps pay for my dinner, and superuser is a direct competitor. I have informed him that I was surprised he did this without asking for permission. I have expressed similar surprise on him spreading a modified version of LiveBoot (which helps pay for a snack now and then).
@topjohnwu has also stated that Magisk's scripts are largely influenced by mine (I have not checked). Scripts based on mine are used all over the place on XDA, some people have crafted amazing things based on them, I have never made an issue of this (otherwise I would have just made them binaries). But yes, I have also stated to him that I don't think it's very nice to base something on one program, and then using that to (almost exclusively) push something directly competing with that program.
tl;dr Towards @topjohnwu, I have:
- expressed surprise he has issues getting Magisk to work with SuperSU, and has chosen not to inform me about those
- expressed surprise he is using SuperSU binaries in a competing superuser without permission
- expressed surprise he is posting a modified LiveBoot without permission
- informed him of issues with the modified SuperSU he has posted
- let him know I thought it wasn't very nice to be applying my scripts to benefit seemingly exclusively that same competing superuser
To be crystal clear:
- I have not asked for an apology
- I have not asked for Magisk to be abandoned, neither the root hiding nor systemless module parts, and certainly not systemless xposed
- I have not made an issue of any of this anywhere, until this post
- I have not even specifically asked for anything to be taken down (though obviously in my opinion the other superuser package mixed with SuperSU's binaries, as well as the LiveBoot package, should go)
- I have not reported this thread to XDA moderators for copyright violations or otherwise
While my conversation with @topjohnwu may not win any awards for being friendly (though it may win some for brevity), I think all things considered my response has been rather mild. To be perfectly honest, until the apology post, I thought this was over with already. I think the apology post was triggered because I haven't replied to his last PM for a while - I was in the zone, it happens.
To emphasize again, I have nothing against @topjohnwu, Magisk, or systemless xposed, and it is certainly not my goal to see any of them go. If it can be made to work together with SuperSU, great.
I get it though: you think of something, you want to see if you can make it work, you finally get it to work, you publish it, it takes off - enthusiasm gets the better of you. Maybe in the rush some mistakes are made. That doesn't mean you have to just drop it and run. None of my stuff would make it past 0.1 if I stopped at the first big mistake
Aside from said being in the zone coding, I usually regret actually responding to these sort of things the day after, which has made me hesitant to reply. Surprise me.76Thread temporarily closed so everyone sees this.
The flood of "SafetyNet isn't working for me either!" posts are not helpful, at all. Please refrain from posting further, it will be looked into. Please do not forget that not passing SafetyNet is 100% NORMAL AND INTENDED when you have an unlocked booloader or running custom firmware. These are workarounds and they will be worked around in turn.
The Flash
Forum Moderator
EDIT: Thread is reopened... I will be cleaning any SafetyNet posts for a while to keep the thread clean for real issues.75Hello everyone!
I am aware that Google has updated Safety Net that makes Magisk itself a no go for Android Pay. In fact, I witnessed the change live while I am developing the new magiskhide, which should hide all Magisk modules and Magisk installed root.
Google is serious about Safety Net now, clearly hunting down all possibility to run Xposed with Safety Net passed. I spend quite some time examining the new security measures last midnight, and fortunately it seems that it is possible to run Magisk and root along with Safety Net if no Xposed is running. I'm glad I removed the old root toggle at the right time lol, that is no longer feasible with the latest detection.
So stay tuned for the next update, it will come with bug fixes, along with the new magiskhide to bypass that Safety Net.
Google, how will a few systemless mods do any harm
