Magisk General Support / Discussion

Search This thread
By:
Advanced…
M

martyfender

Senior Member
Mar 9, 2017
3,256
1,737
Indianapolis, IN
I have 2 Onn 8 first gen tablets with Android 9. One has a newer Android patch date. They both are on the latest magisk alpha. They both have the latest shamiko, lsposed, USF and hidemyapplist. With the latest two momo updates the newer tablet reports: found zygisk and bootloader unlocked. On the older tablet momo reports: found zygisk and TEE broken. Both devices are playstore certified and pass safetynet with evaluation type basic.

Does anyone know what TEE broken means and if there is a solution for it? I do know TEE means trusted execution environment. DRM info Shows Widevine security level at L3 on both devices.

Thanks
 
Last edited:
P

pndwal

Senior Member
Jun 23, 2016
4,494
4,633
Sydney
Redmi Note 8
Xiaomi Redmi Note 8 (2021)
martyfender said:
I have 2 Onn 8 first gen tablets with Android 9. One has a newer Android patch date. They both are on the latest magisk alpha. They both have the latest shamiko, lsposed, USF and hidemyapplist. With the latest two momo updates the newer tablet reports: found zygisk and bootloader unlocked. On the older tablet momo reports: found zygisk and TEE broken. Both devices are playstore certified and pass safetynet with evaluation type basic.

Does anyone know what TEE broken means and if there is a solution for it? I do know TEE means trusted execution environment. DRM info Shows Widevine security level at L3 on both devices.

Thanks
Click to expand...
Click to collapse
People are lately reporting this on TG for various Meizu and OnePlus, Xiaomi Lavender, also aware of Infinix, Xiaomi Poco, and now Onn...

We knew OnePlus messed up keymaster implementation:
www.twitter.com/topjohnwu/status/1237656704537395201

and seems many more OEMs did...

Seems Onn may have patched this issue with an update for your device if both you have are identical...

Some are reporting still having L1 widevine security, so I'm guessing actual TEE OS itself may be ok while HKA to TEE (uses the key pairs) is broken; test for those users will be to decode HD video in Netflix etc; seems OnePlus w/ 'broken TEE' can still do this (uses OS in TEE).

Since L1 security depends on certifying for widevine DRM w/ Google as well as soc compatible w/ HDCP (High-bandwidth Digital Content), you device likely never qualified for L1 anyway.

It could be that Momo is misreporting; the test is new after all, however I've seen no reason to suspect it's not good as yet...

Assuming the MOMO test is good, the sheer volume of devices with bad OEM TEE (attestation only?) has probably contributed to the long time it's taken for Google to get the 'critical mass' of devices w/ keymaster 3 (Android 8+) working properly in order to fully deploy HKA... Ie your broken key attestation is probably what's keeping MagiskHide solutions alive for all of us! ... So thanks mate. 👍 PW
 
  • Like
Reactions: martyfender
X

xdMatthewbx

Member
Jan 3, 2020
23
6
Toronto
Are there modules for hiding files/folders from apps (scoped storage changed nothing I tried it)? I'd like to not have TWRP files found in Momo but renaming the TWRP folder has the issue of now when I boot TWRP my saved settings are gone. I'd prefer to hide it, not delete it. This would also be ideal for hiding custom ROM. Note that overlayfs does not work as a solution since that not only causes Momo to detect overlayfs itself but also Zygisk (using latest Shamiko 0.5.0 112, UNSF, Zygisk without enforce, Momo on denylist).
 
P

pndwal

Senior Member
Jun 23, 2016
4,494
4,633
Sydney
Redmi Note 8
Xiaomi Redmi Note 8 (2021)
xdMatthewbx said:
Are there modules for hiding files/folders from apps (scoped storage changed nothing I tried it)? I'd like to not have TWRP files found in Momo but renaming the TWRP folder has the issue of now when I boot TWRP my saved settings are gone. I'd prefer to hide it, not delete it. This would also be ideal for hiding custom ROM.
Click to expand...
Click to collapse
Sounds like the domain of Rikka's 'Srorage Isolation' (formerly StorageRedirect)
https://sr.rikka.app/
(See guide in menu), or 'sandboxing' apps like Island, Shelter, Insular...

Nb. I haven't used any of these solutions myself. Those with experience may be of more help.
xdMatthewbx said:
Note that overlayfs does not work as a solution since that not only causes Momo to detect overlayfs itself but also Zygisk (using latest Shamiko 0.5.0 112, UNSF, Zygisk without enforce, Momo on denylist).
Click to expand...
Click to collapse
Seems mileage for hiding Zygisk w/ Shamiko varies with device...

👀 PW
 
P

pndwal

Senior Member
Jun 23, 2016
4,494
4,633
Sydney
Redmi Note 8
Xiaomi Redmi Note 8 (2021)
martyfender said:
I have 2 Onn 8 first gen tablets with Android 9. One has a newer Android patch date. They both are on the latest magisk alpha. They both have the latest shamiko, lsposed, USF and hidemyapplist. With the latest two momo updates the newer tablet reports: found zygisk and bootloader unlocked. On the older tablet momo reports: found zygisk and TEE broken. Both devices are playstore certified and pass safetynet with evaluation type basic...
Click to expand...
Click to collapse
Out of interest, if you disable USNF on both devices and reboot, does 'broken TEE' one still give Basic evaluation type in YASNAC? (expected as bad keymaster implementation should cause SafetyNet to fall back to Basic attestation type)... And Basic also on the other one?...

- I'm curious if both use Basic type w/o USNF as I expect Google will have removed this device from the list of devices (whitelist) that are known by Google to support HKA (Hardware backed cryptographic Key Attestation) after testing failed, but may have restored the listing once a patch/fix became available... This is is a different fall-back* implemented using model prop(s).

Please report if you do this test.

* Nb. Either of these fall-back types, (1) keymaster failure and (2) no Model prop match, will result in Basic attestation reported in apps like YASNAC, but Hardware attestation may actually still be enforced by its counterpart. Where this is the case, passing CTS Profile match may be impossible even with Basic attestation reported.
- I believe this is a shortcoming of Safety net checking apps. - Really they should only indicate Basic for Evaluation type when both fall-backs are triggered since only then will Basic attestation work and HKA be fully disengaged...
- In any case, USNF overcomes this by both registering a fake keystore provider that causes Play Services to throw an exception resulting in (1), and appending a space character to model prop value causing a mismatch with whitelist resulting in (2).

🙃 PW
 
Last edited:
M

martyfender

Senior Member
Mar 9, 2017
3,256
1,737
Indianapolis, IN
pndwal said:
Out of interest, if you disable USNF on both devices and reboot, does 'broken TEE' one still give Basic evaluation type in YASNAC? (expected as bad keymaster implementation should cause SafetyNet to fall back to Basic attestation type)... And Basic also on the other one?...

- I'm curious if both use Basic type w/o USNF as I expect Google will have removed this device from the list of devices (whitelist) that are known by Google to support HKA (Hardware backed cryptographic Key Attestation) after testing failed, but may have restored the listing once a patch/fix became available... This is is a different fall-back* implemented using model prop(s).

Please report if you do this test.

* Nb. Either of these fall-back types, (1) keymaster failure and (2) no Model prop match, will result in Basic attestation reported in apps like YASNAC, but Hardware attestation may actually still be enforced by its counterpart. Where this is the case, passing CTS Profile match may be impossible even with Basic attestation reported.
- I believe this is a shortcoming of Safety net checking apps. - Really they should only indicate Basic for Evaluation type when both fall-backs are triggered since only then will Basic attestation work and HKA be fully disengaged...
- In any case, USNF overcomes this by both registering a fake keystore provider that causes Play Services to throw an exception resulting in (1), and appending a space character to model prop value causing a mismatch with whitelist resulting in (2).

🙃 PW
Click to expand...
Click to collapse
If I disable USF module, both basic integrity and cts profile match fail. Evaluation type is BASIC. The device still shows certified in the playstore. This was on the older device:
ONA19TB002, security patch level 2019-04-05.
Although the hardware appears to be the same reported in AIDA64, with the same Android version and kernel version, the model number is 100005207, with a security patch level of 2020-03-05.

I get the same results with safetynet in YASNAC on the newer device.

If I recall correctly, both of these devices passed safetynet, way back in the past, before google changes with Magisk installed, without the USF module.
 
Last edited:
  • Like
Reactions: pndwal
F

Fry-kun

Senior Member
Sep 19, 2012
146
22
Google Pixel 4 XL
Google Pixel 6 Pro
Successful upgrade on Pixel 6 Pro
from: raven-sp2a.220405.004
to: raven-sp2a.220505.002

Procedure to reduce # of steps & time spent:
* Latest canary Magisk already installed (24310)
* raven-sp2a.220505.002 (Factory/full) downloaded & extracted
1 Modify flash-all.sh (since I'm on Linux) to remove "-w" from the last line to avoid erasing my user data
2 Extract boot.img from the inner .zip
3 adb push boot.img /sdcard/Download/boot.ini
4 (still on the old image) Patch Magisk to this boot.img
5 adb pull /sdcard/Download/magisk_patched-****.img (full filename is printed in magisk after patching)
6 adb reboot bootloader
6.5 (sanity check) verify flash-all.sh doesn't have "-w"
7 ./flash-all.sh
8 watch the output and when it finishes, hold volume down on the phone as it reboots -- this will take the phone back to fastboot mode without a full system boot with stock kernel
9 in fastboot mode: fastboot flash boot magisk_patched-*.img (same as pulled in step 5)

I've used this procedure a bunch of times (on earlier versions), and it only (kind of) failed once when I wasn't using Canary Magisk (was at the time apparently necessary for Android 12).
Hope it helps; IIRC, a bunch of tutorials have you boot into stock kernel, and patch the boot image from there -- it's really not necessary if the Magisk version is the same before & after. Also, I haven't needed to re-patch vbmeta since original rooting (no need for --disable-verity --disable-verification either)
 
Last edited:
  • Like
Reactions: ipdev and zgfg
zgfg

zgfg

Senior Member
Oct 10, 2016
7,397
4,792
xdMatthewbx said:
I'd like to not have TWRP files found in Momo but renaming the TWRP folder has the issue of now when I boot TWRP my saved settings are gone.
Click to expand...
Click to collapse
Long ago (mid of last year when we started to play here with Magisk v24 prereleases and Momo etc) I 'hid' TWRP folder by renaming to TWRP.back and TWRP 3.6.1 finds its settings with no problem. Simple and working fine for me
 
  • Like
Reactions: J.Michael
badabing2003

badabing2003

Senior Member
Sep 17, 2012
813
592
Fry-kun said:
Successful upgrade on Pixel 6 Pro
from: raven-sp2a.220405.004
to: raven-sp2a.220505.002

Procedure to reduce # of steps & time spent:
* Latest canary Magisk already installed (24310)
* raven-sp2a.220505.002 (Factory/full) downloaded & extracted
1 Modify flash-all.sh (since I'm on Linux) to remove "-w" from the last line to avoid erasing my user data
2 Extract boot.ini from the inner .zip
3 adb push boot.ini /sdcard/Download/boot.ini
4 (still on the old image) Patch Magisk to this boot.ini
5 adb pull /sdcard/Download/magisk_patched-****.img (full filename is printed in magisk after patching)
6 adb reboot bootloader
6.5 (sanity check) verify flash-all.sh doesn't have "-w"
7 ./flash-all.sh
8 watch the output and when it finishes, hold volume down on the phone as it reboots -- this will take the phone back to fastboot mode without a full system boot with stock kernel
9 in fastboot mode: fastboot flash boot magisk_patched-*.img (same as pulled in step 5)

I've used this procedure a bunch of times (on earlier versions), and it only (kind of) failed once when I wasn't using Canary Magisk (was at the time apparently necessary for Android 12).
Hope it helps; IIRC, a bunch of tutorials have you boot into stock kernel, and patch the boot image from there -- it's really not necessary if the Magisk version is the same before & after. Also, I haven't needed to re-patch vbmeta since original rooting (no need for --disable-verity --disable-verification either)
Click to expand...
Click to collapse
Considering that you'd have to watch and time when you have to press the volume key, you can replace the
-w with --skip-reboot.
If I'm not mistaken in one the several reboots that flashing does, the phone is placed in fastbootd mode, and you probably don't want to press the volume key when that is happening.
Easier yet you can use PixelFlasher that does all the steps above.

By the way I think auto-corrector played a trick on you, it's boot.img not boot.ini.
 
  • Like
Reactions: ipdev
P

pndwal

Senior Member
Jun 23, 2016
4,494
4,633
Sydney
Redmi Note 8
Xiaomi Redmi Note 8 (2021)
Latest (not really... 24312's out...) NEW Official TJW Canary (release) & Debug (debug) Magisk builds:

Magisk (dc65a2b8) (24311)​

  • Introduce new debug channel. Canary builds are now built in release mode, and debug builds are now required for bug reports.

Diffs to v24.3​

  • [MagiskInit] Update 2SI implementation, significantly increase device compatibility (e.g. Sony Xperia devices)
  • [MagiskInit] Introduce new sepolicy injection mechanism
  • [MagiskInit] Support Oculus Go
  • [MagiskInit] Support GKIs with no ramdisk (Pixel 6 Android 13)
  • [MagiskBoot] Fix vbmeta extraction implementation
  • [App] [MagiskSU] Properly support apps using shared UID
  • [MagiskSU] Fix a possible crash in magiskd
  • [Zygisk] Fix function hooking on devices running Android 12 with old kernels
  • [BusyBox] Add workaround for devices running old kernels
https://github.com/topjohnwu/magisk-files/blob/40582aaa15e6a5031f847a5f594c0703099cbcf2/notes.md

👍 PW
 
Last edited:
P

pndwal

Senior Member
Jun 23, 2016
4,494
4,633
Sydney
Redmi Note 8
Xiaomi Redmi Note 8 (2021)
Latest Official TJW Canary (release) & Debug (debug) Magisk builds:

Magisk (756d8356) (24312)​

  • Introduce new debug channel. Canary builds are now built in release mode, and debug builds are now required for bug reports.

Diffs to v24.3​

  • [MagiskInit] Update 2SI implementation, significantly increase device compatibility (e.g. Sony Xperia devices)
  • [MagiskInit] Introduce new sepolicy injection mechanism
  • [MagiskInit] Support Oculus Go
  • [MagiskInit] Support GKIs with no ramdisk (Pixel 6 Android 13)
  • [MagiskBoot] Fix vbmeta extraction implementation
  • [App] [MagiskSU] Properly support apps using shared UID
  • [MagiskSU] Fix a possible crash in magiskd
  • [Zygisk] Fix function hooking on devices running Android 12 with old kernels
  • [BusyBox] Add workaround for devices running old kernels
https://github.com/topjohnwu/magisk-files/blob/eb166b87765ad8755df859e1e6d8749a28cc06cb/notes.md

This includes minor fix:
Show canary channel option on canary builds

👍 PW
 
Last edited:
  • Like
Reactions: tramp20
P

pndwal

Senior Member
Jun 23, 2016
4,494
4,633
Sydney
Redmi Note 8
Xiaomi Redmi Note 8 (2021)
pndwal said:
Latest Official TJW debug Canary Magisk:

Magisk (756d8356) (24312)​

  • Introduce new debug channel. Canary builds are now built in release mode, and debug builds are now required for bug reports.
Click to expand...
Click to collapse
I'm guessing that this paves the way for John to integrate this rather controversial debugging tool c/o vvb2060 -
Add appcenter #5291 otherwise known as Microsoft AppCentre aka telemetry (ie debug-Magisk phone home)*...

Rather nice solution allowing users wanting to be on the leading (cutting) edge of Magisk to continue updating Canary without app 'phoning home' with magisk logging data, as well as builds being more compact (lacking verbose (debug) logging Canary had previously, while implementing a great tool (timesaver / data collection for speedy fixes) in separate Debug builds...

This will mean users must migrate to latest Debug build before submitting bug reports (making GitHub issues), and other users experiencing the same issue will be able to help without even commenting on GitHub simply by installing.Debug build themselves to allow automatic data collection...

IMG_20220516_004432.jpg

IMG_20220516_004552.jpg


* Watch this space! 👀

What's not to like? 😛 ... 😬 PW
 
Last edited:
  • Like
Reactions: belair56, zgfg and dr4go
P

pndwal

Senior Member
Jun 23, 2016
4,494
4,633
Sydney
Redmi Note 8
Xiaomi Redmi Note 8 (2021)
martyfender said:
If I disable USF module, both basic integrity and cts profile match fail. Evaluation type is BASIC. The device still shows certified in the playstore. This was on the older device:
ONA19TB002, security patch level 2019-04-05.
Although the hardware appears to be the same reported in AIDA64, with the same Android version and kernel version, the model number is 100005207, with a security patch level of 2020-03-05.

I get the same results with safetynet in YASNAC on the newer device.

If I recall correctly, both of these devices passed safetynet, way back in the past, before google changes with Magisk installed, without the USF module.
Click to expand...
Click to collapse
Yup, old MagiskHide fixed Basic Integrity on many devices as well as CTS Profile...

Your results show that your tablet is not seemingly on Google whitelist for HKA enforcement meaning the second fallback (model mismatch) is not needed. Incidentally, my Redmi Note 8T w/ 'working' TEE isn't either...

Thanks for your efforts... PW
 
X

xdMatthewbx

Member
Jan 3, 2020
23
6
Toronto
pndwal said:
Sounds like the domain of Rikka's 'Srorage Isolation' (formerly StorageRedirect)
https://sr.rikka.app/
(See guide in menu), or 'sandboxing' apps like Island, Shelter, Insular...

Nb. I haven't used any of these solutions myself. Those with experience may be of more help.

Seems mileage for hiding Zygisk w/ Shamiko varies with device...

👀 PW
Click to expand...
Click to collapse
Yeah I tried Storage Isolation it doesn't even want to let me enable it for Momo since it doesn't use the storage permission (yet still has file access? that part confuses me) and even if I enable it for Momo it still detects :/. Plus it's a free trial I'd have to pay 30$ for nothing (no thanks on subscriptions, lifetime license please), pass.
 
Last edited:
  • Like
Reactions: pndwal
K

KingCoder

Member
May 7, 2015
25
0
Is anyone having difficulties with their banking apps? Have the latest Magisk, Shamiko, Lsposed installs which have worked great but all of a sudden HSBC app will not open, tried hiding Magisk name, putting HSBC in denylist etc nothing working, does anyone have any ideas? Thx
 
C

Captain C

Member
Feb 23, 2011
26
4
KingCoder said:
Is anyone having difficulties with their banking apps? Have the latest Magisk, Shamiko, Lsposed installs which have worked great but all of a sudden HSBC app will not open, tried hiding Magisk name, putting HSBC in denylist etc nothing working, does anyone have any ideas? Thx
Click to expand...
Click to collapse
Yes I have the same issue. Since the Shamiko v0.5 update my banking App won't open. If I revert back to v0.4.4 my banking App works fine again and doesn't detect root, etc.

Are you possibly on a custom ROM? I have EvoX on two devices and both have this issue with Shamiko v0.5. However, I have one device one stock Samsung ROM and my banking App with the latest Shamiko works on that.

Can't figure out what the issue could be.
 
  • Like
Reactions: pndwal
K

KingCoder

Member
May 7, 2015
25
0
Captain C said:
Yes I have the same issue. Since the Shamiko v0.5 update my banking App won't open. If I revert back to v0.4.4 my banking App works fine again and doesn't detect root, etc.

Are you possibly on a custom ROM? I have EvoX on two devices and both have this issue with Shamiko v0.5. However, I have one device one stock Samsung ROM and my banking App with the latest Shamiko works on that.

Can't figure out what the issue could be.
Click to expand...
Click to collapse
Aah right wouldn't have even thought about reverting Shamiko.

I'm using OnePlus 9 Pro on stock ROM I'll try and revert Shamiko though and see if that works many thanks!
 
You must log in or register to reply here.

Similar threads

T
  • Locked
  • Sticky
Magisk - The Magic Mask for Android
Replies
56
Views
6M
T
topjohnwu
T
  • Locked
[CLOSED][BETA][2018.7.19] Magisk v16.7 (1671)
Replies
7K
Views
3M
T
topjohnwu
Heisenberg
[Discussion] PokeMon Go Magisk Discussion Thread
Replies
5K
Views
626K
djkrish5610
djkrish5610
yochananmarqos
  • Sticky
Collection of Magisk Modules v2
Replies
1K
Views
1M
meric57
meric57
Didgeridoohan
[Discussion] Google Pay Magisk Discussion Thread
Replies
2K
Views
438K
umibuzu
umibuzu

Top Liked Posts

24 Hours 30 Days All time
  • 5
    zgfg
    zgfg
    huskydg said:

    Feature request: Extend CLI to show Zygisk status · Issue #6064 · topjohnwu/Magisk

    CLI supports a lot, eg (partially) managing...
    github.com github.com
    Click to expand...
    Click to collapse
    Thanks for your hint to use --sqlite:

    Set Zygisk On:
    magisk --sqlite "REPLACE INTO settings (key,value) VALUES('zygisk',1);"

    Set Zygisk Off:
    magisk --sqlite "REPLACE INTO settings (key,value) VALUES('zygisk',0);"

    Check Zygisk status:
    magisk --sqlite "SELECT value FROM settings WHERE key = 'zygisk';"

    Btw, Magisk.db can be also easily managed from MiXPlorer (incl. Denylist and Root grants)
    View
    4
    huskydg
    huskydg
    ipdev said:
    I missed the one that shows Zygisk status.
    Can you nudge me in the direction of the command to check Zygisk. 👀

    Cheers. :cowboy:
    Click to expand...
    Click to collapse

    Feature request: Extend CLI to show Zygisk status · Issue #6064 · topjohnwu/Magisk

    CLI supports a lot, eg (partially) managing...
    github.com github.com
    View
    2
    rodken
    rodken
    zgfg said:
    It's absolutely strange that Magisk APP is stuck, but do you have any ground that reinstalling Magisk (patch and flash the image) would help to the Magisk app?!

    (It could be that something is wrong with Magisk db or so, and repatching and reflashing Magisk would not fix at all)
    Click to expand...
    Click to collapse
    There were instances where I suffered the same fate [twice] and simply reflashing a previously patched image would solve the dreaded 'stuck on splash screen' conundrum.
    View
    1
    D
    DiamondJohn
    rodken said:
    For future reference:
    -- Always take a working version of the latest Magisk and patch your boot.img
    -- This ensures that you can flash and resort back in the event of a catastrophic event
    -- Consider investing in installation of the Bootloop Saver.
    -- Look into what the 'Magisk Manager for Recovery Mode' can do for you [if you have a working version of TWRP installed].
    Click to expand...
    Click to collapse
    You forgot Plan Z. Make backups before doing anything that may trash your setup, and have a restore plan.
    zgfg said:
    ...snip...

    Btw, Magisk.db can be also easily managed from MiXPlorer (incl. Denylist and Root grants)
    Click to expand...
    Click to collapse
    Id be careful with using MiX. Although I use MiX, editing dB's can have issues. It was a while back, but what I think I saw happen, is that MiX makes a copy of the database, makes the change to its own copy, and then copies back over the original. That can fail if there is another app using the dB or has the same plans.

    Another option is to use SQLite directly from the command line, or use the app I built TeMeFI, which also edits the dB in-situ; its literally has a GUI to SQLite command line. MiX is closed source so its hard to know, but it failed to update a major db in android (I think the MediaDB), where the other options worked.

    But the 1st option is without question the best option. ie have Magisk mess with its own database. Database concurrency is a hard taskmaster.
    View
    1
    zgfg
    zgfg
    J.Michael said:
    It is going to be challenging to repatch the boot image after uninstalling the Magisk app.
    Click to expand...
    Click to collapse
    It was recently shown/discussed in this thread how to use:
    /data/adb/magisk/boot_patch.sh

    to manually patch the (given) boot.ing
    View
  • 9
    P
    pndwal
    Latest Official TJW Beta (release) Magisk build:

    Magisk​

    2022.6.7 Magisk v25.0​

    Another major release! A lot of the changes aren’t visible at the surface, but v25 is actually a really substantial upgrade!

    MagiskInit Rewrite​

    A significant portion of magiskinit (the critical software that runs before your device boots up) is completely rewritten from scratch. Ever since Android introduced Project Treble in Android 8.0, Magisk has been constantly fighting against the increasingly complex partitioning and early mount setups of all kinds of devices, sometimes with weird OEM specific implementations. It got to a point that magiskinit had become so complicated that few people (including myself!) were aware of every detail, and maintaining this piece of software like this was clearly not sustainable. After many months of planning (yes, this whole re-architecture has been in my head for a long time) and some help from external contributors, a whole new sepolicy injection mechanism is introduced into Magisk, solving the “SELinux Problem” once and for all.

    Since this is a full paradigm shift on how Magisk hot-patch the device at boot, several behaviors that many developers implicitly relied on might not exist. For example, Magisk no longer patches fstabs in most scenarios, which means AVB will remain intact; some custom kernels rely on AVB being stripped out for them by Magisk.

    MagiskSU Security Enhancements​

    The superuser functionality of Magisk has not seen much changes ever since its introduction. v25 focuses on making root permission management more accurate and secure:

    • Add a whole new package tracking system to ensure malicious UID reuse attack cannot be performed
    • Properly support and implement the UX in the Magisk app for packages using sharedUserId
    • Enforce root manager APK signature verification to combat the rampant unofficial Magisk app “mods”
    Many might not realize, but using a trusted, unmodified Magisk app is really important. Magisk’s root daemon treats the Magisk app differently and gives it blanket root access without any restrictions. A modded Magisk app can potentially backdoor your device.

    And in case some of you are about to put on your tin foil hats, this is not designed to “vendor lock-in”; the goal is to make sure your root management app comes from the same developer of the underlying root implementation. Magisk’s build system allows custom distributors to use its own signing keys, and in addition, I am also providing official debug builds which skips any signature verification for development.

    Full Changelog: here​

    Magisk Changelog​

    v25.0​

    • [MagiskInit] Update 2SI implementation, significantly increase device compatibility (e.g. Sony Xperia devices)
    • [MagiskInit] Introduce new sepolicy injection mechanism
    • [MagiskInit] Support Oculus Go
    • [MagiskInit] Support Android 13 GKIs (Pixel 6)
    • [MagiskBoot] Fix vbmeta extraction implementation
    • [App] Fix stub app on older Android versions
    • [App] [MagiskSU] Properly support apps using sharedUserId
    • [MagiskSU] Fix a possible crash in magiskd
    • [MagiskSU] Prune unused UIDs as soon as system_server restarts to prevent UID reuse attacks
    • [MagiskSU] Verify and enforce the installed Magisk app’s certificate to match the distributor’s signature
    • [MagiskSU] [Zygisk] Proper package management and detection
    • [Zygisk] Fix function hooking on devices running Android 12 with old kernels
    • [Zygisk] Fix Zygisk’s self code unloading implementation
    • [DenyList] Fix DenyList on shared UID apps
    • [BusyBox] Add workaround for devices running old kernels
    https://topjohnwu.github.io/Magisk/releases/25000.html

    🎉🎉 👍 PW
    View
    7
    P
    pndwal
    Latest Official TJW public Stable (release) Magisk build:

    Magisk​

    Magisk Changelog​

    v25.1​

    • [MagiskBoot] Fix ramdisk backup being incorrectly skipped
    • [MagiskBoot] Add new feature to detect unsupported dtb and abort during installation
    • [Zygisk] Change binary hijack paths
    • [App] Fix incorrect recovery mode detection and installation
    • [MagiskInit] Fix config not properly exported in legacy SAR devices
    • [General] Enforce the Magisk app to always match or be newer than magiskd

    Release Notes:
    https://topjohnwu.github.io/Magisk/releases/25100.html

    For remaining diffs to public Stable 24.3, see Changelog for public Beta 25.0:
    https://forum.xda-developers.com/t/magisk-general-support-discussion.3432382/post-86993241

    🎉🎉 👍 PW
    View
    6
    dohanin
    dohanin
    Rcedude said:
    Hello. Can someone help me downloading latest Momo please? https://t.me/magiskalpha/517
    I am on computer and i dont want to make a Telegram account :/.

    Thanks.
    Click to expand...
    Click to collapse
    View
    6
    S
    Slluxx
    Thank you @zgfg and @ipdev . I have a fully working and automated script to both update my phone and patch & flash the magisk boot.img file. The only thing thats missing is the autoreboot after sideload but i guess TWRP has to implement this feature.

    The script can both be used as standalone or class to modify it for custom stuff. Ill continue to work on the repo and make everything neat, as well as working on windows and linux binarys & a gui for people that have no idea how to use scripts.

    Thank you guys for your help, this will save so much time for me and maybe even other people (at least i hope it will be used). :)

    Here it is on github
    View
    6
    binary**#
    binary**#
    GauchoTche said:
    I've bought a Motorola Moto G71 5G. Unfortunately i cannot find a single thread about it on XDA. If i find it's stock ROM, what's the next steps to install magisk? How can i know that patching boot.img with magisk would work and not result in bootloop?
    Click to expand...
    Click to collapse
    You could opt for temporary root and check if it works or not. For that, boot your device via the Magisk patched boot file using the command-
    Code: 
    fastboot boot magisk-patched-boot.img
    If everything's well and good, then open the Magisk app and select Direct Install. It will permanently root your device.
    However, if your device doesn't boot up, then retry with a force restart, it will be booted to the standard non-rooted OS.
    If you are still unable to boot to the OS, then flash the stock boot.img via
    Code: 
    fastboot flash boot boot.img
    View
  • 1082
    T
    topjohnwu
    This is the place for general support and discussion regarding "Public Releases", which includes both stable and beta releases.
    All information, including troubleshoot guides and notes, are in the Announcement Thread
    View
    156
    T
    topjohnwu
    Hello, I haven't given much support on XDA lately. It can be resulted from
    • University started and I have limited free time. In fact, I mostly develop during midnight
    • I live in Taiwan, which has large time zone differences between my European/American contributors/testers, which usually forces me to stay up late at night to discuss/test stuffs.
    • The new version is about to come, I don't want to spend effort on supporting old releases
    The planned update is delayed again and again, to some point I think I'll shed some light about what has been happening lately, also along with some announcements.

    New Forum!
    As you might have already discovered, Magisk got its own subforum on XDA! Many thanks to all the support you gave me, and much more information/features/support is about to come!
    **For developers supporting all the devices that are not using standard Android boot format, feel free to create threads in this section (actually, PLEASE do so) for your favorite devices after v7 is out. As I currently know, Asus devices require signing the boot image before flashing, and is model dependant; Sony devices seems to use ELF kernel that is unpatchable, or some has two ramdisks (inner + outer), both requires different workarounds; LG bootloader locked devices has to manually "BUMP" the boot image after flashing Magisk..... and there may be lots of other crazy boot image formats that haven't come up to my attention yet.
    It is impossible for me to support all these non-standard boot images, and I hope the community can collaborate to make Magisk running across all the devices. Overall, community collaboration is what XDA about :D

    The Pixel Phone
    Some of you might already know this news, that the next Pixel Phone right around the corner seems like it does not have ramdisk in boot image, which pretty much wrecked Magisk in all ways. However, it pretty much doomed root itself too. Kernel modifications is inevitable IMO, so I'll try to migrate my scripts to C programs that could possibly be included into the kernel itself. Note that I'm not familiar with linux kernel, I'm not even sure if my idea and concept is correct or not. But once the device is available, I think developers will find a way to bypass all the difficulties, and I'll do my best to learn things ;)

    Current Progress
    In the past month, I've spent quite some time learning SELinux, so that I can avoid using SuperSU's sepolicy patches. Thanks to the helps and tips from @phhusson and @Chainfire, I finally have a much clearer understanding of how SELinux works. The Magisk core parts (the scripts, boot image patches, new features, more supports) are actually done some time ago. What is causing all the delays is the Magisk Manager.
    To be completely honest, although I can code in Java without much issues, Magisk Manager is actually my first Android application, I had to reach out for assistance, and fortunately awesome developers like @DVDandroid and @digitalhigh contributed a lot, which makes the current Manager awesome.
    After the repo system and module management is mostly done, I was about to do some adjustments and release, but what we really done is decided to add another feature: auto-unroot with per-app settings. I decided to wait for it to be finished, and then do my adjustments. Due to reasons that'll be mentioned later, this feature will likely not be available for the next release (should come in future updates)

    Safety Net Disaster
    Those who are using Magisk for Safety Net bypass purposes must have known that Google recently updated the detection method of my Systemless Xposed. I still have no idea what Safety Net is detecting, so currently I cannot fix it on my side (also because I'm busy working on the next update). However, suhide developed by @Chainfire is able to hide Xposed and worked fine.
    However, only my Systemless Xposed v86.2, which is based on SuperSU's su.d, is supported using that method. v86.2 and v86.5 (latest, Magisk based) have nearly identical binaries, and the only difference is the path where the binaries are stored.
    I'm still not sure what's the real issue for it not being supported, I just hope it is not done intentionally.

    Conclusion
    Due to the fact that my Safety Net bypass is not 100% perfect now, I do not want to spend any more time waiting for auto-unroot to be polished. What I'm doing now is finishing up all the things I'd like to change in Magisk Manager (it has been a while since I last contributed to Manager, my fellow developers are doing all the heavy job), which might take a little more time, after that, packed with tons of information to be announced in Magisk Section, I'll release the long awaited update.

    Hope this lengthy post gives you the idea of the whole situation, and again thanks for all your support!!
    View
    121
    Chainfire
    Chainfire
    Ah, some Chainfire bashing, I hope it is not too late for me to exercise additional villainy.

    First, let me make clear I have nothing against @topjohnwu, nor against Magisk. Magisk is an interesting project and it certainly displays @topjohnwu ingenuity and persistence. I don't doubt we will see more interesting things from his hands.

    -------------------------

    What has happened here is not all that dark and complicated, from either end. I returned from holidays, and someone pointed me at Magisk. My first thought: interesting!

    Among other things, the thread lists some issues with SuperSU, which in combination with the phrase The developer also requests users to not bug Chainfire with compatibility requests for SuperSU with Magisk from the portal article, raised my left eyebrow by nigh half an inch. The popular systemless xposed mod is apparently now based on it, and apparently it now no longer works with SuperSU, and apparently I'm not supposed to fix that, nor any of the other found issues. I found that a bit weird. So yes, I have told @topjohnwu that I was a bit surprised he was posting about issues with SuperSU without notifying me about them (I can't fix or help fix issues I'm not aware of, after all).

    He's also spreading a modified version of the SuperSU package, which is not all that uncommon, nor necessarily a problem. I have not looked into what he modified, I only ran a few quick tests on one of my devices, and found some commonly used commands run as root to be broken. I have informed him of this as well.

    It appears the tool of choice for Magisk is phh's Superuser, because of some of the mentioned issues with SuperSU. That's fine by itself, but fixing issues in that superuser by incorporating SuperSU's binaries into it is a somewhat questionable practise. After all, SuperSU is a commercial closed-source package that helps pay for my dinner, and superuser is a direct competitor. I have informed him that I was surprised he did this without asking for permission. I have expressed similar surprise on him spreading a modified version of LiveBoot (which helps pay for a snack now and then).
    @topjohnwu has also stated that Magisk's scripts are largely influenced by mine (I have not checked). Scripts based on mine are used all over the place on XDA, some people have crafted amazing things based on them, I have never made an issue of this (otherwise I would have just made them binaries). But yes, I have also stated to him that I don't think it's very nice to base something on one program, and then using that to (almost exclusively) push something directly competing with that program.

    tl;dr Towards @topjohnwu, I have:
    - expressed surprise he has issues getting Magisk to work with SuperSU, and has chosen not to inform me about those
    - expressed surprise he is using SuperSU binaries in a competing superuser without permission
    - expressed surprise he is posting a modified LiveBoot without permission
    - informed him of issues with the modified SuperSU he has posted
    - let him know I thought it wasn't very nice to be applying my scripts to benefit seemingly exclusively that same competing superuser

    To be crystal clear:
    - I have not asked for an apology
    - I have not asked for Magisk to be abandoned, neither the root hiding nor systemless module parts, and certainly not systemless xposed
    - I have not made an issue of any of this anywhere, until this post
    - I have not even specifically asked for anything to be taken down (though obviously in my opinion the other superuser package mixed with SuperSU's binaries, as well as the LiveBoot package, should go)
    - I have not reported this thread to XDA moderators for copyright violations or otherwise

    While my conversation with @topjohnwu may not win any awards for being friendly (though it may win some for brevity), I think all things considered my response has been rather mild. To be perfectly honest, until the apology post, I thought this was over with already. I think the apology post was triggered because I haven't replied to his last PM for a while - I was in the zone, it happens.

    To emphasize again, I have nothing against @topjohnwu, Magisk, or systemless xposed, and it is certainly not my goal to see any of them go. If it can be made to work together with SuperSU, great.

    I get it though: you think of something, you want to see if you can make it work, you finally get it to work, you publish it, it takes off - enthusiasm gets the better of you. Maybe in the rush some mistakes are made. That doesn't mean you have to just drop it and run. None of my stuff would make it past 0.1 if I stopped at the first big mistake :)

    Aside from said being in the zone coding, I usually regret actually responding to these sort of things the day after, which has made me hesitant to reply. Surprise me.
    View
    76
    nathanchance
    nathanchance
    Thread temporarily closed so everyone sees this.

    The flood of "SafetyNet isn't working for me either!" posts are not helpful, at all. Please refrain from posting further, it will be looked into. Please do not forget that not passing SafetyNet is 100% NORMAL AND INTENDED when you have an unlocked booloader or running custom firmware. These are workarounds and they will be worked around in turn.

    The Flash
    Forum Moderator

    EDIT: Thread is reopened... I will be cleaning any SafetyNet posts for a while to keep the thread clean for real issues.
    View
    75
    T
    topjohnwu
    Hello everyone!

    I am aware that Google has updated Safety Net that makes Magisk itself a no go for Android Pay. In fact, I witnessed the change live while I am developing the new magiskhide, which should hide all Magisk modules and Magisk installed root.

    Google is serious about Safety Net now, clearly hunting down all possibility to run Xposed with Safety Net passed. I spend quite some time examining the new security measures last midnight, and fortunately it seems that it is possible to run Magisk and root along with Safety Net if no Xposed is running. I'm glad I removed the old root toggle at the right time lol, that is no longer feasible with the latest detection.

    So stay tuned for the next update, it will come with bug fixes, along with the new magiskhide to bypass that Safety Net.

    Google, how will a few systemless mods do any harm :p:p
    View

New posts