Magisk General Support / Discussion

Search This thread

zputnyq

Senior Member
Apr 19, 2013
619
278
Why should you build debug for yourself?!

Isn't it more simple to follow the link from Magisk app (no matter which version) to go to the Magisk official GitHub page

Scroll down there to find Downloads - see the screenshot

You can download app-debug.apk (Debug) or app-release.apk (Canary)

To switch, you need to download and install the right APK and then to patch the img and flash (or you can flash the renamed APK to zip from TWRP).
Installation is also described in details on the Magisk GitHub page
He didn't mention the debug release on the commit, like stable version or canary.
 

Attachments

  • _20220525_022332.JPG
    _20220525_022332.JPG
    75.5 KB · Views: 30

pndwal

Senior Member
He didn't mention the debug release on the commit, like stable version or canary.
Since Debug and Canary builds are basically functionally identical, they are produced in tandem and appear in https://github.com/topjohnwu/magisk-files/tree/canary (repo/branch).

Debug will produce a performance hit on old devices due to new debug tools integrated, but the difference is otherwise just build type. Canary is now smaller than it was as verbose debug logging is removed and it is built as release. Debug is built as debug. Both are built at the same time from same commit...

John posted this recently:
John Wu, May 15

An update to future Magisk releases: the "Canary" channel will start shipping release builds, and a new "Debug" channel will be shipping debug builds. Both channels will be updated at the same time from the same source code, the only difference is the build flag.

Debug builds should only be used if you are actively developing Magisk, or if you want to submit bug reports. An upcoming change will start enforcing APK signature verifications on release builds to combat fraudulent/modded/hacked Magisk app APKs.

We also plan to start adding symbols (and maybe some sanitizers) and enabling core dumps on debug executables for better debugging and auditing. All these changes can be an issue on older device, and could significant effect performance, which is why it should not be used daily.

John Wu, May 24 (8h)

I just pushed out a new Canary build that enforces Magisk app signature verification directly in the root daemon. I have also updated the README on GitHub with guidance for developers working on Magisk itself and distributing your own builds signed with your own keys.

👀 PW
 
Last edited:

dohanin

Senior Member
Mar 26, 2011
226
126
Sony Xperia X Compact
Xiaomi Mi Pad 4
good morning all.

latest 5.0.5519 of Intune Portal (Microsoft) detects root !

On top of common/standard guideline (100& working till yesterday),

a) I hided xposed modules (HMA)
b) XprivacyLUA is set as well (tracking and analytics)

No way to circumvent root detection. I suspect Intune Portal needs to get the list of installed applications as - when I also set this flag in XPrivacy + complete app's data reset - the account cannot be addedd and app loops.....

I also froze (renamed) Magisk app --> no luck

any further suggestion from you?
my intune company portal is updated to latest version and it is still fine, i.e. root not detected. i only have usnf and shamiko modules

you have to make sure ALL activities under intune are ticked in denylist (default is not)
 

traversone

Senior Member
Feb 18, 2019
189
63
my intune company portal is updated to latest version and it is still fine, i.e. root not detected. i only have usnf and shamiko modules

you have to make sure ALL activities under intune are ticked in denylist (default is not)
ok, many thanks! I will select all the activities as per your suggestion (in last but noe version that was not needed).

But which ANdroid version do you use?
 

dohanin

Senior Member
Mar 26, 2011
226
126
Sony Xperia X Compact
Xiaomi Mi Pad 4
ok, many thanks! I will select all the activities as per your suggestion (in last but noe version that was not needed).

But which ANdroid version do you use?
Actually, someone in this post also reported the need to check all activities for intune company portal:


I am using Android 12.
 

traversone

Senior Member
Feb 18, 2019
189
63
Actually, someone in this post also reported the need to check all activities for intune company portal:


I am using Android 12.
in Android 11 (it is supposed to deny access to applist) I have also added Outlook in Denylist (standard selection for IntunePortal too, non all activities) and it WORKS !

of course Manager must be repacked with random name,

In android 10 this trick does not work though, or I am not able to make it working
 

lindsaysxda

Member
May 14, 2022
20
3
Xiaomi Mi A1
Can someone please help with my issue?
I'm trying to install Magisk to inactive slot as per this guide but no success.

I uninstalled Magisk (restore images option) successfully, downloaded and installed OTA, went back to install Magisk but there is no "install to inactive slot" anymore (screenshot), only select patch a file. It used to be on older versions when I was on LOS 17 a few months ago. I'm on 18 now. Magisk latest.
Screenshot_20220524-154117_Magisk.png
 

zgfg

Senior Member
Oct 10, 2016
7,645
5,048
Can someone please help with my issue?
I'm trying to install Magisk to inactive slot as per this guide but no success.

I uninstalled Magisk (restore images option) successfully, downloaded and installed OTA, went back to install Magisk but there is no "install to inactive slot" anymore (screenshot), only select patch a file. It used to be on older versions when I was on LOS 17 a few months ago. I'm on 18 now. Magisk latest.
View attachment 5622367
Don't know regarding your ROM, on my Xiaomi, stock ROM the option is present

If you are on 24.3 Stable, have you tried with the latest Canary 24313.
Btw, if you want to report to Magisk GitHub, you will need (Canary) Debug version
 
  • Like
Reactions: ipdev

zgfg

Senior Member
Oct 10, 2016
7,645
5,048
There is no canary in the options. Only Stable, Beta, Custom.
I switched to beta. Clicked install on magisk app and it installed same version 24.3.
Magisk install still no inactive slot option
Only Canary is the latest.
Beta is old as Stable (I wrote 24313, Beta almost for sure is not that version)

You should go to the Magisk GitHub and download

And (for everybody else) - there is a direct link to GitHub from the Magisk app (no matter which version you use)
 

pndwal

Senior Member
There is no canary in the options. Only Stable, Beta, Custom.
I switched to beta. Clicked install on magisk app and it installed same version 24.3.
Magisk install still no inactive slot option
View attachment 5622389View attachment 5622391
You won't get Direct Install option without root; I believe option for Install to inactive slot on A/B devices likewise is only available with root... Seems you have rebooted after taking Uninstall, Restore images, so have lost root.

John says:
Do not reboot or you will have Magisk uninstalled...
...do not press the "Restart now" or "Reboot" button!


Whole update process (incl. Installing Magisk to inactive slot) requires root retained in active system... Ie. You can Uninstall / Restore images and Magisk is still loaded, but not if you reboot. 😬 PW
 

lindsaysxda

Member
May 14, 2022
20
3
Xiaomi Mi A1
You won't get Direct Install option without root; I believe option for Install to inactive slot on A/B devices likewise is only available with root... Seems you have rebooted after taking Uninstall, Restore images, so have lost root.
No I haven't. I have done this process multiple times as per the guide I linked in my original post.
The option is just simply on new versions.
 

Top Liked Posts

  • 3
    I did not know cdDroid background....we live and learn! Thanks for clarifying this.

    Custom ROM's generally have just 2 sources, AOSP (Google open source) which is usually close to Pixel appearance or LineageOS.

    Just to make things murkier for you there may be 3 or 4 custom ROMs using LineageOS as a base, but often devs will "cherrypick" commits etc from other repos (other than LineageOS) to fix issues, so issues may exist on one ROM, but not another. Usually (though not always) once a dev finds fix for an issue they will share which commits theyve used to benefit the other ROM's.

    I dont miss the days, while on my s20+, of testing 3/4 ROMs a week like i used to on previous devices....

    <insert Murtaugh quote>

    p.s. If you dont get the Murtaugh quote then youre probably too young, and youre part of what daddy calls "The Problem" :)
    3
    Anyone knows if Magisk works on A13? My Pixel 4a seems to have got it this month. Tried to do a search in this thread, but the search function seems completely broken (unless I'm doing something wrong...)
    Yes it does.
    2
    Anyone knows if Magisk works on A13?...
    1
    Finally managed to get hold of devs at LOS and their response was simply not to use adopted storage. That leaves me with the option of looking at fbind or manually move files to sdcard.

    Thanks everyone for your comments - greatly appreciated.

    Thats not entirely surprising given the downsides of adoptable storage, namely corruption (any issue on the memory can cause the entire ROM to have a spazz), disappearing shortcuts to apps, and that other great one, running out of space (because what do you think happens when you run out of space with adoptable storage? - nothing good is the simple answer)...though thats not as big of a deal as it once was...some of us remember it though....
    1
    p.s. If you dont get the Murtaugh quote then youre probably too young, and youre part of what daddy calls "The Problem" :)
    Off-Topic: I always thought that 'The Problem' colloquially known as Zoomers were the 'ones' that prefer to use abbreviations and/or acronyms for every other word typed or spoken.
  • 8
    However, since the system is already rooted using Magisk shouldn't these folders be unencrypted?
    Magisk has nothing to do with File Based Encryption on Data and Storage.
    That's part of the File System definition - Magisk does not redefine File Systems.
    And when running Android, kernel takes care of FBE

    Btw, why would you (and some other users who maybe first time face FBE) dislike FBE (or be afraid of, or what) and want instead your files to be permanently unencrypted?!

    If you have a proper custom Recovery, it will ask for your pin/pattern and by use of that pin, it will then unencrypt file by file, on demand - just like Android does when you boot to Android

    Then, if your phone is stolen and the thief-hacker reboots to TWRP, he will not be able to steal your documents, phoos, etc, since (s)he does not know your Android unlock pin/pattern (and therefore TWRP cannot decrypt him your files - he can copy the encrypted files to PC but they will be of no use for him)

    However, without encryption, if your phone (with the TWRP installed) gets stolen, thief can simply boot to TWRP and copy all your personal files to PC.
    He can then open and read your documents, see your private photos, etc

    ---

    The official Google FBE documentation is available at:

    ---

    And one important tip:
    When installing custom ROM, usually you have to FORMAT Data (not just Wipe) that your new ROM could properly reformat FBE for itself - only then things will work as described (TWRP and FBE)

    But all that is out-of-topic for our Magisk thread

    Developers of custom ROMs should provide clear instructions how to properly install their ROMs - and their users of custom should take time to read instructions before flashing👍

    ---

    You can go to /vendor/etc/ (aka /system/vendor/etc one has to be mounted to the other in Android)
    and find a file fstab.* (on my phone it is named fstab.emmc).
    That's the read-only, textual file

    Inside, search for /userdata (filesystem definition).
    On my phone it looks like:
    Code:
    /dev/block/bootdevice/by-name/userdata /data f2fs noatime,nosuid,nodev,discard,inlinecrypt,reserve_root=32768,resgid=1065,fsync_mode=nobarrier latemount,wait,check,formattable,fileencryption=aes-256-xts:aes-256-cts:v2+emmc_optimized+wrappedkey_v0,keydirectory=/metadata/vold/metadata_encryption,metadata_encryption=aes-256-xts:wrappedkey_v0,quota,reservedsize=128M,sysfs_path=/sys/devices/platform/soc/1d84000.ufshc,checkpoint=fs

    Actually, inside that line look for the fileencryption definition - in my case:
    Code:
    fileencryption=aes-256-xts:aes-256-cts:v2+emmc_optimized+wrappedkey_v0

    Flag :v2 means that I have FBE v2. It's also emmc_optimized with hardware-wrapped keys (details and description can be found in the Google's FBE documentation as linked above)
    7
    By the way, there is another thread with detailed OP instructions for the new Magisk v24/v25:

    And a thread that was opened for hiding root with the new Magisk:

    Those new threads were opened because of this old and cluttered thread.
    Unfortunately, people still report/ask here (and in parallel complain that thread is too big to read☹️)
    6
    Its trivial to sniff or even MITM a desktop, or even just run WinPE and reset admin password and use the users own saved passwords in their browser, heck even export their passwords....

    In any event the biggest risk vector is social engineering

    Chasing root phone users only gives them a "feelgood", it does nothing to stop genuine misuse and fraud, at all.....

    I dont see Google or a bank sending out a representative every time someone makes a transaction to see if theyre genuine....trying to control the device is attacking the wrong end of the transaction and is ultimately pointless
    They're not chasing root users. They just want a guarantee that the device is secure, and they have good reason to. Rooting by nature compromises device security.

    I'm not saying your opinion is invalid; in this context however, it is irrelevant, because regardless of how you may feel about the situation, it's not going to change.
    6
    I had root, a few apps still recognize it, updating to the newest magisk manager shows n/a for magisk installed. Do I just grab my boot IMG out of my ROM and do it sgain? Will I keep all my data and info...?
    Did you have Magisk App hidden when updated?... Classic trap... Supposed to work, but bit like a pot-luck dinner...

    You're probably suffering from DACFRAS*, which is NOT fatal but all the clinics are full...

    Check in device settings, Apps for your old hidden App... Default name is 'settings', or its what you named it... Uninstall it, and presto!

    *Dual Apps Competing For Root Access Syndrome...

    😜 PW
  • 1085
    This is the place for general support and discussion regarding "Public Releases", which includes both stable and beta releases.
    All information, including troubleshoot guides and notes, are in the Announcement Thread
    156
    Hello, I haven't given much support on XDA lately. It can be resulted from
    • University started and I have limited free time. In fact, I mostly develop during midnight
    • I live in Taiwan, which has large time zone differences between my European/American contributors/testers, which usually forces me to stay up late at night to discuss/test stuffs.
    • The new version is about to come, I don't want to spend effort on supporting old releases
    The planned update is delayed again and again, to some point I think I'll shed some light about what has been happening lately, also along with some announcements.

    New Forum!
    As you might have already discovered, Magisk got its own subforum on XDA! Many thanks to all the support you gave me, and much more information/features/support is about to come!
    **For developers supporting all the devices that are not using standard Android boot format, feel free to create threads in this section (actually, PLEASE do so) for your favorite devices after v7 is out. As I currently know, Asus devices require signing the boot image before flashing, and is model dependant; Sony devices seems to use ELF kernel that is unpatchable, or some has two ramdisks (inner + outer), both requires different workarounds; LG bootloader locked devices has to manually "BUMP" the boot image after flashing Magisk..... and there may be lots of other crazy boot image formats that haven't come up to my attention yet.
    It is impossible for me to support all these non-standard boot images, and I hope the community can collaborate to make Magisk running across all the devices. Overall, community collaboration is what XDA about :D

    The Pixel Phone
    Some of you might already know this news, that the next Pixel Phone right around the corner seems like it does not have ramdisk in boot image, which pretty much wrecked Magisk in all ways. However, it pretty much doomed root itself too. Kernel modifications is inevitable IMO, so I'll try to migrate my scripts to C programs that could possibly be included into the kernel itself. Note that I'm not familiar with linux kernel, I'm not even sure if my idea and concept is correct or not. But once the device is available, I think developers will find a way to bypass all the difficulties, and I'll do my best to learn things ;)

    Current Progress
    In the past month, I've spent quite some time learning SELinux, so that I can avoid using SuperSU's sepolicy patches. Thanks to the helps and tips from @phhusson and @Chainfire, I finally have a much clearer understanding of how SELinux works. The Magisk core parts (the scripts, boot image patches, new features, more supports) are actually done some time ago. What is causing all the delays is the Magisk Manager.
    To be completely honest, although I can code in Java without much issues, Magisk Manager is actually my first Android application, I had to reach out for assistance, and fortunately awesome developers like @DVDandroid and @digitalhigh contributed a lot, which makes the current Manager awesome.
    After the repo system and module management is mostly done, I was about to do some adjustments and release, but what we really done is decided to add another feature: auto-unroot with per-app settings. I decided to wait for it to be finished, and then do my adjustments. Due to reasons that'll be mentioned later, this feature will likely not be available for the next release (should come in future updates)

    Safety Net Disaster
    Those who are using Magisk for Safety Net bypass purposes must have known that Google recently updated the detection method of my Systemless Xposed. I still have no idea what Safety Net is detecting, so currently I cannot fix it on my side (also because I'm busy working on the next update). However, suhide developed by @Chainfire is able to hide Xposed and worked fine.
    However, only my Systemless Xposed v86.2, which is based on SuperSU's su.d, is supported using that method. v86.2 and v86.5 (latest, Magisk based) have nearly identical binaries, and the only difference is the path where the binaries are stored.
    I'm still not sure what's the real issue for it not being supported, I just hope it is not done intentionally.

    Conclusion
    Due to the fact that my Safety Net bypass is not 100% perfect now, I do not want to spend any more time waiting for auto-unroot to be polished. What I'm doing now is finishing up all the things I'd like to change in Magisk Manager (it has been a while since I last contributed to Manager, my fellow developers are doing all the heavy job), which might take a little more time, after that, packed with tons of information to be announced in Magisk Section, I'll release the long awaited update.

    Hope this lengthy post gives you the idea of the whole situation, and again thanks for all your support!!
    121
    Ah, some Chainfire bashing, I hope it is not too late for me to exercise additional villainy.

    First, let me make clear I have nothing against @topjohnwu, nor against Magisk. Magisk is an interesting project and it certainly displays @topjohnwu ingenuity and persistence. I don't doubt we will see more interesting things from his hands.

    -------------------------

    What has happened here is not all that dark and complicated, from either end. I returned from holidays, and someone pointed me at Magisk. My first thought: interesting!

    Among other things, the thread lists some issues with SuperSU, which in combination with the phrase The developer also requests users to not bug Chainfire with compatibility requests for SuperSU with Magisk from the portal article, raised my left eyebrow by nigh half an inch. The popular systemless xposed mod is apparently now based on it, and apparently it now no longer works with SuperSU, and apparently I'm not supposed to fix that, nor any of the other found issues. I found that a bit weird. So yes, I have told @topjohnwu that I was a bit surprised he was posting about issues with SuperSU without notifying me about them (I can't fix or help fix issues I'm not aware of, after all).

    He's also spreading a modified version of the SuperSU package, which is not all that uncommon, nor necessarily a problem. I have not looked into what he modified, I only ran a few quick tests on one of my devices, and found some commonly used commands run as root to be broken. I have informed him of this as well.

    It appears the tool of choice for Magisk is phh's Superuser, because of some of the mentioned issues with SuperSU. That's fine by itself, but fixing issues in that superuser by incorporating SuperSU's binaries into it is a somewhat questionable practise. After all, SuperSU is a commercial closed-source package that helps pay for my dinner, and superuser is a direct competitor. I have informed him that I was surprised he did this without asking for permission. I have expressed similar surprise on him spreading a modified version of LiveBoot (which helps pay for a snack now and then).
    @topjohnwu has also stated that Magisk's scripts are largely influenced by mine (I have not checked). Scripts based on mine are used all over the place on XDA, some people have crafted amazing things based on them, I have never made an issue of this (otherwise I would have just made them binaries). But yes, I have also stated to him that I don't think it's very nice to base something on one program, and then using that to (almost exclusively) push something directly competing with that program.

    tl;dr Towards @topjohnwu, I have:
    - expressed surprise he has issues getting Magisk to work with SuperSU, and has chosen not to inform me about those
    - expressed surprise he is using SuperSU binaries in a competing superuser without permission
    - expressed surprise he is posting a modified LiveBoot without permission
    - informed him of issues with the modified SuperSU he has posted
    - let him know I thought it wasn't very nice to be applying my scripts to benefit seemingly exclusively that same competing superuser

    To be crystal clear:
    - I have not asked for an apology
    - I have not asked for Magisk to be abandoned, neither the root hiding nor systemless module parts, and certainly not systemless xposed
    - I have not made an issue of any of this anywhere, until this post
    - I have not even specifically asked for anything to be taken down (though obviously in my opinion the other superuser package mixed with SuperSU's binaries, as well as the LiveBoot package, should go)
    - I have not reported this thread to XDA moderators for copyright violations or otherwise

    While my conversation with @topjohnwu may not win any awards for being friendly (though it may win some for brevity), I think all things considered my response has been rather mild. To be perfectly honest, until the apology post, I thought this was over with already. I think the apology post was triggered because I haven't replied to his last PM for a while - I was in the zone, it happens.

    To emphasize again, I have nothing against @topjohnwu, Magisk, or systemless xposed, and it is certainly not my goal to see any of them go. If it can be made to work together with SuperSU, great.

    I get it though: you think of something, you want to see if you can make it work, you finally get it to work, you publish it, it takes off - enthusiasm gets the better of you. Maybe in the rush some mistakes are made. That doesn't mean you have to just drop it and run. None of my stuff would make it past 0.1 if I stopped at the first big mistake :)

    Aside from said being in the zone coding, I usually regret actually responding to these sort of things the day after, which has made me hesitant to reply. Surprise me.
    76
    Thread temporarily closed so everyone sees this.

    The flood of "SafetyNet isn't working for me either!" posts are not helpful, at all. Please refrain from posting further, it will be looked into. Please do not forget that not passing SafetyNet is 100% NORMAL AND INTENDED when you have an unlocked booloader or running custom firmware. These are workarounds and they will be worked around in turn.

    The Flash
    Forum Moderator

    EDIT: Thread is reopened... I will be cleaning any SafetyNet posts for a while to keep the thread clean for real issues.
    75
    Hello everyone!

    I am aware that Google has updated Safety Net that makes Magisk itself a no go for Android Pay. In fact, I witnessed the change live while I am developing the new magiskhide, which should hide all Magisk modules and Magisk installed root.

    Google is serious about Safety Net now, clearly hunting down all possibility to run Xposed with Safety Net passed. I spend quite some time examining the new security measures last midnight, and fortunately it seems that it is possible to run Magisk and root along with Safety Net if no Xposed is running. I'm glad I removed the old root toggle at the right time lol, that is no longer feasible with the latest detection.

    So stay tuned for the next update, it will come with bug fixes, along with the new magiskhide to bypass that Safety Net.

    Google, how will a few systemless mods do any harm :p:p