Magisk General Support / Discussion
- Thread starter topjohnwu
- Start date
There is no canary in the options. Only Stable, Beta, Custom.
I switched to beta. Clicked install on magisk app and it installed same version 24.3.
Magisk install still no inactive slot option
Last edited:
Only Canary is the latest.
Beta is old as Stable (I wrote 24313, Beta almost for sure is not that version)
You should go to the Magisk GitHub and download
And (for everybody else) - there is a direct link to GitHub from the Magisk app (no matter which version you use)
You may report to Magisk GitHub but you would need to use 24313 Debug and the logs
Sorry, cannot help you more
... Then you didn't click Magisk Canary or Magisk Debug (under Downloads); the two red options... 
PWYes I did. The canary one.
You won't get Direct Install option without root; I believe option for Install to inactive slot on A/B devices likewise is only available with root... Seems you have rebooted after taking Uninstall, Restore images, so have lost root.
John says:
Do not reboot or you will have Magisk uninstalled...
...do not press the "Restart now" or "Reboot" button!
Whole update process (incl. Installing Magisk to inactive slot) requires root retained in active system... Ie. You can Uninstall / Restore images and Magisk is still loaded, but not if you reboot.
PWNo I haven't. I have done this process multiple times as per the guide I linked in my original post.
The option is just simply on new versions.
So after installing that and then taking Magisk Install, are you saying Canary app is installing 24300??? PW
It promts to install an update on magisk, I click yes and it's still 24300. I don't care about this though. The issue it that the OTA process in the guide is not working anymore as the inactive slot install is missing. I don't care anymore, I restarted the device and lost root now. Whatever.
Your screenshot above shows Magisk Installed, N/A! This means app can't see root. Either root is absent, it's borked, you have a rogue 'hidden' app conflicting with app in use or other app issue preventing root detection... You can't have Direct Install or Install to inactive slot w/ Magisk Installed, N/A unless I'm much mistaken... PW
Sorry, I don't know of option to click 'yes'...
If App Installed is 24313 clicking Magisk Install will patch with 24313...
Clicking App Install however will call app shown as App Latest, and this may well be pointing to 24300 if Update Channel is set to Beta or Stable... PW
Yeah it's not exactly yes. I'm talking about this popup.
It was 24300 and apk install was 24313. I think channel was set to beta. But it doesn't matter anymore, since I didn't find inactive slot option I just rebooted and lost root. I have to reinstall magisk from scratch if I want now.
John says "first go to (Magisk app → Uninstall → Restore Images). Do not reboot or you will have Magisk uninstalled."
As I understand it, you shouldn't get Magisk Installed, N/A unless you reboot because rebooting completes the uninstallation / unloading... The process described only works as Magisk is still loaded even after taking Uninstall Magisk, Restore Images until you reboot...
I have read OTA guide many times, but don't have an A/B device, so I may be wrong, but I don't think you'll have Magisk loaded with Installed = N/A, and if it's possible you should at least have Direct Install option... PW
I think I understand this part of your problem now... Your system is having a problem installing newer app so you still have original 24300. (Could be the way it handles signatures, changes in Canary Magisk, or other...)
Just check what folder is set in Magisk app as download folder, close app, find Canary APK from failed install there and try installing that APK directly from file manager... If you still have parsing / other issues, uninstall 24300 first...
PWSimilar threads
Top Liked Posts
-
2
Covidtime = downtime?... Nah! It's Dreamtime... For the TJW-CPU, uptime! -Yup... But boost = catalyst for Oxidation... he's excited about Rust...
...
PW
www.twitter.com/topjohnwu/status/1542633717495083008John Wu, Jul 1
Spent the past few days while resting and recovering from COVID setting up Magisk for Rust development semi-consciously LMAO
PW
Maybe it's a game to him... "The RUST sleep command will allow admins and moderators, upon issuing the command, to instantly put themselves into sleeper mode. Once they're in sleeper mode, they are required to press any button on their keyboard or mouse to wake up."
https://www.corrosionhour.com/rust-sleep-command/1Covidtime = downtime?... Nah! It's Dreamtime... For the TJW-CPU, uptime! -
www.twitter.com/topjohnwu/status/1542633717495083008
PW
Maybe it's a game to him... "The RUST sleep command will allow admins and moderators, upon issuing the command, to instantly put themselves into sleeper mode. Once they're in sleeper mode, they are required to press any button on their keyboard or mouse to wake up."
https://www.corrosionhour.com/rust-sleep-command/
Theres no stopping him
Theres a rumour he can actually see Ponkles in real time1
Thank you, I got it sorted. I forgot to I was using an incompatible magisk boot image. Once I switched that out everything was working again. Two hours wasted on that lolYes.
The /data/adb directory will be created the next time you boot a magisk patched boot image.
There might be a few extra magisk files in /data (magisk backup files).
If you installed magisk by flashing in recovery and you ROM supports addon.d scripts, there will be a Magisk script in the /system/addon.d directory.
Use the App Info section to uninstall the Magisk app.
Normally long-press the icon and you will get an option for info or, go though system setting, Apps.
Use app info to Force stop, clear cache and data then uninstall the magisk app.
---
Then reboot with your stock boot image.
Install Magisk (app) and patch your stock boot image.
Reboot with the new Magisk patched image.
Cheers.
1
OMG
'Hiding' Magisk app does repackaging (changing package name to random).
Unhide if you don't like and don't hide in the future (or get to know and understand that renaming package to random helps to hide it from banking and similar apps)1
I don't know where is the problem. How hiding works and what it does and everything about has been mentioned and discussed literally hundredth of times in this thread
And one of the XDA forum rules (and not only on XDA) asks that people read and learn before asking. Hence it really makes no sense to ask about something absolutely basic and to be surprised about, and for others to waste time teaching that hiding the Magic app will rename it's package name and what for -
9Latest Official TJW Beta (release) Magisk build:
Magisk
2022.6.7 Magisk v25.0
Another major release! A lot of the changes aren’t visible at the surface, but v25 is actually a really substantial upgrade!
MagiskInit Rewrite
A significant portion of magiskinit (the critical software that runs before your device boots up) is completely rewritten from scratch. Ever since Android introduced Project Treble in Android 8.0, Magisk has been constantly fighting against the increasingly complex partitioning and early mount setups of all kinds of devices, sometimes with weird OEM specific implementations. It got to a point that magiskinit had become so complicated that few people (including myself!) were aware of every detail, and maintaining this piece of software like this was clearly not sustainable. After many months of planning (yes, this whole re-architecture has been in my head for a long time) and some help from external contributors, a whole new sepolicy injection mechanism is introduced into Magisk, solving the “SELinux Problem” once and for all.
Since this is a full paradigm shift on how Magisk hot-patch the device at boot, several behaviors that many developers implicitly relied on might not exist. For example, Magisk no longer patches fstabs in most scenarios, which means AVB will remain intact; some custom kernels rely on AVB being stripped out for them by Magisk.
MagiskSU Security Enhancements
The superuser functionality of Magisk has not seen much changes ever since its introduction. v25 focuses on making root permission management more accurate and secure:
- Add a whole new package tracking system to ensure malicious UID reuse attack cannot be performed
- Properly support and implement the UX in the Magisk app for packages using sharedUserId
- Enforce root manager APK signature verification to combat the rampant unofficial Magisk app “mods”
And in case some of you are about to put on your tin foil hats, this is not designed to “vendor lock-in”; the goal is to make sure your root management app comes from the same developer of the underlying root implementation. Magisk’s build system allows custom distributors to use its own signing keys, and in addition, I am also providing official debug builds which skips any signature verification for development.
Full Changelog: here
Magisk Changelog
v25.0
- [MagiskInit] Update 2SI implementation, significantly increase device compatibility (e.g. Sony Xperia devices)
- [MagiskInit] Introduce new sepolicy injection mechanism
- [MagiskInit] Support Oculus Go
- [MagiskInit] Support Android 13 GKIs (Pixel 6)
- [MagiskBoot] Fix vbmeta extraction implementation
- [App] Fix stub app on older Android versions
- [App] [MagiskSU] Properly support apps using sharedUserId
- [MagiskSU] Fix a possible crash in magiskd
- [MagiskSU] Prune unused UIDs as soon as system_server restarts to prevent UID reuse attacks
- [MagiskSU] Verify and enforce the installed Magisk app’s certificate to match the distributor’s signature
- [MagiskSU] [Zygisk] Proper package management and detection
- [Zygisk] Fix function hooking on devices running Android 12 with old kernels
- [Zygisk] Fix Zygisk’s self code unloading implementation
- [DenyList] Fix DenyList on shared UID apps
- [BusyBox] Add workaround for devices running old kernels
PW7Latest Official TJW public Stable (release) Magisk build:
Magisk
Magisk Changelog
v25.1
- [MagiskBoot] Fix ramdisk backup being incorrectly skipped
- [MagiskBoot] Add new feature to detect unsupported dtb and abort during installation
- [Zygisk] Change binary hijack paths
- [App] Fix incorrect recovery mode detection and installation
- [MagiskInit] Fix config not properly exported in legacy SAR devices
- [General] Enforce the Magisk app to always match or be newer than magiskd
Release Notes:
https://topjohnwu.github.io/Magisk/releases/25100.html
For remaining diffs to public Stable 24.3, see Changelog for public Beta 25.0:
https://forum.xda-developers.com/t/magisk-general-support-discussion.3432382/post-86993241
PW6Thank you @zgfg and @ipdev . I have a fully working and automated script to both update my phone and patch & flash the magisk boot.img file. The only thing thats missing is the autoreboot after sideload but i guess TWRP has to implement this feature.
The script can both be used as standalone or class to modify it for custom stuff. Ill continue to work on the repo and make everything neat, as well as working on windows and linux binarys & a gui for people that have no idea how to use scripts.
Thank you guys for your help, this will save so much time for me and maybe even other people (at least i hope it will be used).
Here it is on github6
You could opt for temporary root and check if it works or not. For that, boot your device via the Magisk patched boot file using the command-
If everything's well and good, then open the Magisk app and select Direct Install. It will permanently root your device.Code:fastboot boot magisk-patched-boot.img
However, if your device doesn't boot up, then retry with a force restart, it will be booted to the standard non-rooted OS.
If you are still unable to boot to the OS, then flash the stock boot.img via
Code:fastboot flash boot boot.img6Latest Official TJW Canary (release) & Debug (debug) Magisk builds:
Magisk (34b2f525) (24316)
- [App] Fix stub app on older Android versions
Diffs to v24.3
- [MagiskInit] Update 2SI implementation, significantly increase device compatibility (e.g. Sony Xperia devices)
- [MagiskInit] Introduce new sepolicy injection mechanism
- [MagiskInit] Support Oculus Go
- [MagiskInit] Support Android 13 GKIs (Pixel 6)
- [MagiskBoot] Fix vbmeta extraction implementation
- [App] [MagiskSU] Properly support apps using shared UID
- [App] Fix stub app on older Android versions
- [MagiskSU] Fix a possible crash in magiskd
- [MagiskSU] Prune unused UIDs as soon as possible to prevent UID reuse attacks
- [MagiskSU] Verify and enforce the installed Magisk app's certificate to match the distributor's signature
- [MagiskSU] Handle system_server restarts to prevent UID reuse abuse
- [MagiskSU] [Zygisk] Proper package management and detection
- [Zygisk] Fix function hooking on devices running Android 12 with old kernels
- [Zygisk] Fix Zygisk's self code unloading implementation
- [DenyList] Fix DenyList on shared UID apps
- [BusyBox] Add workaround for devices running old kernels
PW -
1081This is the place for general support and discussion regarding "Public Releases", which includes both stable and beta releases.
All information, including troubleshoot guides and notes, are in the Announcement Thread156Hello, I haven't given much support on XDA lately. It can be resulted from
- University started and I have limited free time. In fact, I mostly develop during midnight
- I live in Taiwan, which has large time zone differences between my European/American contributors/testers, which usually forces me to stay up late at night to discuss/test stuffs.
- The new version is about to come, I don't want to spend effort on supporting old releases
New Forum!
As you might have already discovered, Magisk got its own subforum on XDA! Many thanks to all the support you gave me, and much more information/features/support is about to come!
**For developers supporting all the devices that are not using standard Android boot format, feel free to create threads in this section (actually, PLEASE do so) for your favorite devices after v7 is out. As I currently know, Asus devices require signing the boot image before flashing, and is model dependant; Sony devices seems to use ELF kernel that is unpatchable, or some has two ramdisks (inner + outer), both requires different workarounds; LG bootloader locked devices has to manually "BUMP" the boot image after flashing Magisk..... and there may be lots of other crazy boot image formats that haven't come up to my attention yet.
It is impossible for me to support all these non-standard boot images, and I hope the community can collaborate to make Magisk running across all the devices. Overall, community collaboration is what XDA about
The Pixel Phone
Some of you might already know this news, that the next Pixel Phone right around the corner seems like it does not have ramdisk in boot image, which pretty much wrecked Magisk in all ways. However, it pretty much doomed root itself too. Kernel modifications is inevitable IMO, so I'll try to migrate my scripts to C programs that could possibly be included into the kernel itself. Note that I'm not familiar with linux kernel, I'm not even sure if my idea and concept is correct or not. But once the device is available, I think developers will find a way to bypass all the difficulties, and I'll do my best to learn things
Current Progress
In the past month, I've spent quite some time learning SELinux, so that I can avoid using SuperSU's sepolicy patches. Thanks to the helps and tips from @phhusson and @Chainfire, I finally have a much clearer understanding of how SELinux works. The Magisk core parts (the scripts, boot image patches, new features, more supports) are actually done some time ago. What is causing all the delays is the Magisk Manager.
To be completely honest, although I can code in Java without much issues, Magisk Manager is actually my first Android application, I had to reach out for assistance, and fortunately awesome developers like @DVDandroid and @digitalhigh contributed a lot, which makes the current Manager awesome.
After the repo system and module management is mostly done, I was about to do some adjustments and release, but what we really done is decided to add another feature: auto-unroot with per-app settings. I decided to wait for it to be finished, and then do my adjustments. Due to reasons that'll be mentioned later, this feature will likely not be available for the next release (should come in future updates)
Safety Net Disaster
Those who are using Magisk for Safety Net bypass purposes must have known that Google recently updated the detection method of my Systemless Xposed. I still have no idea what Safety Net is detecting, so currently I cannot fix it on my side (also because I'm busy working on the next update). However, suhide developed by @Chainfire is able to hide Xposed and worked fine.
However, only my Systemless Xposed v86.2, which is based on SuperSU's su.d, is supported using that method. v86.2 and v86.5 (latest, Magisk based) have nearly identical binaries, and the only difference is the path where the binaries are stored.
I'm still not sure what's the real issue for it not being supported, I just hope it is not done intentionally.
Conclusion
Due to the fact that my Safety Net bypass is not 100% perfect now, I do not want to spend any more time waiting for auto-unroot to be polished. What I'm doing now is finishing up all the things I'd like to change in Magisk Manager (it has been a while since I last contributed to Manager, my fellow developers are doing all the heavy job), which might take a little more time, after that, packed with tons of information to be announced in Magisk Section, I'll release the long awaited update.
Hope this lengthy post gives you the idea of the whole situation, and again thanks for all your support!!121Ah, some Chainfire bashing, I hope it is not too late for me to exercise additional villainy.
First, let me make clear I have nothing against @topjohnwu, nor against Magisk. Magisk is an interesting project and it certainly displays @topjohnwu ingenuity and persistence. I don't doubt we will see more interesting things from his hands.
-------------------------
What has happened here is not all that dark and complicated, from either end. I returned from holidays, and someone pointed me at Magisk. My first thought: interesting!
Among other things, the thread lists some issues with SuperSU, which in combination with the phrase The developer also requests users to not bug Chainfire with compatibility requests for SuperSU with Magisk from the portal article, raised my left eyebrow by nigh half an inch. The popular systemless xposed mod is apparently now based on it, and apparently it now no longer works with SuperSU, and apparently I'm not supposed to fix that, nor any of the other found issues. I found that a bit weird. So yes, I have told @topjohnwu that I was a bit surprised he was posting about issues with SuperSU without notifying me about them (I can't fix or help fix issues I'm not aware of, after all).
He's also spreading a modified version of the SuperSU package, which is not all that uncommon, nor necessarily a problem. I have not looked into what he modified, I only ran a few quick tests on one of my devices, and found some commonly used commands run as root to be broken. I have informed him of this as well.
It appears the tool of choice for Magisk is phh's Superuser, because of some of the mentioned issues with SuperSU. That's fine by itself, but fixing issues in that superuser by incorporating SuperSU's binaries into it is a somewhat questionable practise. After all, SuperSU is a commercial closed-source package that helps pay for my dinner, and superuser is a direct competitor. I have informed him that I was surprised he did this without asking for permission. I have expressed similar surprise on him spreading a modified version of LiveBoot (which helps pay for a snack now and then).
@topjohnwu has also stated that Magisk's scripts are largely influenced by mine (I have not checked). Scripts based on mine are used all over the place on XDA, some people have crafted amazing things based on them, I have never made an issue of this (otherwise I would have just made them binaries). But yes, I have also stated to him that I don't think it's very nice to base something on one program, and then using that to (almost exclusively) push something directly competing with that program.
tl;dr Towards @topjohnwu, I have:
- expressed surprise he has issues getting Magisk to work with SuperSU, and has chosen not to inform me about those
- expressed surprise he is using SuperSU binaries in a competing superuser without permission
- expressed surprise he is posting a modified LiveBoot without permission
- informed him of issues with the modified SuperSU he has posted
- let him know I thought it wasn't very nice to be applying my scripts to benefit seemingly exclusively that same competing superuser
To be crystal clear:
- I have not asked for an apology
- I have not asked for Magisk to be abandoned, neither the root hiding nor systemless module parts, and certainly not systemless xposed
- I have not made an issue of any of this anywhere, until this post
- I have not even specifically asked for anything to be taken down (though obviously in my opinion the other superuser package mixed with SuperSU's binaries, as well as the LiveBoot package, should go)
- I have not reported this thread to XDA moderators for copyright violations or otherwise
While my conversation with @topjohnwu may not win any awards for being friendly (though it may win some for brevity), I think all things considered my response has been rather mild. To be perfectly honest, until the apology post, I thought this was over with already. I think the apology post was triggered because I haven't replied to his last PM for a while - I was in the zone, it happens.
To emphasize again, I have nothing against @topjohnwu, Magisk, or systemless xposed, and it is certainly not my goal to see any of them go. If it can be made to work together with SuperSU, great.
I get it though: you think of something, you want to see if you can make it work, you finally get it to work, you publish it, it takes off - enthusiasm gets the better of you. Maybe in the rush some mistakes are made. That doesn't mean you have to just drop it and run. None of my stuff would make it past 0.1 if I stopped at the first big mistake
Aside from said being in the zone coding, I usually regret actually responding to these sort of things the day after, which has made me hesitant to reply. Surprise me.76Thread temporarily closed so everyone sees this.
The flood of "SafetyNet isn't working for me either!" posts are not helpful, at all. Please refrain from posting further, it will be looked into. Please do not forget that not passing SafetyNet is 100% NORMAL AND INTENDED when you have an unlocked booloader or running custom firmware. These are workarounds and they will be worked around in turn.
The Flash
Forum Moderator
EDIT: Thread is reopened... I will be cleaning any SafetyNet posts for a while to keep the thread clean for real issues.75Hello everyone!
I am aware that Google has updated Safety Net that makes Magisk itself a no go for Android Pay. In fact, I witnessed the change live while I am developing the new magiskhide, which should hide all Magisk modules and Magisk installed root.
Google is serious about Safety Net now, clearly hunting down all possibility to run Xposed with Safety Net passed. I spend quite some time examining the new security measures last midnight, and fortunately it seems that it is possible to run Magisk and root along with Safety Net if no Xposed is running. I'm glad I removed the old root toggle at the right time lol, that is no longer feasible with the latest detection.
So stay tuned for the next update, it will come with bug fixes, along with the new magiskhide to bypass that Safety Net.
Google, how will a few systemless mods do any harm
