Magisk General Support / Discussion

Search This thread

pndwal

Senior Member
I did not reboot my friend. Why is it difficult for you to understand?
Why are you just being difficult?

We are trying to help you to analyse a curly issue... You should admit that your own understanding has been somewhat lacking (sufficiently understated?) and try to understand what others are telling you...

I'd actually like to understand you issue too, but I don't like dealing with attitude, so I'm loosing interest... PW
 

lindsaysxda

Member
May 14, 2022
20
3
Xiaomi Mi A1
Why are you just being difficult?

We are trying to help you to analyse a curly issue... You should admit that your own understanding has been somewhat lacking (sufficiently understated?) and try to understand what others are telling you...
Beucase you are asking me to explain the same thing over and over always assuming it is my error.
I told you I have followed that guide multiple times in the past and explained my steps in the original post exactly and you still assume I am following the guide wrongly. So yes I get frustrated when you don't read what I say.
I'd actually like to understand you issue too
Good, but I gave up and now I don't have Magisk anymore since I rebooted and lost root.
 

pndwal

Senior Member
Beucase you are asking me to explain the same thing over and over always assuming it is my error.
I told you I have followed that guide multiple times in the past and explained my steps in the original post exactly and you still assume I am following the guide wrongly. So yes I get frustrated when you don't read what I say.
That's baloney... made no such assumptions, only said 'seems you rebooted', never 'asked for same explanation over and over', or even once because I did read what you said, simply tried to help and am now regretting it, tis all! Goodnight. PW
 

73sydney

Senior Member
@pndwal

Meanwhile i borked the latest update...temporarily - totally self inflicted and my fault, hence qualifies for a Spanner Award

Unhid the Magisk app
Updated app
Direct Installed magisk
Rebooted

Went to hide the app, gave it a shortcut name (i just call mine App) and hit the button, and just at that moment a notification popped up and lost the Magisk app window

Went back to drawer - nova can stay on page if you like it to, i do...but on this occasion as you will see if i hadnt had this turned on i might have noticed i had an issue and figured it out earlier and just deleted the duplicate (explanation coming)

Still had a Magisk app in the drawer, so assumed it had failed, so repeated the process....worked ...and no more Magisk app.

So i go to look for "App" and theres two...

One opens and looks normal apart from the Zygisk: No

The other prompts to complete full install of Magisk

Well thats fun....

Unhid the one that opened, uninstalled the remaining "App" and rebooted

Waited a few minutes

Hid the proper remaining Magisk to "App" and rebooted

Zygisk said : Yes

Happy Days!

Takeaway/Moral of this story:

Kids, dont do what daddy did and try and hide the Magisk app immediately after reboot, let the system settle, because this was entirely my fault for rushing things :)

Sometimes life really is like a box of Ponkles, you never know what youre going to get....
 
Last edited:
  • Like
Reactions: Fishawy

zgfg

Senior Member
Oct 10, 2016
7,369
4,761
Follow up to the @lindsaysxda case/discussion, some general comments, just to make things clear:

- Magisk app, formerly named Magisk Manager is still just a manager app or some kind of user interface for the Magisk

Therefore, it is possible to have Magisk app installed, but without Magisk. Ie, installing only the Magisk app does not mean that Magisk was installed

In the normal circumstances one would install in parallel both Magisk app and Magisk of the SAME version (like BOTH Stable 24300 or BOTH Canary 24313 or so)

Anyway, Magisk app displays both the version of Magisk (at the top) and Magisk app version below.
One SHOULD pay attention that they both show the same version (it doesn't display are they Stable, Canary etc, but it clearly displays the full version number like 24313 with the hex build like 8bfb30fe) - hence, MAKE SURE they both display the same version (and the same hex build id, although in fact they come in diff pairs)
It's possible to run with diff versions but no guarantee what kind of problems may happen if one would be substantially older than the other

Wen patching/direct installing/installing to inactive slot, Magisk app also clearly displays what is the target version - PAY ATTENTION that it prints the same target version as for your Magisk app running

---

If Magisk app displays N/A for the Magisk version it means that app (think again about as for the "manager') cannot find Magisk

It usually means that Magisk is not installed (yet or no more) - hence again, always PAY ATTENTION to that N/A case

There is also a possibility that Magisk is installed but user has two Magisk apps, ie also an old one, that was previously hidden/renamed but was not restored or deleted before updating to the new Magisk app - then only one of them can 'communicate' with Magisk and the other would display Magisk N/A - again something to be AWARE about and to be immediately resolved

---

Finally, if Magisk app displays Magisk N/A, it means that either Magisk is not installed or that app does not 'communicate' with - in either case the Magisk app has no root grant for itself and CANNOT do Direct install neither Install to inactive slots (hence it doesn't even display those options) - because ONLY with root, the app could patch the (live) boot partition (the active one or inactive one in case of A/B devices)

Without root, Magisk app can ONLY patch the boot image (file). User then has to flash himself the patched boot img:
- through Fastboot (recommended)
- through TWRP (applicable only to devices and Android versions with the TWRP available and 'fully'' working)

---

Btw, to cut-off my time and to avoid unnecessary booting the PC and device in Fastboot or TWRP mode, I usually flash my patched boot img through the Terminal app with:
Code:
su
dd if=/sdcard/Download/patched-boot.img of=/dev/block/bootdevice/by-name/boot
reboot

Here, to make it easier and to be able to always copy/paste that same command (dd if=...), I first rename the every-time different patched boot img to always the same name: patched-boot.img

Also, on A/B device you would need to specify for of= to be boot_a or boot_b (you must know which one is active and do you want to patch the active or inactive boot partition)

Ofc, disk-dump (dd) requires root (su), hence this is not applicable to the Magisk N/A case
 
Last edited:

Fishawy

Senior Member
Mar 26, 2010
3,210
552
Melbourne
OnePlus 9 Pro
@pndwal

Meanwhile i borked the latest update...temporarily - totally self inflicted and my fault, hence qualifies for a Spanner Award

Unhid the Magisk app
Updated app
Direct Installed magisk
Rebooted

Went to hide the app, gave it a shortcut name (i just call mine App) and hit the button, and just at that moment a notification popped up and lost the Magisk app window

Went back to drawer - nova can stay on page if you like it to, i do...but on this occasion as you will see if i hadnt had this turned on i might have noticed i had an issue and figured it out earlier and just deleted the duplicate (explanation coming)

Still had a Magisk app in the drawer, so assumed it had failed, so repeated the process....worked ...and no more Magisk app.

So i go to look for "App" and theres two...

One opens and looks normal apart from the Zygisk: No

The other prompts to complete full install of Magisk

Well thats fun....

Unhid the one that opened, uninstalled the remaining "App" and rebooted

Waited a few minutes

Hid the proper remaining Magisk to "App" and rebooted

Zygisk said : Yes

Happy Days!

Takeaway/Moral of this story:

Kids, dont do what daddy did and try and hide the Magisk app immediately after reboot, let the system settle, because this was entirely my fault for rushing things :)

Sometimes life really is like a box of Ponkles, you never know what youre going to get....
A similar thing happened to me yesterday when trying a Magisk module that hides Magisk manager app when opening any of the apps in DenyList, then restoring it once those apps are closed.

Problem is, I already had the Magisk manager app repackaged and named "Manager", and that was working perfectly. Reboot, gone. Still rooted though, but no app, and no way to 'unhide' it.

Stumbled for some time trying to figure out how to handle this. Ended up uninstalling the repackaged "Manager" app and installing Magisk manager, then re-applied my config.

Moral of the story: If it's working, don't fix it!
 
  • Like
Reactions: 73sydney

pndwal

Senior Member
Follow up to the @lindsaysxda case/discussion...

When patching/direct installing/installing to inactive slot, Magisk app also clearly displays what is the target version - ...

If the version number is 'wrong' then check your settings, Update channel - eg, if you have Magisk Canary app 24313 installed but your Update Channel is set to Stable, it will print (likely...) that it's patching/installing the target 24300 (latest Stable), not the 24313 being your installed Magisk app version
Just to clarify this point:

Update Channel no longer controls Magisk (mask) installations... To change target Magisk version, App must be changed / updated first.

Since we got Single package Magisk distribution (22.0), Magisk (mask itself) is not affected by Update channel and will always patch image or direct install/install to inactive slot using embedded (build specific) binaries. Ie. App Installed is always the target version for Magisk Install and this is regardless of Update channel...

This is also because we now also have entirely offline installation; Magisk doesn't call web hosted Magisk binaries any more and the APK package binaries are always called. Each APK only contains one corresponding set of binaries, so even if Debug channel is set and App Installed is 24313 for instance, Magisk Install will still call Canary 24313 binaries if Canary App was/is installed AFAIK... Users need to take Install App first if changing channel... An issue here is that knowing whether Debug or Canary is installed depends on users memory ATM AFAICS; a better naming convention may be needed to differentiate new Debug from Canary UIMS (unless I'm missing something).

This does mean that for in-app installation at least, Magisk (mask) will always match installed App if updated property as user now needs to update App before taking a Magisk (mask) update. (App will always be same version as Magisk (mask) or a later later version (if only App is updated), unless an app is downloaded and installed manually).

🤠 PW
 
Last edited:
  • Like
Reactions: rodken and zgfg

ipdev

Recognized Contributor
Feb 14, 2016
1,783
1
3,057
Google Nexus 10
Nexus 7 (2013)
@lindsaysxda
Hi. :)

I spent tonight testing something completely different on my Pixel 5a.
boot-looping and/or running into RED-boot. 🤬

Since I have been borking my Pixel 5a all night, I decided to give it a try. 🙃
I normally update manually. Only use OTA(s) when I have to.

I clean flashed Lineage 19.1 20220505 (barbet).
Installed Magisk (app) and patched the boot image.
Pulled the patched boot image.
Rebooted into fastboot (bootloader), flashed the patched boot image and rebooted.
Hid (renamed) the Magisk app and then took the newest Lineage OTA for barbet (20220519).
Download was quick but, it took longer than I expected to install.
Once done, I opened the Magisk (app) and used the patch-other-slot option.
I closed the Magisk (app) and went back to the OTA update and selected reboot.

It rebooted and I was on the 20220519 build with Magisk active (the new boot image was patched).
Magisk (app) was still hidden (renamed) and all was good.
At least one test I did tonight worked. 🙃


---

I might be wrong but, I thought you only had to uninstall/restore images for Factory/OEM ROM(s).
OnePlus used to download the full OTA instead of a partial OTA when "root" was detected.
Not sure if that is still the case.


Custom ROM(s) like Lineage, normally are not affected by root (Magisk).

Sorry if I missed it but, what device are you using?

Cheers. :cowboy:
 
Last edited:
  • Like
Reactions: rodken and pndwal

pndwal

Senior Member
@lindsaysxda
Hi. :)

I spent tonight testing something completely different on my Pixel 5a.

boot-looping and/or running into RED-boot. 🤬

Since I have been borking my Pixel 5a all night, I decided to give it a try. 🙃
I normally update manually. Only use OTA(s) when I have to.

I clean flashed Lineage 19.1 20220505 (barbet).
Installed Magisk (app) and patched the boot image.
Pulled the patched boot image.
Rebooted into fastboot (bootloader), flashed the patched boot image and rebooted.
Hid (renamed) the Magisk app and then took the newest Lineage OTA for barbet (20220519).
Download was quick but, it took longer than I expected to install.
Once done, I opened the Magisk (app) and used the patch-other-slot option.
I closed the Magisk (app) and went back to the OTA update and selected reboot.

It rebooted and I was on the 20220519 build with Magisk active (the new boot image was patched).
Magisk (app) was still hidden (renamed) and all was good.
At least one test I did tonight worked. 🙃


---

I might be wrong but, I thought you only had to uninstall/restore images for Factory/OEM ROM(s).
OnePlus used to download the full OTA instead of a partial OTA when "root" was detected.
Not sure if that is still the case.


Custom ROM(s) like Lineage, normally are not affected by root (Magisk).
This is true; only delta (incremental) OTAs should need Restore Images, so LOS updates (full ROM OTAs) don't.

Of course, Magisk root will be gone after OTA regardless, unless custom ROM complies with addon.d (v2 for A/B devices) and current Magisk was installed from custom recovery using apk as zip installer... (Code for addon.d still exists when Magisk is installed via app, but it's disabled.) The same methods to restore Magisk root will otherwise be needed.
Sorry if I missed it but, what device are you using?

Cheers. :cowboy:
Seems he's using Xiaomi Mi A1 w/ LOS 18.x ... Interesting early A/B (SAR) device launched w/ Android 7.1.2 and Android One OS instead of MIUI...

I'm interested to know this: On A/B devices using the OTA and Install Magisk to inactive slot method, after taking Uninstall Magisk, Restore Images but before rebooting, do you ever see Magisk Installed - N/A, Zygisk - Yes?... Seems strange to me, but perhaps it's as designed / intended...

🙂 PW
 
Last edited:
  • Like
Reactions: ipdev

lindsaysxda

Member
May 14, 2022
20
3
Xiaomi Mi A1
@ipdev Yes, I am using Mi A1 with latest LOS. Thanks for the info about LOS OTA. The OTA method in the magisk guide has always worked for me however. Uninstall restore images, then flash to inactive slot after installing ota, however this was on older magisk versions. I don't know why it's like this now. Maybe I fat fingered the complete uninstall button instead of restore images. And to be honest, these options shouldn't be on top of each other, but left and right.
 
Last edited:
  • Like
Reactions: m0han and ipdev

andrea0807

Senior Member
Jul 24, 2014
387
34
38
Perugia
Is there a magisk or lsposed module to assign the screenshot function to the long press of the home or overview button since the lineageos ROM does not allow it?
 

zgfg

Senior Member
Oct 10, 2016
7,369
4,761
Is there a magisk or lsposed module to assign the screenshot function to the long press of the home or overview button since the lineageos ROM does not allow it?
GravityBox for LSPosed - see the screenshot (I didn't try)
 

Attachments

  • IMG_20220526_173258.jpg
    IMG_20220526_173258.jpg
    263.9 KB · Views: 35
  • Like
Reactions: 73sydney

J.Michael

Recognized Contributor
Jan 20, 2018
1,160
1,095
Samsung Galaxy Tab A series
This is true; only delta (incremental) OTAs should need Restore Images, so LOS updates (full ROM OTAs) don't.

Of course, Magisk root will be gone after OTA regardless, unless custom ROM complies with addon.d (v2 for A/B devices) and current Magisk was installed from custom recovery using apk as zip installer... (Code for addon.d still exists when Magisk is installed via app, but it's disabled.) The same methods to restore Magisk root will otherwise be needed.

Seems he's using Xiaomi Mi A1 w/ LOS 18.x ... Interesting early A/B (SAR) device launched w/ Android 7.1.2 and Android One OS instead of MIUI...

I'm interested to know this: On A/B devices using the OTA and Install Magisk to inactive slot method, after taking Uninstall Magisk, Restore Images but before rebooting, do you ever see Magisk Installed - N/A, Zygisk - Yes?... Seems strange to me, but perhaps it's as designed / intended...

🙂 PW
When did Magisk Manager app stop displaying some mention of "A/B"-ness? I do not see any mention in @lindsaysxda's screenshot.
 

amk316

Senior Member
Dec 14, 2011
103
19
Samsung Galaxy S20
i delete magisk manger form my phone and install it if i need to use it so some apps don't find that i am rooted.

anyway the last update 24313 just add the manger shortcut every time i use an app with root access and that is vary annoying.

dose any one have the same problem? and how to stop it?
 

zgfg

Senior Member
Oct 10, 2016
7,369
4,761
I have lineage 19.1 gravitybox is not compatible
Sorry then, bad luck with LOS 19.1

I'm using GravityBox R, but of course with A11

Btw, I have the same option with another LSPosed module, CustoMIUIzer (screenshot) but it's only for Xiaomi (MIUI) phones
 

Attachments

  • IMG_20220526_184317.jpg
    IMG_20220526_184317.jpg
    201.8 KB · Views: 23
  • Like
Reactions: andrea0807

jonh42

New member
May 26, 2022
4
4
I need help, I just upgraded my Oneplus 6 from lineage 18 to 19 (Android 12) and when I want to flash magisk, I always end up in a bootloop with the both of the methods, the one with apk renamed as zip and the one with the recovery flashed as boot (I followed this tutorial btw)
 

zgfg

Senior Member
Oct 10, 2016
7,369
4,761
I need help, I just upgraded my Oneplus 6 from lineage 18 to 19 (Android 12) and when I want to flash magisk, I always end up in a bootloop with the both of the methods, the one with apk renamed as zip and the one with the recovery flashed as boot (I followed this tutorial btw)
Probably you have Magisk modules, not compatible with A12, that you didn't disable/uninstall before upgrading. They are installed at /dara/adb, hence they were not removed if you didn't ask for Factory reset

This problem has been discussed here several times, you can check in the previous posts
Actually, on Magisk GitHub, Wiki, there is a chapter on how to resolve
 
  • Like
Reactions: ipdev and jonh42

Top Liked Posts

  • 2
    Could be some module or mod?
    The only components I upgraded in the last weeks are:
    - Magisk Canary
    - USNF
    - Shamiko (same if using instead Unmount DenyList))
    - Momo (but I also downgraded Momo but did not help)
    wngraded Momo but did not help)

    All the rest, except for apps over Google play are not touched.
    I checked Google Play System Update, it's still May 1, 2022 - well before Momo started to detect su

    The whole mystery is in Magisk, Zygisk, Shamiko whatever

    TG, I don't have any sensitive app on the phone to start complaining about the root but frankly, with every new round of refactoring or revolutionary improvements, root detection becomes more vulnerable - I wonder why people who really want to run sensitive banking apps or so, that frantically follow all upgrades here. Seems that old technologies (eg MagiskHide in Delta) provide more: root but less vulnerable to detections

    Pls don't respond that preventing root detection is not TJW's business - we all know that. I'm talking from the users perspective, not from his or his employers perspective
    2
    Okay so there is no online installer of modules anymore? Thanks for the clarification.
    There is, extra app Fox MMM
    1
    Yes this is what I was doing in general, but now for the latest magisk version, I cannot flash disable dmverity forceencrypt.zip and then flash after it magisk.zip. I get an error "Unsupported boot image extra"
    Aside from what I already told you about Direct install (and I believe this applies to custom ROM zip installation also if updating previously installed Magisk rather than flashing over unrooted system) being broken / producing this type of error due to refactored MagiskInit when updating from 24.x or less, I see you have Galaxy Note 9... Despite launching with Android 8.1, since updating to Android 10 you now have 2SI "SAR" device, so you should read and follow Samsung (System-as-root) instructions:
    https://topjohnwu.github.io/Magisk/install.html#samsung-system-as-root

    - Just ignore the statement "If your Samsung device is NOT launched with Android 9.0 or higher, you are reading the wrong section"...

    ...But I want to disable force encryption in my device because I'm not able to access internal storage in twrp. Please I need help
    Is your recovery twrp-3.6.2_9-0-crownlte?... Doesn't it decrypt /data?

    🤠 PW
    1
    Aside from what I already told you about Direct install (and I believe this applies to custom ROM zip installation also if updating previously installed Magisk rather than flashing over unrooted system) being broken / producing this type of error due to refactored MagiskInit when updating from 24.x or less, I see you have Galaxy Note 9... Despite launching with Android 8.1, since updating to Android 10 you now have 2SI "SAR" device, so you should read and follow Samsung (System-as-root) instructions:
    https://topjohnwu.github.io/Magisk/install.html#samsung-system-as-root

    - Just ignore the statement "If your Samsung device is NOT launched with Android 9.0 or higher, you are reading the wrong section"...


    Is your recovery twrp-3.6.2_9-0-crownlte?... Doesn't it decrypt /data?

    🤠 PW
    That's the same thing I did bro, I got my stock AP and patched it in magisk then flashed the firmware with this patched AP using odin. But my data is still encrypted, I cannot see my internal storage in twrp, yes I have the latest twrp install and it doesn't ask me to decrypt /data, I cannot access data
    1
    Or boosted, actually :D
    Yup... But boost = catalyst for Oxidation... he's excited about Rust... 😛

    2 commits in his CXX (interop) repo, 1 in ONDK (w/ rust tool-chain), and 6 in Rust (Programming language) Custom and fix-lid branches in last 10 hrs...

    Of course this is all still relevant!:
    John Wu, Jun 19

    Magisk v25.1 published to public stable 🎉🎉
    www.twitter.com/topjohnwu/status/1534117522424811520/photo/1

    This marks the official start of v26's development cycle, which also starts the Oxidation Project (adding Rust to Magisk). So excited!
    www.twitter.com/topjohnwu/status/1538462758332575744

    ... and he's been studying Rust for more than a year... good to see such commitment being distilled now for Android modders benefit!

    Seems open source & equally committed contributors / collaborators have also allowed him to do this...
    https://forum.xda-developers.com/t/magisk-general-support-discussion.3432382/post-84827781

    Linus says Rust is coming to the Linux kernel "real soon now... Rust is a way to try something new. And hopefully, it works out, and people have been working on it a lot, so I really hope it works out because otherwise they'll be bummed."
    https://www.theregister.com/2022/06/23/linus_torvalds_rust_linux_kernel/

    Seems Rust is coming to Magisk injection for kernels 'real soon now' too... If Rust is a way to try something new, hopefully it works out for Magisk too... John's clearly been working on it a lot, so I really hope it works out... because we don't want to be given the bum's rush...

    😷 PW
  • 9
    Latest Official TJW Beta (release) Magisk build:

    Magisk

    2022.6.7 Magisk v25.0​

    Another major release! A lot of the changes aren’t visible at the surface, but v25 is actually a really substantial upgrade!

    MagiskInit Rewrite​

    A significant portion of magiskinit (the critical software that runs before your device boots up) is completely rewritten from scratch. Ever since Android introduced Project Treble in Android 8.0, Magisk has been constantly fighting against the increasingly complex partitioning and early mount setups of all kinds of devices, sometimes with weird OEM specific implementations. It got to a point that magiskinit had become so complicated that few people (including myself!) were aware of every detail, and maintaining this piece of software like this was clearly not sustainable. After many months of planning (yes, this whole re-architecture has been in my head for a long time) and some help from external contributors, a whole new sepolicy injection mechanism is introduced into Magisk, solving the “SELinux Problem” once and for all.

    Since this is a full paradigm shift on how Magisk hot-patch the device at boot, several behaviors that many developers implicitly relied on might not exist. For example, Magisk no longer patches fstabs in most scenarios, which means AVB will remain intact; some custom kernels rely on AVB being stripped out for them by Magisk.

    MagiskSU Security Enhancements​

    The superuser functionality of Magisk has not seen much changes ever since its introduction. v25 focuses on making root permission management more accurate and secure:

    • Add a whole new package tracking system to ensure malicious UID reuse attack cannot be performed
    • Properly support and implement the UX in the Magisk app for packages using sharedUserId
    • Enforce root manager APK signature verification to combat the rampant unofficial Magisk app “mods”
    Many might not realize, but using a trusted, unmodified Magisk app is really important. Magisk’s root daemon treats the Magisk app differently and gives it blanket root access without any restrictions. A modded Magisk app can potentially backdoor your device.

    And in case some of you are about to put on your tin foil hats, this is not designed to “vendor lock-in”; the goal is to make sure your root management app comes from the same developer of the underlying root implementation. Magisk’s build system allows custom distributors to use its own signing keys, and in addition, I am also providing official debug builds which skips any signature verification for development.

    Full Changelog: here

    Magisk Changelog​

    v25.0​

    • [MagiskInit] Update 2SI implementation, significantly increase device compatibility (e.g. Sony Xperia devices)
    • [MagiskInit] Introduce new sepolicy injection mechanism
    • [MagiskInit] Support Oculus Go
    • [MagiskInit] Support Android 13 GKIs (Pixel 6)
    • [MagiskBoot] Fix vbmeta extraction implementation
    • [App] Fix stub app on older Android versions
    • [App] [MagiskSU] Properly support apps using sharedUserId
    • [MagiskSU] Fix a possible crash in magiskd
    • [MagiskSU] Prune unused UIDs as soon as system_server restarts to prevent UID reuse attacks
    • [MagiskSU] Verify and enforce the installed Magisk app’s certificate to match the distributor’s signature
    • [MagiskSU] [Zygisk] Proper package management and detection
    • [Zygisk] Fix function hooking on devices running Android 12 with old kernels
    • [Zygisk] Fix Zygisk’s self code unloading implementation
    • [DenyList] Fix DenyList on shared UID apps
    • [BusyBox] Add workaround for devices running old kernels
    https://topjohnwu.github.io/Magisk/releases/25000.html

    🎉🎉 👍 PW
    7
    Latest Official TJW public Stable (release) Magisk build:

    Magisk

    Magisk Changelog​

    v25.1​

    • [MagiskBoot] Fix ramdisk backup being incorrectly skipped
    • [MagiskBoot] Add new feature to detect unsupported dtb and abort during installation
    • [Zygisk] Change binary hijack paths
    • [App] Fix incorrect recovery mode detection and installation
    • [MagiskInit] Fix config not properly exported in legacy SAR devices
    • [General] Enforce the Magisk app to always match or be newer than magiskd

    Release Notes:
    https://topjohnwu.github.io/Magisk/releases/25100.html

    For remaining diffs to public Stable 24.3, see Changelog for public Beta 25.0:
    https://forum.xda-developers.com/t/magisk-general-support-discussion.3432382/post-86993241

    🎉🎉 👍 PW
    6
    Thank you @zgfg and @ipdev . I have a fully working and automated script to both update my phone and patch & flash the magisk boot.img file. The only thing thats missing is the autoreboot after sideload but i guess TWRP has to implement this feature.

    The script can both be used as standalone or class to modify it for custom stuff. Ill continue to work on the repo and make everything neat, as well as working on windows and linux binarys & a gui for people that have no idea how to use scripts.

    Thank you guys for your help, this will save so much time for me and maybe even other people (at least i hope it will be used). :)

    Here it is on github
    6
    I've bought a Motorola Moto G71 5G. Unfortunately i cannot find a single thread about it on XDA. If i find it's stock ROM, what's the next steps to install magisk? How can i know that patching boot.img with magisk would work and not result in bootloop?
    You could opt for temporary root and check if it works or not. For that, boot your device via the Magisk patched boot file using the command-
    Code:
    fastboot boot magisk-patched-boot.img
    If everything's well and good, then open the Magisk app and select Direct Install. It will permanently root your device.
    However, if your device doesn't boot up, then retry with a force restart, it will be booted to the standard non-rooted OS.
    If you are still unable to boot to the OS, then flash the stock boot.img via
    Code:
    fastboot flash boot boot.img
    6
    Latest Official TJW Canary (release) & Debug (debug) Magisk builds:

    Magisk (34b2f525) (24316)​

    • [App] Fix stub app on older Android versions

    Diffs to v24.3​

    • [MagiskInit] Update 2SI implementation, significantly increase device compatibility (e.g. Sony Xperia devices)
    • [MagiskInit] Introduce new sepolicy injection mechanism
    • [MagiskInit] Support Oculus Go
    • [MagiskInit] Support Android 13 GKIs (Pixel 6)
    • [MagiskBoot] Fix vbmeta extraction implementation
    • [App] [MagiskSU] Properly support apps using shared UID
    • [App] Fix stub app on older Android versions
    • [MagiskSU] Fix a possible crash in magiskd
    • [MagiskSU] Prune unused UIDs as soon as possible to prevent UID reuse attacks
    • [MagiskSU] Verify and enforce the installed Magisk app's certificate to match the distributor's signature
    • [MagiskSU] Handle system_server restarts to prevent UID reuse abuse
    • [MagiskSU] [Zygisk] Proper package management and detection
    • [Zygisk] Fix function hooking on devices running Android 12 with old kernels
    • [Zygisk] Fix Zygisk's self code unloading implementation
    • [DenyList] Fix DenyList on shared UID apps
    • [BusyBox] Add workaround for devices running old kernels
    https://github.com/topjohnwu/magisk-files/blob/b4869a2d900721c508c974e5288edf29aee25e01/notes.md

    👍 PW
  • 1080
    This is the place for general support and discussion regarding "Public Releases", which includes both stable and beta releases.
    All information, including troubleshoot guides and notes, are in the Announcement Thread
    156
    Hello, I haven't given much support on XDA lately. It can be resulted from
    • University started and I have limited free time. In fact, I mostly develop during midnight
    • I live in Taiwan, which has large time zone differences between my European/American contributors/testers, which usually forces me to stay up late at night to discuss/test stuffs.
    • The new version is about to come, I don't want to spend effort on supporting old releases
    The planned update is delayed again and again, to some point I think I'll shed some light about what has been happening lately, also along with some announcements.

    New Forum!
    As you might have already discovered, Magisk got its own subforum on XDA! Many thanks to all the support you gave me, and much more information/features/support is about to come!
    **For developers supporting all the devices that are not using standard Android boot format, feel free to create threads in this section (actually, PLEASE do so) for your favorite devices after v7 is out. As I currently know, Asus devices require signing the boot image before flashing, and is model dependant; Sony devices seems to use ELF kernel that is unpatchable, or some has two ramdisks (inner + outer), both requires different workarounds; LG bootloader locked devices has to manually "BUMP" the boot image after flashing Magisk..... and there may be lots of other crazy boot image formats that haven't come up to my attention yet.
    It is impossible for me to support all these non-standard boot images, and I hope the community can collaborate to make Magisk running across all the devices. Overall, community collaboration is what XDA about :D

    The Pixel Phone
    Some of you might already know this news, that the next Pixel Phone right around the corner seems like it does not have ramdisk in boot image, which pretty much wrecked Magisk in all ways. However, it pretty much doomed root itself too. Kernel modifications is inevitable IMO, so I'll try to migrate my scripts to C programs that could possibly be included into the kernel itself. Note that I'm not familiar with linux kernel, I'm not even sure if my idea and concept is correct or not. But once the device is available, I think developers will find a way to bypass all the difficulties, and I'll do my best to learn things ;)

    Current Progress
    In the past month, I've spent quite some time learning SELinux, so that I can avoid using SuperSU's sepolicy patches. Thanks to the helps and tips from @phhusson and @Chainfire, I finally have a much clearer understanding of how SELinux works. The Magisk core parts (the scripts, boot image patches, new features, more supports) are actually done some time ago. What is causing all the delays is the Magisk Manager.
    To be completely honest, although I can code in Java without much issues, Magisk Manager is actually my first Android application, I had to reach out for assistance, and fortunately awesome developers like @DVDandroid and @digitalhigh contributed a lot, which makes the current Manager awesome.
    After the repo system and module management is mostly done, I was about to do some adjustments and release, but what we really done is decided to add another feature: auto-unroot with per-app settings. I decided to wait for it to be finished, and then do my adjustments. Due to reasons that'll be mentioned later, this feature will likely not be available for the next release (should come in future updates)

    Safety Net Disaster
    Those who are using Magisk for Safety Net bypass purposes must have known that Google recently updated the detection method of my Systemless Xposed. I still have no idea what Safety Net is detecting, so currently I cannot fix it on my side (also because I'm busy working on the next update). However, suhide developed by @Chainfire is able to hide Xposed and worked fine.
    However, only my Systemless Xposed v86.2, which is based on SuperSU's su.d, is supported using that method. v86.2 and v86.5 (latest, Magisk based) have nearly identical binaries, and the only difference is the path where the binaries are stored.
    I'm still not sure what's the real issue for it not being supported, I just hope it is not done intentionally.

    Conclusion
    Due to the fact that my Safety Net bypass is not 100% perfect now, I do not want to spend any more time waiting for auto-unroot to be polished. What I'm doing now is finishing up all the things I'd like to change in Magisk Manager (it has been a while since I last contributed to Manager, my fellow developers are doing all the heavy job), which might take a little more time, after that, packed with tons of information to be announced in Magisk Section, I'll release the long awaited update.

    Hope this lengthy post gives you the idea of the whole situation, and again thanks for all your support!!
    121
    Ah, some Chainfire bashing, I hope it is not too late for me to exercise additional villainy.

    First, let me make clear I have nothing against @topjohnwu, nor against Magisk. Magisk is an interesting project and it certainly displays @topjohnwu ingenuity and persistence. I don't doubt we will see more interesting things from his hands.

    -------------------------

    What has happened here is not all that dark and complicated, from either end. I returned from holidays, and someone pointed me at Magisk. My first thought: interesting!

    Among other things, the thread lists some issues with SuperSU, which in combination with the phrase The developer also requests users to not bug Chainfire with compatibility requests for SuperSU with Magisk from the portal article, raised my left eyebrow by nigh half an inch. The popular systemless xposed mod is apparently now based on it, and apparently it now no longer works with SuperSU, and apparently I'm not supposed to fix that, nor any of the other found issues. I found that a bit weird. So yes, I have told @topjohnwu that I was a bit surprised he was posting about issues with SuperSU without notifying me about them (I can't fix or help fix issues I'm not aware of, after all).

    He's also spreading a modified version of the SuperSU package, which is not all that uncommon, nor necessarily a problem. I have not looked into what he modified, I only ran a few quick tests on one of my devices, and found some commonly used commands run as root to be broken. I have informed him of this as well.

    It appears the tool of choice for Magisk is phh's Superuser, because of some of the mentioned issues with SuperSU. That's fine by itself, but fixing issues in that superuser by incorporating SuperSU's binaries into it is a somewhat questionable practise. After all, SuperSU is a commercial closed-source package that helps pay for my dinner, and superuser is a direct competitor. I have informed him that I was surprised he did this without asking for permission. I have expressed similar surprise on him spreading a modified version of LiveBoot (which helps pay for a snack now and then).
    @topjohnwu has also stated that Magisk's scripts are largely influenced by mine (I have not checked). Scripts based on mine are used all over the place on XDA, some people have crafted amazing things based on them, I have never made an issue of this (otherwise I would have just made them binaries). But yes, I have also stated to him that I don't think it's very nice to base something on one program, and then using that to (almost exclusively) push something directly competing with that program.

    tl;dr Towards @topjohnwu, I have:
    - expressed surprise he has issues getting Magisk to work with SuperSU, and has chosen not to inform me about those
    - expressed surprise he is using SuperSU binaries in a competing superuser without permission
    - expressed surprise he is posting a modified LiveBoot without permission
    - informed him of issues with the modified SuperSU he has posted
    - let him know I thought it wasn't very nice to be applying my scripts to benefit seemingly exclusively that same competing superuser

    To be crystal clear:
    - I have not asked for an apology
    - I have not asked for Magisk to be abandoned, neither the root hiding nor systemless module parts, and certainly not systemless xposed
    - I have not made an issue of any of this anywhere, until this post
    - I have not even specifically asked for anything to be taken down (though obviously in my opinion the other superuser package mixed with SuperSU's binaries, as well as the LiveBoot package, should go)
    - I have not reported this thread to XDA moderators for copyright violations or otherwise

    While my conversation with @topjohnwu may not win any awards for being friendly (though it may win some for brevity), I think all things considered my response has been rather mild. To be perfectly honest, until the apology post, I thought this was over with already. I think the apology post was triggered because I haven't replied to his last PM for a while - I was in the zone, it happens.

    To emphasize again, I have nothing against @topjohnwu, Magisk, or systemless xposed, and it is certainly not my goal to see any of them go. If it can be made to work together with SuperSU, great.

    I get it though: you think of something, you want to see if you can make it work, you finally get it to work, you publish it, it takes off - enthusiasm gets the better of you. Maybe in the rush some mistakes are made. That doesn't mean you have to just drop it and run. None of my stuff would make it past 0.1 if I stopped at the first big mistake :)

    Aside from said being in the zone coding, I usually regret actually responding to these sort of things the day after, which has made me hesitant to reply. Surprise me.
    76
    Thread temporarily closed so everyone sees this.

    The flood of "SafetyNet isn't working for me either!" posts are not helpful, at all. Please refrain from posting further, it will be looked into. Please do not forget that not passing SafetyNet is 100% NORMAL AND INTENDED when you have an unlocked booloader or running custom firmware. These are workarounds and they will be worked around in turn.

    The Flash
    Forum Moderator

    EDIT: Thread is reopened... I will be cleaning any SafetyNet posts for a while to keep the thread clean for real issues.
    75
    Hello everyone!

    I am aware that Google has updated Safety Net that makes Magisk itself a no go for Android Pay. In fact, I witnessed the change live while I am developing the new magiskhide, which should hide all Magisk modules and Magisk installed root.

    Google is serious about Safety Net now, clearly hunting down all possibility to run Xposed with Safety Net passed. I spend quite some time examining the new security measures last midnight, and fortunately it seems that it is possible to run Magisk and root along with Safety Net if no Xposed is running. I'm glad I removed the old root toggle at the right time lol, that is no longer feasible with the latest detection.

    So stay tuned for the next update, it will come with bug fixes, along with the new magiskhide to bypass that Safety Net.

    Google, how will a few systemless mods do any harm :p:p