Magisk General Support / Discussion

Search This thread
By:
Advanced…
P

pndwal

Senior Member
Jun 23, 2016
4,671
4,873
Sydney
Redmi Note 8
Xiaomi Redmi Note 8 (2021)
ipdev said:
Yep.
My fork includes (and updated) with the official links. 🙃

Did you notice the additional file. 😛
Code: 
"link": "https://cdn.jsdelivr.net/gh/ipdev99/[email protected]/app-debug.apk",
Click to expand...
Click to collapse
😕 Sorry - clearly was looking in master branch! 😬 ... see your channel is correct... I'll look closer when have time... Guess installs from there are working... Custom channel thing?
ipdev said:
The stub version only shows if magisk (apk) is hidden (renamed).
Click to expand...
Click to collapse
Of course...
ipdev said:
Since the stub is only used when the full app is not installed, there is no reason to show the stub version of the full app.

Cheers Mate. :cowboy:
Click to expand...
Click to collapse
But you're not getting this. 🤪

In both examples above (screenshots shown) App is hidden (uninstalled), stub installed (and updated with full App's binary data), and Stub version therefore shows.

It seems that the full complement of debug built components should be installed for properly working debugging...

My initial issue report included a suggested means to indicate if any discrete component is built as debug. (With new Debug builds, Stub is also built in debug mode, and is nearly twice the size.

WIth
App Installed xxxxxxxx (2431x) (xx) (D)
solution, it appears that Debug App is installed, whether as full app or embedded in Stub app data.

In the first instance, Debug App is indeed embedded in data of Stub app (itself 45kb) also built in debug mode. In the second, only the app data embedded in stub is debug while the Stub app (27kb) itself is built as release.

There is no indication when Magisk is configured with these mixed debug and release components. This is why I suggested this format:
App Installed xxxxxxxx (2431x-D) (xx-D)

Anyway we're even. 😝 PW
 
Last edited:
  • Like
Reactions: ipdev
Stillhard

Stillhard

Senior Member
Sep 25, 2016
138
109
Latest Magisk Changelog after last Canary release:

- Update VN translation
- Update Portugueses Translations
- Update French translation
- Update RU strings
- Update build scripts
- Move things to the correct location
- Update zh-rTW translation
- Update zh-rCN translation
- More debug indication in UI
- Avoid non-blocking I/O
- Make SYSTEM_UID a special case
- Prune unused UID at boot
- Proper package state management
- Fix incorrect use of compare_exchange

nightly.link Download
 
  • Like
Reactions: Homeboy76 and dr4go
F

faknit

Member
May 27, 2022
7
0
Hey all,

I have a Pixel 5 with LineageOS for MicroG 18.1, running:

Magisk 24.3
MagiskHide Props Config 6.1.2
Shamiko 0.5.0
USNF 2.2.1

I have dev mode turned off. I'm running a specific application in Shelter, and yet I can't find a way to hide root from it to save my life. Some of the logs that seems to correlate are:

2160 103 I Infrastructure sbm: .[103] SuFinder#run: Device rooted - shell which commands

103 I Infrastructure sbm: .[103] RwChecker#rwPartitionExists: Found rw(10300 10185 0:36 / /system/bin rw,relatime master:38 - tmpfs tmpfs rw,seclabel). Reporting device as rooted!

103 I Infrastructure sbm: .[103] RwChecker#run: Device rooted - RW partitions

2160 103 I Infrastructure sbm: .[103] c#a: Extra data contains: {"rootedTypes":["rootedRWSystem","suFileFound"],"SUFileFound":true,"suFileDetection":"checkWhichSuCommand","suFileOutput":"/system/bin/su","PartitionWritable":true,"rwPermissionOutput":"10300 10185 0:36 / /system/bin rw,relatime master:38 - tmpfs tmpfs rw,seclabel","DMVerityChanged":false,"SUPartitionAdded":false,"UnixSocketOpened":false,"MagiskHideDetected":false,"SystemRootProperties":false}

84 I Infrastructure sbm: .[84] PropertiesRetrySendMsgHandler#getDeviceProp: start running properties detectors: 11 05-31 15:28:40.320 2160 84 I Infrastructure sbm: .[84] PropertiesRetrySendMsgHandler#getDeviceProp: running detection: [ ADB-ENABLED ]​

Any insight on where to look to get this application to work would be greatly appreciated!
 
P

pndwal

Senior Member
Jun 23, 2016
4,671
4,873
Sydney
Redmi Note 8
Xiaomi Redmi Note 8 (2021)
faknit said:
Hey all,

I have a Pixel 5 with LineageOS for MicroG 18.1, running:

Magisk 24.3
MagiskHide Props Config 6.1.2
Shamiko 0.5.0
USNF 2.2.1

I have dev mode turned off. I'm running a specific application in Shelter, and yet I can't find a way to hide root from it to save my life. Some of the logs that seems to correlate are:

2160 103 I Infrastructure sbm: .[103] SuFinder#run: Device rooted - shell which commands

103 I Infrastructure sbm: .[103] RwChecker#rwPartitionExists: Found rw(10300 10185 0:36 / /system/bin rw,relatime master:38 - tmpfs tmpfs rw,seclabel). Reporting device as rooted!

103 I Infrastructure sbm: .[103] RwChecker#run: Device rooted - RW partitions

2160 103 I Infrastructure sbm: .[103] c#a: Extra data contains: {"rootedTypes":["rootedRWSystem","suFileFound"],"SUFileFound":true,"suFileDetection":"checkWhichSuCommand","suFileOutput":"/system/bin/su","PartitionWritable":true,"rwPermissionOutput":"10300 10185 0:36 / /system/bin rw,relatime master:38 - tmpfs tmpfs rw,seclabel","DMVerityChanged":false,"SUPartitionAdded":false,"UnixSocketOpened":false,"MagiskHideDetected":false,"SystemRootProperties":false}

84 I Infrastructure sbm: .[84] PropertiesRetrySendMsgHandler#getDeviceProp: start running properties detectors: 11 05-31 15:28:40.320 2160 84 I Infrastructure sbm: .[84] PropertiesRetrySendMsgHandler#getDeviceProp: running detection: [ ADB-ENABLED ]​

Any insight on where to look to get this application to work would be greatly appreciated!
Click to expand...
Click to collapse
YASNAC results? PW
 
X

xerves78

Senior Member
Dec 6, 2015
228
30
NRW
i have lineage 19.1 official and want to install magisk
i patched the boot.img from the lineage 19.1 image and flashed it
but now i get a lineage Boot loop

why ?
 
P

pndwal

Senior Member
Jun 23, 2016
4,671
4,873
Sydney
Redmi Note 8
Xiaomi Redmi Note 8 (2021)
pndwal said:
I can smell 25 ... 😛 PW
Click to expand...
Click to collapse
New In-app contributor credits (nice touch John!):

topjohnwu (John Wu),
vvb2060(南宮雪珊, 'Nangong Xueshan')
yujincheng08 (LoveSy, Shana),
RikkaW (SHAAAAARK!)

diareuse removed!?

Update contributors in app
topjohnwu committed 38 minutes ago

Actions test preview:

IMG_20220603_000242.jpg


👀 PW
 
Last edited:
  • Like
Reactions: dr4go and casouzaj
P

pndwal

Senior Member
Jun 23, 2016
4,671
4,873
Sydney
Redmi Note 8
Xiaomi Redmi Note 8 (2021)
Latest Official TJW Canary (release) & Debug (debug) Magisk builds:

Magisk (2106751e) (24315)​

  • [MagiskSU] [Zygisk] Proper package management and detection
  • [Zygisk] Fix Zygisk's self code unloading implementation
  • [App] Many many fixes, especially on older Android devices

Diffs to v24.3​

  • [MagiskInit] Update 2SI implementation, significantly increase device compatibility (e.g. Sony Xperia devices)
  • [MagiskInit] Introduce new sepolicy injection mechanism
  • [MagiskInit] Support Oculus Go
  • [MagiskInit] Support Android 13 GKIs (Pixel 6)
  • [MagiskBoot] Fix vbmeta extraction implementation
  • [App] [MagiskSU] Properly support apps using shared UID
  • [MagiskSU] Fix a possible crash in magiskd
  • [MagiskSU] Prune unused UIDs as soon as possible to prevent UID reuse attacks
  • [MagiskSU] Verify and enforce the installed Magisk app's certificate to match the distributor's signature
  • [MagiskSU] Handle system_server restarts to prevent UID reuse abuse
  • [MagiskSU] [Zygisk] Proper package management and detection
  • [Zygisk] Fix function hooking on devices running Android 12 with old kernels
  • [Zygisk] Fix Zygisk's self code unloading implementation
  • [DenyList] Fix DenyList on shared UID apps
  • [BusyBox] Add workaround for devices running old kernels
https://github.com/topjohnwu/magisk-files/blob/fa95b510ce952dcbd45c54bd4b429d31ed847af3/notes.md

👍 PW
 
Last edited:
  • Like
Reactions: tramp20, belair56, jakito and 2 others
M

martyfender

Senior Member
Mar 9, 2017
3,268
1,746
Indianapolis, IN
I
pndwal said:
Hiding the Magisk app is broken for me (Xiaomi Redmi Note 8T) in this build. PW
Click to expand...
Click to collapse
I just switched over on on one of my devices from the alpha and I couldn't get hiding to work either. I ended up with the regular app and the hidden app named settings. Only the regular app will launch.
The hidden app will not launch, even after removal of the unhid app.
 
  • Like
Reactions: pndwal
zgfg

zgfg

Senior Member
Oct 10, 2016
7,595
5,000
martyfender said:
I

I just switched over on on one of my devices from the alpha and I couldn't get hiding to work either. I ended up with the regular app and the hidden app named settings. Only the regular app will launch.
The hidden app will not launch, even after removal of the unhid app.
Click to expand...
Click to collapse
Supposidely, hidden app was older - then you had to uninstall that one

Anyway, uninstall both Magisk apps (not Magisk itself) and install only the correct one, corresponding to the new/current Magisk branch and version

Once, that will be working correctly, then hide it
 
  • Like
Reactions: J.Michael
D

deep_raman

Member
Feb 3, 2015
25
3
Gurgaon
Company Intune Portal no more working with magisk root. Configure deny list but i think app got an update and outlook teams and intune no more working now. It says device unhealthy. Please help
 
You must log in or register to reply here.

Similar threads

T
  • Locked
  • Sticky
Magisk - The Magic Mask for Android
Replies
56
Views
6M
T
topjohnwu
T
  • Locked
[CLOSED][BETA][2018.7.19] Magisk v16.7 (1671)
Replies
7K
Views
3M
T
topjohnwu
Heisenberg
[Discussion] PokeMon Go Magisk Discussion Thread
Replies
5K
Views
628K
djkrish5610
djkrish5610
yochananmarqos
  • Sticky
Collection of Magisk Modules v2
Replies
1K
Views
1M
Z
zyhk
Didgeridoohan
[Discussion] Google Pay Magisk Discussion Thread
Replies
3K
Views
462K
Fishawy
Fishawy

Top Liked Posts

24 Hours 30 Days All time
  • 5
    zgfg
    zgfg
    By the way, there is another thread with detailed OP instructions for the new Magisk v24/v25:

    [Discussion] Magisk - The Age of Zygisk.

    This is a discussion and help thread for the...
    forum.xda-developers.com forum.xda-developers.com

    And a thread that was opened for hiding root with the new Magisk:

    [Discussion] How to bypass detections of rooting ?

    Did you have problems with some app that...
    forum.xda-developers.com forum.xda-developers.com

    Those new threads were opened because of this old and cluttered thread.
    Unfortunately, people still report/ask here (and in parallel complain that thread is too big to read☹️)
    View
    3
    P
    pndwal
    Stillhard said:
    As always, 'The Masturbate Girl' - Mad donno
    Click to expand...
    Click to collapse
    Why do you continue this theme... I never read where John Wu said it either; just hearsay...

    I don't need to keep hearing such remarks about anyone helping with Magisk etc, but confess I prefer polite company... And this is impolite (at best) at least among English speakers... 🙄 PW
    View
    3
    zgfg
    zgfg
    Franzyy said:
    I have a issue in magisk where i cant activate mobile data and make calls anymore, it also says no imei, please fix it in the next update. I use the A32 (a325f) where i flashed magisk through boot.img
    More about this here:

    [fixed] rooted a325m suddenly no imei, no sim

    I rooted my a325m by patching the stock AP...
    forum.xda-developers.com forum.xda-developers.com
    Click to expand...
    Click to collapse
    Who will fix it?!

    Developer(s) don't read this thread

    To report issues, you need to go to Magisk GitHub 🤣
    View
    2
    maakosan
    maakosan
    ipdev said:
    I am just confused. 🙃
    More "What The ???"​
    ___


    - Did you patch the recovery image with Magisk.
    - Replace the recovery image with the Magisk patched version and boot into system from Recovery
    or..
    Did you you use recovery to install Magisk (patch the boot image)?

    I have only had a 7T for a few weeks.
    Since OnePlus has switched their release/updates to OTA only, it took me a little while to find a boot image.​
    Once I found it, I patched it with Magisk and ...​

    Currently my (new-to-me) 7T is on the a12 beta.
    I was testing the fingerprint scanner.​

    I was planning on restoring to stable/stock OOS this weekend.
    If you are running a custom ROM or kernel, let me know.
    I am willing to test. 🙂
    ___



    OnePlus 7T partitions.
    Code: 
    OnePlus7T:/ # ls -la dev/block/by-name/
total 0
drwxr-xr-x 2 root root 2520 1972-09-19 21:06 .
drwxr-xr-x 6 root root 4280 1972-09-19 21:06 ..
lrwxrwxrwx 1 root root   15 1972-09-19 21:06 ALIGN_TO_128K_1 -> /dev/block/sdd1
lrwxrwxrwx 1 root root   15 1972-09-19 21:06 ALIGN_TO_128K_2 -> /dev/block/sdf1
lrwxrwxrwx 1 root root   16 1972-09-19 21:06 LOGO_a -> /dev/block/sde21
lrwxrwxrwx 1 root root   16 1972-09-19 21:06 LOGO_b -> /dev/block/sde47
lrwxrwxrwx 1 root root   15 1972-09-19 21:06 abl_a -> /dev/block/sde8
lrwxrwxrwx 1 root root   16 1972-09-19 21:06 abl_b -> /dev/block/sde35
lrwxrwxrwx 1 root root   16 1972-09-19 21:06 aging -> /dev/block/sde54
lrwxrwxrwx 1 root root   16 1972-09-19 21:06 aging_mod -> /dev/block/sde55
lrwxrwxrwx 1 root root   15 1972-09-19 21:06 aop_a -> /dev/block/sde1
lrwxrwxrwx 1 root root   16 1972-09-19 21:06 aop_b -> /dev/block/sde28
lrwxrwxrwx 1 root root   16 1972-09-19 21:06 apdp -> /dev/block/sde59
lrwxrwxrwx 1 root root   15 1972-09-19 21:06 bluetooth_a -> /dev/block/sde5
lrwxrwxrwx 1 root root   16 1972-09-19 21:06 bluetooth_b -> /dev/block/sde32
lrwxrwxrwx 1 root root   16 1972-09-19 21:06 boot_a -> /dev/block/sde11
lrwxrwxrwx 1 root root   16 1972-09-19 21:06 boot_b -> /dev/block/sde38
lrwxrwxrwx 1 root root   16 1972-09-19 21:06 carrier -> /dev/block/sda15
lrwxrwxrwx 1 root root   16 1972-09-19 21:06 catecontentfv -> /dev/block/sde72
lrwxrwxrwx 1 root root   16 1972-09-19 21:06 catefv -> /dev/block/sde71
lrwxrwxrwx 1 root root   16 1972-09-19 21:06 cateloader -> /dev/block/sde66
lrwxrwxrwx 1 root root   15 1972-09-19 21:06 cdt -> /dev/block/sdd2
lrwxrwxrwx 1 root root   16 1972-09-19 21:06 cmnlib64_a -> /dev/block/sde13
lrwxrwxrwx 1 root root   16 1972-09-19 21:06 cmnlib64_b -> /dev/block/sde40
lrwxrwxrwx 1 root root   16 1972-09-19 21:06 cmnlib_a -> /dev/block/sde12
lrwxrwxrwx 1 root root   16 1972-09-19 21:06 cmnlib_b -> /dev/block/sde39
lrwxrwxrwx 1 root root   16 1972-09-19 21:06 config -> /dev/block/sda12
lrwxrwxrwx 1 root root   16 1972-09-19 21:06 core_nhlos -> /dev/block/sde20
lrwxrwxrwx 1 root root   15 1972-09-19 21:06 ddr -> /dev/block/sdd3
lrwxrwxrwx 1 root root   16 1972-09-19 21:06 devcfg_a -> /dev/block/sde14
lrwxrwxrwx 1 root root   16 1972-09-19 21:06 devcfg_b -> /dev/block/sde41
lrwxrwxrwx 1 root root   16 1972-09-19 21:06 devinfo -> /dev/block/sde57
lrwxrwxrwx 1 root root   16 1972-09-19 21:06 dip -> /dev/block/sde58
lrwxrwxrwx 1 root root   15 1972-09-19 21:06 dsp_a -> /dev/block/sde9
lrwxrwxrwx 1 root root   16 1972-09-19 21:06 dsp_b -> /dev/block/sde36
lrwxrwxrwx 1 root root   16 1972-09-19 21:06 dtbo_a -> /dev/block/sde17
lrwxrwxrwx 1 root root   16 1972-09-19 21:06 dtbo_b -> /dev/block/sde44
lrwxrwxrwx 1 root root   15 1972-09-19 21:06 frp -> /dev/block/sda6
lrwxrwxrwx 1 root root   15 1972-09-19 21:06 fsc -> /dev/block/sdf5
lrwxrwxrwx 1 root root   15 1972-09-19 21:06 fsg -> /dev/block/sdf4
lrwxrwxrwx 1 root root   16 1972-09-19 21:06 fw_ufs1_a -> /dev/block/sde22
lrwxrwxrwx 1 root root   16 1972-09-19 21:06 fw_ufs1_b -> /dev/block/sde48
lrwxrwxrwx 1 root root   16 1972-09-19 21:06 fw_ufs2_a -> /dev/block/sde23
lrwxrwxrwx 1 root root   16 1972-09-19 21:06 fw_ufs2_b -> /dev/block/sde49
lrwxrwxrwx 1 root root   16 1972-09-19 21:06 fw_ufs3_a -> /dev/block/sde24
lrwxrwxrwx 1 root root   16 1972-09-19 21:06 fw_ufs3_b -> /dev/block/sde50
lrwxrwxrwx 1 root root   16 1972-09-19 21:06 fw_ufs4_a -> /dev/block/sde25
lrwxrwxrwx 1 root root   16 1972-09-19 21:06 fw_ufs4_b -> /dev/block/sde51
lrwxrwxrwx 1 root root   16 1972-09-19 21:06 fw_ufs5_a -> /dev/block/sde26
lrwxrwxrwx 1 root root   16 1972-09-19 21:06 fw_ufs5_b -> /dev/block/sde52
lrwxrwxrwx 1 root root   15 1972-09-19 21:06 hyp_a -> /dev/block/sde3
lrwxrwxrwx 1 root root   16 1972-09-19 21:06 hyp_b -> /dev/block/sde30
lrwxrwxrwx 1 root root   16 1972-09-19 21:06 imagefv_a -> /dev/block/sde19
lrwxrwxrwx 1 root root   16 1972-09-19 21:06 imagefv_b -> /dev/block/sde46
lrwxrwxrwx 1 root root   16 1972-09-19 21:06 keymaster_a -> /dev/block/sde10
lrwxrwxrwx 1 root root   16 1972-09-19 21:06 keymaster_b -> /dev/block/sde37
lrwxrwxrwx 1 root root   15 1972-09-19 21:06 keystore -> /dev/block/sda5
lrwxrwxrwx 1 root root   16 1972-09-19 21:06 limits -> /dev/block/sde63
lrwxrwxrwx 1 root root   16 1972-09-19 21:06 logdump -> /dev/block/sde67
lrwxrwxrwx 1 root root   16 1972-09-19 21:06 logfs -> /dev/block/sde65
lrwxrwxrwx 1 root root   15 1972-09-19 21:06 mdm1m9kefs1 -> /dev/block/sdf7
lrwxrwxrwx 1 root root   15 1972-09-19 21:06 mdm1m9kefs2 -> /dev/block/sdf8
lrwxrwxrwx 1 root root   15 1972-09-19 21:06 mdm1m9kefs3 -> /dev/block/sdf6
lrwxrwxrwx 1 root root   15 1972-09-19 21:06 mdm1m9kefsc -> /dev/block/sdf9
lrwxrwxrwx 1 root root   16 1972-09-19 21:06 mdm1oemnvbktmp -> /dev/block/sde77
lrwxrwxrwx 1 root root   16 1972-09-19 21:06 mdm_oem_dycnvbk -> /dev/block/sda10
lrwxrwxrwx 1 root root   16 1972-09-19 21:06 mdm_oem_stanvbk -> /dev/block/sda11
lrwxrwxrwx 1 root root   15 1972-09-19 21:06 mdmddr -> /dev/block/sdd4
lrwxrwxrwx 1 root root   15 1972-09-19 21:06 mdtp_a -> /dev/block/sde7
lrwxrwxrwx 1 root root   16 1972-09-19 21:06 mdtp_b -> /dev/block/sde34
lrwxrwxrwx 1 root root   15 1972-09-19 21:06 mdtpsecapp_a -> /dev/block/sde6
lrwxrwxrwx 1 root root   16 1972-09-19 21:06 mdtpsecapp_b -> /dev/block/sde33
lrwxrwxrwx 1 root root   16 1972-09-19 21:06 metadata -> /dev/block/sda21
lrwxrwxrwx 1 root root   15 1972-09-19 21:06 misc -> /dev/block/sda3
lrwxrwxrwx 1 root root   15 1972-09-19 21:06 modem_a -> /dev/block/sde4
lrwxrwxrwx 1 root root   16 1972-09-19 21:06 modem_b -> /dev/block/sde31
lrwxrwxrwx 1 root root   15 1972-09-19 21:06 modemst1 -> /dev/block/sdf2
lrwxrwxrwx 1 root root   15 1972-09-19 21:06 modemst2 -> /dev/block/sdf3
lrwxrwxrwx 1 root root   16 1972-09-19 21:06 msadp -> /dev/block/sde60
lrwxrwxrwx 1 root root   16 1972-09-19 21:06 multiimgoem_a -> /dev/block/sde27
lrwxrwxrwx 1 root root   16 1972-09-19 21:06 multiimgoem_b -> /dev/block/sde53
lrwxrwxrwx 1 root root   15 1972-09-19 21:06 oem_dycnvbk -> /dev/block/sda8
lrwxrwxrwx 1 root root   15 1972-09-19 21:06 oem_stanvbk -> /dev/block/sda9
lrwxrwxrwx 1 root root   16 1972-09-19 21:06 op1 -> /dev/block/sde56
lrwxrwxrwx 1 root root   15 1972-09-19 21:06 op2 -> /dev/block/sda7
lrwxrwxrwx 1 root root   16 1972-09-19 21:06 opproduct_a -> /dev/block/sda13
lrwxrwxrwx 1 root root   16 1972-09-19 21:06 opproduct_b -> /dev/block/sda14
lrwxrwxrwx 1 root root   15 1972-09-19 21:06 param -> /dev/block/sda4
lrwxrwxrwx 1 root root   15 1972-09-19 21:06 persist -> /dev/block/sda2
lrwxrwxrwx 1 root root   16 1972-09-19 21:06 qupfw_a -> /dev/block/sde15
lrwxrwxrwx 1 root root   16 1972-09-19 21:06 qupfw_b -> /dev/block/sde42
lrwxrwxrwx 1 root root   16 1972-09-19 21:06 rawdump -> /dev/block/sda22
lrwxrwxrwx 1 root root   16 1972-09-19 21:06 recovery_a -> /dev/block/sda17
lrwxrwxrwx 1 root root   16 1972-09-19 21:06 recovery_b -> /dev/block/sda18
lrwxrwxrwx 1 root root   16 1972-09-19 21:06 reserve1 -> /dev/block/sde73
lrwxrwxrwx 1 root root   16 1972-09-19 21:06 reserve2 -> /dev/block/sde74
lrwxrwxrwx 1 root root   16 1972-09-19 21:06 reserve3 -> /dev/block/sde75
lrwxrwxrwx 1 root root   16 1972-09-19 21:06 reserve4 -> /dev/block/sde76
lrwxrwxrwx 1 root root   14 1972-09-19 21:06 sda -> /dev/block/sda
lrwxrwxrwx 1 root root   14 1972-09-19 21:06 sdb -> /dev/block/sdb
lrwxrwxrwx 1 root root   14 1972-09-19 21:06 sdc -> /dev/block/sdc
lrwxrwxrwx 1 root root   14 1972-09-19 21:06 sdd -> /dev/block/sdd
lrwxrwxrwx 1 root root   14 1972-09-19 21:06 sde -> /dev/block/sde
lrwxrwxrwx 1 root root   14 1972-09-19 21:06 sdf -> /dev/block/sdf
lrwxrwxrwx 1 root root   16 1972-09-19 21:06 secdata -> /dev/block/sde70
lrwxrwxrwx 1 root root   16 1972-09-19 21:06 splash -> /dev/block/sde62
lrwxrwxrwx 1 root root   16 1972-09-19 21:06 spunvm -> /dev/block/sde61
lrwxrwxrwx 1 root root   15 1972-09-19 21:06 ssd -> /dev/block/sda1
lrwxrwxrwx 1 root root   16 1972-09-19 21:06 storsec_a -> /dev/block/sde68
lrwxrwxrwx 1 root root   16 1972-09-19 21:06 storsec_b -> /dev/block/sde78
lrwxrwxrwx 1 root root   16 1972-09-19 21:06 super -> /dev/block/sda16
lrwxrwxrwx 1 root root   16 1972-09-19 21:06 toolsfv -> /dev/block/sde64
lrwxrwxrwx 1 root root   15 1972-09-19 21:06 tz_a -> /dev/block/sde2
lrwxrwxrwx 1 root root   16 1972-09-19 21:06 tz_b -> /dev/block/sde29
lrwxrwxrwx 1 root root   16 1972-09-19 21:06 uefisecapp_a -> /dev/block/sde18
lrwxrwxrwx 1 root root   16 1972-09-19 21:06 uefisecapp_b -> /dev/block/sde45
lrwxrwxrwx 1 root root   16 1972-09-19 21:06 uefivarstore -> /dev/block/sde69
lrwxrwxrwx 1 root root   16 1972-09-19 21:06 userdata -> /dev/block/sda23
lrwxrwxrwx 1 root root   16 1972-09-19 21:06 vbmeta_a -> /dev/block/sde16
lrwxrwxrwx 1 root root   16 1972-09-19 21:06 vbmeta_b -> /dev/block/sde43
lrwxrwxrwx 1 root root   16 1972-09-19 21:06 vbmeta_system_a -> /dev/block/sda19
lrwxrwxrwx 1 root root   16 1972-09-19 21:06 vbmeta_system_b -> /dev/block/sda20
lrwxrwxrwx 1 root root   15 1972-09-19 21:06 xbl_a -> /dev/block/sdb1
lrwxrwxrwx 1 root root   15 1972-09-19 21:06 xbl_b -> /dev/block/sdc1
lrwxrwxrwx 1 root root   15 1972-09-19 21:06 xbl_config_a -> /dev/block/sdb2
lrwxrwxrwx 1 root root   15 1972-09-19 21:06 xbl_config_b -> /dev/block/sdc2
OnePlus7T:/ #

    Cheers. :cowboy:
    Click to expand...
    Click to collapse
    The first thing you said..
    Did you patch the recovery image with Magisk.
    - Replace the recovery image with the Magisk patched version and boot into system from Recovery
    Click to expand...
    Click to collapse
    View
    1
    ipdev
    ipdev
    pndwal said:
    This is still intriguing me... I see this is OnePlus 7T, and it happens on rebooting...

    Just wondering if you have ever patched / flashed recovery image on this device?... Or is device swapping between A/B system slots somehow? (Do you have working systems on both?... Perhaps Magisk in boot_a and boot_b?)... PW
    Click to expand...
    Click to collapse
    I am just confused. 🙃
    More "What The ???"​
    ___

    maakosan said:
    It kind of works now, but I have to choose if I want Zygisk on (=No Mobile Network) or Zygisk off (=Older version of Magisk).
    I did flash the recovery image to get Magisk onto the device to begin with, everything else is "direct install (recommended)".
    No A/B stuff..
    Click to expand...
    Click to collapse
    - Did you patch the recovery image with Magisk.
    - Replace the recovery image with the Magisk patched version and boot into system from Recovery
    or..
    Did you you use recovery to install Magisk (patch the boot image)?

    I have only had a 7T for a few weeks.
    Since OnePlus has switched their release/updates to OTA only, it took me a little while to find a boot image.
    Once I found it, I patched it with Magisk and ...​

    Currently my (new-to-me) 7T is on the a12 beta.
    I was testing the fingerprint scanner.​

    I was planning on restoring to stable/stock OOS this weekend.
    If you are running a custom ROM or kernel, let me know.
    I am willing to test. 🙂
    ___

    pndwal said:
    Very interesting...

    So can I assume 7T has recovery_a/_b partitions as I believe 8T does, and that you also patched either recovery_a or _b in Magisk App some time back?

    If this is correct, I'm guessing Zygisk-off somehow causes device to reboot to system via recovery, and you thus have old Magisk since you patched recovery image (which is also a boot image containing ramdisk of course) with that some time ago...

    Note: Magisk in recovery and customised protocol for reboot via recovery to system w/o special adapted recovery key combo was designed for A-only legacy SAR devices specifically as these require Magisk in recovery partition as they have no ramdisk in boot... You seem to have used it on your 2SI device and there is no reason it shouldn't work apart from the fact that Magisk in boot partion is far more desirable / convenient...

    If I'm correct about a/b partitioning in 7T, your modern 2SI boot type device will of course have ramdisk in 4 partitions, recovery_a and _b, also boot_a and _b... This is fairly unique as most 2SI devices use recovery in boot partition (w/ a hybrid ramdisk) and have no actual recovery partitions.

    Again, if I'm right you can test theory by booting from powered down state using recovery key combo with this adjustment: As soon as you press the key combo and the device vibrates with a splash screen, release all buttons to boot into Magisk. (If you wanted to boot into the actual recovery mode, you would long press volume up until you see the recovery screen.)
    https://topjohnwu.github.io/Magisk/install.html#magisk-in-recovery

    Please reply to confirm (or correct) this! 😛 PW
    Click to expand...
    Click to collapse

    OnePlus 7T partitions.
    Code: 
    OnePlus7T:/ # ls -la dev/block/by-name/
total 0
drwxr-xr-x 2 root root 2520 1972-09-19 21:06 .
drwxr-xr-x 6 root root 4280 1972-09-19 21:06 ..
lrwxrwxrwx 1 root root   15 1972-09-19 21:06 ALIGN_TO_128K_1 -> /dev/block/sdd1
lrwxrwxrwx 1 root root   15 1972-09-19 21:06 ALIGN_TO_128K_2 -> /dev/block/sdf1
lrwxrwxrwx 1 root root   16 1972-09-19 21:06 LOGO_a -> /dev/block/sde21
lrwxrwxrwx 1 root root   16 1972-09-19 21:06 LOGO_b -> /dev/block/sde47
lrwxrwxrwx 1 root root   15 1972-09-19 21:06 abl_a -> /dev/block/sde8
lrwxrwxrwx 1 root root   16 1972-09-19 21:06 abl_b -> /dev/block/sde35
lrwxrwxrwx 1 root root   16 1972-09-19 21:06 aging -> /dev/block/sde54
lrwxrwxrwx 1 root root   16 1972-09-19 21:06 aging_mod -> /dev/block/sde55
lrwxrwxrwx 1 root root   15 1972-09-19 21:06 aop_a -> /dev/block/sde1
lrwxrwxrwx 1 root root   16 1972-09-19 21:06 aop_b -> /dev/block/sde28
lrwxrwxrwx 1 root root   16 1972-09-19 21:06 apdp -> /dev/block/sde59
lrwxrwxrwx 1 root root   15 1972-09-19 21:06 bluetooth_a -> /dev/block/sde5
lrwxrwxrwx 1 root root   16 1972-09-19 21:06 bluetooth_b -> /dev/block/sde32
lrwxrwxrwx 1 root root   16 1972-09-19 21:06 boot_a -> /dev/block/sde11
lrwxrwxrwx 1 root root   16 1972-09-19 21:06 boot_b -> /dev/block/sde38
lrwxrwxrwx 1 root root   16 1972-09-19 21:06 carrier -> /dev/block/sda15
lrwxrwxrwx 1 root root   16 1972-09-19 21:06 catecontentfv -> /dev/block/sde72
lrwxrwxrwx 1 root root   16 1972-09-19 21:06 catefv -> /dev/block/sde71
lrwxrwxrwx 1 root root   16 1972-09-19 21:06 cateloader -> /dev/block/sde66
lrwxrwxrwx 1 root root   15 1972-09-19 21:06 cdt -> /dev/block/sdd2
lrwxrwxrwx 1 root root   16 1972-09-19 21:06 cmnlib64_a -> /dev/block/sde13
lrwxrwxrwx 1 root root   16 1972-09-19 21:06 cmnlib64_b -> /dev/block/sde40
lrwxrwxrwx 1 root root   16 1972-09-19 21:06 cmnlib_a -> /dev/block/sde12
lrwxrwxrwx 1 root root   16 1972-09-19 21:06 cmnlib_b -> /dev/block/sde39
lrwxrwxrwx 1 root root   16 1972-09-19 21:06 config -> /dev/block/sda12
lrwxrwxrwx 1 root root   16 1972-09-19 21:06 core_nhlos -> /dev/block/sde20
lrwxrwxrwx 1 root root   15 1972-09-19 21:06 ddr -> /dev/block/sdd3
lrwxrwxrwx 1 root root   16 1972-09-19 21:06 devcfg_a -> /dev/block/sde14
lrwxrwxrwx 1 root root   16 1972-09-19 21:06 devcfg_b -> /dev/block/sde41
lrwxrwxrwx 1 root root   16 1972-09-19 21:06 devinfo -> /dev/block/sde57
lrwxrwxrwx 1 root root   16 1972-09-19 21:06 dip -> /dev/block/sde58
lrwxrwxrwx 1 root root   15 1972-09-19 21:06 dsp_a -> /dev/block/sde9
lrwxrwxrwx 1 root root   16 1972-09-19 21:06 dsp_b -> /dev/block/sde36
lrwxrwxrwx 1 root root   16 1972-09-19 21:06 dtbo_a -> /dev/block/sde17
lrwxrwxrwx 1 root root   16 1972-09-19 21:06 dtbo_b -> /dev/block/sde44
lrwxrwxrwx 1 root root   15 1972-09-19 21:06 frp -> /dev/block/sda6
lrwxrwxrwx 1 root root   15 1972-09-19 21:06 fsc -> /dev/block/sdf5
lrwxrwxrwx 1 root root   15 1972-09-19 21:06 fsg -> /dev/block/sdf4
lrwxrwxrwx 1 root root   16 1972-09-19 21:06 fw_ufs1_a -> /dev/block/sde22
lrwxrwxrwx 1 root root   16 1972-09-19 21:06 fw_ufs1_b -> /dev/block/sde48
lrwxrwxrwx 1 root root   16 1972-09-19 21:06 fw_ufs2_a -> /dev/block/sde23
lrwxrwxrwx 1 root root   16 1972-09-19 21:06 fw_ufs2_b -> /dev/block/sde49
lrwxrwxrwx 1 root root   16 1972-09-19 21:06 fw_ufs3_a -> /dev/block/sde24
lrwxrwxrwx 1 root root   16 1972-09-19 21:06 fw_ufs3_b -> /dev/block/sde50
lrwxrwxrwx 1 root root   16 1972-09-19 21:06 fw_ufs4_a -> /dev/block/sde25
lrwxrwxrwx 1 root root   16 1972-09-19 21:06 fw_ufs4_b -> /dev/block/sde51
lrwxrwxrwx 1 root root   16 1972-09-19 21:06 fw_ufs5_a -> /dev/block/sde26
lrwxrwxrwx 1 root root   16 1972-09-19 21:06 fw_ufs5_b -> /dev/block/sde52
lrwxrwxrwx 1 root root   15 1972-09-19 21:06 hyp_a -> /dev/block/sde3
lrwxrwxrwx 1 root root   16 1972-09-19 21:06 hyp_b -> /dev/block/sde30
lrwxrwxrwx 1 root root   16 1972-09-19 21:06 imagefv_a -> /dev/block/sde19
lrwxrwxrwx 1 root root   16 1972-09-19 21:06 imagefv_b -> /dev/block/sde46
lrwxrwxrwx 1 root root   16 1972-09-19 21:06 keymaster_a -> /dev/block/sde10
lrwxrwxrwx 1 root root   16 1972-09-19 21:06 keymaster_b -> /dev/block/sde37
lrwxrwxrwx 1 root root   15 1972-09-19 21:06 keystore -> /dev/block/sda5
lrwxrwxrwx 1 root root   16 1972-09-19 21:06 limits -> /dev/block/sde63
lrwxrwxrwx 1 root root   16 1972-09-19 21:06 logdump -> /dev/block/sde67
lrwxrwxrwx 1 root root   16 1972-09-19 21:06 logfs -> /dev/block/sde65
lrwxrwxrwx 1 root root   15 1972-09-19 21:06 mdm1m9kefs1 -> /dev/block/sdf7
lrwxrwxrwx 1 root root   15 1972-09-19 21:06 mdm1m9kefs2 -> /dev/block/sdf8
lrwxrwxrwx 1 root root   15 1972-09-19 21:06 mdm1m9kefs3 -> /dev/block/sdf6
lrwxrwxrwx 1 root root   15 1972-09-19 21:06 mdm1m9kefsc -> /dev/block/sdf9
lrwxrwxrwx 1 root root   16 1972-09-19 21:06 mdm1oemnvbktmp -> /dev/block/sde77
lrwxrwxrwx 1 root root   16 1972-09-19 21:06 mdm_oem_dycnvbk -> /dev/block/sda10
lrwxrwxrwx 1 root root   16 1972-09-19 21:06 mdm_oem_stanvbk -> /dev/block/sda11
lrwxrwxrwx 1 root root   15 1972-09-19 21:06 mdmddr -> /dev/block/sdd4
lrwxrwxrwx 1 root root   15 1972-09-19 21:06 mdtp_a -> /dev/block/sde7
lrwxrwxrwx 1 root root   16 1972-09-19 21:06 mdtp_b -> /dev/block/sde34
lrwxrwxrwx 1 root root   15 1972-09-19 21:06 mdtpsecapp_a -> /dev/block/sde6
lrwxrwxrwx 1 root root   16 1972-09-19 21:06 mdtpsecapp_b -> /dev/block/sde33
lrwxrwxrwx 1 root root   16 1972-09-19 21:06 metadata -> /dev/block/sda21
lrwxrwxrwx 1 root root   15 1972-09-19 21:06 misc -> /dev/block/sda3
lrwxrwxrwx 1 root root   15 1972-09-19 21:06 modem_a -> /dev/block/sde4
lrwxrwxrwx 1 root root   16 1972-09-19 21:06 modem_b -> /dev/block/sde31
lrwxrwxrwx 1 root root   15 1972-09-19 21:06 modemst1 -> /dev/block/sdf2
lrwxrwxrwx 1 root root   15 1972-09-19 21:06 modemst2 -> /dev/block/sdf3
lrwxrwxrwx 1 root root   16 1972-09-19 21:06 msadp -> /dev/block/sde60
lrwxrwxrwx 1 root root   16 1972-09-19 21:06 multiimgoem_a -> /dev/block/sde27
lrwxrwxrwx 1 root root   16 1972-09-19 21:06 multiimgoem_b -> /dev/block/sde53
lrwxrwxrwx 1 root root   15 1972-09-19 21:06 oem_dycnvbk -> /dev/block/sda8
lrwxrwxrwx 1 root root   15 1972-09-19 21:06 oem_stanvbk -> /dev/block/sda9
lrwxrwxrwx 1 root root   16 1972-09-19 21:06 op1 -> /dev/block/sde56
lrwxrwxrwx 1 root root   15 1972-09-19 21:06 op2 -> /dev/block/sda7
lrwxrwxrwx 1 root root   16 1972-09-19 21:06 opproduct_a -> /dev/block/sda13
lrwxrwxrwx 1 root root   16 1972-09-19 21:06 opproduct_b -> /dev/block/sda14
lrwxrwxrwx 1 root root   15 1972-09-19 21:06 param -> /dev/block/sda4
lrwxrwxrwx 1 root root   15 1972-09-19 21:06 persist -> /dev/block/sda2
lrwxrwxrwx 1 root root   16 1972-09-19 21:06 qupfw_a -> /dev/block/sde15
lrwxrwxrwx 1 root root   16 1972-09-19 21:06 qupfw_b -> /dev/block/sde42
lrwxrwxrwx 1 root root   16 1972-09-19 21:06 rawdump -> /dev/block/sda22
lrwxrwxrwx 1 root root   16 1972-09-19 21:06 recovery_a -> /dev/block/sda17
lrwxrwxrwx 1 root root   16 1972-09-19 21:06 recovery_b -> /dev/block/sda18
lrwxrwxrwx 1 root root   16 1972-09-19 21:06 reserve1 -> /dev/block/sde73
lrwxrwxrwx 1 root root   16 1972-09-19 21:06 reserve2 -> /dev/block/sde74
lrwxrwxrwx 1 root root   16 1972-09-19 21:06 reserve3 -> /dev/block/sde75
lrwxrwxrwx 1 root root   16 1972-09-19 21:06 reserve4 -> /dev/block/sde76
lrwxrwxrwx 1 root root   14 1972-09-19 21:06 sda -> /dev/block/sda
lrwxrwxrwx 1 root root   14 1972-09-19 21:06 sdb -> /dev/block/sdb
lrwxrwxrwx 1 root root   14 1972-09-19 21:06 sdc -> /dev/block/sdc
lrwxrwxrwx 1 root root   14 1972-09-19 21:06 sdd -> /dev/block/sdd
lrwxrwxrwx 1 root root   14 1972-09-19 21:06 sde -> /dev/block/sde
lrwxrwxrwx 1 root root   14 1972-09-19 21:06 sdf -> /dev/block/sdf
lrwxrwxrwx 1 root root   16 1972-09-19 21:06 secdata -> /dev/block/sde70
lrwxrwxrwx 1 root root   16 1972-09-19 21:06 splash -> /dev/block/sde62
lrwxrwxrwx 1 root root   16 1972-09-19 21:06 spunvm -> /dev/block/sde61
lrwxrwxrwx 1 root root   15 1972-09-19 21:06 ssd -> /dev/block/sda1
lrwxrwxrwx 1 root root   16 1972-09-19 21:06 storsec_a -> /dev/block/sde68
lrwxrwxrwx 1 root root   16 1972-09-19 21:06 storsec_b -> /dev/block/sde78
lrwxrwxrwx 1 root root   16 1972-09-19 21:06 super -> /dev/block/sda16
lrwxrwxrwx 1 root root   16 1972-09-19 21:06 toolsfv -> /dev/block/sde64
lrwxrwxrwx 1 root root   15 1972-09-19 21:06 tz_a -> /dev/block/sde2
lrwxrwxrwx 1 root root   16 1972-09-19 21:06 tz_b -> /dev/block/sde29
lrwxrwxrwx 1 root root   16 1972-09-19 21:06 uefisecapp_a -> /dev/block/sde18
lrwxrwxrwx 1 root root   16 1972-09-19 21:06 uefisecapp_b -> /dev/block/sde45
lrwxrwxrwx 1 root root   16 1972-09-19 21:06 uefivarstore -> /dev/block/sde69
lrwxrwxrwx 1 root root   16 1972-09-19 21:06 userdata -> /dev/block/sda23
lrwxrwxrwx 1 root root   16 1972-09-19 21:06 vbmeta_a -> /dev/block/sde16
lrwxrwxrwx 1 root root   16 1972-09-19 21:06 vbmeta_b -> /dev/block/sde43
lrwxrwxrwx 1 root root   16 1972-09-19 21:06 vbmeta_system_a -> /dev/block/sda19
lrwxrwxrwx 1 root root   16 1972-09-19 21:06 vbmeta_system_b -> /dev/block/sda20
lrwxrwxrwx 1 root root   15 1972-09-19 21:06 xbl_a -> /dev/block/sdb1
lrwxrwxrwx 1 root root   15 1972-09-19 21:06 xbl_b -> /dev/block/sdc1
lrwxrwxrwx 1 root root   15 1972-09-19 21:06 xbl_config_a -> /dev/block/sdb2
lrwxrwxrwx 1 root root   15 1972-09-19 21:06 xbl_config_b -> /dev/block/sdc2
OnePlus7T:/ #

    Cheers. :cowboy:
    View
  • 6
    V0latyle
    V0latyle
    73sydney said:
    Its trivial to sniff or even MITM a desktop, or even just run WinPE and reset admin password and use the users own saved passwords in their browser, heck even export their passwords....

    In any event the biggest risk vector is social engineering

    Chasing root phone users only gives them a "feelgood", it does nothing to stop genuine misuse and fraud, at all.....

    I dont see Google or a bank sending out a representative every time someone makes a transaction to see if theyre genuine....trying to control the device is attacking the wrong end of the transaction and is ultimately pointless
    Click to expand...
    Click to collapse
    They're not chasing root users. They just want a guarantee that the device is secure, and they have good reason to. Rooting by nature compromises device security.

    I'm not saying your opinion is invalid; in this context however, it is irrelevant, because regardless of how you may feel about the situation, it's not going to change.
    View
    5
    P
    pndwal
    huskydg said:
    @pndwal You can build Magisk app with custom name and label as you want
    Click to expand...
    Click to collapse
    huskydg said:
    MagiskHide is still effective to hide root from banking apps. It's not dead if you don't care about safetynet stuff.


    Shamiko is taking off your panties on the basic of MagiskHide. So MagiskHide is still better.
    You believe Shamiko too much, It can't really hide zygisk, only fix the zygisk detection of Momo. However, I can't blame it because that was the nature of zygisk and it will never be fixed.
    Click to expand...
    Click to collapse
    Still not sure what you're trying to tell me...

    I think we agree on most of this stuff (except your apparent impression that Shamiko Devs have some sort of sexual agenda, or that it's users are somehow prone to 'self abuse'... I won't use the other term either...).

    If you think I have misrepresented any facts regarding Magisk, Shamiko or other, please say it plainly... I think what I provided for the sake of clarity was accurate... 🙁 PW
    View
    5
    P
    pndwal
    Latest Official TJW public Stable (release) Magisk build:

    Magisk​

    2022.7.20 Magisk v25.2​

    Maintenance release fixing various issues.
    • [MagiskInit] Fix a potential issue when stub cpio is used
    • [MagiskInit] Fix reboot to recovery when stub cpio is used
    • [MagiskInit] Fix sepolicy.rules symlink for rootfs devices
    • [General] Better data encryption detection
    • [General] Move the whole logging infrastructure into Rust

    Full Changelog: here​

    https://topjohnwu.github.io/Magisk/releases/25200.html

    🎉🎊 PW
    View
    5
    gorman42
    gorman42
    And I solved it. Thanks to everybody that helped me. @zgfg idea of working on data/adb/magisk.db prompted me to investigate how to reach there. MiXplorer did not have root access granted forever, so it wasn't working. Ended up using adb and, through commandline removed everything releated to Magisk in there. Uninstalled the app, flashed the standard boot.img, installed the app, flashed the patched boot.img, rebooted and... success! 🙃

    It only took me six hours or however much it's been. Now let's hope I can reactivate hiding features, etc.
    View
    5
    V0latyle
    V0latyle
    RandomPooka said:
    I'm also done with this conversation, because you seem to be going out of your way to be obtuse about it. You specifically mentioned that rooted users are a microscopic minority. None of these corporations enacting the security measures are going to go out of their way to make security exceptions for the tiny fraction of android users that are rooted users.
    Click to expand...
    Click to collapse
    Let's not forget the security issues that rooted devices present. App developers for the aforementioned banks, etc are extremely concerned with operating in a secure environment. You wouldn't want a third party to be able to view, let alone manipulate, your financial transactions, but a rogue process with root permissions could potentially do exactly that - read account numbers, command unauthorized transactions, and worse. Think of it like a malware browser extension that could give a remote party access to your bank account.

    From the developer perspective, every single rooted device is a compromised security environment, and this is 100% true. There is no easy way to determine whether the end user is using root carefully with vetted applications, or if the device has been hijacked by a malicious rootkit. So, developers use methods such as SafetyNet, Play Protect Certification, and the new Play Integrity API as a means to try to verify the security environment of the device.

    Try to look beyond your own inconvenience as a rooted user and understand this concept. The end answer is simple: If you want an app to work correctly on your device, do not modify your device or software.
    View
  • 1084
    T
    topjohnwu
    This is the place for general support and discussion regarding "Public Releases", which includes both stable and beta releases.
    All information, including troubleshoot guides and notes, are in the Announcement Thread
    View
    156
    T
    topjohnwu
    Hello, I haven't given much support on XDA lately. It can be resulted from
    • University started and I have limited free time. In fact, I mostly develop during midnight
    • I live in Taiwan, which has large time zone differences between my European/American contributors/testers, which usually forces me to stay up late at night to discuss/test stuffs.
    • The new version is about to come, I don't want to spend effort on supporting old releases
    The planned update is delayed again and again, to some point I think I'll shed some light about what has been happening lately, also along with some announcements.

    New Forum!
    As you might have already discovered, Magisk got its own subforum on XDA! Many thanks to all the support you gave me, and much more information/features/support is about to come!
    **For developers supporting all the devices that are not using standard Android boot format, feel free to create threads in this section (actually, PLEASE do so) for your favorite devices after v7 is out. As I currently know, Asus devices require signing the boot image before flashing, and is model dependant; Sony devices seems to use ELF kernel that is unpatchable, or some has two ramdisks (inner + outer), both requires different workarounds; LG bootloader locked devices has to manually "BUMP" the boot image after flashing Magisk..... and there may be lots of other crazy boot image formats that haven't come up to my attention yet.
    It is impossible for me to support all these non-standard boot images, and I hope the community can collaborate to make Magisk running across all the devices. Overall, community collaboration is what XDA about :D

    The Pixel Phone
    Some of you might already know this news, that the next Pixel Phone right around the corner seems like it does not have ramdisk in boot image, which pretty much wrecked Magisk in all ways. However, it pretty much doomed root itself too. Kernel modifications is inevitable IMO, so I'll try to migrate my scripts to C programs that could possibly be included into the kernel itself. Note that I'm not familiar with linux kernel, I'm not even sure if my idea and concept is correct or not. But once the device is available, I think developers will find a way to bypass all the difficulties, and I'll do my best to learn things ;)

    Current Progress
    In the past month, I've spent quite some time learning SELinux, so that I can avoid using SuperSU's sepolicy patches. Thanks to the helps and tips from @phhusson and @Chainfire, I finally have a much clearer understanding of how SELinux works. The Magisk core parts (the scripts, boot image patches, new features, more supports) are actually done some time ago. What is causing all the delays is the Magisk Manager.
    To be completely honest, although I can code in Java without much issues, Magisk Manager is actually my first Android application, I had to reach out for assistance, and fortunately awesome developers like @DVDandroid and @digitalhigh contributed a lot, which makes the current Manager awesome.
    After the repo system and module management is mostly done, I was about to do some adjustments and release, but what we really done is decided to add another feature: auto-unroot with per-app settings. I decided to wait for it to be finished, and then do my adjustments. Due to reasons that'll be mentioned later, this feature will likely not be available for the next release (should come in future updates)

    Safety Net Disaster
    Those who are using Magisk for Safety Net bypass purposes must have known that Google recently updated the detection method of my Systemless Xposed. I still have no idea what Safety Net is detecting, so currently I cannot fix it on my side (also because I'm busy working on the next update). However, suhide developed by @Chainfire is able to hide Xposed and worked fine.
    However, only my Systemless Xposed v86.2, which is based on SuperSU's su.d, is supported using that method. v86.2 and v86.5 (latest, Magisk based) have nearly identical binaries, and the only difference is the path where the binaries are stored.
    I'm still not sure what's the real issue for it not being supported, I just hope it is not done intentionally.

    Conclusion
    Due to the fact that my Safety Net bypass is not 100% perfect now, I do not want to spend any more time waiting for auto-unroot to be polished. What I'm doing now is finishing up all the things I'd like to change in Magisk Manager (it has been a while since I last contributed to Manager, my fellow developers are doing all the heavy job), which might take a little more time, after that, packed with tons of information to be announced in Magisk Section, I'll release the long awaited update.

    Hope this lengthy post gives you the idea of the whole situation, and again thanks for all your support!!
    View
    121
    Chainfire
    Chainfire
    Ah, some Chainfire bashing, I hope it is not too late for me to exercise additional villainy.

    First, let me make clear I have nothing against @topjohnwu, nor against Magisk. Magisk is an interesting project and it certainly displays @topjohnwu ingenuity and persistence. I don't doubt we will see more interesting things from his hands.

    -------------------------

    What has happened here is not all that dark and complicated, from either end. I returned from holidays, and someone pointed me at Magisk. My first thought: interesting!

    Among other things, the thread lists some issues with SuperSU, which in combination with the phrase The developer also requests users to not bug Chainfire with compatibility requests for SuperSU with Magisk from the portal article, raised my left eyebrow by nigh half an inch. The popular systemless xposed mod is apparently now based on it, and apparently it now no longer works with SuperSU, and apparently I'm not supposed to fix that, nor any of the other found issues. I found that a bit weird. So yes, I have told @topjohnwu that I was a bit surprised he was posting about issues with SuperSU without notifying me about them (I can't fix or help fix issues I'm not aware of, after all).

    He's also spreading a modified version of the SuperSU package, which is not all that uncommon, nor necessarily a problem. I have not looked into what he modified, I only ran a few quick tests on one of my devices, and found some commonly used commands run as root to be broken. I have informed him of this as well.

    It appears the tool of choice for Magisk is phh's Superuser, because of some of the mentioned issues with SuperSU. That's fine by itself, but fixing issues in that superuser by incorporating SuperSU's binaries into it is a somewhat questionable practise. After all, SuperSU is a commercial closed-source package that helps pay for my dinner, and superuser is a direct competitor. I have informed him that I was surprised he did this without asking for permission. I have expressed similar surprise on him spreading a modified version of LiveBoot (which helps pay for a snack now and then).
    @topjohnwu has also stated that Magisk's scripts are largely influenced by mine (I have not checked). Scripts based on mine are used all over the place on XDA, some people have crafted amazing things based on them, I have never made an issue of this (otherwise I would have just made them binaries). But yes, I have also stated to him that I don't think it's very nice to base something on one program, and then using that to (almost exclusively) push something directly competing with that program.

    tl;dr Towards @topjohnwu, I have:
    - expressed surprise he has issues getting Magisk to work with SuperSU, and has chosen not to inform me about those
    - expressed surprise he is using SuperSU binaries in a competing superuser without permission
    - expressed surprise he is posting a modified LiveBoot without permission
    - informed him of issues with the modified SuperSU he has posted
    - let him know I thought it wasn't very nice to be applying my scripts to benefit seemingly exclusively that same competing superuser

    To be crystal clear:
    - I have not asked for an apology
    - I have not asked for Magisk to be abandoned, neither the root hiding nor systemless module parts, and certainly not systemless xposed
    - I have not made an issue of any of this anywhere, until this post
    - I have not even specifically asked for anything to be taken down (though obviously in my opinion the other superuser package mixed with SuperSU's binaries, as well as the LiveBoot package, should go)
    - I have not reported this thread to XDA moderators for copyright violations or otherwise

    While my conversation with @topjohnwu may not win any awards for being friendly (though it may win some for brevity), I think all things considered my response has been rather mild. To be perfectly honest, until the apology post, I thought this was over with already. I think the apology post was triggered because I haven't replied to his last PM for a while - I was in the zone, it happens.

    To emphasize again, I have nothing against @topjohnwu, Magisk, or systemless xposed, and it is certainly not my goal to see any of them go. If it can be made to work together with SuperSU, great.

    I get it though: you think of something, you want to see if you can make it work, you finally get it to work, you publish it, it takes off - enthusiasm gets the better of you. Maybe in the rush some mistakes are made. That doesn't mean you have to just drop it and run. None of my stuff would make it past 0.1 if I stopped at the first big mistake :)

    Aside from said being in the zone coding, I usually regret actually responding to these sort of things the day after, which has made me hesitant to reply. Surprise me.
    View
    76
    nathanchance
    nathanchance
    Thread temporarily closed so everyone sees this.

    The flood of "SafetyNet isn't working for me either!" posts are not helpful, at all. Please refrain from posting further, it will be looked into. Please do not forget that not passing SafetyNet is 100% NORMAL AND INTENDED when you have an unlocked booloader or running custom firmware. These are workarounds and they will be worked around in turn.

    The Flash
    Forum Moderator

    EDIT: Thread is reopened... I will be cleaning any SafetyNet posts for a while to keep the thread clean for real issues.
    View
    75
    T
    topjohnwu
    Hello everyone!

    I am aware that Google has updated Safety Net that makes Magisk itself a no go for Android Pay. In fact, I witnessed the change live while I am developing the new magiskhide, which should hide all Magisk modules and Magisk installed root.

    Google is serious about Safety Net now, clearly hunting down all possibility to run Xposed with Safety Net passed. I spend quite some time examining the new security measures last midnight, and fortunately it seems that it is possible to run Magisk and root along with Safety Net if no Xposed is running. I'm glad I removed the old root toggle at the right time lol, that is no longer feasible with the latest detection.

    So stay tuned for the next update, it will come with bug fixes, along with the new magiskhide to bypass that Safety Net.

    Google, how will a few systemless mods do any harm :p:p
    View

New posts