Magisk General Support / Discussion

Search This thread

traversone

Senior Member
Feb 18, 2019
189
63
Canary 23.015 has a bad behaviour to me (I think it is on Manager side):

a) updating within the (hidden) 23.014 Manager makes new Manager unresponsive (it never starts) and mobile gets boiling....soft reset is needed
b) installing a fresh 23.015 Manager leads to same behavious once trying to hiding manager (it never starts, 2 managers are shown in the drawer)--> mobile hangs up --> reboot/reset is needed
c) without hiding 23.015 Manager, all is working as expected and Magisk is correctly updated within Manager

thanks to who could comment on this

Hades ROM 3.0 for Samsung S8 - A10

EDIT: just released Canary 24.316 solves this issue!
 
Last edited:

pndwal

Senior Member
Latest Official TJW Canary (release) & Debug (debug) Magisk builds:

Magisk (34b2f525) (24316)​

  • [App] Fix stub app on older Android versions

Diffs to v24.3​

  • [MagiskInit] Update 2SI implementation, significantly increase device compatibility (e.g. Sony Xperia devices)
  • [MagiskInit] Introduce new sepolicy injection mechanism
  • [MagiskInit] Support Oculus Go
  • [MagiskInit] Support Android 13 GKIs (Pixel 6)
  • [MagiskBoot] Fix vbmeta extraction implementation
  • [App] [MagiskSU] Properly support apps using shared UID
  • [App] Fix stub app on older Android versions
  • [MagiskSU] Fix a possible crash in magiskd
  • [MagiskSU] Prune unused UIDs as soon as possible to prevent UID reuse attacks
  • [MagiskSU] Verify and enforce the installed Magisk app's certificate to match the distributor's signature
  • [MagiskSU] Handle system_server restarts to prevent UID reuse abuse
  • [MagiskSU] [Zygisk] Proper package management and detection
  • [Zygisk] Fix function hooking on devices running Android 12 with old kernels
  • [Zygisk] Fix Zygisk's self code unloading implementation
  • [DenyList] Fix DenyList on shared UID apps
  • [BusyBox] Add workaround for devices running old kernels
https://github.com/topjohnwu/magisk-files/blob/b4869a2d900721c508c974e5288edf29aee25e01/notes.md

👍 PW
 
Last edited:

samhhmobil

Senior Member
May 25, 2017
421
216
Hamburg
I see exactly the same trouble.

Model: Xiaomi Mi10T lite 5G (gauguin)
Bootloader unlocked
ROM: LineageOS 19.1
Recovery: Lineage Recovery
Gapps: MindTheGapps 12.1
Magisk: 24.3, hidden

Just flashing Magisk newly with "adb sideload", immediatly after system update, is the workaround.

samhhmobil
 

Attachments

  • IMG_20220606_155616.JPG
    IMG_20220606_155616.JPG
    566.9 KB · Views: 40

pndwal

Senior Member
Hiding the Magisk app is broken for me (Xiaomi Redmi Note 8T) in this build. PW
This is basically fixed for my A-only legacy SAR device w/ Android 10, but setup is still flawed:

I started with no Magisk App installed and took install Magisk Canary (24316) from GitHub Magisk DownloadsApp, then took Update Magisk (mask) and rebooted first.

All seems good. 👍

Then took Update Magisk (mask) via Direct install...

Seems process fails to uninstall the full app, and I get this:
IMG_20220607_000101.jpg

Turns out root is lost due to the classic issue of dual apps competing as I suspected (took a look to confirm this), so I simply ignored this, uninstalled the complete Magisk App, opened Stub App and all is good...

... So this is vastly improved, but I'll open a new issue if no-one else does first.

Also strangely, Restore the Magisk app fails to remove the stub app as well on the first attempt. (Full app remains missing), but trying a second time it succeeds; Zygisk is 'No' despite toggle set On in settings... Closing and reopening App restores Zygisk.

After this, Hide the Magisk app works without a hitch, as does Restore...


I just tried to reproduce the initial behaviour by uninstalling App, downloading and setting up fresh again before taking Hide the Magisk app, but now this continues to work normally and so does Restore, so I've concluded that there was likely some anomaly with magisk.db or other config files due to testing Actions builds...

It now seems the fix is good. 👍

😜 PW
 
Last edited:
  • Like
  • Haha
Reactions: ipdev and svendsvin

zgfg

Senior Member
Oct 10, 2016
7,650
5,054
This is basically fixed for my A-only legacy SAR device (w/ Magisk in boot), but setup is still flawed:

I started with no Magisk App installed and took install Magisk Canary (24316) from GitHub Magisk DownloadsApp, then took Update Magisk (mask) and rebooted first.

All seems good. 👍

Then took Update Magisk (mask) via Direct install...

Seems process fails to uninstall the full app, and I get this:
View attachment 5631549
Turns out root is lost due to the classic issue of dual apps competing as I suspected (took a look to confirm this), so I simply ignored this, uninstalled the complete Magisk App, opened Stub App and all is good:
View attachment 5631557
... So this is vastly improved, but I'll open a new issue if no-one else does first.

Also strangely, Restore the Magisk app fails to remove the stub app as well on the first attempt. (Full app remains missing), but trying a second time it succeeds but Zygisk is 'No' despite toggle set On in settings... Closing an reopening App restores Zygisk.

😜 PW
Sorry, I'm lost about the latest Canaries now

I still have 24314 and I didn't see any issues about hiding Magisk app (except that - IMO, everybody SHOULD BE aware of, one must unhide Magisk app before upgrading)

Hence, do we have now new bugs related to hiding the Magisk app?

Also, how about SafetyNet, GPay and so - are we good in 24316 with all that, something better or worse than how it was previously with 24314 or so
 
  • Like
Reactions: J.Michael

pndwal

Senior Member
Sorry, I'm lost about the latest Canaries now

I still have 24314 and I didn't see any issues about hiding Magisk app (except that - IMO, everybody SHOULD BE aware of, one must unhide Magisk app before upgrading)
This was broken for many (failed completely) including my RN8T, but apparently it was Android version dependant... I still have Android 10...
Hence, do we have now new bugs related to hiding the Magisk app?
Seems this is properly fixed now (for Android 10 and below?).

I thought there were still issues, but probably not... I've edited my post above...
Also, how about SafetyNet, GPay and so - are we good in 24316 with all that, something better or worse than how it was previously with 24314 or so
S/N, device certification all good, GPay still ready so I'm assuming no more issues...

Since my recent GPay glitch (I found wiping Google Play Services, Play Store and Google Pay data wouldn't fix
IMG_20220604_110358.jpg

but uninstalling / reinstalling Google Pay app did (strangely), I've had no problem making any contactless payments, however I get this:
IMG_20220604_202359.jpg

when viewing Activity...

I read reports where this just occurred randomly but 'fixed itself' within a day... For me this has persisted for several days now despite many successful payments...

Any insight into issue / help to fix GPay Activity would be appreciated! PW
 
Last edited:
  • Like
Reactions: zgfg

pndwal

Senior Member
JohnWu400x400.jpg

John Wu, 4h

I'm wrapping up the Magisk v25 development cycle and plan to release a new public release soon-ish. Calling for translators around the world to add the few additional strings in the app 😇

After the v25 dust settles, Magisk will undergo an Oxidation (Rustification) process and start experimenting with introducing Rust into the project. Fun and exciting things ahead!
www.twitter.com/topjohnwu/status/1533771129256439808

👀 PW
 

rodken

Senior Member
Jan 11, 2010
1,009
393
This was broken for many (failed completely) including my RN8T, but apparently it was Android version dependant... I still have Android 10...

Seems this is properly fixed now (for Android 10 and below?).

I thought there were still issues, but probably not... I've edited my post above...

S/N, device certification all good, GPay still ready so I'm assuming no more issues...

Since my recent GPay glitch (I found wiping Google Play Services, Play Store and Google Pay data wouldn't fix
View attachment 5631653
but uninstalling / reinstalling Google Pay app did (strangely), I've had no problem making any contactless payments, however I get this:
View attachment 5631655
when viewing Activity...

I read reports where this just occurred randomly but 'fixed itself' within a day... For me this has persisted for several days now despite many successful payments...

Any insight into issue / help to fix GPay Activity would be appreciated! PW
After you were able to get GPay to behave utilizing the uninstall method - rewipe Google Play Services, Play Store and Google Pay data [of course reboot].

It usually sorts itself out after a few hours [1 - 24] of your device hand-shaking with the servers.

N.B.: Remember to check your phone number to be certain that it is correct within the app.
 
  • Like
Reactions: m0han and pndwal

Gerdje_

Senior Member
Jan 20, 2018
52
11
Hi y'all,

Sorry if this problem have been posted before, but haven't found an solution yet after a few hours of trying.

Issue: after latest Lineage 18.1 OTA update I suddenly lost root. Magisk is no longer installed. Only option is Install within the app=>choose and patch a file after choosing the existing Magisk-24.3(24300).apk on my phone I get an error:
! Unsupported/Unknown image format
! installation failed

I have downloaded the Magisk v23.0, 24.1v and v24.3, giving me the same error.

With TWRP I get:
! cannot mount /system
- Unmounting partitions
Updater process ended with ERROR: 1

Previous OTA updates were no problem and I haven't changed/updated Magisk the since 24.3 (24300)

My device: Samsung S4 Value Edition
Lineage OS 18.1
Zygisk: No
Ramdisk: Yes

Any ideas? Cheers
 

m0han

Senior Member
Apr 30, 2012
5,006
2,058
Sorry, I'm lost about the latest Canaries now. I still have 24314 and I didn't see any issues about hiding Magisk app...

Also, how about SafetyNet, GPay and so - are we good in 24316 with all that...
i went 24314 » 24316. things seem fine on A12.1. no op to test gpay payment atm.
 

Attachments

  • Screenshot_20220606_232221.jpg
    Screenshot_20220606_232221.jpg
    156.6 KB · Views: 84
  • Screenshot_20220606_232402.jpg
    Screenshot_20220606_232402.jpg
    134.5 KB · Views: 84
  • Screenshot_20220606_232321.jpg
    Screenshot_20220606_232321.jpg
    132.1 KB · Views: 85

pndwal

Senior Member
After you were able to get GPay to behave utilizing the uninstall method - rewipe Google Play Services, Play Store and Google Pay data [of course reboot].

It usually sorts itself out after a few hours [1 - 24] of your device hand-shaking with the servers.
Thanks... Did you have same issue?
N.B.: Remember to check your phone number to be certain that it is correct within the app.
Not sure how to do this. 🤔

Edit: Guess you mean in Google Account... tis correct. 👍 PW
 
Last edited:

pndwal

Senior Member
Hi y'all,

Sorry if this problem have been posted before, but haven't found an solution yet after a few hours of trying.

Issue: after latest Lineage 18.1 OTA update I suddenly lost root. Magisk is no longer installed.
Seems LOS 18.1 may force LOS recovery on A-only devices. Addon.d survival script requires decryption. Seems this may be your issue if you also lost (needed to reinstall?) TWRP w/ decryption...
https://github.com/topjohnwu/Magisk/issues/4655#issuecomment-924517921
Is simply flashing magisk.apk as .zip installer (old method) not working? (per official instructions)... This should still work fine on pre-SAR devices...
is Install within the app=>choose and patch a file after choosing the existing Magisk-24.3(24300).apk on my phone I get an error:
! Unsupported/Unknown image format
! installation failed
Sorry, but are you trying to patch Magisk APK?!...

This isn't clear, but if that's your mistake you need to extract boot.img from current ROM and patch that... If it's official LOS I'm guessing you may need a payload dumper app to extract it from ROM package... (Official way.)

Alternatively, patching a TWRP backup (.win file) of current boot partition should work...
I have downloaded the Magisk v23.0, 24.1v and v24.3, giving me the same error.

With TWRP I get:
! cannot mount /system
- Unmounting partitions
Updater process ended with ERROR: 1

Previous OTA updates were no problem and I haven't changed/updated Magisk the since 24.3 (24300)

My device: Samsung S4 Value Edition
Lineage OS 18.1
Zygisk: No
Ramdisk: Yes

Any ideas? Cheers
😜 PW
 

pndwal

Senior Member
Hello, I wasn't really able to get logs but installed today's update of my Samsung Galaxy S5e from LOS Recovery. I got this:

View attachment 5631373

A not decrypted data partition was mentioned but I was able to install Magisk immediately from recovery (after confirming the signature).

So it isn't really a problem of encrypted data?

Thanks

Roger
This is different... installation from recovery should work either way. Addon.d (for auto reinstall after OTA) needs decrypted data to see the script... (See related post above also.) PW
 
Last edited:
  • Like
Reactions: rogers11

pndwal

Senior Member
After you were able to get GPay to behave utilizing the uninstall method - rewipe Google Play Services, Play Store and Google Pay data [of course reboot].

It usually sorts itself out after a few hours [1 - 24] of your device hand-shaking with the servers.
Did this, and can confirm it did the trick 👍 ... I think the reboot made the difference; without it
IMG_20220604_133229.jpg

never completes (and after circumventing this by uninstalling / reinstalling previously, Activity wouldn't update despite payments working fine).

Many thanks! PW
 

73sydney

Senior Member
Did this, and can confirm it did the trick 👍 ... I think the reboot made the difference; without it
View attachment 5632097
never completes (and after circumventing this by uninstalling / reinstalling previously, Activity wouldn't update despite payments working fine).

Many thanks! PW

Confuzzled, do you mean the usual

* Airplane mode on
* Wipe data of Play Services, Play Store and Google Pay
* Reboot
* Airplane mode off

didnt work...you had to fully uninstall pay as well?
 

Gerdje_

Senior Member
Jan 20, 2018
52
11
Seems LOS 18.1 may force LOS recovery on A-only devices. Addon.d survival script requires decryption. Seems this may be your issue if you also lost (needed to reinstall?) TWRP w/ decryption...
Thanks. I still have TWRP (v. 3.5.2_9-1), so LOS recovery wasn't forced.
Is simply flashing magisk.apk as .zip installer (old method) not working? (per official instructions)... This should still work fine on pre-SAR devices...
Noop, not working. I get the same error.
Sorry, but are you trying to patch Magisk APK?!...
Yes. this is the only option, no direct install available. I didn't notice this and went on but it didn't cause the initial problem.
This isn't clear, but if that's your mistake you need to extract boot.img from current ROM and patch that... If it's official LOS I'm guessing you may need a payload dumper app to extract it from ROM package... (Official way.)

Alternatively, patching a TWRP backup (.win file) of current boot partition should work...

😜 PW
Will try that.
Edit: not sure if I need the payload.bin because my device doesn't support seamless updates. In this case the boot.img is enough?
 
Last edited:

pndwal

Senior Member
Thanks. I still have TWRP (v. 3.5.2_9-1), so LOS recovery wasn't forced.

Noop, not working. I get the same error.
So looks like LOS boot image may have become incompatible, or there may be some regression in Magisks handling of boot image compression formats...
Yes. this is the only option, no direct install available.
Sorry, but patching Magisk apk is NOT an option as it's NOT a boot image... it will necessarily result in 'Unsupported/Unknown image format' for same reason. 😬...
I didn't notice this and went on but it didn't cause the initial problem.
No, but you must patch a boot image... Please read official Installation Instruction...
Will try that.
Edit: not sure if I need the payload.bin because my device doesn't support seamless updates. In this case the boot.img is enough?
Ah yes; if you can see boot.img in ROM archive you can just extract / use that...

If you still face issues, try latest Canary; one of the many regressions fixed since last Stable may be for you device... PW
 

Gerdje_

Senior Member
Jan 20, 2018
52
11
Last edited:

pndwal

Senior Member
Latest Official TJW Beta (release) Magisk build:

Magisk

2022.6.7 Magisk v25.0​

Another major release! A lot of the changes aren’t visible at the surface, but v25 is actually a really substantial upgrade!

MagiskInit Rewrite​

A significant portion of magiskinit (the critical software that runs before your device boots up) is completely rewritten from scratch. Ever since Android introduced Project Treble in Android 8.0, Magisk has been constantly fighting against the increasingly complex partitioning and early mount setups of all kinds of devices, sometimes with weird OEM specific implementations. It got to a point that magiskinit had become so complicated that few people (including myself!) were aware of every detail, and maintaining this piece of software like this was clearly not sustainable. After many months of planning (yes, this whole re-architecture has been in my head for a long time) and some help from external contributors, a whole new sepolicy injection mechanism is introduced into Magisk, solving the “SELinux Problem” once and for all.

Since this is a full paradigm shift on how Magisk hot-patch the device at boot, several behaviors that many developers implicitly relied on might not exist. For example, Magisk no longer patches fstabs in most scenarios, which means AVB will remain intact; some custom kernels rely on AVB being stripped out for them by Magisk.

MagiskSU Security Enhancements​

The superuser functionality of Magisk has not seen much changes ever since its introduction. v25 focuses on making root permission management more accurate and secure:

  • Add a whole new package tracking system to ensure malicious UID reuse attack cannot be performed
  • Properly support and implement the UX in the Magisk app for packages using sharedUserId
  • Enforce root manager APK signature verification to combat the rampant unofficial Magisk app “mods”
Many might not realize, but using a trusted, unmodified Magisk app is really important. Magisk’s root daemon treats the Magisk app differently and gives it blanket root access without any restrictions. A modded Magisk app can potentially backdoor your device.

And in case some of you are about to put on your tin foil hats, this is not designed to “vendor lock-in”; the goal is to make sure your root management app comes from the same developer of the underlying root implementation. Magisk’s build system allows custom distributors to use its own signing keys, and in addition, I am also providing official debug builds which skips any signature verification for development.

Full Changelog: here

Magisk Changelog​

v25.0​

  • [MagiskInit] Update 2SI implementation, significantly increase device compatibility (e.g. Sony Xperia devices)
  • [MagiskInit] Introduce new sepolicy injection mechanism
  • [MagiskInit] Support Oculus Go
  • [MagiskInit] Support Android 13 GKIs (Pixel 6)
  • [MagiskBoot] Fix vbmeta extraction implementation
  • [App] Fix stub app on older Android versions
  • [App] [MagiskSU] Properly support apps using sharedUserId
  • [MagiskSU] Fix a possible crash in magiskd
  • [MagiskSU] Prune unused UIDs as soon as system_server restarts to prevent UID reuse attacks
  • [MagiskSU] Verify and enforce the installed Magisk app’s certificate to match the distributor’s signature
  • [MagiskSU] [Zygisk] Proper package management and detection
  • [Zygisk] Fix function hooking on devices running Android 12 with old kernels
  • [Zygisk] Fix Zygisk’s self code unloading implementation
  • [DenyList] Fix DenyList on shared UID apps
  • [BusyBox] Add workaround for devices running old kernels
https://topjohnwu.github.io/Magisk/releases/25000.html

🎉🎉 👍 PW
 
Last edited:

Top Liked Posts

  • 3
    No, I did not extract it from the lineage zip.
    I am unable to mount the payload.bin in windows, and it errors out on me when I try and use 7zip to open it up.
    To extract img files from payload.bin you have to use Payload Dumper. There are several threads (under different devices) with download links on XDA (you should search for) - for Windows, Linux, even for Android (not working great with bin files of several GBs), and with instructions

    Link to my copy (for Windows) I downloaded months ago from XDA and happily used couple of times:
    2
    I read the instructions but got swayed by another post elsewhere where it was stated that instaling the apk first and renaming it as zip and then sideloading has worked for someone quite well. So out of laziness I did the same process and found that it all installed without any errors.

    Could this be the contributing factor with my adopted storage issues which I did not experience earlier? Also, I am experiencing some wierd problems with bluetooth where I can connect using bluetooth to most devices but if I try to connect to another android device it attempts to pair and then fails without any errors. Fortunately, haven't experienced any other major issues.
    Bit vague on your setup now...

    Guess RN7 with ramdisk=no (since launched w/ A9... unless has A/B(?))

    So default instructions are install magisk in recovery ramdisk (recovery mode selected)... Zip install can't do this... Did you ever do that (patch recovery.img)?... But being Xiaomi you won't actually need this... Best to patch boot.img (recovery mode un-selected) using M. App and flash...

    And I wouldn't use .zip install for your device... It's legacy SAR... May be fine, but zip install is fraught since legacy ramdisk booting devices (any device w/ Launch Version A8 or less, but not updated to A10+)... Whether this could impact on SD card, BT issues etc, I'm not sure, but I'd start again w/ proper patch / flash for SAR / 2SI devices...
    What is the correct un-installation procedure for Magisk? I would like to uninstall and re-install as per the official method to see whether my issues will go away.
    You can use Uninstall Magisk from App; Nb. Restore Images leaves android configuration in /data/adb, so you'll want to take Complete Uninstall... (Or, if you first want to test if issue is that magisk.db or other config files are corrupted / causing issues, with root explorer or twrp simply delete everything in /data/adb and reboot and magisk daemon will rebuild config files... You'll have cleanly installed root and modules, superuser, deny lists etc will be gone too...)

    For full uninstall you can also delete everything in /data/adb and flash unpatched boot image (recovery.img or boot.img or both these boot images)... If deleting data with root, don't reboot before flashing original boot image...

    Issue does sound VERY like a mismatched kernel to me... Often this gives associated hardware issues...

    Kernel is in boot image, so this is a common issue where users restore images to take an OTA update (even a minor one), then flash back previous boot image instead of sourcing the ROM corresponding with the OTA to obtain boot.img (or recovery.img) to patch and flash... or simply mix up boot images on the PC... Failing to restore unpatched images before an OTA can cause issues too...

    Did you ever use App to patch images? (... Old .zip installation doesn't allow such a mismatch/ user error).

    ... Remember to treat your Xiaomi SAR A only device as ramdisk=yes for your clean setup, and patch / flash boot.img exactly matching or extracted from current ROM...

    🤠 PW
    1
    To extract img files from payload.bin you have to use Payload Dumper. There are several threads (under different devices) with download links on XDA (you should search for) - for Windows, Linux, even for Android (not working great with bin files of several GBs), and with instructions

    Link to my copy (for Windows) I downloaded months ago from XDA and happily used couple of times:

    Thanks for that worked really well, and solved my issue.
  • 8
    However, since the system is already rooted using Magisk shouldn't these folders be unencrypted?
    Magisk has nothing to do with File Based Encryption on Data and Storage.
    That's part of the File System definition - Magisk does not redefine File Systems.
    And when running Android, kernel takes care of FBE

    Btw, why would you (and some other users who maybe first time face FBE) dislike FBE (or be afraid of, or what) and want instead your files to be permanently unencrypted?!

    If you have a proper custom Recovery, it will ask for your pin/pattern and by use of that pin, it will then unencrypt file by file, on demand - just like Android does when you boot to Android

    Then, if your phone is stolen and the thief-hacker reboots to TWRP, he will not be able to steal your documents, phoos, etc, since (s)he does not know your Android unlock pin/pattern (and therefore TWRP cannot decrypt him your files - he can copy the encrypted files to PC but they will be of no use for him)

    However, without encryption, if your phone (with the TWRP installed) gets stolen, thief can simply boot to TWRP and copy all your personal files to PC.
    He can then open and read your documents, see your private photos, etc

    ---

    The official Google FBE documentation is available at:

    ---

    And one important tip:
    When installing custom ROM, usually you have to FORMAT Data (not just Wipe) that your new ROM could properly reformat FBE for itself - only then things will work as described (TWRP and FBE)

    But all that is out-of-topic for our Magisk thread

    Developers of custom ROMs should provide clear instructions how to properly install their ROMs - and their users of custom should take time to read instructions before flashing👍

    ---

    You can go to /vendor/etc/ (aka /system/vendor/etc one has to be mounted to the other in Android)
    and find a file fstab.* (on my phone it is named fstab.emmc).
    That's the read-only, textual file

    Inside, search for /userdata (filesystem definition).
    On my phone it looks like:
    Code:
    /dev/block/bootdevice/by-name/userdata /data f2fs noatime,nosuid,nodev,discard,inlinecrypt,reserve_root=32768,resgid=1065,fsync_mode=nobarrier latemount,wait,check,formattable,fileencryption=aes-256-xts:aes-256-cts:v2+emmc_optimized+wrappedkey_v0,keydirectory=/metadata/vold/metadata_encryption,metadata_encryption=aes-256-xts:wrappedkey_v0,quota,reservedsize=128M,sysfs_path=/sys/devices/platform/soc/1d84000.ufshc,checkpoint=fs

    Actually, inside that line look for the fileencryption definition - in my case:
    Code:
    fileencryption=aes-256-xts:aes-256-cts:v2+emmc_optimized+wrappedkey_v0

    Flag :v2 means that I have FBE v2. It's also emmc_optimized with hardware-wrapped keys (details and description can be found in the Google's FBE documentation as linked above)
    7
    By the way, there is another thread with detailed OP instructions for the new Magisk v24/v25:

    And a thread that was opened for hiding root with the new Magisk:

    Those new threads were opened because of this old and cluttered thread.
    Unfortunately, people still report/ask here (and in parallel complain that thread is too big to read☹️)
    6
    Its trivial to sniff or even MITM a desktop, or even just run WinPE and reset admin password and use the users own saved passwords in their browser, heck even export their passwords....

    In any event the biggest risk vector is social engineering

    Chasing root phone users only gives them a "feelgood", it does nothing to stop genuine misuse and fraud, at all.....

    I dont see Google or a bank sending out a representative every time someone makes a transaction to see if theyre genuine....trying to control the device is attacking the wrong end of the transaction and is ultimately pointless
    They're not chasing root users. They just want a guarantee that the device is secure, and they have good reason to. Rooting by nature compromises device security.

    I'm not saying your opinion is invalid; in this context however, it is irrelevant, because regardless of how you may feel about the situation, it's not going to change.
    6
    I had root, a few apps still recognize it, updating to the newest magisk manager shows n/a for magisk installed. Do I just grab my boot IMG out of my ROM and do it sgain? Will I keep all my data and info...?
    Did you have Magisk App hidden when updated?... Classic trap... Supposed to work, but bit like a pot-luck dinner...

    You're probably suffering from DACFRAS*, which is NOT fatal but all the clinics are full...

    Check in device settings, Apps for your old hidden App... Default name is 'settings', or its what you named it... Uninstall it, and presto!

    *Dual Apps Competing For Root Access Syndrome...

    😜 PW
  • 1085
    This is the place for general support and discussion regarding "Public Releases", which includes both stable and beta releases.
    All information, including troubleshoot guides and notes, are in the Announcement Thread
    156
    Hello, I haven't given much support on XDA lately. It can be resulted from
    • University started and I have limited free time. In fact, I mostly develop during midnight
    • I live in Taiwan, which has large time zone differences between my European/American contributors/testers, which usually forces me to stay up late at night to discuss/test stuffs.
    • The new version is about to come, I don't want to spend effort on supporting old releases
    The planned update is delayed again and again, to some point I think I'll shed some light about what has been happening lately, also along with some announcements.

    New Forum!
    As you might have already discovered, Magisk got its own subforum on XDA! Many thanks to all the support you gave me, and much more information/features/support is about to come!
    **For developers supporting all the devices that are not using standard Android boot format, feel free to create threads in this section (actually, PLEASE do so) for your favorite devices after v7 is out. As I currently know, Asus devices require signing the boot image before flashing, and is model dependant; Sony devices seems to use ELF kernel that is unpatchable, or some has two ramdisks (inner + outer), both requires different workarounds; LG bootloader locked devices has to manually "BUMP" the boot image after flashing Magisk..... and there may be lots of other crazy boot image formats that haven't come up to my attention yet.
    It is impossible for me to support all these non-standard boot images, and I hope the community can collaborate to make Magisk running across all the devices. Overall, community collaboration is what XDA about :D

    The Pixel Phone
    Some of you might already know this news, that the next Pixel Phone right around the corner seems like it does not have ramdisk in boot image, which pretty much wrecked Magisk in all ways. However, it pretty much doomed root itself too. Kernel modifications is inevitable IMO, so I'll try to migrate my scripts to C programs that could possibly be included into the kernel itself. Note that I'm not familiar with linux kernel, I'm not even sure if my idea and concept is correct or not. But once the device is available, I think developers will find a way to bypass all the difficulties, and I'll do my best to learn things ;)

    Current Progress
    In the past month, I've spent quite some time learning SELinux, so that I can avoid using SuperSU's sepolicy patches. Thanks to the helps and tips from @phhusson and @Chainfire, I finally have a much clearer understanding of how SELinux works. The Magisk core parts (the scripts, boot image patches, new features, more supports) are actually done some time ago. What is causing all the delays is the Magisk Manager.
    To be completely honest, although I can code in Java without much issues, Magisk Manager is actually my first Android application, I had to reach out for assistance, and fortunately awesome developers like @DVDandroid and @digitalhigh contributed a lot, which makes the current Manager awesome.
    After the repo system and module management is mostly done, I was about to do some adjustments and release, but what we really done is decided to add another feature: auto-unroot with per-app settings. I decided to wait for it to be finished, and then do my adjustments. Due to reasons that'll be mentioned later, this feature will likely not be available for the next release (should come in future updates)

    Safety Net Disaster
    Those who are using Magisk for Safety Net bypass purposes must have known that Google recently updated the detection method of my Systemless Xposed. I still have no idea what Safety Net is detecting, so currently I cannot fix it on my side (also because I'm busy working on the next update). However, suhide developed by @Chainfire is able to hide Xposed and worked fine.
    However, only my Systemless Xposed v86.2, which is based on SuperSU's su.d, is supported using that method. v86.2 and v86.5 (latest, Magisk based) have nearly identical binaries, and the only difference is the path where the binaries are stored.
    I'm still not sure what's the real issue for it not being supported, I just hope it is not done intentionally.

    Conclusion
    Due to the fact that my Safety Net bypass is not 100% perfect now, I do not want to spend any more time waiting for auto-unroot to be polished. What I'm doing now is finishing up all the things I'd like to change in Magisk Manager (it has been a while since I last contributed to Manager, my fellow developers are doing all the heavy job), which might take a little more time, after that, packed with tons of information to be announced in Magisk Section, I'll release the long awaited update.

    Hope this lengthy post gives you the idea of the whole situation, and again thanks for all your support!!
    121
    Ah, some Chainfire bashing, I hope it is not too late for me to exercise additional villainy.

    First, let me make clear I have nothing against @topjohnwu, nor against Magisk. Magisk is an interesting project and it certainly displays @topjohnwu ingenuity and persistence. I don't doubt we will see more interesting things from his hands.

    -------------------------

    What has happened here is not all that dark and complicated, from either end. I returned from holidays, and someone pointed me at Magisk. My first thought: interesting!

    Among other things, the thread lists some issues with SuperSU, which in combination with the phrase The developer also requests users to not bug Chainfire with compatibility requests for SuperSU with Magisk from the portal article, raised my left eyebrow by nigh half an inch. The popular systemless xposed mod is apparently now based on it, and apparently it now no longer works with SuperSU, and apparently I'm not supposed to fix that, nor any of the other found issues. I found that a bit weird. So yes, I have told @topjohnwu that I was a bit surprised he was posting about issues with SuperSU without notifying me about them (I can't fix or help fix issues I'm not aware of, after all).

    He's also spreading a modified version of the SuperSU package, which is not all that uncommon, nor necessarily a problem. I have not looked into what he modified, I only ran a few quick tests on one of my devices, and found some commonly used commands run as root to be broken. I have informed him of this as well.

    It appears the tool of choice for Magisk is phh's Superuser, because of some of the mentioned issues with SuperSU. That's fine by itself, but fixing issues in that superuser by incorporating SuperSU's binaries into it is a somewhat questionable practise. After all, SuperSU is a commercial closed-source package that helps pay for my dinner, and superuser is a direct competitor. I have informed him that I was surprised he did this without asking for permission. I have expressed similar surprise on him spreading a modified version of LiveBoot (which helps pay for a snack now and then).
    @topjohnwu has also stated that Magisk's scripts are largely influenced by mine (I have not checked). Scripts based on mine are used all over the place on XDA, some people have crafted amazing things based on them, I have never made an issue of this (otherwise I would have just made them binaries). But yes, I have also stated to him that I don't think it's very nice to base something on one program, and then using that to (almost exclusively) push something directly competing with that program.

    tl;dr Towards @topjohnwu, I have:
    - expressed surprise he has issues getting Magisk to work with SuperSU, and has chosen not to inform me about those
    - expressed surprise he is using SuperSU binaries in a competing superuser without permission
    - expressed surprise he is posting a modified LiveBoot without permission
    - informed him of issues with the modified SuperSU he has posted
    - let him know I thought it wasn't very nice to be applying my scripts to benefit seemingly exclusively that same competing superuser

    To be crystal clear:
    - I have not asked for an apology
    - I have not asked for Magisk to be abandoned, neither the root hiding nor systemless module parts, and certainly not systemless xposed
    - I have not made an issue of any of this anywhere, until this post
    - I have not even specifically asked for anything to be taken down (though obviously in my opinion the other superuser package mixed with SuperSU's binaries, as well as the LiveBoot package, should go)
    - I have not reported this thread to XDA moderators for copyright violations or otherwise

    While my conversation with @topjohnwu may not win any awards for being friendly (though it may win some for brevity), I think all things considered my response has been rather mild. To be perfectly honest, until the apology post, I thought this was over with already. I think the apology post was triggered because I haven't replied to his last PM for a while - I was in the zone, it happens.

    To emphasize again, I have nothing against @topjohnwu, Magisk, or systemless xposed, and it is certainly not my goal to see any of them go. If it can be made to work together with SuperSU, great.

    I get it though: you think of something, you want to see if you can make it work, you finally get it to work, you publish it, it takes off - enthusiasm gets the better of you. Maybe in the rush some mistakes are made. That doesn't mean you have to just drop it and run. None of my stuff would make it past 0.1 if I stopped at the first big mistake :)

    Aside from said being in the zone coding, I usually regret actually responding to these sort of things the day after, which has made me hesitant to reply. Surprise me.
    76
    Thread temporarily closed so everyone sees this.

    The flood of "SafetyNet isn't working for me either!" posts are not helpful, at all. Please refrain from posting further, it will be looked into. Please do not forget that not passing SafetyNet is 100% NORMAL AND INTENDED when you have an unlocked booloader or running custom firmware. These are workarounds and they will be worked around in turn.

    The Flash
    Forum Moderator

    EDIT: Thread is reopened... I will be cleaning any SafetyNet posts for a while to keep the thread clean for real issues.
    75
    Hello everyone!

    I am aware that Google has updated Safety Net that makes Magisk itself a no go for Android Pay. In fact, I witnessed the change live while I am developing the new magiskhide, which should hide all Magisk modules and Magisk installed root.

    Google is serious about Safety Net now, clearly hunting down all possibility to run Xposed with Safety Net passed. I spend quite some time examining the new security measures last midnight, and fortunately it seems that it is possible to run Magisk and root along with Safety Net if no Xposed is running. I'm glad I removed the old root toggle at the right time lol, that is no longer feasible with the latest detection.

    So stay tuned for the next update, it will come with bug fixes, along with the new magiskhide to bypass that Safety Net.

    Google, how will a few systemless mods do any harm :p:p