If you know how can I fix my issue can you help me pleasee?? I did not understand very well what's the matter but as I remeber I didn't touched or changed anything
Magisk General Support / Discussion
- Thread starter topjohnwu
- Start date
I turned off verity and verification by adb'ing the vbmeta file with flags then upgrading to 25.1 from the app, rebooted once more and it got stuck again. The phone then had a tricky time getting in to recovery, but I flashed 24.0 and all was well again. I checked that verity is off through Termux ("verity is disabled on slot with suffix _a"/"verification is disabled on slot with suffix _a"). Maybe the original lineage kernel would let it boot I didn't do any other testing though.Ok...
Be aware that Magisk should still work going forward with ROMs/ Kernels that will boot w/o Magisk, either as-is or w/ verity/verification disabled first by user... If verity/verification disabled is needed, it will also now be needed with Magisk 24303+.
Explanation from Shana (dev) here:
https://github.com/topjohnwu/Magisk/issues/5777#issuecomment-1121937108
I'm assuming official LineageOS should be bootable without Magisk, but if it requires verity/verification disabled to boot without on your device it will likewise require this now w/ 24303+...
Configurations that rely on Magisk to strip avb_key and avb verification flags for partitions will no longer work as Magisk no longer does / needs these changes (since fstab modification is not used for magiskinit injection in 2SI any longer).
This means a number of custom ROMs / kernels, including your Kirisakura kernel by @Freak07, will bootloop on some devices if you don't disable verity/verification before booting... Also worth noting is this new trap:
https://github.com/topjohnwu/Magisk/issues/5777#issuecomment-1123830105
This occurs when seeing
https://github.com/topjohnwu/Magisk/issues/5777#issuecomment-1123939156
PW
Last edited:
As I mentioned above, there may be issues upgrading (Direct installing) Magisk from earlier Magisk that patched fstab for magiskinit injection due to (unexpected?) need to revert previous modifications:
The clue was this terse recommendation given to a user facing the same issue on a OnePlus device:
https://github.com/topjohnwu/Magisk/issues/6022#issuecomment-1163779264
before the issue was closed with no further explanation...
SInce then, @osm0sis has asked
and Canyie finally clarified with this:
https://github.com/topjohnwu/Magisk/issues/6022#issuecomment-1165110166
So it's now confirmed that Direct Install will fail where previous Magisk installation (ie. method of injection etc) is no longer supported although a fresh install will work...
Hope this clarifies the reasons why you and others facing issues (bootloops etc) updating to 25.x (24303+) on 2SI devices need to
1) Do a fresh initial installation (patch/flash an original boot image) of Magisk, and
2) In some cases, eg where a custom kernel requires verity/verification disabled to boot, you may need complete Magisk Uninstall and OS booting w/o Magisk before taking fresh Magisk initial installation.
So:
Try patching/flashing unpatched image for fresh install...
Your best chance (w/ Kirisakura kernel) would be to do complete Uninstall Magisk from app main page (or simply delete everything in /data/ADB and fastboot flash stock/unpatched images), then get ROM booting without Magisk using 3rd party means to disable verity/verification if needed. After this do a fresh install (patch/flash boot image from current ROM package) of Magisk...
PW
Last edited:
Uh where's the love?
Glad we still have ppl like him aboard, BUT maybe it's because THE @osm0sis
Ponkles can't beat him too
Hey thanks. I tried all that - uninstalling Magisk from the app, rebooting, patching the original lineage image, flashing that, rebooting and installing 25.1, rebooting again and it booted fine. I then flashed the Kirisakura kernel and - stuck at fastboot again! Only the patched recovery image or downgrading Magisk got it to boot. Verity & verification is still disabled. Although oddly, wifi refuses to work when on the patched lineage recovery image. The phone starts with wifi not connected, and turning it on in settings does nothing, and is always turned off again when looking in settings afterwards. Once I downgraded Magisk and flashed Kirisakura, wifi now works again.As I mentioned above, there may be issues upgrading (Direct installing) Magisk from earlier Magisk that patched fstab for magiskinit injection due to (unexpected?) need to revert previous modifications:
The clue was this terse recommendation given to a user facing the same issue on a OnePlus device:
https://github.com/topjohnwu/Magisk/issues/6022#issuecomment-1163779264
before the issue was closed with no further explanation...
SInce then, @osm0sis has asked
and Canyie finally clarified with this:
https://github.com/topjohnwu/Magisk/issues/6022#issuecomment-1165110166
So it's now confirmed that Direct Install will fail where previous Magisk installation (ie. method of injection etc) is no longer supported although a fresh install will work...
Hope this clarifies the reasons why you and others facing issues (bootloops etc) updating to 25.x (24303+) on 2SI devices need to
1) Do a fresh initial installation (patch/flash an original boot image) of Magisk, and
2) In some cases, eg where a custom kernel requires verity/verification disabled to boot, you may need complete Magisk Uninstall and OS booting w/o Magisk before taking fresh Magisk initial installation.
So:
Try patching/flashing unpatched image for fresh install...
Your best chance (w/ Kirisakura kernel) would be to do complete Uninstall Magisk from app main page (or simply delete everything in /data/ADB and fastboot flash stock/unpatched images), then get ROM booting without Magisk using 3rd party means to disable verity/verification if needed. After this do a fresh install (patch/flash boot image from current ROM package) of Magisk...
Last edited:
I don't know how much patching Magisk does to the kernel itself, but I would think it would be a bad idea to try to change the kernel on a system on which Magisk is installed. Rather, I think you should replace the kernel on a "stock" system, let Magisk patch the resultant boot image, and flash that.
Please see my last post for further explanation...
so since you seem to have this issue, you still need to do this...
Known issue, but not a regression, so no further fixes will come... (Edit: Except this one: https://forum.xda-developers.com/t/magisk-general-support-discussion.3432382/post-87068697 )
Basically, Direct install breaks due to previous Magisk injection method for 2SI being incompatible with new Magisk... It's more complicated in configurations where disabling verity/verification to boot is still required, but for most 2SI device users the solution is simply to do initial Patch and fasttboot flash original boot image again, thereby replacing the incompatible fstab-patched image...
PW
Last edited:
Confirms issue was previous fstab patching...
Is this a typo?...
Patching recovery image either Pixel 3 or any 2SI device is not needed / may cause issues as it's designed only for A-only legacy SAR devices, although it will likely work for root...
As I said, Magisk in recovery ramdisk is not intended for your device... Expect such issues...
Sure...
So you need to patch/flash Kirisakura boot image, NOT recovery image... However it seems your current/new method(s) for disabling verity/verification may be inadequate...
Did you do this?:
Of course, 'boot image from current ROM package' in this case is image with Kirisakura kernel...... Your best chance (w/ Kirisakura kernel) would be to do complete Uninstall Magisk from app main page (or simply delete everything in /data/ADB and fastboot flash stock/unpatched images), then get ROM booting without Magisk using 3rd party means to disable verity/verification if needed. After this do a fresh install (patch/flash boot image from current ROM package) of Magisk...
In theory the above method should work, but others are trying this as we speak, so you'll likely get specific help in forums for you device and for Kirisakura kernel...
Bit further, @capntrips has managed to get Kirisakura 2.4.0 to boot on SP2A.220405.004 with verity enabled using Magisk 24310 (comment at end of main GitHub issue for this):
https://github.com/topjohnwu/Magisk/issues/5777#issuecomment-1126691707
@capntrips doesn't say if his technical method helps w/ Magisk-patched Kirisakura system booting Magisk 25+, but it may be a good start...
Yup, testing ROM/custom kernel booting without Magisk (and using 3rd party means to disable verity/verification if needed), then installing Magisk seems to be what Shana is recommending. In fact she states she won't consider issues in configurations that rely upon / won't boot without Magisk:
- https://github.com/topjohnwu/Magisk/issues/5777#issuecomment-1121769085
- https://github.com/topjohnwu/Magisk/issues/5777#issuecomment-1121937108
The issue is that Kirisakura and other configurations relied on Magisk to strip avb_key and avb flags for partitions... This function is no longer generally performed for 2SI devices in 25+.
The fact that similar custom configurations relying on any 'undocumented internal behaviors of Magisk' will not be supported (ie. will be marked 'wontfix') is also now evident/clarified...
https://github.com/topjohnwu/Magisk/issues/5777#issuecomment-1118202208
PW
Last edited:
I haven't read back through to get the context in this thread, and I'm on mobile, so I can't easily link to the relevant posts, but I made a tool (Hashtree Patcher, see my sig) to simplify the process, and that has been integrated with AK3 and is included in the latest build or so of Kirisakura.
Last edited:
Efforts to be Friendly and ClearUh where's the love?
Glad we still have ppl like him aboard, BUT maybe it's because THE @osm0sis
Ponkles can't beat him too
Actually, I applaud all Magisk dev's efforts w/ such curly issues... and now Canyie has come to the party, and Shana and @osm0sis have joined the dance also, finally approving this Pull Request - More friendly and clear error message #6030
This changes error messages seen.
Old scripts/boot_patch.sh
ui_print
! Unsupported boot image $dt
abort
! Please restore back to stock boot image
New scripts/boot_patch.sh
ui_print
! Boot image $dt was patched by old (unsupported) Magisk
abort
! Please try again with *unpatched* boot image
So friendly and clear error messages "to make people happier" will be coming to a Magisk distribution near you at any tick of the clock!
PW
Last edited:
Test with Magisk v25.1:
- open Terminal
- do not execute su
(do not go as root/superuser)
- test:
which su
With Magisk Canary 25101 it returns for me:
system/bin/su
Since I did not request (and was not granted root privileges yet), IMO I must not see the su in the path
I'm not sure how it was with earlier versions of Magisk, but I became suspicious since the new Momo v4.3.1 detects:
"Found executable su in the path" - although Momo is properly in DenyList
See the screenshot
- open Terminal
- do not execute su
(do not go as root/superuser)
- test:
which su
With Magisk Canary 25101 it returns for me:
system/bin/su
Since I did not request (and was not granted root privileges yet), IMO I must not see the su in the path
I'm not sure how it was with earlier versions of Magisk, but I became suspicious since the new Momo v4.3.1 detects:
"Found executable su in the path" - although Momo is properly in DenyList
See the screenshot
Attachments
Last edited:
Wasn't it always this way? How else would the shell find `su` when you try to run it?
What if you add `terminal` to your deny list?
Attachments
Last edited:
On RN8T w/ A10 MIUI stock & 25101,
which su gives /sbin/su, but my Momo isn't showing 'Found executable su in the path'...For me it's 'init.rc is modified' and 'Found zygisk' that have returned...
PW
Edit: Thinking about this, I think you're showing results for new 2SI device... Mine is Legacy SAR...
I'm guessing, but detectable 'executable su in the path' could be a regression from new magiskinit refactoring of 2SI implementation... Being brand new, I imagine it will get further attention... hopefully...
Last edited:
You should use
which -a su to see all the directories in your path containing su, not just the first one.
@zgfg @pndwal
How does hiding root work?
When target app on hidelist / denylist is opened, Magisk will immediately unmount Magisk tmpfs mountpoint, dummy skeleton tmpfs and magisk created mount bind so there are no /sbin/su or /system/bin/su (Android 11+) in target apps.
See the source code:
Denylist unmount: zygisk/deny/revert.cpp
MagiskHide: magiskhide/hide_policy.cpp
Momo is abusing isolated process and app zygote process to bypass MagiskHide and detect Magisk. And the fact that not all banking apps use isolated process or app zygote.
Last edited:
Mine is a bit different, it's from termux
Attachments
Similar threads
Top Liked Posts
-
2
Yes; Sorry! - I edited my remark!
It was based on John's release note:
v 25.0:
[MagiskInit] Support Android 13 GKIs (Pixel 6)
which was connected with:
- this:
Support GKIs without ramdisk …
Fix #5819
I initially assumed the fix meant p6 had the new init_boot image scheme, but it actually lacked ramdisk in boot.img due to this being moved to new vendor_boot!
John's chosen fix actually involved recreating ramdisk in boot.img for magisk.init. This:
So this fix actually allows implementations of Android 13 GKIs for updated devices (Pixel 6 etc) to work...
vv's note however, preempts Android 13 release devices, ie. Pixel 7+...
PW1
Same as you.Nah, as it says, it will be released soon, i was just giving folks, and you especially a heads up
Personally i abandoned it (it had *nothing to do* with that time i removed lsposed but forgot to uninstall the magisk module portion of HMA and bootlooped myself ) for updatelocker some time ago, as it does all i was really using HMA for.
But with the talk the new HMA will drop the magisk module, i might give it another go
I am waiting for the new official release.
Is Hide-My-Applist actually shifting to Zygisk.
ZygoteArgsHook for Android 11+
Cheers.
PS.
One of these days I will look up the tg channel. -
8
Magisk has nothing to do with File Based Encryption on Data and Storage.
That's part of the File System definition - Magisk does not redefine File Systems.
And when running Android, kernel takes care of FBE
Btw, why would you (and some other users who maybe first time face FBE) dislike FBE (or be afraid of, or what) and want instead your files to be permanently unencrypted?!
If you have a proper custom Recovery, it will ask for your pin/pattern and by use of that pin, it will then unencrypt file by file, on demand - just like Android does when you boot to Android
Then, if your phone is stolen and the thief-hacker reboots to TWRP, he will not be able to steal your documents, phoos, etc, since (s)he does not know your Android unlock pin/pattern (and therefore TWRP cannot decrypt him your files - he can copy the encrypted files to PC but they will be of no use for him)
However, without encryption, if your phone (with the TWRP installed) gets stolen, thief can simply boot to TWRP and copy all your personal files to PC.
He can then open and read your documents, see your private photos, etc
---
The official Google FBE documentation is available at:
File-Based Encryption | Android Open Source Project
source.android.com
---
And one important tip:
When installing custom ROM, usually you have to FORMAT Data (not just Wipe) that your new ROM could properly reformat FBE for itself - only then things will work as described (TWRP and FBE)
But all that is out-of-topic for our Magisk thread
Developers of custom ROMs should provide clear instructions how to properly install their ROMs - and their users of custom should take time to read instructions before flashing
---
You can go to /vendor/etc/ (aka /system/vendor/etc one has to be mounted to the other in Android)
and find a file fstab.* (on my phone it is named fstab.emmc).
That's the read-only, textual file
Inside, search for /userdata (filesystem definition).
On my phone it looks like:
Code:/dev/block/bootdevice/by-name/userdata /data f2fs noatime,nosuid,nodev,discard,inlinecrypt,reserve_root=32768,resgid=1065,fsync_mode=nobarrier latemount,wait,check,formattable,fileencryption=aes-256-xts:aes-256-cts:v2+emmc_optimized+wrappedkey_v0,keydirectory=/metadata/vold/metadata_encryption,metadata_encryption=aes-256-xts:wrappedkey_v0,quota,reservedsize=128M,sysfs_path=/sys/devices/platform/soc/1d84000.ufshc,checkpoint=fs
Actually, inside that line look for the fileencryption definition - in my case:
Code:fileencryption=aes-256-xts:aes-256-cts:v2+emmc_optimized+wrappedkey_v0
Flag :v2 means that I have FBE v2. It's also emmc_optimized with hardware-wrapped keys (details and description can be found in the Google's FBE documentation as linked above)7By the way, there is another thread with detailed OP instructions for the new Magisk v24/v25:
[Discussion] Magisk - The Age of Zygisk.
This is a discussion and help thread for the...
forum.xda-developers.com
And a thread that was opened for hiding root with the new Magisk:
[Discussion] How to bypass detections of rooting ?
Did you have problems with some app that...
forum.xda-developers.com
Those new threads were opened because of this old and cluttered thread.
Unfortunately, people still report/ask here (and in parallel complain that thread is too big to read
)6
Did you have Magisk App hidden when updated?... Classic trap... Supposed to work, but bit like a pot-luck dinner...
You're probably suffering from DACFRAS*, which is NOT fatal but all the clinics are full...
Check in device settings, Apps for your old hidden App... Default name is 'settings', or its what you named it... Uninstall it, and presto!
*Dual Apps Competing For Root Access Syndrome...
PW6
They're not chasing root users. They just want a guarantee that the device is secure, and they have good reason to. Rooting by nature compromises device security.
I'm not saying your opinion is invalid; in this context however, it is irrelevant, because regardless of how you may feel about the situation, it's not going to change. -
1085This is the place for general support and discussion regarding "Public Releases", which includes both stable and beta releases.
All information, including troubleshoot guides and notes, are in the Announcement Thread156Hello, I haven't given much support on XDA lately. It can be resulted from
- University started and I have limited free time. In fact, I mostly develop during midnight
- I live in Taiwan, which has large time zone differences between my European/American contributors/testers, which usually forces me to stay up late at night to discuss/test stuffs.
- The new version is about to come, I don't want to spend effort on supporting old releases
New Forum!
As you might have already discovered, Magisk got its own subforum on XDA! Many thanks to all the support you gave me, and much more information/features/support is about to come!
**For developers supporting all the devices that are not using standard Android boot format, feel free to create threads in this section (actually, PLEASE do so) for your favorite devices after v7 is out. As I currently know, Asus devices require signing the boot image before flashing, and is model dependant; Sony devices seems to use ELF kernel that is unpatchable, or some has two ramdisks (inner + outer), both requires different workarounds; LG bootloader locked devices has to manually "BUMP" the boot image after flashing Magisk..... and there may be lots of other crazy boot image formats that haven't come up to my attention yet.
It is impossible for me to support all these non-standard boot images, and I hope the community can collaborate to make Magisk running across all the devices. Overall, community collaboration is what XDA about
The Pixel Phone
Some of you might already know this news, that the next Pixel Phone right around the corner seems like it does not have ramdisk in boot image, which pretty much wrecked Magisk in all ways. However, it pretty much doomed root itself too. Kernel modifications is inevitable IMO, so I'll try to migrate my scripts to C programs that could possibly be included into the kernel itself. Note that I'm not familiar with linux kernel, I'm not even sure if my idea and concept is correct or not. But once the device is available, I think developers will find a way to bypass all the difficulties, and I'll do my best to learn things
Current Progress
In the past month, I've spent quite some time learning SELinux, so that I can avoid using SuperSU's sepolicy patches. Thanks to the helps and tips from @phhusson and @Chainfire, I finally have a much clearer understanding of how SELinux works. The Magisk core parts (the scripts, boot image patches, new features, more supports) are actually done some time ago. What is causing all the delays is the Magisk Manager.
To be completely honest, although I can code in Java without much issues, Magisk Manager is actually my first Android application, I had to reach out for assistance, and fortunately awesome developers like @DVDandroid and @digitalhigh contributed a lot, which makes the current Manager awesome.
After the repo system and module management is mostly done, I was about to do some adjustments and release, but what we really done is decided to add another feature: auto-unroot with per-app settings. I decided to wait for it to be finished, and then do my adjustments. Due to reasons that'll be mentioned later, this feature will likely not be available for the next release (should come in future updates)
Safety Net Disaster
Those who are using Magisk for Safety Net bypass purposes must have known that Google recently updated the detection method of my Systemless Xposed. I still have no idea what Safety Net is detecting, so currently I cannot fix it on my side (also because I'm busy working on the next update). However, suhide developed by @Chainfire is able to hide Xposed and worked fine.
However, only my Systemless Xposed v86.2, which is based on SuperSU's su.d, is supported using that method. v86.2 and v86.5 (latest, Magisk based) have nearly identical binaries, and the only difference is the path where the binaries are stored.
I'm still not sure what's the real issue for it not being supported, I just hope it is not done intentionally.
Conclusion
Due to the fact that my Safety Net bypass is not 100% perfect now, I do not want to spend any more time waiting for auto-unroot to be polished. What I'm doing now is finishing up all the things I'd like to change in Magisk Manager (it has been a while since I last contributed to Manager, my fellow developers are doing all the heavy job), which might take a little more time, after that, packed with tons of information to be announced in Magisk Section, I'll release the long awaited update.
Hope this lengthy post gives you the idea of the whole situation, and again thanks for all your support!!121Ah, some Chainfire bashing, I hope it is not too late for me to exercise additional villainy.
First, let me make clear I have nothing against @topjohnwu, nor against Magisk. Magisk is an interesting project and it certainly displays @topjohnwu ingenuity and persistence. I don't doubt we will see more interesting things from his hands.
-------------------------
What has happened here is not all that dark and complicated, from either end. I returned from holidays, and someone pointed me at Magisk. My first thought: interesting!
Among other things, the thread lists some issues with SuperSU, which in combination with the phrase The developer also requests users to not bug Chainfire with compatibility requests for SuperSU with Magisk from the portal article, raised my left eyebrow by nigh half an inch. The popular systemless xposed mod is apparently now based on it, and apparently it now no longer works with SuperSU, and apparently I'm not supposed to fix that, nor any of the other found issues. I found that a bit weird. So yes, I have told @topjohnwu that I was a bit surprised he was posting about issues with SuperSU without notifying me about them (I can't fix or help fix issues I'm not aware of, after all).
He's also spreading a modified version of the SuperSU package, which is not all that uncommon, nor necessarily a problem. I have not looked into what he modified, I only ran a few quick tests on one of my devices, and found some commonly used commands run as root to be broken. I have informed him of this as well.
It appears the tool of choice for Magisk is phh's Superuser, because of some of the mentioned issues with SuperSU. That's fine by itself, but fixing issues in that superuser by incorporating SuperSU's binaries into it is a somewhat questionable practise. After all, SuperSU is a commercial closed-source package that helps pay for my dinner, and superuser is a direct competitor. I have informed him that I was surprised he did this without asking for permission. I have expressed similar surprise on him spreading a modified version of LiveBoot (which helps pay for a snack now and then).
@topjohnwu has also stated that Magisk's scripts are largely influenced by mine (I have not checked). Scripts based on mine are used all over the place on XDA, some people have crafted amazing things based on them, I have never made an issue of this (otherwise I would have just made them binaries). But yes, I have also stated to him that I don't think it's very nice to base something on one program, and then using that to (almost exclusively) push something directly competing with that program.
tl;dr Towards @topjohnwu, I have:
- expressed surprise he has issues getting Magisk to work with SuperSU, and has chosen not to inform me about those
- expressed surprise he is using SuperSU binaries in a competing superuser without permission
- expressed surprise he is posting a modified LiveBoot without permission
- informed him of issues with the modified SuperSU he has posted
- let him know I thought it wasn't very nice to be applying my scripts to benefit seemingly exclusively that same competing superuser
To be crystal clear:
- I have not asked for an apology
- I have not asked for Magisk to be abandoned, neither the root hiding nor systemless module parts, and certainly not systemless xposed
- I have not made an issue of any of this anywhere, until this post
- I have not even specifically asked for anything to be taken down (though obviously in my opinion the other superuser package mixed with SuperSU's binaries, as well as the LiveBoot package, should go)
- I have not reported this thread to XDA moderators for copyright violations or otherwise
While my conversation with @topjohnwu may not win any awards for being friendly (though it may win some for brevity), I think all things considered my response has been rather mild. To be perfectly honest, until the apology post, I thought this was over with already. I think the apology post was triggered because I haven't replied to his last PM for a while - I was in the zone, it happens.
To emphasize again, I have nothing against @topjohnwu, Magisk, or systemless xposed, and it is certainly not my goal to see any of them go. If it can be made to work together with SuperSU, great.
I get it though: you think of something, you want to see if you can make it work, you finally get it to work, you publish it, it takes off - enthusiasm gets the better of you. Maybe in the rush some mistakes are made. That doesn't mean you have to just drop it and run. None of my stuff would make it past 0.1 if I stopped at the first big mistake
Aside from said being in the zone coding, I usually regret actually responding to these sort of things the day after, which has made me hesitant to reply. Surprise me.76Thread temporarily closed so everyone sees this.
The flood of "SafetyNet isn't working for me either!" posts are not helpful, at all. Please refrain from posting further, it will be looked into. Please do not forget that not passing SafetyNet is 100% NORMAL AND INTENDED when you have an unlocked booloader or running custom firmware. These are workarounds and they will be worked around in turn.
The Flash
Forum Moderator
EDIT: Thread is reopened... I will be cleaning any SafetyNet posts for a while to keep the thread clean for real issues.75Hello everyone!
I am aware that Google has updated Safety Net that makes Magisk itself a no go for Android Pay. In fact, I witnessed the change live while I am developing the new magiskhide, which should hide all Magisk modules and Magisk installed root.
Google is serious about Safety Net now, clearly hunting down all possibility to run Xposed with Safety Net passed. I spend quite some time examining the new security measures last midnight, and fortunately it seems that it is possible to run Magisk and root along with Safety Net if no Xposed is running. I'm glad I removed the old root toggle at the right time lol, that is no longer feasible with the latest detection.
So stay tuned for the next update, it will come with bug fixes, along with the new magiskhide to bypass that Safety Net.
Google, how will a few systemless mods do any harm
