Magisk General Support / Discussion

Search This thread

zgfg

Senior Member
Oct 10, 2016
7,641
5,047
Not sure how to test, but basic rule is Any launched with Android 10+ and Legacy ramdisk devices updated to/running Android 10 + Pixel 3/3a series devices. Those launched with Legacy SAR (generally Android :cool:, apart from Pixel 3/3a series which were "retrofitted" by Google and the exception, are "stuck" as Legacy SAR boot type devices... PW
Sorry, I didn't decipher

It's Xiaomi Mi 11 Lite 5G NE, launched with MIUI 12.5, Android 11 - I didn't upgrade to A12, and running stock firmware (only Magisk and custom Recovery)

It's A/B device, with Recovery integrated to Boot, Magisk recognizes as Ramdisk Yes

2SI or not?
 

pndwal

Senior Member
Sorry, I didn't decipher

It's Xiaomi Mi 11 Lite 5G NE, launched with MIUI 12.5, Android 11 - I didn't upgrade to A12, and running stock firmware (only Magisk and custom Recovery)

It's A/B device, with Recovery integrated to Boot, Magisk recognizes as Ramdisk Yes

2SI or not?
For sure! ...

With a number of exceptions, the 3 boot types are:
• Legacy Ramdisk, RV < Android 9
• Legacy SAR, LV Android 9
• 2SI "SAR"* LV > Android 9 & LV < Android 9 w/ RV > Android 9

Key:
LV = Launch Version
RV = Running Version

* If this is SAR is debatable... John Wu says it is 'for Magisk's purposes'. Some Google docs say it's a form of System As Root, others say it's not as Initial rootdir is rootfs despite Final rootdir being system. 🙃 PW
 
Last edited:
  • Like
Reactions: Fif_

pndwal

Senior Member
Yup, A-only can be 2SI if we remove skip_initramfs=1 from cmdline
I mean some 2SI devices are A-only out-of-the-box; (these don't share boot ramdisk with recovery like A/B do).

More importantly, A/B SAR & Ramdisk Yes does not mean @zgfg's device is 2SI... Some are Legacy SAR (eg Pixel 1 & 2)...

Launch version Android 10+ is what indicates 2SI. PW
 
Last edited:

dr4go

Senior Member
Dec 17, 2010
453
374
Vienna
Momohider-Mod removed because the original Momohider module author decided to flex on Telegram for an audience of his inner circle on Telegram and accuse me of not including source code, which of course i did, because of course my ONLY alteration/change/addition was to a script file, which is of course its own source....and he also asserted i didnt notify him, when i did. That he was too lazy to check his notifications isnt my fault.

I credited him here as well, and that credit was visible for the 2 months the attached mod was here

So sorry, but my helpful mod is removed due to that idiot

Sorry he was too lazy to automate adding the config switches to make your lives easier, and that he decided to be a **** when i added a way for people to more easily use his module, and informed him of my additions to allow this

Sadly he chose to wait 2 months and then troll me on Telegram....
Is your mod still available anywhere / could you provide me a link? Thanks a lot in advance.
 

vMAC

Senior Member
Oct 21, 2007
340
34
Please look at your screenshot. It shows everything - please read

Your installed app is v25001 but it shows that latest is v25101

If you are blocked from Installing from unknown sources, go to Magisk GitHub and download Canary APK 25101 (not stable 25001) and install by adb

Or, if you already downloaded Canary 25101 and attempted to install by adb, then check if adb installing reported you an error (due to Intune?!)- that could be also the reason why you still have Magisk app 25001, not 25101

Also, your Magisk app is hidden. For many reasons it is better to unhide before updating. If Install from unknown sources blocks you to unhide, then uninstall the old Magisk app and then install theEW

Please look at your screenshot. It shows everything - please read

Your installed app is v25001 but it shows that latest is v25101

If you are blocked from Installing from unknown sources, go to Magisk GitHub and download Canary APK 25101 (not stable 25001) and install by adb

Or, if you already downloaded Canary 25101 and attempted to install by adb, then check if adb installing reported you an error (due to Intune?!)- that could be also the reason why you still have Magisk app 25001, not 25101

Also, your Magisk app is hidden. For many reasons it is better to unhide before updating. If Install from unknown sources blocks you to unhide, then uninstall the old Magisk app and then install the new 25101

Again, Magisk app (former mngr) is not Magisk itself. Uninstalling Magisk app will not uninstall Magisk itself (but you have to uninstall the app, like any app - and not through adb, bcs it will only disable the old app package but will leave it present on the system)
Where can I find the latest v25101? If I go to the github site and download the latest canary it doesn't tell me what the version is, but I assumed it was the latest v25101.
 

J.Michael

Recognized Contributor
Jan 20, 2018
1,261
1,201
Samsung Galaxy Tab A series
Sometimes, you have to dig deeper within Github to get results?
To be fair, github is a maze of twisty little passages.
I have found the download links in the past.
Other times, where I am, there seen to be no links to what I want, or to unwind my state to let me wander down to the download links. Maybe if I actually read the flowery manual...
 
  • Like
Reactions: rodken

m0han

Senior Member
Apr 30, 2012
5,006
2,057

Attachments

  • Screenshot_20220628_223312.jpg
    Screenshot_20220628_223312.jpg
    169.3 KB · Views: 50

zgfg

Senior Member
Oct 10, 2016
7,641
5,047
Where can I find the latest v25101? If I go to the github site and download the latest canary it doesn't tell me what the version is, but I assumed it was the latest v25101.
OMG

In Magisk app you have DIRECT LINK to TJW GitHub

On that main GitHub page, scroll to DOWNLOAD and click on Magisk Canary (to download the latest Caneay) - how else

That's the page that looks like any Web page and one does not need to know anything about Github

True that the name of downloaded app does not Canary and version number - if unhappy with, complain to developer
 

Attachments

  • IMG_20220628_192206.jpg
    IMG_20220628_192206.jpg
    200.1 KB · Views: 35
  • IMG_20220628_192242.jpg
    IMG_20220628_192242.jpg
    146.6 KB · Views: 36

m0han

Senior Member
Apr 30, 2012
5,006
2,057
Is Zygisk enabled and Enforce DenyList disabled in Magisk app
yes. no option to disable 'enforce denylist'. i'm on the latest delta. the only change to the setup i had shamiko 0.5.0 on is usnf was updated to 2.3.1.

p.s.: that was my post you quoted, but the name is seen as vMAC and not m0han. how come?
 

Attachments

  • Screenshot_20220628_231344.jpg
    Screenshot_20220628_231344.jpg
    81.2 KB · Views: 33
  • Like
Reactions: J.Michael
yes. no option to disable 'enforce denylist'. i'm on the latest delta. the only change to the setup i had shamiko 0.5.0 on is usnf was updated to 2.3.1.
I was using Denylist Unmount v0.2 along with USNF V2.3.1.. Momo v4.3.1 detected Zygisk. Replaced DLU by the new Shamiko (v0.5.1). Momo doesn't see Zygisk anymore.
 
  • Like
Reactions: J.Michael

Top Liked Posts

  • 2
    Quick OT comment.
    To touch back on this.

    crDroid is based on Lineage.
    Think of cr as Lineage with heavy customization. 🙃

    If it does not work with Lineage, it will probably not work with cr unless it is fixed in cr.
    In turn, I would hope cr submits the fix to Lineage.

    Cheers. :cowboy:
    I did not know cdDroid background....we live and learn! Thanks for clarifying this.
    2
    I did not know cdDroid background....we live and learn! Thanks for clarifying this.

    Custom ROM's generally have just 2 sources, AOSP (Google open source) which is usually close to Pixel appearance or LineageOS.

    Just to make things murkier for you there may be 3 or 4 custom ROMs using LineageOS as a base, but often devs will "cherrypick" commits etc from other repos (other than LineageOS) to fix issues, so issues may exist on one ROM, but not another. Usually (though not always) once a dev finds fix for an issue they will share which commits theyve used to benefit the other ROM's.

    I dont miss the days, while on my s20+, of testing 3/4 ROMs a week like i used to on previous devices....

    <insert Murtaugh quote>

    p.s. If you dont get the Murtaugh quote then youre probably too young, and youre part of what daddy calls "The Problem" :)
    2
    Anyone knows if Magisk works on A13? My Pixel 4a seems to have got it this month. Tried to do a search in this thread, but the search function seems completely broken (unless I'm doing something wrong...)
    Yes it does.
    1
    I doubt it is a LOS problem - more likely an operator error! I flashed crdroid and ended up having exactly the same result.
    <SNIP>
    Quick OT comment.
    To touch back on this.

    crDroid is based on Lineage.
    Think of cr as Lineage with heavy customization. 🙃

    If it does not work with Lineage, it will probably not work with cr unless it is fixed in cr.
    In turn, I would hope cr submits the fix to Lineage.

    Cheers. :cowboy:
    1
    Finally managed to get hold of devs at LOS and their response was simply not to use adopted storage. That leaves me with the option of looking at fbind or manually move files to sdcard.

    Thanks everyone for your comments - greatly appreciated.
  • 8
    However, since the system is already rooted using Magisk shouldn't these folders be unencrypted?
    Magisk has nothing to do with File Based Encryption on Data and Storage.
    That's part of the File System definition - Magisk does not redefine File Systems.
    And when running Android, kernel takes care of FBE

    Btw, why would you (and some other users who maybe first time face FBE) dislike FBE (or be afraid of, or what) and want instead your files to be permanently unencrypted?!

    If you have a proper custom Recovery, it will ask for your pin/pattern and by use of that pin, it will then unencrypt file by file, on demand - just like Android does when you boot to Android

    Then, if your phone is stolen and the thief-hacker reboots to TWRP, he will not be able to steal your documents, phoos, etc, since (s)he does not know your Android unlock pin/pattern (and therefore TWRP cannot decrypt him your files - he can copy the encrypted files to PC but they will be of no use for him)

    However, without encryption, if your phone (with the TWRP installed) gets stolen, thief can simply boot to TWRP and copy all your personal files to PC.
    He can then open and read your documents, see your private photos, etc

    ---

    The official Google FBE documentation is available at:

    ---

    And one important tip:
    When installing custom ROM, usually you have to FORMAT Data (not just Wipe) that your new ROM could properly reformat FBE for itself - only then things will work as described (TWRP and FBE)

    But all that is out-of-topic for our Magisk thread

    Developers of custom ROMs should provide clear instructions how to properly install their ROMs - and their users of custom should take time to read instructions before flashing👍

    ---

    You can go to /vendor/etc/ (aka /system/vendor/etc one has to be mounted to the other in Android)
    and find a file fstab.* (on my phone it is named fstab.emmc).
    That's the read-only, textual file

    Inside, search for /userdata (filesystem definition).
    On my phone it looks like:
    Code:
    /dev/block/bootdevice/by-name/userdata /data f2fs noatime,nosuid,nodev,discard,inlinecrypt,reserve_root=32768,resgid=1065,fsync_mode=nobarrier latemount,wait,check,formattable,fileencryption=aes-256-xts:aes-256-cts:v2+emmc_optimized+wrappedkey_v0,keydirectory=/metadata/vold/metadata_encryption,metadata_encryption=aes-256-xts:wrappedkey_v0,quota,reservedsize=128M,sysfs_path=/sys/devices/platform/soc/1d84000.ufshc,checkpoint=fs

    Actually, inside that line look for the fileencryption definition - in my case:
    Code:
    fileencryption=aes-256-xts:aes-256-cts:v2+emmc_optimized+wrappedkey_v0

    Flag :v2 means that I have FBE v2. It's also emmc_optimized with hardware-wrapped keys (details and description can be found in the Google's FBE documentation as linked above)
    7
    By the way, there is another thread with detailed OP instructions for the new Magisk v24/v25:

    And a thread that was opened for hiding root with the new Magisk:

    Those new threads were opened because of this old and cluttered thread.
    Unfortunately, people still report/ask here (and in parallel complain that thread is too big to read☹️)
    6
    Its trivial to sniff or even MITM a desktop, or even just run WinPE and reset admin password and use the users own saved passwords in their browser, heck even export their passwords....

    In any event the biggest risk vector is social engineering

    Chasing root phone users only gives them a "feelgood", it does nothing to stop genuine misuse and fraud, at all.....

    I dont see Google or a bank sending out a representative every time someone makes a transaction to see if theyre genuine....trying to control the device is attacking the wrong end of the transaction and is ultimately pointless
    They're not chasing root users. They just want a guarantee that the device is secure, and they have good reason to. Rooting by nature compromises device security.

    I'm not saying your opinion is invalid; in this context however, it is irrelevant, because regardless of how you may feel about the situation, it's not going to change.
    6
    I had root, a few apps still recognize it, updating to the newest magisk manager shows n/a for magisk installed. Do I just grab my boot IMG out of my ROM and do it sgain? Will I keep all my data and info...?
    Did you have Magisk App hidden when updated?... Classic trap... Supposed to work, but bit like a pot-luck dinner...

    You're probably suffering from DACFRAS*, which is NOT fatal but all the clinics are full...

    Check in device settings, Apps for your old hidden App... Default name is 'settings', or its what you named it... Uninstall it, and presto!

    *Dual Apps Competing For Root Access Syndrome...

    😜 PW
  • 1085
    This is the place for general support and discussion regarding "Public Releases", which includes both stable and beta releases.
    All information, including troubleshoot guides and notes, are in the Announcement Thread
    156
    Hello, I haven't given much support on XDA lately. It can be resulted from
    • University started and I have limited free time. In fact, I mostly develop during midnight
    • I live in Taiwan, which has large time zone differences between my European/American contributors/testers, which usually forces me to stay up late at night to discuss/test stuffs.
    • The new version is about to come, I don't want to spend effort on supporting old releases
    The planned update is delayed again and again, to some point I think I'll shed some light about what has been happening lately, also along with some announcements.

    New Forum!
    As you might have already discovered, Magisk got its own subforum on XDA! Many thanks to all the support you gave me, and much more information/features/support is about to come!
    **For developers supporting all the devices that are not using standard Android boot format, feel free to create threads in this section (actually, PLEASE do so) for your favorite devices after v7 is out. As I currently know, Asus devices require signing the boot image before flashing, and is model dependant; Sony devices seems to use ELF kernel that is unpatchable, or some has two ramdisks (inner + outer), both requires different workarounds; LG bootloader locked devices has to manually "BUMP" the boot image after flashing Magisk..... and there may be lots of other crazy boot image formats that haven't come up to my attention yet.
    It is impossible for me to support all these non-standard boot images, and I hope the community can collaborate to make Magisk running across all the devices. Overall, community collaboration is what XDA about :D

    The Pixel Phone
    Some of you might already know this news, that the next Pixel Phone right around the corner seems like it does not have ramdisk in boot image, which pretty much wrecked Magisk in all ways. However, it pretty much doomed root itself too. Kernel modifications is inevitable IMO, so I'll try to migrate my scripts to C programs that could possibly be included into the kernel itself. Note that I'm not familiar with linux kernel, I'm not even sure if my idea and concept is correct or not. But once the device is available, I think developers will find a way to bypass all the difficulties, and I'll do my best to learn things ;)

    Current Progress
    In the past month, I've spent quite some time learning SELinux, so that I can avoid using SuperSU's sepolicy patches. Thanks to the helps and tips from @phhusson and @Chainfire, I finally have a much clearer understanding of how SELinux works. The Magisk core parts (the scripts, boot image patches, new features, more supports) are actually done some time ago. What is causing all the delays is the Magisk Manager.
    To be completely honest, although I can code in Java without much issues, Magisk Manager is actually my first Android application, I had to reach out for assistance, and fortunately awesome developers like @DVDandroid and @digitalhigh contributed a lot, which makes the current Manager awesome.
    After the repo system and module management is mostly done, I was about to do some adjustments and release, but what we really done is decided to add another feature: auto-unroot with per-app settings. I decided to wait for it to be finished, and then do my adjustments. Due to reasons that'll be mentioned later, this feature will likely not be available for the next release (should come in future updates)

    Safety Net Disaster
    Those who are using Magisk for Safety Net bypass purposes must have known that Google recently updated the detection method of my Systemless Xposed. I still have no idea what Safety Net is detecting, so currently I cannot fix it on my side (also because I'm busy working on the next update). However, suhide developed by @Chainfire is able to hide Xposed and worked fine.
    However, only my Systemless Xposed v86.2, which is based on SuperSU's su.d, is supported using that method. v86.2 and v86.5 (latest, Magisk based) have nearly identical binaries, and the only difference is the path where the binaries are stored.
    I'm still not sure what's the real issue for it not being supported, I just hope it is not done intentionally.

    Conclusion
    Due to the fact that my Safety Net bypass is not 100% perfect now, I do not want to spend any more time waiting for auto-unroot to be polished. What I'm doing now is finishing up all the things I'd like to change in Magisk Manager (it has been a while since I last contributed to Manager, my fellow developers are doing all the heavy job), which might take a little more time, after that, packed with tons of information to be announced in Magisk Section, I'll release the long awaited update.

    Hope this lengthy post gives you the idea of the whole situation, and again thanks for all your support!!
    121
    Ah, some Chainfire bashing, I hope it is not too late for me to exercise additional villainy.

    First, let me make clear I have nothing against @topjohnwu, nor against Magisk. Magisk is an interesting project and it certainly displays @topjohnwu ingenuity and persistence. I don't doubt we will see more interesting things from his hands.

    -------------------------

    What has happened here is not all that dark and complicated, from either end. I returned from holidays, and someone pointed me at Magisk. My first thought: interesting!

    Among other things, the thread lists some issues with SuperSU, which in combination with the phrase The developer also requests users to not bug Chainfire with compatibility requests for SuperSU with Magisk from the portal article, raised my left eyebrow by nigh half an inch. The popular systemless xposed mod is apparently now based on it, and apparently it now no longer works with SuperSU, and apparently I'm not supposed to fix that, nor any of the other found issues. I found that a bit weird. So yes, I have told @topjohnwu that I was a bit surprised he was posting about issues with SuperSU without notifying me about them (I can't fix or help fix issues I'm not aware of, after all).

    He's also spreading a modified version of the SuperSU package, which is not all that uncommon, nor necessarily a problem. I have not looked into what he modified, I only ran a few quick tests on one of my devices, and found some commonly used commands run as root to be broken. I have informed him of this as well.

    It appears the tool of choice for Magisk is phh's Superuser, because of some of the mentioned issues with SuperSU. That's fine by itself, but fixing issues in that superuser by incorporating SuperSU's binaries into it is a somewhat questionable practise. After all, SuperSU is a commercial closed-source package that helps pay for my dinner, and superuser is a direct competitor. I have informed him that I was surprised he did this without asking for permission. I have expressed similar surprise on him spreading a modified version of LiveBoot (which helps pay for a snack now and then).
    @topjohnwu has also stated that Magisk's scripts are largely influenced by mine (I have not checked). Scripts based on mine are used all over the place on XDA, some people have crafted amazing things based on them, I have never made an issue of this (otherwise I would have just made them binaries). But yes, I have also stated to him that I don't think it's very nice to base something on one program, and then using that to (almost exclusively) push something directly competing with that program.

    tl;dr Towards @topjohnwu, I have:
    - expressed surprise he has issues getting Magisk to work with SuperSU, and has chosen not to inform me about those
    - expressed surprise he is using SuperSU binaries in a competing superuser without permission
    - expressed surprise he is posting a modified LiveBoot without permission
    - informed him of issues with the modified SuperSU he has posted
    - let him know I thought it wasn't very nice to be applying my scripts to benefit seemingly exclusively that same competing superuser

    To be crystal clear:
    - I have not asked for an apology
    - I have not asked for Magisk to be abandoned, neither the root hiding nor systemless module parts, and certainly not systemless xposed
    - I have not made an issue of any of this anywhere, until this post
    - I have not even specifically asked for anything to be taken down (though obviously in my opinion the other superuser package mixed with SuperSU's binaries, as well as the LiveBoot package, should go)
    - I have not reported this thread to XDA moderators for copyright violations or otherwise

    While my conversation with @topjohnwu may not win any awards for being friendly (though it may win some for brevity), I think all things considered my response has been rather mild. To be perfectly honest, until the apology post, I thought this was over with already. I think the apology post was triggered because I haven't replied to his last PM for a while - I was in the zone, it happens.

    To emphasize again, I have nothing against @topjohnwu, Magisk, or systemless xposed, and it is certainly not my goal to see any of them go. If it can be made to work together with SuperSU, great.

    I get it though: you think of something, you want to see if you can make it work, you finally get it to work, you publish it, it takes off - enthusiasm gets the better of you. Maybe in the rush some mistakes are made. That doesn't mean you have to just drop it and run. None of my stuff would make it past 0.1 if I stopped at the first big mistake :)

    Aside from said being in the zone coding, I usually regret actually responding to these sort of things the day after, which has made me hesitant to reply. Surprise me.
    76
    Thread temporarily closed so everyone sees this.

    The flood of "SafetyNet isn't working for me either!" posts are not helpful, at all. Please refrain from posting further, it will be looked into. Please do not forget that not passing SafetyNet is 100% NORMAL AND INTENDED when you have an unlocked booloader or running custom firmware. These are workarounds and they will be worked around in turn.

    The Flash
    Forum Moderator

    EDIT: Thread is reopened... I will be cleaning any SafetyNet posts for a while to keep the thread clean for real issues.
    75
    Hello everyone!

    I am aware that Google has updated Safety Net that makes Magisk itself a no go for Android Pay. In fact, I witnessed the change live while I am developing the new magiskhide, which should hide all Magisk modules and Magisk installed root.

    Google is serious about Safety Net now, clearly hunting down all possibility to run Xposed with Safety Net passed. I spend quite some time examining the new security measures last midnight, and fortunately it seems that it is possible to run Magisk and root along with Safety Net if no Xposed is running. I'm glad I removed the old root toggle at the right time lol, that is no longer feasible with the latest detection.

    So stay tuned for the next update, it will come with bug fixes, along with the new magiskhide to bypass that Safety Net.

    Google, how will a few systemless mods do any harm :p:p