Magisk General Support / Discussion

Search This thread

Homeboy76

Senior Member
Aug 24, 2012
3,281
1,809
Google Pixel XL
True, but for that one must be somewhat familiar with GitHub, while newbies usually are not, and then they ask how this/how that/where is what, what to click, etc

Alll downloads (Stable, Beta, Canary, Debug) are easily, on TWO CLICKS, directly accessible from the Magisk app - see post #52425
True, but the XDA Members wanted to know what version of Magisk Canary he was downloading.
The link I provided gave the version information.
 
Last edited:

huskydg

Senior Member
Feb 17, 2021
206
208
If shamiko only can hide zygisk for momo, but really can't for the banking apps such as livin by madiri, instapay egypt, itsme,... then I don't know what is the "core value" mean of using shamiko to hide zygisk?
 
Last edited:
  • Like
Reactions: zgfg and asripath

73sydney

Senior Member
Ohhh really?? Yes that's what I did I formatted my data using TWRP but I didn't noticed there is an option to check do not encrypt

About every device ive used requires a zip file flash to disable dm verity. forced encryption.....

For my S20+, after the bootloaderin unlocked, and TWRP is flashed via ODIN, i have to format /data, and then flash an encryption disabler zip

I would check your devices forums for similar to see if similar is needed
 

vMAC

Senior Member
Oct 21, 2007
339
34
OMG

In Magisk app you have DIRECT LINK to TJW GitHub

On that main GitHub page, scroll to DOWNLOAD and click on Magisk Canary (to download the latest Caneay) - how else

That's the page that looks like any Web page and one does not need to know anything about Github

True that the name of downloaded app does not Canary and version number - if unhappy with, complain to developer
zgfg

I don't know if we are having a language barrier or if we are going round and round because we are just saying the same things. Let me try to make it clearer.

  • I have downloaded the latest canary from TWJ Github
  • Intune does not allow me to install any unknown sources to my personal profile, nor my work profile
  • I cannot use the magisk manager app to update since it is from "unknown source"
  • I have attempted to go around this by installing the latest canary from TWJ Github using "adb install"
  • After doing this it STILL states that I am not on the latest Magisk Manager
Is this normal is the question? Is there any other way to update with the limitations that I state above without removing Intune doing the upgrade and then reinstalling Intune?

Last question is if I uninstall Magisk, then use the "adb install" to reinstall if that works, would I be able to hide Magisk Manager again or would that be blocked due to "unknown sources?"
 

m0han

Senior Member
Apr 30, 2012
5,004
2,050
About every device ive used requires a zip file flash to disable dm verity. forced encryption.....
some devices have modded twrp available that has an option to 'disable forced encryption' and many other 'features'. i think it's the equivalent of using the relevant zip/script(s).

btw, it has been reported by several users that that twrp for poco x3 (surya/karna) can decrypt /data on A12.1.
 

Attachments

  • Screenshot_2022-06-29-08-30-31.png
    Screenshot_2022-06-29-08-30-31.png
    152.8 KB · Views: 33
Last edited:

73sydney

Senior Member
some devices have modded twrp available that has an option to 'disable forced encryption' and many other 'features'. i think it's the equivalent of using the relevant zip/script(s).

btw, it has been reported by several users that that twrp for poco x3 (surya/karna) can decrypt /data on A12.1.

Cheers, yes, i was speaking generally because i wasnt aware of the OP's device, but yes you can get custom TWRP for some devices that includes, ive never personally seen or used one on any of the flagship devices ive used....Pixels/Samsung over the years, its always been a zip :)

Also recently with the S20'+, someone had to update the zip we used after yours truly (im so lucky) became the 1st person to go around in circles with the previous zip after Samsung changed the paths used internally, fun times :)

Can i get a #ponkles ?
.... Ive been watching too much Jimmys World on youtube...#clearprop
 
Last edited:
  • Like
Reactions: m0han

zgfg

Senior Member
Oct 10, 2016
7,617
5,020
I don't know if we are having a language barrier or if we are going round and round because we are just saying the same things. Let me try to make it clearer.

  • I have downloaded the latest canary from TWJ Github
  • Intune does not allow me to install any unknown sources to my personal profile, nor my work profile
  • I cannot use the magisk manager app to update since it is from "unknown source"
  • I have attempted to go around this by installing the latest canary from TWJ Github using "adb install"
  • After doing this it STILL states that I am not on the latest Magisk Manager
Is this normal is the question? Is there any other way to update with the limitations that I state above without removing Intune doing the upgrade and then reinstalling Intune?

Last question is if I uninstall Magisk, then use the "adb install" to reinstall if that works, would I be able to hide Magisk Manager again or would that be blocked due to "unknown sources?"
I asked you about downloading to make sure that you are really downloading the Canary 25101.
My APK is 10.71 MB and see my screenshot with hashes to double check do you have the same/correct 25101 apk

Second, I asked does your adb installation ends with an error or not?
(If it ends with an error, maybe bcs of Intune, then obviously you would not have the new 25101 installed after your 'update')

Third, I asked you to unhide or even delete your old 25001 APK before installing the 25101apk

All those questions were to help to see why after your adb installation of the new 25101 you still open 25001 aok

If you don't understand these questions or you don't want to do so (deleting your old 25001 APK WILL NOT uninstall Magisk itself, your Magisk modules, end so on) then sorry, I can not Help you better

You asked me "is that normal". How do I know is it 'normal' - it could be that Intune does not allow you even to install via adb - that's wh I asked you does adb report an error

Many users have 'problems' installing the new Magisk app (normal way, nobody installs by adb - I didn't see any post from another user with Intune doing that way) IF THEY DIDN'T NOT unhide or uninstall the previous hidden version of Magisk app.
We have had tens and tens of such cases here (without Intune, maybe you didn't follow and read discussions here, it's not specific to 25101, it's repeating through months:
Without unhiding or deleting, after updating they have both apps, old hidden and new.
Maybe you also have both, but you don't 'see' the new 25101 APK and you are opening that old hidden 25001

That's why I asked you to unhide (or even delete) your old 25001 APK.

But I cannot answer you would you be able to hide again. How do I know for sure if I don't have Intune and cannot test myself?!?!?!?!?!

Maybe somebody else with Intune can tell you about hiding the Magisk app with Intune.
Btw, if you were able to hide 25001, then you should be also able to hide 25101 as well

---

EDIT:

To avoid the case that after your adb installation of AP 25101 you still open the old/hidden/repackaged 25001, test as on my second screenshot (I used terminal app but you can do through adb with adb shell)

Ie, your old hidden 25001 is repackaged and has a different package name (random)

Test do you have installed the package: com.tophognwu.magisk

If it shows that package is installed, it means that you have in parallel the old hidden (random pkg name) 25001 and New not-hidden 25101 (com.topjohnwu.nagisk) - common problem for users who do not unhide before updating the Magisk APK
 

Attachments

  • IMG_20220629_070454.jpg
    IMG_20220629_070454.jpg
    351.3 KB · Views: 28
  • IMG_20220629_080705.jpg
    IMG_20220629_080705.jpg
    55.7 KB · Views: 28
Last edited:

m0han

Senior Member
Apr 30, 2012
5,004
2,050
...If you would have hidden 25001 and you updated to 25101 APK - normal way and successfully...Your updated 25101 WOULD NOT BE hidden after the update - you would again have to hide 25101 if you want to have it hidden...
drawing inspiration from @casouzaj's assertion that he has always updated magisk app, including the latest one, keeping it renamed/hidden....and just the updated renamed/hidden app shows up in the apps drawer, i did a dirty update (see screenshots there). i don't recall having hidden the magisk app after that; it showed up as renamed app, just the way i named it. ymmv, though. and, i hope i don't run into trouble in the future. :D ;)
 

zgfg

Senior Member
Oct 10, 2016
7,617
5,020
drawing inspiration from @casouzaj's assertion that he has always updated magisk app, including the latest one, keeping it renamed/hidden....and just the updated renamed/hidden app shows up in the apps drawer, i did a dirty update (see screenshots there). i don't recall having hidden the magisk app after that; it showed up as renamed app, just the way i named it. ymmv, though. and, i hope i don't run into trouble in the future. :D ;)
See and test as in EDIT part of my post #25459, to make sure that you don't have in parallel both, hidden old and not-hidden new
 

zgfg

Senior Member
Oct 10, 2016
7,617
5,020
you probably meant #52459, right? i run delta now; don't have any other magisk packages on my device atm.
I don't know about Delta and its package name and updating while hidden.
Still my questions/suggestions for vMAC remain (he uses Canary, not the special Delta)

Also, if you (or somebody else) have Intune, welcome to help him
 

J.Michael

Recognized Contributor
Jan 20, 2018
1,256
1,195
Samsung Galaxy Tab A series
So currently I have Magisk installed on my phone. I also have a Work Profile with Intune setup. The problem is that it restricts my ability to install apps from "unknown sources." So with the last update to Magisk Canary I keep getting the alert that I need to update. I currently have Magisk hidden also, so it doesn't come up with the Magisk name.

I connected my computer to my phone and did a "adb install magisk.apk" for the canary app. The problem is that after doing this, while it states that it was successful, the app still says that I need to upgrade the app.

Can someone help me? What am I doing wrong?

I hope the answer isn't that I need to uninstall Intune every time I want to upgrade Magisk.
Can you deactivate the Intune app as a Device Administrator?
Will that be less trouble than uninstalling Intune?
 

J.Michael

Recognized Contributor
Jan 20, 2018
1,256
1,195
Samsung Galaxy Tab A series
So currently I have Magisk installed on my phone. I also have a Work Profile with Intune setup. The problem is that it restricts my ability to install apps from "unknown sources." So with the last update to Magisk Canary I keep getting the alert that I need to update. I currently have Magisk hidden also, so it doesn't come up with the Magisk name.

I connected my computer to my phone and did a "adb install magisk.apk" for the canary app. The problem is that after doing this, while it states that it was successful, the app still says that I need to upgrade the app.

Can someone help me? What am I doing wrong?

I hope the answer isn't that I need to uninstall Intune every time I want to upgrade Magisk.
Was your original Magisk installation a Canary version?
There have been posts about a misalignment of the "update channel" settings resulting in endless nagging about a need to update, but no update being possible.
 

Bouls

Member
Jun 22, 2022
9
2
About every device ive used requires a zip file flash to disable dm verity. forced encryption.....

For my S20+, after the bootloaderin unlocked, and TWRP is flashed via ODIN, i have to format /data, and then flash an encryption disabler zip

I would check your devices forums for similar to see if similar is needed
Yes this is what I was doing in general, but now for the latest magisk version, I cannot flash disable dmverity forceencrypt.zip and then flash after it magisk.zip. I get an error "Unsupported boot image extra"
 
  • Like
Reactions: 73sydney

n.p.

Senior Member
Jul 25, 2013
100
14
HELP! This release (25.1) has become an absolute disaster. Of my first device, I did direct install as recommended, but upon rebooting, I had no Magisk, just the app. After some struggles, I managed to patch a raw boot image and flash that.

On my second device (with 24.3 installed and working for months). I again tried direct install, and Magisk appear to install, as normal. Again, after I rebooted, I had no Magisk (the app simply says "Installed: N/A"). I tried patching the boot image (several boot images actually, older patched ones, ones backed up from TWRP, and one extracted from the latest firmware - every one of them produced the same output file, meaning that all of the magisk_patched-25100_xxx.img had the same sha256 value). Every attempt keeps producing "Installed: N/A" after flashing the patched boot image.

I would like (for now) to go back to the old version (24.3) but attempting to install it produces "Please connect to the internet! Upgrading to full Magisk is required." If I connect to the internet, I get version 25.1 again (app only, and still no Magisk).

Any ideas? Thank you in advance for your help.
 

Top Liked Posts

  • 5
    Some Insight on the New Cat and Mouse Game...

    Since many are asking:
    Is there a fix for this? ... Can't pass MEETS_STRONG_INTEGRITY.
    I'm posting this WOT. 🤪

    I predict some will like it, some won't... You've been warned! 😜

    FWIW, Play Integrity MEETS_STRONG_INTEGRITY is akin to SafetyNet Evaluation type HARDWARE with CTS Profile match...

    Banks could have used this before (w/ S/N API) but haven't as it would have excluded too many users/devices/customers... Nothing has actually changed with new PI API; MEETS_STRONG_INTEGRITY will exclude the same group, so it's doubtful they'll rush to require this verdict...

    Basically, the means to enforce Hardware key-backed Attestation has already been here w/ either of these attestations, but banks don't want to exclude all those w/Android 7 and below, or many w/ broken keymaster 3+ implementations in Android 8+ devices (CTS Profile match with HARDWARE Evaluation type / MEETS_STRONG_INTEGRITY won't pass with locked bootloader), eg most OnePlus devices (nb. Keymaster may have been fixed in OnePlus devices launched with Android 12+)...

    I'm guessing the banks may well leverage this at some point if the time arrives when they feel there is a sufficient critical mass of devices w/ working hardware-backed keymaster (ie w/ hardware keystore, A8+) to trade against the number of modded (bootloader unlocked) devices in use especially if they deem Google slow to close the fallback-to-basic-attestation loophole that has allowed modders to bypass hardware based attestation to CTS Profile match enforcement (by triggering fallback to BASIC Evaluation type as well as bypassing enforcement) and also to allow its counterpart, MEETS_DEVICE_INTEGRITY verdict. (Nb. This verdict should not properly be obtained on modded devices, and it requires the same attestations as S/N as well as the same tricks to trigger fallback to BASIC attestation and bypass enforcement) The incentive to use this foolproof means is also certainly being weighed constantly against the cost / need to use their own custom means of sophisticated 'root' detection...

    Google also, as other authorities have commented, appears to be waiting for some 'acceptable' percentile / critical mass of such devices in use to be reached also, before they swing the 'big hammer' that is Hardware-backed Key Attestation enforcement and that will definitely spell the endgame for modders' use of bank apps, and possibly for OnePlus users and others whose devices have broken keymaster*

    *Nb. There are exceptions, eg Asus ROG Phone 3, where broken keymaster actually results in PI MEETS_STRONG_INTEGRITY and S/N CTS Profile match with Evaluation type HARDWARE regardless of bootloader status instead of the converse...

    It seems likely to me that OnePlus and other devices with broken keymaster can be spared if Google do prevent on-device triggering of fallbacks to basic attestation use simply by using device info contained in the cryptographic attestation sent to Google servers instead of userspace model props etc now used, to bypass enforcement at the server end. If they do this it would be a concession as modded OnePlus etc may then still be able to pass CTS Profile match / DEVICE_INTEGRITY while other modern modded devices won't...

    This would, however, be a way to swing the hammer a bit sooner, and either way, as can be seen from the above, they may be forced to do this once banks do indicate a willingness to enforce
    MEETS_STRONG_INTEGRITY in order to stop a landslide that would prevent all stock locked Android 7 and lower devices using bank apps etc... Or maybe they'll just let the landslide go and force bank app users to upgrade devices...

    Hopefully this gives some insight regarding what pressures may finally force Google to properly deploy (ie. strictly enforce) Hardware-based Key Attestation on devices that support it...

    Personally, I think Google has exercised great restraint, possibly out of some regard for the modding community since I can't see any other compelling reason not to have properly enforced CTS Profile match with HARDWARE Evaluation type where supported or Hardware attested MEETS_DEVICE_INTEGRITY sooner, unless the matter of ensuring that the API properly sees hardware identifiers (ie. these cannot be spoofed, which I believe would again require cryptographic server-side attestation that the device doesn't indicate the presence of hardware keystore) for bypassing hardware attestation enforcement in devices launched with Android 7 and earlier is proving difficult (but I'm fairly sure this mechanism will be a simple matter for Google and probably already in place)... 😛

    It may well be that Google is benevolently holding off but is using/will use MEETS_STRONG_INTEGRITY uptake data as tha natural indicator of the banks propensity for reliable HKA... My bet is that if Google doesn't have immediate plans to move to srtict HKA enforcement for MEETS_DEVICE_INTEGRITY, then they will when the banks themselves move to use the even stricter MEETS_STRONG_INTEGRITY verdict...


    👀 🤠
    3
    I had root, a few apps still recognize it, updating to the newest magisk manager shows n/a for magisk installed. Do I just grab my boot IMG out of my ROM and do it sgain? Will I keep all my data and info...?
    Did you have Magisk App hidden when updated?... Classic trap... Supposed to work, but bit like a pot-luck dinner...

    You're probably suffering from DACFRAS*, which is NOT fatal but all the clinics are full...

    Check in device settings, Apps for your old hidden App... Default name is 'settings', or its what you named it... Uninstall it, and presto!

    *Dual Apps Competing For Root Access Syndrome...

    😜 PW
    2
    ... updating to the newest magisk manager shows n/a for magisk installed....
    Experienced this issue on a fork of Magisk too. https://forum.xda-developers.com/t/...third-party-magisk-fork.4460555/post-87255925
    Did you have Magisk App hidden when updated?... Classic trap...
    2
    It's a general rule: take chances (w/ awareness of issue/remedy) or take Restore the Magisk app before updating App... My success estimate is reducing... 50/100 --> 40/100 --> 30/100 (?).

    It's all TJW/vv2060 code, so irrespective of fork... PW
    2
    Honestly we are almost at the point where we should move these discussions into a standalone thread specifically for Play Integrity.
  • 7
    By the way, there is another thread with detailed OP instructions for the new Magisk v24/v25:

    And a thread that was opened for hiding root with the new Magisk:

    Those new threads were opened because of this old and cluttered thread.
    Unfortunately, people still report/ask here (and in parallel complain that thread is too big to read☹️)
    6
    Its trivial to sniff or even MITM a desktop, or even just run WinPE and reset admin password and use the users own saved passwords in their browser, heck even export their passwords....

    In any event the biggest risk vector is social engineering

    Chasing root phone users only gives them a "feelgood", it does nothing to stop genuine misuse and fraud, at all.....

    I dont see Google or a bank sending out a representative every time someone makes a transaction to see if theyre genuine....trying to control the device is attacking the wrong end of the transaction and is ultimately pointless
    They're not chasing root users. They just want a guarantee that the device is secure, and they have good reason to. Rooting by nature compromises device security.

    I'm not saying your opinion is invalid; in this context however, it is irrelevant, because regardless of how you may feel about the situation, it's not going to change.
    5
    @pndwal You can build Magisk app with custom name and label as you want
    MagiskHide is still effective to hide root from banking apps. It's not dead if you don't care about safetynet stuff.


    Shamiko is taking off your panties on the basic of MagiskHide. So MagiskHide is still better.
    You believe Shamiko too much, It can't really hide zygisk, only fix the zygisk detection of Momo. However, I can't blame it because that was the nature of zygisk and it will never be fixed.
    Still not sure what you're trying to tell me...

    I think we agree on most of this stuff (except your apparent impression that Shamiko Devs have some sort of sexual agenda, or that it's users are somehow prone to 'self abuse'... I won't use the other term either...).

    If you think I have misrepresented any facts regarding Magisk, Shamiko or other, please say it plainly... I think what I provided for the sake of clarity was accurate... 🙁 PW
    5
    Latest Official TJW public Stable (release) Magisk build:

    Magisk

    2022.7.20 Magisk v25.2​

    Maintenance release fixing various issues.
    • [MagiskInit] Fix a potential issue when stub cpio is used
    • [MagiskInit] Fix reboot to recovery when stub cpio is used
    • [MagiskInit] Fix sepolicy.rules symlink for rootfs devices
    • [General] Better data encryption detection
    • [General] Move the whole logging infrastructure into Rust

    Full Changelog: here

    https://topjohnwu.github.io/Magisk/releases/25200.html

    🎉🎊 PW
    5
    did all that, flashed uninstall.zip, uninstalled the Magisk app, flashed the original boot.img from LineageOS payload.bin...

    End result: root apps don't have root, "secure apps" (banking, etc.) complain about the phone being rooted.

    Example: CF.lumen stating "Could not aquire root access". But then the banking app is claiming the phone isn't secure and closes. Same for a State ID certification app I use.

    This is a disaster.

    With Magisk uninstalled and original boot you have no more Magisk

    But you don't pass SafetyNet (bcs your Bootloader is still unlocked and you still run custom ROM and you are no more hiding it by eg using Magisk module USNF), hence banking apps do complain about 'root' (they probably don't say "root" or use the meaning vaguely)

    If you want to get rid of Magisk and with that you want to pass SN and banking apps, you would need to go back to stock and relock the bootloader
    For the record.

    A few months ago, testing something.. :unsure:

    I was surprised to see the official Lineage build(s) were not user builds.
    Since they are not user builds, they can/will be considered compromised and not properly locked down.
    Some apps will report root or a custom rom.​

    It was pointed out to me (by a cm/los dev I highly respect) that the official Lineage (cyanogenmod) builds have always been debug builds.
    • Switching to user builds would be extremely difficult and way too much time and work for the maintainers.
      Reminder. Most are volunteers that freely give us their time and knowledge.​
    • Some devices might not be able to be supported as a user build.
    • Would limit what you as the user can do with the device.

    Cheers. :cowboy:
  • 1084
    This is the place for general support and discussion regarding "Public Releases", which includes both stable and beta releases.
    All information, including troubleshoot guides and notes, are in the Announcement Thread
    156
    Hello, I haven't given much support on XDA lately. It can be resulted from
    • University started and I have limited free time. In fact, I mostly develop during midnight
    • I live in Taiwan, which has large time zone differences between my European/American contributors/testers, which usually forces me to stay up late at night to discuss/test stuffs.
    • The new version is about to come, I don't want to spend effort on supporting old releases
    The planned update is delayed again and again, to some point I think I'll shed some light about what has been happening lately, also along with some announcements.

    New Forum!
    As you might have already discovered, Magisk got its own subforum on XDA! Many thanks to all the support you gave me, and much more information/features/support is about to come!
    **For developers supporting all the devices that are not using standard Android boot format, feel free to create threads in this section (actually, PLEASE do so) for your favorite devices after v7 is out. As I currently know, Asus devices require signing the boot image before flashing, and is model dependant; Sony devices seems to use ELF kernel that is unpatchable, or some has two ramdisks (inner + outer), both requires different workarounds; LG bootloader locked devices has to manually "BUMP" the boot image after flashing Magisk..... and there may be lots of other crazy boot image formats that haven't come up to my attention yet.
    It is impossible for me to support all these non-standard boot images, and I hope the community can collaborate to make Magisk running across all the devices. Overall, community collaboration is what XDA about :D

    The Pixel Phone
    Some of you might already know this news, that the next Pixel Phone right around the corner seems like it does not have ramdisk in boot image, which pretty much wrecked Magisk in all ways. However, it pretty much doomed root itself too. Kernel modifications is inevitable IMO, so I'll try to migrate my scripts to C programs that could possibly be included into the kernel itself. Note that I'm not familiar with linux kernel, I'm not even sure if my idea and concept is correct or not. But once the device is available, I think developers will find a way to bypass all the difficulties, and I'll do my best to learn things ;)

    Current Progress
    In the past month, I've spent quite some time learning SELinux, so that I can avoid using SuperSU's sepolicy patches. Thanks to the helps and tips from @phhusson and @Chainfire, I finally have a much clearer understanding of how SELinux works. The Magisk core parts (the scripts, boot image patches, new features, more supports) are actually done some time ago. What is causing all the delays is the Magisk Manager.
    To be completely honest, although I can code in Java without much issues, Magisk Manager is actually my first Android application, I had to reach out for assistance, and fortunately awesome developers like @DVDandroid and @digitalhigh contributed a lot, which makes the current Manager awesome.
    After the repo system and module management is mostly done, I was about to do some adjustments and release, but what we really done is decided to add another feature: auto-unroot with per-app settings. I decided to wait for it to be finished, and then do my adjustments. Due to reasons that'll be mentioned later, this feature will likely not be available for the next release (should come in future updates)

    Safety Net Disaster
    Those who are using Magisk for Safety Net bypass purposes must have known that Google recently updated the detection method of my Systemless Xposed. I still have no idea what Safety Net is detecting, so currently I cannot fix it on my side (also because I'm busy working on the next update). However, suhide developed by @Chainfire is able to hide Xposed and worked fine.
    However, only my Systemless Xposed v86.2, which is based on SuperSU's su.d, is supported using that method. v86.2 and v86.5 (latest, Magisk based) have nearly identical binaries, and the only difference is the path where the binaries are stored.
    I'm still not sure what's the real issue for it not being supported, I just hope it is not done intentionally.

    Conclusion
    Due to the fact that my Safety Net bypass is not 100% perfect now, I do not want to spend any more time waiting for auto-unroot to be polished. What I'm doing now is finishing up all the things I'd like to change in Magisk Manager (it has been a while since I last contributed to Manager, my fellow developers are doing all the heavy job), which might take a little more time, after that, packed with tons of information to be announced in Magisk Section, I'll release the long awaited update.

    Hope this lengthy post gives you the idea of the whole situation, and again thanks for all your support!!
    121
    Ah, some Chainfire bashing, I hope it is not too late for me to exercise additional villainy.

    First, let me make clear I have nothing against @topjohnwu, nor against Magisk. Magisk is an interesting project and it certainly displays @topjohnwu ingenuity and persistence. I don't doubt we will see more interesting things from his hands.

    -------------------------

    What has happened here is not all that dark and complicated, from either end. I returned from holidays, and someone pointed me at Magisk. My first thought: interesting!

    Among other things, the thread lists some issues with SuperSU, which in combination with the phrase The developer also requests users to not bug Chainfire with compatibility requests for SuperSU with Magisk from the portal article, raised my left eyebrow by nigh half an inch. The popular systemless xposed mod is apparently now based on it, and apparently it now no longer works with SuperSU, and apparently I'm not supposed to fix that, nor any of the other found issues. I found that a bit weird. So yes, I have told @topjohnwu that I was a bit surprised he was posting about issues with SuperSU without notifying me about them (I can't fix or help fix issues I'm not aware of, after all).

    He's also spreading a modified version of the SuperSU package, which is not all that uncommon, nor necessarily a problem. I have not looked into what he modified, I only ran a few quick tests on one of my devices, and found some commonly used commands run as root to be broken. I have informed him of this as well.

    It appears the tool of choice for Magisk is phh's Superuser, because of some of the mentioned issues with SuperSU. That's fine by itself, but fixing issues in that superuser by incorporating SuperSU's binaries into it is a somewhat questionable practise. After all, SuperSU is a commercial closed-source package that helps pay for my dinner, and superuser is a direct competitor. I have informed him that I was surprised he did this without asking for permission. I have expressed similar surprise on him spreading a modified version of LiveBoot (which helps pay for a snack now and then).
    @topjohnwu has also stated that Magisk's scripts are largely influenced by mine (I have not checked). Scripts based on mine are used all over the place on XDA, some people have crafted amazing things based on them, I have never made an issue of this (otherwise I would have just made them binaries). But yes, I have also stated to him that I don't think it's very nice to base something on one program, and then using that to (almost exclusively) push something directly competing with that program.

    tl;dr Towards @topjohnwu, I have:
    - expressed surprise he has issues getting Magisk to work with SuperSU, and has chosen not to inform me about those
    - expressed surprise he is using SuperSU binaries in a competing superuser without permission
    - expressed surprise he is posting a modified LiveBoot without permission
    - informed him of issues with the modified SuperSU he has posted
    - let him know I thought it wasn't very nice to be applying my scripts to benefit seemingly exclusively that same competing superuser

    To be crystal clear:
    - I have not asked for an apology
    - I have not asked for Magisk to be abandoned, neither the root hiding nor systemless module parts, and certainly not systemless xposed
    - I have not made an issue of any of this anywhere, until this post
    - I have not even specifically asked for anything to be taken down (though obviously in my opinion the other superuser package mixed with SuperSU's binaries, as well as the LiveBoot package, should go)
    - I have not reported this thread to XDA moderators for copyright violations or otherwise

    While my conversation with @topjohnwu may not win any awards for being friendly (though it may win some for brevity), I think all things considered my response has been rather mild. To be perfectly honest, until the apology post, I thought this was over with already. I think the apology post was triggered because I haven't replied to his last PM for a while - I was in the zone, it happens.

    To emphasize again, I have nothing against @topjohnwu, Magisk, or systemless xposed, and it is certainly not my goal to see any of them go. If it can be made to work together with SuperSU, great.

    I get it though: you think of something, you want to see if you can make it work, you finally get it to work, you publish it, it takes off - enthusiasm gets the better of you. Maybe in the rush some mistakes are made. That doesn't mean you have to just drop it and run. None of my stuff would make it past 0.1 if I stopped at the first big mistake :)

    Aside from said being in the zone coding, I usually regret actually responding to these sort of things the day after, which has made me hesitant to reply. Surprise me.
    76
    Thread temporarily closed so everyone sees this.

    The flood of "SafetyNet isn't working for me either!" posts are not helpful, at all. Please refrain from posting further, it will be looked into. Please do not forget that not passing SafetyNet is 100% NORMAL AND INTENDED when you have an unlocked booloader or running custom firmware. These are workarounds and they will be worked around in turn.

    The Flash
    Forum Moderator

    EDIT: Thread is reopened... I will be cleaning any SafetyNet posts for a while to keep the thread clean for real issues.
    75
    Hello everyone!

    I am aware that Google has updated Safety Net that makes Magisk itself a no go for Android Pay. In fact, I witnessed the change live while I am developing the new magiskhide, which should hide all Magisk modules and Magisk installed root.

    Google is serious about Safety Net now, clearly hunting down all possibility to run Xposed with Safety Net passed. I spend quite some time examining the new security measures last midnight, and fortunately it seems that it is possible to run Magisk and root along with Safety Net if no Xposed is running. I'm glad I removed the old root toggle at the right time lol, that is no longer feasible with the latest detection.

    So stay tuned for the next update, it will come with bug fixes, along with the new magiskhide to bypass that Safety Net.

    Google, how will a few systemless mods do any harm :p:p