Magisk General Support / Discussion

Search This thread

shoey63

Recognized Contributor
. . . The following is how I usually try to do it.


1. Magisk > Uninstall > Restore Images
2. System Settings update (DO NOT REBOOT)
3. Magisk > Install > Install Into Inactive Slot (After OTA)

. . .
If you are on the latest version of Magisk (some previous versions had issues), and no other partitions are modified other than boot and you reboot from within Magisk manager after flashing to other slot, then that should work.
I take OTA updates on Pixel 6 that way.
 
If you are on the latest version of Magisk (some previous versions had issues), and no other partitions are modified other than boot and you reboot from within Magisk manager after flashing to other slot, then that should work.
I take OTA updates on Pixel 6 that way.
I last did it with 24.3 Magisk and it boot loop. Am I supposed to turn off the module I have? Systemless Hosts.
 

shoey63

Recognized Contributor
I last did it with 24.3 Magisk and it boot loop. Am I supposed to turn off the module I have? Systemless Hosts.
Not necessarily, but you DO need to update Magisk to the latest version as I mentioned.

Edit: Disabling modules before taking an OTA update and re-enabling later is a good idea. It eliminates them as the cause of boot loops.
 
Last edited:

martyfender

Senior Member
Mar 9, 2017
3,269
1,747
Indianapolis, IN
Good evening Martyfender, Thank you Google translator if there is better I take.
The problem may be with proper English grammar and punctuation. I am trying to help us better understand your posts so as to better help You.
Suggestion:
"Good evening martyfender. Thank you. I am using Google Translator, unless someone can suggest a better alternative."
 
Last edited:

dcarvil

Senior Member
Apr 20, 2016
596
337
Good evening Martyfender, Thank you Google translator if there is better I take.
I think your posts would be easier to understand if you included the original French below the English translator output. From the forum rules:

4. Use the English language.

We understand that with all the different nationalities, not everyone speaks English well, but please try. If you're really unable to post in English, use an online translator. You're free to include your original message in your own language, below the English translation. (This rule covers your posts, profile entries and signature). You could try :- https://translate.google.com/ or https://www.babelfish.com/ or use one of your choice.
 
  • Like
Reactions: Timmmmaaahh!

pndwal

Senior Member
I have a question about OTA incremental updates. I have a OnePlus 9 on OxygenOS 12 C.48. C.61 is now being pushed out. Oxygen Updater no longer offers the full updates and is telling me to use incremental. Everytime I updare with incremental I get a boot loop and have to factory reset to be able to boot again, of course losing all data. Is there some new way we are supposed to update with incremental? The following is how I usually try to do it.


1. Magisk > Uninstall > Restore Images
2. System Settings update (DO NOT REBOOT)
3. Magisk > Install > Install Into Inactive Slot (After OTA)


Am I missing something? I do not have any modules installed, except Systemless Hosts. I have read that I should disable modules. Should I just restore images and complete uninstall Magisk?
Please say if you are doing anything different, eg use custom kernel, change Verity flags (options) etc... Also, what is current Magisk version and update version...

Method looks fine. - ie. recently fixed method here:
https://github.com/topjohnwu/Magisk/blob/master/docs/ota.md#devices-with-ab-partitions

How are you rebooting after updates?... From Magisk App? ... This may be important:
  • After installation is done, press the reboot button in the Magisk app. Under-the-hood, the Magisk app forces your device to switch to the updated slot, bypassing any possible post-OTA verifications.

Nb. Direct Install to 25+ from earlier Magisk will fail where previous Magisk installation (ie. method of injection etc) is no longer supported. This does affect OnePlus in particular it seems, and is a result of change from patching fstab in 2SI devices
on 2SI devices, we patch fstab and execute the original `init` to mount partitions for us.
to patching original init
on 2SI devices, we patch the original `init` to redirect the 2nd stage init file to magiskinit and execute it to mount partitions for us.
https://github.com/topjohnwu/Magisk/commit/4f1a1879e572891bc005b489f82421303f602f72?diff=split

In these cases, a fresh install (patching previously unpatched image) will work, and Direct updates should work again going forward.

As I understand it, this shouldn't affect Install to Inactivate Slot method, but I guess it's possible Magisk may carry over some settings / flags from the previous slot installation, so this might help / apply...

I put information on this here:
https://forum.xda-developers.com/t/magisk-general-support-discussion.3432382/post-87064251

Hope it provides clues... PW
 
Please say if you are doing anything different, eg use custom kernel, change Verity flags (options) etc... Also, what is current Magisk version and update version...

Method looks fine. - ie. recently fixed method here:
https://github.com/topjohnwu/Magisk/blob/master/docs/ota.md#devices-with-ab-partitions

How are you rebooting after updates?... From Magisk App? ... This may be important:


Nb. Direct Install to 25+ from earlier Magisk will fail where previous Magisk installation (ie. method of injection etc) is no longer supported. This does affect OnePlus in particular it seems, and is a result of change from patching fstab in 2SI devices
on 2SI devices, we patch fstab and execute the original `init` to mount partitions for us.
to patching original init
on 2SI devices, we patch the original `init` to redirect the 2nd stage init file to magiskinit and execute it to mount partitions for us.
https://github.com/topjohnwu/Magisk/commit/4f1a1879e572891bc005b489f82421303f602f72?diff=split

In these cases, a fresh install (patching previously unpatched image) will work, and Direct updates should work again going forward.

As I understand it, this shouldn't affect Install to Inactivate Slot method, but I guess it's possible Magisk may carry over some settings / flags from the previous slot installation, so this might help / apply...

I put information on this here:
https://forum.xda-developers.com/t/magisk-general-support-discussion.3432382/post-87064251

Hope it provides clues... PW
I used to use a custom kernel, but haven't since going to the OnePlus 9. Otherwise I only install Magisk. I do not ever mount any partition as read/write except boot to install Magisk.

Yes, I forgot that step. I reboot from within Magisk.

I installed 25.1 App from within 24.3, and than direct install 25.1 into boot. I did not get any errors. So, should I restore image and direct install from 25.1 and reboot before OTA?

Last time I tried OTA and got a boot loop only 24.3 was out. I am asking questions before I go to update now, but I do have 25.1 installed. App and Boot. Since 25+ came with the fstab change, I doubt that was the issue before.
 

DiamondJohn

Recognized Contributor
Aug 31, 2013
6,295
6,226
Sydney
Good evening Martyfender, Thank you Google translator if there is better I take.
OT But, one of the methods I use when using computer assisted translations, is to translate it to the other language (say French as my primary to English as my secondary) and then put that 2nd Language translation back into the translator, and translate it back into my original language, and see what is lost or broken in the translation. Then adjust my primary language text until both ways result in the exact same text ie nothing is lost or confused with the translator.
 
  • Like
Reactions: J.Michael

pndwal

Senior Member
I am on 25.1. Last time I tried to update using OTA incremental was with 24.3.
Bit further... It may be to do with OnePlus upgrade itself...

I notice Pixel 6 users report that Patching the Inactive slot after an OTA Update and rebooting results in a Bootloop currently:
Bootloop after OTA #5959
https://github.com/topjohnwu/Magisk/issues/5959

Perhaps your late OnePlus device is affected by an upgraded method too...

This issue is marked as wontfix, but vv comments:
Fix it requires implementing the partition digest calculation to overwrite the original value, PR welcome.
https://github.com/topjohnwu/Magisk/issues/5959#issuecomment-1152869296

👀 PW
 

m0han

Senior Member
Apr 30, 2012
5,004
2,052

Attachments

  • Screenshot_20220703_093516.jpg
    Screenshot_20220703_093516.jpg
    155.4 KB · Views: 41
  • Screenshot_20220703_094150.jpg
    Screenshot_20220703_094150.jpg
    107.3 KB · Views: 39
Last edited:
Bit further... It may be to do with OnePlus upgrade itself...

I notice Pixel 6 users report that Patching the Inactive slot after an OTA Update and rebooting results in a Bootloop currently:
Bootloop after OTA #5959
https://github.com/topjohnwu/Magisk/issues/5959

Perhaps your late OnePlus device is affected by an upgraded method too...

This issue is marked as wontfix, but vv comments:

https://github.com/topjohnwu/Magisk/issues/5959#issuecomment-1152869296

👀 PW
I do not think this is the issue. I cannot flash any boot image and get it to boot again. I have to factory reset from recovery. It used to not be an issue, because full OTA update zips where available for the OnePlus 9, but now Oxygen Updater is telling me I have to do the incremental ones.
 

doniedogawa

Member
Oct 29, 2021
33
2
Indonesia
I just installed Magisk v25.1 on my LG V20 H990DS with stock oreo, and success without having kernel issues. But i can't opened the app itself (stuck on logo), but when downgrading the app to v23.0. It can be opened.
 
Last edited:

pndwal

Senior Member
I used to use a custom kernel, but haven't since going to the OnePlus 9. Otherwise I only install Magisk. I do not ever mount any partition as read/write except boot to install Magisk.

Yes, I forgot that step. I reboot from within Magisk.

I installed 25.1 App from within 24.3, and than direct install 25.1 into boot. I did not get any errors. So, should I restore image and direct install from 25.1 and reboot before OTA?
You don't restore images for Direct install generally, although I hadn't considered "restore image(s) and direct install" before reboot... Is the option still there after Restore Images?... If so it may be useful if simply taking Direct Install fails...

I'd personally be giving Install to Inactive Slot from 25.1 another shot too...
Last time I tried OTA and got a boot loop only 24.3 was out. I am asking questions before I go to update now, but I do have 25.1 installed. App and Boot. Since 25+ came with the fstab change, I doubt that was the issue before.
Yes, my bad... Originally assumed Install to Inactive Slot was from 25.1 since you hadn't specified, and I hadn't caught up... PW
 
You don't restore images for Direct install generally, although I hadn't considered "restore image(s) and direct install" before reboot... Is the option still there after Restore Images?... If so it may be useful if simply taking Direct Install fails...

I'd personally be giving Install to Inactive Slot from 25.1 another shot too...

Yes, my bad... Originally assumed Install to Inactive Slot was from 25.1 since you hadn't specified, and I hadn't caught up... PW
Yes, I know you do not generally restore the images for direct install, and I didn't do that when doing 24.3 -> 25.1. Maybe the failed install was caused by 25.0 not 25.1. I was thinking about that because that would flash stock boot and than install 25.1. This is all before doing the OTA incremental update.

But because I did not have any issue direct installing 25.1, I do not see how this would effect install to inactive slot anyways. Also, again I have had this issue before 25+ Magisk builds. When I had issue with it before I did grab the full update, used payload dumper to get all the IMG files, and flash all of them without factory reset. I still could not boot until I factory reset the device from recovery.
 

pndwal

Senior Member
I do not think this is the issue. I cannot flash any boot image and get it to boot again. I have to factory reset from recovery. It used to not be an issue, because full OTA update zips where available for the OnePlus 9, but now Oxygen Updater is telling me I have to do the incremental ones.
It's a current issue for Install to Inactive Slot... It's not an OTA issue per se.

You seem to be confusing the issue a bit...

The Install to Inactive Slot will work for both full and Delta OTA types; the difference is that Delta OTA's always require Restore Images step... Previously (if OnePlus actually delivered full ROM OTA package) this step may actually have been superfluous as the OTA can update the images without requiring the previous images to pass pre-OTA block verifications. The verification is needed as the A/B update engine combines expected binary from the active slot with Delta update (contains only changed bytes, not complete files) using a complex algorithm to generate images flashed concurrently to the inactive slot...

Further, generally custom ROMs use full package, and stock use Delta... PW
 

pndwal

Senior Member
Yes, I know you do not generally restore the images for direct install, and I didn't do that when doing 24.3 -> 25.1. Maybe the failed install was caused by 25.0 not 25.1. I was thinking about that because that would flash stock boot and than install 25.1. This is all before doing the OTA incremental update.
Since we got single-package Magisk (22+), Magisk (mask) is flashed from App package installed... If you had 25.1 App, 25.1 binary is flashed, not 25.0...
But because I did not have any issue direct installing 25.1, I do not see how this would effect install to inactive slot anyways.
The issue for Pixel 6 I gave should make you think then... no issue direct installing 25.1, but Install to Inactive Slot is broken!... 🙃
Also, again I have had this issue before 25+ Magisk builds. When I had issue with it before I did grab the full update, used payload dumper to get all the IMG files, and flash all of them without factory reset. I still could not boot until I factory reset the device from recovery.
So seems you faced / may be facing other (multiple) issues... PW
 
Since we got single-package Magisk (22+), Magisk (mask) is flashed from App package installed... If you had 25.1 App, 25.1 binary is flashed, not 25.0...
Mostly I am talking about how the direct install failed. Maybe it was either just the Pixel or 25.0 failing, because of the new init thing. I did not install 25.0, because 25.1 was what popped up for update.

The issue for Pixel 6 I gave should make you think then... no issue direct installing 25.1, but Install to Inactive Slot is broken!... 🙃
Yeah. Install to inactive slot always worked for Full OTA, but never for incremental.

So seems you faced / may be facing other (multiple) issues... PW
I am unsure of what other issues could be causing this. Only guess was maybe I have to deactivate the "Systemless Hosts" module that Magisk installed. I am going to try again with OTA incremental and 25.1. Before I would have to restore old stock and factory reset (because of boot loop), than do the OTA before Magisk and setting things up. I just come here to see if anyone else is having this issue.
 

Top Liked Posts

  • 5
    Some Insight on the New Cat and Mouse Game...

    Since many are asking:
    Is there a fix for this? ... Can't pass MEETS_STRONG_INTEGRITY.
    I'm posting this WOT. 🤪

    I predict some will like it, some won't... You've been warned! 😜

    FWIW, Play Integrity MEETS_STRONG_INTEGRITY is akin to SafetyNet Evaluation type HARDWARE with CTS Profile match...

    Banks could have used this before (w/ S/N API) but haven't as it would have excluded too many users/devices/customers... Nothing has actually changed with new PI API; MEETS_STRONG_INTEGRITY will exclude the same group, so it's doubtful they'll rush to require this verdict...

    Basically, the means to enforce Hardware key-backed Attestation has already been here w/ either of these attestations, but banks don't want to exclude all those w/Android 7 and below, or many w/ broken keymaster 3+ implementations in Android 8+ devices (CTS Profile match with HARDWARE Evaluation type / MEETS_STRONG_INTEGRITY won't pass with locked bootloader), eg most OnePlus devices (nb. Keymaster may have been fixed in OnePlus devices launched with Android 12+)...

    I'm guessing the banks may well leverage this at some point if the time arrives when they feel there is a sufficient critical mass of devices w/ working hardware-backed keymaster (ie w/ hardware keystore, A8+) to trade against the number of modded (bootloader unlocked) devices in use especially if they deem Google slow to close the fallback-to-basic-attestation loophole that has allowed modders to bypass hardware based attestation to CTS Profile match enforcement (by triggering fallback to BASIC Evaluation type as well as bypassing enforcement) and also to allow its counterpart, MEETS_DEVICE_INTEGRITY verdict. (Nb. This verdict should not properly be obtained on modded devices, and it requires the same attestations as S/N as well as the same tricks to trigger fallback to BASIC attestation and bypass enforcement) The incentive to use this foolproof means is also certainly being weighed constantly against the cost / need to use their own custom means of sophisticated 'root' detection...

    Google also, as other authorities have commented, appears to be waiting for some 'acceptable' percentile / critical mass of such devices in use to be reached also, before they swing the 'big hammer' that is Hardware-backed Key Attestation enforcement and that will definitely spell the endgame for modders' use of bank apps, and possibly for OnePlus users and others whose devices have broken keymaster*

    *Nb. There are exceptions, eg Asus ROG Phone 3, where broken keymaster actually results in PI MEETS_STRONG_INTEGRITY and S/N CTS Profile match with Evaluation type HARDWARE regardless of bootloader status instead of the converse...

    It seems likely to me that OnePlus and other devices with broken keymaster can be spared if Google do prevent on-device triggering of fallbacks to basic attestation use simply by using device info contained in the cryptographic attestation sent to Google servers instead of userspace model props etc now used, to bypass enforcement at the server end. If they do this it would be a concession as modded OnePlus etc may then still be able to pass CTS Profile match / DEVICE_INTEGRITY while other modern modded devices won't...

    This would, however, be a way to swing the hammer a bit sooner, and either way, as can be seen from the above, they may be forced to do this once banks do indicate a willingness to enforce
    MEETS_STRONG_INTEGRITY in order to stop a landslide that would prevent all stock locked Android 7 and lower devices using bank apps etc... Or maybe they'll just let the landslide go and force bank app users to upgrade devices...

    Hopefully this gives some insight regarding what pressures may finally force Google to properly deploy (ie. strictly enforce) Hardware-based Key Attestation on devices that support it...

    Personally, I think Google has exercised great restraint, possibly out of some regard for the modding community since I can't see any other compelling reason not to have properly enforced CTS Profile match with HARDWARE Evaluation type where supported or Hardware attested MEETS_DEVICE_INTEGRITY sooner, unless the matter of ensuring that the API properly sees hardware identifiers (ie. these cannot be spoofed, which I believe would again require cryptographic server-side attestation that the device doesn't indicate the presence of hardware keystore) for bypassing hardware attestation enforcement in devices launched with Android 7 and earlier is proving difficult (but I'm fairly sure this mechanism will be a simple matter for Google and probably already in place)... 😛

    It may well be that Google is benevolently holding off but is using/will use MEETS_STRONG_INTEGRITY uptake data as tha natural indicator of the banks propensity for reliable HKA... My bet is that if Google doesn't have immediate plans to move to srtict HKA enforcement for MEETS_DEVICE_INTEGRITY, then they will when the banks themselves move to use the even stricter MEETS_STRONG_INTEGRITY verdict...


    👀 🤠
    3
    ... updating to the newest magisk manager shows n/a for magisk installed....
    Experienced this issue on a fork of Magisk too. https://forum.xda-developers.com/t/...third-party-magisk-fork.4460555/post-87255925
    Did you have Magisk App hidden when updated?... Classic trap...
    3
    It's a general rule: take chances (w/ awareness of issue/remedy) or take Restore the Magisk app before updating App... My success estimate is reducing... 50/100 --> 40/100 --> 30/100 (?).

    It's all TJW/vv2060 code, so irrespective of fork... PW
    3
    Alright so I looked a bit and had very little luck and gave up. Then I opened terminal emulator for some unrelated activity, ran su, and "device manager" stopped working. Gonna see what happens when I uninstall that...

    Worked lol shows which version is installed access to superuser tab and modules tab active haha
    Very simple (and you don't need Terninal, su, etc):
    - look into your Drawer and/or Settings/Apps and find your old hidden/renamed Magisk app
    - when you did in the past *Hide Magisk app" you were given a chance to rename it.. Hence you should know what name you gave it (default name is Setting)

    Find that app and uninstall, and reboot. You may additionally need to reinstall the new Magisk app

    If you look into this thread you will literally find hundredth of such posts and answers. Hence nothing new - before installing/updating the new Magisk app, one MUST open the OLD hidden (if he did hide it) and do "Restore Magisk app"

    Otherwise, when you install the new Magisk app, you will have a clash - new Magisk app does not see Magisk (because the old/hidden Magisk app is connected to Magisk)

    Unfortunately,v I also don't know why TJW does not acknowledge this problem and if they could not fix it, AT LEAST to make a note into the Installation instructions (I know, nobody would read☹️) and a warning into the Changelog

    Of course, he does not read this thread and he doesn't care about all the users experiencing the same problem (99% of them are not on the level to have GitHub account and to report there, and they don't bother him to his lovely Twitter🤣)
  • 7
    By the way, there is another thread with detailed OP instructions for the new Magisk v24/v25:

    And a thread that was opened for hiding root with the new Magisk:

    Those new threads were opened because of this old and cluttered thread.
    Unfortunately, people still report/ask here (and in parallel complain that thread is too big to read☹️)
    6
    Its trivial to sniff or even MITM a desktop, or even just run WinPE and reset admin password and use the users own saved passwords in their browser, heck even export their passwords....

    In any event the biggest risk vector is social engineering

    Chasing root phone users only gives them a "feelgood", it does nothing to stop genuine misuse and fraud, at all.....

    I dont see Google or a bank sending out a representative every time someone makes a transaction to see if theyre genuine....trying to control the device is attacking the wrong end of the transaction and is ultimately pointless
    They're not chasing root users. They just want a guarantee that the device is secure, and they have good reason to. Rooting by nature compromises device security.

    I'm not saying your opinion is invalid; in this context however, it is irrelevant, because regardless of how you may feel about the situation, it's not going to change.
    5
    @pndwal You can build Magisk app with custom name and label as you want
    MagiskHide is still effective to hide root from banking apps. It's not dead if you don't care about safetynet stuff.


    Shamiko is taking off your panties on the basic of MagiskHide. So MagiskHide is still better.
    You believe Shamiko too much, It can't really hide zygisk, only fix the zygisk detection of Momo. However, I can't blame it because that was the nature of zygisk and it will never be fixed.
    Still not sure what you're trying to tell me...

    I think we agree on most of this stuff (except your apparent impression that Shamiko Devs have some sort of sexual agenda, or that it's users are somehow prone to 'self abuse'... I won't use the other term either...).

    If you think I have misrepresented any facts regarding Magisk, Shamiko or other, please say it plainly... I think what I provided for the sake of clarity was accurate... 🙁 PW
    5
    Latest Official TJW public Stable (release) Magisk build:

    Magisk

    2022.7.20 Magisk v25.2​

    Maintenance release fixing various issues.
    • [MagiskInit] Fix a potential issue when stub cpio is used
    • [MagiskInit] Fix reboot to recovery when stub cpio is used
    • [MagiskInit] Fix sepolicy.rules symlink for rootfs devices
    • [General] Better data encryption detection
    • [General] Move the whole logging infrastructure into Rust

    Full Changelog: here

    https://topjohnwu.github.io/Magisk/releases/25200.html

    🎉🎊 PW
    5
    did all that, flashed uninstall.zip, uninstalled the Magisk app, flashed the original boot.img from LineageOS payload.bin...

    End result: root apps don't have root, "secure apps" (banking, etc.) complain about the phone being rooted.

    Example: CF.lumen stating "Could not aquire root access". But then the banking app is claiming the phone isn't secure and closes. Same for a State ID certification app I use.

    This is a disaster.

    With Magisk uninstalled and original boot you have no more Magisk

    But you don't pass SafetyNet (bcs your Bootloader is still unlocked and you still run custom ROM and you are no more hiding it by eg using Magisk module USNF), hence banking apps do complain about 'root' (they probably don't say "root" or use the meaning vaguely)

    If you want to get rid of Magisk and with that you want to pass SN and banking apps, you would need to go back to stock and relock the bootloader
    For the record.

    A few months ago, testing something.. :unsure:

    I was surprised to see the official Lineage build(s) were not user builds.
    Since they are not user builds, they can/will be considered compromised and not properly locked down.
    Some apps will report root or a custom rom.​

    It was pointed out to me (by a cm/los dev I highly respect) that the official Lineage (cyanogenmod) builds have always been debug builds.
    • Switching to user builds would be extremely difficult and way too much time and work for the maintainers.
      Reminder. Most are volunteers that freely give us their time and knowledge.​
    • Some devices might not be able to be supported as a user build.
    • Would limit what you as the user can do with the device.

    Cheers. :cowboy:
  • 1084
    This is the place for general support and discussion regarding "Public Releases", which includes both stable and beta releases.
    All information, including troubleshoot guides and notes, are in the Announcement Thread
    156
    Hello, I haven't given much support on XDA lately. It can be resulted from
    • University started and I have limited free time. In fact, I mostly develop during midnight
    • I live in Taiwan, which has large time zone differences between my European/American contributors/testers, which usually forces me to stay up late at night to discuss/test stuffs.
    • The new version is about to come, I don't want to spend effort on supporting old releases
    The planned update is delayed again and again, to some point I think I'll shed some light about what has been happening lately, also along with some announcements.

    New Forum!
    As you might have already discovered, Magisk got its own subforum on XDA! Many thanks to all the support you gave me, and much more information/features/support is about to come!
    **For developers supporting all the devices that are not using standard Android boot format, feel free to create threads in this section (actually, PLEASE do so) for your favorite devices after v7 is out. As I currently know, Asus devices require signing the boot image before flashing, and is model dependant; Sony devices seems to use ELF kernel that is unpatchable, or some has two ramdisks (inner + outer), both requires different workarounds; LG bootloader locked devices has to manually "BUMP" the boot image after flashing Magisk..... and there may be lots of other crazy boot image formats that haven't come up to my attention yet.
    It is impossible for me to support all these non-standard boot images, and I hope the community can collaborate to make Magisk running across all the devices. Overall, community collaboration is what XDA about :D

    The Pixel Phone
    Some of you might already know this news, that the next Pixel Phone right around the corner seems like it does not have ramdisk in boot image, which pretty much wrecked Magisk in all ways. However, it pretty much doomed root itself too. Kernel modifications is inevitable IMO, so I'll try to migrate my scripts to C programs that could possibly be included into the kernel itself. Note that I'm not familiar with linux kernel, I'm not even sure if my idea and concept is correct or not. But once the device is available, I think developers will find a way to bypass all the difficulties, and I'll do my best to learn things ;)

    Current Progress
    In the past month, I've spent quite some time learning SELinux, so that I can avoid using SuperSU's sepolicy patches. Thanks to the helps and tips from @phhusson and @Chainfire, I finally have a much clearer understanding of how SELinux works. The Magisk core parts (the scripts, boot image patches, new features, more supports) are actually done some time ago. What is causing all the delays is the Magisk Manager.
    To be completely honest, although I can code in Java without much issues, Magisk Manager is actually my first Android application, I had to reach out for assistance, and fortunately awesome developers like @DVDandroid and @digitalhigh contributed a lot, which makes the current Manager awesome.
    After the repo system and module management is mostly done, I was about to do some adjustments and release, but what we really done is decided to add another feature: auto-unroot with per-app settings. I decided to wait for it to be finished, and then do my adjustments. Due to reasons that'll be mentioned later, this feature will likely not be available for the next release (should come in future updates)

    Safety Net Disaster
    Those who are using Magisk for Safety Net bypass purposes must have known that Google recently updated the detection method of my Systemless Xposed. I still have no idea what Safety Net is detecting, so currently I cannot fix it on my side (also because I'm busy working on the next update). However, suhide developed by @Chainfire is able to hide Xposed and worked fine.
    However, only my Systemless Xposed v86.2, which is based on SuperSU's su.d, is supported using that method. v86.2 and v86.5 (latest, Magisk based) have nearly identical binaries, and the only difference is the path where the binaries are stored.
    I'm still not sure what's the real issue for it not being supported, I just hope it is not done intentionally.

    Conclusion
    Due to the fact that my Safety Net bypass is not 100% perfect now, I do not want to spend any more time waiting for auto-unroot to be polished. What I'm doing now is finishing up all the things I'd like to change in Magisk Manager (it has been a while since I last contributed to Manager, my fellow developers are doing all the heavy job), which might take a little more time, after that, packed with tons of information to be announced in Magisk Section, I'll release the long awaited update.

    Hope this lengthy post gives you the idea of the whole situation, and again thanks for all your support!!
    121
    Ah, some Chainfire bashing, I hope it is not too late for me to exercise additional villainy.

    First, let me make clear I have nothing against @topjohnwu, nor against Magisk. Magisk is an interesting project and it certainly displays @topjohnwu ingenuity and persistence. I don't doubt we will see more interesting things from his hands.

    -------------------------

    What has happened here is not all that dark and complicated, from either end. I returned from holidays, and someone pointed me at Magisk. My first thought: interesting!

    Among other things, the thread lists some issues with SuperSU, which in combination with the phrase The developer also requests users to not bug Chainfire with compatibility requests for SuperSU with Magisk from the portal article, raised my left eyebrow by nigh half an inch. The popular systemless xposed mod is apparently now based on it, and apparently it now no longer works with SuperSU, and apparently I'm not supposed to fix that, nor any of the other found issues. I found that a bit weird. So yes, I have told @topjohnwu that I was a bit surprised he was posting about issues with SuperSU without notifying me about them (I can't fix or help fix issues I'm not aware of, after all).

    He's also spreading a modified version of the SuperSU package, which is not all that uncommon, nor necessarily a problem. I have not looked into what he modified, I only ran a few quick tests on one of my devices, and found some commonly used commands run as root to be broken. I have informed him of this as well.

    It appears the tool of choice for Magisk is phh's Superuser, because of some of the mentioned issues with SuperSU. That's fine by itself, but fixing issues in that superuser by incorporating SuperSU's binaries into it is a somewhat questionable practise. After all, SuperSU is a commercial closed-source package that helps pay for my dinner, and superuser is a direct competitor. I have informed him that I was surprised he did this without asking for permission. I have expressed similar surprise on him spreading a modified version of LiveBoot (which helps pay for a snack now and then).
    @topjohnwu has also stated that Magisk's scripts are largely influenced by mine (I have not checked). Scripts based on mine are used all over the place on XDA, some people have crafted amazing things based on them, I have never made an issue of this (otherwise I would have just made them binaries). But yes, I have also stated to him that I don't think it's very nice to base something on one program, and then using that to (almost exclusively) push something directly competing with that program.

    tl;dr Towards @topjohnwu, I have:
    - expressed surprise he has issues getting Magisk to work with SuperSU, and has chosen not to inform me about those
    - expressed surprise he is using SuperSU binaries in a competing superuser without permission
    - expressed surprise he is posting a modified LiveBoot without permission
    - informed him of issues with the modified SuperSU he has posted
    - let him know I thought it wasn't very nice to be applying my scripts to benefit seemingly exclusively that same competing superuser

    To be crystal clear:
    - I have not asked for an apology
    - I have not asked for Magisk to be abandoned, neither the root hiding nor systemless module parts, and certainly not systemless xposed
    - I have not made an issue of any of this anywhere, until this post
    - I have not even specifically asked for anything to be taken down (though obviously in my opinion the other superuser package mixed with SuperSU's binaries, as well as the LiveBoot package, should go)
    - I have not reported this thread to XDA moderators for copyright violations or otherwise

    While my conversation with @topjohnwu may not win any awards for being friendly (though it may win some for brevity), I think all things considered my response has been rather mild. To be perfectly honest, until the apology post, I thought this was over with already. I think the apology post was triggered because I haven't replied to his last PM for a while - I was in the zone, it happens.

    To emphasize again, I have nothing against @topjohnwu, Magisk, or systemless xposed, and it is certainly not my goal to see any of them go. If it can be made to work together with SuperSU, great.

    I get it though: you think of something, you want to see if you can make it work, you finally get it to work, you publish it, it takes off - enthusiasm gets the better of you. Maybe in the rush some mistakes are made. That doesn't mean you have to just drop it and run. None of my stuff would make it past 0.1 if I stopped at the first big mistake :)

    Aside from said being in the zone coding, I usually regret actually responding to these sort of things the day after, which has made me hesitant to reply. Surprise me.
    76
    Thread temporarily closed so everyone sees this.

    The flood of "SafetyNet isn't working for me either!" posts are not helpful, at all. Please refrain from posting further, it will be looked into. Please do not forget that not passing SafetyNet is 100% NORMAL AND INTENDED when you have an unlocked booloader or running custom firmware. These are workarounds and they will be worked around in turn.

    The Flash
    Forum Moderator

    EDIT: Thread is reopened... I will be cleaning any SafetyNet posts for a while to keep the thread clean for real issues.
    75
    Hello everyone!

    I am aware that Google has updated Safety Net that makes Magisk itself a no go for Android Pay. In fact, I witnessed the change live while I am developing the new magiskhide, which should hide all Magisk modules and Magisk installed root.

    Google is serious about Safety Net now, clearly hunting down all possibility to run Xposed with Safety Net passed. I spend quite some time examining the new security measures last midnight, and fortunately it seems that it is possible to run Magisk and root along with Safety Net if no Xposed is running. I'm glad I removed the old root toggle at the right time lol, that is no longer feasible with the latest detection.

    So stay tuned for the next update, it will come with bug fixes, along with the new magiskhide to bypass that Safety Net.

    Google, how will a few systemless mods do any harm :p:p