Magisk General Support / Discussion

Search This thread
Hey there.
I have a Samsung S9 under Alexis Rom (based on OneUI 2.5).
When trying to update to Magisk 25.1, the direct install method leads to an error "unsupported boot image extra".
So I tried the patch images method. However, there was no “Patch vbmeta in boot image” option as described. So I let Magisk patch the original boot.img and flashed it.
It ended up to boot on a locked screen saying that the device is encrypted, which is not true. Moreover, the /data partition is readable in TWRP.

What have I done wrong?

EDIT: solved the issue with a backup of /data, then formatting it, then restoring the backup.
However, flashing again the 25.1 patched boot image resulted in bootloop: back to 24.3.
 
Last edited:

rodken

Senior Member
Jan 11, 2010
1,004
392
I'm stuck in a bootloop due to a module I installed (foxyboot?). I can boot normally with the stock boot.img and another boot image that gives me ADB root access.

I tried
Code:
adb wait-for-device shell magisk --remove-modules
but the device never established an ADB connection. So then I used the boot image that gives me ADB root, and I deleted /data/ADB/modules and modules_update. That didn't help. I tried data/ADB/magisk/ ./magisk32 --remove-modules, but that just caused the device to reboot, and didn't change the bootloop.

I can't install zips via TWRP currently.

Is it possible for me to just remove all the ADB files on the device eMMC and reinstall magisk manager? Where else is magisk storing files other than /data/ADB ?
For future reference:
-- Always take a working version of the latest Magisk and patch your boot.img
-- This ensures that you can flash and resort back in the event of a catastrophic event
-- Consider investing in installation of the Bootloop Saver.
-- Look into what the 'Magisk Manager for Recovery Mode' can do for you [if you have a working version of TWRP installed].

 

sharpknight

Senior Member
Mar 28, 2012
72
26
I just installed Magisk v25.1 on my LG V20 H990DS with stock oreo, and success without having kernel issues. But i can't opened the app itself (stuck on logo), but when downgrading the app to v23.0. It can be opened.
I am experiencing the same issue on my LG G7 ThinQ. I am able to install the Magisk v25.1 app but after the app install, the Magisk v25.1 app does not open. I just see the Magisk mask/face logo. I upgraded from v24.3. I'm able to downgrade back to Magisk v24.3 without problems.
 

rodken

Senior Member
Jan 11, 2010
1,004
392
I am experiencing the same issue on my LG G7 ThinQ. I am able to install the Magisk v25.1 app but after the app install, the Magisk v25.1 app does not open. I just see the Magisk mask/face logo. I upgraded from v24.3. I'm able to downgrade back to Magisk v24.3 without problems.
If Magisk is stuck on the splash screen:
-- Uninstall Magisk app and repatch your boot image.
-- If that doesn't work - Reflash your boot image and then patch the new boot image.
 
  • Like
Reactions: 73sydney

zgfg

Senior Member
Oct 10, 2016
7,641
5,047
If Magisk is stuck on the splash screen:
-- Uninstall Magisk app and repatch your boot image.
-- If that doesn't work - Reflash your boot image and then patch the new boot image.
It's absolutely strange that Magisk APP is stuck, but do you have any ground that reinstalling Magisk (patch and flash the image) would help to the Magisk app?!

(It could be that something is wrong with Magisk db or so, and repatching and reflashing Magisk would not fix at all)
 

zgfg

Senior Member
Oct 10, 2016
7,641
5,047
I am experiencing the same issue on my LG G7 ThinQ. I am able to install the Magisk v25.1 app but after the app install, the Magisk v25.1 app does not open. I just see the Magisk mask/face logo. I upgraded from v24.3. I'm able to downgrade back to Magisk v24.3 without problems.
Magisk app is only like a UI Manager (remember it's previous name Manager?)

Magisk can work without the app - did you test if Magisk works?

Root: If you previously granted root to an app, does that app still works with root grants (it wouldn't if Magisk is not running)

Modules: Do you have any modules installed, then test if those modules still work

Command Line Interface: From terminal type magisk and read the help (man pages).
With the magisk command + options (all from Terminal), youu can investigate which version of Magisk is running, if Zygisk is active or not, etc (you can even manage DenyList and modules - not just check their status)

If you really did not make some mistake on your side, it would be more than worth to report as an issue to the Magisk GitHub. You would need Magisk Debug 25101 and its logs....

PS: When you say you install Magisk 25.1 and downgrade to 24.3, are you referring really to upgrading and downgrading Magisk (service/mask) or you only install Magisk app v25.1 and then back Magisk app v24.3?

And in that case, what is your procedure of upgrading and downgrading Magisk (I'm not asking about the app) - please describe
 

sharpknight

Senior Member
Mar 28, 2012
72
26
Magisk app is only like a UI Manager (remember it's previous name Manager?)

Magisk can work without the app - did you test if Magisk works?

Root: If you previously granted root to an app, does that app still works with root grants (it wouldn't if Magisk is not running)

Modules: Do you have any modules installed, then test if those modules still work

Command Line Interface: From terminal type magisk and read the help (man pages).
With the magisk command + options (all from Terminal), youu can investigate which version of Magisk is running, if Zygisk is active or not, etc (you can even manage DenyList and modules - not just check their status)

If you really did not make some mistake on your side, it would be more than worth to report as an issue to the Magisk GitHub. You would need Magisk Debug 25101 and its logs....

PS: When you say you install Magisk 25.1 and downgrade to 24.3, are you referring really to upgrading and downgrading Magisk (service/mask) or you only install Magisk app v25.1 and then back Magisk app v24.3?

And in that case, what is your procedure of upgrading and downgrading Magisk (I'm not asking about the app) - please describe
I reverted to Magisk 24.3 and it appears to work. I have root access (my other root apps work).
Yes, all my root apps that previously had been granted root access work.

with terminal command: magisk -c
i get: 24.3MAGISK (24300)

with terminal command: magisk -v
i get: 24.3MAGISK

therefore it appears that i have Magisk 24.3

When I said I installed Magisk 25.1, I downloaded and installed the Magisk Manager 25.1 app. I obtained the app via the Magisk manager, but i also tried the apk from the Github. Both yield the same result where upon opening the Magisk Manager 25.1 app, I see the Magisk mask/face logo. Nothing else. I waited several minutes. SO technically? i was unable to install Magisk 25.1.
I was going to install Magisk 25.1 via the Magisk 25.1 by clicking "Install" and selecting the "Direct Install (Recommended)" option.
 

ipdev

Recognized Contributor
Feb 14, 2016
1,858
1
3,281
Google Nexus 10
Nexus 7 (2013)
Command Line Interface: From terminal type magisk and read the help (man pages).
With the magisk command + options (all from Terminal), youu can investigate which version of Magisk is running, if Zygisk is active or not, etc (you can even manage DenyList and modules - not just check their status)
I missed the one that shows Zygisk status.
Can you nudge me in the direction of the command to check Zygisk. 👀

Cheers. :cowboy:
 

pndwal

Senior Member
Hey there.
I have a Samsung S9 under Alexis Rom (based on OneUI 2.5).
When trying to update to Magisk 25.1, the direct install method leads to an error "unsupported boot image extra".
So I tried the patch images method. However, there was no “Patch vbmeta in boot image” option as described.
Sounds like your device has a separate vbmeta partition...
So I let Magisk patch the original boot.img and flashed it.
It ended up to boot on a locked screen saying that the device is encrypted, which is not true. Moreover, the /data partition is readable in TWRP.

What have I done wrong?

EDIT: solved the issue with a backup of /data, then formatting it, then restoring the backup.
However, flashing again the 25.1 patched boot image resulted in bootloop: back to 24.3.
So have you tried with the optional step to disable verity/verification?:
  • (Optional) If your device has a separate vbmeta partition, you can patch the vbmeta partition with command:
    fastboot flash vbmeta --disable-verity --disable-verification vbmeta.img
Note: pre 25.0 Magisk used to strip avb_key and avb verification flags for partitions in 2SI devices, but 25+ no longer does this since refactoring 2SI MagiskInit injection...

Configurations that rely on Magisk to strip avb_key and avb verification flags for partitions will no longer work as Magisk no longer does / needs these changes (since fstab modification is not used for magiskinit injection in 2SI any longer).

This means a number of custom ROMs / kernels, including... Kirisakura kernel by @Freak07, will bootloop on some devices if you don't disable verity/verification before booting...

🤠 PW
 

pndwal

Senior Member
I just installed Magisk v25.1 on my LG V20 H990DS with stock oreo, and success without having kernel issues. But i can't opened the app itself (stuck on logo), but when downgrading the app to v23.0. It can be opened.
I am experiencing the same issue on my LG G7 ThinQ. I am able to install the Magisk v25.1 app but after the app install, the Magisk v25.1 app does not open. I just see the Magisk mask/face logo. I upgraded from v24.3. I'm able to downgrade back to Magisk v24.3 without problems.
Could be worth trying Canary apk or Debug...

User here reports that Stable 25.1 (frozen) behaviour is different, and Debug works... That should mean Canary will work also:
https://github.com/topjohnwu/Magisk/issues/6026#issuecomment-1165267294

Issue was closed and I can't confirm anything there... Hope it provides clues

Since user also reports differences in builds file structure (anomaly?), I'm guessing it could also (possibly) relate to this issue:
www.twitter.com/topjohnwu/status/1543440351460962305

... PW
 
Last edited:

zgfg

Senior Member
Oct 10, 2016
7,641
5,047
I missed the one that shows Zygisk status.
Can you nudge me in the direction of the command to check Zygisk. 👀

Cheers. :cowboy:
You're right. I missed that currently even checking the Zygisk status is not supported through CLI

 
  • Like
Reactions: ipdev

dohanin

Senior Member
Mar 26, 2011
226
126
Sony Xperia X Compact
Xiaomi Mi Pad 4
Hi, I suddenly found that while using a root explorer (Total Commander), there were only two folders and a link in /data/data, but in the past I could see all apps' data folders. Then I realised I recently had re-installed Magisk and just left the Mount Namesapce Mode as default (i.e. Inherit). After I changed it to Global, everything back to normal.

I just wanna ask, is this option only affecting the behaviour of those apps granted superuser access? Would it in any way affect root hiding?

cap.png
 
Last edited:
  • Like
Reactions: J.Michael

BlekBomor

Member
Jul 4, 2022
7
0
Whenever i open magisk, it just gets stuck on its logo at the start. I have tried deleting and reinstalling it and even wiped chache and dalvik but it still didnt work. Please someone help me
 

zgfg

Senior Member
Oct 10, 2016
7,641
5,047
Last edited:
  • Like
Reactions: J.Michael

J.Michael

Recognized Contributor
Jan 20, 2018
1,261
1,201
Samsung Galaxy Tab A series
It was recently shown/discussed in this thread how to use:
/data/adb/magisk/boot_patch.sh

to manually patch the (given) boot.ing
Wouldn't boot_patch.sh produce a boot image corresponding to the version of Magisk already installed?

I thought that the original problem was: Magisk and manager app v23 installed and working; Magisk Manager app v25 won't run. Maybe problem will be resolved by replacing Magisk with v25, but how to patch boot image to v25 without being able to run manager app v25?

I thought @rodken's suggestion to reflash stock, then install manager app v25 was likely to work. I didn't see how just uninstalling the manager app could advance the situation. I still do not.
 

zgfg

Senior Member
Oct 10, 2016
7,641
5,047
Wouldn't boot_patch.sh produce a boot image corresponding to the version of Magisk already installed?

I thought that the original problem was: Magisk and manager app v23 installed and working; Magisk Manager app v25 won't run. Maybe problem will be resolved by replacing Magisk with v25, but how to patch boot image to v25 without being able to run manager app v25?

I thought @rodken's suggestion to reflash stock, then install manager app v25 was likely to work. I didn't see how just uninstalling the manager app could advance the situation. I still do not.
Yeah, manual procedure will reflash the currently installed Magisk and that's v24.3 in his case

But apparently the user has a problem with Magisk APP v25.1 (Stable, supposed) not launching

It should have nothing to do with patching Magisk. Pndwal yesterday responded, see also a post right before yours (already three users reporting the same here - seems they have to try installing Canary v25101 APP instead, and then proceed with updating Magisk)
 
  • Like
Reactions: J.Michael

huskydg

Senior Member
Feb 17, 2021
207
209

zgfg

Senior Member
Oct 10, 2016
7,641
5,047
Thanks for your hint to use --sqlite:

Set Zygisk On:
magisk --sqlite "REPLACE INTO settings (key,value) VALUES('zygisk',1);"

Set Zygisk Off:
magisk --sqlite "REPLACE INTO settings (key,value) VALUES('zygisk',0);"

Check Zygisk status:
magisk --sqlite "SELECT value FROM settings WHERE key = 'zygisk';"

Btw, Magisk.db can be also easily managed from MiXPlorer (incl. Denylist and Root grants)
 

Attachments

  • IMG_20220706_110300.jpg
    IMG_20220706_110300.jpg
    42.6 KB · Views: 51

Top Liked Posts

  • 2
    Quick OT comment.
    To touch back on this.

    crDroid is based on Lineage.
    Think of cr as Lineage with heavy customization. 🙃

    If it does not work with Lineage, it will probably not work with cr unless it is fixed in cr.
    In turn, I would hope cr submits the fix to Lineage.

    Cheers. :cowboy:
    I did not know cdDroid background....we live and learn! Thanks for clarifying this.
    2
    I did not know cdDroid background....we live and learn! Thanks for clarifying this.

    Custom ROM's generally have just 2 sources, AOSP (Google open source) which is usually close to Pixel appearance or LineageOS.

    Just to make things murkier for you there may be 3 or 4 custom ROMs using LineageOS as a base, but often devs will "cherrypick" commits etc from other repos (other than LineageOS) to fix issues, so issues may exist on one ROM, but not another. Usually (though not always) once a dev finds fix for an issue they will share which commits theyve used to benefit the other ROM's.

    I dont miss the days, while on my s20+, of testing 3/4 ROMs a week like i used to on previous devices....

    <insert Murtaugh quote>

    p.s. If you dont get the Murtaugh quote then youre probably too young, and youre part of what daddy calls "The Problem" :)
    2
    Anyone knows if Magisk works on A13? My Pixel 4a seems to have got it this month. Tried to do a search in this thread, but the search function seems completely broken (unless I'm doing something wrong...)
    Yes it does.
    1
    I doubt it is a LOS problem - more likely an operator error! I flashed crdroid and ended up having exactly the same result.
    <SNIP>
    Quick OT comment.
    To touch back on this.

    crDroid is based on Lineage.
    Think of cr as Lineage with heavy customization. 🙃

    If it does not work with Lineage, it will probably not work with cr unless it is fixed in cr.
    In turn, I would hope cr submits the fix to Lineage.

    Cheers. :cowboy:
    1
    Finally managed to get hold of devs at LOS and their response was simply not to use adopted storage. That leaves me with the option of looking at fbind or manually move files to sdcard.

    Thanks everyone for your comments - greatly appreciated.
  • 8
    However, since the system is already rooted using Magisk shouldn't these folders be unencrypted?
    Magisk has nothing to do with File Based Encryption on Data and Storage.
    That's part of the File System definition - Magisk does not redefine File Systems.
    And when running Android, kernel takes care of FBE

    Btw, why would you (and some other users who maybe first time face FBE) dislike FBE (or be afraid of, or what) and want instead your files to be permanently unencrypted?!

    If you have a proper custom Recovery, it will ask for your pin/pattern and by use of that pin, it will then unencrypt file by file, on demand - just like Android does when you boot to Android

    Then, if your phone is stolen and the thief-hacker reboots to TWRP, he will not be able to steal your documents, phoos, etc, since (s)he does not know your Android unlock pin/pattern (and therefore TWRP cannot decrypt him your files - he can copy the encrypted files to PC but they will be of no use for him)

    However, without encryption, if your phone (with the TWRP installed) gets stolen, thief can simply boot to TWRP and copy all your personal files to PC.
    He can then open and read your documents, see your private photos, etc

    ---

    The official Google FBE documentation is available at:

    ---

    And one important tip:
    When installing custom ROM, usually you have to FORMAT Data (not just Wipe) that your new ROM could properly reformat FBE for itself - only then things will work as described (TWRP and FBE)

    But all that is out-of-topic for our Magisk thread

    Developers of custom ROMs should provide clear instructions how to properly install their ROMs - and their users of custom should take time to read instructions before flashing👍

    ---

    You can go to /vendor/etc/ (aka /system/vendor/etc one has to be mounted to the other in Android)
    and find a file fstab.* (on my phone it is named fstab.emmc).
    That's the read-only, textual file

    Inside, search for /userdata (filesystem definition).
    On my phone it looks like:
    Code:
    /dev/block/bootdevice/by-name/userdata /data f2fs noatime,nosuid,nodev,discard,inlinecrypt,reserve_root=32768,resgid=1065,fsync_mode=nobarrier latemount,wait,check,formattable,fileencryption=aes-256-xts:aes-256-cts:v2+emmc_optimized+wrappedkey_v0,keydirectory=/metadata/vold/metadata_encryption,metadata_encryption=aes-256-xts:wrappedkey_v0,quota,reservedsize=128M,sysfs_path=/sys/devices/platform/soc/1d84000.ufshc,checkpoint=fs

    Actually, inside that line look for the fileencryption definition - in my case:
    Code:
    fileencryption=aes-256-xts:aes-256-cts:v2+emmc_optimized+wrappedkey_v0

    Flag :v2 means that I have FBE v2. It's also emmc_optimized with hardware-wrapped keys (details and description can be found in the Google's FBE documentation as linked above)
    7
    By the way, there is another thread with detailed OP instructions for the new Magisk v24/v25:

    And a thread that was opened for hiding root with the new Magisk:

    Those new threads were opened because of this old and cluttered thread.
    Unfortunately, people still report/ask here (and in parallel complain that thread is too big to read☹️)
    6
    Its trivial to sniff or even MITM a desktop, or even just run WinPE and reset admin password and use the users own saved passwords in their browser, heck even export their passwords....

    In any event the biggest risk vector is social engineering

    Chasing root phone users only gives them a "feelgood", it does nothing to stop genuine misuse and fraud, at all.....

    I dont see Google or a bank sending out a representative every time someone makes a transaction to see if theyre genuine....trying to control the device is attacking the wrong end of the transaction and is ultimately pointless
    They're not chasing root users. They just want a guarantee that the device is secure, and they have good reason to. Rooting by nature compromises device security.

    I'm not saying your opinion is invalid; in this context however, it is irrelevant, because regardless of how you may feel about the situation, it's not going to change.
    6
    I had root, a few apps still recognize it, updating to the newest magisk manager shows n/a for magisk installed. Do I just grab my boot IMG out of my ROM and do it sgain? Will I keep all my data and info...?
    Did you have Magisk App hidden when updated?... Classic trap... Supposed to work, but bit like a pot-luck dinner...

    You're probably suffering from DACFRAS*, which is NOT fatal but all the clinics are full...

    Check in device settings, Apps for your old hidden App... Default name is 'settings', or its what you named it... Uninstall it, and presto!

    *Dual Apps Competing For Root Access Syndrome...

    😜 PW
  • 1085
    This is the place for general support and discussion regarding "Public Releases", which includes both stable and beta releases.
    All information, including troubleshoot guides and notes, are in the Announcement Thread
    156
    Hello, I haven't given much support on XDA lately. It can be resulted from
    • University started and I have limited free time. In fact, I mostly develop during midnight
    • I live in Taiwan, which has large time zone differences between my European/American contributors/testers, which usually forces me to stay up late at night to discuss/test stuffs.
    • The new version is about to come, I don't want to spend effort on supporting old releases
    The planned update is delayed again and again, to some point I think I'll shed some light about what has been happening lately, also along with some announcements.

    New Forum!
    As you might have already discovered, Magisk got its own subforum on XDA! Many thanks to all the support you gave me, and much more information/features/support is about to come!
    **For developers supporting all the devices that are not using standard Android boot format, feel free to create threads in this section (actually, PLEASE do so) for your favorite devices after v7 is out. As I currently know, Asus devices require signing the boot image before flashing, and is model dependant; Sony devices seems to use ELF kernel that is unpatchable, or some has two ramdisks (inner + outer), both requires different workarounds; LG bootloader locked devices has to manually "BUMP" the boot image after flashing Magisk..... and there may be lots of other crazy boot image formats that haven't come up to my attention yet.
    It is impossible for me to support all these non-standard boot images, and I hope the community can collaborate to make Magisk running across all the devices. Overall, community collaboration is what XDA about :D

    The Pixel Phone
    Some of you might already know this news, that the next Pixel Phone right around the corner seems like it does not have ramdisk in boot image, which pretty much wrecked Magisk in all ways. However, it pretty much doomed root itself too. Kernel modifications is inevitable IMO, so I'll try to migrate my scripts to C programs that could possibly be included into the kernel itself. Note that I'm not familiar with linux kernel, I'm not even sure if my idea and concept is correct or not. But once the device is available, I think developers will find a way to bypass all the difficulties, and I'll do my best to learn things ;)

    Current Progress
    In the past month, I've spent quite some time learning SELinux, so that I can avoid using SuperSU's sepolicy patches. Thanks to the helps and tips from @phhusson and @Chainfire, I finally have a much clearer understanding of how SELinux works. The Magisk core parts (the scripts, boot image patches, new features, more supports) are actually done some time ago. What is causing all the delays is the Magisk Manager.
    To be completely honest, although I can code in Java without much issues, Magisk Manager is actually my first Android application, I had to reach out for assistance, and fortunately awesome developers like @DVDandroid and @digitalhigh contributed a lot, which makes the current Manager awesome.
    After the repo system and module management is mostly done, I was about to do some adjustments and release, but what we really done is decided to add another feature: auto-unroot with per-app settings. I decided to wait for it to be finished, and then do my adjustments. Due to reasons that'll be mentioned later, this feature will likely not be available for the next release (should come in future updates)

    Safety Net Disaster
    Those who are using Magisk for Safety Net bypass purposes must have known that Google recently updated the detection method of my Systemless Xposed. I still have no idea what Safety Net is detecting, so currently I cannot fix it on my side (also because I'm busy working on the next update). However, suhide developed by @Chainfire is able to hide Xposed and worked fine.
    However, only my Systemless Xposed v86.2, which is based on SuperSU's su.d, is supported using that method. v86.2 and v86.5 (latest, Magisk based) have nearly identical binaries, and the only difference is the path where the binaries are stored.
    I'm still not sure what's the real issue for it not being supported, I just hope it is not done intentionally.

    Conclusion
    Due to the fact that my Safety Net bypass is not 100% perfect now, I do not want to spend any more time waiting for auto-unroot to be polished. What I'm doing now is finishing up all the things I'd like to change in Magisk Manager (it has been a while since I last contributed to Manager, my fellow developers are doing all the heavy job), which might take a little more time, after that, packed with tons of information to be announced in Magisk Section, I'll release the long awaited update.

    Hope this lengthy post gives you the idea of the whole situation, and again thanks for all your support!!
    121
    Ah, some Chainfire bashing, I hope it is not too late for me to exercise additional villainy.

    First, let me make clear I have nothing against @topjohnwu, nor against Magisk. Magisk is an interesting project and it certainly displays @topjohnwu ingenuity and persistence. I don't doubt we will see more interesting things from his hands.

    -------------------------

    What has happened here is not all that dark and complicated, from either end. I returned from holidays, and someone pointed me at Magisk. My first thought: interesting!

    Among other things, the thread lists some issues with SuperSU, which in combination with the phrase The developer also requests users to not bug Chainfire with compatibility requests for SuperSU with Magisk from the portal article, raised my left eyebrow by nigh half an inch. The popular systemless xposed mod is apparently now based on it, and apparently it now no longer works with SuperSU, and apparently I'm not supposed to fix that, nor any of the other found issues. I found that a bit weird. So yes, I have told @topjohnwu that I was a bit surprised he was posting about issues with SuperSU without notifying me about them (I can't fix or help fix issues I'm not aware of, after all).

    He's also spreading a modified version of the SuperSU package, which is not all that uncommon, nor necessarily a problem. I have not looked into what he modified, I only ran a few quick tests on one of my devices, and found some commonly used commands run as root to be broken. I have informed him of this as well.

    It appears the tool of choice for Magisk is phh's Superuser, because of some of the mentioned issues with SuperSU. That's fine by itself, but fixing issues in that superuser by incorporating SuperSU's binaries into it is a somewhat questionable practise. After all, SuperSU is a commercial closed-source package that helps pay for my dinner, and superuser is a direct competitor. I have informed him that I was surprised he did this without asking for permission. I have expressed similar surprise on him spreading a modified version of LiveBoot (which helps pay for a snack now and then).
    @topjohnwu has also stated that Magisk's scripts are largely influenced by mine (I have not checked). Scripts based on mine are used all over the place on XDA, some people have crafted amazing things based on them, I have never made an issue of this (otherwise I would have just made them binaries). But yes, I have also stated to him that I don't think it's very nice to base something on one program, and then using that to (almost exclusively) push something directly competing with that program.

    tl;dr Towards @topjohnwu, I have:
    - expressed surprise he has issues getting Magisk to work with SuperSU, and has chosen not to inform me about those
    - expressed surprise he is using SuperSU binaries in a competing superuser without permission
    - expressed surprise he is posting a modified LiveBoot without permission
    - informed him of issues with the modified SuperSU he has posted
    - let him know I thought it wasn't very nice to be applying my scripts to benefit seemingly exclusively that same competing superuser

    To be crystal clear:
    - I have not asked for an apology
    - I have not asked for Magisk to be abandoned, neither the root hiding nor systemless module parts, and certainly not systemless xposed
    - I have not made an issue of any of this anywhere, until this post
    - I have not even specifically asked for anything to be taken down (though obviously in my opinion the other superuser package mixed with SuperSU's binaries, as well as the LiveBoot package, should go)
    - I have not reported this thread to XDA moderators for copyright violations or otherwise

    While my conversation with @topjohnwu may not win any awards for being friendly (though it may win some for brevity), I think all things considered my response has been rather mild. To be perfectly honest, until the apology post, I thought this was over with already. I think the apology post was triggered because I haven't replied to his last PM for a while - I was in the zone, it happens.

    To emphasize again, I have nothing against @topjohnwu, Magisk, or systemless xposed, and it is certainly not my goal to see any of them go. If it can be made to work together with SuperSU, great.

    I get it though: you think of something, you want to see if you can make it work, you finally get it to work, you publish it, it takes off - enthusiasm gets the better of you. Maybe in the rush some mistakes are made. That doesn't mean you have to just drop it and run. None of my stuff would make it past 0.1 if I stopped at the first big mistake :)

    Aside from said being in the zone coding, I usually regret actually responding to these sort of things the day after, which has made me hesitant to reply. Surprise me.
    76
    Thread temporarily closed so everyone sees this.

    The flood of "SafetyNet isn't working for me either!" posts are not helpful, at all. Please refrain from posting further, it will be looked into. Please do not forget that not passing SafetyNet is 100% NORMAL AND INTENDED when you have an unlocked booloader or running custom firmware. These are workarounds and they will be worked around in turn.

    The Flash
    Forum Moderator

    EDIT: Thread is reopened... I will be cleaning any SafetyNet posts for a while to keep the thread clean for real issues.
    75
    Hello everyone!

    I am aware that Google has updated Safety Net that makes Magisk itself a no go for Android Pay. In fact, I witnessed the change live while I am developing the new magiskhide, which should hide all Magisk modules and Magisk installed root.

    Google is serious about Safety Net now, clearly hunting down all possibility to run Xposed with Safety Net passed. I spend quite some time examining the new security measures last midnight, and fortunately it seems that it is possible to run Magisk and root along with Safety Net if no Xposed is running. I'm glad I removed the old root toggle at the right time lol, that is no longer feasible with the latest detection.

    So stay tuned for the next update, it will come with bug fixes, along with the new magiskhide to bypass that Safety Net.

    Google, how will a few systemless mods do any harm :p:p