Magisk General Support / Discussion

Search This thread

rodken

Senior Member
Jan 11, 2010
1,125
457
It's absolutely strange that Magisk APP is stuck, but do you have any ground that reinstalling Magisk (patch and flash the image) would help to the Magisk app?!

(It could be that something is wrong with Magisk db or so, and repatching and reflashing Magisk would not fix at all)
There were instances where I suffered the same fate [twice] and simply reflashing a previously patched image would solve the dreaded 'stuck on splash screen' conundrum.
 
Last edited:

DiamondJohn

Recognized Contributor
Aug 31, 2013
6,381
6,333
Sydney
For future reference:
-- Always take a working version of the latest Magisk and patch your boot.img
-- This ensures that you can flash and resort back in the event of a catastrophic event
-- Consider investing in installation of the Bootloop Saver.
-- Look into what the 'Magisk Manager for Recovery Mode' can do for you [if you have a working version of TWRP installed].
You forgot Plan Z. Make backups before doing anything that may trash your setup, and have a restore plan.
...snip...

Btw, Magisk.db can be also easily managed from MiXPlorer (incl. Denylist and Root grants)
Id be careful with using MiX. Although I use MiX, editing dB's can have issues. It was a while back, but what I think I saw happen, is that MiX makes a copy of the database, makes the change to its own copy, and then copies back over the original. That can fail if there is another app using the dB or has the same plans.

Another option is to use SQLite directly from the command line, or use the app I built TeMeFI, which also edits the dB in-situ; its literally has a GUI to SQLite command line. MiX is closed source so its hard to know, but it failed to update a major db in android (I think the MediaDB), where the other options worked.

But the 1st option is without question the best option. ie have Magisk mess with its own database. Database concurrency is a hard taskmaster.
 
Last edited:

ipdev

Recognized Contributor
Feb 14, 2016
1,920
1
3,523
Google Nexus 10
Nexus 7 (2013)
You're right. I missed that currently even checking the Zygisk status is not supported through CLI


Looks like vvb2060 is against adding zygisk to the CLI. 🙁

Would be nice if we could check zygisk status just like we can the denylist.
Check the Zygisk status when you are installing a Zygisk module.​

Code:
magisk --denylist status 2> /dev/null
if [ $? -ne 0 ]; then
  ui_print " "
  ui_print " The Denylist is not enforced."
fi
'Denylist is not enforced' returns as error (1).​
'Denylist is enforced' returns as success (0).​

This would be nice. 🙂
Code:
magisk --zygisk status 2> /dev/null
if [ $? -ne 0 ]; then
  ui_print " "
  ui_print " Magisk Zygisk is not enabled."
fi
Assuming zygisk status returns the same as denylist status.​
'Zygisk is not enabled' returns as error (1).​
'Zygisk is enabled' returns as success (0).​

Guess we can work with the sql method. 🙃
Code:
if [[ $(magisk --sqlite "SELECT value FROM settings WHERE key = 'zygisk'" | cut -d '=' -f2) -ne 1 ]]; then
  ui_print " "
  ui_print " Magisk Zygisk is not enabled."
fi

Thank you for nudging me in the direction of the command to check Zygisk. (y)

Cheers. :cowboy:
 
Last edited:
  • Like
Reactions: galaxys
Then I don't understand "Maybe the failed install was caused by 25.0 not 25.1"... 🤔

and AFAIK, Pixel always used Delta...

Are you talking about need for full data wipe needed in order to install Magisk after an OTA?... IIRC, late Pixels had this issue for a long while... If you're still facing this to boot w/ Magisk 25.1+ after OTA, please say...

Restore images, take incremental OTA, download full ROM matching OTA, extract boot image, patch/flash boot image should work without data wipes generally... PW
I just did the update. I disabled the only module I have, which is the "Systemless Hosts" from Magisk itself. I downloaded the OTA incremental from Oxygen Updater. Restored Images in Magisk (25.1). Installed the update with the System Update APK that OnePlus had out for the A12 betas (because you cannot do local updates anymore in settings). I than went into Magisk and installed to inactive and rebooted from Magisk. It came up just fine. I think there must have been an error in 24.3 or I have to disable even "Systemless Hosts" module. I am now fully up to date. Thanks @pndwal
 
  • Like
Reactions: pndwal

Fif_

Senior Member
Jun 5, 2013
1,230
1,357
Google Nexus 10
Google Nexus 4
I have a OnePlus 9 on OxygenOS 12 C.48. C.61 is now being pushed out. Oxygen Updater no longer offers the full updates and is telling me to use incremental.
That is more than annoying. That means you have to boot once into Android with Magisk off after an OTA . If you have debloated apps, you can end up with the debloated apps reappearing when Magisk is not installed, getting updated, then having the system package pulled under the updated debloated apps. I've had instances where if I then remove the updated app, the system will refuse to boot again because expected libraries are missing. I was able to recover by editing /data/system/packages.xml, which I do not recommend for the faint of heart or noobs.
Anyways, you should do that magisk-less reboot in Airplane mode anyways, that prevents the problem from occurring in the first place, and saves you from losing certified status.
 
That is more than annoying. That means you have to boot once into Android with Magisk off after an OTA . If you have debloated apps, you can end up with the debloated apps reappearing when Magisk is not installed, getting updated, then having the system package pulled under the updated debloated apps. I've had instances where if I then remove the updated app, the system will refuse to boot again because expected libraries are missing. I was able to recover by editing /data/system/packages.xml, which I do not recommend for the faint of heart or noobs.
Anyways, you should do that magisk-less reboot in Airplane mode anyways, that prevents the problem from occurring in the first place, and saves you from losing certified status.
Well, I am now up to date. It might have been a bug in Magisk that was fixed in 25.1, or because I never disabled the one module I have in Magisk. I was able to use "Install to inactive" in Magisk after the incremental OTA just fine. I don't do anything special with bloat, just disable it in settings, and Neo Backup can disable those that settings tries to prevent you from doing. Even if I flash stock boot the bloat stays disabled.
 
  • Like
Reactions: ipdev

pndwal

Senior Member
Apparently Magisk 'repository owner' doesn't want GitHub members to offer any help / clarity after issues are closed without proper resolutions...
IMG_20220708_223501.jpg

https://github.com/topjohnwu/Magisk/issues/6072

This already closed issue was effectively killed within minutes of my comments. ☹️ PW
 
Apparently Magisk 'repository owner' doesn't want GitHub members to offer any help / clarity after issues are closed without proper resolutions...
View attachment 5654997
https://github.com/topjohnwu/Magisk/issues/6072

This already closed issue was effectively killed within minutes of my comments. ☹️ PW
Unfortunately, many many devs are like that, not just these. Don't know why, but they are.... This seems to be completely vvb2060 doing it because they didn't like being wrong.
 
  • Like
Reactions: rodken

pndwal

Senior Member
Unfortunately, many many devs are like that, not just these. Don't know why, but they are.... This seems to be completely vvb2060 doing it because they didn't like being wrong.
Not saying she's wrong... It's a fair response to a misleading issue description...

But I would like to see Devs (especially more than one LSP Dev) being more respectful of others' time / efforts, and also of users who battle w/ magiskbot & submit the same issue 5 times before getting it right and it's accepted... Bit frustrating for all involved, and has alienated a few...

And we do have some good l o n g s u f f e r i n g role models... Perhaps @osm0sis could make a pull request for a an internationally acceptable magisk-manners code for dev / modding community relations... 😜 🙃 PW
 
Last edited:

73sydney

Senior Member
Not saying she's wrong... It's a fair response to a misleading issue description...

But I would like to see Devs (especially more than one LSP Dev) being more respectful of others' time / efforts, and also of users who battle w/ magiskbot & submit the same issue 5 times before getting it right and it's accepted... Bit frustrating for all involved, and has alienated a few...

And we do have some good l o n g s u f f e r i n g role models... Perhaps @osm0sis could make a pull request for a an internationally acceptable magisk-manners code for dev / modding community relations... 😜 🙃 PW

Sadly not the 1st time the dev has gotten "spicy"

Really responses like "ignore it" to an issue are beyond less than helpful

And yes @osm0sis is a good egg, went to bat for me to get my feature request for magisk manager to stay on Install tab after local module install, upsold that one twice if my memory serves....
 
Sadly not the 1st time the dev has gotten "spicy"

Really responses like "ignore it" to an issue are beyond less than helpful

And yes @osm0sis is a good egg, went to bat for me to get my feature request for magisk manager to stay on Install tab after local module install, upsold that one twice if my memory serves....
My opinion is "ignore it" should be banned as a response, especially from a dev.
 
  • Like
Reactions: 73sydney

J.Michael

Recognized Contributor
Jan 20, 2018
1,317
1,251
Samsung Galaxy Tab A series
I interpreted "ignore it" as advice to the original poster to ignore the error messages. I couldn't follow the process well enough to tell if/where files were being copied, but I think the error message occurs when a copy is done with the "preserve permissions, time, owner" flag, and the destination filesystem does not support one or more of those attributes.

I was more annoyed when the "response" to @pndwal's request for clarification was just a repeat of a section of the log.
 
  • Like
Reactions: rodken and 73sydney
I interpreted "ignore it" as advice to the original poster to ignore the error messages. I couldn't follow the process well enough to tell if/where files were being copied, but I think the error message occurs when a copy is done with the "preserve permissions, time, owner" flag, and the destination filesystem does not support one or more of those attributes.

I was more annoyed when the "response" to @pndwal's request for clarification was just a repeat of a section of the log.
The response should have been more of "this message can be safely ignored" instead. I also take issue with how they closed down the issue and locked it, because @pndwal was trying to help. Also take issue with how they hid his last comment.
 

BlueMan_86

Senior Member
Jul 2, 2015
84
14
Novi Sad
Is it possible that Magisk v25 bricked my device? I updated to latest miui rom Mi10T Pro, before that I used v24.. BUT, when I intalled v25, phone caused to bootloop, that is not strange at all, most weird thing is when I back my original boot.img, phone stuck in bootloop and that was it... My phone have "vbmeta" so I selected that option on install... What is going on there... How is posible that original boot.img want work and phone bricked...
Any ideas whats happened and what was causing that? Also I deleted magisk modules folder over TWRP, but nothing.. just dead bootloop... Thanks..
 

zgfg

Senior Member
Oct 10, 2016
7,804
5,216
Boot with that original boot.img but having Magisk v25 APPLICATION installed.

From Magisk app, chose Install (Magisk) - main window, on top, right; Select and Patch, navigate to the original boot img file, do not tick Recovery option; Let's go

When done, youl'll have the patched boot img (in Download folder)- from Fastboot or TWRP, flash to Boot (and do not play with vbmeta)

Reboot to Magisk

That's the way Magisk installation works on all Xiaomi devices, MIUI 10/11/12... (btw, I have two of them, and do it as above since 2019)

Try first that way. If it won't work,then bootloop could be due to the incompatible Magisk module that was not disabled (but that usually happens when you upgrade ROM, not Magisk like you). That can be also fixed, but try first as above
 

pndwal

Senior Member
Is it possible that Magisk v25 bricked my device? I updated to latest miui rom Mi10T Pro, before that I used v24.. BUT, when I intalled v25, phone caused to bootloop, that is not strange at all, most weird thing is when I back my original boot.img, phone stuck in bootloop and that was it... My phone have "vbmeta" so I selected that option on install...
I'm assuming you mean you did this:
  • (Optional) If your device has a separate vbmeta partition, you can patch the vbmeta partition with command:
    fastboot flash vbmeta --disable-verity --disable-verification vbmeta.img
What is going on there... How is posible that original boot.img want work and phone bricked...
Any ideas whats happened and what was causing that? Also I deleted magisk modules folder over TWRP, but nothing.. just dead bootloop... Thanks..
So likely your device needs AVB (Android verified boot) intact and you have disabled it by patching vbmeta to disable-verity & disable-verification...

Instructions don't say to do this; they simply say it's an option & you can...

I believe this method has been added for the relatively few devices, eg (perhaps only) those running custom kernels, that require disable-verity & disable-verification... My guess is that most modern stock ROMs will normally require working AVB...

Since you've patched vbmeta in addition to boot image, you'll need to restore this image from ROM package also... or can dirty flash complete ROM... PW
 
Last edited:

pndwal

Senior Member
Did a bit or playing with modern Magisk, and it seems we can no longer 'downgrade' the App to a version earlier than running Magisk daemon in 25100+...
Force app version not lower than daemon
vvb2060 authored and topjohnwu committed 22 days ago

So with Magisk 25101 loaded, there is no way I can downgrade the App to Stable 25100 (despite the binary being in sync), or run any earlier app (Including old Manager app) on my device. ☹️

Whether calling apk package from App by setting Channel to Stable (App not hidden), or by downloading this or earlier Apps (previous App uninstalled), all the packages will simply install the stub app which in turn prompts:
IMG_20220709_152209.jpg

and this always fails with never ending:
IMG_20220709_152237.jpg

until it is force-closed.

(I guess Build dynamic stub resource APK at runtimetopjohnwu and vvb2060 committed 17 days ago
or Fix app state, vvb2060 authored and topjohnwu committed 7 days ago
may fix some broken behaviour.)

At present, the only Magisk App I can seem to install successfully (w/ 25101 binaries loaded) is 25101!* ... This installs the full App (not stub) as expected.

... It seems we must at least remove root injection and do an initial re-flash again just to install synced Beta/Stable App, and that any other 'downgrade' is also precluded...

*Further, I've found I can no longer even install a CI App, even one later than my Canary build (these actually use the same last app version, ie. also 25101), from Actions (Continuous Integration test build) runs with 25101 Magisk binary installed! ☹️ ... Same behaviour as above... I'm guessing this is due to app signature checks.

If anyone wants to try, or is able to downgrade the Magisk App from current Canary or Debug to Stable, or to upgrade this to a CI build w/o restoring unpatched images (removing root), please report... I'll reward you with some happy faces... 😁 PW
 
Last edited:
  • Wow
Reactions: Fif_

pndwal

Senior Member

samhhmobil

Senior Member
May 25, 2017
440
224
Hamburg
Hi,

does somebody knows, how the german health insurance app "TK" does detect root?

My configuration:
LOS 19.1
Magisk 24.3 (app hidden),
Zygisk, Shamiko 0.5.1(115),
MagiskHidePropConfig is set,
Safetynet is passed! CTS is passed.
No TWRP folder.

What am I missing?

samhhmobil
 

Top Liked Posts

  • There are no posts matching your filters.
  • 7
    Can someone either provide actual proof that zygisk/shamiko etc does anything to GPS (i havent had a single issue and i use it daily) or i dunno, maybe stop spreading FUD because of personal gripes you have against people on other platforms that dont take part here, and therefore wont get any of the swipes youre taking at them here that only further add to the aforementioned FUD.

    We've all had our moments with those folk and its fine to mention the odd bit of spice you may come across when trying to submit an issue on github (ive done this myself), but to then to continually poison magisk proper/shamiko because of that person/persons taking part is not helping anyone. Thats a personal gripe, and shouldnt colour the entire magisk (proper) project/shamiko. What we dont need is spice here....

    Please, you know who you are...

    I think we've all had enough, now
    5
    How does PixelFlasher invoke boot_patch.sh?
    Does it invoke it as an "executable", creating a new process? Or does it "source" it, so changes to the environment will survive?

    Does PixelFlasher create an environment variable named "SHA1"?

    My copy of boot_patch.sh has a compound statement that tests whether SHA1 has a non-zero length value before setting it to the sha1 of the boot image. If the environment variable is already set, it will not be overwritten. I don't know why.
    I wouldn't source. The script is supposed to be called as an executable

    Eg, my following code is rather primitive but it dumps the active Boot partition (it supports A/B and non-A/B devices), then it patches by invoking the boot_patch.sh script, finally it dumps back to the Boot partition and automatically reboots

    Ie, it updates me the Magisk and it also leaves me the patched-boot img in the Download folder

    Code:
    #!/system/bin/sh
    
    # Boot partition
    AB=$(getprop ro.boot.slot_suffix)
    BOOT_PART=/dev/block/bootdevice/by-name/boot"$AB"
    
    # Boot and patched boot images
    DOWNLOAD=/sdcard/Download/
    BOOT_IMG="$DOWNLOAD"boot.img
    PATCHED_BOOT_IMG="$DOWNLOAD"patched-boot.img
    
    # Magisk path
    MAGISK_PATH=/data/adb/magisk/
    
    # Disk-dump boot image to Download folder
    dd if="$BOOT_PART" of="$BOOT_IMG"
    
    # Patch the boot image and move to Download folder
    "$MAGISK_PATH"boot_patch.sh "$BOOT_IMG"
    mv "$MAGISK_PATH"new-boot.img "$PATCHED_BOOT_IMG"
    
    # Flash the patched boot image
    dd if="$PATCHED_BOOT_IMG" of="$BOOT_PART"
    
    # Reboot
    reboot
    5
    Installing on Samsung S7 (SM-G930F) with /e/OS?
    Okay folks, thought I'd post up the procedure:
    1. Follow these instructions until you get to 7th bullet point here;
    2. Stop. Some points to mention on the way:
      1. Note my progress above from 'Preliminaries' until point 5, adb pull /sdcard/Download/magisk_patched_[random_strings].img works just fine;
      2. Ignore my rambling queries up to point 5;
    3. Install heimdall;
    4. Boot device into 'Download' mode without USB cable connected, then once in 'Download' mode insert USB cable (this seemed important as I ran into quite a lot of ERROR: Protocol initialisation failed! type errors which seemed possibly cable/ hardware related);
    5. Bash:
      $ heimdall detect
      Device detected
      $ heimdall print-pit --no-reboot > print-pit.txt
    6. From print-pit.txt discover:
      ...
      --- Entry #10 ---
      Binary Type: 0 (AP)
      Device Type: 8 (Unknown)
      Identifier: 5
      Attributes: 5 (Read/Write)
      Update Attributes: 1 (FOTA)
      Partition Block Size/Offset: 10240
      Partition Block Count: 10240
      File Offset (Obsolete): 0
      File Size (Obsolete): 0
      Partition Name: BOOT
      Flash Filename: boot.img
      FOTA Filename:
      ...
    7. Reboot into 'Download' mode (this rebooting also seemed to help prevent the above errors);
    8. Bash:
      $ heimdall detect
      Device detected
      $
    9. Then, instead of fastboot flash boot /path/to/magisk_patched.img at the 7th bullet point here
      Do:

      Bash:
      $ heimdall flash --BOOT magisk_patched-25200_UjUVt.img
      Heimdall v1.4.2
      
      Copyright (c) 2010-2017 Benjamin Dobell, Glass Echidna
      http://www.glassechidna.com.au/
      
      This software is provided free of charge. Copying and redistribution is
      encouraged.
      
      If you appreciate this software and you would like to support future
      development please consider donating:
      http://www.glassechidna.com.au/donate/
      
      Initialising connection...
      Detecting device...
      Claiming interface...
      Setting up interface...
      
      Initialising protocol...
      Protocol initialisation successful.
      
      Beginning session...
      
      Some devices may take up to 2 minutes to respond.
      Please be patient!
      
      Session begun.
      
      Downloading device's PIT file...
      PIT file download successful.
      
      Uploading BOOT
      100%
      BOOT upload successful
      
      Ending session...
      Rebooting device...
      Releasing device interface...
      
      $
    10. At which, the device reboots and:
      Screenshot_20220927-133842_Magisk.png
    11. Happiness :)
    5
    I'm using the systemless debloater module to degoogle and debloat a device (and several other magisk modules to assist in that endeavor). I'd really like to be able to do a factory reset to clear the device of any data/artifacts from the debloated apps, but of course a factory reset wipes out magisk modules, so I'm in a catch 22.
    You can do some cleaning like this:

    - Wipe (from TWRP or by root explorer like MiXPlorer)
    /data/dalwik-cache
    /data/system/package_cache

    -In MiXPlorer, go to three dots, Tools and clean by App Remnants

    -Install SD Maid:
    And clean by CorpsFinder option
  • 1085
    This is the place for general support and discussion regarding "Public Releases", which includes both stable and beta releases.
    All information, including troubleshoot guides and notes, are in the Announcement Thread
    156
    Hello, I haven't given much support on XDA lately. It can be resulted from
    • University started and I have limited free time. In fact, I mostly develop during midnight
    • I live in Taiwan, which has large time zone differences between my European/American contributors/testers, which usually forces me to stay up late at night to discuss/test stuffs.
    • The new version is about to come, I don't want to spend effort on supporting old releases
    The planned update is delayed again and again, to some point I think I'll shed some light about what has been happening lately, also along with some announcements.

    New Forum!
    As you might have already discovered, Magisk got its own subforum on XDA! Many thanks to all the support you gave me, and much more information/features/support is about to come!
    **For developers supporting all the devices that are not using standard Android boot format, feel free to create threads in this section (actually, PLEASE do so) for your favorite devices after v7 is out. As I currently know, Asus devices require signing the boot image before flashing, and is model dependant; Sony devices seems to use ELF kernel that is unpatchable, or some has two ramdisks (inner + outer), both requires different workarounds; LG bootloader locked devices has to manually "BUMP" the boot image after flashing Magisk..... and there may be lots of other crazy boot image formats that haven't come up to my attention yet.
    It is impossible for me to support all these non-standard boot images, and I hope the community can collaborate to make Magisk running across all the devices. Overall, community collaboration is what XDA about :D

    The Pixel Phone
    Some of you might already know this news, that the next Pixel Phone right around the corner seems like it does not have ramdisk in boot image, which pretty much wrecked Magisk in all ways. However, it pretty much doomed root itself too. Kernel modifications is inevitable IMO, so I'll try to migrate my scripts to C programs that could possibly be included into the kernel itself. Note that I'm not familiar with linux kernel, I'm not even sure if my idea and concept is correct or not. But once the device is available, I think developers will find a way to bypass all the difficulties, and I'll do my best to learn things ;)

    Current Progress
    In the past month, I've spent quite some time learning SELinux, so that I can avoid using SuperSU's sepolicy patches. Thanks to the helps and tips from @phhusson and @Chainfire, I finally have a much clearer understanding of how SELinux works. The Magisk core parts (the scripts, boot image patches, new features, more supports) are actually done some time ago. What is causing all the delays is the Magisk Manager.
    To be completely honest, although I can code in Java without much issues, Magisk Manager is actually my first Android application, I had to reach out for assistance, and fortunately awesome developers like @DVDandroid and @digitalhigh contributed a lot, which makes the current Manager awesome.
    After the repo system and module management is mostly done, I was about to do some adjustments and release, but what we really done is decided to add another feature: auto-unroot with per-app settings. I decided to wait for it to be finished, and then do my adjustments. Due to reasons that'll be mentioned later, this feature will likely not be available for the next release (should come in future updates)

    Safety Net Disaster
    Those who are using Magisk for Safety Net bypass purposes must have known that Google recently updated the detection method of my Systemless Xposed. I still have no idea what Safety Net is detecting, so currently I cannot fix it on my side (also because I'm busy working on the next update). However, suhide developed by @Chainfire is able to hide Xposed and worked fine.
    However, only my Systemless Xposed v86.2, which is based on SuperSU's su.d, is supported using that method. v86.2 and v86.5 (latest, Magisk based) have nearly identical binaries, and the only difference is the path where the binaries are stored.
    I'm still not sure what's the real issue for it not being supported, I just hope it is not done intentionally.

    Conclusion
    Due to the fact that my Safety Net bypass is not 100% perfect now, I do not want to spend any more time waiting for auto-unroot to be polished. What I'm doing now is finishing up all the things I'd like to change in Magisk Manager (it has been a while since I last contributed to Manager, my fellow developers are doing all the heavy job), which might take a little more time, after that, packed with tons of information to be announced in Magisk Section, I'll release the long awaited update.

    Hope this lengthy post gives you the idea of the whole situation, and again thanks for all your support!!
    121
    Ah, some Chainfire bashing, I hope it is not too late for me to exercise additional villainy.

    First, let me make clear I have nothing against @topjohnwu, nor against Magisk. Magisk is an interesting project and it certainly displays @topjohnwu ingenuity and persistence. I don't doubt we will see more interesting things from his hands.

    -------------------------

    What has happened here is not all that dark and complicated, from either end. I returned from holidays, and someone pointed me at Magisk. My first thought: interesting!

    Among other things, the thread lists some issues with SuperSU, which in combination with the phrase The developer also requests users to not bug Chainfire with compatibility requests for SuperSU with Magisk from the portal article, raised my left eyebrow by nigh half an inch. The popular systemless xposed mod is apparently now based on it, and apparently it now no longer works with SuperSU, and apparently I'm not supposed to fix that, nor any of the other found issues. I found that a bit weird. So yes, I have told @topjohnwu that I was a bit surprised he was posting about issues with SuperSU without notifying me about them (I can't fix or help fix issues I'm not aware of, after all).

    He's also spreading a modified version of the SuperSU package, which is not all that uncommon, nor necessarily a problem. I have not looked into what he modified, I only ran a few quick tests on one of my devices, and found some commonly used commands run as root to be broken. I have informed him of this as well.

    It appears the tool of choice for Magisk is phh's Superuser, because of some of the mentioned issues with SuperSU. That's fine by itself, but fixing issues in that superuser by incorporating SuperSU's binaries into it is a somewhat questionable practise. After all, SuperSU is a commercial closed-source package that helps pay for my dinner, and superuser is a direct competitor. I have informed him that I was surprised he did this without asking for permission. I have expressed similar surprise on him spreading a modified version of LiveBoot (which helps pay for a snack now and then).
    @topjohnwu has also stated that Magisk's scripts are largely influenced by mine (I have not checked). Scripts based on mine are used all over the place on XDA, some people have crafted amazing things based on them, I have never made an issue of this (otherwise I would have just made them binaries). But yes, I have also stated to him that I don't think it's very nice to base something on one program, and then using that to (almost exclusively) push something directly competing with that program.

    tl;dr Towards @topjohnwu, I have:
    - expressed surprise he has issues getting Magisk to work with SuperSU, and has chosen not to inform me about those
    - expressed surprise he is using SuperSU binaries in a competing superuser without permission
    - expressed surprise he is posting a modified LiveBoot without permission
    - informed him of issues with the modified SuperSU he has posted
    - let him know I thought it wasn't very nice to be applying my scripts to benefit seemingly exclusively that same competing superuser

    To be crystal clear:
    - I have not asked for an apology
    - I have not asked for Magisk to be abandoned, neither the root hiding nor systemless module parts, and certainly not systemless xposed
    - I have not made an issue of any of this anywhere, until this post
    - I have not even specifically asked for anything to be taken down (though obviously in my opinion the other superuser package mixed with SuperSU's binaries, as well as the LiveBoot package, should go)
    - I have not reported this thread to XDA moderators for copyright violations or otherwise

    While my conversation with @topjohnwu may not win any awards for being friendly (though it may win some for brevity), I think all things considered my response has been rather mild. To be perfectly honest, until the apology post, I thought this was over with already. I think the apology post was triggered because I haven't replied to his last PM for a while - I was in the zone, it happens.

    To emphasize again, I have nothing against @topjohnwu, Magisk, or systemless xposed, and it is certainly not my goal to see any of them go. If it can be made to work together with SuperSU, great.

    I get it though: you think of something, you want to see if you can make it work, you finally get it to work, you publish it, it takes off - enthusiasm gets the better of you. Maybe in the rush some mistakes are made. That doesn't mean you have to just drop it and run. None of my stuff would make it past 0.1 if I stopped at the first big mistake :)

    Aside from said being in the zone coding, I usually regret actually responding to these sort of things the day after, which has made me hesitant to reply. Surprise me.
    76
    Thread temporarily closed so everyone sees this.

    The flood of "SafetyNet isn't working for me either!" posts are not helpful, at all. Please refrain from posting further, it will be looked into. Please do not forget that not passing SafetyNet is 100% NORMAL AND INTENDED when you have an unlocked booloader or running custom firmware. These are workarounds and they will be worked around in turn.

    The Flash
    Forum Moderator

    EDIT: Thread is reopened... I will be cleaning any SafetyNet posts for a while to keep the thread clean for real issues.
    75
    Hello everyone!

    I am aware that Google has updated Safety Net that makes Magisk itself a no go for Android Pay. In fact, I witnessed the change live while I am developing the new magiskhide, which should hide all Magisk modules and Magisk installed root.

    Google is serious about Safety Net now, clearly hunting down all possibility to run Xposed with Safety Net passed. I spend quite some time examining the new security measures last midnight, and fortunately it seems that it is possible to run Magisk and root along with Safety Net if no Xposed is running. I'm glad I removed the old root toggle at the right time lol, that is no longer feasible with the latest detection.

    So stay tuned for the next update, it will come with bug fixes, along with the new magiskhide to bypass that Safety Net.

    Google, how will a few systemless mods do any harm :p:p