Magisk General Support / Discussion

Search This thread

pndwal

Senior Member
I'm so sorry, I'm trying to use the search function for this thread, but for some reason, I'm getting results from the whole forum.
I got Magisk 24.1 installed (App is 25.2). I'm updating to 25.2 (Direct install), reboot and everything is fine. For a few days.
Then network services stop working requiring a reboot to get back up and running. And in return Magisk is back to 24.1..
I've tried to disable all the modules before updating = no difference.
Maybe one of the modules needs to be removed?
Modules:
ARCore/playground Patcher 2.1
Busybox for Android NDK 1.34.1
CloudflareNDS4Magisk IPv6 2.6
Debloater (Terminal Emulator) 17.3.3
F-Droid Privileged Extension2021-07-21
Terminal Modifications 1.4.6
Universal SafetyNet Fix 3.3.1

Or is there some known issue I don't know of?
Is this OnePlus 7T? (2SI boot-type device).

I believe you'll find Magisk never successfully updated to 25.2 due to Magiskinit refactoring for 2SI which breaks Direct Install for many devices. (This has been deemed NOT a bug, but makes previous version patched images incompatible for re-patching w/ current magiskboot).

The solution for affected devices is simply to do initial patch (using unpatched boot image) and fastboot flash again...

Not sure about network issues, but it may be that something else is borked... Could be a module as mentioned, or could be something in Magisk config; deleting whole /data/adb directory before shutdown should fix this. - Magisk config incl. magisk.db will be rebuilt...

... I put a lot of information about the magiskinit refactoring here around June 23...

If you happen to use a custom kernel, you may have further issues due to this refactoring reverting verity disabling (AVB key/flag stripping); Check here:
https://forum.xda-developers.com/t/magisk-general-support-discussion.3432382/post-87134821

Please give more device / environment details if this doesn't apply/fix your issue... Without this, my diagnosis here is largely guesswork...

🤠 PW
 
Last edited:

IronTechmonkey

Recognized Contributor
Feb 12, 2013
8,736
13,847

I see that your other two posts are in the new threads you created for questions you have about Magisk. FYI, creating a new thread for questions like that will not necessarily attract the most people who know the answers because they will not be searching the threads. This thread here would be a good place to research and ask your question. I couldn't answer it but there are people around who might.
 
  • Like
Reactions: ipdev

13Sullo80

Member
Aug 6, 2022
9
2
I see that your other two posts are in the new threads you created for questions you have about Magisk. FYI, creating a new thread for questions like that will not necessarily attract the most people who know the answers because they will not be searching the threads. This thread here would be a good place to research and ask your question. I couldn't answer it but there are people around who might.
Thx. I did not know what is the best approach. I could not delete this. Sorry for the confusion.
 
  • Like
Reactions: IronTechmonkey

pndwal

Senior Member
I am not having success installing Magisk v25.2 on my Samsung Galaxy Tab S MT-800. This used to run Android 6.0 OS. I updated the OS to Android 7.0 Nougat. I have installed Magisk and followed the instructions to create a patched boot.img file. I have copied the patched file on my PC. I have ODIN on my PC and TWRP on Tab S.

i can get ADB to recognize my device but fastboot simply returns <waiting for device> on my PC.
Not a Sammy user, but I know many older Sammy devices had a fastboot mode (eg Galaxy Note 8, Kona)... However it seems many use their own Download (Odin) mode also; perhaps after updates(?)... Newer Sammy never had traditional fastboot mode.

So it could be a driver issue, but if Odin is working, that should work for Magisk. So should renaming Magisk .apk package to .zip and installing via recovery on legacy ramdisk devices at least.
Am assuming fastboot does not work with Samsung TAB S running Android 7 Nougat.

I tried flashing the patched boot.img via TWRP with no success.

Tried ODIN with no success :
AP: boot.img.tar (patched boot file)
Bit confusing... Did you patch discrete boot.img or whole AP binary?

Recommend you patch complete AP (transfer using ADB pull, NOT MTP), then reboot to download mode, open Odin and flash magisk_patched.tar as AP, together with whatever binaries you have of BL, CP, and HOME_CSC. - I'm guessing you won't have them all on your older device. Nb. If you use CSC instead of HOME_CSC, you'll fully wipe/data.
ODIN ran successfully.

Reboot and open Magisk i still see the following:
Magisk
Installed N/A
Zygisk: No
Ramdisk Yes
Nb if you previously had Magisk hidden (Hide the Magisk app), you may find new App simply can't see Magisk due to competing apps; check in device settings, Apps for old hidden app ('settings' or whatever you named it) and uninstall it if found...
App
Latest 25.2 (25200) (33)
Installed 25.2
Package com.topjohnwu.magisk

looking for guidance. I do not see the Superuser or any other capability available to hide root for apps.
Hope this helps... PW
 

13Sullo80

Member
Aug 6, 2022
9
2
Not a Sammy user, but I know many older Sammy devices had a fastboot mode (eg Galaxy Note 8, Kona)... However it seems many use their own Download (Odin) mode also; perhaps after updates(?)... Newer Sammy never had traditional fastboot mode.

So it could be a driver issue, but if Odin is working, that should work for Magisk. So should renaming Magisk .apk package to .zip and installing via recovery on legacy ramdisk devices at least.

Bit confusing... Did you patch discrete boot.img or whole AP binary?

Recommend you patch complete AP (transfer using ADB pull, NOT MTP), then reboot to download mode, open Odin and flash magisk_patched.tar as AP, together with whatever binaries you have of BL, CP, and HOME_CSC. - I'm guessing you won't have them all on your older device. Nb. If you use CSC instead of HOME_CSC, you'll fully wipe/data.

Nb if you previously had Magisk hidden (Hide the Magisk app), you may find new App simply can't see Magisk due to competing apps; check in device settings, Apps for old hidden app ('settings' or whatever you named it) and uninstall it if found...

Hope this helps... PW
Thx for the note. I never had Magisk on the tablet.

I just flashed boot.img. I also pulled the patched image via MTP vs ADB.

Given this is a custom OS. How do I pull AP BL and CP?

Steps:
1. Pull the patched boot.img via ADB
2. What else should I pull and the command I should use?
3. Flash using ODIN via download mode

Thx
Not a Sammy user, but I know many older Sammy devices had a fastboot mode (eg Galaxy Note 8, Kona)... However it seems many use their own Download (Odin) mode also; perhaps after updates(?)... Newer Sammy never had traditional fastboot mode.

So it could be a driver issue, but if Odin is working, that should work for Magisk. So should renaming Magisk .apk package to .zip and installing via recovery on legacy ramdisk devices at least.

Bit confusing... Did you patch discrete boot.img or whole AP binary?

Recommend you patch complete AP (transfer using ADB pull, NOT MTP), then reboot to download mode, open Odin and flash magisk_patched.tar as AP, together with whatever binaries you have of BL, CP, and HOME_CSC. - I'm guessing you won't have them all on your older device. Nb. If you use CSC instead of HOME_CSC, you'll fully wipe/data.

Nb if you previously had Magisk hidden (Hide the Magisk app), you may find new App simply can't see Magisk due to competing apps; check in device settings, Apps for old hidden app ('settings' or whatever you named it) and uninstall it if found...

Hope this helps... PW
thx for the details. I do not have Magisk installed on the tablet.

I pulled patched boot.img via MTP vs ADB. Will pull using ADB.

I renamed the patched boot.img as boot.img.tar and used ODIN. Looks like that was wrong as well.

I need help to pull the right files from tablet for BL AP and CP. can you please help with the right commands and what to pull using ADB.
 

pndwal

Senior Member
Thx for the note. I never had Magisk on the tablet.

I just flashed boot.img. I also pulled the patched image via MTP vs ADB.

Given this is a custom OS. How do I pull AP BL and CP?
I wasn't aware this is custom ROM... 🤪

If you have package with images rather than Samsung binaries I'm guessing these should be fine; Sammy users could give better advice, but I think Odin can flash images... (??)
Steps:
1. Pull the patched boot.img via ADB
2. What else should I pull and the command I should use?
3. Flash using ODIN via download mode

Thx
I believe it should work...
thx for the details. I do not have Magisk installed on the tablet.

I pulled patched boot.img via MTP vs ADB. Will pull using ADB.
MTP is usually ok for small (image) files AFAIK; large (AP binary etc) files are often corrupted...
I renamed the patched boot.img as boot.img.tar and used ODIN. Looks like that was wrong as well.
I think that's likely... Will it flash as an image?... This could well have been your issue...
I need help to pull the right files from tablet for BL AP and CP. can you please help with the right commands and what to pull using ADB.
No, if traditional zip ROM archive, I think you just patch / flash boot.img as mentioned...

Also, there's no reason you shouldn't rename .apk archive to .zip and flash in TWRP on your legacy ramdisk device... This should work fine up to Android 9 if updates become available. (If updated to A10, Legacy ramdisk devices are converted to 2SI and new patch/flash installation is then recommended)...

If none of this helps, please give custom ROM details... 🙃 PW
 

J.Michael

Recognized Contributor
Jan 20, 2018
1,314
1,246
Samsung Galaxy Tab A series
@13Sullo80 If you want to flash a single image file in Odin, I think you should make a tar archive containing that one image file. Renaming is not the way.

The AP, BL, CP, and CSC tar files are the way we've seen Samsung ROMs packaged. You won't find them on the phone.

How did you get this custom ROM? What assortment of files? How did you install it?

Installing a Magisk-patched system should follow the same pattern as the installation of the unpatched system.

Find the forum that deals with the ROM. And the forum that deals with the phone. If you are lucky, there is some overlap.
 

13Sullo80

Member
Aug 6, 2022
9
2
Not a Sammy user, but I know many older Sammy devices had a fastboot mode (eg Galaxy Note 8, Kona)... However it seems many use their own Download (Odin) mode also; perhaps after updates(?)... Newer Sammy never had traditional fastboot mode.

So it could be a driver issue, but if Odin is working, that should work for Magisk. So should renaming Magisk .apk package to .zip and installing via recovery on legacy ramdisk devices at least.

Bit confusing... Did you patch discrete boot.img or whole AP binary?

Recommend you patch complete AP (transfer using ADB pull, NOT MTP), then reboot to download mode, open Odin and flash magisk_patched.tar as AP, together with whatever binaries you have of BL, CP, and HOME_CSC. - I'm guessing you won't have them all on your older device. Nb. If you use CSC instead of HOME_CSC, you'll fully wipe/data.

Nb if you previously had Magisk hidden (Hide the Magisk app), you may find new App simply can't see Magisk due to competing apps; check in device settings, Apps for old hidden app ('settings' or whatever you named it) and uninstall it if found...

Hope this helps... PW
Thx for the note. I never had Magisk on the tablet.

I just flashed boot.img. I also pulled the patched image via MTP vs ADB.

Given this is a custom OS. How do I pull AP BL and CP?

Steps:
1. Pull the patched boot.img via ADB
2. What else should I pull and the command I should use?
3. Flash using ODIN via download mode

Thx
I wasn't aware this is custom ROM... 🤪

If you have package with images rather than Samsung binaries I'm guessing these should be fine; Sammy users could give better advice, but I think Odin can flash images... (??)

I believe it should work...

MTP is usually ok for small (image) files AFAIK; large (AP binary etc) files are often corrupted...

I think that's likely... Will it flash as an image?... This could well have been your issue...

No, if traditional zip ROM archive, I think you just patch / flash boot.img as mentioned...

Also, there's no reason you shouldn't rename .apk archive to .zip and flash in TWRP on your legacy ramdisk device... This should work fine up to Android 9 if updates become available. (If updated to A10, Legacy ramdisk devices are converted to 2SI and new patch/flash installation is then recommended)...

If none of this helps, please give custom ROM details... 🙃 PW
thx for all the help. I gave up on the custom OS.

Used TWRP to install LineageOS and Magisk. Now the app installs successfully.

Now on to figuring how to configure Magisk to ensure safetyNet passes.
 
  • Like
Reactions: pndwal

ipdev

Recognized Contributor
Feb 14, 2016
1,917
1
3,510
Google Nexus 10
Nexus 7 (2013)
@pndwal Have you ever seen an MTP transfer corrupt a file, or are you just repeating the advice I have seen elsewhere?

I always used Windows Explorer to transfer files. I checked the md5sum at both ends, never saw a mismatch.
Years ago, I had some corruption issue with MTP and a Kindle Fire 7(?) using MacOS.
Since then I have just used adb to push and pull using Linux, Mac, and Windows.

I might test the MTP connection for a device but, that is about it.
twrp-3.6.2_9-0
- MTP works.
- OTG works.

twrp-3.6.2_9-1
- MTP is broken.
- OTG works.

So it looks like the fix for adb sideload breaks MTP.

Cheers. :cowboy:
 
Last edited:

ipdev

Recognized Contributor
Feb 14, 2016
1,917
1
3,510
Google Nexus 10
Nexus 7 (2013)
@13Sullo80
Not a Sammy guy per say but, I have played with them though the years. 🙃
Most recently I found a SM-580 tablet for my brother a few months ago.

After wiping and updating it.
I unlocked it and used odin to install TWRP.

From there I used TWRP to install an unofficial lineage 19.1 and OpenGApps.
Once booted, I installed the Magisk app and patched the lineage boot image (pulled from the lineage zip file).

Rebooted into recovery (TWRP) and flashed the magisk_patched boot image.
Update Magisk by the direct install option.

When it is time for a ROM update..
- Pull the new boot image and patch it.
- Update rom and flash the new magisk patched boot image in TWRP.

Not sure if this works on newer Samsung or when running a stock Samsung rom.

What do you think @pndwal ?

Cheers. :cowboy:
 
Last edited:
  • Like
Reactions: 73sydney and pndwal

pndwal

Senior Member
@pndwal Have you ever seen an MTP transfer corrupt a file, or are you just repeating the advice I have seen elsewhere?

I always used Windows Explorer to transfer files. I checked the md5sum at both ends, never saw a mismatch.
Yes, I tried to help several (3?) members here who confirmed that various issues disappeared (sometimes corrupted image would flash, sometimes not) after using ADB pull... The first couple of times the members themselves found the fix; I hadn't thought of it...

I only know it's common w/ Sammy's large binaries however; don't recall similar reports for other devices. 😉 PW
 
Last edited:
  • Like
Reactions: J.Michael and ipdev

ipdev

Recognized Contributor
Feb 14, 2016
1,917
1
3,510
Google Nexus 10
Nexus 7 (2013)
Shifting the discussion to this thread.
So whole a bit off topic, but kinda still on topic as I'm desperately trying to get this to work and refuse to give up...

I just discovered the app 'rootbeer sample'

View attachment 5679855
...is this an issue?=
Are you enforcing Magisk's Denylist or not enforcing and using a module like Shamiko to hide root?

Add RootBeer to Magisk's Denylist.
That should hide most (or all) from RootBeer.

If you are enforcing Magisk's denylist, there might be a few other processes that you will also need to add to the Denylist.

Cheers. :cowboy:
I've tried to both the module and enforce, same results.

We will need to know your setup to help more.
Pixel 6, stock Google (July) rooted with Magisk.
A personal snapshot build, normally a few commits ahead of canary.
Zygisk is active and Denylist is not enforcing.

Modules:
BusyBox
MagiskHide Props Config
Nano
Shamiko
Systemless Hosts
Universal SafetyNet Fix
Slightly modified (WIP) testing version.​
Zygisk - LSPosed

Cheers. :cowboy:

Edit:
Attach ScreenShots.
 

Attachments

  • Screenshot_20220807-162151.png
    Screenshot_20220807-162151.png
    142.3 KB · Views: 46
  • Screenshot_20220807-162313.png
    Screenshot_20220807-162313.png
    150.5 KB · Views: 43
  • Screenshot_20220807-162450.png
    Screenshot_20220807-162450.png
    162.5 KB · Views: 44
  • Screenshot_20220807-162535.png
    Screenshot_20220807-162535.png
    132.5 KB · Views: 42
  • Screenshot_20220807-162133.png
    Screenshot_20220807-162133.png
    132.2 KB · Views: 38
  • Screenshot_20220807-162216.png
    Screenshot_20220807-162216.png
    187.8 KB · Views: 40
  • Screenshot_20220807-162225.png
    Screenshot_20220807-162225.png
    188.9 KB · Views: 39
  • Screenshot_20220807-162251.png
    Screenshot_20220807-162251.png
    54.4 KB · Views: 38
  • Screenshot_20220807-162330.png
    Screenshot_20220807-162330.png
    123.8 KB · Views: 41
  • Screenshot_20220807-162357.png
    Screenshot_20220807-162357.png
    186.7 KB · Views: 39
  • Screenshot_20220807-162519.png
    Screenshot_20220807-162519.png
    122.6 KB · Views: 47
Last edited:
  • Like
Reactions: Eng.Raman

13Sullo80

Member
Aug 6, 2022
9
2
Yes, I tried to help several (3?) members here who confirmed that various issues disappeared (sometimes corrupted image would flash, sometimes not) after using ADB pull... The first couple of times the members themselves found the fix; I hadn't thought of it... I only know it's common w/ Sammy's large binaries however; don't recall similar reports for other devices. 😉 PW
My next area of help is safetyNet failure with LineageOS 14.1 ROM

1. Have Magisk setup and hidden
2. Have downloaded UniversalSafetyNet fix and it shows under modules in Magisk
3. YASNAC fails Basic Integrity and CTS checks.

Have reviewed the posts but not able to fix. Is this ROM so old that I cannot get it to pass?
 

pndwal

Senior Member
Last edited:
  • Like
Reactions: ipdev

pndwal

Senior Member
My next area of help is safetyNet failure with LineageOS 14.1 ROM

1. Have Magisk setup and hidden
2. Have downloaded UniversalSafetyNet fix and it shows under modules in Magisk
3. YASNAC fails Basic Integrity and CTS checks.

Have reviewed the posts but not able to fix. Is this ROM so old that I cannot get it to pass?
Search in USNF thread for USNF mod from @Displax and install it... Is spoofs a very old fingerprint that should kill two birds; 1) need for fingerprint / security patch date matching in custom and other uncertified ROMs (always in official LOS due to their policy not to alter expected signals), and 2) new Play Integrity MEETS_DEVICE_INTEGRITY failure.

Traditional solution for CTS Profile match in official LOS etc was to configure a passing fingerprint/patch date combination using MHPC module, but this shouldn't be needed w/ @Displax modded USNF... PW
 
  • Like
Reactions: J.Michael and ipdev

pndwal

Senior Member
Years ago, I had some corruption issue with MTP and a Kindle Fire 7(?) using MacOS.
Since then I have just used adb to push and pull using Linux, Mac, and Windows.

I might test the MTP connection for a device but, that is about it.
Ahh!
twrp-3.6.2_9-0
- MTP works.
- OTG works.

twrp-3.6.2_9-1
- MTP is broken.
- OTG works.

So it looks like the fix for adb sideload breaks MTP.
So ..9-1 fixed adb?... (It isn't self-evident). PW
 
  • Like
Reactions: ipdev

pndwal

Senior Member
@13Sullo80
Not a Sammy guy per say but, I have played with them though the years. 🙃
Most recently I found a SM-580 tablet for my brother a few months ago.

After wiping and updating it.
I unlocked it and used odin to install TWRP.

From there I used TWRP to install an unofficial lineage 19.1 and OpenGApps.
Once booted, I installed the Magisk app and patched the lineage boot image (pulled from the lineage zip file).

Rebooted into recovery (TWRP) and flashed the magisk_patched boot image.
Update Magisk by the direct install option.

When it is time for a ROM update..
- Pull the new boot image and patch it.
- Update rom and flash the new magisk patched boot image in TWRP.

Not sure if this works on newer Samsung or when running a stock Samsung rom.

What do you think @pndwal ?

Cheers. :cowboy:
Looks good to me... I'm a bumbling advisor... Only ever owned one (old) Sammy...

Not sure (guessing all the way actually) about newer devices either (especially where patching of other partitions is done and other caveats discussed by John apply), but I think your advice is pretty safe for Android 7 etc. 😛 PW
 
  • Like
Reactions: ipdev

ipdev

Recognized Contributor
Feb 14, 2016
1,917
1
3,510
Google Nexus 10
Nexus 7 (2013)
Ahh!

So ..9-1 fixed adb?... (It isn't self-evident). PW
OT for this thread but..
The update to TWRP 3.6.2 broke adb sideload and partitions formatted with fastboot were not recognized by TWRP, when using newer/current versions of Platform Tools.
The fix (9-1) for adb sideload (using newer builds of Platform Tools) was a revert of a previous commit.
Can you please test if MTP works ?

Remember some issues .. and the reason for changing the USB product / vendor ID in recovery at this time.
The revert fixed adb sideload but broke MTP. 😥
So currently, we have to use older adb/fastboot builds to be compatible with TWRP 3.6.2.
Note:
Platform-Tools r27.0.1 (December 2017) seemed to be the safest to use at the moment.
You can download an older release of platform-tools by adjusting the official download link to the release you want.

Cheers. :cowboy:
 
Last edited:
  • Like
Reactions: rodken and pndwal

Top Liked Posts

  • 4
    Installing on Samsung S7 (SM-G930F) with /e/OS?
    Okay folks, thought I'd post up the procedure:
    1. Follow these instructions until you get to 7th bullet point here;
    2. Stop. Some points to mention on the way:
      1. Note my progress above from 'Preliminaries' until point 5, adb pull /sdcard/Download/magisk_patched_[random_strings].img works just fine;
      2. Ignore my rambling queries up to point 5;
    3. Install heimdall;
    4. Boot device into 'Download' mode without USB cable connected, then once in 'Download' mode insert USB cable (this seemed important as I ran into quite a lot of ERROR: Protocol initialisation failed! type errors which seemed possibly cable/ hardware related);
    5. Bash:
      $ heimdall detect
      Device detected
      $ heimdall print-pit --no-reboot > print-pit.txt
    6. From print-pit.txt discover:
      ...
      --- Entry #10 ---
      Binary Type: 0 (AP)
      Device Type: 8 (Unknown)
      Identifier: 5
      Attributes: 5 (Read/Write)
      Update Attributes: 1 (FOTA)
      Partition Block Size/Offset: 10240
      Partition Block Count: 10240
      File Offset (Obsolete): 0
      File Size (Obsolete): 0
      Partition Name: BOOT
      Flash Filename: boot.img
      FOTA Filename:
      ...
    7. Reboot into 'Download' mode (this rebooting also seemed to help prevent the above errors);
    8. Bash:
      $ heimdall detect
      Device detected
      $
    9. Then, instead of fastboot flash boot /path/to/magisk_patched.img at the 7th bullet point here
      Do:

      Bash:
      $ heimdall flash --BOOT magisk_patched-25200_UjUVt.img
      Heimdall v1.4.2
      
      Copyright (c) 2010-2017 Benjamin Dobell, Glass Echidna
      http://www.glassechidna.com.au/
      
      This software is provided free of charge. Copying and redistribution is
      encouraged.
      
      If you appreciate this software and you would like to support future
      development please consider donating:
      http://www.glassechidna.com.au/donate/
      
      Initialising connection...
      Detecting device...
      Claiming interface...
      Setting up interface...
      
      Initialising protocol...
      Protocol initialisation successful.
      
      Beginning session...
      
      Some devices may take up to 2 minutes to respond.
      Please be patient!
      
      Session begun.
      
      Downloading device's PIT file...
      PIT file download successful.
      
      Uploading BOOT
      100%
      BOOT upload successful
      
      Ending session...
      Rebooting device...
      Releasing device interface...
      
      $
    10. At which, the device reboots and:
      Screenshot_20220927-133842_Magisk.png
    11. Happiness :)
    3
    Okay folks, thought I'd post up the procedure...

    ...Happiness :)
    See theres that faffing about that i said made me avoid heimdall for my entire Android career :)
    ... And what a career!
    @pndwal, tell him what he's won.....
    He won! ... And made Gaël Duval proud!...

    He'll be the /e/nvy of all if he can get S/N & PI verdicts passing with that! 🤪

    Thing I'm most intrigued by is Zygisk = Yes on Galaxy S7!...

    Last I knew this shouldn't work as the S7 pre 3.19 (3.18.91) Kernel had the the exec limitation (when exec an ELF from /proc the process can no longer call some systemcalls)...
    - https://github.com/topjohnwu/Magisk/issues/5395#issuecomment-1073746347
    - https://github.com/topjohnwu/Magisk/issues/5339#issuecomment-1031010036
    - https://github.com/topjohnwu/Magisk/issues/5339#issuecomment-1031095243

    Now I see this was fixed in LOS 18.1+ using 3.18.140 kernel...
    - https://github.com/topjohnwu/Magisk/issues/5395#issuecomment-1073746347

    Of course /e/ OS derives from LOS...

    Guess this kernel may be available for stock S7 users, or ported to a compatible boot.img...

    At least S7 users can move to Lineage OS or /e/ OS to get Zygisk working... 😛 PW

    PS. Your steak knives!
    🔪
    🔪🔪
    🔪🔪🔪
    🔪🔪🔪🔪
    2
    But unfortunately the error remained even after installing the module

    Okay you only need one Busybox module, so disable (or uninstall) one of them

    Also you should install this module (if you havent already)


    and (almost certainly/usually) disable MagiskHide Props Config unless theres a specific reason you need it enabled

    Also i havent tested Deny List Unmount in a while, but Shamiko is an alternative (disable Enforce Deny List in Magisk -> Settings if you try this - making sure to disable DenyList Unmount first)


    and make sure you reboot after making any such changes

    theres a lot of modules for basic root hiding that do similar things (sometimes in different ways), but you cant have them all installed or active at once....so you have to pick 1 or the other


    you should probably also follow this thread, as its newer than the (legacy) magisk thread we're currently in, plus it also will have links to all the modules and latest info in the opening few posts:

    2
    I am from Ukraine and do not know English well, so I communicate through an interpreter and it makes it a lot harder to find information

    I understand completely, i have to use Firefox Addon to translate some russian android sites all the time, so something like this may make things easier, you can use it to translate an entire page or from a highlighted section of text via the right click menu


    And without getting too political (actually impossible not to) as a former infantry soldier, know theres plenty of us here in Australia would come to help if we could. The Ukrainian people have really shown their courage and determination, and may there be peace for you soon.
    2
    Who can tell me how to fix these errors?

    @zgfg has covered this before

    and using search terms Hide My Applist or HMA would have gotten you here with a little clicking


    you can get a 100% pass on all but Momo (we tend to ignore it, if not call it pointless or worse here) but doing as suggested - create a blacklist with root and lsposed/xposed modules, and then apply it to any "detector" apps. also important is to force stop, then clear data on those detector apps before testing again each time as they can cache previous results....failure to do this last step can send you in hours of circular disappointment :)
  • 7
    Can someone either provide actual proof that zygisk/shamiko etc does anything to GPS (i havent had a single issue and i use it daily) or i dunno, maybe stop spreading FUD because of personal gripes you have against people on other platforms that dont take part here, and therefore wont get any of the swipes youre taking at them here that only further add to the aforementioned FUD.

    We've all had our moments with those folk and its fine to mention the odd bit of spice you may come across when trying to submit an issue on github (ive done this myself), but to then to continually poison magisk proper/shamiko because of that person/persons taking part is not helping anyone. Thats a personal gripe, and shouldnt colour the entire magisk (proper) project/shamiko. What we dont need is spice here....

    Please, you know who you are...

    I think we've all had enough, now
    5
    I'm using the systemless debloater module to degoogle and debloat a device (and several other magisk modules to assist in that endeavor). I'd really like to be able to do a factory reset to clear the device of any data/artifacts from the debloated apps, but of course a factory reset wipes out magisk modules, so I'm in a catch 22.
    You can do some cleaning like this:

    - Wipe (from TWRP or by root explorer like MiXPlorer)
    /data/dalwik-cache
    /data/system/package_cache

    -In MiXPlorer, go to three dots, Tools and clean by App Remnants

    -Install SD Maid:
    And clean by CorpsFinder option
    5
    How does PixelFlasher invoke boot_patch.sh?
    Does it invoke it as an "executable", creating a new process? Or does it "source" it, so changes to the environment will survive?

    Does PixelFlasher create an environment variable named "SHA1"?

    My copy of boot_patch.sh has a compound statement that tests whether SHA1 has a non-zero length value before setting it to the sha1 of the boot image. If the environment variable is already set, it will not be overwritten. I don't know why.
    I wouldn't source. The script is supposed to be called as an executable

    Eg, my following code is rather primitive but it dumps the active Boot partition (it supports A/B and non-A/B devices), then it patches by invoking the boot_patch.sh script, finally it dumps back to the Boot partition and automatically reboots

    Ie, it updates me the Magisk and it also leaves me the patched-boot img in the Download folder

    Code:
    #!/system/bin/sh
    
    # Boot partition
    AB=$(getprop ro.boot.slot_suffix)
    BOOT_PART=/dev/block/bootdevice/by-name/boot"$AB"
    
    # Boot and patched boot images
    DOWNLOAD=/sdcard/Download/
    BOOT_IMG="$DOWNLOAD"boot.img
    PATCHED_BOOT_IMG="$DOWNLOAD"patched-boot.img
    
    # Magisk path
    MAGISK_PATH=/data/adb/magisk/
    
    # Disk-dump boot image to Download folder
    dd if="$BOOT_PART" of="$BOOT_IMG"
    
    # Patch the boot image and move to Download folder
    "$MAGISK_PATH"boot_patch.sh "$BOOT_IMG"
    mv "$MAGISK_PATH"new-boot.img "$PATCHED_BOOT_IMG"
    
    # Flash the patched boot image
    dd if="$PATCHED_BOOT_IMG" of="$BOOT_PART"
    
    # Reboot
    reboot
    5
    I'm sorry I didn't realize that.

    I've been so used to generic steps (boot recovery -> flash recovery -> reboot recovery -> wipe all -> flash firmware -> flash ROM -> flash GApps -> flash dm-verity disabler -> boot system -> boot recovery -> flash Magisk -> flash *Posed) that I didn't bother checking if steps have changed.

    Therefore, neither.

    Honestly I think it's too bad that we can't just flash ZIPs anymore, that was so easy.

    Anyway, thank you for your response.
    For everyone, a bit of

    Insight into Custom Recovery installation method Depreciation:

    Yup... Method was fine for old legacy ramdisk booting devices, but does rely on custom recovery compatibility, and John ended up fielding the TWRP issues; plenty from official TWRP builds not to mention broken unofficial ones... Then Dees Troy needed to attend to real life and Team Win simply couldn't adapt to Google's ever changing system architecture, boot methods etc fast enough and lagged way behind Magisk. (See John's Android Booting Shenanigans)...

    This precipitated the move to an installation solution that doesn't rely on other custom development, but wasn't the only practical consideration; 'Manager' and now 'App' patching w/ fastboot (etc) flashing meant owners of
    devices with no custom recovery can start rooting and do further modification
    https://forum.xda-developers.com/t/magisk-the-magic-mask-for-android.3473445/post-72587983
    and users can also preserve stock recovery to apply OTAs etc... Thus 'Magisk Manual Injection' was born...

    Next, support was added for patching Samsung AP firmware which recovery/zip installation couldn't achieve. Then with Project Treble came efforts to
    update Magisk to be modular and adaptive to follow Google's Pixel concept... modding a device has changed completely. I am a strong advocate of these new changes, praising the effort Google has put into designing such weird but fascinating setup despite many view this as "moves against developers".

    With the announcement of Project Treble, all devices will go through the same "Pixel-ize" treatment, so this future is inevitable. Project Treble is all about "modular", and Magisk has been rewritten to embrace this concept. I have spent extra effort to backport the changes made requires to run on these new modern devices to downward support all devices, so we do not need 2 drastically different installation methods...
    https://forum.xda-developers.com/t/magisk-the-magic-mask-for-android.3473445/post-74961572
    ... and then 'recovery mode' support for many A-only legacy SAR devices (A9 / 2018) w/ ramdisk only in recovery partition (again not supported by recovery/zip installation)... And it is now noted:
    This installation method is deprecated and is maintained with minimum effort. YOU HAVE BEEN WARNED!

    Installing using custom recoveries is only possible if your device has boot ramdisk.

    Installing Magisk through custom recoveries on modern devices is no longer recommended. If you face any issues, please use the proper Patch Image method.
    ...

    Note that even (old) legacy ramdisk boot-type devices are to be considered 'modern' once running Android 10+ as they are automatically converted to current 2SI "SAR" boot-type!...

    👀 PW
  • 1085
    This is the place for general support and discussion regarding "Public Releases", which includes both stable and beta releases.
    All information, including troubleshoot guides and notes, are in the Announcement Thread
    156
    Hello, I haven't given much support on XDA lately. It can be resulted from
    • University started and I have limited free time. In fact, I mostly develop during midnight
    • I live in Taiwan, which has large time zone differences between my European/American contributors/testers, which usually forces me to stay up late at night to discuss/test stuffs.
    • The new version is about to come, I don't want to spend effort on supporting old releases
    The planned update is delayed again and again, to some point I think I'll shed some light about what has been happening lately, also along with some announcements.

    New Forum!
    As you might have already discovered, Magisk got its own subforum on XDA! Many thanks to all the support you gave me, and much more information/features/support is about to come!
    **For developers supporting all the devices that are not using standard Android boot format, feel free to create threads in this section (actually, PLEASE do so) for your favorite devices after v7 is out. As I currently know, Asus devices require signing the boot image before flashing, and is model dependant; Sony devices seems to use ELF kernel that is unpatchable, or some has two ramdisks (inner + outer), both requires different workarounds; LG bootloader locked devices has to manually "BUMP" the boot image after flashing Magisk..... and there may be lots of other crazy boot image formats that haven't come up to my attention yet.
    It is impossible for me to support all these non-standard boot images, and I hope the community can collaborate to make Magisk running across all the devices. Overall, community collaboration is what XDA about :D

    The Pixel Phone
    Some of you might already know this news, that the next Pixel Phone right around the corner seems like it does not have ramdisk in boot image, which pretty much wrecked Magisk in all ways. However, it pretty much doomed root itself too. Kernel modifications is inevitable IMO, so I'll try to migrate my scripts to C programs that could possibly be included into the kernel itself. Note that I'm not familiar with linux kernel, I'm not even sure if my idea and concept is correct or not. But once the device is available, I think developers will find a way to bypass all the difficulties, and I'll do my best to learn things ;)

    Current Progress
    In the past month, I've spent quite some time learning SELinux, so that I can avoid using SuperSU's sepolicy patches. Thanks to the helps and tips from @phhusson and @Chainfire, I finally have a much clearer understanding of how SELinux works. The Magisk core parts (the scripts, boot image patches, new features, more supports) are actually done some time ago. What is causing all the delays is the Magisk Manager.
    To be completely honest, although I can code in Java without much issues, Magisk Manager is actually my first Android application, I had to reach out for assistance, and fortunately awesome developers like @DVDandroid and @digitalhigh contributed a lot, which makes the current Manager awesome.
    After the repo system and module management is mostly done, I was about to do some adjustments and release, but what we really done is decided to add another feature: auto-unroot with per-app settings. I decided to wait for it to be finished, and then do my adjustments. Due to reasons that'll be mentioned later, this feature will likely not be available for the next release (should come in future updates)

    Safety Net Disaster
    Those who are using Magisk for Safety Net bypass purposes must have known that Google recently updated the detection method of my Systemless Xposed. I still have no idea what Safety Net is detecting, so currently I cannot fix it on my side (also because I'm busy working on the next update). However, suhide developed by @Chainfire is able to hide Xposed and worked fine.
    However, only my Systemless Xposed v86.2, which is based on SuperSU's su.d, is supported using that method. v86.2 and v86.5 (latest, Magisk based) have nearly identical binaries, and the only difference is the path where the binaries are stored.
    I'm still not sure what's the real issue for it not being supported, I just hope it is not done intentionally.

    Conclusion
    Due to the fact that my Safety Net bypass is not 100% perfect now, I do not want to spend any more time waiting for auto-unroot to be polished. What I'm doing now is finishing up all the things I'd like to change in Magisk Manager (it has been a while since I last contributed to Manager, my fellow developers are doing all the heavy job), which might take a little more time, after that, packed with tons of information to be announced in Magisk Section, I'll release the long awaited update.

    Hope this lengthy post gives you the idea of the whole situation, and again thanks for all your support!!
    121
    Ah, some Chainfire bashing, I hope it is not too late for me to exercise additional villainy.

    First, let me make clear I have nothing against @topjohnwu, nor against Magisk. Magisk is an interesting project and it certainly displays @topjohnwu ingenuity and persistence. I don't doubt we will see more interesting things from his hands.

    -------------------------

    What has happened here is not all that dark and complicated, from either end. I returned from holidays, and someone pointed me at Magisk. My first thought: interesting!

    Among other things, the thread lists some issues with SuperSU, which in combination with the phrase The developer also requests users to not bug Chainfire with compatibility requests for SuperSU with Magisk from the portal article, raised my left eyebrow by nigh half an inch. The popular systemless xposed mod is apparently now based on it, and apparently it now no longer works with SuperSU, and apparently I'm not supposed to fix that, nor any of the other found issues. I found that a bit weird. So yes, I have told @topjohnwu that I was a bit surprised he was posting about issues with SuperSU without notifying me about them (I can't fix or help fix issues I'm not aware of, after all).

    He's also spreading a modified version of the SuperSU package, which is not all that uncommon, nor necessarily a problem. I have not looked into what he modified, I only ran a few quick tests on one of my devices, and found some commonly used commands run as root to be broken. I have informed him of this as well.

    It appears the tool of choice for Magisk is phh's Superuser, because of some of the mentioned issues with SuperSU. That's fine by itself, but fixing issues in that superuser by incorporating SuperSU's binaries into it is a somewhat questionable practise. After all, SuperSU is a commercial closed-source package that helps pay for my dinner, and superuser is a direct competitor. I have informed him that I was surprised he did this without asking for permission. I have expressed similar surprise on him spreading a modified version of LiveBoot (which helps pay for a snack now and then).
    @topjohnwu has also stated that Magisk's scripts are largely influenced by mine (I have not checked). Scripts based on mine are used all over the place on XDA, some people have crafted amazing things based on them, I have never made an issue of this (otherwise I would have just made them binaries). But yes, I have also stated to him that I don't think it's very nice to base something on one program, and then using that to (almost exclusively) push something directly competing with that program.

    tl;dr Towards @topjohnwu, I have:
    - expressed surprise he has issues getting Magisk to work with SuperSU, and has chosen not to inform me about those
    - expressed surprise he is using SuperSU binaries in a competing superuser without permission
    - expressed surprise he is posting a modified LiveBoot without permission
    - informed him of issues with the modified SuperSU he has posted
    - let him know I thought it wasn't very nice to be applying my scripts to benefit seemingly exclusively that same competing superuser

    To be crystal clear:
    - I have not asked for an apology
    - I have not asked for Magisk to be abandoned, neither the root hiding nor systemless module parts, and certainly not systemless xposed
    - I have not made an issue of any of this anywhere, until this post
    - I have not even specifically asked for anything to be taken down (though obviously in my opinion the other superuser package mixed with SuperSU's binaries, as well as the LiveBoot package, should go)
    - I have not reported this thread to XDA moderators for copyright violations or otherwise

    While my conversation with @topjohnwu may not win any awards for being friendly (though it may win some for brevity), I think all things considered my response has been rather mild. To be perfectly honest, until the apology post, I thought this was over with already. I think the apology post was triggered because I haven't replied to his last PM for a while - I was in the zone, it happens.

    To emphasize again, I have nothing against @topjohnwu, Magisk, or systemless xposed, and it is certainly not my goal to see any of them go. If it can be made to work together with SuperSU, great.

    I get it though: you think of something, you want to see if you can make it work, you finally get it to work, you publish it, it takes off - enthusiasm gets the better of you. Maybe in the rush some mistakes are made. That doesn't mean you have to just drop it and run. None of my stuff would make it past 0.1 if I stopped at the first big mistake :)

    Aside from said being in the zone coding, I usually regret actually responding to these sort of things the day after, which has made me hesitant to reply. Surprise me.
    76
    Thread temporarily closed so everyone sees this.

    The flood of "SafetyNet isn't working for me either!" posts are not helpful, at all. Please refrain from posting further, it will be looked into. Please do not forget that not passing SafetyNet is 100% NORMAL AND INTENDED when you have an unlocked booloader or running custom firmware. These are workarounds and they will be worked around in turn.

    The Flash
    Forum Moderator

    EDIT: Thread is reopened... I will be cleaning any SafetyNet posts for a while to keep the thread clean for real issues.
    75
    Hello everyone!

    I am aware that Google has updated Safety Net that makes Magisk itself a no go for Android Pay. In fact, I witnessed the change live while I am developing the new magiskhide, which should hide all Magisk modules and Magisk installed root.

    Google is serious about Safety Net now, clearly hunting down all possibility to run Xposed with Safety Net passed. I spend quite some time examining the new security measures last midnight, and fortunately it seems that it is possible to run Magisk and root along with Safety Net if no Xposed is running. I'm glad I removed the old root toggle at the right time lol, that is no longer feasible with the latest detection.

    So stay tuned for the next update, it will come with bug fixes, along with the new magiskhide to bypass that Safety Net.

    Google, how will a few systemless mods do any harm :p:p