Magisk General Support / Discussion

Search This thread

pndwal

Senior Member
Seems to be device/rom related. :unsure:

In the last year..
I had one issue updating Magisk while hidden (renamed) on a few devices that I still have it hidden. 🙂
Renamed the Magisk app for some reason (probably testing something) and just left it hidden since.

The one issue I had (do not remember the device)..
I think it was the switch in Magisk patching and not so much the hidden (renamed) app.
From a prior post
I know I saw something reported about it at that time.
Not sure if it was a post here on xda, an issue or a PR on GitHub.
Something about updating instead of a clean install with one of the Magisk updates.


Mine was a little different situation.
I updated Magisk while the app was hidden.

Normally the update would hide the new (updated) app.
That time it did not and triggered a bunch of issues.

The old (hidden) app showed as Magisk installed (new version) and there was an app update available.
The new (updated) app reported Magisk not installed but the app was up-to-date.
I also had the stub-app showing in my app drawer.
Gave an error that it could not download the full app.
I uninstalled the old (hidden) app, and rebooted.
The old (hidden) app was restored on boot.

Long story short.
I ended up uninstalling Magisk using the old (hidden) app since it had root access.
That did not uninstall the new (updated) app so, I had to uninstalled it manually.
Flashed the stock boot image back to the device (fastboot) and booted.
Then installed the new (updated) app and did the steps for a clean install using the patch boot image method.

Then set everything up again.
Configure Magisk, install modules, grant root access...


No one will read it but.. :unsure:
We can link users to it though. 😛

Anyone willing to take (have) the time to write up and submit an update to the official Magisk installation instructions.
Magisk Installation - [GitHub] - Improve this page.
Code:
### Known Issues
Some devices and/or roms still have issues updating when Magisk is hidden (renamed). Add Quick Explanation of the the Problem.

To fix the failed update (Word this better).
- Uninstall the older (hidden) Magisk app and reboot.

Note something about continued updates.
- Restore Magisk
- Upgrade directly via the Magisk app using its “Direct Install” method.
- Add or link to updating for Samsung and/or Magisk in Recovery.
I do not have the time to write up a proper edit.
Maybe next month..?
Unless you, pndwal or someone else writes it up.


Cheers. :cowboy:
May be device thing... Very common on my Xiaomi RN8T and Mi Pad 4...

I thought much the same re. GitHub issue... Hope someone else does... (I think a few tried and got nowhere)...

I've made a couple of relavent issues for the good of others now that have just been closed with little or no comment or, worse, locked for commentiy by me or others...
One was re. inability to hide Magisk app at all if user tried after new App became available and user either hadn't or couldn't take update (sometimes due to a regression). This sometime occurs immediately if update stub version increased, or after stub becomes 2 or 3 versions old, and occurs because unlike the packaged Magisk binary, the stub is called from GitHub repo and the Jason doesn't point to the builds original compatible stub, but always to the latest which seem to become incompatible within a few versions... (One workaround only after Magisk 24 was to turn off network while taking Hide The Magisk App to force use of offline stub (a vv2060 commit), but I'm not sure this still works... Another is to use custom Channel to point to archived JSON which fixes App hiding but breaks Update info unless unset again). Anyway, terse 'Old builds are not supported' was the answer, which makes sense for Canary, but for Stable??? (If you ever wanna un-hide and hide again you're basically forced to discover workaround or update Magisk)...

Another issue (vv actually locked issue and me out due to an idiot spammer; had to move issue to my own GitHub to continue. Pinged Canyie and she commented there, but nothing more was done...) was for pre A9 Sammy devices updated to A10+, all of which are converted to 2SI at that point with users experiencing several issues covered by official Samsung (System-as-root) instructions... But that section says "If your Samsung device is NOT launched with Android 9.0 or higher, you are reading the wrong section"... WRONG!... It applies to any Sammy device updated to A10+ other than those that launched with A9!... After seeing more users with Sammy-SAR issues on old devices I even pinged John on his Twitter re legit issues being shut down in general and my examples... Not a peep...
Bit disheartened by that... Seems workaround is XDA members putting word out here... 🙃 PW
 
Last edited:
  • Like
Reactions: ipdev

huskydg

Senior Member
Feb 17, 2021
242
246
May be device thing... Very common on my Xiaomi RN8T and Mi Pad 4...

I thought much the same re. GitHub issue... Hope someone else does... (I think a few tried and got nowhere)...

I've made a couple of relavent issues for the good of others now that have just been closed with little or no comment or, worse, locked for comments by me or others...

One was re. inability to hide Magisk app at all if user tried after new App became available and user either hadn't or couldn't take update (sometimes due to a regression). This sometime occurs immediately if update stub version increased, or after stub becomes 2 or 3 versions old, and occurs because unlike the packaged Magisk binary, the stub is called from GitHub repo and the Jason doesn't point to the builds original compatible stub, but always to the latest which seem to become incompatible within a few versions... (One workaround only after Magisk 24 was to turn off network while taking Hide The Magisk App to force use of offline stub (a vv2060 commit), but I'm not sure this still works... Another is to use custom Channel to point to archived JSON which fixes App hiding but breaks Update info unless unset again). Anyway, terse 'Old builds are not supported' was the answer, which makes sense for Canary, but for Stable??? (If you ever wanna un-hide and hide again you're basically forced to discover workaround or update Magisk)...

Another issue (vv actually locked issue and me out due to an idiot spammer; had to move issue to my own GitHub to continue. Pinged Canyie and she commented there, but nothing more was done...) was for pre A9 Sammy devices updated to A10+, all of which are converted to 2SI at that point with users experiencing several issues covered by official Samsung (System-as-root) instructions... But that section says "If your Samsung device is NOT launched with Android 9.0 or higher, you are reading the wrong section"... WRONG!... It applies to any Sammy device updated to A10+ other than those that launched with A9!... After seeing more users with Sammy-SAR issues on old devices I even pinged John on his Twitter re legit issues being shut down in general and my examples... Not a peep...

Bit disheartened by that... Seems workaround is XDA members putting word out here... 🙃 PW
Too long, can't read
 

evil-google

Member
Jul 3, 2019
29
8
Hi, I am having this strange problem with my sdcard which I suspect is related Magisk and would appreciate if someone can give me some pointers to resolve it.

I was running LineageOS 18.1 with OrangeFox recovery. I used the Magisk module in OrgangeFox recovery to root the system. Recently I noticed that OrangeFox modules were missing and tried to re-install it. This did not go down very well and I was unable to boot to recovery.

Then I tried Twrp and was able to boot to recovery. However, when I booted the system was I could not get pass mounting of SD card. The system says SD Card is missing and goes back reboot and mount the SD card. I then removed the SD card and the system booted perfectly OK. Then re-inserted the SD card and formatted to internal storage (which is what I had earlier). The formatting process goes up to 40% and the system automatically reboots. Tried ths process many time without any luck. However, if I format the SD card as external storage it all goes well. Tried with another SD card to eliminate the possibility of having a faulty SD card but the the outcome was the same.

I checked out the file structure using Twrp file manager and I noted that the internal storage folder names appear to be encrypted - folder names appear as just a random string of characters.

I re-installed Magisk and uninstalled it from the app (which did not report any errors) but my SD card issue still remains.

I would greatly appreciate if anyone can come up with some suggestions.

Many thanks.
 

zgfg

Senior Member
Oct 10, 2016
7,804
5,216
Hi, I am having this strange problem with my sdcard which I suspect is related Magisk and would appreciate if someone can give me some pointers to resolve it.

I was running LineageOS 18.1 with OrangeFox recovery. I used the Magisk module in OrgangeFox recovery to root the system. Recently I noticed that OrangeFox modules were missing and tried to re-install it. This did not go down very well and I was unable to boot to recovery.

Then I tried Twrp and was able to boot to recovery. However, when I booted the system was I could not get pass mounting of SD card. The system says SD Card is missing and goes back reboot and mount the SD card. I then removed the SD card and the system booted perfectly OK. Then re-inserted the SD card and formatted to internal storage (which is what I had earlier). The formatting process goes up to 40% and the system automatically reboots. Tried ths process many time without any luck. However, if I format the SD card as external storage it all goes well. Tried with another SD card to eliminate the possibility of having a faulty SD card but the the outcome was the same.

I checked out the file structure using Twrp file manager and I noted that the internal storage folder names appear to be encrypted - folder names appear as just a random string of characters.

I re-installed Magisk and uninstalled it from the app (which did not report any errors) but my SD card issue still remains.

I would greatly appreciate if anyone can come up with some suggestions.

Many thanks.
Internal storage files and folders are encrypted by use of FBE (File Based Encryption).
You need to be asked for your Android unlock pin/pass/pattern when starting TWRP and only when you enter, TWRP will be able to decrypt file (and folder) names (and content)
 
  • Like
Reactions: J.Michael

evil-google

Member
Jul 3, 2019
29
8
Internal storage files and folders are encrypted by use of FBE (File Based Encryption).
You need to be asked for your Android unlock pin/pass/pattern when starting TWRP and only when you enter, TWRP will be able to decrypt file (and folder) names (and content)
Hi, thanks for the prompt response. In my case TWRP does not ask me to enter any unlock pin or password. The issue seems to be when formatting the SD card as internal storage the process stops at 40% and reboots - I do not think this is normal but I may be wrong. However, since the system is already rooted using Magisk shouldn't these folders be unencrypted? Not particularly concerned about not being able to read the folder names on TWRP but not being able to use the SD card as internal storage is the main issue.
 

Tech = Spy-Biz

Account currently disabled
May 25, 2022
32
20
Hi, thanks for the prompt response. In my case TWRP does not ask me to enter any unlock pin or password. The issue seems to be when formatting the SD card as internal storage the process stops at 40% and reboots - I do not think this is normal but I may be wrong. However, since the system is already rooted using Magisk shouldn't these folders be unencrypted? Not particularly concerned about not being able to read the folder names on TWRP but not being able to use the SD card as internal storage is the main issue.
I think I had faced the same issue before but I don't remember exactly what I did to get sdcard as internal...I think I either placed the sdcard then rebooted to twrp/ofox then change file system to ext2 then back to ext4 or I had formatted to ExFat using DOS then placed sdcard in and rebooted to system then the format goes from 40% to done. OR maybe I had flashed decryption.zip, but something had made it work.
(excuse off-topic i think)
 
  • Like
Reactions: pndwal

samhhmobil

Senior Member
May 25, 2017
440
224
Hamburg
I was running LineageOS 18.1 ...

... Then re-inserted the SD card and formatted to internal storage (which is what I had earlier). The formatting process goes up to 40% and the system automatically reboots. Tried ths process many time without any luck. However, if I format the SD card as external storage it all goes well....
Offtopic here (it's NOT a magisk issue):

LineageOS is well known to be completely unreliable with SDcards as "internal storage". (It's many times written in this Forum — not in this thread.)

DON'T USE THAT!!

Someone sometimes should have been lucky with that I was told, but in most cases it does not work and destroys at least your file structure.

Moreover I have destroyed physically several SDcards when I was trying to establish/format a SDcard as internal storage with LineageOS. NEVER AGAIN.

Again: DON'T DO THAT, when using LineageOS.

Instead of that: format your SDcard as external storage, and use the Magisk-module "fbind" to mount it into the necessary directories inside your internal storage.

That works flawlessly, but the setup is somewhat tricky. Documentation exists.

Just my 2¢,
samhhmobil
 
Last edited:

zgfg

Senior Member
Oct 10, 2016
7,804
5,216
However, since the system is already rooted using Magisk shouldn't these folders be unencrypted?
Magisk has nothing to do with File Based Encryption on Data and Storage.
That's part of the File System definition - Magisk does not redefine File Systems.
And when running Android, kernel takes care of FBE

Btw, why would you (and some other users who maybe first time face FBE) dislike FBE (or be afraid of, or what) and want instead your files to be permanently unencrypted?!

If you have a proper custom Recovery, it will ask for your pin/pattern and by use of that pin, it will then unencrypt file by file, on demand - just like Android does when you boot to Android

Then, if your phone is stolen and the thief-hacker reboots to TWRP, he will not be able to steal your documents, phoos, etc, since (s)he does not know your Android unlock pin/pattern (and therefore TWRP cannot decrypt him your files - he can copy the encrypted files to PC but they will be of no use for him)

However, without encryption, if your phone (with the TWRP installed) gets stolen, thief can simply boot to TWRP and copy all your personal files to PC.
He can then open and read your documents, see your private photos, etc

---

The official Google FBE documentation is available at:

---

And one important tip:
When installing custom ROM, usually you have to FORMAT Data (not just Wipe) that your new ROM could properly reformat FBE for itself - only then things will work as described (TWRP and FBE)

But all that is out-of-topic for our Magisk thread

Developers of custom ROMs should provide clear instructions how to properly install their ROMs - and their users of custom should take time to read instructions before flashing👍

---

You can go to /vendor/etc/ (aka /system/vendor/etc one has to be mounted to the other in Android)
and find a file fstab.* (on my phone it is named fstab.emmc).
That's the read-only, textual file

Inside, search for /userdata (filesystem definition).
On my phone it looks like:
Code:
/dev/block/bootdevice/by-name/userdata /data f2fs noatime,nosuid,nodev,discard,inlinecrypt,reserve_root=32768,resgid=1065,fsync_mode=nobarrier latemount,wait,check,formattable,fileencryption=aes-256-xts:aes-256-cts:v2+emmc_optimized+wrappedkey_v0,keydirectory=/metadata/vold/metadata_encryption,metadata_encryption=aes-256-xts:wrappedkey_v0,quota,reservedsize=128M,sysfs_path=/sys/devices/platform/soc/1d84000.ufshc,checkpoint=fs

Actually, inside that line look for the fileencryption definition - in my case:
Code:
fileencryption=aes-256-xts:aes-256-cts:v2+emmc_optimized+wrappedkey_v0

Flag :v2 means that I have FBE v2. It's also emmc_optimized with hardware-wrapped keys (details and description can be found in the Google's FBE documentation as linked above)
 
Last edited:

evil-google

Member
Jul 3, 2019
29
8
I think I had faced the same issue before but I don't remember exactly what I did to get sdcard as internal...I think I either placed the sdcard then rebooted to twrp/ofox then change file system to ext2 then back to ext4 or I had formatted to ExFat using DOS then placed sdcard in and rebooted to system then the format goes from 40% to done. OR maybe I had flashed decryption.zip, but something had made it work.
(excuse off-topic i think)
Hi, thanks very much for the suggestions. I tried reformating with TWRP and then wiped out everything using kdepartition manager (left unformatted) but none of them worked. Where can I find 'decryption.zip'?
 

evil-google

Member
Jul 3, 2019
29
8
LineageOS is well known to be completely unreliable with SDcards as "internal storage". (It's many times written in this Forum — not in this thread.)
I doubt it is a LOS problem - more likely an operator error! I flashed crdroid and ended up having exactly the same result.

Thanks very much for your warning about destroying the SD card - in fact, I was concerned about repeated formatting/reinserting the SD card.

Will try out using fbind module as you suggested - thanks.

EDIT: I could not locate the Magisk module fbind in the repo - appreciate if you can suggest where I could download it from. Thanks.
 
Last edited:

evil-google

Member
Jul 3, 2019
29
8
Btw, why would you (and some other users who maybe first time face FBE) dislike FBE (or be afraid of, or what) and want instead your files to be permanently unencrypted?!
It is not just that I do not like FBE - just trying to see why I cannot use the SD card as internal storage.:)

You can go to /vendor/etc/
and find a file fstab.* (on my phone it is named fstab.emmc).
That's the read-only, textual file
In my case, /vendor has no etc directory. It has lib64 and firmware folders and two xml files, manifest and compatibility-matrix.

I will post this issue on LOS see whether anyone has any further suggestions. Many thanks.
 
  • Like
Reactions: zgfg

adfree

Senior Member
Jun 14, 2008
9,858
5,835
Samsung Galaxy Watch 4
Thank you very much for Magisk and all cool infos and Modules etc... for Rooting.

I can use my Galaxy Watch 4...

SM-R870

I was able to root with help of Magisk Version:
Code:
24.3

At the moment only tested Version:
Code:
EVA8

And just for fun tested patched Kernel (boot.img) from:
Code:
FVD4

Mixed with EVA8 Firmware...

Reason only EVA8 complete leak for Odin use...

And my FOTA is now broken... so at the moment no chance to use update.zip for me... to reach higher Firmware Version...

Rooting process require at the moment USB wires...

"We" are not able to bypass Security with netOdin only...

Wireless update mechanism check something in boot.img "Footer"...

USB cable and Odin ignores Security check...

Only as info. :cowboy:

Best Regards
 
  • Like
Reactions: ipdev and galaxys

pndwal

Senior Member
It is not just that I do not like FBE - just trying to see why I cannot use the SD card as internal storage.:)
Redmi Note 7?

I may have missed your usage scenario, but why not format SD card for official Adopted Storage? (Will be encrypted and just work with encryption keys stored in /data/misc/vold)

I used to use link2sd, then switched to apps2sd on old devices with very limited storage, then moved to Adopted SD storage when proper Android support came w/ A6 Marshmallow... Was a bit flakey then (config issues/anomalies), but worked flawlessly from A7 Nought... 😛 PW
 

evil-google

Member
Jul 3, 2019
29
8
Redmi Note 7?

I may have missed your usage scenario, but why not format SD card for official Adopted Storage? (Will be encrypted and just work with encryption keys stored in /data/misc/vold)

I used to use link2sd, then switched to apps2sd on old devices with very limited storage, then moved to Adopted SD storage when proper Android support came w/ A6 Marshmallow... Was a bit flakey then (config issues/anomalies), but worked flawlessly from A7 Nought... 😛 PW
Hi,

Yes, it is Redmi Note 7.

I did have it formatted as internal storage but decided to re-install the same LOS 18.1 version I had. Now I cannot format the SD card as internal storage and hence this post. I'd rather not use another app to do this as I can easily move data manually but if would be nice if I can work out why I can no longer format it as internal storage. Thanks.
 

zgfg

Senior Member
Oct 10, 2016
7,804
5,216
EDIT: I could not locate the Magisk module fbind in the repo - appreciate if you can suggest where I could download it from. Thanks.
If you install the root app Fox Magisk Module Manager (FMMM tool was suggested here several times since support for the on-line modules repo was removed by
Magisk v24), you can search for the fbind module (and simply install it directly from FMMM).
Screenshot attached

The module is actually published on the new Alt Repo:

Disclaimer: I don't use the fbind module
 

Attachments

  • IMG_20220814_073524.jpg
    IMG_20220814_073524.jpg
    192.9 KB · Views: 33
Last edited:
  • Like
Reactions: ipdev

pndwal

Senior Member
Hi,

Yes, it is Redmi Note 7.

I did have it formatted as internal storage but decided to re-install the same LOS 18.1 version I had. Now I cannot format the SD card as internal storage and hence this post. I'd rather not use another app to do this as I can easily move data manually but if would be nice if I can work out why I can no longer format it as internal storage. Thanks.
Oh, I see you mean officially adopted...

I never had issues with Adopted Storage on LOS!... Guess you fully formatted card... PW
 
Last edited:

evil-google

Member
Jul 3, 2019
29
8
If you install the root app Fox Magisk Module Manager (FMMM tool was suggested here several times since support for the on-line modules repo was removed by
Magisk v24), you can search for the fbind module (and simply install it directly from FMMM).
Screenshot attached

The module is actually published on the new Alt Repo:

Disclaimer: I don't use the fbind module
Thanks. Downloaded and installed fbind. I will first try the LOS forum to see whether anyone can suggest a straight forward solution - if that fails, I will look at using fbind which looks very promising. (y)
 

samhhmobil

Senior Member
May 25, 2017
440
224
Hamburg
Thanks. Downloaded and installed fbind. I will first try the LOS forum to see whether anyone can suggest a straight forward solution - if that fails, I will look at using fbind which looks very promising. (y)
This is the "thread" for fbind:

The "home" is:

samhhmobil
 

Tech = Spy-Biz

Account currently disabled
May 25, 2022
32
20
Hi, thanks very much for the suggestions. I tried reformating with TWRP and then wiped out everything using kdepartition manager (left unformatted) but none of them worked. Where can I find 'decryption.zip'?
(Excuse, Off-Topic)

Hope you find luck with fbind, also since you asked for the decryption zip i think that is the file that ive attached (you might have to modify the updater-script in google folder to be able to flash it, for that you need to remove the first few lines in the updater-script that mentions which devices this zip is intended to be flashed upon) but please back up your device data first before you flash the modified version of this zip file or even if you flash directly without modifying the file.
 

Attachments

  • Disable_Dm-Verity_ForceEncrypt_03.04.2020(1).zip
    3.4 MB · Views: 13
  • Like
Reactions: ipdev

Top Liked Posts

  • There are no posts matching your filters.
  • 7
    Can someone either provide actual proof that zygisk/shamiko etc does anything to GPS (i havent had a single issue and i use it daily) or i dunno, maybe stop spreading FUD because of personal gripes you have against people on other platforms that dont take part here, and therefore wont get any of the swipes youre taking at them here that only further add to the aforementioned FUD.

    We've all had our moments with those folk and its fine to mention the odd bit of spice you may come across when trying to submit an issue on github (ive done this myself), but to then to continually poison magisk proper/shamiko because of that person/persons taking part is not helping anyone. Thats a personal gripe, and shouldnt colour the entire magisk (proper) project/shamiko. What we dont need is spice here....

    Please, you know who you are...

    I think we've all had enough, now
    5
    How does PixelFlasher invoke boot_patch.sh?
    Does it invoke it as an "executable", creating a new process? Or does it "source" it, so changes to the environment will survive?

    Does PixelFlasher create an environment variable named "SHA1"?

    My copy of boot_patch.sh has a compound statement that tests whether SHA1 has a non-zero length value before setting it to the sha1 of the boot image. If the environment variable is already set, it will not be overwritten. I don't know why.
    I wouldn't source. The script is supposed to be called as an executable

    Eg, my following code is rather primitive but it dumps the active Boot partition (it supports A/B and non-A/B devices), then it patches by invoking the boot_patch.sh script, finally it dumps back to the Boot partition and automatically reboots

    Ie, it updates me the Magisk and it also leaves me the patched-boot img in the Download folder

    Code:
    #!/system/bin/sh
    
    # Boot partition
    AB=$(getprop ro.boot.slot_suffix)
    BOOT_PART=/dev/block/bootdevice/by-name/boot"$AB"
    
    # Boot and patched boot images
    DOWNLOAD=/sdcard/Download/
    BOOT_IMG="$DOWNLOAD"boot.img
    PATCHED_BOOT_IMG="$DOWNLOAD"patched-boot.img
    
    # Magisk path
    MAGISK_PATH=/data/adb/magisk/
    
    # Disk-dump boot image to Download folder
    dd if="$BOOT_PART" of="$BOOT_IMG"
    
    # Patch the boot image and move to Download folder
    "$MAGISK_PATH"boot_patch.sh "$BOOT_IMG"
    mv "$MAGISK_PATH"new-boot.img "$PATCHED_BOOT_IMG"
    
    # Flash the patched boot image
    dd if="$PATCHED_BOOT_IMG" of="$BOOT_PART"
    
    # Reboot
    reboot
    5
    Installing on Samsung S7 (SM-G930F) with /e/OS?
    Okay folks, thought I'd post up the procedure:
    1. Follow these instructions until you get to 7th bullet point here;
    2. Stop. Some points to mention on the way:
      1. Note my progress above from 'Preliminaries' until point 5, adb pull /sdcard/Download/magisk_patched_[random_strings].img works just fine;
      2. Ignore my rambling queries up to point 5;
    3. Install heimdall;
    4. Boot device into 'Download' mode without USB cable connected, then once in 'Download' mode insert USB cable (this seemed important as I ran into quite a lot of ERROR: Protocol initialisation failed! type errors which seemed possibly cable/ hardware related);
    5. Bash:
      $ heimdall detect
      Device detected
      $ heimdall print-pit --no-reboot > print-pit.txt
    6. From print-pit.txt discover:
      ...
      --- Entry #10 ---
      Binary Type: 0 (AP)
      Device Type: 8 (Unknown)
      Identifier: 5
      Attributes: 5 (Read/Write)
      Update Attributes: 1 (FOTA)
      Partition Block Size/Offset: 10240
      Partition Block Count: 10240
      File Offset (Obsolete): 0
      File Size (Obsolete): 0
      Partition Name: BOOT
      Flash Filename: boot.img
      FOTA Filename:
      ...
    7. Reboot into 'Download' mode (this rebooting also seemed to help prevent the above errors);
    8. Bash:
      $ heimdall detect
      Device detected
      $
    9. Then, instead of fastboot flash boot /path/to/magisk_patched.img at the 7th bullet point here
      Do:

      Bash:
      $ heimdall flash --BOOT magisk_patched-25200_UjUVt.img
      Heimdall v1.4.2
      
      Copyright (c) 2010-2017 Benjamin Dobell, Glass Echidna
      http://www.glassechidna.com.au/
      
      This software is provided free of charge. Copying and redistribution is
      encouraged.
      
      If you appreciate this software and you would like to support future
      development please consider donating:
      http://www.glassechidna.com.au/donate/
      
      Initialising connection...
      Detecting device...
      Claiming interface...
      Setting up interface...
      
      Initialising protocol...
      Protocol initialisation successful.
      
      Beginning session...
      
      Some devices may take up to 2 minutes to respond.
      Please be patient!
      
      Session begun.
      
      Downloading device's PIT file...
      PIT file download successful.
      
      Uploading BOOT
      100%
      BOOT upload successful
      
      Ending session...
      Rebooting device...
      Releasing device interface...
      
      $
    10. At which, the device reboots and:
      Screenshot_20220927-133842_Magisk.png
    11. Happiness :)
    5
    I'm using the systemless debloater module to degoogle and debloat a device (and several other magisk modules to assist in that endeavor). I'd really like to be able to do a factory reset to clear the device of any data/artifacts from the debloated apps, but of course a factory reset wipes out magisk modules, so I'm in a catch 22.
    You can do some cleaning like this:

    - Wipe (from TWRP or by root explorer like MiXPlorer)
    /data/dalwik-cache
    /data/system/package_cache

    -In MiXPlorer, go to three dots, Tools and clean by App Remnants

    -Install SD Maid:
    And clean by CorpsFinder option
  • 1085
    This is the place for general support and discussion regarding "Public Releases", which includes both stable and beta releases.
    All information, including troubleshoot guides and notes, are in the Announcement Thread
    156
    Hello, I haven't given much support on XDA lately. It can be resulted from
    • University started and I have limited free time. In fact, I mostly develop during midnight
    • I live in Taiwan, which has large time zone differences between my European/American contributors/testers, which usually forces me to stay up late at night to discuss/test stuffs.
    • The new version is about to come, I don't want to spend effort on supporting old releases
    The planned update is delayed again and again, to some point I think I'll shed some light about what has been happening lately, also along with some announcements.

    New Forum!
    As you might have already discovered, Magisk got its own subforum on XDA! Many thanks to all the support you gave me, and much more information/features/support is about to come!
    **For developers supporting all the devices that are not using standard Android boot format, feel free to create threads in this section (actually, PLEASE do so) for your favorite devices after v7 is out. As I currently know, Asus devices require signing the boot image before flashing, and is model dependant; Sony devices seems to use ELF kernel that is unpatchable, or some has two ramdisks (inner + outer), both requires different workarounds; LG bootloader locked devices has to manually "BUMP" the boot image after flashing Magisk..... and there may be lots of other crazy boot image formats that haven't come up to my attention yet.
    It is impossible for me to support all these non-standard boot images, and I hope the community can collaborate to make Magisk running across all the devices. Overall, community collaboration is what XDA about :D

    The Pixel Phone
    Some of you might already know this news, that the next Pixel Phone right around the corner seems like it does not have ramdisk in boot image, which pretty much wrecked Magisk in all ways. However, it pretty much doomed root itself too. Kernel modifications is inevitable IMO, so I'll try to migrate my scripts to C programs that could possibly be included into the kernel itself. Note that I'm not familiar with linux kernel, I'm not even sure if my idea and concept is correct or not. But once the device is available, I think developers will find a way to bypass all the difficulties, and I'll do my best to learn things ;)

    Current Progress
    In the past month, I've spent quite some time learning SELinux, so that I can avoid using SuperSU's sepolicy patches. Thanks to the helps and tips from @phhusson and @Chainfire, I finally have a much clearer understanding of how SELinux works. The Magisk core parts (the scripts, boot image patches, new features, more supports) are actually done some time ago. What is causing all the delays is the Magisk Manager.
    To be completely honest, although I can code in Java without much issues, Magisk Manager is actually my first Android application, I had to reach out for assistance, and fortunately awesome developers like @DVDandroid and @digitalhigh contributed a lot, which makes the current Manager awesome.
    After the repo system and module management is mostly done, I was about to do some adjustments and release, but what we really done is decided to add another feature: auto-unroot with per-app settings. I decided to wait for it to be finished, and then do my adjustments. Due to reasons that'll be mentioned later, this feature will likely not be available for the next release (should come in future updates)

    Safety Net Disaster
    Those who are using Magisk for Safety Net bypass purposes must have known that Google recently updated the detection method of my Systemless Xposed. I still have no idea what Safety Net is detecting, so currently I cannot fix it on my side (also because I'm busy working on the next update). However, suhide developed by @Chainfire is able to hide Xposed and worked fine.
    However, only my Systemless Xposed v86.2, which is based on SuperSU's su.d, is supported using that method. v86.2 and v86.5 (latest, Magisk based) have nearly identical binaries, and the only difference is the path where the binaries are stored.
    I'm still not sure what's the real issue for it not being supported, I just hope it is not done intentionally.

    Conclusion
    Due to the fact that my Safety Net bypass is not 100% perfect now, I do not want to spend any more time waiting for auto-unroot to be polished. What I'm doing now is finishing up all the things I'd like to change in Magisk Manager (it has been a while since I last contributed to Manager, my fellow developers are doing all the heavy job), which might take a little more time, after that, packed with tons of information to be announced in Magisk Section, I'll release the long awaited update.

    Hope this lengthy post gives you the idea of the whole situation, and again thanks for all your support!!
    121
    Ah, some Chainfire bashing, I hope it is not too late for me to exercise additional villainy.

    First, let me make clear I have nothing against @topjohnwu, nor against Magisk. Magisk is an interesting project and it certainly displays @topjohnwu ingenuity and persistence. I don't doubt we will see more interesting things from his hands.

    -------------------------

    What has happened here is not all that dark and complicated, from either end. I returned from holidays, and someone pointed me at Magisk. My first thought: interesting!

    Among other things, the thread lists some issues with SuperSU, which in combination with the phrase The developer also requests users to not bug Chainfire with compatibility requests for SuperSU with Magisk from the portal article, raised my left eyebrow by nigh half an inch. The popular systemless xposed mod is apparently now based on it, and apparently it now no longer works with SuperSU, and apparently I'm not supposed to fix that, nor any of the other found issues. I found that a bit weird. So yes, I have told @topjohnwu that I was a bit surprised he was posting about issues with SuperSU without notifying me about them (I can't fix or help fix issues I'm not aware of, after all).

    He's also spreading a modified version of the SuperSU package, which is not all that uncommon, nor necessarily a problem. I have not looked into what he modified, I only ran a few quick tests on one of my devices, and found some commonly used commands run as root to be broken. I have informed him of this as well.

    It appears the tool of choice for Magisk is phh's Superuser, because of some of the mentioned issues with SuperSU. That's fine by itself, but fixing issues in that superuser by incorporating SuperSU's binaries into it is a somewhat questionable practise. After all, SuperSU is a commercial closed-source package that helps pay for my dinner, and superuser is a direct competitor. I have informed him that I was surprised he did this without asking for permission. I have expressed similar surprise on him spreading a modified version of LiveBoot (which helps pay for a snack now and then).
    @topjohnwu has also stated that Magisk's scripts are largely influenced by mine (I have not checked). Scripts based on mine are used all over the place on XDA, some people have crafted amazing things based on them, I have never made an issue of this (otherwise I would have just made them binaries). But yes, I have also stated to him that I don't think it's very nice to base something on one program, and then using that to (almost exclusively) push something directly competing with that program.

    tl;dr Towards @topjohnwu, I have:
    - expressed surprise he has issues getting Magisk to work with SuperSU, and has chosen not to inform me about those
    - expressed surprise he is using SuperSU binaries in a competing superuser without permission
    - expressed surprise he is posting a modified LiveBoot without permission
    - informed him of issues with the modified SuperSU he has posted
    - let him know I thought it wasn't very nice to be applying my scripts to benefit seemingly exclusively that same competing superuser

    To be crystal clear:
    - I have not asked for an apology
    - I have not asked for Magisk to be abandoned, neither the root hiding nor systemless module parts, and certainly not systemless xposed
    - I have not made an issue of any of this anywhere, until this post
    - I have not even specifically asked for anything to be taken down (though obviously in my opinion the other superuser package mixed with SuperSU's binaries, as well as the LiveBoot package, should go)
    - I have not reported this thread to XDA moderators for copyright violations or otherwise

    While my conversation with @topjohnwu may not win any awards for being friendly (though it may win some for brevity), I think all things considered my response has been rather mild. To be perfectly honest, until the apology post, I thought this was over with already. I think the apology post was triggered because I haven't replied to his last PM for a while - I was in the zone, it happens.

    To emphasize again, I have nothing against @topjohnwu, Magisk, or systemless xposed, and it is certainly not my goal to see any of them go. If it can be made to work together with SuperSU, great.

    I get it though: you think of something, you want to see if you can make it work, you finally get it to work, you publish it, it takes off - enthusiasm gets the better of you. Maybe in the rush some mistakes are made. That doesn't mean you have to just drop it and run. None of my stuff would make it past 0.1 if I stopped at the first big mistake :)

    Aside from said being in the zone coding, I usually regret actually responding to these sort of things the day after, which has made me hesitant to reply. Surprise me.
    76
    Thread temporarily closed so everyone sees this.

    The flood of "SafetyNet isn't working for me either!" posts are not helpful, at all. Please refrain from posting further, it will be looked into. Please do not forget that not passing SafetyNet is 100% NORMAL AND INTENDED when you have an unlocked booloader or running custom firmware. These are workarounds and they will be worked around in turn.

    The Flash
    Forum Moderator

    EDIT: Thread is reopened... I will be cleaning any SafetyNet posts for a while to keep the thread clean for real issues.
    75
    Hello everyone!

    I am aware that Google has updated Safety Net that makes Magisk itself a no go for Android Pay. In fact, I witnessed the change live while I am developing the new magiskhide, which should hide all Magisk modules and Magisk installed root.

    Google is serious about Safety Net now, clearly hunting down all possibility to run Xposed with Safety Net passed. I spend quite some time examining the new security measures last midnight, and fortunately it seems that it is possible to run Magisk and root along with Safety Net if no Xposed is running. I'm glad I removed the old root toggle at the right time lol, that is no longer feasible with the latest detection.

    So stay tuned for the next update, it will come with bug fixes, along with the new magiskhide to bypass that Safety Net.

    Google, how will a few systemless mods do any harm :p:p