Magisk General Support / Discussion

Search This thread

evil-google

Member
Jul 3, 2019
29
8
(Excuse, Off-Topic)

Hope you find luck with fbind, also since you asked for the decryption zip i think that is the file that ive attached (you might have to modify the updater-script in google folder to be able to flash it, for that you need to remove the first few lines in the updater-script that mentions which devices this zip is intended to be flashed upon) but please back up your device data first before you flash the modified version of this zip file or even if you flash directly without modifying the file.
Did have a quick look at fbind - haven't got my head around yet on the syntax and usage. Will need to spend a couple of days to work out the details. But it certainly appears to be the way to go.

Not sure whether I want to go down the path of playing around with decryption.zip - just that I do not feel comfortable doing it as my knowledge about Android is file structure is not that great and I might end up creating more work for myself! Thanks for sharing the file anyway. Still waiting to hear from LOS but the only available support is via IRC and given the time difference not had much success in getting someone to have a look at the issue. Looks like fbind is the way forward.

Thanks for all your support.
 

ipdev

Recognized Contributor
Feb 14, 2016
1,914
1
3,503
Google Nexus 10
Nexus 7 (2013)
I doubt it is a LOS problem - more likely an operator error! I flashed crdroid and ended up having exactly the same result.
<SNIP>
Quick OT comment.
To touch back on this.

crDroid is based on Lineage.
Think of cr as Lineage with heavy customization. 🙃

If it does not work with Lineage, it will probably not work with cr unless it is fixed in cr.
In turn, I would hope cr submits the fix to Lineage.

Cheers. :cowboy:
 
  • Like
Reactions: 73sydney

evil-google

Member
Jul 3, 2019
29
8
Finally managed to get hold of devs at LOS and their response was simply not to use adopted storage. That leaves me with the option of looking at fbind or manually move files to sdcard.

Thanks everyone for your comments - greatly appreciated.
 
  • Like
Reactions: ipdev and 73sydney

73sydney

Senior Member
I did not know cdDroid background....we live and learn! Thanks for clarifying this.

Custom ROM's generally have just 2 sources, AOSP (Google open source) which is usually close to Pixel appearance or LineageOS.

Just to make things murkier for you there may be 3 or 4 custom ROMs using LineageOS as a base, but often devs will "cherrypick" commits etc from other repos (other than LineageOS) to fix issues, so issues may exist on one ROM, but not another. Usually (though not always) once a dev finds fix for an issue they will share which commits theyve used to benefit the other ROM's.

I dont miss the days, while on my s20+, of testing 3/4 ROMs a week like i used to on previous devices....

<insert Murtaugh quote>

p.s. If you dont get the Murtaugh quote then youre probably too young, and youre part of what daddy calls "The Problem" :)
 

73sydney

Senior Member
Finally managed to get hold of devs at LOS and their response was simply not to use adopted storage. That leaves me with the option of looking at fbind or manually move files to sdcard.

Thanks everyone for your comments - greatly appreciated.

Thats not entirely surprising given the downsides of adoptable storage, namely corruption (any issue on the memory can cause the entire ROM to have a spazz), disappearing shortcuts to apps, and that other great one, running out of space (because what do you think happens when you run out of space with adoptable storage? - nothing good is the simple answer)...though thats not as big of a deal as it once was...some of us remember it though....
 
  • Like
Reactions: ipdev

rodken

Senior Member
Jan 11, 2010
1,111
451
p.s. If you dont get the Murtaugh quote then youre probably too young, and youre part of what daddy calls "The Problem" :)
Off-Topic: I always thought that 'The Problem' colloquially known as Zoomers were the 'ones' that prefer to use abbreviations and/or acronyms for every other word typed or spoken.
 
  • Like
Reactions: 73sydney

m0han

Senior Member
Apr 30, 2012
5,094
2,117
  • Like
Reactions: ipdev and Makishima

exist2resist

Senior Member
Nov 18, 2010
285
58
Calgary
Google Pixel 3 XL
I have been running lineage OS on my Pixel 3 XL (crosshatch) for about 3 years now side by side with Magisk.
I recently upgraded to Lineage OS 19.1 and some issues started popping up in the OS.

Primarily when I boot, I see a toast message about network not being available.
Also my Amazon app stopped working, it keeps complaining about not being able to find a network.

So I decided to remove magisk/root, as soon as I did that the toast message stopped popping up on boot and the Amazon app started working.

I'd like to keep using magisk so I can backup my apps and run adblocker, anyone seen this before or know a fix for this?
 

J.Michael

Recognized Contributor
Jan 20, 2018
1,311
1,244
Samsung Galaxy Tab A series
I have been running lineage OS on my Pixel 3 XL (crosshatch) for about 3 years now side by side with Magisk.
I recently upgraded to Lineage OS 19.1 and some issues started popping up in the OS.

Primarily when I boot, I see a toast message about network not being available.
Also my Amazon app stopped working, it keeps complaining about not being able to find a network.

So I decided to remove magisk/root, as soon as I did that the toast message stopped popping up on boot and the Amazon app started working.

I'd like to keep using magisk so I can backup my apps and run adblocker, anyone seen this before or know a fix for this?
How did you upgrade Lineage?
Did you re-install Magisk after upgrading Lineage? How?
How did you remove Magisk?

If you flashed a Magisk-patched boot image after upgrading the LineageOS, did you extract the boot image from the new Lineage and re-patch?
 

pndwal

Senior Member
I have been running lineage OS on my Pixel 3 XL (crosshatch) for about 3 years now side by side with Magisk.
I recently upgraded to Lineage OS 19.1 and some issues started popping up in the OS.

Primarily when I boot, I see a toast message about network not being available.
Also my Amazon app stopped working, it keeps complaining about not being able to find a network.

So I decided to remove magisk/root, as soon as I did that the toast message stopped popping up on boot and the Amazon app started working.

I'd like to keep using magisk so I can backup my apps and run adblocker, anyone seen this before or know a fix for this?
... Further to the above did you remove root by manual boot.img flash, or Unstall Magisk from App?... PW
 

evil-google

Member
Jul 3, 2019
29
8
I read the instructions but got swayed by another post elsewhere where it was stated that instaling the apk first and renaming it as zip and then sideloading has worked for someone quite well. So out of laziness I did the same process and found that it all installed without any errors.

Could this be the contributing factor with my adopted storage issues which I did not experience earlier? Also, I am experiencing some wierd problems with bluetooth where I can connect using bluetooth to most devices but if I try to connect to another android device it attempts to pair and then fails without any errors. Fortunately, haven't experienced any other major issues.

What is the correct un-installation procedure for Magisk? I would like to uninstall and re-install as per the official method to see whether my issues will go away.
 

pndwal

Senior Member
I read the instructions but got swayed by another post elsewhere where it was stated that instaling the apk first and renaming it as zip and then sideloading has worked for someone quite well. So out of laziness I did the same process and found that it all installed without any errors.

Could this be the contributing factor with my adopted storage issues which I did not experience earlier? Also, I am experiencing some wierd problems with bluetooth where I can connect using bluetooth to most devices but if I try to connect to another android device it attempts to pair and then fails without any errors. Fortunately, haven't experienced any other major issues.
Bit vague on your setup now...

Guess RN7 with ramdisk=no (since launched w/ A9... unless has A/B(?))

So default instructions are install magisk in recovery ramdisk (recovery mode selected)... Zip install can't do this... Did you ever do that (patch recovery.img)?... But being Xiaomi you won't actually need this... Best to patch boot.img (recovery mode un-selected) using M. App and flash...

And I wouldn't use .zip install for your device... It's legacy SAR... May be fine, but zip install is fraught since legacy ramdisk booting devices (any device w/ Launch Version A8 or less, but not updated to A10+)... Whether this could impact on SD card, BT issues etc, I'm not sure, but I'd start again w/ proper patch / flash for SAR / 2SI devices...
What is the correct un-installation procedure for Magisk? I would like to uninstall and re-install as per the official method to see whether my issues will go away.
You can use Uninstall Magisk from App; Nb. Restore Images leaves android configuration in /data/adb, so you'll want to take Complete Uninstall... (Or, if you first want to test if issue is that magisk.db or other config files are corrupted / causing issues, with root explorer or twrp simply delete everything in /data/adb and reboot and magisk daemon will rebuild config files... You'll have cleanly installed root and modules, superuser, deny lists etc will be gone too...)

For full uninstall you can also delete everything in /data/adb and flash unpatched boot image (recovery.img or boot.img or both these boot images)... If deleting data with root, don't reboot before flashing original boot image...

Issue does sound VERY like a mismatched kernel to me... Often this gives associated hardware issues...

Kernel is in boot image, so this is a common issue where users restore images to take an OTA update (even a minor one), then flash back previous boot image instead of sourcing the ROM corresponding with the OTA to obtain boot.img (or recovery.img) to patch and flash... or simply mix up boot images on the PC... Failing to restore unpatched images before an OTA can cause issues too...

Did you ever use App to patch images? (... Old .zip installation doesn't allow such a mismatch/ user error).

... Remember to treat your Xiaomi SAR A only device as ramdisk=yes for your clean setup, and patch / flash boot.img exactly matching or extracted from current ROM...

🤠 PW
 
Last edited:

exist2resist

Senior Member
Nov 18, 2010
285
58
Calgary
Google Pixel 3 XL
How did you upgrade Lineage?
Did you re-install Magisk after upgrading Lineage? How?
How did you remove Magisk?

If you flashed a Magisk-patched boot image after upgrading the LineageOS, did you extract the boot image from the new Lineage and re-patch?

I upgraded Lineage using the Lineage Recovery, as per Lineage instructions, then I flashed the Magisk.zip as my phone supports boot ramdisk.
I removed Magisk using the APP inside the OS.

No, I did not extract it from the lineage zip.
I am unable to mount the payload.bin in windows, and it errors out on me when I try and use 7zip to open it up.
 
Last edited:

zgfg

Senior Member
Oct 10, 2016
7,784
5,189
No, I did not extract it from the lineage zip.
I am unable to mount the payload.bin in windows, and it errors out on me when I try and use 7zip to open it up.
To extract img files from payload.bin you have to use Payload Dumper. There are several threads (under different devices) with download links on XDA (you should search for) - for Windows, Linux, even for Android (not working great with bin files of several GBs), and with instructions

Link to my copy (for Windows) I downloaded months ago from XDA and happily used couple of times:
 
Last edited:

J.Michael

Recognized Contributor
Jan 20, 2018
1,311
1,244
Samsung Galaxy Tab A series
I upgraded Lineage using the Lineage Recovery, as per Lineage instructions, then I flashed the Magisk.zip as my phone supports boot ramdisk.
I removed Magisk using the APP inside the OS.

No, I did not extract it from the lineage zip.
I am unable to mount the payload.bin in windows, and it errors out on me when I try and use 7zip to open it up.
From what @pndwal just said to someone else, if Lineage recovery can flash a zip like TWRP can flash a zip, then there is no danger that you are using the wrong boot image (which includes using the wrong kernel). That was the point of my questions about extracting the boot image. They just don't apply for the procedure you used.

If you want to try a different way of installing Magisk, you will have to solve your problem of how to handle payload.bin. You can probably get guidance in a Lineage thread. Or search the forum for words like "payload dumper". I know I've seen a set of files / scripts. I do not remember if ZIP is any part of the process.
 
  • Like
Reactions: ipdev

exist2resist

Senior Member
Nov 18, 2010
285
58
Calgary
Google Pixel 3 XL
From what @pndwal just said to someone else, if Lineage recovery can flash a zip like TWRP can flash a zip, then there is no danger that you are using the wrong boot image (which includes using the wrong kernel). That was the point of my questions about extracting the boot image. They just don't apply for the procedure you used.

If you want to try a different way of installing Magisk, you will have to solve your problem of how to handle payload.bin. You can probably get guidance in a Lineage thread. Or search the forum for words like "payload dumper". I know I've seen a set of files / scripts. I do not remember if ZIP is any part of the process.

That seems to have done the trick. Thanks
 

Top Liked Posts

  • 2
    deleting (only) those folders - outright? or only the contents therein? If outright, will all these folders be auto-created when/if required?
    Delete the content or the whole folders, they will be recreated on reboot

    I also delete /data/system/package_cache
    1
    Could you elaborate on "suspected Gmail account"?
    Whenever I add the account to my device, suddenly I can't use gpay, I get the "device is rooted or modified" notice, and finally the "gpay is updating right now" notice. I haven't used the account since.
    1
    ..... Dalwik and Cache can be wiped.... by navigating to /data/dalwik-cache and /data/cache and deleting (only) those folders
    deleting (only) those folders - outright? or only the contents therein? If outright, will all these folders be auto-created when/if required?
  • 6
    Can someone either provide actual proof that zygisk/shamiko etc does anything to GPS (i havent had a single issue and i use it daily) or i dunno, maybe stop spreading FUD because of personal gripes you have against people on other platforms that dont take part here, and therefore wont get any of the swipes youre taking at them here that only further add to the aforementioned FUD.

    We've all had our moments with those folk and its fine to mention the odd bit of spice you may come across when trying to submit an issue on github (ive done this myself), but to then to continually poison magisk proper/shamiko because of that person/persons taking part is not helping anyone. Thats a personal gripe, and shouldnt colour the entire magisk (proper) project/shamiko. What we dont need is spice here....

    Please, you know who you are...

    I think we've all had enough, now
    5
    I'm sorry I didn't realize that.

    I've been so used to generic steps (boot recovery -> flash recovery -> reboot recovery -> wipe all -> flash firmware -> flash ROM -> flash GApps -> flash dm-verity disabler -> boot system -> boot recovery -> flash Magisk -> flash *Posed) that I didn't bother checking if steps have changed.

    Therefore, neither.

    Honestly I think it's too bad that we can't just flash ZIPs anymore, that was so easy.

    Anyway, thank you for your response.
    For everyone, a bit of

    Insight into Custom Recovery installation method Depreciation:

    Yup... Method was fine for old legacy ramdisk booting devices, but does rely on custom recovery compatibility, and John ended up fielding the TWRP issues; plenty from official TWRP builds not to mention broken unofficial ones... Then Dees Troy needed to attend to real life and Team Win simply couldn't adapt to Google's ever changing system architecture, boot methods etc fast enough and lagged way behind Magisk. (See John's Android Booting Shenanigans)...

    This precipitated the move to an installation solution that doesn't rely on other custom development, but wasn't the only practical consideration; 'Manager' and now 'App' patching w/ fastboot (etc) flashing meant owners of
    devices with no custom recovery can start rooting and do further modification
    https://forum.xda-developers.com/t/magisk-the-magic-mask-for-android.3473445/post-72587983
    and users can also preserve stock recovery to apply OTAs etc... Thus 'Magisk Manual Injection' was born...

    Next, support was added for patching Samsung AP firmware which recovery/zip installation couldn't achieve. Then with Project Treble came efforts to
    update Magisk to be modular and adaptive to follow Google's Pixel concept... modding a device has changed completely. I am a strong advocate of these new changes, praising the effort Google has put into designing such weird but fascinating setup despite many view this as "moves against developers".

    With the announcement of Project Treble, all devices will go through the same "Pixel-ize" treatment, so this future is inevitable. Project Treble is all about "modular", and Magisk has been rewritten to embrace this concept. I have spent extra effort to backport the changes made requires to run on these new modern devices to downward support all devices, so we do not need 2 drastically different installation methods...
    https://forum.xda-developers.com/t/magisk-the-magic-mask-for-android.3473445/post-74961572
    ... and then 'recovery mode' support for many A-only legacy SAR devices (A9 / 2018) w/ ramdisk only in recovery partition (again not supported by recovery/zip installation)... And it is now noted:
    This installation method is deprecated and is maintained with minimum effort. YOU HAVE BEEN WARNED!

    Installing using custom recoveries is only possible if your device has boot ramdisk.

    Installing Magisk through custom recoveries on modern devices is no longer recommended. If you face any issues, please use the proper Patch Image method.
    ...

    Note that even (old) legacy ramdisk boot-type devices are to be considered 'modern' once running Android 10+ as they are automatically converted to current 2SI "SAR" boot-type!...

    👀 PW
    5
    Hello good people,

    I'm trying my luck here hoping that someone more knowledgeable with magisk can give me a hint about my issue.
    I succeed to build a Samsung S22 Ultra (S908B) rom with f2fs rw partitions (stock rom has locked ro dynamic partitions) but it boots only on permissive kernel patched with magisk 24.3, more precisely 24301. I mention that it boots ok but zygisk cannot be activated. (activation ok in magisk app settings but it says Zygisk = No on magisk app home page)
    As soon I update and patch the kernel with a higher version of magisk, the phone bootloops. Tried all v24 and v25 magisk versions and it bootloops on any version higher than 24301.

    Here are the differences between magisk 24301 (boots ok) and 24302 (bootloop).

    Diffs 24301 --> 24302

    - Support multiple CPIO concatenated
    - Use /data as tmpfs mount point in 2SI setup
    - Cleanup inheritance
    - Introduce new sepolicy injection mechanism
    - Add hijack sepolicy support for rootfs devices
    - Remove unused code
    - Reorganize magiskinit code
    - Fix #5589 (WARNING: linker: su unsupported flags DT_FLAGS_1=0x8000001 after typing su on terminal emulator)
    - Log if failed to dlopen a zygisk module
    - Use standalone magiskpolicy
    - Make magiskinit not magiskpolicy
    - SAR can also have monolithic sepolicy
    - Also hijack plat_file_contexts if necessary

    PS. On stock rooted rom magisk update to v24 and v25 is ok but all partitions are ro. Although it still need permissive kernel to boot.

    Thank you in advance for any hint/advice.
    FWIW, I found older info I posted in addition to link above re. problems getting r/w /system at least w/ stock Android 10 or later any more due to shared blocks implementation:
    https://forum.xda-developers.com/t/magisk-general-support-discussion.3432382/post-85049195

    ... and re. Magic Mount, the new way to 'write' to /system w/ Magisk systemlessly.

    Of course you can rebuild whole filesystem to overcome OEMs locking /system to read only (by using an automated bash script by XDA member @lebigmac to "Universally Mount System read write"... BUT (big but), you MUST be adventurous / maverick / a 'Power User' / know your stuff) as mentioned, but you should be able to make just about any needed changes to /system systemlessly using Magisk without the myriad issues/pitfalls inherent in R/W mounted /system... Of course for simple property manipulation @Didgeridoohan's MagiskHide Props Config module is probably all you need, but you can overlay /system (hence Magisk description 'The Magic Mask for Android') with just about any files / code using Magisk Tools provided.

    Interestingly, the link following refers to how John Wu has even overlayed a stock system with an entire custom ROM as Proof of Concept for a projected Universal MultiROM (Magisk powered custom ROM)... Unfortunately he didn't take that much further...

    I posted (earlier) info on these two methods here:
    https://forum.xda-developers.com/t/magisk-general-support-discussion.3432382/post-84859571

    🤠 PW
    5
    How does PixelFlasher invoke boot_patch.sh?
    Does it invoke it as an "executable", creating a new process? Or does it "source" it, so changes to the environment will survive?

    Does PixelFlasher create an environment variable named "SHA1"?

    My copy of boot_patch.sh has a compound statement that tests whether SHA1 has a non-zero length value before setting it to the sha1 of the boot image. If the environment variable is already set, it will not be overwritten. I don't know why.
    I wouldn't source. The script is supposed to be called as an executable

    Eg, my following code is rather primitive but it dumps the active Boot partition (it supports A/B and non-A/B devices), then it patches by invoking the boot_patch.sh script, finally it dumps back to the Boot partition and automatically reboots

    Ie, it updates me the Magisk and it also leaves me the patched-boot img in the Download folder

    Code:
    #!/system/bin/sh
    
    # Boot partition
    AB=$(getprop ro.boot.slot_suffix)
    BOOT_PART=/dev/block/bootdevice/by-name/boot"$AB"
    
    # Boot and patched boot images
    DOWNLOAD=/sdcard/Download/
    BOOT_IMG="$DOWNLOAD"boot.img
    PATCHED_BOOT_IMG="$DOWNLOAD"patched-boot.img
    
    # Magisk path
    MAGISK_PATH=/data/adb/magisk/
    
    # Disk-dump boot image to Download folder
    dd if="$BOOT_PART" of="$BOOT_IMG"
    
    # Patch the boot image and move to Download folder
    "$MAGISK_PATH"boot_patch.sh "$BOOT_IMG"
    mv "$MAGISK_PATH"new-boot.img "$PATCHED_BOOT_IMG"
    
    # Flash the patched boot image
    dd if="$PATCHED_BOOT_IMG" of="$BOOT_PART"
    
    # Reboot
    reboot
  • 1085
    This is the place for general support and discussion regarding "Public Releases", which includes both stable and beta releases.
    All information, including troubleshoot guides and notes, are in the Announcement Thread
    156
    Hello, I haven't given much support on XDA lately. It can be resulted from
    • University started and I have limited free time. In fact, I mostly develop during midnight
    • I live in Taiwan, which has large time zone differences between my European/American contributors/testers, which usually forces me to stay up late at night to discuss/test stuffs.
    • The new version is about to come, I don't want to spend effort on supporting old releases
    The planned update is delayed again and again, to some point I think I'll shed some light about what has been happening lately, also along with some announcements.

    New Forum!
    As you might have already discovered, Magisk got its own subforum on XDA! Many thanks to all the support you gave me, and much more information/features/support is about to come!
    **For developers supporting all the devices that are not using standard Android boot format, feel free to create threads in this section (actually, PLEASE do so) for your favorite devices after v7 is out. As I currently know, Asus devices require signing the boot image before flashing, and is model dependant; Sony devices seems to use ELF kernel that is unpatchable, or some has two ramdisks (inner + outer), both requires different workarounds; LG bootloader locked devices has to manually "BUMP" the boot image after flashing Magisk..... and there may be lots of other crazy boot image formats that haven't come up to my attention yet.
    It is impossible for me to support all these non-standard boot images, and I hope the community can collaborate to make Magisk running across all the devices. Overall, community collaboration is what XDA about :D

    The Pixel Phone
    Some of you might already know this news, that the next Pixel Phone right around the corner seems like it does not have ramdisk in boot image, which pretty much wrecked Magisk in all ways. However, it pretty much doomed root itself too. Kernel modifications is inevitable IMO, so I'll try to migrate my scripts to C programs that could possibly be included into the kernel itself. Note that I'm not familiar with linux kernel, I'm not even sure if my idea and concept is correct or not. But once the device is available, I think developers will find a way to bypass all the difficulties, and I'll do my best to learn things ;)

    Current Progress
    In the past month, I've spent quite some time learning SELinux, so that I can avoid using SuperSU's sepolicy patches. Thanks to the helps and tips from @phhusson and @Chainfire, I finally have a much clearer understanding of how SELinux works. The Magisk core parts (the scripts, boot image patches, new features, more supports) are actually done some time ago. What is causing all the delays is the Magisk Manager.
    To be completely honest, although I can code in Java without much issues, Magisk Manager is actually my first Android application, I had to reach out for assistance, and fortunately awesome developers like @DVDandroid and @digitalhigh contributed a lot, which makes the current Manager awesome.
    After the repo system and module management is mostly done, I was about to do some adjustments and release, but what we really done is decided to add another feature: auto-unroot with per-app settings. I decided to wait for it to be finished, and then do my adjustments. Due to reasons that'll be mentioned later, this feature will likely not be available for the next release (should come in future updates)

    Safety Net Disaster
    Those who are using Magisk for Safety Net bypass purposes must have known that Google recently updated the detection method of my Systemless Xposed. I still have no idea what Safety Net is detecting, so currently I cannot fix it on my side (also because I'm busy working on the next update). However, suhide developed by @Chainfire is able to hide Xposed and worked fine.
    However, only my Systemless Xposed v86.2, which is based on SuperSU's su.d, is supported using that method. v86.2 and v86.5 (latest, Magisk based) have nearly identical binaries, and the only difference is the path where the binaries are stored.
    I'm still not sure what's the real issue for it not being supported, I just hope it is not done intentionally.

    Conclusion
    Due to the fact that my Safety Net bypass is not 100% perfect now, I do not want to spend any more time waiting for auto-unroot to be polished. What I'm doing now is finishing up all the things I'd like to change in Magisk Manager (it has been a while since I last contributed to Manager, my fellow developers are doing all the heavy job), which might take a little more time, after that, packed with tons of information to be announced in Magisk Section, I'll release the long awaited update.

    Hope this lengthy post gives you the idea of the whole situation, and again thanks for all your support!!
    121
    Ah, some Chainfire bashing, I hope it is not too late for me to exercise additional villainy.

    First, let me make clear I have nothing against @topjohnwu, nor against Magisk. Magisk is an interesting project and it certainly displays @topjohnwu ingenuity and persistence. I don't doubt we will see more interesting things from his hands.

    -------------------------

    What has happened here is not all that dark and complicated, from either end. I returned from holidays, and someone pointed me at Magisk. My first thought: interesting!

    Among other things, the thread lists some issues with SuperSU, which in combination with the phrase The developer also requests users to not bug Chainfire with compatibility requests for SuperSU with Magisk from the portal article, raised my left eyebrow by nigh half an inch. The popular systemless xposed mod is apparently now based on it, and apparently it now no longer works with SuperSU, and apparently I'm not supposed to fix that, nor any of the other found issues. I found that a bit weird. So yes, I have told @topjohnwu that I was a bit surprised he was posting about issues with SuperSU without notifying me about them (I can't fix or help fix issues I'm not aware of, after all).

    He's also spreading a modified version of the SuperSU package, which is not all that uncommon, nor necessarily a problem. I have not looked into what he modified, I only ran a few quick tests on one of my devices, and found some commonly used commands run as root to be broken. I have informed him of this as well.

    It appears the tool of choice for Magisk is phh's Superuser, because of some of the mentioned issues with SuperSU. That's fine by itself, but fixing issues in that superuser by incorporating SuperSU's binaries into it is a somewhat questionable practise. After all, SuperSU is a commercial closed-source package that helps pay for my dinner, and superuser is a direct competitor. I have informed him that I was surprised he did this without asking for permission. I have expressed similar surprise on him spreading a modified version of LiveBoot (which helps pay for a snack now and then).
    @topjohnwu has also stated that Magisk's scripts are largely influenced by mine (I have not checked). Scripts based on mine are used all over the place on XDA, some people have crafted amazing things based on them, I have never made an issue of this (otherwise I would have just made them binaries). But yes, I have also stated to him that I don't think it's very nice to base something on one program, and then using that to (almost exclusively) push something directly competing with that program.

    tl;dr Towards @topjohnwu, I have:
    - expressed surprise he has issues getting Magisk to work with SuperSU, and has chosen not to inform me about those
    - expressed surprise he is using SuperSU binaries in a competing superuser without permission
    - expressed surprise he is posting a modified LiveBoot without permission
    - informed him of issues with the modified SuperSU he has posted
    - let him know I thought it wasn't very nice to be applying my scripts to benefit seemingly exclusively that same competing superuser

    To be crystal clear:
    - I have not asked for an apology
    - I have not asked for Magisk to be abandoned, neither the root hiding nor systemless module parts, and certainly not systemless xposed
    - I have not made an issue of any of this anywhere, until this post
    - I have not even specifically asked for anything to be taken down (though obviously in my opinion the other superuser package mixed with SuperSU's binaries, as well as the LiveBoot package, should go)
    - I have not reported this thread to XDA moderators for copyright violations or otherwise

    While my conversation with @topjohnwu may not win any awards for being friendly (though it may win some for brevity), I think all things considered my response has been rather mild. To be perfectly honest, until the apology post, I thought this was over with already. I think the apology post was triggered because I haven't replied to his last PM for a while - I was in the zone, it happens.

    To emphasize again, I have nothing against @topjohnwu, Magisk, or systemless xposed, and it is certainly not my goal to see any of them go. If it can be made to work together with SuperSU, great.

    I get it though: you think of something, you want to see if you can make it work, you finally get it to work, you publish it, it takes off - enthusiasm gets the better of you. Maybe in the rush some mistakes are made. That doesn't mean you have to just drop it and run. None of my stuff would make it past 0.1 if I stopped at the first big mistake :)

    Aside from said being in the zone coding, I usually regret actually responding to these sort of things the day after, which has made me hesitant to reply. Surprise me.
    76
    Thread temporarily closed so everyone sees this.

    The flood of "SafetyNet isn't working for me either!" posts are not helpful, at all. Please refrain from posting further, it will be looked into. Please do not forget that not passing SafetyNet is 100% NORMAL AND INTENDED when you have an unlocked booloader or running custom firmware. These are workarounds and they will be worked around in turn.

    The Flash
    Forum Moderator

    EDIT: Thread is reopened... I will be cleaning any SafetyNet posts for a while to keep the thread clean for real issues.
    75
    Hello everyone!

    I am aware that Google has updated Safety Net that makes Magisk itself a no go for Android Pay. In fact, I witnessed the change live while I am developing the new magiskhide, which should hide all Magisk modules and Magisk installed root.

    Google is serious about Safety Net now, clearly hunting down all possibility to run Xposed with Safety Net passed. I spend quite some time examining the new security measures last midnight, and fortunately it seems that it is possible to run Magisk and root along with Safety Net if no Xposed is running. I'm glad I removed the old root toggle at the right time lol, that is no longer feasible with the latest detection.

    So stay tuned for the next update, it will come with bug fixes, along with the new magiskhide to bypass that Safety Net.

    Google, how will a few systemless mods do any harm :p:p