Magisk General Support / Discussion

Search This thread

LedgendaryEpics

Senior Member
Jun 14, 2018
195
51
To be fair, CAF is not mainstream, in all my years of Android, from the very first Galaxy onwards, ive literally never run a CAF ROM.....

Have you also modded your gps.conf for your local region? People have been doing that since the dawn of time too. My own (mod of a) GPS magisk module is attached. Feel free to open and edit the (4 = because original module catered for non-China ROM's as well) gps.conf files, edit the NTP_SERVER lines to your local NTP pool, and give it a bash

you can drill down as far as you like starting from the zones here:

I'll try it out
 

m0han

Senior Member
Apr 30, 2012
5,197
2,203
..... Dalwik and Cache can be wiped.... by navigating to /data/dalwik-cache and /data/cache and deleting (only) those folders
deleting (only) those folders - outright? or only the contents therein? If outright, will all these folders be auto-created when/if required?
 

Attachments

  • Screenshot_20220924_110611.jpg
    Screenshot_20220924_110611.jpg
    165.7 KB · Views: 47
  • Like
Reactions: J.Michael

pndwal

Senior Member
Moving this here as it's probably OT in MHPC thread now...
oh i didnt try spark os. the new A13 build gets stuck at boot logo for me. i am using the A12 builds instead. i wish the A13 build booted because the only A13 gsi that boots for me is the google gsi but it lacks phh patches and google monet otherwise i would daily drive it. for now i am stuck with lagginess in A12. A13 was sooooo smooth. oh yeah i am using Arrow OS 12.1
A12 builds are probably passing for the same reasons; a plethora of Devs incl. yours are now sourcing code from @kdrag0n / @Displax fixs to integrate a SN / PI fix...

Re A13 bootloop issue, guess you mean it works clean but bootloops with Magisk...

Did you disable all modules before booting w/ A13 and Magisk?... (What modules did you have installed?)... Also, did you try with Magisk fully uninstalled (all files, ie previous configuration, removed from/data/ADB before installing Magisk)?... And have you tried with latest Canary build?...

I assume you patched extracted A13 boot.img successfully?... No issues in patching log?...

Is this Galaxy A32 4g?... Patching AP (Odin flash), or boot or recovery images?... PW
 
Moving this here as it's probably OT in MHPC thread now...

A12 builds are probably passing for the same reasons; a plethora of Devs incl. yours are now sourcing code from @kdrag0n / @Displax fixs to integrate a SN / PI fix...

Re A13 bootloop issue, guess you mean it works clean but bootloops with Magisk...

Did you disable all modules before booting w/ A13 and Magisk?... (What modules did you have installed?)... Also, did you try with Magisk fully uninstalled (all files, ie previous configuration, removed from/data/ADB before installing Magisk)?... And have you tried with latest Canary build?...

I assume you patched extracted A13 boot.img successfully?... No issues in patching log?...

Is this Galaxy A32 4g?... Patching AP (Odin flash), or boot or recovery images?... PW
yes it is A32. i patched the AP file thats it. The A13 gsi did not boot at all at a clean flash. and its a gsi so theres no boot.img. i wiped /data the cache internal storage and dalvik etc. works for every gsi everytime.
 

pndwal

Senior Member
yes it is A32. i patched the AP file thats it. The A13 gsi did not boot at all at a clean flash.
Oh... So GSI you said "was sooooo smooth" was Google A13 GSI?
and its a gsi so theres no boot.img.
I don't know much about GSIs, but I think you have boot img!... I think new A13 should use GKI boot.img too, so non generic parts are separated to vendor_boot.img etc...
i wiped /data the cache internal storage and dalvik etc. works for every gsi everytime.
So did you try formatting data, not just wipe?... And assume you're flashing all 4(?) binaries w/ Odin, not just AP?... And did transfer w/ ADB pull, not mtp...

And tried using latest Canary (or not)?... PW
 
Oh... So GSI you said "was sooooo smooth" was Google A13 GSI?

I don't know much about GSIs, but I think you have boot img!... I think new A13 should use GKI boot.img too, so non generic parts are separated to vendor_boot.img etc...

So did you try formatting data, not just wipe?... And assume you're flashing all 4(?) binaries w/ Odin, not just AP?... And did transfer w/ ADB pull, not mtp...

And tried using latest Canary (or not)?... PW
yes gsi was smooth.

google A13 and i just discovered LeOS beta based on android 13 works fine too but there are no google apps. it is very smooth. and yes i did flash all the other binaries along with the patched ap file. i also have twrp installed and vb meta disabler.tar flashed along with it. thats how i install gsi's through twrp
 

MorganXYZ

Member
Jun 28, 2021
26
11
Installing on Samsung S7 (SM-G930F) with /e/OS?
(I've done a bit of installed custom ROMs on all my phones, but I've steered clear of Samsungs up until now so I'm a bit nervous of their 'Download' stuff.)

Preliminaries:
/e/OS: e-1.3-q-20220905216076-stable-herolte.zip
(based on lineageos 18.1)
I've followed these install instructions because it says here that 'Github is the only source where you can get official Magisk information and downloads.'
But, the install instructions here seem pretty complete and 'official'.
(Method 2 Install seems the same as Github install instructions, but Method 1 Install isn't reported on Github. What's official?)
So, first up I am using a Samsung device with Andriod 9.0 or latter, but as I'm using it with /e/OS, I ignored the warning that said: 'If you are using a Samsung device that is launched with Android 9.0 or higher, you can now jump to its own section.' I hope that was correct - but if not, someone please shout!

Steps so far:
  1. Magisk App reports 'Ramdisk: Yes' so, I need a copy of boot.img. Done, extracted from here.
  2. Device does not have separate vbmeta
    Code:
    $ adb shell ls -l /dev/block/by-name|grep vbmeta
    $
  3. At Patching Images I did not have either “Recovery Mode” or “Patch vbmeta in boot image” options so I hope these settings were detected automagically, please shout otherwise
  4. 'Choose “Select and Patch a File” in method, and select the boot/recovery image' was the only option
  5. This is where things got difficult, I couldn't adb pull /sdcard/Download/magisk_patched_[random_strings].img because the output file was written to /storage/emulated/0/Download/magisk_patched-25200_UjUVt.img and /storage/emulated/0/ is only accessible to root via adb and I don't yet have root access... :-/
  6. So, I copied via MTD mount device - like it says not to here... :-/ (Any workarounds?)
  7. Now, I've got my magisk_patched patched image on my PC, what? I'm using a Samsung device with doesn't seem to have normal fastboot but instead has 'Download.' If I boot to fastboot from recovery (it's an /e/OS recovery) it just boots straight to the system; if I boot to fastboot from adb, it just boots straight to the system... I can reboot to Download from Android via the extended reboot menu - but, then when I'm in Download what do I do? fastboot flash boot /path/to/magisk_patched.img isn't going to work...
  8. The /e/OS recovery does offer the option to apply an update from internal storage - should follow the Method 1 Install install from here?
  9. The /e/OS recovery does offer the option to apply an update from ADB Sideload - but... which partition:
    Code:
    heroltexx:/ # ls -l /dev/block/by-name
    total 0
    lrwxrwxrwx 1 root root 15 2022-09-24 16:39 BOOT -> /dev/block/sda5
    lrwxrwxrwx 1 root root 15 2022-09-24 16:39 BOTA0 -> /dev/block/sda1
    lrwxrwxrwx 1 root root 15 2022-09-24 16:39 BOTA1 -> /dev/block/sda2
    lrwxrwxrwx 1 root root 16 2022-09-24 16:39 CACHE -> /dev/block/sda15
    lrwxrwxrwx 1 root root 15 2022-09-24 16:39 CPEFS -> /dev/block/sdd1
    lrwxrwxrwx 1 root root 16 2022-09-24 16:39 CP_DEBUG -> /dev/block/sda17
    lrwxrwxrwx 1 root root 16 2022-09-24 16:39 DNT -> /dev/block/sda10
    lrwxrwxrwx 1 root root 15 2022-09-24 16:39 EFS -> /dev/block/sda3
    lrwxrwxrwx 1 root root 16 2022-09-24 16:39 HIDDEN -> /dev/block/sda16
    lrwxrwxrwx 1 root root 15 2022-09-24 16:39 OTA -> /dev/block/sda7
    lrwxrwxrwx 1 root root 15 2022-09-24 16:39 PARAM -> /dev/block/sda4
    lrwxrwxrwx 1 root root 16 2022-09-24 16:39 PERSDATA -> /dev/block/sda13
    lrwxrwxrwx 1 root root 16 2022-09-24 16:39 PERSISTENT -> /dev/block/sda11
    lrwxrwxrwx 1 root root 15 2022-09-24 16:39 RADIO -> /dev/block/sda8
    lrwxrwxrwx 1 root root 15 2022-09-24 16:39 RECOVERY -> /dev/block/sda6
    lrwxrwxrwx 1 root root 16 2022-09-24 16:39 STEADY -> /dev/block/sda12
    lrwxrwxrwx 1 root root 16 2022-09-24 16:39 SYSTEM -> /dev/block/sda14
    lrwxrwxrwx 1 root root 15 2022-09-24 16:39 TOMBSTONES -> /dev/block/sda9
    lrwxrwxrwx 1 root root 16 2022-09-24 16:39 USERDATA -> /dev/block/sda18
    lrwxrwxrwx 1 root root 14 2022-09-24 16:39 sda -> /dev/block/sda
    lrwxrwxrwx 1 root root 14 2022-09-24 16:39 sdb -> /dev/block/sdb
    lrwxrwxrwx 1 root root 14 2022-09-24 16:39 sdc -> /dev/block/sdc
    lrwxrwxrwx 1 root root 14 2022-09-24 16:39 sdd -> /dev/block/sdd
    heroltexx:/ #
    /dev/block/sda5?

Attached screenshot of what the Magisk App looks like:
Screenshot_20220924-180601_Magisk.png

Any ideas about how to install Magisk?
 

J.Michael

Recognized Contributor
Jan 20, 2018
1,408
1,413
Samsung Galaxy Tab A series
Installing on Samsung S7 (SM-G930F) with /e/OS?
(I've done a bit of installed custom ROMs on all my phones, but I've steered clear of Samsungs up until now so I'm a bit nervous of their 'Download' stuff.)

Preliminaries:
/e/OS: e-1.3-q-20220905216076-stable-herolte.zip
(based on lineageos 18.1)
I've followed these install instructions because it says here that 'Github is the only source where you can get official Magisk information and downloads.'
But, the install instructions here seem pretty complete and 'official'.
(Method 2 Install seems the same as Github install instructions, but Method 1 Install isn't reported on Github. What's official?)
So, first up I am using a Samsung device with Andriod 9.0 or latter, but as I'm using it with /e/OS, I ignored the warning that said: 'If you are using a Samsung device that is launched with Android 9.0 or higher, you can now jump to its own section.' I hope that was correct - but if not, someone please shout!

Steps so far:
  1. Magisk App reports 'Ramdisk: Yes' so, I need a copy of boot.img. Done, extracted from here.
  2. Device does not have separate vbmeta
    Code:
    $ adb shell ls -l /dev/block/by-name|grep vbmeta
    $
  3. At Patching Images I did not have either “Recovery Mode” or “Patch vbmeta in boot image” options so I hope these settings were detected automagically, please shout otherwise
  4. 'Choose “Select and Patch a File” in method, and select the boot/recovery image' was the only option
  5. This is where things got difficult, I couldn't adb pull /sdcard/Download/magisk_patched_[random_strings].img because the output file was written to /storage/emulated/0/Download/magisk_patched-25200_UjUVt.img and /storage/emulated/0/ is only accessible to root via adb and I don't yet have root access... :-/
  6. So, I copied via MTD mount device - like it says not to here... :-/ (Any workarounds?)
  7. Now, I've got my magisk_patched patched image on my PC, what? I'm using a Samsung device with doesn't seem to have normal fastboot but instead has 'Download.' If I boot to fastboot from recovery (it's an /e/OS recovery) it just boots straight to the system; if I boot to fastboot from adb, it just boots straight to the system... I can reboot to Download from Android via the extended reboot menu - but, then when I'm in Download what do I do? fastboot flash boot /path/to/magisk_patched.img isn't going to work...
  8. The /e/OS recovery does offer the option to apply an update from internal storage - should follow the Method 1 Install install from here?
  9. The /e/OS recovery does offer the option to apply an update from ADB Sideload - but... which partition:
    Code:
    heroltexx:/ # ls -l /dev/block/by-name
    total 0
    lrwxrwxrwx 1 root root 15 2022-09-24 16:39 BOOT -> /dev/block/sda5
    lrwxrwxrwx 1 root root 15 2022-09-24 16:39 BOTA0 -> /dev/block/sda1
    lrwxrwxrwx 1 root root 15 2022-09-24 16:39 BOTA1 -> /dev/block/sda2
    lrwxrwxrwx 1 root root 16 2022-09-24 16:39 CACHE -> /dev/block/sda15
    lrwxrwxrwx 1 root root 15 2022-09-24 16:39 CPEFS -> /dev/block/sdd1
    lrwxrwxrwx 1 root root 16 2022-09-24 16:39 CP_DEBUG -> /dev/block/sda17
    lrwxrwxrwx 1 root root 16 2022-09-24 16:39 DNT -> /dev/block/sda10
    lrwxrwxrwx 1 root root 15 2022-09-24 16:39 EFS -> /dev/block/sda3
    lrwxrwxrwx 1 root root 16 2022-09-24 16:39 HIDDEN -> /dev/block/sda16
    lrwxrwxrwx 1 root root 15 2022-09-24 16:39 OTA -> /dev/block/sda7
    lrwxrwxrwx 1 root root 15 2022-09-24 16:39 PARAM -> /dev/block/sda4
    lrwxrwxrwx 1 root root 16 2022-09-24 16:39 PERSDATA -> /dev/block/sda13
    lrwxrwxrwx 1 root root 16 2022-09-24 16:39 PERSISTENT -> /dev/block/sda11
    lrwxrwxrwx 1 root root 15 2022-09-24 16:39 RADIO -> /dev/block/sda8
    lrwxrwxrwx 1 root root 15 2022-09-24 16:39 RECOVERY -> /dev/block/sda6
    lrwxrwxrwx 1 root root 16 2022-09-24 16:39 STEADY -> /dev/block/sda12
    lrwxrwxrwx 1 root root 16 2022-09-24 16:39 SYSTEM -> /dev/block/sda14
    lrwxrwxrwx 1 root root 15 2022-09-24 16:39 TOMBSTONES -> /dev/block/sda9
    lrwxrwxrwx 1 root root 16 2022-09-24 16:39 USERDATA -> /dev/block/sda18
    lrwxrwxrwx 1 root root 14 2022-09-24 16:39 sda -> /dev/block/sda
    lrwxrwxrwx 1 root root 14 2022-09-24 16:39 sdb -> /dev/block/sdb
    lrwxrwxrwx 1 root root 14 2022-09-24 16:39 sdc -> /dev/block/sdc
    lrwxrwxrwx 1 root root 14 2022-09-24 16:39 sdd -> /dev/block/sdd
    heroltexx:/ #
    /dev/block/sda5?

Attached screenshot of what the Magisk App looks like:
View attachment 5719443
Any ideas about how to install Magisk?
The web site magiskapp.com declares (at the very bottom) "This Website Isn't Owned Or Affiliated With Topjohnwu". My immediate reaction is that it is the work of a parasite, and should be avoided.

Did this Samsung device come with /e/OS installed? If not, how did you isntall it?

The John Wu installation instructions describe using Odin. As far as I know, Odin (or Heimdall on Linux) runs on a desktop computer and downloads tar files to an attached device.

You should find an /e/OS forum to ask about what their recovery supports. It does seem reasonable to assume they will "flash" a .ZIP file the way TWRP does, but you know what "assume" does...
 
  • Like
Reactions: ipdev and 73sydney

73sydney

Senior Member
Installing on Samsung S7 (SM-G930F) with /e/OS?
(I've done a bit of installed custom ROMs on all my phones, but I've steered clear of Samsungs up until now so I'm a bit nervous of their 'Download' stuff.)

Preliminaries:
/e/OS: e-1.3-q-20220905216076-stable-herolte.zip
(based on lineageos 18.1)
I've followed these install instructions because it says here that 'Github is the only source where you can get official Magisk information and downloads.'
But, the install instructions here seem pretty complete and 'official'.
(Method 2 Install seems the same as Github install instructions, but Method 1 Install isn't reported on Github. What's official?)
So, first up I am using a Samsung device with Andriod 9.0 or latter, but as I'm using it with /e/OS, I ignored the warning that said: 'If you are using a Samsung device that is launched with Android 9.0 or higher, you can now jump to its own section.' I hope that was correct - but if not, someone please shout!

Steps so far:
  1. Magisk App reports 'Ramdisk: Yes' so, I need a copy of boot.img. Done, extracted from here.
  2. Device does not have separate vbmeta
    Code:
    $ adb shell ls -l /dev/block/by-name|grep vbmeta
    $
  3. At Patching Images I did not have either “Recovery Mode” or “Patch vbmeta in boot image” options so I hope these settings were detected automagically, please shout otherwise
  4. 'Choose “Select and Patch a File” in method, and select the boot/recovery image' was the only option
  5. This is where things got difficult, I couldn't adb pull /sdcard/Download/magisk_patched_[random_strings].img because the output file was written to /storage/emulated/0/Download/magisk_patched-25200_UjUVt.img and /storage/emulated/0/ is only accessible to root via adb and I don't yet have root access... :-/
  6. So, I copied via MTD mount device - like it says not to here... :-/ (Any workarounds?)
  7. Now, I've got my magisk_patched patched image on my PC, what? I'm using a Samsung device with doesn't seem to have normal fastboot but instead has 'Download.' If I boot to fastboot from recovery (it's an /e/OS recovery) it just boots straight to the system; if I boot to fastboot from adb, it just boots straight to the system... I can reboot to Download from Android via the extended reboot menu - but, then when I'm in Download what do I do? fastboot flash boot /path/to/magisk_patched.img isn't going to work...
  8. The /e/OS recovery does offer the option to apply an update from internal storage - should follow the Method 1 Install install from here?
  9. The /e/OS recovery does offer the option to apply an update from ADB Sideload - but... which partition:
    Code:
    heroltexx:/ # ls -l /dev/block/by-name
    total 0
    lrwxrwxrwx 1 root root 15 2022-09-24 16:39 BOOT -> /dev/block/sda5
    lrwxrwxrwx 1 root root 15 2022-09-24 16:39 BOTA0 -> /dev/block/sda1
    lrwxrwxrwx 1 root root 15 2022-09-24 16:39 BOTA1 -> /dev/block/sda2
    lrwxrwxrwx 1 root root 16 2022-09-24 16:39 CACHE -> /dev/block/sda15
    lrwxrwxrwx 1 root root 15 2022-09-24 16:39 CPEFS -> /dev/block/sdd1
    lrwxrwxrwx 1 root root 16 2022-09-24 16:39 CP_DEBUG -> /dev/block/sda17
    lrwxrwxrwx 1 root root 16 2022-09-24 16:39 DNT -> /dev/block/sda10
    lrwxrwxrwx 1 root root 15 2022-09-24 16:39 EFS -> /dev/block/sda3
    lrwxrwxrwx 1 root root 16 2022-09-24 16:39 HIDDEN -> /dev/block/sda16
    lrwxrwxrwx 1 root root 15 2022-09-24 16:39 OTA -> /dev/block/sda7
    lrwxrwxrwx 1 root root 15 2022-09-24 16:39 PARAM -> /dev/block/sda4
    lrwxrwxrwx 1 root root 16 2022-09-24 16:39 PERSDATA -> /dev/block/sda13
    lrwxrwxrwx 1 root root 16 2022-09-24 16:39 PERSISTENT -> /dev/block/sda11
    lrwxrwxrwx 1 root root 15 2022-09-24 16:39 RADIO -> /dev/block/sda8
    lrwxrwxrwx 1 root root 15 2022-09-24 16:39 RECOVERY -> /dev/block/sda6
    lrwxrwxrwx 1 root root 16 2022-09-24 16:39 STEADY -> /dev/block/sda12
    lrwxrwxrwx 1 root root 16 2022-09-24 16:39 SYSTEM -> /dev/block/sda14
    lrwxrwxrwx 1 root root 15 2022-09-24 16:39 TOMBSTONES -> /dev/block/sda9
    lrwxrwxrwx 1 root root 16 2022-09-24 16:39 USERDATA -> /dev/block/sda18
    lrwxrwxrwx 1 root root 14 2022-09-24 16:39 sda -> /dev/block/sda
    lrwxrwxrwx 1 root root 14 2022-09-24 16:39 sdb -> /dev/block/sdb
    lrwxrwxrwx 1 root root 14 2022-09-24 16:39 sdc -> /dev/block/sdc
    lrwxrwxrwx 1 root root 14 2022-09-24 16:39 sdd -> /dev/block/sdd
    heroltexx:/ #
    /dev/block/sda5?

Attached screenshot of what the Magisk App looks like:
View attachment 5719443
Any ideas about how to install Magisk?

#1 - dont reference anything on magiskapp.com

#2 - you'll need to use ODIN to flash to a Samsung if you want to do the boot.img malarkey - best place to find out how to do that for your Samsung is in the Samsung S7 threads for your device. Ideally you would look for a post on how to install custom Recovery (TWRP) and then just simply flash the magisk.apk (renamed to magisk.zip) from TWRP which would bypass all the patching malarkey and root you automagically....i still do this on my S20, rather than patch the boot image and flash via ODIN, because im notoriously lazy


I would change topjohnwu's instructions to read (because patching a multi gigabyte AP file is a LONG wait - my devices AP is 7gb long) (my changes in orange, this is how i do it on my S20 if i do use boot image patch and ODIN):​

  • [On your PC] Use either samfirm.js, Frija, or Samloader to download the latest firmware zip of your device directly from Samsung servers
  • [On your PC] Install z-7ip
  • [On your PC] Unzip the firmware and extract the AP tar file. It is normally named as AP_[device_model_sw_ver].tar.md5
  • [On your PC] Open the AP_[device_model_sw_ver].tar.md5 from right click context menu select 7-zip -> Open Archive and extract:
boot.img.lz4
vbmeta.img.lz4 (if its listed)
  • [On your PC] Select both files and right click and from right click context menu select 7-zip -> Add To Archive
  • change Archive (name -1st box onscreen) to something like boot.tar and Archive Format to tar, and click OK to create tar archive
  • move boot.tar to mobile device
  • Press the Install button in the Magisk card
  • If your device does NOT have boot ramdisk, check the “Recovery Mode” option
  • Choose “Select and Patch a File” in method, and select the boot.tar file
  • Move the /sdcard/Download/magisk_patched.tar file to PC
  • Code:
    adb pull /sdcard/Download/magisk_patched_[random_strings].tar)
  • Reboot to download mode. Open Odin on your PC, and flash magisk_patched.tar as AP.
  • Your device should reboot automatically once Odin finished flashing.
  • Install the Magisk app you’ve already downloaded and launch the app. It should show a dialog asking for additional setup.
  • Let the app do its job and automatically reboot the device. Voila!
 
Last edited:
  • Like
Reactions: ipdev and J.Michael

MorganXYZ

Member
Jun 28, 2021
26
11
Did this Samsung device come with /e/OS installed? If not, how did you isntall it?
@J.Michael I just used the auto-installer provided by /e/os - it worked like a treat, never had a more straight forward and easy flash of my device: What is the /e/OS easy-installer? I was really quite amazed.

Thanks @73sydney , that's going to take me a moment or two to work through - but, I'll be using heimdall/ heimdall-frontend - all this weird Samsung stuff is very disconcerting... Do you have any inkling whether that'll make much difference?

But, just reading more closely - those instructions are assuming that the device has Samsung software on it, but wouldn't that have all been blown away by the /e/os stuff?
 

73sydney

Senior Member
@J.Michael I just used the auto-installer provided by /e/os - it worked like a treat, never had a more straight forward and easy flash of my device: What is the /e/OS easy-installer? I was really quite amazed.

Thanks @73sydney , that's going to take me a moment or two to work through - but, I'll be using heimdall/ heimdall-frontend - all this weird Samsung stuff is very disconcerting... Do you have any inkling whether that'll make much difference?

But, just reading more closely - those instructions are assuming that the device has Samsung software on it, but wouldn't that have all been blown away by the /e/os stuff?

Ive never used heimdall because it seemed like a lot of faffing about, but perhaps youre using it because youre not on Windows? otherwise if you are on windows, you must just love punishing yourself and doing things the hard way :)

ODIN/heimdall doesnt matter, is just going to be writing a boot image, it doesnt know you dont have Samsung software on there...its not writing or looking beyond the boot block
 

MorganXYZ

Member
Jun 28, 2021
26
11
because youre not on Windows?
Haven't allowed Windoze to sully my life in 20 years ;)
This is what's in /e/OS: e-1.3-q-20220905216076-stable-herolte.zip :
Code:
$ unzip -l e-1.3-q-20220905216076-stable-herolte.zip
Archive:  e-1.3-q-20220905216076-stable-herolte.zip
signed by SignApk
  Length      Date    Time    Name
---------  ---------- -----   ----
      363  2009-01-01 00:00   META-INF/com/android/metadata
977107715  2009-01-01 00:00   system.new.dat.br
        0  2009-01-01 00:00   system.patch.dat
  2097640  2009-01-01 00:00   META-INF/com/google/android/update-binary
     5368  2009-01-01 00:00   META-INF/com/google/android/updater-script
 36689936  2009-01-01 00:00   boot.img
  2445584  2009-01-01 00:00   firmware-update/F_cm.bin
 40046256  2009-01-01 00:00   firmware-update/F_modem.bin
  1218560  2009-01-01 00:00   firmware-update/F_param.bin
  1777936  2009-01-01 00:00   firmware-update/F_sboot.bin
  2445584  2009-01-01 00:00   firmware-update/K_cm.bin
 38889200  2009-01-01 00:00   firmware-update/K_modem.bin
  1525760  2009-01-01 00:00   firmware-update/K_param.bin
  1777936  2009-01-01 00:00   firmware-update/K_sboot.bin
  2445584  2009-01-01 00:00   firmware-update/L_cm.bin
 38879280  2009-01-01 00:00   firmware-update/L_modem.bin
  1525760  2009-01-01 00:00   firmware-update/L_param.bin
  1777936  2009-01-01 00:00   firmware-update/L_sboot.bin
  2445584  2009-01-01 00:00   firmware-update/S_cm.bin
 38887888  2009-01-01 00:00   firmware-update/S_modem.bin
  1525760  2009-01-01 00:00   firmware-update/S_param.bin
  1777936  2009-01-01 00:00   firmware-update/S_sboot.bin
  2445584  2009-01-01 00:00   firmware-update/W8_cm.bin
 39115376  2009-01-01 00:00   firmware-update/W8_modem.bin
  1218560  2009-01-01 00:00   firmware-update/W8_param.bin
  1777936  2009-01-01 00:00   firmware-update/W8_sboot.bin
     1184  2009-01-01 00:00   firmware-update/filemap
 45320208  2009-01-01 00:00   firmware-update/recovery.img
     1028  2009-01-01 00:00   install/bin/backuptool.functions
     2233  2009-01-01 00:00   install/bin/backuptool.sh
   794752  2009-01-01 00:00   install/bin/resize2fs_static
    12651  2009-01-01 00:00   system.transfer.list
     1456  2009-01-01 00:00   META-INF/com/android/otacert
---------                     -------
1285984534                     33 files
$
That doesn't seem to have anything like
... AP tar file. It is normally named as AP_[device_model_sw_ver].tar.md5
But, does have boot.img
?

Can Odin/ heimdall be used to install boot.img to the correct partition? Which I'm guessing, looking at:
Code:
heroltexx:/ # ls -l /dev/block/by-name
total 0
lrwxrwxrwx 1 root root 15 2022-09-24 16:39 BOOT -> /dev/block/sda5
...
Above, would be /dev/block/sda5
?
(I'm really floundering around in the dark here...)
 
Last edited:

73sydney

Senior Member
Haven't allowed Windoze to sully my life in 20 years ;)
This is what's in /e/OS: e-1.3-q-20220905216076-stable-herolte.zip :
Code:
$ unzip -l e-1.3-q-20220905216076-stable-herolte.zip
Archive:  e-1.3-q-20220905216076-stable-herolte.zip
signed by SignApk
  Length      Date    Time    Name
---------  ---------- -----   ----
      363  2009-01-01 00:00   META-INF/com/android/metadata
977107715  2009-01-01 00:00   system.new.dat.br
        0  2009-01-01 00:00   system.patch.dat
  2097640  2009-01-01 00:00   META-INF/com/google/android/update-binary
     5368  2009-01-01 00:00   META-INF/com/google/android/updater-script
 36689936  2009-01-01 00:00   boot.img
  2445584  2009-01-01 00:00   firmware-update/F_cm.bin
 40046256  2009-01-01 00:00   firmware-update/F_modem.bin
  1218560  2009-01-01 00:00   firmware-update/F_param.bin
  1777936  2009-01-01 00:00   firmware-update/F_sboot.bin
  2445584  2009-01-01 00:00   firmware-update/K_cm.bin
 38889200  2009-01-01 00:00   firmware-update/K_modem.bin
  1525760  2009-01-01 00:00   firmware-update/K_param.bin
  1777936  2009-01-01 00:00   firmware-update/K_sboot.bin
  2445584  2009-01-01 00:00   firmware-update/L_cm.bin
 38879280  2009-01-01 00:00   firmware-update/L_modem.bin
  1525760  2009-01-01 00:00   firmware-update/L_param.bin
  1777936  2009-01-01 00:00   firmware-update/L_sboot.bin
  2445584  2009-01-01 00:00   firmware-update/S_cm.bin
 38887888  2009-01-01 00:00   firmware-update/S_modem.bin
  1525760  2009-01-01 00:00   firmware-update/S_param.bin
  1777936  2009-01-01 00:00   firmware-update/S_sboot.bin
  2445584  2009-01-01 00:00   firmware-update/W8_cm.bin
 39115376  2009-01-01 00:00   firmware-update/W8_modem.bin
  1218560  2009-01-01 00:00   firmware-update/W8_param.bin
  1777936  2009-01-01 00:00   firmware-update/W8_sboot.bin
     1184  2009-01-01 00:00   firmware-update/filemap
 45320208  2009-01-01 00:00   firmware-update/recovery.img
     1028  2009-01-01 00:00   install/bin/backuptool.functions
     2233  2009-01-01 00:00   install/bin/backuptool.sh
   794752  2009-01-01 00:00   install/bin/resize2fs_static
    12651  2009-01-01 00:00   system.transfer.list
     1456  2009-01-01 00:00   META-INF/com/android/otacert
---------                     -------
1285984534                     33 files
$
That doesn't seem to have anything like

But, does have boot.img
?

Can Odin/ heimdall be used to install boot.img to the correct partition? Which I'm guessing, looking at:
Code:
heroltexx:/ # ls -l /dev/block/by-name
total 0
lrwxrwxrwx 1 root root 15 2022-09-24 16:39 BOOT -> /dev/block/sda5
...
Above, would be /dev/block/sda5
?
(I'm really floundering around in the dark here...)

Those modified instructions mentioning .tar files are for stock Samsung ROM's, i was pointing out a deficiency in johns instructions, it wasnt meant to be a direct roadplan for your particular issue.

All you need on that custom one is the boot.img, patch it and then send it to the correct partition, which i dont know how to do with heimdall as ive specifically avoided it since the dawn of Android time.

Just think, if you had windows, you’d have been done by now :)
 
Last edited:

Sarosh Ishfaq

New member
Sep 6, 2014
1
0
Bhawalnagar
I have problem to update Magisk in samsung note 9 sm-n960f/ds. Please help
Screenshot_20220925-144244.jpg
 

Attachments

  • Screenshot_20220925-145712.jpg
    Screenshot_20220925-145712.jpg
    135.7 KB · Views: 36
  • Screenshot_20220925-145753_Yet Another SafetyNet Attestation Checker.jpg
    Screenshot_20220925-145753_Yet Another SafetyNet Attestation Checker.jpg
    124.8 KB · Views: 36

pndwal

Senior Member
I have problem to update Magisk in samsung note 9 sm-n960f/ds. Please help
View attachment 5719965
You need to do just as the message above states; download ROM corresponding exactly with current version (especially if you took OTAs since first Magisk installation), patch the AP binary and Odin flash all 4 binaries per 'Samsung (System-as-root)' section in Installation Instruction page under 'Upgrading the OS' (even though you're not 😉 ): Flash magisk_patched.tar as AP, together with BL, CP, and HOME_CSC...

(- Please say if you use a custom ROM... May have additional issues...)

This is needed because refactoring of magiskinit injection in 25+ has broken Direct Install (when updating previously patched boot images) in a number of 2SI boot type devices as images w/ patched fstab (no longer done) are now incompatible with magiskboot patching... Instructions for patching / flashing Magisk from unpatched images still works fine...

Further, since updating your legacy ramdisk boot type device to Android 10 it has been automatically updated to 2SI boot type... As such 'Samsung (System-as-root)' section (methods, precautions, warnings) has information pertinent to your device despite the message "If your Samsung device is NOT launched with Android 9.0 or higher, you are reading the wrong section". (- This was true at the time of writing however since no Sammy devices yet had A10)...

👀 PW
 
Last edited:

pndwal

Senior Member
yes gsi was smooth.

google A13 and i just discovered LeOS beta based on android 13 works fine too but there are no google apps. it is very smooth. and yes i did flash all the other binaries along with the patched ap file. i also have twrp installed and vb meta disabler.tar flashed along with it. thats how i install gsi's through twrp
oh its not about magisk the A13 image didnt even boot at all no matter what i did. this build was actually based on sooti's android 13 aosp which didnt boot on alot of devices including mine soo it makes sense. maybe some better gsi will pop up eventually. but thanks
... Just a couple of thoughts:

ROM Devs properly don't distribute GApps with ROM if they care about Google's rules / licensing for proprietary code, however these are easy to 'sideload', and distributions for this purpose, ie. for personal installation by end user on certified (licenced) or Google Registered (whitelisted for custom ROM use by submitting Google Services Framework Android ID) devices, are permitted / sanctioned by Google... You should be able to install OpenGapps, BitGapps, NIKGapps or other distributions after installing a ROM lacking these...

If you can get a fastboot type distribution of your desired ROM you may have more success, and even with a recovery ROM you should be may be able to extract vbmeta partition and flash it with the following switches:
fastboot flash vbmeta --disable-verity --disable-verification vbmeta.img
per official Magisk (optional) instructions:
https://topjohnwu.github.io/Magisk/install.html#patching-images
instead of using 3rd party vbmeta disabling methods... I really don't know if this will help, but may be worth a shot...

🙂 PW
 
  • Like
Reactions: J.Michael

Top Liked Posts

  • 3
    Too much to read 2000+pages. Where are you hiding the modules? I need them all and I'm sure they are in a box somewhere for me to root through. 😁
    The modules are hidden where a number of posts say they are. There is a not-official-John-Wu repository. I remember the name "Orange Fox" -- it might be that; it might be something else entirely.

    The thread search function is not entirely unusable. @IronTechmonkey has instructions in his signature. (I use a browser, and if I click enough I manage to select "This thread" when searching. The XDA app has bigger problems with searching.
    3
    so just an update. I finally found the solution for this. If you have a xiaomi.eu rom check this thread: https://xiaomi.eu/community/threads/widevine-l1-support.65671/ . If your device is supported for widevine L1 certificate renewal then you won't have a problem getting it back. mine was L3 before, but after doing this fix, I got it back up to L1. now I can watch FHD in my disney+ app. btw my device has unlocked bootloader and is rooted.
    Haha... We've been discussing this very fix for broken Xiaomi updates (affects un-modded locked devices also) on last few pages!

    That's why I asked you to "Check Widevine security level" originally! ... Expected you to use DRM Info app per the link, however you posted fingerprint payment menu which did seem to indicate you had L1... Guess you didn't...

    Restoring L1 is generally the answer... Still not sure why @Drahy (on Sammy device, above) is having such difficulties even with L1...

    Glad you stumbled on the late-MIUI Xiaomi inbuilt fix anyway...

    Also, thanks for the excellent link:
    https://xiaomi.eu/community/threads/widevine-l1-support.65671/
    ... it confirms a few things we were only speculating on here:

    1) XiaomiEU custom MIUI seems to give native access to the menu for generating new keys / certificate (after keys are revoked), and

    2) Xiaomi models w/ support for generating keys / certificate... Seems MTK model users and some others are out of luck... 😕 Extensive list given...

    🤠 PW
    2
    It was not like that.

    I was just answering the same questions over and over mentioning exact link for libencrypto and people asking me what I used ...
    and I felt you only want to answer some questions as I had to ask more than once... 🙃
    then I specifically wrote mods I use and still got questions for that it seemed to me like I am going in circles so I just asked if that was not understandable the first time? There was no frustration from my side...
    But you hadn't clarified... maybe in your mind...
    In my first post I wrote: "I am using Samsung Galaxy Note 20 Ultra 5G, Android 13 November update - original firmware rooted with Magisk + Universal Safetynet + Zygisk ..." - Not sure how more clear I could be than that
    Since you're still not letting go of assumptions I'll explain further, despite it being a circular argument... 😝

    If you check Google Pay discussion thread you'll see many members had USNF + added a mismatched fingerprint (globally applied) using MHPC long before @Displax's USNF mod w/ (partial) Play Integrity fix (which does the same thing but targets gms) even existed (and @Displax was watching these developments in that thread), and that many continue to use this setup... You DID NOT state you had @ Displax (targeted) mod EVEN WHEN ASKED, and as you said you used MHPC in conjunction with USNF it appeared that you were likely passing deviceIntegrity verdict this way, like many others... - Not sure how more clear I could be than that...
    ... I also wrote that in this setting I am using Netflix with no problems but other streaming apps are not working ... they only work with that additional mod which loweres the streaming to L3... Really not sure how more clear I could have been - maybe next time :)
    I already covered why I wasn't sure you actually had L1 at that point since you never stated that plainly and you only said "Netflix is ok" (many users consider Netflix works fine w/ SD having never had L1 compatible hardware anyway)... Further, you didn't state how you were seeing "it goes to L3 with bad quality streams" despite my asking. (Thinking: 'perhaps you see L3 somewhere (where?) but never actually had L1 since streaming didn't even work w/o liboemcrypto-disabler mod')...
    ... I also wrote that in this setting I am using Netflix with no problems but other streaming apps are not working ... they only work with that additional mod which loweres the streaming to L3 which is basicly what that mode does...
    Well that's not really the purpose of the mod...

    Actually the mod simply masks liboemcrypto.so library, and L3 is just a consequence...

    Apps can use liboemcrypto.so for decrypting both SD and HD streams, but the library is required for HD... Apps can fall back to other libraries where liboemcrypto.so doesn't exist but HD streaming will fail as will L1 security check...

    It seems that affected apps are not allowing liboemcrypto.so use for ANY streaming and root detection (or possibly even detection that existing hardware for TEE decryption exists and should be used... Could be using model / other props with their own model whitelist too...) seems to be the likely reason to me... Ie. it's likely that these apps are simply restricting their use to SD decoding with older libraries (as liboemcrypto.so is primarily designed to decrypt HD content in secure TEE OS) rather than preventing apps from working on devices w/o hardware TEE...

    Netflix does this too BTW, but relies wholly on Widevine certification since v5.0, making their approach much simpler...
    ... Really not sure how more clear I could have been - maybe next time :)
    Those helping here often have information you aren't aware of and are looking at issues from a different angle... Which is really why you ask here in the first place...

    Helpers shouldn't have to explain every reason for requesting information when analysing an issue; It's very helpful when members simply provide details of setup initially and further details as requested...

    Others are trying to think outside the box on your behalf... Let them!...
    Screenshots confirmed my setup and without Displax mod I could not pass safetynet
    ... I think you mean Play Integrity deviceIntegrity here(?)
    with my previously mentioned setup of course but I get your fear of assumption now.
    It's dangerous to assume anything when diagnosing issues on other's devices... This is actually a case in point: You CAN pass PI deviceIntegrity w/o Displax mod (as I've stated before)... You may not have tried/achieved that, but many do...
    Thank you for your try to help me anyway, I appreciate it ... Will look for solution elswhere and hope.
    All best on your quest... Hope something here was helpful... PW
    2
    can someone help me with my disney+ app issue. so I have:
    Xiaomi POCO X3 NFC
    xiaomi.eu MIUI v13.0.1
    Android 12
    Magisk v25.2
    USNF v2.3.1 (Displax mod)

    my problem is I can't watch any of their content on FHD, it only shows up to HD quality even though I've subcribed to premium. I've tried logging in the same account on the same device model but w/ locked bootloader and stock rom and it has a FHD quality option. I've also added disney+ to denylist but the issue still persist. I've checked if my device is certified using Play Integrity API Checker (Nikolas Spiridakis). Here's the result:
    so just an update. I finally found the solution for this. If you have a xiaomi.eu rom check this thread: https://xiaomi.eu/community/threads/widevine-l1-support.65671/ . If your device is supported for widevine L1 certificate renewal then you won't have a problem getting it back. mine was L3 before, but after doing this fix, I got it back up to L1. now I can watch FHD in my disney+ app. btw my device has unlocked bootloader and is rooted.
    2
    I was just hoping that there was a library for modules so that I could learn more about them and how to use them. I used search and did not find an easy to understand answer. I then turned to you/this thread for help and support. I'm new to the magisk.

    You could review

    And use foxmm for module management
  • 8
    New Shamiko-v0.6(126)

    With this new Shamiko, Momo does no more detect Zygisk and Zygote (official latest Magisk Canary 25205, Zygisk enabled, DenyList configured and not enforced, Shamiko v0.6 in default black-list mode)
    7
    Just Curious
    Which command did you use to flash the patched_magisk...img with?
    1. fastboot flash init_boot magisk_patched...img
      or
    2. fastboot boot init_boot magisk_patched...img
    I think they both will work. :)
    Personally, unless booting an image is not an option..

    I always test boot the Magisk patched image using fastboot boot NameOfFile.img instead of flashing it.
    If it boots, Magisk will be active and I then use the Direct install option to make it permanent.
    If it does not boot, then no harm since the stock boot image is still installed. 🙃

    Cheers. :cowboy:
    7
    S-Check:

    Root detection, as on the screenshot

    I can pass with Delta but cannot with TJW Canary

    Delta:
    latest, Zygisk, MagiskHide, no Shamiko, App Data Isolation, HMA

    Canary:
    latest, Zygisk, DenyList, Shamiko, App Data Isolation, HMA, even with Magisk app uninstalled

    I have tested thoroughly on my two Xiaomi phones, one with A11 and the other with A12.
    Tested on both phones with Canary and with Delta - and I have the same results on both phones

    Not to mention that I fully pass Oprek, Ruru, TB-Checker, SafetyNet/Play Integrity
    Yup, Native bridge loading based on Maru Magisk fork implementation of Riru's loading method seems to have much merit...

    Nb. Original author says it's an experiment however, still not perfectly implemented and may be issues w/ some modules... Also Shamiko hiding with probably not work properly with this... Long read here for those interested:
    https://github.com/5ec1cff/my-notes/blob/master/maru.md

    For others, I put more here too:
    https://forum.xda-developers.com/t/...third-party-magisk-fork.4460555/post-87729841

    🙂 PW
    Worth pointing out that @zgfg asked me to test that on Magisk Canary (official) earlier but ive broken something it seems with my uber Samsung debloat and cant get S-check to even open anymore :)

    Anyone else care to chime in with Magisk Canary (official)
    I had that issue a while back, I do not remember what I did to fix it. :unsure:
    I just setup my Pixel 5a (it did not like updating from July to November 🙄) so clean flash. 😛

    No issues with Security Check. 🙂

    Pixel 6 - Stock Google 12L (July 2022).
    Pixel 5a - Stock Google 13 (November 2022).

    Magisk debug (snapshot)
    - Personal build from the official branch, so it includes the commits since the last canary/debug release.
    Magisk - [GitHub] - Building and Development

    USNF - Not the one that includes Displax's changes.
    - Personal test build that includes some other (mostly prop) changes.
    Fork - [GitHub] - commits
    One of these days I will have to pull Displax's Zygisk changes. 🙃

    MHPC
    - Set fingerprint back to stock Pixel 12.
    Pixel 6 is using the Pixel 6 12 print, 5a is using the 5a 12 print.

    Shamiko and LSPosed modules.

    HMA (Beta v3.0.5 r373)
    Two templates.
    Magisk
    - Settings (renamed Magisk app).
    - Hide My Applist.

    PlayStore
    - YouTube
    - YouTube Music​

    AdAway running in VPN (non-root) mode. ;)

    Cheers. :cowboy:
    6
    Personally, unless booting an image is not an option..

    I always test boot the Magisk patched image using fastboot boot NameOfFile.img instead of flashing it.
    If it boots, Magisk will be active and I then use the Direct install option to make it permanent.
    If it does not boot, then no harm since the stock boot image is still installed. 🙃

    Cheers. :cowboy:
    Some have said it's a waste of time to test by booting first, then direct installing because you can just flash the stock image back if it doesn't work.
    This maybe true, but directly flashing the patched image does NOT give Magisk the chance to back up the stock boot image, whereas booting then installing does.
    This makes it easier to take an OTA update on devices that require everything to be pure stock before proceeding by using Magisk's restore images function.
    6
    Hello everyone!

    Thank you for the very active thread i finally managed to figure out what i did wrong (yet again).

    I rarely tinker with the device, and when i am forced to, then i forget about A/B partitions, and wipe boot.img.

    I was hoping there is now another way for keeping TWRP and Magisk. Aside from embedding twrp image in stock boot, and than patching from magisk manager?

    Thank you.

    Also if someone more knowledgeable could help (even though it is slightly Offtopic), do i patch boot img with firmware boot img, or boot img from the custom rom i was using?

    Because that rom was then for testing (even though i kept it), and i can't figure out the version.
    I suspect when i run adb shell getprop "ro.product.version" it will probably fail, because i did a number on that device trying to fix it without understanding A/B partitions.
    Only if you don't have Recovery partition, then you patch TWRP to Boot (and afterwards the Magisk)

    (It's not necessarily specific to A/B devices - there are A/B devices that do have separated Boot and Recovery partitions, and in that case TWRP goes to Recovery partition, Magisk to Boot)

    But when you update Magisk, you can just take Direct Install (update)

    ---

    And of course, you must patch the boot.img corresponding to your current ROM. Usually, you can find it in the ROM zip file

    If you use some stock boot.img instead, then you risk the bootloop (of course, if boot img from your custom ROM coincides with the stock boot img then it doesn't matter, but usually it won't be the case - or you will not know

    That does not depend on Magisk - if the boot.img is wrong and you flash it (with or without Magisk) it will cause the bootloop (in the 'better' case, it may boot but you might have troubles later because of eg the wrong Kernel).
    Hence make sure to always use (for patching) the correct boot img
  • 1089
    This is the place for general support and discussion regarding "Public Releases", which includes both stable and beta releases.
    All information, including troubleshoot guides and notes, are in the Announcement Thread
    156
    Hello, I haven't given much support on XDA lately. It can be resulted from
    • University started and I have limited free time. In fact, I mostly develop during midnight
    • I live in Taiwan, which has large time zone differences between my European/American contributors/testers, which usually forces me to stay up late at night to discuss/test stuffs.
    • The new version is about to come, I don't want to spend effort on supporting old releases
    The planned update is delayed again and again, to some point I think I'll shed some light about what has been happening lately, also along with some announcements.

    New Forum!
    As you might have already discovered, Magisk got its own subforum on XDA! Many thanks to all the support you gave me, and much more information/features/support is about to come!
    **For developers supporting all the devices that are not using standard Android boot format, feel free to create threads in this section (actually, PLEASE do so) for your favorite devices after v7 is out. As I currently know, Asus devices require signing the boot image before flashing, and is model dependant; Sony devices seems to use ELF kernel that is unpatchable, or some has two ramdisks (inner + outer), both requires different workarounds; LG bootloader locked devices has to manually "BUMP" the boot image after flashing Magisk..... and there may be lots of other crazy boot image formats that haven't come up to my attention yet.
    It is impossible for me to support all these non-standard boot images, and I hope the community can collaborate to make Magisk running across all the devices. Overall, community collaboration is what XDA about :D

    The Pixel Phone
    Some of you might already know this news, that the next Pixel Phone right around the corner seems like it does not have ramdisk in boot image, which pretty much wrecked Magisk in all ways. However, it pretty much doomed root itself too. Kernel modifications is inevitable IMO, so I'll try to migrate my scripts to C programs that could possibly be included into the kernel itself. Note that I'm not familiar with linux kernel, I'm not even sure if my idea and concept is correct or not. But once the device is available, I think developers will find a way to bypass all the difficulties, and I'll do my best to learn things ;)

    Current Progress
    In the past month, I've spent quite some time learning SELinux, so that I can avoid using SuperSU's sepolicy patches. Thanks to the helps and tips from @phhusson and @Chainfire, I finally have a much clearer understanding of how SELinux works. The Magisk core parts (the scripts, boot image patches, new features, more supports) are actually done some time ago. What is causing all the delays is the Magisk Manager.
    To be completely honest, although I can code in Java without much issues, Magisk Manager is actually my first Android application, I had to reach out for assistance, and fortunately awesome developers like @DVDandroid and @digitalhigh contributed a lot, which makes the current Manager awesome.
    After the repo system and module management is mostly done, I was about to do some adjustments and release, but what we really done is decided to add another feature: auto-unroot with per-app settings. I decided to wait for it to be finished, and then do my adjustments. Due to reasons that'll be mentioned later, this feature will likely not be available for the next release (should come in future updates)

    Safety Net Disaster
    Those who are using Magisk for Safety Net bypass purposes must have known that Google recently updated the detection method of my Systemless Xposed. I still have no idea what Safety Net is detecting, so currently I cannot fix it on my side (also because I'm busy working on the next update). However, suhide developed by @Chainfire is able to hide Xposed and worked fine.
    However, only my Systemless Xposed v86.2, which is based on SuperSU's su.d, is supported using that method. v86.2 and v86.5 (latest, Magisk based) have nearly identical binaries, and the only difference is the path where the binaries are stored.
    I'm still not sure what's the real issue for it not being supported, I just hope it is not done intentionally.

    Conclusion
    Due to the fact that my Safety Net bypass is not 100% perfect now, I do not want to spend any more time waiting for auto-unroot to be polished. What I'm doing now is finishing up all the things I'd like to change in Magisk Manager (it has been a while since I last contributed to Manager, my fellow developers are doing all the heavy job), which might take a little more time, after that, packed with tons of information to be announced in Magisk Section, I'll release the long awaited update.

    Hope this lengthy post gives you the idea of the whole situation, and again thanks for all your support!!
    121
    Ah, some Chainfire bashing, I hope it is not too late for me to exercise additional villainy.

    First, let me make clear I have nothing against @topjohnwu, nor against Magisk. Magisk is an interesting project and it certainly displays @topjohnwu ingenuity and persistence. I don't doubt we will see more interesting things from his hands.

    -------------------------

    What has happened here is not all that dark and complicated, from either end. I returned from holidays, and someone pointed me at Magisk. My first thought: interesting!

    Among other things, the thread lists some issues with SuperSU, which in combination with the phrase The developer also requests users to not bug Chainfire with compatibility requests for SuperSU with Magisk from the portal article, raised my left eyebrow by nigh half an inch. The popular systemless xposed mod is apparently now based on it, and apparently it now no longer works with SuperSU, and apparently I'm not supposed to fix that, nor any of the other found issues. I found that a bit weird. So yes, I have told @topjohnwu that I was a bit surprised he was posting about issues with SuperSU without notifying me about them (I can't fix or help fix issues I'm not aware of, after all).

    He's also spreading a modified version of the SuperSU package, which is not all that uncommon, nor necessarily a problem. I have not looked into what he modified, I only ran a few quick tests on one of my devices, and found some commonly used commands run as root to be broken. I have informed him of this as well.

    It appears the tool of choice for Magisk is phh's Superuser, because of some of the mentioned issues with SuperSU. That's fine by itself, but fixing issues in that superuser by incorporating SuperSU's binaries into it is a somewhat questionable practise. After all, SuperSU is a commercial closed-source package that helps pay for my dinner, and superuser is a direct competitor. I have informed him that I was surprised he did this without asking for permission. I have expressed similar surprise on him spreading a modified version of LiveBoot (which helps pay for a snack now and then).
    @topjohnwu has also stated that Magisk's scripts are largely influenced by mine (I have not checked). Scripts based on mine are used all over the place on XDA, some people have crafted amazing things based on them, I have never made an issue of this (otherwise I would have just made them binaries). But yes, I have also stated to him that I don't think it's very nice to base something on one program, and then using that to (almost exclusively) push something directly competing with that program.

    tl;dr Towards @topjohnwu, I have:
    - expressed surprise he has issues getting Magisk to work with SuperSU, and has chosen not to inform me about those
    - expressed surprise he is using SuperSU binaries in a competing superuser without permission
    - expressed surprise he is posting a modified LiveBoot without permission
    - informed him of issues with the modified SuperSU he has posted
    - let him know I thought it wasn't very nice to be applying my scripts to benefit seemingly exclusively that same competing superuser

    To be crystal clear:
    - I have not asked for an apology
    - I have not asked for Magisk to be abandoned, neither the root hiding nor systemless module parts, and certainly not systemless xposed
    - I have not made an issue of any of this anywhere, until this post
    - I have not even specifically asked for anything to be taken down (though obviously in my opinion the other superuser package mixed with SuperSU's binaries, as well as the LiveBoot package, should go)
    - I have not reported this thread to XDA moderators for copyright violations or otherwise

    While my conversation with @topjohnwu may not win any awards for being friendly (though it may win some for brevity), I think all things considered my response has been rather mild. To be perfectly honest, until the apology post, I thought this was over with already. I think the apology post was triggered because I haven't replied to his last PM for a while - I was in the zone, it happens.

    To emphasize again, I have nothing against @topjohnwu, Magisk, or systemless xposed, and it is certainly not my goal to see any of them go. If it can be made to work together with SuperSU, great.

    I get it though: you think of something, you want to see if you can make it work, you finally get it to work, you publish it, it takes off - enthusiasm gets the better of you. Maybe in the rush some mistakes are made. That doesn't mean you have to just drop it and run. None of my stuff would make it past 0.1 if I stopped at the first big mistake :)

    Aside from said being in the zone coding, I usually regret actually responding to these sort of things the day after, which has made me hesitant to reply. Surprise me.
    76
    Thread temporarily closed so everyone sees this.

    The flood of "SafetyNet isn't working for me either!" posts are not helpful, at all. Please refrain from posting further, it will be looked into. Please do not forget that not passing SafetyNet is 100% NORMAL AND INTENDED when you have an unlocked booloader or running custom firmware. These are workarounds and they will be worked around in turn.

    The Flash
    Forum Moderator

    EDIT: Thread is reopened... I will be cleaning any SafetyNet posts for a while to keep the thread clean for real issues.
    75
    Hello everyone!

    I am aware that Google has updated Safety Net that makes Magisk itself a no go for Android Pay. In fact, I witnessed the change live while I am developing the new magiskhide, which should hide all Magisk modules and Magisk installed root.

    Google is serious about Safety Net now, clearly hunting down all possibility to run Xposed with Safety Net passed. I spend quite some time examining the new security measures last midnight, and fortunately it seems that it is possible to run Magisk and root along with Safety Net if no Xposed is running. I'm glad I removed the old root toggle at the right time lol, that is no longer feasible with the latest detection.

    So stay tuned for the next update, it will come with bug fixes, along with the new magiskhide to bypass that Safety Net.

    Google, how will a few systemless mods do any harm :p:p