Magisk General Support / Discussion

Search This thread
They won't, as I said...

Actually it seems you may have lost some Sammy features in addition to 'corporate' ones incl. Samsung Pay... See this:
What happens if I root my device that is running a Knox service?
https://docs.samsungknox.com/admin/knox-platform-for-enterprise/faqs/faq-115013719548.htm

I think that can happen simply by rooting... Hence John's 'OTA Upgrade Guides' doc says:

https://github.com/topjohnwu/Magisk/blob/master/docs/ota.md#prerequisites

👀 PW
wow- it failed anyways. sometimes it did brick itself but i was done with one ui for this phone anyways
 

badabing2003

Recognized Contributor
Sep 17, 2012
1,420
1,647
Maybe if it didnt tend to be post after post
For heaven's sake I only have a handful of posts in this thread.
(along with a large graphic signature promoting software) that tends to dominate the thread when you post here
The last I checked you can turn of signature display,
and detract from people asking actual general questions
Yeah, I'm detracting people asking questions because I'm asking a relevant question? in 53k + posts thread?
Then theres the fact that no one here is an active developer on magisk and yet youre asking development questions
To answer my questions they don't have to be active developers, they just have to be knowledgeable (and courteous) which most are.
Generally threads at least in my experience have always been separated on XDA, go and look at any devices section, theres one for development, and one for Q&A
Care to suggest which device development thread I should post Magisk questions (which is not a device by the way), take a look where this thread is under.
1665156856733.png


I get it, you don't like me, that's fine, you don't have to, I see that you get irritated easily, I'm not hijacking the thread, unlike endless other discussions.

Please ignore me and my posts, just like I will to you, and if you see me violating any forum rules, please bring it up to the attention of forum moderators, all I'm trying to do is learn and help the best way I can.
 

badabing2003

Recognized Contributor
Sep 17, 2012
1,420
1,647
But not yet!

... And , of course, you're only speaking of the (small) subset of apps who's Devs require proper attestation to an unmodified execution environment, and who's designs you want to take advantage of while circumventing the same... and their wishes...

The vast majority of apps are not threatened at all!

... And not yet because Google has clearly been in no great rush to fix that attestation...

And of course many of us thought this would have been achieved years ago!... Ie. Game Over for the mouse... But the Cat hasn't killed the mouse yet; it's still playing with it... so the game continues!

Fun eh! (?)...

... Bye, MagiskHide. Long live MagiskHide (Wu) - PW

Perspective is a funny thing...
Hope you're right, but I'm seeing useless apps checking for root.
Can you guess what app is this?
Hint, it's not a bank app ;)
1665157881445.png
 
Hope you're right, but I'm seeing useless apps checking for root.
Can you guess what app is this?
Hint, it's not a bank app ;)
View attachment 5729465
even my stupid chinese unsecure filled with ads camera app detects root. although i was able to bypass it somehow. i am running a gsi that passes safety net automatically once i use shamiko to hide magisk from play services. all apps do not detect root and run fine now
 

wugga3

Senior Member
Oct 15, 2014
112
36
Ontario
OnePlus 7T
Hope you're right, but I'm seeing useless apps checking for root.
Can you guess what app is this?
Hint, it's not a bank app ;)
View attachment 5729465
Still haven't gotten the stupid weather network app to work with root... Don't use payment apps but 2 big bank apps and one payroll app all still work so I'll stick to OnePlus weather app lol

Edits:. OnePlus gets me the Weather Channel... so good enough ...
 
Last edited:
  • Like
Reactions: badabing2003
Still haven't gotten the stupid weather network app to work with root... Don't use payment apps but 2 big bank apps and one payroll app all still work so I'll stick to OnePlus weather app lol
weather.... looks like soon every calculator app will not run on rooted devices anymore..
 

pndwal

Senior Member
Hope you're right, but I'm seeing useless apps checking for root.
Different story that, but does make the subset bigger...
Can you guess what app is this?
Hint, it's not a bank app ;)
View attachment 5729465
mymaccas?, Some game? Controller app for your smart washing machine etc?
John Wu, Apr 13, 2021

No laundry for you, filthy custom ROM / root Android users
www.twitter.com/topjohnwu/status/1381735155044249601

... Or wanna Join John's magisk Slack group?

This:
John Wu, Sep 23, 2021

I kinda want to enable this in my Magisk Slack group so nobody can participate 😉
...
Or look at it this way: you can only join if you defeat Slack's root detection. I think that's a reasonable requirement for joining, don't you?
www.twitter.com/topjohnwu/status/1440764583589728264
-------​
John Wu, Jun 30, 2020

I advocate [@]AndroidDev to restrict hardware-backed SafetyNet evaluation to "real" security sensitive apps. Developers should go through an application process to qualify this level of API access. It is ridiculous for McDonalds to refuse to run on a bootloader unlocked device.

I understand that a reliable service for verifying device security status is important. However it shall not be abused and used to remove a significant portion of functionality on the few chosen to give up some security. This creates a hostile ecosystem against hobbyists.
www.twitter.com/topjohnwu/status/1277683005843111936
John Wu, Oct 6, 2021

My honest stance on root detection? With HW KA, that war is already over for me. For me right now, within Google we are brainstorming solutions on how to deal with the "root detection abuse" situation
www.twitter.com/topjohnwu/status/1445598606346444807

😝 PW
 
Last edited:

badabing2003

Recognized Contributor
Sep 17, 2012
1,420
1,647

adfree

Senior Member
Jun 14, 2008
10,092
5,927
Samsung Galaxy Watch 4
Google Pixel Watch
I can confirm GW4 SM-R870 is rooted with help of Magisk Version 25.2...

Firmware GVH2...

And since few hours I realized I have write access to /system

Still not solved to bypass netOdin Security Check:

I have only success with attached USB cable... and Odin.

Maybe somebody could help to solve the riddle about
Code:
wirelessd

In recovery.img

Magisk for instance delete during patching the text stringS:
Code:
SignerVer03

In Footer...

Only SEANDROIDENFORCE textstring is still inside...
But all other Samsung crap like user frp mrk is erased...

Please help.

Thanx in advance.

Best Regards
 
  • Like
Reactions: galaxys

73sydney

Senior Member
For heaven's sake I only have a handful of posts in this thread.

The last I checked you can turn of signature display,

Yeah, I'm detracting people asking questions because I'm asking a relevant question? in 53k + posts thread?

To answer my questions they don't have to be active developers, they just have to be knowledgeable (and courteous) which most are.

Care to suggest which device development thread I should post Magisk questions (which is not a device by the way), take a look where this thread is under.
View attachment 5729453

I get it, you don't like me, that's fine, you don't have to, I see that you get irritated easily, I'm not hijacking the thread, unlike endless other discussions.

Please ignore me and my posts, just like I will to you, and if you see me violating any forum rules, please bring it up to the attention of forum moderators, all I'm trying to do is learn and help the best way I can.

never said i "didnt like you" thats a construct thats been chosen to create conflict. Read my comments again, ive argued the points/topic, not the person, as i always do. Im an emotionless robot with aspergers, i literally dont care what people think of me and i dont attribute emotions to things others do, because its an absolute waste of my brain cycles to employ emotions for non-critical things that are in most cases (on here) niche or arbitrary to me in my larger life. If others chose to dwell on things and get a dose of red mist, thats a personal choice that cant be attributed to me

Taking things personally, thats a conscious choice, lets make that crystal clear right now....

ive said my piece and objected at the hijacking the thread (yet again) for a particular members software purposes, i dont believe this is the place for it, and this is being proven (again) by:

a) creating more off topic posts
b) introducing drama that doesnt exist or need to, to top things off
c) issuing "gotcha" statements

Everything spoken about could be handled via PM to those people who think can asisst...i have to carry on PM convos because theyre not germaine to the topics of threads in im, i have one PM thread 27 pages long discussing things we have had purged from this thread and others for not being on topic.

My suggestion, which i use myself, is if you want to develop software, create a thread/PM thread for it, and invite the people you think can help you from here on that thread by tagging them, or create a PM thread with them. Thats how i often rope people into helping me with things...even the mighty didgeridoohan has given up his time to come and respond to a thread/PM thread he's been tagged in on more than a 1,000 occasions by someone (a few times by me) developing something magisk related. Why do you think this doesnt apply in this instance? i dont get it, its good enough for everyone else to use that tagging paradigm and either create a targetted thread or PM thread

You seem to have spent a lot of time trying to make it personal....when it wasnt and doesnt need to be

Im personally tired of pointing out the bleeding obvious, this is not a dev thread, and its not designed for someone to hijack multiple times to write their own software. Period. I dont understand how thats not obvious or getting lost in translation somehow....

Notice i didnt use the word you once.....dont make it personal.....

p.s. i shouldnt have to turn off everyones signature display just because over and over it can be overwhelming with a graphic in it,and ideally, i dont like to ignore people, you really have to get on my nerves to be on that list. Id personally like to see where your software ends up, but in its own thread...
 
Last edited:

73sydney

Senior Member
I can confirm GW4 SM-R870 is rooted with help of Magisk Version 25.2...

Firmware GVH2...

And since few hours I realized I have write access to /system

Still not solved to bypass netOdin Security Check:

I have only success with attached USB cable... and Odin.

Maybe somebody could help to solve the riddle about
Code:
wirelessd

In recovery.img

Magisk for instance delete during patching the text stringS:
Code:
SignerVer03

In Footer...

Only SEANDROIDENFORCE textstring is still inside...
But all other Samsung crap like user frp mrk is erased...

Please help.

Thanx in advance.

Best Regards

I have been watching your progress and your bravery at hacking the Watch, and sacrificing one

Thats a younger mans game, and i like to be blissfully aware of the inner workings, but ready to heap praise on when you finally nail it
 
  • Like
Reactions: adfree and galaxys

zgfg

Senior Member
Oct 10, 2016
7,975
5,527

73sydney

Senior Member
  • Like
Reactions: martyfender

pndwal

Senior Member
Im personally tired of pointing out the bleeding obvious, this is not a dev thread, and its not designed for someone to hijack multiple times to write their own software. Period...
Mate, it wasn't a development question!... Legitimate query re. generated patch files having the wrong sha1 md5 and Magisk possibly using the wrong boot image files (other than user selected) in the Magisk download folder, or potentially the wrong backup images from /data/magisk_backup_xxxx folder...
Hi,

I think I might have hit a Magisk Manager bug, I'd like to check here first before reporting it as a bug in case anyone has seen this or thinks it's not a bug....

Two days ago, I patched boot.img of Pixel 6 September release...

I used Magisk Canary 25203 (38ab6858)
I used PixelFlasher which used
/data/adb/magisk/boot_patch.sh to patch it.
... Here he continues tests using Magisk App UI:
Today I used Magisk Manager UI to select boot_175dd086.img and get a patched file.
I expected the hash to be 8db3c1e6a94a49e8e2c12c07c3dc6fe4 similar to the one I got two days ago, after all nothing has changed about the source boot, nor the Magisk version...

I compared the two generated patches.
They are binary identical with the exception of this segment...

Obviously this is being inserted by Magisk, and it looks like it is supposed to be SHA1 of the source boot.img judging from one of the values, 7f04123661284ff8d554f01060b00eb6f188a07b

But why is the other 9c43d3fa9822dfd1f2eb7cc2768bbfa3c6c0bddf, and where is it coming from? And considering that everything else is binary identical, it can't be a different source boot.img can it?...

What is going on?
How is this possible.
Is it possible that the part that is supposed to get the sha1 is picking up the wrong file, but the patcher is picking up the correct file?...

Is it possible that the sha1 process is looking for first match of boot*.img and picking the wrong file?
I really can't see what else could be the cause other than some values being cached between runs even if Magisk Manager is stopped....

Yet the generated patch file has the wrong sha1 md5...
Clearly this discovery may have sprung from Pixel Flasher testing, but reveals potential serious underlying bugs in Magisk code...

Other posts indicate that this may be connected with other user's issues with backup files generated/used... I'm guessing if Magisk can pick up incorrect files from Download folder also, some unsolved issues may also be indicated here...

This may be a complex issue but is potentially a serious one we may all benefit from a resolution to.

Further, issues like this may never be solved without dev interaction with userbase like this... I see this as a positive thing!...
those devs never set a foot here and tried to use the thread to develop their own software.....
... But wouldn't some dev interaction, esp. some from the LSP associated Devs who's Magisk contributions are prolific, be a good thing?... Don't these very dev's often simply shut down issues without explanation or user interaction even in GitHub issues resulting in these simply being shelved/ignored/simply accepted?... And Oh how I wish they'd simply show a modicum of respect for the general Magisk user base/community, let alone poll for some user input on issues here...

... And I don't see such development happening, or dev-related questions in this case at all... That's a s t r e t c h...

I'd like to say 'keep it up' to any experienced Devs who ask questions here, especially those who also contribute positively like @badabing2003... We don't have nearly enough... And let's be careful not to alienate them... 🙃 PW
 
Hope you're right, but I'm seeing useless apps checking for root.
Can you guess what app is this?
Hint, it's not a bank app ;)
View attachment 5729465
i just installed to see it. And yep there it was. Although i bypassed it. i am using shamiko and i added this app to denylist and rebooted. I dont see the root warning anymore.
 

badabing2003

Recognized Contributor
Sep 17, 2012
1,420
1,647
i just installed to see it. And yep there it was. Although i bypassed it. i am using shamiko and i added this app to denylist and rebooted. I dont see the root warning anymore.
Yes, it passes for me too even without Shamiko, by just adding to Magisk denylist.
The concern being for now, and for how long before even unimportant apps start checking for meeting strong integrity.
 
  • Like
Reactions: HippoMan

73sydney

Senior Member
Mate, it wasn't a development question!... Legitimate query re. generated patch files having the wrong sha1 md5 and Magisk possibly using the wrong boot image files (other than user selected) in the Magisk download folder, or potentially the wrong backup images from /data/magisk_backup_xxxx folder...

... Here he continues tests using Magisk App UI:

Clearly this discovery may have sprung from Pixel Flasher testing, but reveals potential serious underlying bugs in Magisk code...

Other posts indicate that this may be connected with other user's issues with backup files generated/used... I'm guessing if Magisk can pick up incorrect files from Download folder also, some unsolved issues may also be indicated here...

This may be a complex issue but is potentially a serious one we may all benefit from a resolution to.

Further, issues like this may never be solved without dev interaction with userbase like this... I see this as a positive thing!...

... But wouldn't some dev interaction, esp. some from the LSP associated Devs who's Magisk contributions are prolific, be a good thing?... Don't these very dev's often simply shut down issues without explanation or user interaction even in GitHub issues resulting in these simply being shelved/ignored/simply accepted?... And Oh how I wish they'd simply show a modicum of respect for the general Magisk user base/community, let alone poll for some user input on issues here...

... And I don't see such development happening, or dev-related questions in this case at all... That's a s t r e t c h...

I'd like to say 'keep it up' to any experienced Devs who ask questions here, especially those who also contribute positively like @badabing2003... We don't have nearly enough... And let's be careful not to alienate them... 🙃 PW

This isnt a dev/support thread for a users software, which is what it feels like....thats my objection

all i have to say on it, ill just ignore him and shake my head at having to do that.....worth pointing out the only people on my ignore list are 2 trolls you know about.....but i guess thread breaking is normal now
 
Last edited:

Top Liked Posts

  • 2
    Read that; mulling over the idea, while waiting to see if some other method is available 👍.
    Well you can use custom XiaomiEU ROM as has been said... Other than this or stock, only option is take-to-service-centre method AFAIK, and you'd need device to be stock for that anyway...

    Nb. Custom XiaomiEU (basically debloated stock) also keeps this facility and may actually be required as it actually offers later MIIU than official for for some devices, porting late MIUI from models that did get the updates... Yours may be one that actually requires this custom ROM... PW
    1
    This is very similar issue on my Disney+ Yes seems the same issue like I have.
    There must be something "wrong" with these apps - they check something we dont know about even though we have:
    - Integrity check passed
    - Displax USNF working
    - Widevine L1 ok
    - Magisk hidden as app
    - Disney+ in blocked apps in Magisk
    - Zygisk + Shamiko
    - Device is certified in Google Play
    - Play Protect passed
    - Original Samsung (rooted) Newest Android 13 + November security


    There must be something else these streaming apps (Disney and HBO) are checking ...
    I wrote this to you earlier:
    It seems that affected apps are not allowing liboemcrypto.so use for ANY streaming and root detection (or possibly even detection that existing hardware for TEE decryption exists and should be used... Could be using model / other props with their own model whitelist too...) seems to be the likely reason to me... Ie. it's likely that these apps are simply restricting their use to SD decoding with older libraries (as liboemcrypto.so is primarily designed to decrypt HD content in secure TEE OS) rather than preventing apps from working on devices w/o hardware TEE...

    Netflix does this too BTW, but relies wholly on Widevine certification since v5.0, making their approach much simpler...

    All best on your quest... Hope something here was helpful... PW
    🙂 PW
    1
    ... Other than this or stock, only option is take-to-service-centre method AFAIK, and you'd need device to be stock for that anyway...
    I'd rather not be going down that road....
  • 8
    New Shamiko-v0.6(126)

    With this new Shamiko, Momo does no more detect Zygisk and Zygote (official latest Magisk Canary 25205, Zygisk enabled, DenyList configured and not enforced, Shamiko v0.6 in default black-list mode)
    7
    Just Curious
    Which command did you use to flash the patched_magisk...img with?
    1. fastboot flash init_boot magisk_patched...img
      or
    2. fastboot boot init_boot magisk_patched...img
    I think they both will work. :)
    Personally, unless booting an image is not an option..

    I always test boot the Magisk patched image using fastboot boot NameOfFile.img instead of flashing it.
    If it boots, Magisk will be active and I then use the Direct install option to make it permanent.
    If it does not boot, then no harm since the stock boot image is still installed. 🙃

    Cheers. :cowboy:
    7
    S-Check:

    Root detection, as on the screenshot

    I can pass with Delta but cannot with TJW Canary

    Delta:
    latest, Zygisk, MagiskHide, no Shamiko, App Data Isolation, HMA

    Canary:
    latest, Zygisk, DenyList, Shamiko, App Data Isolation, HMA, even with Magisk app uninstalled

    I have tested thoroughly on my two Xiaomi phones, one with A11 and the other with A12.
    Tested on both phones with Canary and with Delta - and I have the same results on both phones

    Not to mention that I fully pass Oprek, Ruru, TB-Checker, SafetyNet/Play Integrity
    Yup, Native bridge loading based on Maru Magisk fork implementation of Riru's loading method seems to have much merit...

    Nb. Original author says it's an experiment however, still not perfectly implemented and may be issues w/ some modules... Also Shamiko hiding with probably not work properly with this... Long read here for those interested:
    https://github.com/5ec1cff/my-notes/blob/master/maru.md

    For others, I put more here too:
    https://forum.xda-developers.com/t/...third-party-magisk-fork.4460555/post-87729841

    🙂 PW
    Worth pointing out that @zgfg asked me to test that on Magisk Canary (official) earlier but ive broken something it seems with my uber Samsung debloat and cant get S-check to even open anymore :)

    Anyone else care to chime in with Magisk Canary (official)
    I had that issue a while back, I do not remember what I did to fix it. :unsure:
    I just setup my Pixel 5a (it did not like updating from July to November 🙄) so clean flash. 😛

    No issues with Security Check. 🙂

    Pixel 6 - Stock Google 12L (July 2022).
    Pixel 5a - Stock Google 13 (November 2022).

    Magisk debug (snapshot)
    - Personal build from the official branch, so it includes the commits since the last canary/debug release.
    Magisk - [GitHub] - Building and Development

    USNF - Not the one that includes Displax's changes.
    - Personal test build that includes some other (mostly prop) changes.
    Fork - [GitHub] - commits
    One of these days I will have to pull Displax's Zygisk changes. 🙃

    MHPC
    - Set fingerprint back to stock Pixel 12.
    Pixel 6 is using the Pixel 6 12 print, 5a is using the 5a 12 print.

    Shamiko and LSPosed modules.

    HMA (Beta v3.0.5 r373)
    Two templates.
    Magisk
    - Settings (renamed Magisk app).
    - Hide My Applist.

    PlayStore
    - YouTube
    - YouTube Music​

    AdAway running in VPN (non-root) mode. ;)

    Cheers. :cowboy:
    6
    Personally, unless booting an image is not an option..

    I always test boot the Magisk patched image using fastboot boot NameOfFile.img instead of flashing it.
    If it boots, Magisk will be active and I then use the Direct install option to make it permanent.
    If it does not boot, then no harm since the stock boot image is still installed. 🙃

    Cheers. :cowboy:
    Some have said it's a waste of time to test by booting first, then direct installing because you can just flash the stock image back if it doesn't work.
    This maybe true, but directly flashing the patched image does NOT give Magisk the chance to back up the stock boot image, whereas booting then installing does.
    This makes it easier to take an OTA update on devices that require everything to be pure stock before proceeding by using Magisk's restore images function.
    6
    Hello everyone!

    Thank you for the very active thread i finally managed to figure out what i did wrong (yet again).

    I rarely tinker with the device, and when i am forced to, then i forget about A/B partitions, and wipe boot.img.

    I was hoping there is now another way for keeping TWRP and Magisk. Aside from embedding twrp image in stock boot, and than patching from magisk manager?

    Thank you.

    Also if someone more knowledgeable could help (even though it is slightly Offtopic), do i patch boot img with firmware boot img, or boot img from the custom rom i was using?

    Because that rom was then for testing (even though i kept it), and i can't figure out the version.
    I suspect when i run adb shell getprop "ro.product.version" it will probably fail, because i did a number on that device trying to fix it without understanding A/B partitions.
    Only if you don't have Recovery partition, then you patch TWRP to Boot (and afterwards the Magisk)

    (It's not necessarily specific to A/B devices - there are A/B devices that do have separated Boot and Recovery partitions, and in that case TWRP goes to Recovery partition, Magisk to Boot)

    But when you update Magisk, you can just take Direct Install (update)

    ---

    And of course, you must patch the boot.img corresponding to your current ROM. Usually, you can find it in the ROM zip file

    If you use some stock boot.img instead, then you risk the bootloop (of course, if boot img from your custom ROM coincides with the stock boot img then it doesn't matter, but usually it won't be the case - or you will not know

    That does not depend on Magisk - if the boot.img is wrong and you flash it (with or without Magisk) it will cause the bootloop (in the 'better' case, it may boot but you might have troubles later because of eg the wrong Kernel).
    Hence make sure to always use (for patching) the correct boot img
  • 1089
    This is the place for general support and discussion regarding "Public Releases", which includes both stable and beta releases.
    All information, including troubleshoot guides and notes, are in the Announcement Thread
    156
    Hello, I haven't given much support on XDA lately. It can be resulted from
    • University started and I have limited free time. In fact, I mostly develop during midnight
    • I live in Taiwan, which has large time zone differences between my European/American contributors/testers, which usually forces me to stay up late at night to discuss/test stuffs.
    • The new version is about to come, I don't want to spend effort on supporting old releases
    The planned update is delayed again and again, to some point I think I'll shed some light about what has been happening lately, also along with some announcements.

    New Forum!
    As you might have already discovered, Magisk got its own subforum on XDA! Many thanks to all the support you gave me, and much more information/features/support is about to come!
    **For developers supporting all the devices that are not using standard Android boot format, feel free to create threads in this section (actually, PLEASE do so) for your favorite devices after v7 is out. As I currently know, Asus devices require signing the boot image before flashing, and is model dependant; Sony devices seems to use ELF kernel that is unpatchable, or some has two ramdisks (inner + outer), both requires different workarounds; LG bootloader locked devices has to manually "BUMP" the boot image after flashing Magisk..... and there may be lots of other crazy boot image formats that haven't come up to my attention yet.
    It is impossible for me to support all these non-standard boot images, and I hope the community can collaborate to make Magisk running across all the devices. Overall, community collaboration is what XDA about :D

    The Pixel Phone
    Some of you might already know this news, that the next Pixel Phone right around the corner seems like it does not have ramdisk in boot image, which pretty much wrecked Magisk in all ways. However, it pretty much doomed root itself too. Kernel modifications is inevitable IMO, so I'll try to migrate my scripts to C programs that could possibly be included into the kernel itself. Note that I'm not familiar with linux kernel, I'm not even sure if my idea and concept is correct or not. But once the device is available, I think developers will find a way to bypass all the difficulties, and I'll do my best to learn things ;)

    Current Progress
    In the past month, I've spent quite some time learning SELinux, so that I can avoid using SuperSU's sepolicy patches. Thanks to the helps and tips from @phhusson and @Chainfire, I finally have a much clearer understanding of how SELinux works. The Magisk core parts (the scripts, boot image patches, new features, more supports) are actually done some time ago. What is causing all the delays is the Magisk Manager.
    To be completely honest, although I can code in Java without much issues, Magisk Manager is actually my first Android application, I had to reach out for assistance, and fortunately awesome developers like @DVDandroid and @digitalhigh contributed a lot, which makes the current Manager awesome.
    After the repo system and module management is mostly done, I was about to do some adjustments and release, but what we really done is decided to add another feature: auto-unroot with per-app settings. I decided to wait for it to be finished, and then do my adjustments. Due to reasons that'll be mentioned later, this feature will likely not be available for the next release (should come in future updates)

    Safety Net Disaster
    Those who are using Magisk for Safety Net bypass purposes must have known that Google recently updated the detection method of my Systemless Xposed. I still have no idea what Safety Net is detecting, so currently I cannot fix it on my side (also because I'm busy working on the next update). However, suhide developed by @Chainfire is able to hide Xposed and worked fine.
    However, only my Systemless Xposed v86.2, which is based on SuperSU's su.d, is supported using that method. v86.2 and v86.5 (latest, Magisk based) have nearly identical binaries, and the only difference is the path where the binaries are stored.
    I'm still not sure what's the real issue for it not being supported, I just hope it is not done intentionally.

    Conclusion
    Due to the fact that my Safety Net bypass is not 100% perfect now, I do not want to spend any more time waiting for auto-unroot to be polished. What I'm doing now is finishing up all the things I'd like to change in Magisk Manager (it has been a while since I last contributed to Manager, my fellow developers are doing all the heavy job), which might take a little more time, after that, packed with tons of information to be announced in Magisk Section, I'll release the long awaited update.

    Hope this lengthy post gives you the idea of the whole situation, and again thanks for all your support!!
    121
    Ah, some Chainfire bashing, I hope it is not too late for me to exercise additional villainy.

    First, let me make clear I have nothing against @topjohnwu, nor against Magisk. Magisk is an interesting project and it certainly displays @topjohnwu ingenuity and persistence. I don't doubt we will see more interesting things from his hands.

    -------------------------

    What has happened here is not all that dark and complicated, from either end. I returned from holidays, and someone pointed me at Magisk. My first thought: interesting!

    Among other things, the thread lists some issues with SuperSU, which in combination with the phrase The developer also requests users to not bug Chainfire with compatibility requests for SuperSU with Magisk from the portal article, raised my left eyebrow by nigh half an inch. The popular systemless xposed mod is apparently now based on it, and apparently it now no longer works with SuperSU, and apparently I'm not supposed to fix that, nor any of the other found issues. I found that a bit weird. So yes, I have told @topjohnwu that I was a bit surprised he was posting about issues with SuperSU without notifying me about them (I can't fix or help fix issues I'm not aware of, after all).

    He's also spreading a modified version of the SuperSU package, which is not all that uncommon, nor necessarily a problem. I have not looked into what he modified, I only ran a few quick tests on one of my devices, and found some commonly used commands run as root to be broken. I have informed him of this as well.

    It appears the tool of choice for Magisk is phh's Superuser, because of some of the mentioned issues with SuperSU. That's fine by itself, but fixing issues in that superuser by incorporating SuperSU's binaries into it is a somewhat questionable practise. After all, SuperSU is a commercial closed-source package that helps pay for my dinner, and superuser is a direct competitor. I have informed him that I was surprised he did this without asking for permission. I have expressed similar surprise on him spreading a modified version of LiveBoot (which helps pay for a snack now and then).
    @topjohnwu has also stated that Magisk's scripts are largely influenced by mine (I have not checked). Scripts based on mine are used all over the place on XDA, some people have crafted amazing things based on them, I have never made an issue of this (otherwise I would have just made them binaries). But yes, I have also stated to him that I don't think it's very nice to base something on one program, and then using that to (almost exclusively) push something directly competing with that program.

    tl;dr Towards @topjohnwu, I have:
    - expressed surprise he has issues getting Magisk to work with SuperSU, and has chosen not to inform me about those
    - expressed surprise he is using SuperSU binaries in a competing superuser without permission
    - expressed surprise he is posting a modified LiveBoot without permission
    - informed him of issues with the modified SuperSU he has posted
    - let him know I thought it wasn't very nice to be applying my scripts to benefit seemingly exclusively that same competing superuser

    To be crystal clear:
    - I have not asked for an apology
    - I have not asked for Magisk to be abandoned, neither the root hiding nor systemless module parts, and certainly not systemless xposed
    - I have not made an issue of any of this anywhere, until this post
    - I have not even specifically asked for anything to be taken down (though obviously in my opinion the other superuser package mixed with SuperSU's binaries, as well as the LiveBoot package, should go)
    - I have not reported this thread to XDA moderators for copyright violations or otherwise

    While my conversation with @topjohnwu may not win any awards for being friendly (though it may win some for brevity), I think all things considered my response has been rather mild. To be perfectly honest, until the apology post, I thought this was over with already. I think the apology post was triggered because I haven't replied to his last PM for a while - I was in the zone, it happens.

    To emphasize again, I have nothing against @topjohnwu, Magisk, or systemless xposed, and it is certainly not my goal to see any of them go. If it can be made to work together with SuperSU, great.

    I get it though: you think of something, you want to see if you can make it work, you finally get it to work, you publish it, it takes off - enthusiasm gets the better of you. Maybe in the rush some mistakes are made. That doesn't mean you have to just drop it and run. None of my stuff would make it past 0.1 if I stopped at the first big mistake :)

    Aside from said being in the zone coding, I usually regret actually responding to these sort of things the day after, which has made me hesitant to reply. Surprise me.
    76
    Thread temporarily closed so everyone sees this.

    The flood of "SafetyNet isn't working for me either!" posts are not helpful, at all. Please refrain from posting further, it will be looked into. Please do not forget that not passing SafetyNet is 100% NORMAL AND INTENDED when you have an unlocked booloader or running custom firmware. These are workarounds and they will be worked around in turn.

    The Flash
    Forum Moderator

    EDIT: Thread is reopened... I will be cleaning any SafetyNet posts for a while to keep the thread clean for real issues.
    75
    Hello everyone!

    I am aware that Google has updated Safety Net that makes Magisk itself a no go for Android Pay. In fact, I witnessed the change live while I am developing the new magiskhide, which should hide all Magisk modules and Magisk installed root.

    Google is serious about Safety Net now, clearly hunting down all possibility to run Xposed with Safety Net passed. I spend quite some time examining the new security measures last midnight, and fortunately it seems that it is possible to run Magisk and root along with Safety Net if no Xposed is running. I'm glad I removed the old root toggle at the right time lol, that is no longer feasible with the latest detection.

    So stay tuned for the next update, it will come with bug fixes, along with the new magiskhide to bypass that Safety Net.

    Google, how will a few systemless mods do any harm :p:p