Magisk General Support / Discussion

[chichino84]

Thx for your answer.

Tried to boot through both slots (after verifying with "fastboot getvar all") and result is the same: it boots fine, but freeze & reboot after few seconds.

What other options I have? A fastboot factory image flash?

 

[J.Michael]

Hi everybody!

I'm having problems with my phone, freezing few seconds after booting and then restarting.
Already uninstalled Magisk along with all modules, no luck.

Also tried to flash the original boot.img via fastboot command, but it seems that it is flashed only on the slot "a" - while (if I remember correctly) the Magisk patched boot.img was flashed on slot "b".
Is probably this the part I'm doing wrong? Should I flash the original boot.img on both partitions by the command "fastboot flash --slot=all boot"

Please bare with me, been away from rooting since a loooong time....
Thx!

Pixel 6a
Android 13 (nov. update)
Magisk 25.2

Was it working just fine, with Magisk installed, and after weeks it suddenly had a problem?

Did you take an update? Did you uninstall Magisk first?

Have you been following this thread enough to notice whether your device/ROM is one that suddenly needs something other than boot.img patched? (Something like "init_boot.img".)

 

[kerlaeda08]

tell me what to do please, put tvrp and magisk, everything seems to be normal (there is a root), but after rebooting the phone, a lock screen appears asking you to enter a pin code and a black background (that is, there is no splash screen) and when you enter the pin code, the phone will not be unlocked for a long time (all also a black background and no desktop) and again a black screen with a pincode input. sometimes the desktop appears for a second, but then a black screen and again unlocking. only wipe in tvrp helps to get rid of this. Smsung A50 stock

 

[rodken]

tell me what to do please, put tvrp and magisk, everything seems to be normal (there is a root), but after rebooting the phone, a lock screen appears asking you to enter a pin code and a black background (that is, there is no splash screen) and when you enter the pin code, the phone will not be unlocked for a long time (all also a black background and no desktop) and again a black screen with a pincode input. sometimes the desktop appears for a second, but then a black screen and again unlocking. only wipe in tvrp helps to get rid of this. Smsung A50 stock

I missed the part where you attempted to factory reset your device.

 

[kerlaeda08]

I missed the part where you attempted to factory reset your device.

resetting to factory settings helps to remove the permanent lock screen, but if you install Magisk again, then after the reboot there will be a lock screen again

 

[chichino84]

Was it working just fine, with Magisk installed, and after weeks it suddenly had a problem?

Did you take an update? Did you uninstall Magisk first?

Have you been following this thread enough to notice whether your device/ROM is one that suddenly needs something other than boot.img patched? (Something like "init_boot.img".)

It was working fine until I installed Pixel Launcher Mods module, issue started right after the activation reboot inside the Magisk app.
So I tried to clean everything back from there. Along with the app itself (completely uninstalled as 1st thing), other modules I've uninstalled are AOSP Mods, Zygysk and Systemless Host.

Haven't done any recent update, last OTA I installed is November, all seemed works fine till today.

Android 13 stock on Pixel 6a doesn't have init_boot.img file to be patched.


EDIT: turns out it wasn't any module to cause my issue, it was the Greenify app messing with my Smart Lock settings right after boot. Uninstalled - along with its root privilege- seems to have solved everything.

 

[rodken]

resetting to factory settings helps to remove the permanent lock screen, but if you install Magisk again, then after the reboot there will be a lock screen again

Did you try this method for your device [outdated, but still reliable]?

 

[dimm0k]

It would pay to be very certain of point 1)... Flashing a recent boot.img often works but invariably causes issues...

Other Pixel Users (especially 4XL):

Can anyone confirm if loopback bug is still an issue w/ latest stock kernels?... I'm not certain it is, nor what is latest kernel version (this affected kernels at least up to v4.9), but I notice the following fix (from linked issue) is still being merged almost daily in custom kernels for a plethora of different (incl. non Pixel) devices:

Spoiler

flar2 pushed a commit to flar2/Pixel-4 that referenced this issue on Dec 1, 2020

f2fs: Fix deadlock between f2fs_quota_sync and block_operation …

3510d81
This deadlock is hitting Android users (Pixel 3/3a/4) with Magisk, due to frequent umount/mount operations that trigger quota_sync, hitting the race. See topjohnwu/Magisk#3171 for additional impact discussion.

In commit db6ec53b7e03, we added a semaphore to protect quota flags. As part of this commit, we changed f2fs_quota_sync to call f2fs_lock_op, in an attempt to prevent an AB/BA type deadlock with quota_sem locking in block_operation. However, rwsem in Linux is not recursive. Therefore, the following deadlock can occur:

f2fs_quota_sync
down_read(cp_rwsem) // f2fs_lock_op
filemap_fdatawrite
f2fs_write_data_pages
...
block_opertaion down_write(cp_rwsem) - marks rwsem as "writer pending"
down_read_trylock(cp_rwsem) - fails as there is a writer pending.
Code keeps on trying, live-locking the filesystem.

We solve this by creating a new rwsem, used specifically to
synchronize this case, instead of attempting to reuse an existing lock.

Signed-off-by: Shachar Raindel <[email protected]>

Fixes: db6ec53b7e03 f2fs: add a rw_sem to cover quota flag changes

PW

my steps were essentially the same I take to update my Pixel devices
- download the full factory image
- unpack its contents
- unpack the boot.img from the large zip file from the contents
- feed magisk the boot.img, save it to the computer
- fastboot flash the resulting file from magisk

did I miss anything else or do anything wrong?

 

[J.Michael]

my steps were essentially the same I take to update my Pixel devices
- download the full factory image
- unpack its contents
- unpack the boot.img from the large zip file from the contents
- feed magisk the boot.img, save it to the computer
- fastboot flash the resulting file from magisk

did I miss anything else or do anything wrong?

Try "fastboot boot" the unpatched boot.img -- just to make sure it works. (If you've been recovering by flashing the unpatched boot.img, just ignore me.)

 

[pndwal]

my steps were essentially the same I take to update my Pixel devices
- download the full factory image
- unpack its contents
- unpack the boot.img from the large zip file from the contents
- feed magisk the boot.img, save it to the computer
- fastboot flash the resulting file from magisk

did I miss anything else or do anything wrong?

No; your process seems good as long as you're sure you didn't mix up older .img files on PC etc...

It would be good if P4 series Pixel users could confirm if loopback bug was never fixed w/ updates... But it's certainly looking like this... PW

 

[dimm0k]

No; your process seems good as long as you're sure you didn't mix up older .img files on PC etc...

It would be good if P4 series Pixel users could confirm if loopback bug was never fixed w/ updates... But it's certainly looking like this... PW

given that the Pixel 4XL has reached EOL in terms of Google updates, perhaps I'll move entirely to the PixelExperience ROM where there's more support. thanks for shedding the light on this bug!

 

[ipdev]

S-Check:

Security Check - Device compli - Apps on Google Play

Check your device readiness and compliance for Mobile Payments

play.google.com

Root detection, as on the screenshot

I can pass with Delta but cannot with TJW Canary

Delta:
latest, Zygisk, MagiskHide, no Shamiko, App Data Isolation, HMA

Canary:
latest, Zygisk, DenyList, Shamiko, App Data Isolation, HMA, even with Magisk app uninstalled

I have tested thoroughly on my two Xiaomi phones, one with A11 and the other with A12.
Tested on both phones with Canary and with Delta - and I have the same results on both phones

Not to mention that I fully pass Oprek, Ruru, TB-Checker, SafetyNet/Play Integrity

Yup, Native bridge loading based on Maru Magisk fork implementation of Riru's loading method seems to have much merit...

Nb. Original author says it's an experiment however, still not perfectly implemented and may be issues w/ some modules... Also Shamiko hiding with probably not work properly with this... Long read here for those interested:
https://github.com/5ec1cff/my-notes/blob/master/maru.md

For others, I put more here too:
https://forum.xda-developers.com/t/...third-party-magisk-fork.4460555/post-87729841

PW

Worth pointing out that @zgfg asked me to test that on Magisk Canary (official) earlier but ive broken something it seems with my uber Samsung debloat and cant get S-check to even open anymore

Anyone else care to chime in with Magisk Canary (official)

I had that issue a while back, I do not remember what I did to fix it.
I just setup my Pixel 5a (it did not like updating from July to November ) so clean flash.

No issues with Security Check.

Pixel 6 - Stock Google 12L (July 2022).
Pixel 5a - Stock Google 13 (November 2022).

Magisk debug (snapshot)
- Personal build from the official branch, so it includes the commits since the last canary/debug release.
Magisk - [GitHub] - Building and Development

USNF - Not the one that includes Displax's changes.
- Personal test build that includes some other (mostly prop) changes.
Fork - [GitHub] - commits

One of these days I will have to pull Displax's Zygisk changes. ​

MHPC
- Set fingerprint back to stock Pixel 12.
Pixel 6 is using the Pixel 6 12 print, 5a is using the 5a 12 print.

Shamiko and LSPosed modules.

HMA (Beta v3.0.5 r373)
Two templates.

Magisk
- Settings (renamed Magisk app).
- Hide My Applist.

PlayStore
- YouTube
- YouTube Music​

AdAway running in VPN (non-root) mode.

Cheers.

 

[pndwal]

I had that issue a while back, I do not remember what I did to fix it.
I just setup my Pixel 5a (it did not like updating from July to November ) so clean flash.

No issues with Security Check.

Pixel 6 - Stock Google 12L (July 2022).
Pixel 5a - Stock Google 13 (November 2022).

Magisk debug (snapshot)
- Personal build from the official branch, so it includes the commits since the last canary/debug release.
Magisk - [GitHub] - Building and Development

USNF - Not the one that includes Displax's changes.
- Personal test build that includes some other (mostly prop) changes.
Fork - [GitHub] - commits

One of these days I will have to pull Displax's Zygisk changes. ​

MHPC
- Set fingerprint back to stock Pixel 12.
Pixel 6 is using the Pixel 6 12 print, 5a is using the 5a 12 print.

Shamiko and LSPosed modules.

HMA (Beta v3.0.5 r373)
Two templates.

Magisk​

- Settings (renamed Magisk app).​

- Hide My Applist.​

​

PlayStore​

- YouTube​

- YouTube Music​

AdAway running in VPN (non-root) mode.

Cheers.

Good stuff... It would be useful if you could put your finger on what's needed to pass S-Check w/ TJW Magisk... Clearly Maru Magisk Native bridge loading isn't needed for this detection... PW

 

[73sydney]

Worth pointing out that @zgfg asked me to test that on Magisk Canary (official) earlier but ive broken something it seems with my uber Samsung debloat and cant get S-check to even open anymore

Anyone else care to chime in with Magisk Canary (official)

I had that issue a while back, I do not remember what I did to fix it.

Its all good, i picked up a Pixel 6 Pro this afternoon, i thought it might save any more posts on XDA about how fed up ive become at Samsung trying to dictate how i use devices i paid them for, and specifically how they keep breaking my ability to easily connect my phone and watch. Had enough, back to Pixel...

Already feeling less stressed...want to unlock your bootloader?:

Samsung - We'll make you wish you hadnt even thought to try, go any further and we'll ruin your life and void your warranty
Google - Heres how you do that, plus you can keep your warranty. Have at it...

 

[pndwal]

FWIW, LoveSy (Shana) has made a pull request for Zygisk v5 Api already merged in her Metagisk ('The Meta Magic Mask for Android') Magisk fork... The commit Add inode plt hook APIs includes this comment:

Since xhook originally hooks by using regex which may cause confusion, we add this API for more specific hooks.

John has requested new XHook API use with Zygisk be deferred (stay w/ v4 for now) and Shana suggested fixing v4 Zygisk compatibility (Zygisk crashes whenever a module uses v4 api, see fixes #6402 and #6396) issue before revisiting this PR (it's been marked as draft for now)... This may also explain some recent Zygisk issues... Watch this space...

I have no idea about inode plt hook or what benefits it will bring... Any coders w/ XHook experience care to edify us?

CI Metagisk build is in Artifacts here (for mavericks):
Add inode plt hook APIs Magisk Build #2276...

PW

 

[mcpite]

Hello guys.

I have a Pixel 6a, and (was) rooted with magisk (for volte).
My phone didn't see the november update, so I tried to uninstall/restore magisk, maybe then I can see. Earlier it worked me once this method (right after rooting): P6 OTA with magisk
The phone didn't fint the update, so I installed back magisk...
But I forgot, that magisk is hidden/renamed, so the magisk install was a new magisk! After restart, root lost, and the old, renamed magisk says: The hidden magisk app cannot continue to work because root was lost. Please restore the original apk.


1, Should I uninstall both magisk?
2, I need to do all setups again for magisk?
3, Can I solve this without flashing, or when root is lost, I need to patch again? (I made it with pixelfalsher originaly)
+1, Now I can see the november pacth - should I upgrade it now, or only after maisk/root works again?

Thanks for any help!

 

[c3k]

Yesterday I've updated my S21 to Android 13.
Switching to Magisk canary was necessary since the firmware patched with the stable version didn't boot.
Now when I open Magisk it asks for additional setup but, after confirmation, instead of reboot it goes in the install page.

Is the right / safe way to select select "direct install"?

Everithing seems to work btw (battery drain apart...)

 

[J.Michael]

Hello guys.

I have a Pixel 6a, and (was) rooted with magisk (for volte).
My phone didn't see the november update, so I tried to uninstall/restore magisk, maybe then I can see. Earlier it worked me once this method (right after rooting): P6 OTA with magisk
The phone didn't fint the update, so I installed back magisk...
But I forgot, that magisk is hidden/renamed, so the magisk install was a new magisk! After restart, root lost, and the old, renamed magisk says: The hidden magisk app cannot continue to work because root was lost. Please restore the original apk.


1, Should I uninstall both magisk?
2, I need to do all setups again for magisk?
3, Can I solve this without flashing, or when root is lost, I need to patch again? (I made it with pixelfalsher originaly)
+1, Now I can see the november pacth - should I upgrade it now, or only after maisk/root works again?

Thanks for any help!

Are you distinguishing between Magisk and the Magisk manager app?

If you installed a new Magisk manager app without dealing with an old, renamed, manager app, the first step is usually to uninstall the old app. After reboot the new Magisk might be working.

If you don't know whether Magisk is installed at all, you can uninstall all manager apps and reboot. Reasonably recent versions of Magisk will not tolerate having no manager installed, and will install a manager -- if you uninstall all manager apps and have a manager app after rebooting, you have a Magisk installed.

If you installed originally with PixelFlasher, I think you can use PixelFlasher again. I do not know if PixelFlasher helps with the dance to restore Magisk-less system, take update, reinstall Magisk (except that last step).

 

[zgfg]

Hello guys.

I have a Pixel 6a, and (was) rooted with magisk (for volte).
My phone didn't see the november update, so I tried to uninstall/restore magisk, maybe then I can see. Earlier it worked me once this method (right after rooting): P6 OTA with magisk
The phone didn't fint the update, so I installed back magisk...
But I forgot, that magisk is hidden/renamed, so the magisk install was a new magisk! After restart, root lost, and the old, renamed magisk says: The hidden magisk app cannot continue to work because root was lost. Please restore the original apk.


1, Should I uninstall both magisk?
2, I need to do all setups again for magisk?
3, Can I solve this without flashing, or when root is lost, I need to patch again? (I made it with pixelfalsher originaly)
+1, Now I can see the november pacth - should I upgrade it now, or only after maisk/root works again?

Thanks for any help!

You have to uninstall Magisk APPLICATIONS (uninstall both apps) and install once again

But be aware, that Magisk APP (aka manager) is not Magisk (service, mask, 'root', whatever you call it), hence you should not uninstall Magisk (as you wrote), but only uninstall Magisk APP(s) (as I wrote above)

---
About terminology (translation between your names and mine)

Ie, when you say 'root' that is actually Magisk (service, mask, 'root') - how I call it

When you say 'magisk' that is actually Magisk App or Manager - how I call it above

Because, Magisk is more than root, and Magisk app is actually only the user interface or Manager for that Magisk

Hence, in your case, you have single Magisk (mask, service 'root') installed, but you have two Magisk applications where the old one was hidden/repackaged/renamed and that one still communicates with Magisk, while the new Magisk app does not 'see' Magisk

However, your Magisk still works (you didn't loose root). If you previously granted root to some root apps, those root apps should still be able to use root

Also, Magisk modules that you previously installed should also still work (no matter that your new Magisk app does not see them)

 

[pndwal]

Hello guys.

I have a Pixel 6a, and (was) rooted with magisk (for volte).
My phone didn't see the november update, so I tried to uninstall/restore magisk, maybe then I can see. Earlier it worked me once this method (right after rooting): P6 OTA with magisk
The phone didn't fint the update, so I installed back magisk...

Yes, Install to inactive slot method used to work but it's broken at least for P6 and P7 series after late A12 updates... See this issue:
https://github.com/topjohnwu/Magisk/issues/5959
vv points to an article stating that as part of a Chrome/Android Update Engine change for A/B devices, after reboot the update_verifier program now runs and reads all dm-verity devices to make sure the partitions aren't corrupted... A fix would involve partition digest being re-calculated and overwriten to account for Magisk binaries in the newly flashed slot.
https://android.googlesource.com/platform/system/update_engine/

Nb. I don't much like the 3rd party source for instructions... Here's the official doc (albeit broken for you):
https://github.com/topjohnwu/Magisk/blob/master/docs/ota.md

But I forgot, that magisk is hidden/renamed, so the magisk install was a new magisk! After restart, root lost, and the old, renamed magisk says: The hidden magisk app cannot continue to work because root was lost. Please restore the original apk.


1, Should I uninstall both magisk?

Yes (Apps, not core/mask as already discussed); easiest way to fix issues with competing apps especially if you accepted a Superuser request for an app (nb. this is a symptom of the issue (

2, I need to do all setups again for magisk?

No, just uninstall full App + hidden (stub) app per custom name, then reinstall full App and take Hide the Magisk app if you wish...

3, Can I solve this without flashing, or when root is lost, I need to patch again? (I made it with pixelfalsher originaly)

Yes, you shouldn't need to flash again and it's unlikely root was actually lost when you simply have app conflicts...

+1, Now I can see the november pacth - should I upgrade it now, or only after maisk/root works again?

I'd fix first, then restore images before taking update (if you mean a delta OTA), but you'll need to reboot and fastboot flash Magisk again since preserve root through OTA method is broken...

Nb. Since updating with Magisk App hidden often fails it is advisable to take Restore the Magisk app before a Magisk update...

Thanks for any help!

Welcome. PW