Magisk General Support / Discussion

Search This thread

pndwal

Senior Member
Thanks for the help, however removing magisk and its module in data/adb, but didn't seem to work, my phone still goes black after the logo and goes to fastboot.

My custom rom doesn't have a vbmeta file that i can restore.
Yup... I covered a few bases since you didn't give details re. device / ROM... Please give this info as I don't know it's age, boot type or even if you have 2SI booting (affected by the 25.0 refactoring I mentioned)...
I may try dirty flashing, (not sure what dirty flashing is, but i assume it's flashing my custom rom in its current state of my phone without wiping) but i want to ask, does dirty flashing usually delete all of the data, apps etc?
You can try restoring unpatched boot.img (or recovery.img if you have A-only legacy SAR device Magisk in recovery ramdisk) only using fastboot to see if booting is restored... Or dirty flash complete ROM (Nb. fastboot type ROMs are more complete than recovery ROMs)...

Yes, dirty flash means no data wipe/factory reset... Apps etc will usually be preserved fine... and you've already wiped the data that may cause bootloops w/ Magisk installed, ie. in /data/adb, so fresh Magisk install after ROM flash should be fine... PW
 

pndwal

Senior Member
I would like to continue with this thread here...

I am using Samsung Galaxy Note 20 Ultra 5G, Android 13 November update - original firmware rooted with Magisk + Universal Safetynet + Zygisk ...

I can install apps like Netflix, Disney+ etc no problem (I pass safetynet checks, device is authorized in GooglePlay etc all seems ok) BUT only Disney and HBO cannot play any streams (Netflix is ok)
"Netflix is ok" meaning you have HD decoding or only low definition?...
unless I install this: https://forum.xda-developers.com/t/...rm-protected-content-netflix-my5-etc.3794393/

It works then and only then - But it goes to L3 with bad quality streams. I tried MagiskHide to change fingerprint - no success,
You shouldn't need fingerprint set by MHPC if you have @Displax modded USNF fork module w/ Play Integrity hardware based verdict enforcement bypass as this sets an old but passing fingerprint to target gms...
I tried Shamiko - same result still cannot play streams - I can open the apps - update them on Google Play but cannot play anything once I open the apps it just goes black with loading screen (location in EU) - I tried to disable Adblock if that can somehow blokc it but streaming works with Liboemcrypto modul instaled (on bad L3 quality) with adblock active so it must be somewhere else - anyone experienced anything like this and has any working solution?

Thank you!
So Netflix is no longer using SafetyNet or Play Integrity APIs to restrict usage directly... I'm not sure about Disney, HBO etc but may be similar... L1 Widevine does depend on S/N or PI deviceIntegrity pass on some devices (but not on my RN8T MIUI device) as well as a number of other factors... I'll put more in a following post...

Please confirm you are passing new PI API deviceIntegrity verdict as this may affect those apps even if Widevine is not using this verdict on your device... Give results from Play Integrity API Checker and DRM Info apps...

If you have L1 Widevine you shouldn't need module you mention... PW
 
Last edited:
  • Like
Reactions: shoey63

pndwal

Senior Member
@Drahy,
So Netflix is no longer using SafetyNet or Play Integrity APIs to restrict usage directly... I'm not sure about Disney, HBO etc but may be similar... L1 Widevine does depend on S/N or PI deviceIntegrity pass on some devices (but not on my RN8T MIUI device) as well as a number of other factors... I'll put more in a following post...
Here goes:

--- Part of a recent conversation pasted: ---

ipdev said:
For the record..
Just manually install (sideload) Netflix. Google will find it and take over updating it.
Magically it show up in PlayStore. Even if not certified and failing SN/PI. 🙃

You do not need GApps to use Netflix. ;)
You can install and use Netflix on a custom rom or AOSP/GSI without GApps just fine.
I will stop there before I fill up a whole page on Netflix. 😜
You are correct that this occurs now... Big change from v5.0:
...
Things were different for Netflix users before v5.0, when NetFlix app apparently directly polled SafetyNet. Now SafetyNet only seems to affect users who's device specific Widevine implementation itself is polling SafetyNet API. Netflix said:
With our latest 5.0 release, we now fully rely on the Widevine DRM provided by Google; therefore, many devices that are not Google-certified or have been altered will no longer work with our latest app and those users will no longer see the Netflix app in the Play Store.
... Things are a bit strange/unusual since that update; Store will show app if manually installed but still says "app will not work for your device"... App otherwise still appears per CTS Profile match pass, and now apparently per deviceIntegrity verdict...

It appears that the statement "many devices that are not Google-certified or have been altered will no longer work with our latest app" is not strictly correct; many not passing S/N / PI deviceIntegrity won't decode HD streams however... L1 and L3 are both Google certifications but Widevine is part of AOSP, not just proprietary code, and even uncertified China region devices have L3 certification (I don't think L3 can be lost or any Android don't have at least that) meaning Netflix does work w/ SD streaming on any device since 5.0...

As I said a while ago:
Why is Netflix even worried about root?
Seems it's not, but we need SafetyNet pass for Netflix in Play Store, also for Widevine attestation to TEE (L1 security for HD streaming / processing) on devices where Widevine polls SafetyNet result / API (Netflix polls Androids Widevine DRM API).

For this reason Netflix runs fine w/ HD processing on many MIUI devices even with broken SafetyNet, but not on others...
Most Xiaomi devices seem to retain L1 Widevine with or without passing CTS Profile match (which of course requires GApps; nb. deviceIntegrity may well now be polled by those devices after updates since June also), but other devices have it only when passing and some devices seem to prevent L1 restoration w/o relocking bootloader... Still others require service department specialist software to generate new keys for CDM if ever they're lost, and some OEMs refuse to help... Since post 5.0 Netflix 'fully relys on the Widevine DRM provided by Google' and OEM implementation is so inconsistent, Netflix is still affected differently by S/N (and PI deviceIntegrity?) per device at least in respect to HD stream decoding ability assuming a device is certified for L1 Widevine in the first place...

A recent post about this:
https://forum.xda-developers.com/t/...p-edits-and-more-v6-1-2.3789228/post-87737559

Despite knowing this stuff I found a couple of my posts where I'd misremembered details and I've made some needed corrections... 😜

--- End of conversation ---

Hope this information helps content streaming service users... 🤠 PW
 
Last edited:
  • Like
Reactions: asripath

PolyDave

New member
Dec 2, 2022
3
2
Yup... I covered a few bases since you didn't give details re. device / ROM... Please give this info as I don't know it's age, boot type or even if you have 2SI booting (affected by the 25.0 refactoring I mentioned)...

You can try restoring unpatched boot.img (or recovery.img if you have A-only legacy SAR device Magisk in recovery ramdisk) only using fastboot to see if booting is restored... Or dirty flash complete ROM (Nb. fastboot type ROMs are more complete than recovery ROMs)...

Yes, dirty flash means no data wipe/factory reset... Apps etc will usually be preserved fine... and you've already wiped the data that may cause bootloops w/ Magisk installed, ie. in /data/adb, so fresh Magisk install after ROM flash should be fine... PW
Dirty flash did the trick, after i flashed the rom again, i reinstalled magisk and everything seems to be working fine with no issues.

Thanks!
 
  • Like
Reactions: ipdev and pndwal

Erfirya

Member
Aug 20, 2022
16
8
can someone help me with my disney+ app issue. so I have:
Xiaomi POCO X3 NFC
xiaomi.eu MIUI v13.0.1
Android 12
Magisk v25.2
USNF v2.3.1 (Displax mod)

my problem is I can't watch any of their content on FHD, it only shows up to HD quality even though I've subcribed to premium. I've tried logging in the same account on the same device model but w/ locked bootloader and stock rom and it has a FHD quality option. I've also added disney+ to denylist but the issue still persist. I've checked if my device is certified using Play Integrity API Checker (Nikolas Spiridakis). Here's the result:
 

Attachments

  • Screenshot_2022-12-03-09-52-36-589_gr.nikolasspyr.integritycheck.jpg
    Screenshot_2022-12-03-09-52-36-589_gr.nikolasspyr.integritycheck.jpg
    138.6 KB · Views: 18

pndwal

Senior Member
can someone help me with my disney+ app issue. so I have:
Xiaomi POCO X3 NFC
xiaomi.eu MIUI v13.0.1
Android 12
Magisk v25.2
USNF v2.3.1 (Displax mod)

my problem is I can't watch any of their content on FHD, it only shows up to HD quality even though I've subcribed to premium. I've tried logging in the same account on the same device model but w/ locked bootloader and stock rom and it has a FHD quality option. I've also added disney+ to denylist but the issue still persist. I've checked if my device is certified using Play Integrity API Checker (Nikolas Spiridakis). Here's the result:
My Last two posts above may help you... Check Widevine security level... PW
 

73sydney

Senior Member
I maintain my L1 Widevine on rooted Pixel 6 Pro. First device ive ever personally seen this happen on. I just assumed once you unlock bootloader you lose it. I keep wondering why people seem surprised by this....this has just been the way it is since forever...

I personally weigh this up as the cost of rooting, just like no OTA or warranty on Samsung....
 
  • Like
Reactions: Erfirya

asripath

Senior Member
Jul 12, 2020
227
180
Redmi K20 Pro
can someone help me with my disney+ app issue. so I have:
Xiaomi POCO X3 NFC
xiaomi.eu MIUI v13.0.1
Android 12
Magisk v25.2
USNF v2.3.1 (Displax mod)

my problem is I can't watch any of their content on FHD, it only shows up to HD quality even though I've subcribed to premium. I've tried logging in the same account on the same device model but w/ locked bootloader and stock rom and it has a FHD quality option. I've also added disney+ to denylist but the issue still persist. I've checked if my device is certified using Play Integrity API Checker (Nikolas Spiridakis). Here's the result:
Had similar issue...
Cloned Disney to workprofile and
Uninstalled main profile Disney.

In work profile clear cache/data
Of Disney and relogin..HD started working again
 

m0han

Senior Member
Apr 30, 2012
5,311
2,410
... L1 Widevine.... I just assumed once you unlock bootloader you lose it. I keep wondering why people seem surprised by this....this has just been the way it is since forever...

I personally weigh this up as the cost of rooting, just like no OTA or warranty on Samsung....
I used to have L1 widewine on my 'bootloader unlocked' device for a long time.

https://forum.xda-developers.com/t/magisk-general-support-discussion.3432382/post-86770763

https://forum.xda-developers.com/t/...y-featured-file-manager.1523691/post-86844883

Sadly, not anymore. I don't know how I lost it. I'd sure like to get it back if I can.
 

inhirz

Member
Mar 5, 2011
44
5
Casablanca
I got this error line in magisk log : stat /data/data/com.android.systemui failed with 2: No such file or directory

Any idea of what it is ?

Device : Oneplus 9
Rom : OxygenOS 13
Magisk : Canary 25205
 

pndwal

Senior Member
sadly its not showing in mine. I don't think I can get it back.
🤔.. what's not showing?.. you showed screenshot of lockscreen??? Are you confused about something?

... Widevine implementation varies wildly across OEMs / devices... Follow links back from my posts above to discover various fixes and cautions...

Nb. Poco F2 Pro, Note 8 Pro, 9S and other users can use Xiaomi's embedded fix to restore lost keys / certification for Widevine... Not sure if it's available in X3... Probably need to restore stock to fix too... Some Poco models got fix before 9S and others... Method should be the same if available... Here's post w/ instructions for 9S...
https://forum.xda-developers.com/t/...p-edits-and-more-v6-1-2.3789228/post-87737559
See also link to April post there... 9S (others?) fix was available with MIUI 11.0.11.0 OJWMIXM but fix isn't automatic; requires you to follow steps to generate new keys / certificate... PW
 
Last edited:
  • Like
Reactions: asripath

pndwal

Senior Member

Erfirya

Member
Aug 20, 2022
16
8
🤔.. what's not showing?.. you showed screenshot of lockscreen??? Are you confused about something?

... Widevine implementation varies wildly across OEMs / devices... Follow links back from my posts above to discover various fixes and cautions...

Nb. Poco F2 Pro, Note 8 Pro, 9S and other users can use Xiaomi's embedded fix to restore lost keys / certification for Widevine... Not sure if it's available in X3... Probably need to restore stock to fix too... Some Poco models got fix before 9S and others... Method should be the same if available... Here's post w/ instructions for 9S... See also link to April post there... 9S (others?) fix was available with MIUI 11.0.11.0 OJWMIXM but fix isn't automatic; requires you to follow steps to generate new keys / certificate... PW
I was trying to show you that in my device, widevine (L1) settings isn't there. This is a screenshot from another device (same model) that has a locked bootloader and stock rom. There's no hope in fixing it anyway so yeah, I'm just gonna stick to custom ROM with root.
 

Attachments

  • 1670054054681_035429.jpg
    1670054054681_035429.jpg
    223.4 KB · Views: 30
  • 1670054054672_035428.jpg
    1670054054672_035428.jpg
    96.5 KB · Views: 30
  • 1670054054664_035425.jpg
    1670054054664_035425.jpg
    138.8 KB · Views: 29
  • Like
Reactions: pndwal

asripath

Senior Member
Jul 12, 2020
227
180
Redmi K20 Pro
cloned using what? can you please elaborate, I'd like to try this. btw HD is working, FHD is what I need to work
Using island.

You can use any workprofile app and
Install Disney in it to check.

Disney might be checking for root.
I could use Disney within browser of the phone with fhd but the app streams at a lower resolution and changing resolution option does not work.

There seems to be a emerging current trend of apps not only checking for root/lsposed
But also checking for root checker apps presence like momo/root beer etc.
 
  • Like
Reactions: pndwal and Erfirya

pndwal

Senior Member
I was trying to show you that in my device, widevine (L1) settings isn't there. This is a screenshot from another device (same model) that has a locked bootloader and stock rom. There's no hope in fixing it anyway so yeah, I'm just gonna stick to custom ROM with root.
Ah... Sorry... But you won't have this in custom rom anyway... If you have Widevine under Fingerprint Payments in late stock miui on x3, I believe you can update and fix certificate... Then you should retain certificate (L1) if you move back to custom ROM (as it was only a bad update that caused keys to be revoked, even on locked devices)... Why do you assume there's no hope?... Of course, there's no guarantees either... PW
 

asripath

Senior Member
Jul 12, 2020
227
180
Redmi K20 Pro
I used to have L1 widewine on my 'bootloader unlocked' device for a long time.

https://forum.xda-developers.com/t/magisk-general-support-discussion.3432382/post-86770763

https://forum.xda-developers.com/t/...y-featured-file-manager.1523691/post-86844883

Sadly, not anymore. I don't know how I lost it. I'd sure like to get it back if I can.
Widevine L1 Fix (Stock MIUI ROM case):

Step 1. Make sure the Auto-sync data is turned on and make sure you turn off Video Toolbox from Settings - Special Features

Go to Settings and scroll down to Accounts and sync - Auto-sync data.

Step 2. Still in Settings, navigate to password & security - fingerprint - fingerprint payment - download the latest Widevine L1 certificate.

Step 3. Reboot your device and check the Widevine security level, it should upgrade to L1.

Notes:
• If still failed, Maybe you have debloat your phone and debloated "Soter Service (Tencent soter service)" which is needed for L1 stuff.
• Reinstall it again from your Xiaomi ADB Tools (Szaki tools)
• Reboot your phone and reinstall Widevine L1 (Step 2)
 

Top Liked Posts

  • There are no posts matching your filters.
  • 8
    Didge says Bye...

    I was very sorry to see yesterday's MHPC commits:
    1. Update FUNDING.yml
      Didgeridoohan committed yesterday

    2. Bye.
      Didgeridoohan committed yesterday
    and the update of @Didgeridoohan's OP in [MODULE] [DEPRECATED] MagiskHide Props Config - SafetyNet, prop edits, and more - v6.1.2 thread:
    MagiskHide Props Config v6.1.2

    Note: This project is dead, and has been for some time. I have not been involved in the Android modding scene for some time and I no longer have the energy to take it up again.

    If anyone feels like taking over give me a holler.
    This project was a mainstay of Magisk modification, giving John Wu's Magisk applet resetprop, an advanced system property manipulation utility, the terminal based UI that made prop manipulation accessible to Magisk users in general...

    Each option has been elegantly implemented to make what would otherwise be an arduous exercise involving user creation of custom boot scripts the no-brainer that we know so well!

    What a project, what a plethora of uses...

    @Didgeridoohan's Last post in that thread was back in February:
    Just popping in and letting everyone know I'm still alive.

    There are simply too many things going on outside the world of Android tinkering for me to be able to give XDA much attention at all. Once things settle down, and if I'm not entirely burnt out by then, I've got quite a lot of catching up to do. Can't give any kind of ETA, but I'm hoping for things clearing up before the end of February.

    Huge thanks to everyone answering questions and helping out...
    ... well clearly no clearing has occurred in Feb. or later... 🙁

    @Didgeridoohan's last XDA post, only weeks later, was a response regarding his officially endorsed comprehensive Magisk Troubleshooting Wiki:
    Everything about Magisk install and more can be found in this great guide by @Didgeridoohan .
    https://www.didgeridoohan.com/magisk/Magisk
    Thank you... With the slight caveat that it needs a serious update after the v24 release. I've just been too swamped IRL the past few months. Hopefully soon™.
    So no further updates to that either, but whatawiki!!! - Still a principle go-to for any non-lazy Magisk user w/ any issue!...

    ... So as a foreigner living in Didgeridooland, I'd like to wish the Didgeridoo man from Sweden all the very best with real life, and to thank him for such elegant contributions to the Magisk modding community...

    I hope you can visit Didgeridooland soon Sir! ... I have a boomerang with your name on it... 👍👏 PW
    6
    The caveat to this is if OEM Unlocking is enabled in Developer Options. I'm not sure if this is a bug; the Pixel devices can be flashed this way even on a locked bootloader.
    Are you referring to when using Android Flash Tool to flash? If this is the case, Android Flash Tool actually unlocks the bootloader (with the prerequisite that OEM Unlocking is enabled) during the process so it can flash the image. If, however, you flash an image via flash-all, for example, with OEM Unlocking enabled but with the bootloader still locked, you won't be able to flash the image.
    6
    Think you might be quoting the wrong person. The person I was responding to couldn't root their phone because their bootloader was locked.
    Sorry, it was @TheNixck . I am going through chemo therapy and I think I have one of the side effects: chemo brain lol!







    6
    kdragon has released an updated version (v2.4.0) of his USNF mod for his Patreon members. Hopefully will go public in a week or two.

    v2.4.0 (early access)

    Repository: kdrag0n/safetynet-fix · Tag: v2.4.0-ea · Commit: 2f18d85 · Released by: kdrag0n

    Highlights​

    • Play Integrity bypass without breaking device checks or causing other issues
    • Disabled use of hardware attestation on Pixel 7 and newer (@anirudhgupta109)

    Other changes​

    • Updated instructions for newer Android and Magisk versions
    • Better debugging for future development
    It's taken a while to find way to bypass Play Integrity that doesn't require spoofing the build fingerprint permanently, but I wanted to make sure this module doesn't cause any unnecessary breakage. Just like the original goal of Universal SafetyNet Fix, this minimizes adverse effects by spoofing dynamically at runtime only when necessary. Enjoy!
    Public release now available.

    6
    Hello, I need some help with spoofing sys.oem_unlock_allowed to 0.

    My banking app (Estonian Swedbank app "Swedbank Eestis," package name "com.swedbank") detects sys.oem_unlock_allowed if it is set to 1 and disables specific options in the app (like biometric login). I can confirm that it is sys.oem_unlock_allowed because setting it temporarily with resetprop -n sys.oem_unlock_allowed 0 and deleting the app data allowed me to use the blocked features. The app doesn't complain about root; hiding root with Zygisk works without issue.

    However, I am unsure what method I should use to safely spoof this value without bricking my device. Is it safe to use resetprop -n? Does it persist after a reboot? Should I use a different method entirely?

    I'm running:
    LineageOS 20-20230105-NIGHTLY-kebab on a OnePlus 8T KB2003
    Magisk 25.2
    Universal SafetyNet Fix 2.4.0
    Swedbank version 21440
    Passing SafetyNet with YASNAC
    I am also spoofing device fingerprint with MagiskHide Props Config to pass SafetyNet.

    I really appreciate any help you can provide.
    Ok, so as guessed in my yesterday's post/answer #54234, it seems that you could more-or-less achieve your wanted functionality - could you try please:

    1) Install the following module and reboot - all thanks to @huskydg for his interesting and excellent module:

    2) Go to:
    /data/adb/modules/magisk_proc_monitor

    and rename the original (dummy/template) dynmount.sh script to dynmount.bak,
    and replace that dynmount.sh with my customized script:

    My changes (customizations) in the script can be recognized as commented by CAPS LOCK comments

    How it works:

    myAPP=com.swedbank defines the package name for your Estonian Swedbank app

    myPROP=sys.oem_unlock_allowed defines the property you want to 'hide'/'un-hide'(corresponding to your Developer Options, OEM Unlock disable/enable switch)

    hidePROP=0 defines the 'hidden' property value (OEM Unlock disabled)
    unhidePROP=1 defines the 'un-hidden' property value (OEM Unlock enabled)

    You can redefine those variables (lines 24-32) if you need

    Eg, I did my own non-intrusive tests (still commented out in the script if somebody else wants to play) with MiXPlorer instead of your banking app:
    myAPP=com.mixplorer

    and by playing with a dummy prop:
    myPROP=my.test

    a)
    When module recognizes that your banking app $myAPP is pre-initializing,
    it will 'hide' $myPROP 'by setting to $hidePROP (lines 39-46)

    and you will see the notification like:
    "Hide my prop / com.swedbank, sys.oem_unlock_allowed=0"

    For this event to happen, the banking app $myAPP must be started, not brought back from background (kill and restart your app)

    b)
    Whenever the module recognizes that any other user app is pre-initializing AND that $myPROP was still 'hidden',
    it will 'un-hide' the prop by setting it back to $unhidePROP (lines 51-60)

    and you will see the notification like:
    "Un-hide my prop / com.xda.labs.play, sys.oem_unlock_allowed=1"

    All the $myPROP sitches are systemless - when you reboot, the prop will be back to its original/default value

    Issue/question:

    Of course, instead of monitoring while any other user app is initializing (case b),
    it would be better if the module could directly recognize when your banking app $myAPP gets closed (killed) and to 'un-hide' then the $myPROP property back

    However, I did not find how to recognize in the dynmount.sh script when an app is really closing and that's why I put the case b as described above

    Maybe the module's developer @huskydg could better customize the script dynmount.sh to more closely cover the original functionality as you needed:
    - 'hide' the $myPROP property only for the $myAPP application

    ---

    The really good and interesting thing with his module is that user can customize the provided default dynmount.sh script
    to catch-up events when particular app(s) are starting to dynamically apply certain changes (redefine certain properties, do particular mounts)

    Otherwise, one would need to develop his own Zygisk module, but there the Zygisk part must be coded in C (and recompiled),
    it cannot be made simply by scripting as here with his simple dynmount.sh script
  • 1089
    This is the place for general support and discussion regarding "Public Releases", which includes both stable and beta releases.
    All information, including troubleshoot guides and notes, are in the Announcement Thread
    156
    Hello, I haven't given much support on XDA lately. It can be resulted from
    • University started and I have limited free time. In fact, I mostly develop during midnight
    • I live in Taiwan, which has large time zone differences between my European/American contributors/testers, which usually forces me to stay up late at night to discuss/test stuffs.
    • The new version is about to come, I don't want to spend effort on supporting old releases
    The planned update is delayed again and again, to some point I think I'll shed some light about what has been happening lately, also along with some announcements.

    New Forum!
    As you might have already discovered, Magisk got its own subforum on XDA! Many thanks to all the support you gave me, and much more information/features/support is about to come!
    **For developers supporting all the devices that are not using standard Android boot format, feel free to create threads in this section (actually, PLEASE do so) for your favorite devices after v7 is out. As I currently know, Asus devices require signing the boot image before flashing, and is model dependant; Sony devices seems to use ELF kernel that is unpatchable, or some has two ramdisks (inner + outer), both requires different workarounds; LG bootloader locked devices has to manually "BUMP" the boot image after flashing Magisk..... and there may be lots of other crazy boot image formats that haven't come up to my attention yet.
    It is impossible for me to support all these non-standard boot images, and I hope the community can collaborate to make Magisk running across all the devices. Overall, community collaboration is what XDA about :D

    The Pixel Phone
    Some of you might already know this news, that the next Pixel Phone right around the corner seems like it does not have ramdisk in boot image, which pretty much wrecked Magisk in all ways. However, it pretty much doomed root itself too. Kernel modifications is inevitable IMO, so I'll try to migrate my scripts to C programs that could possibly be included into the kernel itself. Note that I'm not familiar with linux kernel, I'm not even sure if my idea and concept is correct or not. But once the device is available, I think developers will find a way to bypass all the difficulties, and I'll do my best to learn things ;)

    Current Progress
    In the past month, I've spent quite some time learning SELinux, so that I can avoid using SuperSU's sepolicy patches. Thanks to the helps and tips from @phhusson and @Chainfire, I finally have a much clearer understanding of how SELinux works. The Magisk core parts (the scripts, boot image patches, new features, more supports) are actually done some time ago. What is causing all the delays is the Magisk Manager.
    To be completely honest, although I can code in Java without much issues, Magisk Manager is actually my first Android application, I had to reach out for assistance, and fortunately awesome developers like @DVDandroid and @digitalhigh contributed a lot, which makes the current Manager awesome.
    After the repo system and module management is mostly done, I was about to do some adjustments and release, but what we really done is decided to add another feature: auto-unroot with per-app settings. I decided to wait for it to be finished, and then do my adjustments. Due to reasons that'll be mentioned later, this feature will likely not be available for the next release (should come in future updates)

    Safety Net Disaster
    Those who are using Magisk for Safety Net bypass purposes must have known that Google recently updated the detection method of my Systemless Xposed. I still have no idea what Safety Net is detecting, so currently I cannot fix it on my side (also because I'm busy working on the next update). However, suhide developed by @Chainfire is able to hide Xposed and worked fine.
    However, only my Systemless Xposed v86.2, which is based on SuperSU's su.d, is supported using that method. v86.2 and v86.5 (latest, Magisk based) have nearly identical binaries, and the only difference is the path where the binaries are stored.
    I'm still not sure what's the real issue for it not being supported, I just hope it is not done intentionally.

    Conclusion
    Due to the fact that my Safety Net bypass is not 100% perfect now, I do not want to spend any more time waiting for auto-unroot to be polished. What I'm doing now is finishing up all the things I'd like to change in Magisk Manager (it has been a while since I last contributed to Manager, my fellow developers are doing all the heavy job), which might take a little more time, after that, packed with tons of information to be announced in Magisk Section, I'll release the long awaited update.

    Hope this lengthy post gives you the idea of the whole situation, and again thanks for all your support!!
    121
    Ah, some Chainfire bashing, I hope it is not too late for me to exercise additional villainy.

    First, let me make clear I have nothing against @topjohnwu, nor against Magisk. Magisk is an interesting project and it certainly displays @topjohnwu ingenuity and persistence. I don't doubt we will see more interesting things from his hands.

    -------------------------

    What has happened here is not all that dark and complicated, from either end. I returned from holidays, and someone pointed me at Magisk. My first thought: interesting!

    Among other things, the thread lists some issues with SuperSU, which in combination with the phrase The developer also requests users to not bug Chainfire with compatibility requests for SuperSU with Magisk from the portal article, raised my left eyebrow by nigh half an inch. The popular systemless xposed mod is apparently now based on it, and apparently it now no longer works with SuperSU, and apparently I'm not supposed to fix that, nor any of the other found issues. I found that a bit weird. So yes, I have told @topjohnwu that I was a bit surprised he was posting about issues with SuperSU without notifying me about them (I can't fix or help fix issues I'm not aware of, after all).

    He's also spreading a modified version of the SuperSU package, which is not all that uncommon, nor necessarily a problem. I have not looked into what he modified, I only ran a few quick tests on one of my devices, and found some commonly used commands run as root to be broken. I have informed him of this as well.

    It appears the tool of choice for Magisk is phh's Superuser, because of some of the mentioned issues with SuperSU. That's fine by itself, but fixing issues in that superuser by incorporating SuperSU's binaries into it is a somewhat questionable practise. After all, SuperSU is a commercial closed-source package that helps pay for my dinner, and superuser is a direct competitor. I have informed him that I was surprised he did this without asking for permission. I have expressed similar surprise on him spreading a modified version of LiveBoot (which helps pay for a snack now and then).
    @topjohnwu has also stated that Magisk's scripts are largely influenced by mine (I have not checked). Scripts based on mine are used all over the place on XDA, some people have crafted amazing things based on them, I have never made an issue of this (otherwise I would have just made them binaries). But yes, I have also stated to him that I don't think it's very nice to base something on one program, and then using that to (almost exclusively) push something directly competing with that program.

    tl;dr Towards @topjohnwu, I have:
    - expressed surprise he has issues getting Magisk to work with SuperSU, and has chosen not to inform me about those
    - expressed surprise he is using SuperSU binaries in a competing superuser without permission
    - expressed surprise he is posting a modified LiveBoot without permission
    - informed him of issues with the modified SuperSU he has posted
    - let him know I thought it wasn't very nice to be applying my scripts to benefit seemingly exclusively that same competing superuser

    To be crystal clear:
    - I have not asked for an apology
    - I have not asked for Magisk to be abandoned, neither the root hiding nor systemless module parts, and certainly not systemless xposed
    - I have not made an issue of any of this anywhere, until this post
    - I have not even specifically asked for anything to be taken down (though obviously in my opinion the other superuser package mixed with SuperSU's binaries, as well as the LiveBoot package, should go)
    - I have not reported this thread to XDA moderators for copyright violations or otherwise

    While my conversation with @topjohnwu may not win any awards for being friendly (though it may win some for brevity), I think all things considered my response has been rather mild. To be perfectly honest, until the apology post, I thought this was over with already. I think the apology post was triggered because I haven't replied to his last PM for a while - I was in the zone, it happens.

    To emphasize again, I have nothing against @topjohnwu, Magisk, or systemless xposed, and it is certainly not my goal to see any of them go. If it can be made to work together with SuperSU, great.

    I get it though: you think of something, you want to see if you can make it work, you finally get it to work, you publish it, it takes off - enthusiasm gets the better of you. Maybe in the rush some mistakes are made. That doesn't mean you have to just drop it and run. None of my stuff would make it past 0.1 if I stopped at the first big mistake :)

    Aside from said being in the zone coding, I usually regret actually responding to these sort of things the day after, which has made me hesitant to reply. Surprise me.
    76
    Thread temporarily closed so everyone sees this.

    The flood of "SafetyNet isn't working for me either!" posts are not helpful, at all. Please refrain from posting further, it will be looked into. Please do not forget that not passing SafetyNet is 100% NORMAL AND INTENDED when you have an unlocked booloader or running custom firmware. These are workarounds and they will be worked around in turn.

    The Flash
    Forum Moderator

    EDIT: Thread is reopened... I will be cleaning any SafetyNet posts for a while to keep the thread clean for real issues.
    75
    Hello everyone!

    I am aware that Google has updated Safety Net that makes Magisk itself a no go for Android Pay. In fact, I witnessed the change live while I am developing the new magiskhide, which should hide all Magisk modules and Magisk installed root.

    Google is serious about Safety Net now, clearly hunting down all possibility to run Xposed with Safety Net passed. I spend quite some time examining the new security measures last midnight, and fortunately it seems that it is possible to run Magisk and root along with Safety Net if no Xposed is running. I'm glad I removed the old root toggle at the right time lol, that is no longer feasible with the latest detection.

    So stay tuned for the next update, it will come with bug fixes, along with the new magiskhide to bypass that Safety Net.

    Google, how will a few systemless mods do any harm :p:p