Magisk General Support / Discussion

Search This thread

pndwal

Senior Member
Okay. I'm using both in tandem. (The only way to get Google-Pay working, it seems.)

I will search for Displax's mod.

Unfortunately Shamiko gives my a phone a lot of instability: crashing, freezing, hanging, forced to hold-power-button-reset...
You didn't add any gms processes in denylist did you?... Don't do that with any Zygisk USNF solutions...

Interesting Shamiko issue... Shouldn't cause that... Please give device / OS / setup details...

I would generally suggest keeping Shamiko, but you don't actually need it for G Pay/Wallet... PW
 
  • Like
Reactions: ipdev and J.Michael

blksith0

Senior Member
Aug 10, 2008
232
28
You didn't add any gms processes in denylist did you?... Don't do that with any Zygisk USNF solutions...

Interesting Shamiko issue... Shouldn't cause that... Please give device / OS / setup details...

I would generally suggest keeping Shamiko, but you don't actually need it for G Pay/Wallet... PW
Thanks for replying.
Nothing like that in the denylist. I've disabled shamiko and now trying out only the Displax 2.3.1 mod. Seems to be okay...
Sometimes I think it might be easier to just go the Magisk Delta mod and bring Magisk Hide back!

device: Google Pixel 3a (sargo)
ROM: crDroid, Android 12.1
 
  • Like
Reactions: ipdev and pndwal

pndwal

Senior Member
Thanks for replying.
Nothing like that in the denylist. I've disabled shamiko and now trying out only the Displax 2.3.1 mod. Seems to be okay...
Sometimes I think it might be easier to just go the Magisk Delta mod and bring Magisk Hide back!

device: Google Pixel 3a (sargo)
ROM: crDroid, Android 12.1
Ah, custom crDroid... I think that normally integrates @kdrag0n SNF per Proton ROM options (2 methods offered), and may also pull extra @Displax fixes... could be wrong...

You could try this:

Remove USNF completely, add Google Play Services attestation/droidguard (com.google.android.gms.unstable) and main (com.google.android.gms) processes in denylist (enforced) and reboot...

Check YASNAC results... You should be passing S/N (ctsProfileMatch) w/ BASIC evaluationType...

Check Play Integrity API Checker results... If you have recent crDroid and maintaining Dev has added recent fixes for SNF you should be passing deviceIntegrity too... If not, you may be best to run a @Displax modded USNF build... You could alternatively globally spoof (eg with MHPC module) a mismatched but passing fingerprint prop that bypasses fingerprint property based PI-hardware-based-verdict-enforcement, but targeting spoofing is preferable...

If you can pass PI deviceIntegrity with no USNF module this way, you could also disable denylist enforcement and check if Shamiko becomes stable with this setup... PW
 
  • Like
Reactions: ipdev and blksith0

meric57

Senior Member
Oct 2, 2017
292
58
Oeutrange
Samsung Galaxy Tab E
Hello, I would like to know the reason when installing an application or updating the fox manager apk or others. Magisk application is found unavailable.

As in the screenshot, then no more root, so I must again reflash the AP patch_magisk and the 3 CP -BL and home CSC files with odin.

There is no direct way to recover with magisk.

thank
 

Attachments

  • Screenshot_20230130_150401.jpg
    Screenshot_20230130_150401.jpg
    189.3 KB · Views: 60
  • Screenshot_20230204_132436.jpg
    Screenshot_20230204_132436.jpg
    296.1 KB · Views: 62

badabing2003

Recognized Contributor
Sep 17, 2012
1,879
2,466
Hello, I would like to know the reason when installing an application or updating the fox manager apk or others. Magisk application is found unavailable.

As in the screenshot, then no more root, so I must again reflash the AP patch_magisk and the 3 CP -BL and home CSC files with odin.

There is no direct way to recover with magisk.

thank
Would you happen to have two instances?
Notice the package name of one which is hidden and the other not hidden
 

pndwal

Senior Member
Hello, I would like to know the reason when installing an application or updating the fox manager apk or others. Magisk application is found unavailable.

As in the screenshot, then no more root, so I must again reflash the AP patch_magisk and the 3 CP -BL and home CSC files with odin.

There is no direct way to recover with magisk.

thank
In your first screenshot you have full Magisk App (not hidden)... I'm guessing you also had the stub (hidden) App still installed and that's causing the conflict...

In the second screenshot you have stub (ver 33) (hidden) App restored...

In the first case, simply uninstalling the hidden App should allow the full App to work again, and you can also then hide it again... 🙂 PW
 

meric57

Senior Member
Oct 2, 2017
292
58
Oeutrange
Samsung Galaxy Tab E
Hello Badading2003, magisk is hidden in the magisk parameter, the root is present until I install a third-party or magisk-specific apk. As on the screenshot, neither magisk nor zigysk is available, so the root jumps at startup, there is no way to recover the magisk application directly the magisk application in boot.img or recovery.img flash.

why is talking about two instence , LSPosed .apk install in module

normal the capture already registered following the previous problem with LSPosed APK, the I have just restored magisk hidden these good.
I would like to know the reason as explained during updates or apk installation.
I find magisk not available and application ok
 
Last edited:

pndwal

Senior Member
Hello Badading2003, magisk is hidden in the magisk parameter,
The fact is, in your first screenshot (w/ root not recognised by app) your App shown as installed is NOT the hidden App (App is NOT hidden); it's actually a completely different app to the hidden one; hiding uninstalls full 17MB app and installs the v33 tiny stub App and later fills it's data with approx. 17MB of data (Magisk binaries)...

If you think you had the hidden App you're probably right!... you actually had Both! Ie. Two instances!... Believe me, that's very common... root and modules are still there, but App can't see them when two Apps are competing... 🙃 PW
 

meric57

Senior Member
Oct 2, 2017
292
58
Oeutrange
Samsung Galaxy Tab E
Hello pndwal, yes I have hidden magisk in magisk parameter. My concern that I would like to know why as explained during an example installation yesterday I installed superNDS a DS nitendo emulator. apk then in magisk not available and application always install, how to fix worry because each time you have to flash with odin to recover the root.
I use google translate I'm French so hard for my spelling
 

pndwal

Senior Member
Hello pndwal, yes I have hidden magisk in magisk parameter..
Then why is full App still installed in screenshot??? It should be gone!... If Magisk installed it during an update and failed to uninstall hidden stub, you simply need to uninstall one or other, or sometimes both apps and reinstall for one app to work again...
... each time you have to flash with odin to recover the root...
No, no such need; if you had hidden app as you state, you do need to remove the full app which is clearly installed also... You can't have two Magisk apps... 😶 PW
 

meric57

Senior Member
Oct 2, 2017
292
58
Oeutrange
Samsung Galaxy Tab E
Complicated this situation which is to install that its is magisk and sigisk and application magisk ok, why magisk this uninstalls during an installation of an apk.

I don't have a bank problem, just that I would like to know how to solve this problem during an installation after a restart
At the moment I wanted to hide magisk again I got an error then I restarted my S 10 magisk not available, so to find my root I must redo with odin BL -APp atched _magisk -home CSC

Screenshot after flashing to find the root in magisk
 

Attachments

  • Screenshot_20230204_161741.jpg
    Screenshot_20230204_161741.jpg
    294.4 KB · Views: 41
  • Screenshot_20230204_132436.jpg
    Screenshot_20230204_132436.jpg
    296.1 KB · Views: 42
  • Screenshot_20230204_161907.jpg
    Screenshot_20230204_161907.jpg
    291.5 KB · Views: 40
  • Screenshot_20230204_161813.jpg
    Screenshot_20230204_161813.jpg
    335.4 KB · Views: 40
Last edited:

badabing2003

Recognized Contributor
Sep 17, 2012
1,879
2,466
Complicated this situation which is to install that its is magisk and sigisk and application magisk ok, why magisk this uninstalls during an installation of an apk.

I don't have a bank problem, just that I would like to know how to solve this problem during an installation after a restart
At the moment I wanted to hide magisk again I got an error then I restarted my S 10 magisk not available, so to find my root I must redo with odin BL -APp atched _magisk -home CSC

Screenshot after flashing to find the root in magisk
You can't have multiple instances of Magisk manager.
What is sigisk?
I would uninstall all Magisk Managers (don't worry you won't lose root by doing so)
Start with uninstalling the unhidden one if you have one currently.
Code:
adb shell pm uninstall com.topjohnwu.magisk
Next unhide Magisk if you have one
if you can't find one look for Application Accueil
then uninstall it
repeat the process if you have more hidden Magisk Apps or Accueil that is Magisk
You can also issue these commands based on your screenshots
Code:
adb shell pm uninstall tu.ec
adb shell pm uninstall r.iazafs.l.kn.jntj

When you have all Magisks uninstalled
Reboot
See if you find Magisk Manager after reboot.
If you don't, just go ahead and install it
Hide if you want.
If you get an error during hiding, that is a clue that you will encounter a problem.
Perhaps it is failing to uninstall the unhidden one, which is causing multiple versions to exists and pose problems.
 

meric57

Senior Member
Oct 2, 2017
292
58
Oeutrange
Samsung Galaxy Tab E
Good evening Badading2003, I am with samsung first generation so exynos not 5 G in 4 G.
As marked in signature A12, applist detector I have this so no worries I think on the hidden side of magisk.
Me my concern what I would like to know why magisk is unavailable when installing an APK ???
Then how to re-install magisk as shown on a screenshot.
look at the applist detector screenshot,you see in application not available and tu.ec package therefore hidden.
 

Attachments

  • Screenshot_20230204_170941.jpg
    Screenshot_20230204_170941.jpg
    319 KB · Views: 36
  • Screenshot_20230204_171822.jpg
    Screenshot_20230204_171822.jpg
    277.9 KB · Views: 35
Last edited:

badabing2003

Recognized Contributor
Sep 17, 2012
1,879
2,466
Good evening Badading2003, I am with samsung first generation so exynos not 5 G in 4 G.
As marked in signature A12, applist detector I have this so no worries I think on the hidden side of magisk.
Me my concern what I would like to know why magisk is unavailable when installing an APK ???
Then how to re-install magisk as shown on a screenshot.
look at the applist detector screenshot
You have to realize that there is two parts to Magisk.
The manager which is the ui component, and the core, which is what you flash.
When you have multiple managers, then they would get confused about the state.
I bet you're still rooted even though the manager says you're not.
Run a root app and you'd see.
The solution is to keep only one copy/version of manager.
 

meric57

Senior Member
Oct 2, 2017
292
58
Oeutrange
Samsung Galaxy Tab E
yes, these are where I don't understand the magisk party and magisk app.
When I see the part magisk not available and zigisk not available when I do with root checker its me not root as I know that if I unroot with the official rom the knox0x1 so concern for system health samsung applications.
the information you said is explained or on the forum.
 
Last edited:

badabing2003

Recognized Contributor
Sep 17, 2012
1,879
2,466
yes, these are where I don't understand the magisk party and magisk app.
When I see the part magisk not available and zigisk not available when I do with root checker its me not root as I know that if I unroot with the official rom the knox0x1 so concern for system health samsung applications.
the information you said is explained or on the forum.
Have you tried my suggestion?
 
  • Like
Reactions: J.Michael

J.Michael

Recognized Contributor
Jan 20, 2018
1,657
1,831
Samsung Galaxy Tab A series
yes, these are where I don't understand the magisk party and magisk app.
When I see the part magisk not available and zigisk not available when I do with root checker its me not root as I know that if I unroot with the official rom the knox0x1 so concern for system health samsung applications.
the information you said is explained or on the forum.
When you run the Magisk app, the first screen has two parts. The top part is describing the magic Magisk installed in boot or recovery. The next part down is describing the Magisk manager app. Where it says "Paquet" (packet? package?) it is identifying the app. When it says "com.topjohnwu.magisk", that means an unhidden Magisk manager app. When it says jumbled name, like "r.iazafs.l.kn.jntj", that means a hidden Magiso manager app. It is not good to have more than one Magisk manager app.

Are you generating new screen shots every timevyou post? I am trying to understand whether you can see both of these Magisk screens without changing your system.

Stop hiding the Magisk manager app.
 

pndwal

Senior Member
@meric57, all, FWIW:
you run the Magisk app, the first screen has two parts. The top part is describing the magic Magisk installed in boot or recovery. The next part down is describing the Magisk manager app. Where it says "Paquet" (packet? package?) it is identifying the app. When it says "com.topjohnwu.magisk", that means an unhidden Magisk manager app. When it says jumbled name, like "r.iazafs.l.kn.jntj", that means a hidden Magiso manager app.
Yup, and further,
IMG_20230205_135412.jpg

indicates installed App is full ver 25200 whereas
IMG_20230205_135602.jpg

indicates installed App is stub ver 33 w/ binaries from 25200 loaded in its data...

As I've already said,
...App shown as installed is NOT the hidden App...
Also https://forum.xda-developers.com/t/magisk-general-support-discussion.3432382/post-88094379

Full App is
actually a completely different app to the hidden one...
Hidden App is simply an empty shell/container, ie the
and Magisk simply
fills it's data with approx. 17MB of data (Magisk binaries)...
extracted from the current full App (.apk package) before that is removed...

But often the Hide the Magisk app option fails to remove the full app!!!

In this situation we end up with dual apps, which is very easily done since we haven't simply installed an update, but rather a different app with different package name and signing keys!!!... The former (competing) full app/package needs special treatment to be removed after its binaries are transferred to the stub app...

Also, this situation is
very common... root and modules are still there, but App can't see them when two Apps are competing... 🙃 PW
If Magisk... failed to uninstall hidden stub, you simply need to uninstall one or other, or sometimes both apps and reinstall for one app to work again...

... You can't have two Magisk apps... 😶 PW
😬 PW
 
Last edited:

meric57

Senior Member
Oct 2, 2017
292
58
Oeutrange
Samsung Galaxy Tab E
Hello thank you for your answers pndwal and J.Michael, ok I don't see why and how to reinstall following a third-party installation or other magisk which shows me not available and zygisk not available without going through odin.
I would like to know if possible to do with ABD or other direct from the smartphone to find magisk on yes and zigisk on yes, I'm talking about magisk the one who is first step APP which is always installed.
I saw on the son of descution which must be done with boot.img or recovery.img of the file patched_magisk.img.tar, will have to make an explanation on the first page of this forum to recover magisk not available.
THANKS

I do it like this I reflash with the 3 files from the official home rom CSC -BL-CP- patched-magisk.img.tar, root recovery which is not practical slower which works all the same.

Also I read that USNF of KdragOn was broken which has a modification must go through the modified version, I put you 2 screenshots one to show that I removed the cache of magisk and the other the module in question is he the one who needs to be changed.
 

Attachments

  • Screenshot_20230205_083359.jpg
    Screenshot_20230205_083359.jpg
    404.1 KB · Views: 25
  • Screenshot_20230205_083327.jpg
    Screenshot_20230205_083327.jpg
    286.7 KB · Views: 25

J.Michael

Recognized Contributor
Jan 20, 2018
1,657
1,831
Samsung Galaxy Tab A series
Hello thank you for your answers pndwal and J.Michael, ok I don't see why and how to reinstall following a third-party installation or other magisk which shows me not available and zygisk not available without going through odin.
I would like to know if possible to do with ABD or other direct from the smartphone to find magisk on yes and zigisk on yes, I'm talking about magisk the one who is first step APP which is always installed.
I saw on the son of descution which must be done with boot.img or recovery.img of the file patched_magisk.img.tar, will have to make an explanation on the first page of this forum to recover magisk not available.
THANKS

I do it like this I reflash with the 3 files from the official home rom CSC -BL-CP- patched-magisk.img.tar, root recovery which is not practical slower which works all the same.

Also I read that USNF of KdragOn was broken which has a modification must go through the modified version, I put you 2 screenshots one to show that I removed the cache of magisk and the other the module in question is he the one who needs to be changed.
Do you have a problem now?
Do you have Magisk available at this moment?

Stop re-installing Magisk. Do not use Odin when you think you have lost Magisk. We do not think you have really lost Magisk.

You have a lot going on. You are doing a lot of things. The next time you think you have lost Magisk, do not reinstall Magisk. Look around for Magisk manager apps in your app drawer. If you find two -- that is probably the problem. Uninstall all of them. Do not uninstall Magisk. Uninstall apps -- Magisk manager apps. Then install the Magisk manager app apk. See if that can see Magisk is already installed.

Can you stop trying to hide the Magisk manager app?

Did you try @badabing2003's suggestions? (Using the command line to remove packages.)
 
  • Like
Reactions: badabing2003

Top Liked Posts

  • 1
    The phone is not rooted?

    Did you really fully uninstall Magisk or just Magisk app (Magisk app is only the UI interface, like a manager)?

    As I asked, make sure to pass Basic and Device Integrity by Play Integrity API checker (find on Playstore, you don't need Magisk to install from PlayStore and to test)

    But you will not pass if your Bootloader is unlocked (uninstalling Magisk is not enough, you must not have custom ROM and you have to re-lock Bootloader)

    Banking and similar apps first of all test Play Integrity - if you don't pass Play Integrity, do not expect your MitID would work
    Magisk is fully uninstalled. I usually have two boot images one stock and one rooted, which I swap around after needs. But I got to lazy and just went unrooted for a while now.

    But good that u mention regarding Safety Net. I completely forgot about that part, that an unlocked bootloader makes it fail.

    Thanks for your responses.
  • 12
    . . . found a YT video that explains you can download the APK, rename to .zip, and install it as a module. Hopefully that works 😯
    Not only does it work, but if you take a few extra steps, you can make a 100% clean install of ANY Magisk version or fork without PC or TWRP.
    Here's how I do it :-

    - Download Magisk version/fork you want to try
    - Add .zip to the end of the Magisk apk eg: Magisk.apk becomes Magisk.apk.zip
    - Unhide the Magisk app if you have hidden/renamed it
    - Turn on aeroplane mode
    - Delete /data/adb/Magisk folder and /data/adb/magisk.db file
    - In Magisk app, perform Uninstall Magisk - RESTORE IMAGES so you are back on stock boot image
    - Install the new Magisk.apk.zip as a module
    - Change Magisk.apk.zip back to Magisk.apk
    - Uninstall the Magisk app (the apk only NOT Magisk itself)
    - Reboot
    - Install the new Magisk.apk
    - Open it up and check settings and modules and customise to your needs eg: zygisk may need to be re-enabled and deny list reconfigured
    - Reboot again and turn off aeroplane mode

    You will now be on a new clean install of whatever Magisk you are trying. No loss of root or modules and no need to clear data from play services to re-enable wallet (assuming it worked before and you set everything up properly)
    Only thing left to do is grant root to whatever apps need it.
    11
    how/where do you get prior canary builds if you're on the latest?
    Magisk canary builds are available on GitHub.
    You just have to look at the history. 🙃

    Canary builds are hosted in the magisk-files repo.
    magisk-files (Canary commit history) - [GitHub] - Link
    Select the build commit you are looking for.
    Select the apk file and "View File".
    You can then Download or "View raw".
    Since it can not show you the raw file, it will start the download of the file.
    mcanary1.png
    mcanary2.png
    mcanary3.png
    mcanary4.png

    Cheers. :cowboy:
    10
    Thread lightly cleaned!

    @S8rooted&tooted and @pndwal

    Greetings to you both. As you have both noticed, I have cleaned this thread of some of your recent comments. I will politely ask you both to please refrain from
    further OT and argumentative comments, and to please conduct yourselves in accordance with XDA Rule #2.3 for member conduct:

    2.3 Flaming / Lack of respect: XDA is about sharing and this does not involve virtual yelling (flaming) or rudeness. Flaming or posting with a lack of respect is unacceptable. Treat new members in the manner in which you would like to have been treated when you were a new member. When dealing with any member, provide them with guidance, advice and instructions when you can, showing them respect and courtesy. Never post in a demanding, argumentative, disrespectful or self-righteous manner.

    If you wish to argue further, then please do so via PM's, or another platform since XDA is not the place for these types of discussions on the public forums. Please be advised, posts which continue to violate the forum rules will be removed with immediate effect, and posiible sanctions applied to your account should things get too far out of hand, which we certainly do not want.
    So please let this be the end of this here and now.

    Thank you for your cooperation, and hope you have a pleasant day.

    Best regards: Badger50
    8
    I always find thread search results to be in reverse chronological order. I only use browser. Are you using app?

    Probably easier to just read last five pages -- not all relevant posts will use keyword you chose.
    Searching tips (again)
    XDA app or browser:

    1) "Search this thread"
    On top,
    do not enter any keyword, it will be ignored at the moment, "Search"

    2) When it shows results for:
    "Search results for: *"
    Click on that star/asterisk/wildcard sign
    and replace the wildcard with your search keyword, like "systemless"

    3) Scroll little bit down and checkmark "Recent"
    (who cares about the posts from 2017).
    "Search"

    Then, you will have results from this thread, most recent on top, for the keyword you asked
    8
    View attachment 5853939
    @osm0sis now they are going to remove custom recovery support 😂

    It is because Magisk can't work properly on some broken custom recoveries, which mount partitions with wrong devices...
    Found no way to workaround it other than detecting and warning user to reinstall Magisk manually...
  • 1091
    This is the place for general support and discussion regarding "Public Releases", which includes both stable and beta releases.
    All information, including troubleshoot guides and notes, are in the Announcement Thread
    156
    Hello, I haven't given much support on XDA lately. It can be resulted from
    • University started and I have limited free time. In fact, I mostly develop during midnight
    • I live in Taiwan, which has large time zone differences between my European/American contributors/testers, which usually forces me to stay up late at night to discuss/test stuffs.
    • The new version is about to come, I don't want to spend effort on supporting old releases
    The planned update is delayed again and again, to some point I think I'll shed some light about what has been happening lately, also along with some announcements.

    New Forum!
    As you might have already discovered, Magisk got its own subforum on XDA! Many thanks to all the support you gave me, and much more information/features/support is about to come!
    **For developers supporting all the devices that are not using standard Android boot format, feel free to create threads in this section (actually, PLEASE do so) for your favorite devices after v7 is out. As I currently know, Asus devices require signing the boot image before flashing, and is model dependant; Sony devices seems to use ELF kernel that is unpatchable, or some has two ramdisks (inner + outer), both requires different workarounds; LG bootloader locked devices has to manually "BUMP" the boot image after flashing Magisk..... and there may be lots of other crazy boot image formats that haven't come up to my attention yet.
    It is impossible for me to support all these non-standard boot images, and I hope the community can collaborate to make Magisk running across all the devices. Overall, community collaboration is what XDA about :D

    The Pixel Phone
    Some of you might already know this news, that the next Pixel Phone right around the corner seems like it does not have ramdisk in boot image, which pretty much wrecked Magisk in all ways. However, it pretty much doomed root itself too. Kernel modifications is inevitable IMO, so I'll try to migrate my scripts to C programs that could possibly be included into the kernel itself. Note that I'm not familiar with linux kernel, I'm not even sure if my idea and concept is correct or not. But once the device is available, I think developers will find a way to bypass all the difficulties, and I'll do my best to learn things ;)

    Current Progress
    In the past month, I've spent quite some time learning SELinux, so that I can avoid using SuperSU's sepolicy patches. Thanks to the helps and tips from @phhusson and @Chainfire, I finally have a much clearer understanding of how SELinux works. The Magisk core parts (the scripts, boot image patches, new features, more supports) are actually done some time ago. What is causing all the delays is the Magisk Manager.
    To be completely honest, although I can code in Java without much issues, Magisk Manager is actually my first Android application, I had to reach out for assistance, and fortunately awesome developers like @DVDandroid and @digitalhigh contributed a lot, which makes the current Manager awesome.
    After the repo system and module management is mostly done, I was about to do some adjustments and release, but what we really done is decided to add another feature: auto-unroot with per-app settings. I decided to wait for it to be finished, and then do my adjustments. Due to reasons that'll be mentioned later, this feature will likely not be available for the next release (should come in future updates)

    Safety Net Disaster
    Those who are using Magisk for Safety Net bypass purposes must have known that Google recently updated the detection method of my Systemless Xposed. I still have no idea what Safety Net is detecting, so currently I cannot fix it on my side (also because I'm busy working on the next update). However, suhide developed by @Chainfire is able to hide Xposed and worked fine.
    However, only my Systemless Xposed v86.2, which is based on SuperSU's su.d, is supported using that method. v86.2 and v86.5 (latest, Magisk based) have nearly identical binaries, and the only difference is the path where the binaries are stored.
    I'm still not sure what's the real issue for it not being supported, I just hope it is not done intentionally.

    Conclusion
    Due to the fact that my Safety Net bypass is not 100% perfect now, I do not want to spend any more time waiting for auto-unroot to be polished. What I'm doing now is finishing up all the things I'd like to change in Magisk Manager (it has been a while since I last contributed to Manager, my fellow developers are doing all the heavy job), which might take a little more time, after that, packed with tons of information to be announced in Magisk Section, I'll release the long awaited update.

    Hope this lengthy post gives you the idea of the whole situation, and again thanks for all your support!!
    121
    Ah, some Chainfire bashing, I hope it is not too late for me to exercise additional villainy.

    First, let me make clear I have nothing against @topjohnwu, nor against Magisk. Magisk is an interesting project and it certainly displays @topjohnwu ingenuity and persistence. I don't doubt we will see more interesting things from his hands.

    -------------------------

    What has happened here is not all that dark and complicated, from either end. I returned from holidays, and someone pointed me at Magisk. My first thought: interesting!

    Among other things, the thread lists some issues with SuperSU, which in combination with the phrase The developer also requests users to not bug Chainfire with compatibility requests for SuperSU with Magisk from the portal article, raised my left eyebrow by nigh half an inch. The popular systemless xposed mod is apparently now based on it, and apparently it now no longer works with SuperSU, and apparently I'm not supposed to fix that, nor any of the other found issues. I found that a bit weird. So yes, I have told @topjohnwu that I was a bit surprised he was posting about issues with SuperSU without notifying me about them (I can't fix or help fix issues I'm not aware of, after all).

    He's also spreading a modified version of the SuperSU package, which is not all that uncommon, nor necessarily a problem. I have not looked into what he modified, I only ran a few quick tests on one of my devices, and found some commonly used commands run as root to be broken. I have informed him of this as well.

    It appears the tool of choice for Magisk is phh's Superuser, because of some of the mentioned issues with SuperSU. That's fine by itself, but fixing issues in that superuser by incorporating SuperSU's binaries into it is a somewhat questionable practise. After all, SuperSU is a commercial closed-source package that helps pay for my dinner, and superuser is a direct competitor. I have informed him that I was surprised he did this without asking for permission. I have expressed similar surprise on him spreading a modified version of LiveBoot (which helps pay for a snack now and then).
    @topjohnwu has also stated that Magisk's scripts are largely influenced by mine (I have not checked). Scripts based on mine are used all over the place on XDA, some people have crafted amazing things based on them, I have never made an issue of this (otherwise I would have just made them binaries). But yes, I have also stated to him that I don't think it's very nice to base something on one program, and then using that to (almost exclusively) push something directly competing with that program.

    tl;dr Towards @topjohnwu, I have:
    - expressed surprise he has issues getting Magisk to work with SuperSU, and has chosen not to inform me about those
    - expressed surprise he is using SuperSU binaries in a competing superuser without permission
    - expressed surprise he is posting a modified LiveBoot without permission
    - informed him of issues with the modified SuperSU he has posted
    - let him know I thought it wasn't very nice to be applying my scripts to benefit seemingly exclusively that same competing superuser

    To be crystal clear:
    - I have not asked for an apology
    - I have not asked for Magisk to be abandoned, neither the root hiding nor systemless module parts, and certainly not systemless xposed
    - I have not made an issue of any of this anywhere, until this post
    - I have not even specifically asked for anything to be taken down (though obviously in my opinion the other superuser package mixed with SuperSU's binaries, as well as the LiveBoot package, should go)
    - I have not reported this thread to XDA moderators for copyright violations or otherwise

    While my conversation with @topjohnwu may not win any awards for being friendly (though it may win some for brevity), I think all things considered my response has been rather mild. To be perfectly honest, until the apology post, I thought this was over with already. I think the apology post was triggered because I haven't replied to his last PM for a while - I was in the zone, it happens.

    To emphasize again, I have nothing against @topjohnwu, Magisk, or systemless xposed, and it is certainly not my goal to see any of them go. If it can be made to work together with SuperSU, great.

    I get it though: you think of something, you want to see if you can make it work, you finally get it to work, you publish it, it takes off - enthusiasm gets the better of you. Maybe in the rush some mistakes are made. That doesn't mean you have to just drop it and run. None of my stuff would make it past 0.1 if I stopped at the first big mistake :)

    Aside from said being in the zone coding, I usually regret actually responding to these sort of things the day after, which has made me hesitant to reply. Surprise me.
    76
    Thread temporarily closed so everyone sees this.

    The flood of "SafetyNet isn't working for me either!" posts are not helpful, at all. Please refrain from posting further, it will be looked into. Please do not forget that not passing SafetyNet is 100% NORMAL AND INTENDED when you have an unlocked booloader or running custom firmware. These are workarounds and they will be worked around in turn.

    The Flash
    Forum Moderator

    EDIT: Thread is reopened... I will be cleaning any SafetyNet posts for a while to keep the thread clean for real issues.
    75
    Hello everyone!

    I am aware that Google has updated Safety Net that makes Magisk itself a no go for Android Pay. In fact, I witnessed the change live while I am developing the new magiskhide, which should hide all Magisk modules and Magisk installed root.

    Google is serious about Safety Net now, clearly hunting down all possibility to run Xposed with Safety Net passed. I spend quite some time examining the new security measures last midnight, and fortunately it seems that it is possible to run Magisk and root along with Safety Net if no Xposed is running. I'm glad I removed the old root toggle at the right time lol, that is no longer feasible with the latest detection.

    So stay tuned for the next update, it will come with bug fixes, along with the new magiskhide to bypass that Safety Net.

    Google, how will a few systemless mods do any harm :p:p