Magisk General Support / Discussion
- Thread starter topjohnwu
- Start date
Magisk (Magic Mask/root) is always installed in a real device's ramdisk... Thus root (superuser permission) exists regardless of any App...
The Magisk App is NOT Magisk (Mask); it's only a UI or 'dashboard' interface for Magisk...
Your issue is apparently not loss of Magisk/root... Only that the App (dashboard) becomes disconnected... Root still exists...
This issue commonly occurs when you have both the stub (hidden) App and the full (original apk package) App installed at the same time... There should only ever be one or the other...
The 'dashboard' displays/controls fail if you have two instances... (Like a car, installing dual controls requires specialised modifications.)
You have said you have the hidden App while your screenshot proved that the full App was also installed... That's why the App can't see or control Magisk/root status or functions...
If you simply uninstall one or other or both Apps and ensure only one is installed, you will see root/Magisk version in App again... Uninstalling Apps will not affect Magisk (the Magic Mask/root) itself, and you don't need to reflash using Odin etc as only the App (UI/'dashboard') is the issue...
Just uninstall stub or full Apps like any regular App and ensure you only have one App (instance) remaining, then check for Magisk/root...
Don't worry about losing configuration, modules etc as these are not stored in App data unlike regular app configurations... They are stored independently of Magisk App at /data/adb...
If you think you have lost root, run a terminal emulator app and type
magisk -c to see current binary version. If Magisk is not installed, no version info will be returned... To check Magisk is running in the background, type magisk -V to see running daemon version code. If Magisk daemon is not running properly no version info will be returned...You can check this whether any Magisk App is installed or not.
I hope this helps clarify the difference between Magisk (Magic Mask/root) installation and Magisk App (UI/'dashboard') installation for you...
Bien à vous, PW
Last edited:
@badabing2003 @pndwal @J.Michael
Now that everyone has explained Magisk root vs. the Manager app.
---
I would like to bump the other half of his question.
- Why would installing/updating a Module cause Magisk to fail for him.
- Why would installing an APK file even affect Magisk let alone cause it to fail.
I can not duplicate this part of the issue.
Any ideas on why this part of the issue would happen?
Cheers
PS.
I update and install modules, apks and even system updates with Magisk hidden (renamed).
Very rarely do I have an issue due to the Magisk app being renamed.
Now that everyone has explained Magisk root vs. the Manager app.
Sorry.
I will always refer to the Magisk app as the Manager because that is what it is.
I have used Xposed and other(s) for too long to not refer to the application that allows you to setup, install modules, configure and control as the Manager.
I will always refer to the Magisk app as the Manager because that is what it is.
I have used Xposed and other(s) for too long to not refer to the application that allows you to setup, install modules, configure and control as the Manager.
---
I would like to bump the other half of his question.
- Why would installing/updating a Module cause Magisk to fail for him.
- Why would installing an APK file even affect Magisk let alone cause it to fail.
I can not duplicate this part of the issue.
Any ideas on why this part of the issue would happen?
Cheers
PS.
I update and install modules, apks and even system updates with Magisk hidden (renamed).
Very rarely do I have an issue due to the Magisk app being renamed.
There is no denying that the Android app formerly known as "Magisk Manager" is a manager. The quibbling comes from John Wu declaring that he no longer wanted the app to be called "Magisk Manager", but rather just "Magisk".@badabing2003 @pndwal @J.Michael
Now that everyone has explained Magisk root vs. the Manager app.
Sorry.I will always refer to the Magisk app as the Manager because that is what it is.I have used Xposed and other(s) for too long to not refer to the application that allows you to setup, install modules, configure and control as the Manager.
---
I would like to bump the other half of his question.
- Why would installing/updating a Module cause Magisk to fail for him.
- Why would installing an APK file even affect Magisk let alone cause it to fail.
I can not duplicate this part of the issue.
Any ideas on why this part of the issue would happen?
Cheers
PS.
I update and install modules, apks and even system updates with Magisk hidden (renamed).
Very rarely do I have an issue due to the Magisk app being renamed.
As for @meric57's disappearing Magisk: He mentioned installing apps, not so much modules. And we are all currently so hung up on him displaying screenshots showing no-Magisk/unhidden-manager vs. Magisk/hidden-manager, I think we are ignoring his claim that the problem is triggered by installing/updating an app.
@J.Michael and @ipdev
To me the problem of why installing an app is triggering the issue is a secondary problem, that I wouldn't look into until I address the primary issue.
Which is:
1- Multiple versions of the manager on the system.
2- Redoing the root patch (this should not be necessary)
Hence I asked to first uninstall all managers, reboot and the install one copy, preferably not hidden (just for testing) and then install an app and see if it triggers the issue. I suspect that it won't, but if it does, at least at that point we know it is not the manger misleading him.
It is also possible that the Magisk root is of a different version than the manager being installed.
Once change at a time to narrow it down, that would be my approach.
Competing installed Magisk manager apps would give the error even before installing a random apk file.
Both the full Magisk app and the hidden (renamed) one would show Magisk as N/A.
I do not think the initial issue is with multiple Magisk apps installed.
Since Magisk (hidden) seems to be working before installing an apk file.
I can see reflashing magisk via Odin might install the full Magisk app.
But, it does not explain why it (full version) shows Magisk actively installed if there is a hidden magisk Manager app still active.
The full version and the hidden (renamed) version should both show Magisk as N/A until you remove one of them.
---
I fully agree with your suggestion about testing without the Magisk app hidden (renamed).
Cheers.
PS.
Just tried to duplicate competing full and hidden Magisk app on my Pixel 7.
Current commits in Magisk seem to now keep this from happening.
I installed the full Magisk app version.
Opened it and it closed and was removed, leaving only my hidden (renamed) version active.
@meric57's screenshots show no Magisk with unhidden manager; Magisk with hidden managerCompeting installed Magisk manager apps would give the error even before installing a random apk file.
Both the full Magisk app and the hidden (renamed) one would show Magisk as N/A.
I do not think the initial issue is with multiple Magisk apps installed.
Since Magisk (hidden) seems to be working before installing an apk file.
I can see reflashing magisk via Odin might install the full Magisk app.
But, it does not explain why it (full version) shows Magisk actively installed if there is a hidden magisk Manager app still active.
The full version and the hidden (renamed) version should both show Magisk as N/A until you remove one of them.
---
I fully agree with your suggestion about testing without the Magisk app hidden (renamed).
Cheers.
PS.
Just tried to duplicate competing full and hidden Magisk app on my Pixel 7.
Current commits in Magisk seem to now keep this from happening.
I installed the full Magisk app version.
Opened it and it closed and was removed, leaving only my hidden (renamed) version active.
I don't remember anyone ever talking about locating the hidden app in the app drawer and using it. I have been assuming that it would show Magisk installed -- the problem was always that the victim didn't realize he had two manager apps, I don't remember anyone saying that with two managers, both managers are disabled, only that the new, unhidden, manager did not communicate with the installed Magisk because the installed Magisk had somehow been co-opted by the manager that is now hidden.
Maybe meaningless details. I do not feel that we have been told what @meric57 did, in exactly what order.
I think John did this:@badabing2003 @pndwal @J.Michael
Now that everyone has explained Magisk root vs. the Manager app.
Sorry.I will always refer to the Magisk app as the Manager because that is what it is.I have used Xposed and other(s) for too long to not refer to the application that allows you to setup, install modules, configure and control as the Manager.
https://topjohnwu.github.io/Magisk/...agisk-manager-is-deadlong-live-the-magisk-app
to clearly distinguish the old Manager which was just that, the Manager component, a "companion app" finishing with version 8.0.7, from the new Magisk app which is actually a complete Magisk package w/ the App (UI) part now necessarily in sync with the Magisk binaries and including "everything it needs within the APK itself, making installation a 100% offline process" incl. zip installers and now stub APK etc and starting wrapped with Magisk itself as version 22.0 (22000)...
Magisk Manager is dead.
Long live the Magisk app!
PWThis may be device or version dependant... I always try this just to guage if the issue has been resolved... On my device the issue is less frequent than a year ago, but both taking Hide the Magisk app and updating with App hidden have still failed several times recently to remove the full App and required manual removal...
Here's an open issue on this; My comments there too:
Hiding and Restoring Magisk App not working properly on Galaxy A8 2018 (Android 9.0)
#6309 opened on Oct 6, 2022 by DarkKnight1995
PW
Last edited:
I did wonder about this too, but am not familiar with how Fox updates / other apps etc might interfere or even restore full app...I would like to bump the other half of his question.
- Why would installing/updating a Module cause Magisk to fail for him.
- Why would installing an APK file even affect Magisk let alone cause it to fail.
I can not duplicate this part of the issue.
Any ideas on why this part of the issue would happen?
However the fact is the member said he had hidden app but first screenshot showed full app was used when Magisk Installed = Non disponible (N/A)...
https://forum.xda-developers.com/t/magisk-general-support-discussion.3432382/post-88094125
After his flashing efforts the hidden app is shown working, so the difference is evidently the simple removal (however it occurred) of the full app and thus the conflict...
As @badabing2003 said:
Yes, but that is evidently the state of things now for whatever reason... And FWIW, once the hidden stub is properly working the full App has necessarily been removed...
So why did he show the full app not working?I do not think the initial issue is with multiple Magisk apps installed.
Since Magisk (hidden) seems to be working before installing an apk file.
Ah... But it didn't... Full App showed Non disponible ... Excusez mon français...
Please say which commit... (This: Fix automatic stub installation seems unrelated)...PS.
Just tried to duplicate competing full and hidden Magisk app on my Pixel 7.
Current commits in Magisk seem to now keep this from happening.
I installed the full Magisk app version.
Opened it and it closed and was removed, leaving only my hidden (renamed) version active.
PW
Last edited:
Hello, my installation I do as explained by JohnWu modify AP with magisk then adb pull then odin.
Then once active start zygisk and installation of the main modules, applications like root checker and others give me active root.
Why for example when I update LSPosed in magisk or an application like Saturday that I installed nitendo DS emulator, when I restart my s10 exynos I find in the first magisk and zigisk not available.
So either it comes from a conflict with magisk installer or magisk is jealous that I install another application with its permission.
if it starts again how to proceed for the reinstallation without going through odin normally I just update firmware when a new security arrives, I read on the thread of the discussions you have to flash the boot.img or recovery.img of the AP patched_magisk with adb or magisk in recovery.
Canyie talks about uninstalling app manager no, for automatic installation
https://github.com/topjohnwu/Magisk/pull/6547
Badading2003 talks about 2 install managers, he talks about magisk and app magisk manager .
unless it speaks that on the internal memory of the Samsung S 10 I have 2 installations of the magisk manager app.
Then once active start zygisk and installation of the main modules, applications like root checker and others give me active root.
Why for example when I update LSPosed in magisk or an application like Saturday that I installed nitendo DS emulator, when I restart my s10 exynos I find in the first magisk and zigisk not available.
So either it comes from a conflict with magisk installer or magisk is jealous that I install another application with its permission.
if it starts again how to proceed for the reinstallation without going through odin normally I just update firmware when a new security arrives, I read on the thread of the discussions you have to flash the boot.img or recovery.img of the AP patched_magisk with adb or magisk in recovery.
Canyie talks about uninstalling app manager no, for automatic installation
https://github.com/topjohnwu/Magisk/pull/6547
Badading2003 talks about 2 install managers, he talks about magisk and app magisk manager .
unless it speaks that on the internal memory of the Samsung S 10 I have 2 installations of the magisk manager app.
Last edited:
Ah... So appearance of full app happens with a reboot...
Could be to do with the broken function (Fix automatic stub installation) the Pull Request you linked is supposed to fix... Not sure...
I just deleted my Magisk App to see if it's restored on reboot (issue comments says it works without Zygisk so I disabled Zygisk to test) and sure enough I get stub installed named "Magisk" on reboot!... However it won't open nor does it ask for additional setup, so can't test further...
It could be that Magisk checks aren't recognising the hidden stub App on your device and Magisk is also installing another stub with full Magisk (I seem to recall this working this way a long while ago) on reboot which then conflicts with existing hidden stub App...
If this continues to occur, I'd try what's been suggested; uninstall every Magisk app (hidden, not hidden), then install full app from GitHub matching Magisk build you have installed again (without rebooting), then take Hide the Magisk app and reboot to see if all is the same and working (ie working hidden stub App still)... If full Magisk appears again after this, please let us know!
PWJust did the same to ensure forced app removal occurs even with same build App installation... It did...PS.
Just tried to duplicate competing full and hidden Magisk app on my Pixel 7.
Current commits in Magisk seem to now keep this from happening.
I installed the full Magisk app version.
Opened it and it closed and was removed, leaving only my hidden (renamed) version active.
So seems we do have forced app removal for App when hidden stub App is present in addition to when signing keys differ or App has a lower version than Magisk daemon...
Man, Magisk Devs are trying hard to protect us from ourselves! (Not sure I need my hand held this much)... Except that when this fails to work as expected we may need protecting from them!
PW
Last edited:
... But regarding this:Just did the same to ensure forced app removal occurs even with same build App installation... It did...
So seems we do have forced app removal for App when hidden stub App is present in addition to when signing keys differ or App has a lower version than Magisk daemon...
Man, Magisk Devs are trying hard to protect us from ourselves! (Not sure I need my hand held this much)... Except that when this fails to work as expected we may need protecting from them!
Just uninstalled hidden App (on latest Canary) again, reinstalled Canary Magisk App, then took Hide the Magisk app, and once again process failed to uninstall full app, asks for superuser permission for Magisk App etc ... As usual, simply ignoring requests and uninstalling the full App restores hidden app functions...This may be device or version dependant... I always try this just to guage if the issue has been resolved... On my device the issue is less frequent than a year ago, but both taking Hide the Magisk app and updating with App hidden have still failed several times recently to remove the full App and required manual removal...
Here's an open issue on this; My comments there too:
Hiding and Restoring Magisk App not working properly on Galaxy A8 2018 (Android 9.0)
#6309 opened on Oct 6, 2022 by DarkKnight1995
PWWhat did you do?
- install Magisk APK
- find boot image
- patch boot image
- use Odin to install patched boot image
- allow Android to update
- find new boot image
When did you make the screenshot showing Magisk: Yes, Package: gibberish?
When you update Android, do you look for a new boot image? Do you
patch the new boot image? Do you install the new patched new boot image?
Samsung compatibility
Fix for Magisk on new A13 LV Samsung (S23 Ultra etc) devices coming soon!
Add init_boot.img patching for Samsung tar firmware packages #6586 opened 6 hours ago by BlackMesa123• Approved
- Ckecks now passed, tested, ready to merge. ... Thanks @BlackMesa123 and @dr.ketan!
PW
Fix for Magisk on new A13 LV Samsung (S23 Ultra etc) devices coming soon!
Add init_boot.img patching for Samsung tar firmware packages #6586 opened 6 hours ago by BlackMesa123• Approved
- Ckecks now passed, tested, ready to merge.
... Thanks @BlackMesa123 and @dr.ketan! PW
As for competing managers.
I was going off of memory from when it used to happen to me every now and then.
Both the regular (not hidden) and hidden (renamed) would show Magisk N/A.
All I had to do was uninstall one of them.
Normally I uninstalled the hidden (renamed) one and rebooted.
Then the regular (not hidden) one would show Magisk installed again. Then I could hide (rename) the manager again.
It was hit or miss if I uninstalled the regular one and rebooted.
Sometimes the hidden one would still show N/A. If so, then I had to uninstall it and reinstall the regular version again.
Then hide (rename) the manager again.
---
I wasted a bit of time tonight trying to get two Magisk manager apps to run currently.
The best I got was an error with Magisk Stable v25.1 on my Pixel 4a.
The initial hiding gave me issues with setting permissions and such.
Once the hidden app was installed, the regular version was removed.
The hidden version showed Magisk installed and active but, would keep throwing errors telling me to restore the Magisk app and hide again.
So I did and no issues the second time around.
Once the hidden app was installed, the regular version was removed.
The hidden version showed Magisk installed and active but, would keep throwing errors telling me to restore the Magisk app and hide again.
So I did and no issues the second time around.
Cheers.
Edit:
@pndwal I did not read your last couple of posts before testing.
When I have time (tomarrow) I will see if I can duplicate it.
Last edited:
Like I said I have been using Manger apps way too long to not refer to them as the Manager.I think John did this:
https://topjohnwu.github.io/Magisk/...agisk-manager-is-deadlong-live-the-magisk-app
to clearly distinguish the old Manager which was just that, the Manager component, a "companion app" finishing with version 8.0.7, from the new Magisk app which is actually a complete Magisk package w/ the App (UI) part now necessarily in sync with the Magisk binaries and including "everything it needs within the APK itself, making installation a 100% offline process" incl. zip installers and now stub APK etc and starting wrapped with Magisk itself as version 22.0 (22000)...
Magisk Manager is dead.
Long live the Magisk app!
Next I will be yelling at kids to keep of my lawn.
Cheers.
Like I said I have been using Manger apps way too long to not refer to them as the Manager.
The combination of app and on-device services (root) could be called Magisk The Gathering.
Last edited:
It's been a long, long time since I've paid attention to how rooting works on a technical level with modern devices.
I have an Android 10 head unit that I'm trying to get a working userspace root solution onto. The bootloader is locked, but I have root via both a wireless ADB shell as well as serial console. I have read/write access to /system. I don't have the ability to unlock the bootloader and flash a patched boot image. Is it possible to get Magisk working?
I have an Android 10 head unit that I'm trying to get a working userspace root solution onto. The bootloader is locked, but I have root via both a wireless ADB shell as well as serial console. I have read/write access to /system. I don't have the ability to unlock the bootloader and flash a patched boot image. Is it possible to get Magisk working?
Similar threads
Top Liked Posts
-
3
It's ok not to be a dev or know Python, you can use the program as a user,
it would extract the boot from the image, transfer it to the phone, create the script based on the chosen file, create the patch and pull it back to your PC, and it is cross platform.
You can inspect the generated script which is bash, and understand what it is doing without necessarily knowing one bit of python.
The program is very verbose so that people can follow what is going on.
Generate a patch using the program, and let's assume this patch is not exactly what is needed and functional, let's call it abad patch
Also generate a patch the manual way that you know works, and let's call this agood patch
Next you would compare the two, the patched boot files can be unpacked and compared.
This can be done on the phone or if you are more comfortable doing it on the PC, you can use the excellent toolkit Android Image Kitchen by @osm0sis
Even a binary diff would give you an idea of the difference.
See further below.
I don't agree with the above generalization, there's always outliers, but in general the community is very helpful, and amazingly patient even with newcomers, what is typically not tolerated is people not putting in the effort to research or even read few posts and expect all the answers to be delivered on a platter.
When a senior member who is well seasoned and knows what he/she is talking about, asks a specific question to be able to offer advise, and it is evaded, it naturally irks the person.
Almost always there is a lot of context in the questioner's mind that is not totally relayed in the post, hence why specific questions are asked and answers expected.
You're not supposed to know, but you find out with exploratory observation, testing, trial and error and of course differential analysis.
For example I didn't know about the KEEPVERITY and KEEPENFORCEENCRYPT flags when I first called boot_patch.sh, and just like you the generated patch was not good and different from a good patch.
I did a binary diff of the two (at the time I didn't even know I could unpack) and noticed those two keywords existing in the good patch, but not mine.
Read up about it, inspected the script, and asked questions to eventually figure out the right options to use to generate an identical patch.
Same with the Magisk32,2
With Magisk Delta Canary 'Direct Install' too. I was thinking mine was one of those rare cases.2
If you're runningboot_patch.shthose are referenced without.so
but if you're callingligmagiskboot.soand others directly then there is no need to rename anything.
Here's an example script generated by PF to create a patch usingboot_patch.shon an unrooted system
Code:#!/system/bin/sh ############################################################################## # PixelFlasher 4.8.1.0 patch script using Magisk Manager 25.2:25200 ############################################################################## ARCH=arm64-v8a cp /data/app/~~wUtBmsEAIr1uaL-H7KirJg==/com.topjohnwu.magisk-Bsw07ODC_tLE4-KThHUD3A==/base.apk /data/local/tmp/pf.zip cd /data/local/tmp rm -rf pf mkdir pf cd pf ../busybox unzip -o ../pf.zip cd assets for FILE in ../lib/$ARCH/lib*.so; do NEWNAME=$(echo $FILE | sed -En 's/.*\/lib(.*)\.so/\1/p') cp $FILE $NEWNAME done cp ../lib/armeabi-v7a/libmagisk32.so magisk32 chmod 755 * export KEEPVERITY=true export KEEPFORCEENCRYPT=true ./magiskboot cleanup ./boot_patch.sh /sdcard/Download/init_boot.img_4d938d3c.img cp -f /data/local/tmp/pf/assets/new-boot.img /sdcard/Download/magisk_patched_4d938d3c.img2
True, it is the case... No need for another reboot since you've already done one since flashing Magisk and Android system setup...
App doesn't need to be installed... Magisk daemon does the config setup... App will only notify you of need for extra setup (just a reboot actually) if it's opened...
Magisk Daemon succeeds in instance above because /data can be written to...
No, sorry...
You may have missed what I put in italics here:
... the important difference is actually that you (re)booted after the system was up... When you installed the Magisk App is immaterial...
In your originally scenario requiring 'additional setup' there was simply no booting with 'system up'... Magisk daemon could not set up configuration on first boot (following factory reset) because /data cannot be written to before the Android Setup is performed (system is preventing this) and you bypassed a reboot using flags...
Simply put, no boot with Magisk installed and Android configured had yet occurred... (Again, the App doesn't enter this equation)...
PW2
no, as in similar approach to determine that I needed to include Magisk32 binary when creating a patchDid this get truncated? PW
It was an answer to this point
Because creating a patch manually using Magisk only matched the output from the boot_patch script when it was included.
Perhaps the exclusions were benign, but I wanted to generate a patch exactly an equivalent of the manual patch. -
11
Not only does it work, but if you take a few extra steps, you can make a 100% clean install of ANY Magisk version or fork without PC or TWRP.. . . found a YT video that explains you can download the APK, rename to .zip, and install it as a module. Hopefully that works
Here's how I do it :-
- Download Magisk version/fork you want to try
- Add .zip to the end of the Magisk apk eg: Magisk.apk becomes Magisk.apk.zip
- Unhide the Magisk app if you have hidden/renamed it
- Turn on aeroplane mode
- Delete /data/adb/Magisk folder and /data/adb/magisk.db file
- In Magisk app, perform Uninstall Magisk - RESTORE IMAGES so you are back on stock boot image
- Install the new Magisk.apk.zip as a module
- Change Magisk.apk.zip back to Magisk.apk
- Uninstall the Magisk app (the apk only NOT Magisk itself)
- Reboot
- Install the new Magisk.apk
- Open it up and check settings and modules and customise to your needs eg: zygisk may need to be re-enabled and deny list reconfigured
- Reboot again and turn off aeroplane mode
You will now be on a new clean install of whatever Magisk you are trying. No loss of root or modules and no need to clear data from play services to re-enable wallet (assuming it worked before and you set everything up properly)
Only thing left to do is grant root to whatever apps need it.11
Magisk canary builds are available on GitHub.
You just have to look at the history.
Canary builds are hosted in the magisk-files repo.
magisk-files (Canary commit history) - [GitHub] - Link
Select the build commit you are looking for.
Select the apk file and "View File".
You can then Download or "View raw".
Since it can not show you the raw file, it will start the download of the file.
Cheers.10Latest Canary (+Debug) Magisk:
Magisk (e5641d5b) (25208)
- Fix release builds
Diffs to v25.2
- [General] New magic mount backend. It supports loading modules into system with overlayfs files injected
- [MagiskPolicy] Fix minor bug in command line argument parsing
- [Zygisk] Prevent crashing daemon in error
- [Zygisk] Rewrite zygote code injection with new loader library approach
- [Zygisk] Release new API version 4
- [App] Make stub patching 100% offline
- [App] Support patching init_boot.img for Samsung ODIN firmware
- [MagiskInit] Support replacing existing *.rc files in overlay.d
- [MagiskInit] Rewrite sepolicy.rules mounting and loading implementation
PW10Thread lightly cleaned!
@S8rooted&tooted and @pndwal
Greetings to you both. As you have both noticed, I have cleaned this thread of some of your recent comments. I will politely ask you both to please refrain from
further OT and argumentative comments, and to please conduct yourselves in accordance with XDA Rule #2.3 for member conduct:
If you wish to argue further, then please do so via PM's, or another platform since XDA is not the place for these types of discussions on the public forums. Please be advised, posts which continue to violate the forum rules will be removed with immediate effect, and posiible sanctions applied to your account should things get too far out of hand, which we certainly do not want.
So please let this be the end of this here and now.
Thank you for your cooperation, and hope you have a pleasant day.
Best regards: Badger508
It is because Magisk can't work properly on some broken custom recoveries, which mount partitions with wrong devices...
Found no way to workaround it other than detecting and warning user to reinstall Magisk manually... -
1091This is the place for general support and discussion regarding "Public Releases", which includes both stable and beta releases.
All information, including troubleshoot guides and notes, are in the Announcement Thread156Hello, I haven't given much support on XDA lately. It can be resulted from
- University started and I have limited free time. In fact, I mostly develop during midnight
- I live in Taiwan, which has large time zone differences between my European/American contributors/testers, which usually forces me to stay up late at night to discuss/test stuffs.
- The new version is about to come, I don't want to spend effort on supporting old releases
New Forum!
As you might have already discovered, Magisk got its own subforum on XDA! Many thanks to all the support you gave me, and much more information/features/support is about to come!
**For developers supporting all the devices that are not using standard Android boot format, feel free to create threads in this section (actually, PLEASE do so) for your favorite devices after v7 is out. As I currently know, Asus devices require signing the boot image before flashing, and is model dependant; Sony devices seems to use ELF kernel that is unpatchable, or some has two ramdisks (inner + outer), both requires different workarounds; LG bootloader locked devices has to manually "BUMP" the boot image after flashing Magisk..... and there may be lots of other crazy boot image formats that haven't come up to my attention yet.
It is impossible for me to support all these non-standard boot images, and I hope the community can collaborate to make Magisk running across all the devices. Overall, community collaboration is what XDA about
The Pixel Phone
Some of you might already know this news, that the next Pixel Phone right around the corner seems like it does not have ramdisk in boot image, which pretty much wrecked Magisk in all ways. However, it pretty much doomed root itself too. Kernel modifications is inevitable IMO, so I'll try to migrate my scripts to C programs that could possibly be included into the kernel itself. Note that I'm not familiar with linux kernel, I'm not even sure if my idea and concept is correct or not. But once the device is available, I think developers will find a way to bypass all the difficulties, and I'll do my best to learn things
Current Progress
In the past month, I've spent quite some time learning SELinux, so that I can avoid using SuperSU's sepolicy patches. Thanks to the helps and tips from @phhusson and @Chainfire, I finally have a much clearer understanding of how SELinux works. The Magisk core parts (the scripts, boot image patches, new features, more supports) are actually done some time ago. What is causing all the delays is the Magisk Manager.
To be completely honest, although I can code in Java without much issues, Magisk Manager is actually my first Android application, I had to reach out for assistance, and fortunately awesome developers like @DVDandroid and @digitalhigh contributed a lot, which makes the current Manager awesome.
After the repo system and module management is mostly done, I was about to do some adjustments and release, but what we really done is decided to add another feature: auto-unroot with per-app settings. I decided to wait for it to be finished, and then do my adjustments. Due to reasons that'll be mentioned later, this feature will likely not be available for the next release (should come in future updates)
Safety Net Disaster
Those who are using Magisk for Safety Net bypass purposes must have known that Google recently updated the detection method of my Systemless Xposed. I still have no idea what Safety Net is detecting, so currently I cannot fix it on my side (also because I'm busy working on the next update). However, suhide developed by @Chainfire is able to hide Xposed and worked fine.
However, only my Systemless Xposed v86.2, which is based on SuperSU's su.d, is supported using that method. v86.2 and v86.5 (latest, Magisk based) have nearly identical binaries, and the only difference is the path where the binaries are stored.
I'm still not sure what's the real issue for it not being supported, I just hope it is not done intentionally.
Conclusion
Due to the fact that my Safety Net bypass is not 100% perfect now, I do not want to spend any more time waiting for auto-unroot to be polished. What I'm doing now is finishing up all the things I'd like to change in Magisk Manager (it has been a while since I last contributed to Manager, my fellow developers are doing all the heavy job), which might take a little more time, after that, packed with tons of information to be announced in Magisk Section, I'll release the long awaited update.
Hope this lengthy post gives you the idea of the whole situation, and again thanks for all your support!!121Ah, some Chainfire bashing, I hope it is not too late for me to exercise additional villainy.
First, let me make clear I have nothing against @topjohnwu, nor against Magisk. Magisk is an interesting project and it certainly displays @topjohnwu ingenuity and persistence. I don't doubt we will see more interesting things from his hands.
-------------------------
What has happened here is not all that dark and complicated, from either end. I returned from holidays, and someone pointed me at Magisk. My first thought: interesting!
Among other things, the thread lists some issues with SuperSU, which in combination with the phrase The developer also requests users to not bug Chainfire with compatibility requests for SuperSU with Magisk from the portal article, raised my left eyebrow by nigh half an inch. The popular systemless xposed mod is apparently now based on it, and apparently it now no longer works with SuperSU, and apparently I'm not supposed to fix that, nor any of the other found issues. I found that a bit weird. So yes, I have told @topjohnwu that I was a bit surprised he was posting about issues with SuperSU without notifying me about them (I can't fix or help fix issues I'm not aware of, after all).
He's also spreading a modified version of the SuperSU package, which is not all that uncommon, nor necessarily a problem. I have not looked into what he modified, I only ran a few quick tests on one of my devices, and found some commonly used commands run as root to be broken. I have informed him of this as well.
It appears the tool of choice for Magisk is phh's Superuser, because of some of the mentioned issues with SuperSU. That's fine by itself, but fixing issues in that superuser by incorporating SuperSU's binaries into it is a somewhat questionable practise. After all, SuperSU is a commercial closed-source package that helps pay for my dinner, and superuser is a direct competitor. I have informed him that I was surprised he did this without asking for permission. I have expressed similar surprise on him spreading a modified version of LiveBoot (which helps pay for a snack now and then).
@topjohnwu has also stated that Magisk's scripts are largely influenced by mine (I have not checked). Scripts based on mine are used all over the place on XDA, some people have crafted amazing things based on them, I have never made an issue of this (otherwise I would have just made them binaries). But yes, I have also stated to him that I don't think it's very nice to base something on one program, and then using that to (almost exclusively) push something directly competing with that program.
tl;dr Towards @topjohnwu, I have:
- expressed surprise he has issues getting Magisk to work with SuperSU, and has chosen not to inform me about those
- expressed surprise he is using SuperSU binaries in a competing superuser without permission
- expressed surprise he is posting a modified LiveBoot without permission
- informed him of issues with the modified SuperSU he has posted
- let him know I thought it wasn't very nice to be applying my scripts to benefit seemingly exclusively that same competing superuser
To be crystal clear:
- I have not asked for an apology
- I have not asked for Magisk to be abandoned, neither the root hiding nor systemless module parts, and certainly not systemless xposed
- I have not made an issue of any of this anywhere, until this post
- I have not even specifically asked for anything to be taken down (though obviously in my opinion the other superuser package mixed with SuperSU's binaries, as well as the LiveBoot package, should go)
- I have not reported this thread to XDA moderators for copyright violations or otherwise
While my conversation with @topjohnwu may not win any awards for being friendly (though it may win some for brevity), I think all things considered my response has been rather mild. To be perfectly honest, until the apology post, I thought this was over with already. I think the apology post was triggered because I haven't replied to his last PM for a while - I was in the zone, it happens.
To emphasize again, I have nothing against @topjohnwu, Magisk, or systemless xposed, and it is certainly not my goal to see any of them go. If it can be made to work together with SuperSU, great.
I get it though: you think of something, you want to see if you can make it work, you finally get it to work, you publish it, it takes off - enthusiasm gets the better of you. Maybe in the rush some mistakes are made. That doesn't mean you have to just drop it and run. None of my stuff would make it past 0.1 if I stopped at the first big mistake
Aside from said being in the zone coding, I usually regret actually responding to these sort of things the day after, which has made me hesitant to reply. Surprise me.76Thread temporarily closed so everyone sees this.
The flood of "SafetyNet isn't working for me either!" posts are not helpful, at all. Please refrain from posting further, it will be looked into. Please do not forget that not passing SafetyNet is 100% NORMAL AND INTENDED when you have an unlocked booloader or running custom firmware. These are workarounds and they will be worked around in turn.
The Flash
Forum Moderator
EDIT: Thread is reopened... I will be cleaning any SafetyNet posts for a while to keep the thread clean for real issues.75Hello everyone!
I am aware that Google has updated Safety Net that makes Magisk itself a no go for Android Pay. In fact, I witnessed the change live while I am developing the new magiskhide, which should hide all Magisk modules and Magisk installed root.
Google is serious about Safety Net now, clearly hunting down all possibility to run Xposed with Safety Net passed. I spend quite some time examining the new security measures last midnight, and fortunately it seems that it is possible to run Magisk and root along with Safety Net if no Xposed is running. I'm glad I removed the old root toggle at the right time lol, that is no longer feasible with the latest detection.
So stay tuned for the next update, it will come with bug fixes, along with the new magiskhide to bypass that Safety Net.
Google, how will a few systemless mods do any harm
New posts
-
-
Question magisk(nfc) module on note 12 pro plus?- Latest: Shanewatson
-