Magisk General Support / Discussion

Search This thread
By:
Advanced…
meric57

meric57

Senior Member
Oct 2, 2017
295
58
Oeutrange
Samsung Galaxy Tab E
Bonjour, j'ai regardé dans les modules fox manager pour voir à quoi sert certain module.
Quelqu'un peut-il m'expliquer à quoi servent ces 4 modules que je vais citer et m'aider un peu avec mon souci de perte de magisk comme expliqué dans mes posts.
Assistant TRWP - gestionnaire de magisk pour le mode de récupération (mm) -SSH pour magisk - protecteur de boucle de démarrage magisk.
Je pense qui doit en avoir un ou plusieurs qui vont m'aider avec mon problème, non
 
Last edited:
NEOVerse!XChara

NEOVerse!XChara

Member
Feb 5, 2023
41
5
pndwal said:
Bit confusing what you did... You extract and patch one boot image only; either boot.img (WITHOUT selecting Recovery mode) or recovery.img with Recovery mode set, NOT both! ... To access rooted system in recovery mode you will always need to boot via recovery with recovery key combo but release all buttons at splash screen to bypass recovery and boot to system with root...

Nb. Recovery mode means Magisk in recovery ramdisk... It has nothing to do with flashing via custom recovery (TWRP etc), and can't be flashed that way in any case...

In your case you can simply ignore Ramdisk = No! This is because Xiaomi bootloaders are (inexplicably) compatible with ramdisk in boot partition despite the OEM not installing one in A-Only legacy SAR devices, and Magisk always installs basic ramdisk where OEM Randisk is missing... (Magisk continues to display Ramdisk = No to indicate No OEM Ramdisk in boot.)

This means you extract and patch your boot.img (Ensure Recovery mode is NOT selected) and flash the resulting image to boot partition.

To fix you device, simply fastboot flash both unpatched boot.img and recovery.img then check device boots/operates normally again.

Next, ensure you have ROM package corresponding exactly to current running OS version and extract boot.img to patch/flash as above... Alternatively, you can install TWRP and make a backup of boot partition, obtain that from Backups and use this image. You may not even need to rename .win extension as .img, but can if you wish...

Please read John's Installation Instruction page carefully also because all necessary information is actually treated there...

Hope this helps... Please report results. 🙂 PW
Click to expand...
Click to collapse
i tried to flash stock boot.img adn TWRP.img but if i flash the TWRP (No Ramdisk) phone just loads in recovery, and i flashed the recovery with the recovery option, then via magisk i have patched boot (didn't flashed it by myself, magisk did)
 
P

pndwal

Senior Member
Jun 23, 2016
5,911
6,512
Sydney
Redmi Note 8
Xiaomi Redmi Note 8 (2021)
NEOVerse!XChara said:
i tried to flash stock boot.img adn TWRP.img but if i flash the TWRP (No Ramdisk) phone just loads in recovery, and i flashed the recovery with the recovery option, then via magisk i have patched boot (didn't flashed it by myself, magisk did)
Click to expand...
Click to collapse
I don't really understand much of this... Is this stuff you've done since my response to you? Or before? 🤔
NEOVerse!XChara said:
i tried to flash stock boot.img adn TWRP.img
Click to expand...
Click to collapse
Sorry, I have no idea what this means... What's 'adn'? 🤔
NEOVerse!XChara said:
but if i flash the TWRP (No Ramdisk) phone just loads in recovery,
Click to expand...
Click to collapse
So are you trying to flash TWRP?... Why?... And what does 'phone just loads in recovery' mean?... 🤔
NEOVerse!XChara said:
and i flashed the recovery with the recovery option,
Click to expand...
Click to collapse
What does 'flashed the recovery with the recovery option' mean?... Flashed TWRP with some option??... Or flashed a patched or stock recovery?... What 'option'?
NEOVerse!XChara said:
then via magisk i have patched boot (didn't flashed it by myself, magisk did)
Click to expand...
Click to collapse
So you mean Direct Install did it?... So you must have had root already. (??)..

Anyway, did you try what I recommended?... Because it doesn't sound like it at all...

If you just do these parts:
pndwal said:
In your case you can simply ignore Ramdisk = No! ...

This means you extract and patch your boot.img (Ensure Recovery mode is NOT selected) and flash the resulting image to boot partition.

To fix you device, simply fastboot flash both unpatched boot.img and recovery.img then check device boots/operates normally again.

Next, ensure you have ROM package corresponding exactly to current running OS version and extract boot.img to patch/flash as above...
Click to expand...
Click to collapse
you'll fix your issues... 🙃 PW
 
Last edited:
  • Like
Reactions: J.Michael
NEOVerse!XChara

NEOVerse!XChara

Member
Feb 5, 2023
41
5
pndwal said:
Sorry, I have no idea what this means... What's 'adn'? 🤔
Click to expand...
Click to collapse
and* typo :|
pndwal said:
So are you trying to flash TWRP?... Why?... And what does 'phone just loads in recovery' mean?... 🤔
Click to expand...
Click to collapse
my phone loading to recovery instead of rom
pndwal said:
What does 'flashed the recovery with the recovery option' mean?... Flashed TWRP with some option??... Or flashed a patched or stock recovery?... What 'option'?
Click to expand...
Click to collapse
in the magisk i patched my "stock" TWRP with enabled "recovery mode"
pndwal said:
So you mean Direct Install did it?... So you must have had root already. (??)..

Anyway, did you try what I recommended?... Because it doesn't sound like it at all... PW
Click to expand...
Click to collapse
i'm having the su perms, but i don't have any connection to internet (i'm making thoose all from notebook)
 
  • Like
Reactions: J.Michael
P

pndwal

Senior Member
Jun 23, 2016
5,911
6,512
Sydney
Redmi Note 8
Xiaomi Redmi Note 8 (2021)
NEOVerse!XChara said:
and* typo :|

my phone loading to recovery instead of rom

in the magisk i patched my "stock" TWRP with enabled "recovery mode"

i'm having the su perms, but i don't have any connection to internet (i'm making thoose all from notebook)
Click to expand...
Click to collapse
I can't really follow what you've done, but seems you've patched and flashed both boot.img and TWRP.img or stock recovery.img...

Restore stock recovery or unpatched twrp for reasons I've given, then, without root, patch stock boot.img only and fastboot flash that...

I repeat, If you just do these parts:
pndwal said:
In your case you can simply ignore Ramdisk = No! ...

This means you extract and patch your boot.img (Ensure Recovery mode is NOT selected) and flash the resulting image to boot partition.

To fix you device, simply fastboot flash both unpatched boot.img and recovery.img then check device boots/operates normally again.

Next, ensure you have ROM package corresponding exactly to current running OS version and extract boot.img to patch/flash as above...
Click to expand...
Click to collapse
you'll fix your issues... 🙃 PW
 
  • Like
Reactions: J.Michael
NEOVerse!XChara

NEOVerse!XChara

Member
Feb 5, 2023
41
5
pndwal said:
I can't really follow what you've done, but seems you've patched and flashed both boot.img and TWRP.img or stock recovery.img...

Restore stock recovery or unpatched twrp for reasons I've given, then, without root, patch stock boot.img only and fastboot flash that...

I repeat, If you just do these parts:
Click to expand...
Click to collapse
as i said when i'm trying to flash stock TWRP (TWRP without ramdisk) my phone can't load to the crDroid
it's just booting into recovery
 
P

pndwal

Senior Member
Jun 23, 2016
5,911
6,512
Sydney
Redmi Note 8
Xiaomi Redmi Note 8 (2021)
NEOVerse!XChara said:
as i said when i'm trying to flash stock TWRP (TWRP without ramdisk) my phone can't load to the crDroid
it's just booting into recovery
Click to expand...
Click to collapse
Ok, forgot you use custom crDroid... so fastboot BOTH TWRP and boot.img from crDroid (both unpatched) and see if system can boot again... Should be no issues now... If there is, try dirty-flashing crDroid ROM again...

Next, patch that same crDroid boot.img in Magisk App with Recovery Mode DE-SELECTED! (Boot mode, not Recovery mode) and flash from TWRP... System should then boot with root... PW
 
  • Like
Reactions: J.Michael
NEOVerse!XChara

NEOVerse!XChara

Member
Feb 5, 2023
41
5
pndwal said:
Ok, forgot you use custom crDroid... so fastboot BOTH TWRP and boot.img from crDroid (both unpatched) and see if system can boot again... Should be no issues now... If there is, try dirty-flashing crDroid ROM again...
Click to expand...
Click to collapse
i have tried all of them, i don't know much about dirty-flashing, say how to do it
pndwal said:
Next, patch that same crDroid boot.img in Magisk App with Recovery Mode DE-SELECTED! (Boot mode, not Recovery mode) and flash from TWRP... System should then boot with root... PW
Click to expand...
Click to collapse
i have patched the boot image like that you said it now, but i didn't got the su perms :(
 
Last edited:
rodken

rodken

Senior Member
Jan 11, 2010
1,546
679
meric57 said:
Hello, I looked in the fox manager modules to see what certain module is for.
Can someone explain to me what these 5 modules that I will mention are for and help me a little with my concern for the loss of magisk as explained in my posts.
TRWP helper- magisk manager for recovery mode(mm)-SSH for magisk- magisk bootloop protector.
I think who must have one or more who will help me with my problem, no
Click to expand...
Click to collapse
The bootloop protector works by disabling certain Magisk modules that may be causing the bootloop, and then re-enabling them one by one to identify the specific module that is causing the problem. Once the problematic module is identified, it can be removed or replaced, and the device should be able to boot normally.

With Magisk Manager for Recovery - if you end up with a bootloop, you can just disable the module from recovery. This app is used in a recovery terminal only (e.g. TWRP), not in Magisk by itself.
 
  • Like
Reactions: ipdev and J.Michael
NEOVerse!XChara

NEOVerse!XChara

Member
Feb 5, 2023
41
5
rodken said:
The bootloop protector works by disabling certain Magisk modules that may be causing the bootloop, and then re-enabling them one by one to identify the specific module that is causing the problem. Once the problematic module is identified, it can be removed or replaced, and the device should be able to boot normally.

With Magisk Manager for Recovery - if you end up with a bootloop, you can just disable the module from recovery. This app is used in a recovery terminal only (e.g. TWRP), not in Magisk by itself.
Click to expand...
Click to collapse
woah, where you know that all?
 
P

pndwal

Senior Member
Jun 23, 2016
5,911
6,512
Sydney
Redmi Note 8
Xiaomi Redmi Note 8 (2021)
rodken said:
The bootloop protector works by disabling certain Magisk modules that may be causing the bootloop, and then re-enabling them one by one to identify the specific module that is causing the problem. Once the problematic module is identified, it can be removed or replaced, and the device should be able to boot normally.
Click to expand...
Click to collapse
IINM, it disables all modules after (and denylist?) after several failed boot attempts (loops) similar to invoking safe mode but automatically/more reliably... Then user needs to enable selectively again...
rodken said:
With Magisk Manager for Recovery - if you end up with a bootloop, you can just disable the module(s) from recovery. This app is used in a recovery terminal only (e.g. TWRP), not in Magisk by itself.
Click to expand...
Click to collapse

👍 PW
 
  • Like
Reactions: ipdev and rodken
rodken

rodken

Senior Member
Jan 11, 2010
1,546
679
pndwal said:
IINM, it disables all modules after (and denylist?) after several failed boot attempts (loops) similar to invoking safe mode but automatically/more reliably... Then user needs to enable selectively again...
Click to expand...
Click to collapse
There is also the SystemUI Bootloop Protector that in theory, fixes SystemUI bootloops by detecting when SystemUI crashes (due to a Magisk module such as Substratum,) and reboots your device into safe mode automatically to disable Magisk so you can correct the faulty module.
 
  • Like
Reactions: ipdev and pndwal
P

pndwal

Senior Member
Jun 23, 2016
5,911
6,512
Sydney
Redmi Note 8
Xiaomi Redmi Note 8 (2021)
NEOVerse!XChara said:
i have tried all of them, i don't know much about dirty-flashing, say how to do it
Click to expand...
Click to collapse
Just means flashing ROM without data wipes / factory reset... Clean flash means at least factory reset wipes, sometimes formatting data / other partitions first...
NEOVerse!XChara said:
i have patched the boot image like that you said it now, but i didn't got the su perms :(
Click to expand...
Click to collapse
Try reflashing ROM dirty... Flash unpatched TWRP if ROM doesn't include recovery partition...

Could be an issue with crDroid ROM but doubtful... Pretty sure patching/flashing boot will work for stock Olive... PW
 
NEOVerse!XChara

NEOVerse!XChara

Member
Feb 5, 2023
41
5
pndwal said:
Just means flashing ROM without data wipes / factory reset... Clean flash means at least factory reset wipes, sometimes formatting data / other partitions first...
Click to expand...
Click to collapse
who
pndwal said:
Try reflashing ROM dirty... Flash unpatched TWRP if ROM doesn't include recovery partition...
Click to expand...
Click to collapse
who x2
pndwal said:
Could be an issue with crDroid ROM but doubtful... Pretty sure patching/flashing boot will work for stock Olive... PW
Click to expand...
Click to collapse
bro, i'm just losed my wifi or i'm a bit (yeah, yeah bit) dumb
 
P

pndwal

Senior Member
Jun 23, 2016
5,911
6,512
Sydney
Redmi Note 8
Xiaomi Redmi Note 8 (2021)
zgfg

zgfg

Senior Member
Oct 10, 2016
8,580
6,298
Xiaomi Mi 11 Lite 5G
meric57 said:
Hello, I looked in the fox manager modules to see what certain module is for.
Can someone explain to me what these 5 modules that I will mention are for and help me a little with my concern for the loss of magisk as explained in my posts.
TRWP helper- magisk manager for recovery mode(mm)-SSH for magisk- magisk bootloop protector.
I think who must have one or more who will help me with my problem, no
Click to expand...
Click to collapse
In the Fox MM, scroll to the given module, click on Description, it will open the GitHub page for that module

Developers usually try to put some helpful description what for the module is and how it works.
If useful description is missing, skip the module
 
  • Like
Reactions: meric57, ipdev and rodken
You must log in or register to reply here.

Similar threads

T
  • Locked
  • Sticky
Magisk - The Magic Mask for Android
Replies
56
Views
6M
T
topjohnwu
T
  • Locked
[CLOSED][BETA][2018.7.19] Magisk v16.7 (1671)
Replies
7K
Views
3M
T
topjohnwu
Heisenberg
[Discussion] PokeMon Go Magisk Discussion Thread
Replies
5K
Views
635K
djkrish5610
djkrish5610
yochananmarqos
  • Sticky
Collection of Magisk Modules v2
Replies
1K
Views
1M
J
jacomail95
Didgeridoohan
[Discussion] Google Pay Magisk Discussion Thread
Replies
3K
Views
522K
varunpilankar
varunpilankar

Top Liked Posts

24 Hours 30 Days All time
  • 2
    martyfender
    martyfender
    I had a suspicion this was going to happen.
    This was posted in the Delta Telegram group:
    I have to say with regret that Magisk Delta is dead... There will no more updates. Thank all for using Magisk Delta along with those days, we have many memories that should never be faded. I will miss you
    Click to expand...
    Click to collapse
    View
    3
    zgfg
    zgfg
    pndwal said:
    Seem to get more invasive (annoying) adds now
    Click to expand...
    Click to collapse
    No ads with AdAway
    View
    1
    zgfg
    zgfg
    Spartacus500 said:
    After today's TB checker app update from Google Play, the app is not working, any solution ?
    Click to expand...
    Click to collapse
    Just updated TB Checker on two my phones (Canary and Delta), I have everything configured as previously (HMA, etc) and it still works for me (passing all, except Strong and Virtual Integrity - hence, all ok for me)
    View
    1
    zgfg
    zgfg
    Spartacus500 said:
    For me, the application does not open at all, as if it detects the zygisk process 🤷
    Click to expand...
    Click to collapse
    DenyList, Magisk Hide module (find the link, etc, among previous posts)
    View
    1
    P
    pndwal
    Spartacus500 said:
    After today's TB checker app update from Google Play, the app is not working, any solution ?
    Click to expand...
    Click to collapse
    After updating opened fine for me but on running Play Integrity Check I got:
    IMG_20230401_203839.jpg

    ... Cleared all app data... Seem to get more invasive (annoying) adds now, plus is this new?:
    IMG_20230401_204553.jpg


    ... Selected Don't Allow and ran Play Integrity Check again... All fine now... (Only strongIntegrity and virtualIntegrity red... All green for Root and Xposed checks.)

    Suggest clearing data as seems updated app may not play nicely with old config data... PW
    View
  • 12
    shoey63
    shoey63
    Fry-kun said:
    . . . found a YT video that explains you can download the APK, rename to .zip, and install it as a module. Hopefully that works 😯
    Click to expand...
    Click to collapse
    Not only does it work, but if you take a few extra steps, you can make a 100% clean install of ANY Magisk version or fork without PC or TWRP.
    Here's how I do it :-

    - Download Magisk version/fork you want to try
    - Add .zip to the end of the Magisk apk eg: Magisk.apk becomes Magisk.apk.zip
    - Unhide the Magisk app if you have hidden/renamed it
    - Turn on aeroplane mode
    - Delete /data/adb/Magisk folder and /data/adb/magisk.db file
    - In Magisk app, perform Uninstall Magisk - RESTORE IMAGES so you are back on stock boot image
    - Install the new Magisk.apk.zip as a module
    - Change Magisk.apk.zip back to Magisk.apk
    - Uninstall the Magisk app (the apk only NOT Magisk itself)
    - Reboot
    - Install the new Magisk.apk
    - Open it up and check settings and modules and customise to your needs eg: zygisk may need to be re-enabled and deny list reconfigured
    - Reboot again and turn off aeroplane mode

    You will now be on a new clean install of whatever Magisk you are trying. No loss of root or modules and no need to clear data from play services to re-enable wallet (assuming it worked before and you set everything up properly)
    Only thing left to do is grant root to whatever apps need it.
    View
    11
    ipdev
    ipdev
    deusfaux said:
    how/where do you get prior canary builds if you're on the latest?
    Click to expand...
    Click to collapse
    Magisk canary builds are available on GitHub.
    You just have to look at the history. 🙃

    Canary builds are hosted in the magisk-files repo.
    magisk-files (Canary commit history) - [GitHub] - Link
    Select the build commit you are looking for.
    Select the apk file and "View File".
    You can then Download or "View raw".
    Since it can not show you the raw file, it will start the download of the file.
    mcanary1.png
    mcanary2.png
    mcanary3.png
    mcanary4.png

    Cheers. :cowboy:
    View
    10
    Badger50
    Badger50
    Thread lightly cleaned!

    @S8rooted&tooted and @pndwal

    Greetings to you both. As you have both noticed, I have cleaned this thread of some of your recent comments. I will politely ask you both to please refrain from
    further OT and argumentative comments, and to please conduct yourselves in accordance with XDA Rule #2.3 for member conduct:

    2.3 Flaming / Lack of respect: XDA is about sharing and this does not involve virtual yelling (flaming) or rudeness. Flaming or posting with a lack of respect is unacceptable. Treat new members in the manner in which you would like to have been treated when you were a new member. When dealing with any member, provide them with guidance, advice and instructions when you can, showing them respect and courtesy. Never post in a demanding, argumentative, disrespectful or self-righteous manner.
    Click to expand...
    Click to collapse

    If you wish to argue further, then please do so via PM's, or another platform since XDA is not the place for these types of discussions on the public forums. Please be advised, posts which continue to violate the forum rules will be removed with immediate effect, and posiible sanctions applied to your account should things get too far out of hand, which we certainly do not want.
    So please let this be the end of this here and now.

    Thank you for your cooperation, and hope you have a pleasant day.

    Best regards: Badger50
    View
    8
    canyie
    canyie
    huskydg said:
    View attachment 5853939
    @osm0sis now they are going to remove custom recovery support 😂
    Click to expand...
    Click to collapse

    It is because Magisk can't work properly on some broken custom recoveries, which mount partitions with wrong devices...
    Found no way to workaround it other than detecting and warning user to reinstall Magisk manually...
    View
    8
    zgfg
    zgfg
    J.Michael said:
    I always find thread search results to be in reverse chronological order. I only use browser. Are you using app?

    Probably easier to just read last five pages -- not all relevant posts will use keyword you chose.
    Click to expand...
    Click to collapse
    Searching tips (again)
    XDA app or browser:

    1) "Search this thread"
    On top,
    do not enter any keyword, it will be ignored at the moment, "Search"

    2) When it shows results for:
    "Search results for: *"
    Click on that star/asterisk/wildcard sign
    and replace the wildcard with your search keyword, like "systemless"

    3) Scroll little bit down and checkmark "Recent"
    (who cares about the posts from 2017).
    "Search"

    Then, you will have results from this thread, most recent on top, for the keyword you asked
    View
  • 1091
    T
    topjohnwu
    This is the place for general support and discussion regarding "Public Releases", which includes both stable and beta releases.
    All information, including troubleshoot guides and notes, are in the Announcement Thread
    View
    156
    T
    topjohnwu
    Hello, I haven't given much support on XDA lately. It can be resulted from
    • University started and I have limited free time. In fact, I mostly develop during midnight
    • I live in Taiwan, which has large time zone differences between my European/American contributors/testers, which usually forces me to stay up late at night to discuss/test stuffs.
    • The new version is about to come, I don't want to spend effort on supporting old releases
    The planned update is delayed again and again, to some point I think I'll shed some light about what has been happening lately, also along with some announcements.

    New Forum!
    As you might have already discovered, Magisk got its own subforum on XDA! Many thanks to all the support you gave me, and much more information/features/support is about to come!
    **For developers supporting all the devices that are not using standard Android boot format, feel free to create threads in this section (actually, PLEASE do so) for your favorite devices after v7 is out. As I currently know, Asus devices require signing the boot image before flashing, and is model dependant; Sony devices seems to use ELF kernel that is unpatchable, or some has two ramdisks (inner + outer), both requires different workarounds; LG bootloader locked devices has to manually "BUMP" the boot image after flashing Magisk..... and there may be lots of other crazy boot image formats that haven't come up to my attention yet.
    It is impossible for me to support all these non-standard boot images, and I hope the community can collaborate to make Magisk running across all the devices. Overall, community collaboration is what XDA about :D

    The Pixel Phone
    Some of you might already know this news, that the next Pixel Phone right around the corner seems like it does not have ramdisk in boot image, which pretty much wrecked Magisk in all ways. However, it pretty much doomed root itself too. Kernel modifications is inevitable IMO, so I'll try to migrate my scripts to C programs that could possibly be included into the kernel itself. Note that I'm not familiar with linux kernel, I'm not even sure if my idea and concept is correct or not. But once the device is available, I think developers will find a way to bypass all the difficulties, and I'll do my best to learn things ;)

    Current Progress
    In the past month, I've spent quite some time learning SELinux, so that I can avoid using SuperSU's sepolicy patches. Thanks to the helps and tips from @phhusson and @Chainfire, I finally have a much clearer understanding of how SELinux works. The Magisk core parts (the scripts, boot image patches, new features, more supports) are actually done some time ago. What is causing all the delays is the Magisk Manager.
    To be completely honest, although I can code in Java without much issues, Magisk Manager is actually my first Android application, I had to reach out for assistance, and fortunately awesome developers like @DVDandroid and @digitalhigh contributed a lot, which makes the current Manager awesome.
    After the repo system and module management is mostly done, I was about to do some adjustments and release, but what we really done is decided to add another feature: auto-unroot with per-app settings. I decided to wait for it to be finished, and then do my adjustments. Due to reasons that'll be mentioned later, this feature will likely not be available for the next release (should come in future updates)

    Safety Net Disaster
    Those who are using Magisk for Safety Net bypass purposes must have known that Google recently updated the detection method of my Systemless Xposed. I still have no idea what Safety Net is detecting, so currently I cannot fix it on my side (also because I'm busy working on the next update). However, suhide developed by @Chainfire is able to hide Xposed and worked fine.
    However, only my Systemless Xposed v86.2, which is based on SuperSU's su.d, is supported using that method. v86.2 and v86.5 (latest, Magisk based) have nearly identical binaries, and the only difference is the path where the binaries are stored.
    I'm still not sure what's the real issue for it not being supported, I just hope it is not done intentionally.

    Conclusion
    Due to the fact that my Safety Net bypass is not 100% perfect now, I do not want to spend any more time waiting for auto-unroot to be polished. What I'm doing now is finishing up all the things I'd like to change in Magisk Manager (it has been a while since I last contributed to Manager, my fellow developers are doing all the heavy job), which might take a little more time, after that, packed with tons of information to be announced in Magisk Section, I'll release the long awaited update.

    Hope this lengthy post gives you the idea of the whole situation, and again thanks for all your support!!
    View
    121
    Chainfire
    Chainfire
    Ah, some Chainfire bashing, I hope it is not too late for me to exercise additional villainy.

    First, let me make clear I have nothing against @topjohnwu, nor against Magisk. Magisk is an interesting project and it certainly displays @topjohnwu ingenuity and persistence. I don't doubt we will see more interesting things from his hands.

    -------------------------

    What has happened here is not all that dark and complicated, from either end. I returned from holidays, and someone pointed me at Magisk. My first thought: interesting!

    Among other things, the thread lists some issues with SuperSU, which in combination with the phrase The developer also requests users to not bug Chainfire with compatibility requests for SuperSU with Magisk from the portal article, raised my left eyebrow by nigh half an inch. The popular systemless xposed mod is apparently now based on it, and apparently it now no longer works with SuperSU, and apparently I'm not supposed to fix that, nor any of the other found issues. I found that a bit weird. So yes, I have told @topjohnwu that I was a bit surprised he was posting about issues with SuperSU without notifying me about them (I can't fix or help fix issues I'm not aware of, after all).

    He's also spreading a modified version of the SuperSU package, which is not all that uncommon, nor necessarily a problem. I have not looked into what he modified, I only ran a few quick tests on one of my devices, and found some commonly used commands run as root to be broken. I have informed him of this as well.

    It appears the tool of choice for Magisk is phh's Superuser, because of some of the mentioned issues with SuperSU. That's fine by itself, but fixing issues in that superuser by incorporating SuperSU's binaries into it is a somewhat questionable practise. After all, SuperSU is a commercial closed-source package that helps pay for my dinner, and superuser is a direct competitor. I have informed him that I was surprised he did this without asking for permission. I have expressed similar surprise on him spreading a modified version of LiveBoot (which helps pay for a snack now and then).
    @topjohnwu has also stated that Magisk's scripts are largely influenced by mine (I have not checked). Scripts based on mine are used all over the place on XDA, some people have crafted amazing things based on them, I have never made an issue of this (otherwise I would have just made them binaries). But yes, I have also stated to him that I don't think it's very nice to base something on one program, and then using that to (almost exclusively) push something directly competing with that program.

    tl;dr Towards @topjohnwu, I have:
    - expressed surprise he has issues getting Magisk to work with SuperSU, and has chosen not to inform me about those
    - expressed surprise he is using SuperSU binaries in a competing superuser without permission
    - expressed surprise he is posting a modified LiveBoot without permission
    - informed him of issues with the modified SuperSU he has posted
    - let him know I thought it wasn't very nice to be applying my scripts to benefit seemingly exclusively that same competing superuser

    To be crystal clear:
    - I have not asked for an apology
    - I have not asked for Magisk to be abandoned, neither the root hiding nor systemless module parts, and certainly not systemless xposed
    - I have not made an issue of any of this anywhere, until this post
    - I have not even specifically asked for anything to be taken down (though obviously in my opinion the other superuser package mixed with SuperSU's binaries, as well as the LiveBoot package, should go)
    - I have not reported this thread to XDA moderators for copyright violations or otherwise

    While my conversation with @topjohnwu may not win any awards for being friendly (though it may win some for brevity), I think all things considered my response has been rather mild. To be perfectly honest, until the apology post, I thought this was over with already. I think the apology post was triggered because I haven't replied to his last PM for a while - I was in the zone, it happens.

    To emphasize again, I have nothing against @topjohnwu, Magisk, or systemless xposed, and it is certainly not my goal to see any of them go. If it can be made to work together with SuperSU, great.

    I get it though: you think of something, you want to see if you can make it work, you finally get it to work, you publish it, it takes off - enthusiasm gets the better of you. Maybe in the rush some mistakes are made. That doesn't mean you have to just drop it and run. None of my stuff would make it past 0.1 if I stopped at the first big mistake :)

    Aside from said being in the zone coding, I usually regret actually responding to these sort of things the day after, which has made me hesitant to reply. Surprise me.
    View
    76
    nathanchance
    nathanchance
    Thread temporarily closed so everyone sees this.

    The flood of "SafetyNet isn't working for me either!" posts are not helpful, at all. Please refrain from posting further, it will be looked into. Please do not forget that not passing SafetyNet is 100% NORMAL AND INTENDED when you have an unlocked booloader or running custom firmware. These are workarounds and they will be worked around in turn.

    The Flash
    Forum Moderator

    EDIT: Thread is reopened... I will be cleaning any SafetyNet posts for a while to keep the thread clean for real issues.
    View
    75
    T
    topjohnwu
    Hello everyone!

    I am aware that Google has updated Safety Net that makes Magisk itself a no go for Android Pay. In fact, I witnessed the change live while I am developing the new magiskhide, which should hide all Magisk modules and Magisk installed root.

    Google is serious about Safety Net now, clearly hunting down all possibility to run Xposed with Safety Net passed. I spend quite some time examining the new security measures last midnight, and fortunately it seems that it is possible to run Magisk and root along with Safety Net if no Xposed is running. I'm glad I removed the old root toggle at the right time lol, that is no longer feasible with the latest detection.

    So stay tuned for the next update, it will come with bug fixes, along with the new magiskhide to bypass that Safety Net.

    Google, how will a few systemless mods do any harm :p:p
    View

New posts