Magisk General Support / Discussion

[m0han]

.... happened after I install the bootloop saver module..... root access gone including all modules. Then I reflashed the magisk. Still the same....

If you have a working TWRP, why don't you just delete that 'bootloop saver' module folder? If that doesn't work just flash the Magisk apk (or renamed zip file), provided you haven't already done that.

I doubt you have a patched file (or can patch one), since you don't have root ATM.

I'm sure the more knowledgeable folks here will advise you better on this.

p.s.: I see they already have.

 

[Fry-kun]

Actually, that's a good known trick, but I hadn't considered it for bypassing inbuilt Magisk downgrade prevention (Magisk daemon now checks App version as well as signing keys and will forcibly uninstall an app with different keys or older version)... I'm adding it mentally!...

The official way to use older or different builds is either to uninstall Magisk (ie. Mask/core, not App) or to install Debug build, both of which will disable version (and signature) checks allowing users to downgrade App etc and then take Direct install to install corresponding binaries (Mask/core)...

PW

#rant
I understand preventing downgrades is usually desirable, but something like this is a lifesaver if you don't have access to a computer temporarily... From past bad experience I tend to delay magisk upgrades for the same reason.. and still have problems

 

[J.Michael]

@podiwadda Is there any chance you used "hide the magisk app" to change the package name and then installed another Magisk app?

See if you have a file "magisk" in one of your bin directories (/bin, /xbin, /sbin, /system/?bin)

 

[podiwadda]

@podiwadda Is there any chance you used "hide the magisk app" to change the package name and then installed another Magisk app?

See if you have a file "magisk" in one of your bin directories (/bin, /xbin, /sbin, /system/?bin)

No I did not. Only the modules. By the way I found its not modules making it that way. When I try to add Google apps to set in deny list. That's what cause the issue.

 

[podiwadda]

If it happened after you installed a particular module, reinstalling or reflashing Magisk will not change/help since Magisk will always again find the problematic module in /data/adb/modules

If you have TWRP, use its Advanced File Explorer, go to that folder

and find there various subfolders,beach one corresponding to one of your modules

Recognize the subfolders by their names (should resemble module names)

Disable problematic module(s) by placing an empty or not file named disable into the particular
/data/adb/modules/<subfolder>
and reboot

Upon rebooting that module will be disabled

If you use the file name remove, that will uninstall/remove given folder

---

Alternatively use Android Safe Mode or adb - go to Magisk GitHub, Documentation, FAQ and read Q1:

Frequently Asked Questions

The Magic Mask for Android

topjohnwu.github.io

Hey I did this . I mean I didn't fully understood this. But I removed everything saying "magisk and "bootloop" then phone restarted and root back as normal . I reflashed just to make sure. Btw I found out that modules not causing the losing root. It caused by setting play store in deny list

 

[J.Michael]

No I did not. Only the modules. By the way I found its not modules making it that way. When I try to add Google apps to set in deny list. That's what cause the issue.

Still not a reasonable sounding problem. I have never heard of adding something to the deny list causing the loss of root. Unless maybe you added 1000 things to the deny list, and the Play Store was one too many.

Will you please check to see if the file "magisk" is still in one of your "bin" directories. Then try running it from a command prompt.
Assuming you're interested enough to recreate your problem.

EDIT: OK, I take it back, I guess if you put the Magisk manager app in the deny list, it will look like Magisk is no longer running.

 

[shoey63]

. . . found a YT video that explains you can download the APK, rename to .zip, and install it as a module. Hopefully that works

Not only does it work, but if you take a few extra steps, you can make a 100% clean install of ANY Magisk version or fork without PC or TWRP.
Here's how I do it :-

- Download Magisk version/fork you want to try
- Add .zip to the end of the Magisk apk eg: Magisk.apk becomes Magisk.apk.zip
- Unhide the Magisk app if you have hidden/renamed it
- Turn on aeroplane mode
- Delete /data/adb/Magisk folder and /data/adb/magisk.db file
- In Magisk app, perform Uninstall Magisk - RESTORE IMAGES so you are back on stock boot image
- Install the new Magisk.apk.zip as a module
- Change Magisk.apk.zip back to Magisk.apk
- Uninstall the Magisk app (the apk only NOT Magisk itself)
- Reboot
- Install the new Magisk.apk
- Open it up and check settings and modules and customise to your needs eg: zygisk may need to be re-enabled and deny list reconfigured
- Reboot again and turn off aeroplane mode

You will now be on a new clean install of whatever Magisk you are trying. No loss of root or modules and no need to clear data from play services to re-enable wallet (assuming it worked before and you set everything up properly)
Only thing left to do is grant root to whatever apps need it.

 

[ctcx]

As part of the "learning" process, I downloaded current Magisk 25.2 apk and manually unzipped it, then compared the included boot_patch.sh with the current one here

Magisk/boot_patch.sh at master · topjohnwu/Magisk

The Magic Mask for Android. Contribute to topjohnwu/Magisk development by creating an account on GitHub.

github.com

and noticed the first one may be few commits behind.
Notably, apk one still lacks PATCHVBMETAFLAG and RECOVERYMODE flags; despite this, when patching with the app it does show a possible option "Patch vbmeta in boot image".

If apk's script lacks that flag, how is it possible that it shows the option in the app?

 

[badabing2003]

@pndwal

Question for you, I'm pretty sure you know the answer to this
I wanted to hand me down my Pixel 6 to my son, he wanted it rooted.
So I did the following.

• Considering that it already had Magisk Canary 25206 installed, I patched the latest stock boot with it.
• Flashed latest factory image with wipe option.
  • To both slots (inconsequential, but mentioning regardless)
  • Didn't reboot to system (used the flag to skip reboot)
  • Flashed the patched boot
  • reboot

The system booted normal, and was prompted with standard Google phone setup.
After the setup, I installed Magisk 25206 canary, matching what was in boot.
Upon launching Magisk, it told me that it needed to setup something, or something along those lines.
Zygisk was not active, and even though it was showing Magisk installed, the Install button was active.

I ignored the message, I figured I have the core and I also have the Manager, why do I need to do anything else.
Changed the settings, to enable Zygisk.
then tried to install a module, which failed with a message that Magisk installation is not complete.

Why did this happen, and what exactly Magisk had to do to be complete?
I proceeded with direct install, reboot
Zygisk was still disabled, then I enabled Zygisk and rebooted.
All was good after that.

Still would like to know what was missing.

Thanks

 

[J.Michael]

As part of the "learning" process, I downloaded current Magisk 25.2 apk and manually unzipped it, then compared the included boot_patch.sh with the current one here

Magisk/boot_patch.sh at master · topjohnwu/Magisk

The Magic Mask for Android. Contribute to topjohnwu/Magisk development by creating an account on GitHub.

github.com

and noticed the first one may be few commits behind.
Notably, apk one still lacks PATCHVBMETAFLAG and RECOVERYMODE flags; despite this, when patching with the app it does show a possible option "Patch vbmeta in boot image".

If apk's script lacks that flag, how is it possible that it shows the option in the app?

What makes you say "apk one still lacks PATCHVBMETAFLAG and RECOVERYMODE flags"?

The implementation of a function in a program is separate from whether the program connects environment variables to the function.

 

[zgfg]

@pndwal

Question for you, I'm pretty sure you know the answer to this
I wanted to hand me down my Pixel 6 to my son, he wanted it rooted.
So I did the following.

• Considering that it already had Magisk Canary 25206 installed, I patched the latest stock boot with it.
• Flashed latest factory image with wipe option.
  • To both slots (inconsequential, but mentioning regardless)
  • Didn't reboot to system (used the flag to skip reboot)
  • Flashed the patched boot
  • reboot

The system booted normal, and was prompted with standard Google phone setup.
After the setup, I installed Magisk 25206 canary, matching what was in boot.
Upon launching Magisk, it told me that it needed to setup something, or something along those lines.
Zygisk was not active, and even though it was showing Magisk installed, the Install button was active.

I ignored the message, I figured I have the core and I also have the Manager, why do I need to do anything else.
Changed the settings, to enable Zygisk.
then tried to install a module, which failed with a message that Magisk installation is not complete.

Why did this happen, and what exactly Magisk had to do to be complete?
I proceeded with direct install, reboot
Zygisk was still disabled, then I enabled Zygisk and rebooted.
All was good after that.

Still would like to know what was missing.

Thanks

This is usual. It shall reboot one time and then you use it

 

[badabing2003]

This is usual. It shall reboot one time and then you use it

Do you know why?
What actually it is doing?
I understand a reboot is needed of you enable or disable zygisk, but i got the prompt before i toggled anything, i got it as soon as i started the app.

 

[ipdev]

Remember this?:

Then you're too old!... So-long Lollipop...


www.twitter.com/topjohnwu/status/1636674099492835328

@canyie would like one more lollipop flavoured Magisk... PW

Too late.
Magisk- [GitHub] - commit

Cheers.

 

[shoey63]

. . .

Still would like to know what was missing.

Whilst you had the necessary ramdisk/boot image changes and the Manager apk installed, /data/adb had not yet had a chance to be populated with the required Magisk files, having just come off a factory reset.
This happens upon the next reboot, and I presume is done by the Magisk manager, once fully installed.

 

[ctcx]

Finally installed Magisk on an ocean (Moto) device with LOS 20.0. With Zygisk active, universal safetynet module, and adding the infamous banking app to deny list, app finally let run instead of complaining "device cannot be trusted, exit".

But there were big problems, which I describe in 2 separate posts.

First, trying "fastboot boot magisk_patched.img" did not work at all.
Fastboot output:
fastboot FAILED (remote: '') # yes, [B]nothing[/B] inside the simple quotes...
Bootloader logs:
incomplete boot image downloaded

I tried with su in PC console, "--set-active=b" just to be sure (albeit it's always slot b, and it already was), different platform-tools versions... NOTHING.

Why is this?

 

[ctcx]

The other problem was with patching boot.img via script.

In order to be able to use boot_patch.sh without root, these links were the ones:

Magisk General Support / Discussion

This is the place for general support and discussion regarding "Public Releases", which includes both stable and beta releases. All information, including troubleshoot guides and notes, are in the Announcement Thread

forum.xda-developers.com

Magisk General Support / Discussion

This is the place for general support and discussion regarding "Public Releases", which includes both stable and beta releases. All information, including troubleshoot guides and notes, are in the Announcement Thread

forum.xda-developers.com

So:
---Downloaded latest Magisk apk from Github
---Unzipped lib/arm64-v8a/{libmagisk64.so,libmagiskboot.so,libmagiskinit.so} and assets/{boot_patch.sh,util_functions.sh}
---Renamed the *.so removing the "lib" and ".so" parts
---Put original boot.img among all these files, and all of them in one single directory
---Pushed all of them to device's /data/local/tmp/tempdir
---Chmod all to 0755, except boot.img, which was 0644
---adb shell "cd /data/local/tmp/tempdir && ./boot_patch.sh boot.img

The patching was successful, but not so the flashing...

As mentioned in the above post, fastboot boot didn't work, so had to just directly fastboot flash boot.

The boot.img patched by Magisk app directly was ok.

The boot.img patched by scripting like described above, did flash, but did not boot. When LOS was trying to boot, it just ran the animated booting logo endlessly (boot loop?).
I hard reset, tried to flash the "good" patched img, or even original one... now fastboot command hanged with no response until hard resetting device...
In another try I got
error: Failed to identify current slot
Rebooted into LOS recovery, it said slot b was active (as always for this device).
Back into bootloader mode. Again ran fastboot --set-active=b. It already was set.
Then suddenly it let me again flash either the Magisk patched img or the original one.

One thing, since the very beginning, when flashing I always got these messages:
<bootoader> logical has-slot: slot_b not found writing boot_b image not signed or corrupted
However in the end everything went ok according to fastboot.

Do you happen to have an idea why I got these shenanigans when trying the "scripted" patching?

 

[J.Michael]

The other problem was with patching boot.img via script.

In order to be able to use boot_patch.sh without root, these links were the ones:

Magisk General Support / Discussion

This is the place for general support and discussion regarding "Public Releases", which includes both stable and beta releases. All information, including troubleshoot guides and notes, are in the Announcement Thread

forum.xda-developers.com

Magisk General Support / Discussion

This is the place for general support and discussion regarding "Public Releases", which includes both stable and beta releases. All information, including troubleshoot guides and notes, are in the Announcement Thread

forum.xda-developers.com

So:
---Downloaded latest Magisk apk from Github
---Unzipped lib/arm64-v8a/{libmagisk64.so,libmagiskboot.so,libmagiskinit.so} and assets/{boot_patch.sh,util_functions.sh}
---Renamed the *.so removing the "lib" and ".so" parts
---Put original boot.img among all these files, and all of them in one single directory
---Pushed all of them to device's /data/local/tmp/tempdir
---Chmod all to 0755, except boot.img, which was 0644
---adb shell "cd /data/local/tmp/tempdir && ./boot_patch.sh boot.img

The patching was successful, but not so the flashing...

As mentioned in the above post, fastboot boot didn't work, so had to just directly fastboot flash boot.

The boot.img patched by Magisk app directly was ok.

The boot.img patched by scripting like described above, did flash, but did not boot. When LOS was trying to boot, it just ran the animated booting logo endlessly (boot loop?).
I hard reset, tried to flash the "good" patched img, or even original one... now fastboot command hanged with no response until hard resetting device...
In another try I got
error: Failed to identify current slot
Rebooted into LOS recovery, it said slot b was active (as always for this device).
Back into bootloader mode. Again ran fastboot --set-active=b. It already was set.
Then suddenly it let me again flash either the Magisk patched img or the original one.

One thing, since the very beginning, when flashing I always got these messages:
<bootoader> logical has-slot: slot_b not found writing boot_b image not signed or corrupted
However in the end everything went ok according to fastboot.

Do you happen to have an idea why I got these shenanigans when trying the "scripted" patching?

What inspired you to remove the "lib" and ".so" parts?

 

[pndwal]

@pndwal

Question for you, I'm pretty sure you know the answer to this
I wanted to hand me down my Pixel 6 to my son, he wanted it rooted.
So I did the following.

• Considering that it already had Magisk Canary 25206 installed, I patched the latest stock boot with it.
• Flashed latest factory image with wipe option.
  • To both slots (inconsequential, but mentioning regardless)
  • Didn't reboot to system (used the flag to skip reboot)
  • Flashed the patched boot
  • reboot

The system booted normal, and was prompted with standard Google phone setup.
After the setup, I installed Magisk 25206 canary, matching what was in boot.
Upon launching Magisk, it told me that it needed to setup something, or something along those lines.
Zygisk was not active, and even though it was showing Magisk installed, the Install button was active.

I ignored the message, I figured I have the core and I also have the Manager, why do I need to do anything else.
Changed the settings, to enable Zygisk.
then tried to install a module, which failed with a message that Magisk installation is not complete.

Why did this happen, and what exactly Magisk had to do to be complete?
I proceeded with direct install, reboot
Zygisk was still disabled, then I enabled Zygisk and rebooted.
All was good after that.

Still would like to know what was missing.

Thanks

"Your device needs additional setup..." message is associated with env_fix, fixenv, EnvFixEvent etc routines in app/src/main/java/com/topjohnwu/magisk/core/tasks/MagiskInstaller.kt and other files...

Seems it may be called for several reasons, but additional setup is generally needed where /data is wiped after Magisk is set up or a /data wipe is associated with an initial Magisk installation... For the reason that flashing CSC Odin binary necessarily wipes /data, this note is included in Installation Instruction for SAR+ Samsung devices:

• Install the Magisk app you’ve already downloaded and launch the app. It should show a dialog asking for additional setup.
• Let the app do its job and automatically reboot the device. Voila!

So the Magisk App simply detects the missing configuration files...

As @shoey63 indicates above this occurs "coming off a factory reset" and it can actually be reproduced simply by removing Magisk folder and .db from /data/adb while booted and opening app again...

Without digging into the code further this indicates to me that the 'Additional Setup' needs no special routines in this case, only a simple reboot to rebuild configuration files which happens automatically if they're missing anyway... Seems we just need two reboots after factory reset / data wipes simply because Magisk cannot build configuration in /data/adb until initial Android Setup is performed.

Since it seems that if you'd simply rebooted and done intial Android setup after

• Flashed latest factory image with wipe option.

Instead of

• Didn't reboot to system (used the flag to skip reboot)

and then

• Flashed the patched boot
• reboot

You would have avoided "Your device needs additional setup..." message.

... Also, regarding this:

I ignored the message, I figured I have the core and I also have the Manager, why do I need to do anything else.
Changed the settings, to enable Zygisk.
then tried to install a module, which failed with a message that Magisk installation is not complete.

it's not clear if you rebooted between enabling Zygisk and installing module... Doing that should have fixed the Magisk environment at that point... PW

 

[pndwal]

Whilst you had the necessary ramdisk/boot image changes and the Manager apk installed, /data/adb had not yet had a chance to be populated with the required Magisk files, having just come off a factory reset.
This happens upon the next reboot, and I presume is done by the Magisk manager, once fully installed.

Actually Magisk daemon does this even if App is not present... The App will (inconsistently) force the reboot however. PW

 

[pndwal]

Too late.
Magisk- [GitHub] - commit

Cheers.

Funny, I put that link with the Twitter link!

... Edits disappear on my device if I swap from XDA page in browser to copy something and forget to refresh when returning... PW