Magisk General Support / Discussion

Search This thread

zgfg

Senior Member
Oct 10, 2016
8,996
6,741
Redmi K20 / Xiaomi Mi 9T
Xiaomi Mi 11 Ultra
With Magisk installed, in order to make banking app work I had to:
enable Zygisk, install universal safetynet fix module, and also enable deny list and add banking app to it (I thought this last one was no longer needed...)

Infamous banking app finally ran and began registration stuff. But the app is unable to scan the needed qr code: the "screen" is just complete black instead of the camera looking for qr code.

Do you think this could be related to Magisk further settings, or is it purely app's fault?

Thanks.

(I read that, supposedly, there were 3rd-party qr code apps which were able to scan the qr code and open it with another installed app, which supposedly could work for cases like this. Do you know something about this?)
I don't understand why you thought that adding banking app to DenyList is not needed - you can read that here in every guide and every answer to sime newbies asking the same every few days (there are really tons of similar posts/answers)

Anyway, don't know if scanning QR code is maybe related to USNF

You could try using Google Lens (available on Playstore)
 
  • Like
Reactions: J.Michael

ctcx

Senior Member
Jan 16, 2013
269
87
Google lens, just like all other apps, cannot "send" scanned code to another app.

Anyway, I think I was asking for too much...
 
  • Like
Reactions: ipdev

J.Michael

Recognized Contributor
Jan 20, 2018
1,830
2,086
Samsung Galaxy Tab A series
With Magisk installed, in order to make banking app work I had to:
enable Zygisk, install universal safetynet fix module, and also enable deny list and add banking app to it (I thought this last one was no longer needed...)

Infamous banking app finally ran and began registration stuff. But the app is unable to scan the needed qr code: the "screen" is just complete black instead of the camera looking for qr code.

Do you think this could be related to Magisk further settings, or is it purely app's fault?

Thanks.

(I read that, supposedly, there were 3rd-party qr code apps which were able to scan the qr code and open it with another installed app, which supposedly could work for cases like this. Do you know something about this?)
When you try to scan a QR code, and you get a black screen:

Can you tell whether you are using the front camera or the back camera?

Do you have a case that covers the back camera?
 

dd805bb

Senior Member
Sep 18, 2017
455
260
Google Pixel
Google Pixel XL
The Motorola lineageOS guy. All wrong. Do not follow the XDA article and find lineageOS magisk install thread. Sounds like you are patching the wrong .img like the XDA article says. lineageOS you patch the recovery.img they provide for official ones. It's the same process through the app of select file and patch. If you got lineageOS up and running then patching the recovery.img is simple. The article about pulling the boot.img is wrong. lineageOS you don't ever do that. I have a pixel 3 xl and pixel xl both running lineageOS with Magisk. The problems you are experiencing sound like mount points are wrong from installing Magisk wrong. That procedure they have up in their article pertains to using stock procedures of getting a boot.img on a custom ROM. Whoever wrote that is way off.

This here would be closer to what to do for lineageOS. And none of this is really Magisk related. All this can be found in Motorola threads and or lineageOS threads.

 
  • Like
Reactions: J.Michael

dd805bb

Senior Member
Sep 18, 2017
455
260
Google Pixel
Google Pixel XL
This is correct.

This is not. PW
This is the Magsik Alpha. The links on this page link to Magisk Debug latest version. The code hasn't been updated but the links and where they are the same as canary/debug official build. Did you check anything?
Screenshot_20230321-123133.png
 

pndwal

Senior Member

dd805bb

Senior Member
Sep 18, 2017
455
260
Google Pixel
Google Pixel XL
That's not a vv repo... That's an outdated copy by some other dev... PW
And right over your head.. lol. Whoever forked that has now linked to official GitHub Magisk for downloading. The actions, releases and everything has been wiped out and diverted via link to Magisk Debug/canary/beta/official releases. I didn't say it is a copy repo. I said above, which you failed to read, the links go to the official so there basically is no Alpha Magisk. You may download from there but is the official links on that GitHub. Which screenshot shows the Magsik debug app off of there. So it is the same.

Look at the owner of this repo.. says who again??
 
Last edited:
  • Angry
Reactions: zgfg

zgfg

Senior Member
Oct 10, 2016
8,996
6,741
Redmi K20 / Xiaomi Mi 9T
Xiaomi Mi 11 Ultra
And right over your head.. lol. Whoever forked that has now linked to official GitHub Magisk for downloading. The actions, releases and everything has been wiped out and diverted via link to Magisk Debug/canary/beta/official releases. I didn't say it is a copy repo. I said above, which you failed to read, the links go to the official so there basically is no Alpha Magisk. You may download from there but is the official links on that GitHub. Which screenshot shows the Magsik debug app off of there. So it is the same.

Look at the owner of this repo.. says who again??
This is not official Magisk Alpha. To download Magisk Alpha, developped by Magisk Alpha developers, use the Telegram (Alpha is currently closed source and you cannot look at the source files on GitHub)

When we talk here about Magisk Alpha, we refer to the 'real' Alpha from the Telegram group maintained by the Chinese Alpha developers

They have also another, closed TG channel for discussion (invitation link is no more publicly available and discussion is exclusively in Chinese)

As you can see on the screenshot, Alpha 25209 and 25210 hex tags are completely different tags than yours/Magisk Canary tags
 

Attachments

  • Screenshot_2023-03-21-21-13-12-562_org.telegram.messenger.jpg
    Screenshot_2023-03-21-21-13-12-562_org.telegram.messenger.jpg
    756.6 KB · Views: 32
  • Like
Reactions: J.Michael and ipdev

zgfg

Senior Member
Oct 10, 2016
8,996
6,741
Redmi K20 / Xiaomi Mi 9T
Xiaomi Mi 11 Ultra
Also there is another Alpha, which is exactly the same too.. The other one just syncs when a canary build is pushed. Hence 100 and something commits behind. So both lead to the same Canary Build 25210.
OMG - it's not worth to waste time on this 'discussion'

Look at the attached screenshot and learn what is the package name for Magisk Alpha:
io.github.vvb2060.magisk

And the latest 25210 Alpha version is.(again different from your Magisk Canary 25210:
d52ea1b0-alpha(25210)

See the post #54950 above, look at the screenshot from Telegram, open that Telegram channel (I cannot put the link to TG here, it would be against the XDA rules) and download the official Magisk Alpha from there

And see also a dedicated Magisk Aloha thread on XDA:
 

Attachments

  • Screenshot_2023-03-21-21-33-07-814_io.github.vvb2060.magisk-edit.jpg
    Screenshot_2023-03-21-21-33-07-814_io.github.vvb2060.magisk-edit.jpg
    99.9 KB · Views: 30
Last edited:
  • Like
Reactions: ipdev

pndwal

Senior Member
And right over your head.. lol. Whoever forked that has now linked to official GitHub Magisk for downloading. The actions, releases and everything has been wiped out and diverted via link to Magisk Debug/canary/beta/official releases. I didn't say it is a copy repo. I said above, which you failed to read, the links go to the official so there basically is no Alpha Magisk. You may download from there but is the official links on that GitHub. Which screenshot shows the Magsik debug app off of there. So it is the same.

Look at the owner of this repo.. says who again??

There are official links, but as @huskydg and others have said, no open source seems to be publicly available now...

You can LOL, "LMFAO" or whatever else you do, but that repo owner is not vvb2060... She links latest source as in a LSPosed repo that seems inaccessible to public:

As you say yourself, you links are way behind current Magisk ... vv's GitHub is up to date with JSONs here:
https://github.com/vvb2060/magisk_files/commits/alpha

Sure, she's left JSON pointing to official Canary notes recently (it used to point to her Chinese changelog), but Alpha itself doesn't use Canary channel; only Alpha and Custom are available in app...

👀 PW
 

dd805bb

Senior Member
Sep 18, 2017
455
260
Google Pixel
Google Pixel XL
OMG - it's not worth to waste time on this 'discussion'

Don't you know that Magisk Alpha installs with the different package name:
io.github.vvb2060.magisk

See the post #54950 above, look at the screenshot from Telegram, open that Telegram channel (I cannot put the link to TG here, it would be against the XDA rules) and download the official Magisk Alpha from there

And see also a dedicated Magisk Aloha thread on XDA:
[URL https://forum.xda-developers.com/t/discussion-magisk-alpha-public-released-fork-vvb2060.4424845
I am going to say ok now to whatever. If you can't access it on GitHub... NVM. Not worth it. Follow the XDA links you posted.. 2 weeks behind via GitHub commits. Which I can see. The shared APK screenshot you posted is from a group not a GitHub project. I would be able to see it. The link actually links to nothing/ 404 not found. Those shared apks are not updated alphas but say they have injection in them. Translate before installing. Because it's shared in a telegram group doesn't mean that it came from a legit source. Know what else happened 2 weeks ago? Alpha on GitHub hasn't updated. Hmm. Coincidental I guess. Alpha XDA to that telegram is way different. No way would I ever grab an APK that can gain root and say it has injection over the official, and don't know them. Wow that ballsy.

Screenshot_20230321-134712.png
 

zgfg

Senior Member
Oct 10, 2016
8,996
6,741
Redmi K20 / Xiaomi Mi 9T
Xiaomi Mi 11 Ultra
I am going to say ok now to whatever. If you can't access it on GitHub... NVM. Not worth it. Follow the XDA links you posted.. 2 weeks behind via GitHub commits. Which I can see. The shared APK screenshot you posted is from a group not a GitHub project. I would be able to see it. The link actually links to nothing/ 404 not found. Those shared apks are not updated alphas but say they have injection in them. Translate before installing. Because it's shared in a telegram group doesn't mean that it came from a legit source.

View attachment 5868853
As said, Alpha is no more open source

That's the reason why many users here (incl. myself), stopped using Alpha.
Actually, the other reason is that the only support is their closed TG channel only in Chinese (English forbidden)

But once again, MAGISK ALPHA IS A FORK and hence DIFFERENT FROM THE OFFICIAL MAGISK
 

dd805bb

Senior Member
Sep 18, 2017
455
260
Google Pixel
Google Pixel XL
Wrong again...


And just because public can't see code on GitHub (ie not public repo) doesn't mean it's not. GitHub project... Also, the TG channel is vv's! So don't know why you think source may not be legit... 🙄 PW
Read above. Not even going there. Another member explained why it's not legit. The TG channel, IDK. Closed source. I am going to leave it there. You say a lot of things that don't make sense. Grabbing an APK you can't verify is, well not legit. From what I translated, I wouldn't ever install an APK off there. That is ballsy.
 

dd805bb

Senior Member
Sep 18, 2017
455
260
Google Pixel
Google Pixel XL
Post in thread '[Discussion] Magisk Alpha (Public Released) fork - @vvb2060' https://forum.xda-developers.com/t/...c-released-fork-vvb2060.4424845/post-88296465

So what I originally said is still true. The GitHub Alpha repos all point to official Magisk now. They didn't a week ago before being wiped. I never brought up TG and don't care what is said in a closed Chinese forum nor given out in those groups. I went off links on XDA and what is found on GitHub. The Alpha repos on GitHub now point to Magisk due to it being closed source now. Only real Alpha now is on TG.. The alphas before a week ago were available GitHub but not anymore. You 2 act like this has been this way forever when it literally just changed within the past week. Playing 🥴 and being 🥴 are 2 different things. Just saying. Great way to show both.
 
Last edited:

zgfg

Senior Member
Oct 10, 2016
8,996
6,741
Redmi K20 / Xiaomi Mi 9T
Xiaomi Mi 11 Ultra
Post in thread '[Discussion] Magisk Alpha (Public Released) fork - @vvb2060' https://forum.xda-developers.com/t/...c-released-fork-vvb2060.4424845/post-88296465
Yes. But this is exactly what we were telling you (since we well knew about that thread and post) but you kept arguing that we don't know and that we are wrong:

1) Alpha TG channel is legit, meaning that the channel was opened by the lead developer of the Magisk Alpha group, you see her (yes, she) posts there and the apps you would download there are their legit Alpha releases

2) They do have GitGub repo but it is not open for the public

3) Again, Alpha is a fork and hence different from the official Canary.
Eg Alpha 25210 or 25209 are different from Canary 25210 or 25209 (you 'argued' in two insisting exactly on the opposite, wrong statements) - Alpha has different package name and their version tags are different

Hopefully you sorted out now and we don't need to continue😁
 
  • Like
Reactions: ipdev and pndwal

Top Liked Posts

  • 2
    Oh, maybe? The only one I re-installed was the Magisk built-in BusyBox since it said an update was available. The others were a simple enable.

    This had to be it, 1.0.5 made my device bootloop but once 1.0.6 was released all went back to normal.

    In fact, the changelog for 1.0.6 states that the release was to fix bootlooping devices

    My detective work is done, case solved
    1
    So due to random encryption keys there is no hope of recovering anything?
    Wish I knew before.
    What I need to know is can root be done without this problem?
    A lot of what I've lost could be on my previous note 9 too (deleted obviously after factory reset) but I don't want to be stuck in the same situation.

    This is true. Never used to be the case. I've had this issue in the past before the whole bootloader unlocking thing and a factory data reset when flashing new software still enabled you to recover deleted files.
    Still never learnt my lesson. I never backup because I usually have way more than the standard 15gb to backup. I should really start regularly backing up files and photos, videos etc to my laptop really to prevent this issue in future.
    It has nothing to do with root - if by root you mean installing Magisk

    It has with unlocking Bootloader - that triggers factory reset

    And if you decide to switch to a custom ROM, and later to another custom ROM, every time you will also have to factory reset (when switching from one custom ROM to another, not when upgrading the same custom ROM - but again, that is not rooting, it has nothing to do with Magisk)

    For all that you must have your Bootloader unlocked, but you unlock Bootloader only once, and later you may thousand times install and uninstall Magisk (that's really the rooting and un-rooting), but installing/uninstalling Magisk will not affect your data

    IDK how is all that for Samsung but eg for Xiaomi, user is clearly warned that unlocking BL will immediately factory reset his Internal memory before he initiates the process. And he is warned once again the last moment right before pushing the 'red button'

    And on all forums, guides, everywhere there are warnings bout

    Hence if somebody still ignores all that, he clearly did not do his homework. And unfortunately, that's not really a topic for this Magisk thread (afaik, even the official Magisk Installation guide on GitHub describes that a precondition for installing a Magisk is the unlocked Bootloader. And that before unlocking BL, one has to backup the data he wants to save)
    1
    It has nothing to do with root - if by root you mean installing Magisk

    It has with unlocking Bootloader - that does factory reset

    And if you decide to switch to a custom ROM, and later to another custom ROM, , every time you will also have to factory reset (when switching from one custom ROM to another, not when upgrading the same custom ROM - but again, that is not rooting, it has nothing to do with Magisk)

    For all that you must have your Bootloader unlocked, but you unlock Bootloader only once, and after that you may thousand times install and uninstall Magisk (that's the rooting and unrooting), and installing/uninstalling Magisk will not affect your data

    IDK how is all that for Samsung but eg for Xiaomi, user is clearly warned that unlocking BL will immediately factory reset his Internal memory. And he is warned once again the last moment right before pushing the 'red button'

    And on all forums, guides, everywhere there are warnings bout

    Hence if somebody still ignores all that, he clearly did not do his homework. And unfortunately, that's not really a topic for Magisk (afaik, even the official Magisk Installation guide on GitHub describes that a precondition for installing a Magisk is to have the unlocked Bootloader. And that before unlocking BL, one has to backup his data)
    Sorry don't think I'm complaining at magisk for this because I'm not. What I am saying is that in the past when rooting etc, before bootloader unlocking was a thing factory reset never wiped all the data completely. Files were still recoverable. That's where I guess i was a bit naive, because I haven't rooted phones for a long long time I didn't realise that a factory reset now actually does completely destroy all data making nothing recoverable.
    Apologies if my last reply came across the wrong way.
    This is just something I was not expecting as when i last played with this sort of stuff a factory reset wasn't as in depth as it clearly is now
    1
    This thing is so confusing, it's my first time using it and I'm finding it super complicated

    I already have Lineage OS 20 installed on my Pixel 2 Walleye with unlocked bootloader

    These installation instructions are atrocious. Why is this all so complicated and confusing?
    Are you referring to official GitHub Instruction page?

    Generally that's sufficient and frankly covers the essentials in a logical and concise fashion.
    I don't understand what I'm supposed to do. The Magisk APK is installed but what's with this patching stuff ?
    Start at the top of that page...

    Please ask here with specific points you want clarification on; We don't want to rehash general instructions here, but you should understand that the App is simply the Magisk package until you a) install it which gives you only the UI used to configure Magisk, patch boot images etc, and b) install Magisk itself by flashing the boot image patched to install magiskinit and binaries in ramdisk... 👍 PW
  • 8
    So as well as making it easier to keep root with an ota we can have the same firmware on the device one rooted and one not? So if magisk hide/safetynet/etc aren't working we can boot to the non rooted firmware to use wallet/banking apps etc and then boot back to rooted. Or is it a bit more complicated than that? Never had a pixel device before
    Others have already addressed your question, but for me, the biggest benefit here is to have a safety valve in place where your inactive slot is bootable (without first having to flash the firmware) in case you get into a hairy situation where your active slot becomes unbootable for whatever reason. May be useful in some situations.
    8
    Hello!
    How do you know?
    You must be an expert or something

    Nigerian-Meme.jpg 😜 PW
    7
    Yeah, if I want to run a custom kernel (Pixel 7) then I need to wipe. Should have sideloaded (not booted up), then gone into bootloader and run fastboot flash vbmeta --disable-verity --disable-verification vbmeta.img to that slot. Once booted after sideload/flashing the firmware it's too late as it's enabled after booting. Don't think it matters if you do it before or after flashing the patched image, just as long as you do it before you boot up. Oh well, lol...

    Nothing to do with what we were testing, just custom kernel related. Seems to also help to avoid getting the red eio corrupt message when things may not go as expected.
    Thanks, I realize it is only needed for custom Kernel cases.
    I should add extracting vbmeta from payload.bin then in addition to boot.img / init_boot.img so that the step can be performed if the options are selected.
    7
    Hello together
    If I tick some apps in the denylist and leave magisk app, some apps untick it themself: Android Auto, Cell Broadcast Service, Google Services Framework, Networkmanager and Tethering. If you wondering why I hide this apps, I just hide all Apps from google. Are there any limitation of hide apps in the list?
    You are not supposed to "hide all apps", you are generally advised to hide as few apps as possible; hide an app only when necessary.

    I don't know whether "hide all apps from google" means "hide from Google all apps" or "hide any app you think was produced by Google", but both are bad ideas.

    In particular, hiding some Google processes can cripple Android.

    There have been posts about USNF or Shamiko (not necessarily both, I just don't remember the details) removing some Google process from the deny list because it (the module, USNF or Shamiko) handled that process specially. I do not remember reading about those other processes you say are getting unticked.
    6
    You guys still aren't using ASH_STANDALONE=1 which forces busybox to use its own applets above what's in the path. Either export it or specify it as a command prefix. It has to be Magisk's busybox or my SELinux busybox to have the patch required for standalone mode.

    export ASH_STANDALONE=1
    /data/adb/magisk/busybox ash /data/local/tmp/test2.sh

    or

    ASH_STANDALONE=1 /data/adb/magisk/busybox ash /data/local/tmp/test2.sh

    P.S. `` (backticks) are just a lazy way to suggest a code/command block since that's what they are when used in markdown, plus if copied whole directly to a shell it just dumps it into a subshell, like $() does, and unlike "".
  • 1094
    This is the place for general support and discussion regarding "Public Releases", which includes both stable and beta releases.
    All information, including troubleshoot guides and notes, are in the Announcement Thread
    156
    Hello, I haven't given much support on XDA lately. It can be resulted from
    • University started and I have limited free time. In fact, I mostly develop during midnight
    • I live in Taiwan, which has large time zone differences between my European/American contributors/testers, which usually forces me to stay up late at night to discuss/test stuffs.
    • The new version is about to come, I don't want to spend effort on supporting old releases
    The planned update is delayed again and again, to some point I think I'll shed some light about what has been happening lately, also along with some announcements.

    New Forum!
    As you might have already discovered, Magisk got its own subforum on XDA! Many thanks to all the support you gave me, and much more information/features/support is about to come!
    **For developers supporting all the devices that are not using standard Android boot format, feel free to create threads in this section (actually, PLEASE do so) for your favorite devices after v7 is out. As I currently know, Asus devices require signing the boot image before flashing, and is model dependant; Sony devices seems to use ELF kernel that is unpatchable, or some has two ramdisks (inner + outer), both requires different workarounds; LG bootloader locked devices has to manually "BUMP" the boot image after flashing Magisk..... and there may be lots of other crazy boot image formats that haven't come up to my attention yet.
    It is impossible for me to support all these non-standard boot images, and I hope the community can collaborate to make Magisk running across all the devices. Overall, community collaboration is what XDA about :D

    The Pixel Phone
    Some of you might already know this news, that the next Pixel Phone right around the corner seems like it does not have ramdisk in boot image, which pretty much wrecked Magisk in all ways. However, it pretty much doomed root itself too. Kernel modifications is inevitable IMO, so I'll try to migrate my scripts to C programs that could possibly be included into the kernel itself. Note that I'm not familiar with linux kernel, I'm not even sure if my idea and concept is correct or not. But once the device is available, I think developers will find a way to bypass all the difficulties, and I'll do my best to learn things ;)

    Current Progress
    In the past month, I've spent quite some time learning SELinux, so that I can avoid using SuperSU's sepolicy patches. Thanks to the helps and tips from @phhusson and @Chainfire, I finally have a much clearer understanding of how SELinux works. The Magisk core parts (the scripts, boot image patches, new features, more supports) are actually done some time ago. What is causing all the delays is the Magisk Manager.
    To be completely honest, although I can code in Java without much issues, Magisk Manager is actually my first Android application, I had to reach out for assistance, and fortunately awesome developers like @DVDandroid and @digitalhigh contributed a lot, which makes the current Manager awesome.
    After the repo system and module management is mostly done, I was about to do some adjustments and release, but what we really done is decided to add another feature: auto-unroot with per-app settings. I decided to wait for it to be finished, and then do my adjustments. Due to reasons that'll be mentioned later, this feature will likely not be available for the next release (should come in future updates)

    Safety Net Disaster
    Those who are using Magisk for Safety Net bypass purposes must have known that Google recently updated the detection method of my Systemless Xposed. I still have no idea what Safety Net is detecting, so currently I cannot fix it on my side (also because I'm busy working on the next update). However, suhide developed by @Chainfire is able to hide Xposed and worked fine.
    However, only my Systemless Xposed v86.2, which is based on SuperSU's su.d, is supported using that method. v86.2 and v86.5 (latest, Magisk based) have nearly identical binaries, and the only difference is the path where the binaries are stored.
    I'm still not sure what's the real issue for it not being supported, I just hope it is not done intentionally.

    Conclusion
    Due to the fact that my Safety Net bypass is not 100% perfect now, I do not want to spend any more time waiting for auto-unroot to be polished. What I'm doing now is finishing up all the things I'd like to change in Magisk Manager (it has been a while since I last contributed to Manager, my fellow developers are doing all the heavy job), which might take a little more time, after that, packed with tons of information to be announced in Magisk Section, I'll release the long awaited update.

    Hope this lengthy post gives you the idea of the whole situation, and again thanks for all your support!!
    121
    Ah, some Chainfire bashing, I hope it is not too late for me to exercise additional villainy.

    First, let me make clear I have nothing against @topjohnwu, nor against Magisk. Magisk is an interesting project and it certainly displays @topjohnwu ingenuity and persistence. I don't doubt we will see more interesting things from his hands.

    -------------------------

    What has happened here is not all that dark and complicated, from either end. I returned from holidays, and someone pointed me at Magisk. My first thought: interesting!

    Among other things, the thread lists some issues with SuperSU, which in combination with the phrase The developer also requests users to not bug Chainfire with compatibility requests for SuperSU with Magisk from the portal article, raised my left eyebrow by nigh half an inch. The popular systemless xposed mod is apparently now based on it, and apparently it now no longer works with SuperSU, and apparently I'm not supposed to fix that, nor any of the other found issues. I found that a bit weird. So yes, I have told @topjohnwu that I was a bit surprised he was posting about issues with SuperSU without notifying me about them (I can't fix or help fix issues I'm not aware of, after all).

    He's also spreading a modified version of the SuperSU package, which is not all that uncommon, nor necessarily a problem. I have not looked into what he modified, I only ran a few quick tests on one of my devices, and found some commonly used commands run as root to be broken. I have informed him of this as well.

    It appears the tool of choice for Magisk is phh's Superuser, because of some of the mentioned issues with SuperSU. That's fine by itself, but fixing issues in that superuser by incorporating SuperSU's binaries into it is a somewhat questionable practise. After all, SuperSU is a commercial closed-source package that helps pay for my dinner, and superuser is a direct competitor. I have informed him that I was surprised he did this without asking for permission. I have expressed similar surprise on him spreading a modified version of LiveBoot (which helps pay for a snack now and then).
    @topjohnwu has also stated that Magisk's scripts are largely influenced by mine (I have not checked). Scripts based on mine are used all over the place on XDA, some people have crafted amazing things based on them, I have never made an issue of this (otherwise I would have just made them binaries). But yes, I have also stated to him that I don't think it's very nice to base something on one program, and then using that to (almost exclusively) push something directly competing with that program.

    tl;dr Towards @topjohnwu, I have:
    - expressed surprise he has issues getting Magisk to work with SuperSU, and has chosen not to inform me about those
    - expressed surprise he is using SuperSU binaries in a competing superuser without permission
    - expressed surprise he is posting a modified LiveBoot without permission
    - informed him of issues with the modified SuperSU he has posted
    - let him know I thought it wasn't very nice to be applying my scripts to benefit seemingly exclusively that same competing superuser

    To be crystal clear:
    - I have not asked for an apology
    - I have not asked for Magisk to be abandoned, neither the root hiding nor systemless module parts, and certainly not systemless xposed
    - I have not made an issue of any of this anywhere, until this post
    - I have not even specifically asked for anything to be taken down (though obviously in my opinion the other superuser package mixed with SuperSU's binaries, as well as the LiveBoot package, should go)
    - I have not reported this thread to XDA moderators for copyright violations or otherwise

    While my conversation with @topjohnwu may not win any awards for being friendly (though it may win some for brevity), I think all things considered my response has been rather mild. To be perfectly honest, until the apology post, I thought this was over with already. I think the apology post was triggered because I haven't replied to his last PM for a while - I was in the zone, it happens.

    To emphasize again, I have nothing against @topjohnwu, Magisk, or systemless xposed, and it is certainly not my goal to see any of them go. If it can be made to work together with SuperSU, great.

    I get it though: you think of something, you want to see if you can make it work, you finally get it to work, you publish it, it takes off - enthusiasm gets the better of you. Maybe in the rush some mistakes are made. That doesn't mean you have to just drop it and run. None of my stuff would make it past 0.1 if I stopped at the first big mistake :)

    Aside from said being in the zone coding, I usually regret actually responding to these sort of things the day after, which has made me hesitant to reply. Surprise me.
    76
    Thread temporarily closed so everyone sees this.

    The flood of "SafetyNet isn't working for me either!" posts are not helpful, at all. Please refrain from posting further, it will be looked into. Please do not forget that not passing SafetyNet is 100% NORMAL AND INTENDED when you have an unlocked booloader or running custom firmware. These are workarounds and they will be worked around in turn.

    The Flash
    Forum Moderator

    EDIT: Thread is reopened... I will be cleaning any SafetyNet posts for a while to keep the thread clean for real issues.
    75
    Hello everyone!

    I am aware that Google has updated Safety Net that makes Magisk itself a no go for Android Pay. In fact, I witnessed the change live while I am developing the new magiskhide, which should hide all Magisk modules and Magisk installed root.

    Google is serious about Safety Net now, clearly hunting down all possibility to run Xposed with Safety Net passed. I spend quite some time examining the new security measures last midnight, and fortunately it seems that it is possible to run Magisk and root along with Safety Net if no Xposed is running. I'm glad I removed the old root toggle at the right time lol, that is no longer feasible with the latest detection.

    So stay tuned for the next update, it will come with bug fixes, along with the new magiskhide to bypass that Safety Net.

    Google, how will a few systemless mods do any harm :p:p