Magisk General Support / Discussion

Search This thread

dd805bb

Senior Member
Sep 18, 2017
453
257
Google Pixel
Google Pixel XL
Screenshot_20230321-144826.png

It's all shared from a private channel you can't even see. And the owner isn't listed.
 

Homeboy76

Recognized Contributor
Aug 24, 2012
3,872
2,310
Google Pixel XL
Google Pixel 7 Pro
Agree... This is an abusive member who thinks I'm a toxic know-it-all anyway...

I've run Alpha since this was just the base for mtk fix and other branches... Not going down the "it's not legit" route either... Already cited @huskydg's view, but nothing has changed in last couple of weeks ... Source and GitHub builds have been unavailable publicly for months now... PW
Please help me understand Magisk Alpha. Is this a Magisk Alpha - Public build?
 
  • Like
Reactions: dd805bb and zgfg

pndwal

Senior Member
The guy you are replying quoted husky first. See told you, you are toxic. Blaming me for something someone else did too. Lol. Literally the guy you are responding saying I am bad for linking that linked it before me.
I mentioned that, so did @zgfg... Who cares who said it first?...
That is toxic. Ok for him before me but not me. LMFAO. Literally are proving my point on the daily.

2weeks≠months
Last Alpha with published source was July last year AFAIK... Source began to be linked from inaccessible (to public) LSPosed GitHub since Feb this year... That's inaccessible for month's in my book...

FWIW, I never reported you previously despite your allegations (a respected dev here did)... Now I am (first time)... PW
 

Homeboy76

Recognized Contributor
Aug 24, 2012
3,872
2,310
Google Pixel XL
Google Pixel 7 Pro
Yes, checksum for app-release.apk is the same as when 25210 downloaded from the TG channel

But only the Readme, JSON for auto-updating and latest apk for download, no sources
Ok.
So, the problem XDA Members are having with using this public build of Magisk Alpha is @vvb2060 or the creator of Magisk Alpha didn't post the source code.
Thanks for the clarification.
 
Last edited:
  • Like
Reactions: pndwal and dd805bb

pndwal

Senior Member
Post in thread '[Discussion] Magisk Alpha (Public Released) fork - @vvb2060' https://forum.xda-developers.com/t/...c-released-fork-vvb2060.4424845/post-88296465

So what I originally said is still true. The GitHub Alpha repos all point to official Magisk now. They didn't a week ago before being wiped...
You originally said:
... The Alpha Canary is the same as the Canary Official, FYI.
This is still NOT true... At best, JSON in vv's Alpha GitHub repo points to official Canary notes, and Alpha does build Canary commits but it adds her experimental ones... always has... And lack of public source doesn't change that; ie. Alpha builds are a very different animal...

For example, recent builds incl latest 25210 include support for experimental (not publicly released) Shamiko v0.6-141. This simply won't run on TJW releases incl. latest Canary ATM... If you want to test early Shamiko you need Alpha...

Another big (and somewhat controversial) difference is that all Alpha builds include (Microsoft based) telemetry... Her pull request for this has been up in TJW Magisk for some time now, but John has never merged this in Canary builds... Yet...

So Alpha is basically Canary with additional (experimental) commits, and there is no published "Alpha Canary" but if there were it would be reasonable to expect it that would contain the unique Alpha commits too...

Many of vv's Alpha commits end up in TJW Magisk, as do commits from Shana's Metagisk and Canyie's Bravo as well as commits developed in other test branches from these Devs (most prolific) and from other forks/Devs also... PW
 

pndwal

Senior Member
View attachment 5868873

It's all shared from a private channel you can't even see. And the owner isn't listed.
That's only the original (Chinese) Alpha Discussion thread, now name has changed but a number of members here are in that discussion... Builds aren't shared there however, only in the official Alpha channel...

Anyone can still join if they find the cryptic (musical) entrance link in the official Alpha TG channel... 😁 PW
 
  • Haha
Reactions: dd805bb

zgfg

Senior Member
Oct 10, 2016
8,957
6,686
Redmi K20 / Xiaomi Mi 9T
Xiaomi Mi 11 Ultra
This is the Magsik Alpha. The links on this page link to Magisk Debug latest version. The code hasn't been updated but the links and where they are the same as canary/debug official build.
For those who might be confused is that the official Magisk Alpha GitHub source (wrong, it is not) and why its Readme Download links to the official Canary (yielding somebody to wrongly think that Alpha is nothing else but Magisk Canary)

Back then in the late summer of 2021, Magisk v23 was still the latest official version

However, TJW (developer and founder of Magisk), who started to work for Google some months earlier, with his peers (some of them are now Magisk Alpha developers) started to work on the new Magisk v24 with the brand new Zygisk, DenyList instead of MagiskHide, removed support for the old Modules Repo, etc

The new code was already committed to his GitHub repo (changes were ongoing) but the new Magisk Canary v24xxx had not been released yet (afaik, it was soon afterwards, during the fall of 2021)

Guys (actually girls or more appropriately, young ladies, students) from the Alpha group released their Magisk Alpha and for many of us here (who dared to install and use) that was the first experience with what would soon come with the new Magisk v24 (for a long time back then in 2021, Alpha provided the new Magisk+DenyList but also the alternative, the old MagiskHide instead)

Btw, that was also the reason why they probably chose the Alpha name - it was like an experimental, pre-release, earlier than the Magisk Canary (and Magisk Beta) v24 came out.
(Another viable theory: They thought of themselves as Alpha females😁)

And they had Magisk Alpha source code open on the GirHub (it remained open until the end of last year or so), and they themselves experimented with the new stuff through the Magisk Alpha installations, eg, developing/debugging modules like Zygisk-LSPosed (for that new Zygisk) and Shamiko (to hide Zygisk) - those modules were indeed developed and still maintained (btw, isn't Shamiko also closed source?!) from the same Alpha developers group

Hence somebody, that CoderThyn (sorry, I'm not familiar with that name but I think he was not part of Magisk nor Alpha development) forked their code

If you look to his GitHub project (you provided the link), you will see that it's frozen in time, 2 years old, last update Sep 2021 (screenshots below)

Btw, the same guy has another Alpha fork (the other screenshot below), 'newer' - albeit from Oct 2021😁

The Readme you see there is also frozen in time: Readme page (Alpha devs did not waste time on writing their own Readme.md but they reused TJW Readme from the official Magisk) - scroll down and you will see that it refers to v23 as the 'latest' Stable Magisk

(That old Readme had also a link to the Wiki - Wiki was recently removed since the author of Wiki is no more 'in' and does no more update his Wiki, although it would still be an excellent user guide for many)

All together, that GitHub link you provided is nothing else but the two years old fork of Magisk Alpha, frozen back in that time.
If you would fork yourself and build (assuming the source is complete there) you would obtain some Magisk Alpha v23xxx (as their version numbers were before Magisk v24 was released)

And the download link points to the (always the latest) official Canary since that's how it was in the Alpha Readme.md when CoderThyn forked Magisk Alpha back in Sep 2021 (again, once upon a time When the World Was New and Alpha was the open source)

Hence that GitHub project is not an up-to-date Magisk Alpha and its download link does not provide a link to download the Magisk Alpha (ie, when you click to 'his' Download and get the latest official Magisk Canary, it does not mean that Alpha = Canary - it is not and it never was)

Hopefully it resolves the confusion
 

Attachments

  • IMG_20230322_092033.jpg
    IMG_20230322_092033.jpg
    267.3 KB · Views: 58
  • IMG_20230322_091832.jpg
    IMG_20230322_091832.jpg
    351.9 KB · Views: 59
  • IMG_20230322_092123.jpg
    IMG_20230322_092123.jpg
    291 KB · Views: 55
  • IMG_20230322_092426.jpg
    IMG_20230322_092426.jpg
    319.9 KB · Views: 58
Last edited:

Nergal di Cuthah

Senior Member
Sep 20, 2013
2,111
1,156
Google Pixel 6 Pro
  • Like
Reactions: ipdev and pndwal

pndwal

Senior Member
Last edited:
  • Like
Reactions: wugga3 and ipdev

dd805bb

Senior Member
Sep 18, 2017
453
257
Google Pixel
Google Pixel XL

John was not part of that group. Quit spreading lies.

And to go even farther.
Canary= bleeding edge
Beta= almost stable
Official/alpha(term not app=stable
Hence husky using Delta name because Delta would be before Canary. Backwards alphabet like most projects. Idk where you think Alpha would before Canary. Read the GitHub she was using. She was pulling from the main branch and basically re-forking it with a commit or 2 changed from Canary. More than likely small things like package name and update channel. Literally above in John's own post from over a year ago he denounced them using that name. He didn't say anything about him being in it..if he did start it, why use that name and then call them out for using that name? I mean that sounds off. It's a good story though. She is a contributor, or was or whatever she is now. She flipped on being open source with Alpha. That is fact. Shared in a Chinese only TG. I wouldn't trust it. "Confusing."
 
Last edited:
  • Like
Reactions: Nergal di Cuthah

zgfg

Senior Member
Oct 10, 2016
8,957
6,686
Redmi K20 / Xiaomi Mi 9T
Xiaomi Mi 11 Ultra
John was not part of that group. Quit spreading lies.
Who is spreading the lies?

Who ever said here that John is part of the Alpha group?!

If you accuse anybody here that we are spreading lies - then link that post and quote particularly that sentence where it was 'said' that John is part of the Alpha group!!!

Or otherwise please stop spreading the lies (that somebody was saying here that John is part of the Alpha group)

---

And about the lies - it's harsh word but you were the one who stated more than once in your previous posts that Alpha is just a Magisk Canary - wasn't that a 'lie'?

And btw, the Twitter post you attached is well known for many of us here - look into the Magisk general thread for about a year ago, it was posted there by @pndwal
 
Last edited:

Top Liked Posts

  • 4
    https://forum.xda-developers.com/t/...r-root-pixel-7-pro-cheetah-safetynet.4502805/

    VERY IMPORTANT - On the Pixel 7/Pro, we use Magisk to patch init_boot.img, NOT boot.img AND we flash the patched init_boot to the init_boot partition - do not flash it to the boot partition.​

    2
    Still, you said

    which is just not true. You can both re-lock B/L and use stock ROM again and you will have Android like other devices. Samsung just disable their proprietary special knox-based features after device is tampered...

    Old Sammy devices did work that way, but now soc makers include e-fuses that utilise physical burn-in on the substrate... I put info on use of q-fuses (Qualcomm) here:
    https://forum.xda-developers.com/t/magisk-general-support-discussion.3432382/post-85146255

    Samsung says


    I put a number of links here (incl. ref. above):
    https://forum.xda-developers.com/t/magisk-general-support-discussion.3432382/post-85755893


    Yup... It's a choice... Much like Google's device integrity APIs and key attestation models really... They're doing that because they must compete in the secure Mobile OS arena in today's climate, and are loosing to IOS in the enterprise/corporate marketplace because of the (justified) perception that Android is largely insecure...

    Samsung want to position themselves as a credible alternative to IOS/iPhone and as the leading manufacturer of property secure Android devices in this market too as the (somewhat outdated) links above show...

    The difference in these approaches (ie. Google doesn't penalise modders by making the restoration of some device features impossible while Samsung does) may indicate that Google is more supportive of the modding community than is Samsung... I don't know if Sammy encourage custom modders in any way other than allowing B/L unlock... But it's still far more generous that what IOS will offer you!

    😜 PW
    What I said was once you root something's will never work again which is 💯 CORRECT. Of course you can relock bootloader but it won't fix the apps that will never work again and that was my point ffs
    2
    What I said was once you root something's will never work again which is 💯 CORRECT. Of course you can relock bootloader but it won't fix the apps that will never work again and that was my point ffs
    Ah... Sorry. 🙁

    I'd read
    At least you can relock bootloader and go back stock I guess. On Sammy once you trip Knox that's it something's will never ever work again...
    to mean you 'can't relock bootloader and go back to stock on Sammy once you trip Knox, and that's something that will never ever work again' rather than 'If you relock bootloader and go to back stock on Sammy, once you trip Knox some things will never ever work again'!... 🤪

    I probably should have asked you to clarify that, sorry mate... PW
    1
    Unfortunately I use everyones of the apps you listed which is why i never rooted my zfold 3. The one think Knox gives you is adhell 3 and other similar apps. You can use the Knox firewall as a pretty effective adblocker and to disable system apps/remove permissions and receivers.
    Still, you said
    At least you can relock bootloader and go back stock I guess. On Sammy once you trip Knox that's it something's will never ever work again...
    which is just not true.
    Edit: Seems I've misunderstood the members meaning here (as pointed out in next post), sorry! 🙃

    FWIW however, you can both re-lock B/L and use stock ROM again and you will have Android like other devices. Samsung just disable their proprietary special knox-based features after device is tampered...
    I must say that I totaly hate that warranty bit. No idea why, when relocking the device and wiping the device completely that bit is not reverted to 0x0 to allow the full experience.
    Old Sammy devices did work that way, but now soc makers include e-fuses that utilise physical burn-in on the substrate... I put info on use of q-fuses (Qualcomm) here:
    https://forum.xda-developers.com/t/magisk-general-support-discussion.3432382/post-85146255

    Samsung says
    If a non-Knox boot loader or kernel has been installed on the device, Knox can no longer guarantee the security of the Knox container. As a result, the Warranty Bit is tripped to 0X1, indicating that this device can no longer use the Knox Workspace (container.)

    I put a number of links here (incl. ref. above):
    https://forum.xda-developers.com/t/magisk-general-support-discussion.3432382/post-85755893

    It's one of the biggest things that I dislike about Samsung devices as I like to root my devices and make roms for them :) .
    Yup... It's a choice... Much like Google's device integrity APIs and key attestation models really... They're doing that because they must compete in the secure Mobile OS arena in today's climate, and are loosing to IOS in the enterprise/corporate marketplace because of the (justified) perception that Android is largely insecure...

    Samsung want to position themselves as a credible alternative to IOS/iPhone and as the leading manufacturer of property secure Android devices in this market too as the (somewhat outdated) links above show...

    The difference in these approaches (ie. Google doesn't penalise modders by making the restoration of some device features impossible while Samsung does) may indicate that Google is more supportive of the modding community than is Samsung... I don't know if Sammy encourage custom modders in any way other than allowing B/L unlock... But it's still far more generous that what IOS will offer you!

    😜 PW
  • 8
    Hello!
    How do you know?
    You must be an expert or something

    Nigerian-Meme.jpg 😜 PW
    7
    As I expected in advance, problems with Magisk occurred after the OTA update of LineageOS (Pixel 6a).
    Updated from a 20.0 build to lineage-20.0-20230429-nightly-bluejay

    After the update it was necessary to flash the new boot image again. I have done that. But Magisk simply does not root. Magisk patched the downloaded LineageOS boot-image, saved it in the download folder and that was it.

    Magisk was hidden before I did OTA update.
    Simply very beautiful. All this after setting up LineageOS to my liking.
    And what can I do now except re-flash ROM?

    You might be interested in this.

    If you are using the current Magisk canary build, addon.d support was fixed.
    A few weeks ago, I tested it on my Pixel 3a and made a post in The Age of Zygisk thread.
    Post #3,128

    Since I did not install Magisk via recovery, I made a module that overlays Magisk's addon.d script into the system/addon.d directory.
    The module is not necessary after the first OTA.
    - The OTA updater will actually restore the Magisk script into system with the others.

    Magisk Survival Module - [GitHub] - Link
    Please read all of the readme if you decide to use it.
    - This only works with addon.d-v2 (A/B slot devices).

    Cheers. :cowboy:

    PS.
    I have updated my 3a using the OTA updater 4/5 times now and Magisk is retained each time.
    No need to manually patch and flash the new boot image after update.
    7
    Yeah, if I want to run a custom kernel (Pixel 7) then I need to wipe. Should have sideloaded (not booted up), then gone into bootloader and run fastboot flash vbmeta --disable-verity --disable-verification vbmeta.img to that slot. Once booted after sideload/flashing the firmware it's too late as it's enabled after booting. Don't think it matters if you do it before or after flashing the patched image, just as long as you do it before you boot up. Oh well, lol...

    Nothing to do with what we were testing, just custom kernel related. Seems to also help to avoid getting the red eio corrupt message when things may not go as expected.
    Thanks, I realize it is only needed for custom Kernel cases.
    I should add extracting vbmeta from payload.bin then in addition to boot.img / init_boot.img so that the step can be performed if the options are selected.
    7
    So as well as making it easier to keep root with an ota we can have the same firmware on the device one rooted and one not? So if magisk hide/safetynet/etc aren't working we can boot to the non rooted firmware to use wallet/banking apps etc and then boot back to rooted. Or is it a bit more complicated than that? Never had a pixel device before
    Others have already addressed your question, but for me, the biggest benefit here is to have a safety valve in place where your inactive slot is bootable (without first having to flash the firmware) in case you get into a hairy situation where your active slot becomes unbootable for whatever reason. May be useful in some situations.
    7
    If the "issue" is that you have not yet been able to reproduce the Magisk manager app's "Ramdisk: Yes/No":

    Did you try a "wrapper" for the shell script function you found? At the time you reported several script fragments, there was talk of needing to call other functions first to set up environment variables.

    Look up the "echo" command. There is a form that causes the shell to echo all lines as they are executed. Do this, redirect output to a log file, and you can crawl through and maybe spot where it first disappoints you.

    I believe "needing to call other functions first to set up environment variables" is exactly why he is getting a different result from the app. 👍

    I could gut out all the relevant bits for him to run, but, not trying to offend here, I kind of don't see what the point of all this has been, so I don't think I can justify putting in that amount of effort when I've got my own stuff to be doing... 🫤

    Edit: One final thought. It could also be that he needs to use Magisk's busybox and busybox ash env for some of the commands like Magisk would be to get the intended output.

    I'm running into an interesting problem that I can't put my fingers on, and am open to ideas / suggestions.
    As you may already know, Magisk embeds the SHA1 of the stock boot image used to create the patch into the patched image, this is great because one can easily determine the source image that was used and validate if it is what it is supposed to be.

    And this is exactly what PF does, it extracts the SHA1 from the patched image.
    Here's the function code
    Python:
    def extract_sha1(binfile, length = 8):
        with open(binfile, 'rb') as f:
            s = f.read()
            # Find SHA1=
            pos = s.find(b'\x53\x48\x41\x31\x3D')
            # Move to that location
            if pos != -1:
                # move to 5 characters from the found position
                f.seek(pos + 5, 0)
                # read length bytes
                res = f.read(length)
                return res.decode("utf-8")

    Unlike magiskboot and Android Kitchen Tools by @osm0sis which extracts the ramdisk.cpio and performs magiskboot cpio <ramdisk.cpio> sha1 on it, PF (to keep it lightweight) it just looks for the string SHA1= directly on the patched file and then reads the next 8 hex characters and converts them to ascii.
    And this has worked flawlessly so far, until this.
    Basically what is happening is:
    The expected embedded SHA1 is: 40100d6b9512f6dffbb6f6b67c1b878f3bd82d18

    With the exception of the red part of the SHA1, everything matches.
    In one case 0100 part which is expected to be 30 31 30 30 hex it is instead 89 00 FB 33, and in the other case it is 72 00 FC 15

    View attachment 5902493View attachment 5902495


    I don't understand why this is happening, my first guess would be some kind of encoding, but then why now and only with this image, my other guess / fear is that perhaps the writing is not clean which would be a bug in Magisk.
    Obviously I can skip over the first few bytes and do the validation with the remaining bytes, but I'd hate to take a path like that without understanding why this is happening, who's to say that this thing can't happen on the other portions of the SHA1 string.

    If you have any ideas, I'm all ears.

    The boot.img contains the ramdisk.cpio.gz/.lz4/.lzma/.xz and while text strings may get stored as-is in a compression format, that isn't guaranteed and the compression might find something it thinks it can "optimize" for space savings. That's why `magiskboot cpio <file> sha1` is run on the uncompressed ramdisk.cpio. 🙂
  • 1094
    This is the place for general support and discussion regarding "Public Releases", which includes both stable and beta releases.
    All information, including troubleshoot guides and notes, are in the Announcement Thread
    156
    Hello, I haven't given much support on XDA lately. It can be resulted from
    • University started and I have limited free time. In fact, I mostly develop during midnight
    • I live in Taiwan, which has large time zone differences between my European/American contributors/testers, which usually forces me to stay up late at night to discuss/test stuffs.
    • The new version is about to come, I don't want to spend effort on supporting old releases
    The planned update is delayed again and again, to some point I think I'll shed some light about what has been happening lately, also along with some announcements.

    New Forum!
    As you might have already discovered, Magisk got its own subforum on XDA! Many thanks to all the support you gave me, and much more information/features/support is about to come!
    **For developers supporting all the devices that are not using standard Android boot format, feel free to create threads in this section (actually, PLEASE do so) for your favorite devices after v7 is out. As I currently know, Asus devices require signing the boot image before flashing, and is model dependant; Sony devices seems to use ELF kernel that is unpatchable, or some has two ramdisks (inner + outer), both requires different workarounds; LG bootloader locked devices has to manually "BUMP" the boot image after flashing Magisk..... and there may be lots of other crazy boot image formats that haven't come up to my attention yet.
    It is impossible for me to support all these non-standard boot images, and I hope the community can collaborate to make Magisk running across all the devices. Overall, community collaboration is what XDA about :D

    The Pixel Phone
    Some of you might already know this news, that the next Pixel Phone right around the corner seems like it does not have ramdisk in boot image, which pretty much wrecked Magisk in all ways. However, it pretty much doomed root itself too. Kernel modifications is inevitable IMO, so I'll try to migrate my scripts to C programs that could possibly be included into the kernel itself. Note that I'm not familiar with linux kernel, I'm not even sure if my idea and concept is correct or not. But once the device is available, I think developers will find a way to bypass all the difficulties, and I'll do my best to learn things ;)

    Current Progress
    In the past month, I've spent quite some time learning SELinux, so that I can avoid using SuperSU's sepolicy patches. Thanks to the helps and tips from @phhusson and @Chainfire, I finally have a much clearer understanding of how SELinux works. The Magisk core parts (the scripts, boot image patches, new features, more supports) are actually done some time ago. What is causing all the delays is the Magisk Manager.
    To be completely honest, although I can code in Java without much issues, Magisk Manager is actually my first Android application, I had to reach out for assistance, and fortunately awesome developers like @DVDandroid and @digitalhigh contributed a lot, which makes the current Manager awesome.
    After the repo system and module management is mostly done, I was about to do some adjustments and release, but what we really done is decided to add another feature: auto-unroot with per-app settings. I decided to wait for it to be finished, and then do my adjustments. Due to reasons that'll be mentioned later, this feature will likely not be available for the next release (should come in future updates)

    Safety Net Disaster
    Those who are using Magisk for Safety Net bypass purposes must have known that Google recently updated the detection method of my Systemless Xposed. I still have no idea what Safety Net is detecting, so currently I cannot fix it on my side (also because I'm busy working on the next update). However, suhide developed by @Chainfire is able to hide Xposed and worked fine.
    However, only my Systemless Xposed v86.2, which is based on SuperSU's su.d, is supported using that method. v86.2 and v86.5 (latest, Magisk based) have nearly identical binaries, and the only difference is the path where the binaries are stored.
    I'm still not sure what's the real issue for it not being supported, I just hope it is not done intentionally.

    Conclusion
    Due to the fact that my Safety Net bypass is not 100% perfect now, I do not want to spend any more time waiting for auto-unroot to be polished. What I'm doing now is finishing up all the things I'd like to change in Magisk Manager (it has been a while since I last contributed to Manager, my fellow developers are doing all the heavy job), which might take a little more time, after that, packed with tons of information to be announced in Magisk Section, I'll release the long awaited update.

    Hope this lengthy post gives you the idea of the whole situation, and again thanks for all your support!!
    121
    Ah, some Chainfire bashing, I hope it is not too late for me to exercise additional villainy.

    First, let me make clear I have nothing against @topjohnwu, nor against Magisk. Magisk is an interesting project and it certainly displays @topjohnwu ingenuity and persistence. I don't doubt we will see more interesting things from his hands.

    -------------------------

    What has happened here is not all that dark and complicated, from either end. I returned from holidays, and someone pointed me at Magisk. My first thought: interesting!

    Among other things, the thread lists some issues with SuperSU, which in combination with the phrase The developer also requests users to not bug Chainfire with compatibility requests for SuperSU with Magisk from the portal article, raised my left eyebrow by nigh half an inch. The popular systemless xposed mod is apparently now based on it, and apparently it now no longer works with SuperSU, and apparently I'm not supposed to fix that, nor any of the other found issues. I found that a bit weird. So yes, I have told @topjohnwu that I was a bit surprised he was posting about issues with SuperSU without notifying me about them (I can't fix or help fix issues I'm not aware of, after all).

    He's also spreading a modified version of the SuperSU package, which is not all that uncommon, nor necessarily a problem. I have not looked into what he modified, I only ran a few quick tests on one of my devices, and found some commonly used commands run as root to be broken. I have informed him of this as well.

    It appears the tool of choice for Magisk is phh's Superuser, because of some of the mentioned issues with SuperSU. That's fine by itself, but fixing issues in that superuser by incorporating SuperSU's binaries into it is a somewhat questionable practise. After all, SuperSU is a commercial closed-source package that helps pay for my dinner, and superuser is a direct competitor. I have informed him that I was surprised he did this without asking for permission. I have expressed similar surprise on him spreading a modified version of LiveBoot (which helps pay for a snack now and then).
    @topjohnwu has also stated that Magisk's scripts are largely influenced by mine (I have not checked). Scripts based on mine are used all over the place on XDA, some people have crafted amazing things based on them, I have never made an issue of this (otherwise I would have just made them binaries). But yes, I have also stated to him that I don't think it's very nice to base something on one program, and then using that to (almost exclusively) push something directly competing with that program.

    tl;dr Towards @topjohnwu, I have:
    - expressed surprise he has issues getting Magisk to work with SuperSU, and has chosen not to inform me about those
    - expressed surprise he is using SuperSU binaries in a competing superuser without permission
    - expressed surprise he is posting a modified LiveBoot without permission
    - informed him of issues with the modified SuperSU he has posted
    - let him know I thought it wasn't very nice to be applying my scripts to benefit seemingly exclusively that same competing superuser

    To be crystal clear:
    - I have not asked for an apology
    - I have not asked for Magisk to be abandoned, neither the root hiding nor systemless module parts, and certainly not systemless xposed
    - I have not made an issue of any of this anywhere, until this post
    - I have not even specifically asked for anything to be taken down (though obviously in my opinion the other superuser package mixed with SuperSU's binaries, as well as the LiveBoot package, should go)
    - I have not reported this thread to XDA moderators for copyright violations or otherwise

    While my conversation with @topjohnwu may not win any awards for being friendly (though it may win some for brevity), I think all things considered my response has been rather mild. To be perfectly honest, until the apology post, I thought this was over with already. I think the apology post was triggered because I haven't replied to his last PM for a while - I was in the zone, it happens.

    To emphasize again, I have nothing against @topjohnwu, Magisk, or systemless xposed, and it is certainly not my goal to see any of them go. If it can be made to work together with SuperSU, great.

    I get it though: you think of something, you want to see if you can make it work, you finally get it to work, you publish it, it takes off - enthusiasm gets the better of you. Maybe in the rush some mistakes are made. That doesn't mean you have to just drop it and run. None of my stuff would make it past 0.1 if I stopped at the first big mistake :)

    Aside from said being in the zone coding, I usually regret actually responding to these sort of things the day after, which has made me hesitant to reply. Surprise me.
    76
    Thread temporarily closed so everyone sees this.

    The flood of "SafetyNet isn't working for me either!" posts are not helpful, at all. Please refrain from posting further, it will be looked into. Please do not forget that not passing SafetyNet is 100% NORMAL AND INTENDED when you have an unlocked booloader or running custom firmware. These are workarounds and they will be worked around in turn.

    The Flash
    Forum Moderator

    EDIT: Thread is reopened... I will be cleaning any SafetyNet posts for a while to keep the thread clean for real issues.
    75
    Hello everyone!

    I am aware that Google has updated Safety Net that makes Magisk itself a no go for Android Pay. In fact, I witnessed the change live while I am developing the new magiskhide, which should hide all Magisk modules and Magisk installed root.

    Google is serious about Safety Net now, clearly hunting down all possibility to run Xposed with Safety Net passed. I spend quite some time examining the new security measures last midnight, and fortunately it seems that it is possible to run Magisk and root along with Safety Net if no Xposed is running. I'm glad I removed the old root toggle at the right time lol, that is no longer feasible with the latest detection.

    So stay tuned for the next update, it will come with bug fixes, along with the new magiskhide to bypass that Safety Net.

    Google, how will a few systemless mods do any harm :p:p