Magisk General Support / Discussion
- Thread starter topjohnwu
- Start date
Please help me understand Magisk Alpha. Is this a Magisk Alpha - Public build?
Yes, checksum for app-release.apk is the same as when 25210 downloaded from the TG channel
But only the Readme, JSON for auto-updating and latest apk for download, no sources
I mentioned that, so did @zgfg... Who cares who said it first?...
Last Alpha with published source was July last year AFAIK... Source began to be linked from inaccessible (to public) LSPosed GitHub since Feb this year... That's inaccessible for month's in my book...
FWIW, I never reported you previously despite your allegations (a respected dev here did)... Now I am (first time)... PW
Ok.
So, the problem XDA Members are having with using this public build of Magisk Alpha is @vvb2060 or the creator of Magisk Alpha didn't post the source code.
Thanks for the clarification.
Last edited:
You originally said:
This is still NOT true... At best, JSON in vv's Alpha GitHub repo points to official Canary notes, and Alpha does build Canary commits but it adds her experimental ones... always has... And lack of public source doesn't change that; ie. Alpha builds are a very different animal...
For example, recent builds incl latest 25210 include support for experimental (not publicly released) Shamiko v0.6-141. This simply won't run on TJW releases incl. latest Canary ATM... If you want to test early Shamiko you need Alpha...
Another big (and somewhat controversial) difference is that all Alpha builds include (Microsoft based) telemetry... Her pull request for this has been up in TJW Magisk for some time now, but John has never merged this in Canary builds... Yet...
So Alpha is basically Canary with additional (experimental) commits, and there is no published "Alpha Canary" but if there were it would be reasonable to expect it that would contain the unique Alpha commits too...
Many of vv's Alpha commits end up in TJW Magisk, as do commits from Shana's Metagisk and Canyie's Bravo as well as commits developed in other test branches from these Devs (most prolific) and from other forks/Devs also... PW
That's only the original (Chinese) Alpha Discussion thread, now name has changed but a number of members here are in that discussion... Builds aren't shared there however, only in the official Alpha channel...
Anyone can still join if they find the cryptic (musical) entrance link in the official Alpha TG channel...
PW
For those who might be confused is that the official Magisk Alpha GitHub source (wrong, it is not) and why its Readme Download links to the official Canary (yielding somebody to wrongly think that Alpha is nothing else but Magisk Canary)This is the Magsik Alpha. The links on this page link to Magisk Debug latest version. The code hasn't been updated but the links and where they are the same as canary/debug official build.
GitHub - CoderTyn/Magisk-Alpha
Contribute to CoderTyn/Magisk-Alpha development by creating an account on GitHub.github.com
Back then in the late summer of 2021, Magisk v23 was still the latest official version
However, TJW (developer and founder of Magisk), who started to work for Google some months earlier, with his peers (some of them are now Magisk Alpha developers) started to work on the new Magisk v24 with the brand new Zygisk, DenyList instead of MagiskHide, removed support for the old Modules Repo, etc
The new code was already committed to his GitHub repo (changes were ongoing) but the new Magisk Canary v24xxx had not been released yet (afaik, it was soon afterwards, during the fall of 2021)
Guys (actually girls or more appropriately, young ladies, students) from the Alpha group released their Magisk Alpha and for many of us here (who dared to install and use) that was the first experience with what would soon come with the new Magisk v24 (for a long time back then in 2021, Alpha provided the new Magisk+DenyList but also the alternative, the old MagiskHide instead)
Btw, that was also the reason why they probably chose the Alpha name - it was like an experimental, pre-release, earlier than the Magisk Canary (and Magisk Beta) v24 came out.
(Another viable theory: They thought of themselves as Alpha females
)And they had Magisk Alpha source code open on the GirHub (it remained open until the end of last year or so), and they themselves experimented with the new stuff through the Magisk Alpha installations, eg, developing/debugging modules like Zygisk-LSPosed (for that new Zygisk) and Shamiko (to hide Zygisk) - those modules were indeed developed and still maintained (btw, isn't Shamiko also closed source?!) from the same Alpha developers group
Hence somebody, that CoderThyn (sorry, I'm not familiar with that name but I think he was not part of Magisk nor Alpha development) forked their code
If you look to his GitHub project (you provided the link), you will see that it's frozen in time, 2 years old, last update Sep 2021 (screenshots below)
Btw, the same guy has another Alpha fork (the other screenshot below), 'newer' - albeit from Oct 2021
The Readme you see there is also frozen in time: Readme page (Alpha devs did not waste time on writing their own Readme.md but they reused TJW Readme from the official Magisk) - scroll down and you will see that it refers to v23 as the 'latest' Stable Magisk
(That old Readme had also a link to the Wiki - Wiki was recently removed since the author of Wiki is no more 'in' and does no more update his Wiki, although it would still be an excellent user guide for many)
All together, that GitHub link you provided is nothing else but the two years old fork of Magisk Alpha, frozen back in that time.
If you would fork yourself and build (assuming the source is complete there) you would obtain some Magisk Alpha v23xxx (as their version numbers were before Magisk v24 was released)
And the download link points to the (always the latest) official Canary since that's how it was in the Alpha Readme.md when CoderThyn forked Magisk Alpha back in Sep 2021 (again, once upon a time When the World Was New and Alpha was the open source)
Hence that GitHub project is not an up-to-date Magisk Alpha and its download link does not provide a link to download the Magisk Alpha (ie, when you click to 'his' Download and get the latest official Magisk Canary, it does not mean that Alpha = Canary - it is not and it never was)
Hopefully it resolves the confusion
Attachments
Last edited:
I have been using this link for current code changes.
github.com
GitHub - topjohnwu/Magisk: The Magic Mask for Android
The Magic Mask for Android. Contribute to topjohnwu/Magisk development by creating an account on GitHub.
github.com
Thank you, though that link is, of course, in the information thread and peppered all through this discussion thread so nothing newI have been using this link for current code changes.
GitHub - topjohnwu/Magisk: The Magic Mask for Android
The Magic Mask for Android. Contribute to topjohnwu/Magisk development by creating an account on GitHub.
Users should be aware that official @kdrag0n fix is busted ATM however.... Use this fork:Also current changes for safetynet Fix
kdrag0n - Overview
Generalist dev exploring new things. kdrag0n has 120 repositories available. Follow their code on GitHub.
https://github.com/Displax/safetynet-fix
PW
Last edited:
For the record. 
Any one using the CI builds or personal builds of Magisk.
Personal builds from the main branch.
Today's updates (20230322), fixed the installing and patching issues.
Magisk - Commits (master branch) - Link
Cheers.
Any one using the CI builds or personal builds of Magisk.
Personal builds from the main branch.
Today's updates (20230322), fixed the installing and patching issues.
Magisk - Commits (master branch) - Link
Cheers.
John was not part of that group. Quit spreading lies.
And to go even farther.
Canary= bleeding edge
Beta= almost stable
Official/alpha(term not app=stable
Hence husky using Delta name because Delta would be before Canary. Backwards alphabet like most projects. Idk where you think Alpha would before Canary. Read the GitHub she was using. She was pulling from the main branch and basically re-forking it with a commit or 2 changed from Canary. More than likely small things like package name and update channel. Literally above in John's own post from over a year ago he denounced them using that name. He didn't say anything about him being in it..if he did start it, why use that name and then call them out for using that name? I mean that sounds off. It's a good story though. She is a contributor, or was or whatever she is now. She flipped on being open source with Alpha. That is fact. Shared in a Chinese only TG. I wouldn't trust it. "Confusing."
Last edited:
my magisk is "d52ea1b0-alpha:MAGISK:R (25210)"
how do I go back to the latest stable version?
thank you.
how do I go back to the latest stable version?
thank you.
Who is spreading the lies?
Who ever said here that John is part of the Alpha group?!
If you accuse anybody here that we are spreading lies - then link that post and quote particularly that sentence where it was 'said' that John is part of the Alpha group!!!
Or otherwise please stop spreading the lies (that somebody was saying here that John is part of the Alpha group)
---
And about the lies - it's harsh word but you were the one who stated more than once in your previous posts that Alpha is just a Magisk Canary - wasn't that a 'lie'?
And btw, the Twitter post you attached is well known for many of us here - look into the Magisk general thread for about a year ago, it was posted there by @pndwal
Last edited:
Folks, how about taking this to a PM exchange?
This is derailing this thread and you either agree to disagree or try a PM approach.
Thx for understanding.
Cheers,
mrjuniork
This is derailing this thread and you either agree to disagree or try a PM approach.
Thx for understanding.
Cheers,
mrjuniork
Similar threads
Top Liked Posts
-
2Continuing on the previous talk about /system/bin
That folder provides pre-installed Linux binaries and utilities (many are needed by the system itself like during the booting to System), and that includes also the toybox tool-box, ie, the toybox binary and its applets (Linux utilities to be executed by the toybox binary and linked to the toybox binary)
If I recall correctly, toybox comes already as part of AOSP, those utilities that are needed to run the AOSP build scripts (except for the compiler, linker, and so)
Hence the pre-installed toybox with its applets built into the AOSP are self-sufficient to rebuild AOSP (that was like the agenda behind)
Now, I'd like to ask those of you who are not afraid of Terminal emulator, to run the following commands to find about the toybox preinstalled to your ROMs
Commands must be executed in the given order, since I define some variable ($TB), switch to a particular directory, and use them all till the end
First we look if the toybox binary is preinstalled, where (full path), and for its version:
Code:su TB=toybox which $TB ls -l $(which $TB) $TB --version # to learn more, read: $TB --help
Expected output will be: /system/bin/toybox (maybe on some older ROMs /sbin/toybox ?!), v0.8.4-android or so (on my two phones)
Btw the latest toybox is v0.8.9 from Jan 2023, see the official ToyBox site https://landley.net/toybox
Now we extract the system folder/path where the toybox is installed, change to that directory and print the current path (pwd):
Code:cd $(which $TB | sed "s,/$TB$,,") pwd
Now we look for the expected toybox utilities to be installed to the same directory (I'm looking for the utilities I'm just using: cut, grep, ls, pwd, sed, wc, which; the others like cd and rev are provided by the shell itself, hence I don't need an additional tool-box like busybox and its applets)
Code:ls -l cut ls -l grep ls -l ls ls -l pwd ls -l sed ls -l wc ls -l which
They are expected to be linked to the toybox binary with chmod 755 or 744 (executable files), like:
Code:lrwxrwxrwx 1 root root 6 1971-07-07 12:40 cut -> toybox lrwxrwxrwx 1 root root 6 1971-07-07 12:40 grep -> toybox lrwxrwxrwx 1 root root 6 1971-07-07 12:40 ls -> toybox lrwxrwxrwx 1 root root 6 1971-07-07 12:40 pwd -> toybox lrwxrwxrwx 1 root root 6 1971-07-07 12:40 sed -> toybox lrwxrwxrwx 1 root root 6 1971-07-07 12:40 wc -> toybox lrwxrwxrwx 1 root root 6 1971-07-07 12:40 which -> toybox
Hence they can be called two ways, like:
Code:toybox cut --help # or shorter, just: cut --help
Now we list all files in this directory (line by line), grep (filter) for those having toybox in the line/string (either the toybox binary itself or applets linked to the toybox binary) and additionally filter from them those being the executable links (lrwx), and count the number of these filtered lines:
Code:ls -l | grep $TB | grep ^lr.x | wc -l
Expected result will be like 174 (latest toybox v0.8.9 can provide many more, 233 applets), meaning that we have the toybox binary with eg 174 its applets
To summarize, we will use the trick with reversing the lines/strings and cutting out their third fields (applet names) but counting the field ordinals from the (reversed) beginning, since the cut utility cannot count and cut from the end
Eg, we have to extract the third field/word (applet name) counting from the end, say: pwd, from the ls -l line/string ending with the known end part of the format like:
... pwd -> toybox
hence we execute:
Code:ls -l | grep $TB | grep ^lr.x | rev | cut -d ' ' -f 3 | rev
Expected list of the pre-installed toybox applets will include: [ (aka the test utility), test, utilities mentioned above, and more like cat, chmod, echo, find, ln, gunzip, gzip, kill, mkdir, mount, printf, rm, rmdir, sleep, sort, touch, tar and so on:
[
acpi
base64
basename
blockdev
cal
cat
chattr
chcon
chgrp
chmod
chown
chroot
chrt
cksum
clear
cmp
comm
cp
cpio
cut
date
dd
devmem
df
diff
dirname
dmesg
dos2unix
du
echo
egrep
env
expand
expr
fallocate
false
fgrep
file
find
flock
fmt
free
fsync
getconf
getenforce
grep
groups
gunzip
gzip
head
hostname
hwclock
i2cdetect
i2cdump
i2cget
i2cset
iconv
id
ifconfig
inotifyd
insmod
install
ionice
iorenice
kill
killall
ln
load_policy
log
logname
losetup
ls
lsattr
lsmod
lsof
lspci
lsusb
md5sum
microcom
mkdir
mkfifo
mknod
mkswap
mktemp
modinfo
more
mount
mountpoint
mv
nc
netcat
netstat
nice
nl
nohup
nproc
nsenter
od
paste
patch
pgrep
pidof
pkill
pmap
printenv
printf
ps
pwd
readelf
readlink
realpath
renice
restorecon
rm
rmdir
rmmod
rtcwake
runcon
sed
sendevent
seq
setenforce
setsid
sha1sum
sha224sum
sha256sum
sha384sum
sha512sum
sleep
sort
split
stat
strings
stty
swapoff
swapon
sync
sysctl
tac
tail
tar
taskset
tee
test
time
timeout
top
touch
tr
true
truncate
tty
ulimit
umount
uname
uniq
unix2dos
unlink
unshare
uptime
usleep
uudecode
uuencode
uuidgen
vmstat
watch
wc
which
whoami
xargs
xxd
yes
zcat
---
Finally, I would be interested to see from your ROMs - thanks in advance:
- do you have toybox pre-installed
- is it pre-installed to /system/bin or some other directory
- which version (couple of years ago old v0.8.4 or maybe newer)
- how many toybox executables are preinstalled in your ROM (174 or more or less)2Continuing on the previous talk about /system/bin
That folder serves to provide pre-installed Linux binaries and utilities (many are needed by the system itself, like during the booting to System), and that includes also the toybox tool-box, ie, the toybox binary and its applets (Linux utilities linked to the toybox binary)
If I recall correctly, toybox comes already as part of AOSP, those utilities that are needed to run the AOSP build scripts (except for the compiler, linker, and so)
Hence the pre-installed toybox with its applets built to AOSP are self-sufficient to rebuild the AOSP (that was like the agenda behind)
Now, I'd like to ask those of you who are not afraid of Terminal emulator, to run the following commands to find about the toybox preinstalled to your ROMs
Commands must be executed in the given order, since I define some variable ($TB), switch to a particular directory, and use them all till the end
First we look if the toybox binary is preinstalled, where (full path), and for its version:
Code:su TB=toybox which $TB ls -l $(which $TB) $TB --version # to learn more, read: $TB --help
Expected output will be: /system/bin/toybox (maybe on some older ROMs /sbin/toybox ?!), v0.8.4-android or so (on my two phones)
Btw the latest toybox is v0.8.9 from Jan 2023, see the official ToyBox site https://landley.net/toybox
Now we extract the system folder/path where the toybox is installed, change to that directory and print the current path (pwd):
Code:cd $(which $TB | rev | cut -c 7- | rev) pwd
Observe that I used a trick: rev applet/utility to reverse the full path string (eg /system/bin/toybox to xobyot/nib/metsys/), then cut to cut all before the 7th character now counting from the beginning, (/nib/metsys/) and then rev to reverse it back (/system/bin/)
That way I didn't need heavy artillery like sed or even awk (awk is not part of toybox and it requires additional toolbox like busybox) to cut off from the end but from the path/string with an unknown/variable length
Now we look for the expected toybox utilities to be installed to the same directory (I'm looking for the utilities I'm just using: cut, grep, ls, pwd, wc, which; the others like cd and rev are provided by the shell itself, hence I don't need an additional tool-box like busybox and its applets)
Code:ls -l cut ls -l grep ls -l ls ls -l pwd ls -l wc ls -l which
They are expected to be linked to the toybox binary with chmod 755 or 744 (executable files), like:
Code:lrwxrwxrwx 1 root root 6 1971-07-07 12:40 cut -> toybox lrwxrwxrwx 1 root root 6 1971-07-07 12:40 grep -> toybox lrwxrwxrwx 1 root root 6 1971-07-07 12:40 ls -> toybox lrwxrwxrwx 1 root root 6 1971-07-07 12:40 pwd -> toybox lrwxrwxrwx 1 root root 6 1971-07-07 12:40 wc -> toybox lrwxrwxrwx 1 root root 6 1971-07-07 12:40 which -> toybox
Hence they can be called two ways, like:
Code:toybox cut --help # or shorter, just: cut --help
Now we list all files in this directory (line by line), grep (filter) for those having toybox in the line/string (either the toybox binary itself or applets linked to the toybox binary) and additionally filter from them those being the executable links (lrwx), and count the number of these filtered lines:
Code:ls -l | grep $TB | grep lrwx | wc -l
Expected result will be like 174 (latest toybox v0.8.9 can provide many more, 233 applets), meaning that we have the toybox binary with eg 174 its applets
To summarize, we will use again the trick with reversing the lines/strings and cutting out their third fields (applet names) but counting the field ordinals from the (reversed) beginning, since the cut utility cannot count and cut from the end
Eg, we have to extract the third field/word (applet name) counting from the end, eg: pwd, from the ls -l line/string ending with the known end part of the format like:
... pwd -> toybox
hence we execute:
Code:ls -l | grep $TB | grep lrwx | rev | cut -d ' ' -f 3 | rev
Expected list of the pre-installed toybox applets will include: [ (aka the test utility), test, utilities mentioned above, and more like cat, chmod, echo, find, ln, gunzip, gzip, kill, mkdir, mount, printf, rm, rmdir, even sed, sleep, sort, touch, tar and so on:
[
acpi
base64
basename
blockdev
cal
cat
chattr
chcon
chgrp
chmod
chown
chroot
chrt
cksum
clear
cmp
comm
cp
cpio
cut
date
dd
devmem
df
diff
dirname
dmesg
dos2unix
du
echo
egrep
env
expand
expr
fallocate
false
fgrep
file
find
flock
fmt
free
fsync
getconf
getenforce
grep
groups
gunzip
gzip
head
hostname
hwclock
i2cdetect
i2cdump
i2cget
i2cset
iconv
id
ifconfig
inotifyd
insmod
install
ionice
iorenice
kill
killall
ln
load_policy
log
logname
losetup
ls
lsattr
lsmod
lsof
lspci
lsusb
md5sum
microcom
mkdir
mkfifo
mknod
mkswap
mktemp
modinfo
more
mount
mountpoint
mv
nc
netcat
netstat
nice
nl
nohup
nproc
nsenter
od
paste
patch
pgrep
pidof
pkill
pmap
printenv
printf
ps
pwd
readelf
readlink
realpath
renice
restorecon
rm
rmdir
rmmod
rtcwake
runcon
sed
sendevent
seq
setenforce
setsid
sha1sum
sha224sum
sha256sum
sha384sum
sha512sum
sleep
sort
split
stat
strings
stty
swapoff
swapon
sync
sysctl
tac
tail
tar
taskset
tee
test
time
timeout
top
touch
tr
true
truncate
tty
ulimit
umount
uname
uniq
unix2dos
unlink
unshare
uptime
usleep
uudecode
uuencode
uuidgen
vmstat
watch
wc
which
whoami
xargs
xxd
yes
zcat
---
Finally, I would be interested to see from your ROMs - thanks in advance:
- do you have toybox pre-installed
- is it pre-installed to /system/bin or some other directory
- which version (couple of years ago old v0.8.4 or maybe newer)
- how many toybox executables are preinstalled in your ROM (174 or more or less)
Hi
fyi
Bash:cd $(which $TB | rev | cut -c 7- | rev)
rev is not installed per default (at least in the OmniROM) and that is ugly code ... better use something like this:
Bash:TBP=$( which $TB ) echo ${TBP%/*} cd ${TBP%/*}
and to list the symbolic links something like this:
Bash:ls -l | cut -c50- | cut -f1 -d " "
regards
Bernd2
Where are you hoping to find these "lost" pictures?
If you deleted them by accident, their space could have been overwritten by now.
If they used to be accessible from a PC, they are probably in the area called /sdcard, unless they were on an external SD-card. If an external SD-card, remove it from your device and read it directly on a PC.
If you want to know which partition is "/data", check the output of "mount". (My tablet has /dev/block/mmcblk0p69 mounted on /data) Or run a partition program like "fdisk -l". ("fdisk" is not in my toybox, but it is in @osm0sis' busybox.)
If there is a good custom recovery for your device I don't think it offers you anything you don't have right now. It would just be a different way to run Android with root privilege. Unless something like TWRP can be counted on to not touch /data without being told to, which might be of some value to avoid overwriting any more of these pictures, assuming they were deleted.2
If you don't set unlock pin then Android uses some default but random/unique key it creates and secretly stores on the first reboot after factory resetting (formatting Internal storage).
Since the Google constantly changes and improves protections/privacy with the new Android versions, it causes delays and takes additional efforts for TWRP developers to breake and to make TWRP to be also able to decrypt and read/write to Data and Internal storage
It's all about protecting the user's data (that can be also now the photos of your children) in case of lost or stolen phone
Therefore, whatever you do now will not help.(and Magisk and root cannot help you) to recover (random key used as default for encryption during your previous life, ie, before you factory reset the phone).
And btw, unlocking BL usually includes the mandatory factory reset
You had to regularly backup your data (photos are the most easiest part - connect the phone by USB cable to PC, use MTP and copy the /DCIM/Camera folder to PC) and specially before unlocking BL and/or factory resetting2
This had to be it, 1.0.5 made my device bootloop but once 1.0.6 was released all went back to normal.
In fact, the changelog for 1.0.6 states that the release was to fix bootlooping devices
My detective work is done, case solved -
8
Others have already addressed your question, but for me, the biggest benefit here is to have a safety valve in place where your inactive slot is bootable (without first having to flash the firmware) in case you get into a hairy situation where your active slot becomes unbootable for whatever reason. May be useful in some situations.87
Thanks, I realize it is only needed for custom Kernel cases.
I should add extracting vbmeta from payload.bin then in addition to boot.img / init_boot.img so that the step can be performed if the options are selected.7
You are not supposed to "hide all apps", you are generally advised to hide as few apps as possible; hide an app only when necessary.
I don't know whether "hide all apps from google" means "hide from Google all apps" or "hide any app you think was produced by Google", but both are bad ideas.
In particular, hiding some Google processes can cripple Android.
There have been posts about USNF or Shamiko (not necessarily both, I just don't remember the details) removing some Google process from the deny list because it (the module, USNF or Shamiko) handled that process specially. I do not remember reading about those other processes you say are getting unticked.6You guys still aren't using ASH_STANDALONE=1 which forces busybox to use its own applets above what's in the path. Either export it or specify it as a command prefix. It has to be Magisk's busybox or my SELinux busybox to have the patch required for standalone mode.
export ASH_STANDALONE=1
/data/adb/magisk/busybox ash /data/local/tmp/test2.sh
or
ASH_STANDALONE=1 /data/adb/magisk/busybox ash /data/local/tmp/test2.sh
P.S. `` (backticks) are just a lazy way to suggest a code/command block since that's what they are when used in markdown, plus if copied whole directly to a shell it just dumps it into a subshell, like $() does, and unlike "". -
1094This is the place for general support and discussion regarding "Public Releases", which includes both stable and beta releases.
All information, including troubleshoot guides and notes, are in the Announcement Thread156Hello, I haven't given much support on XDA lately. It can be resulted from
- University started and I have limited free time. In fact, I mostly develop during midnight
- I live in Taiwan, which has large time zone differences between my European/American contributors/testers, which usually forces me to stay up late at night to discuss/test stuffs.
- The new version is about to come, I don't want to spend effort on supporting old releases
New Forum!
As you might have already discovered, Magisk got its own subforum on XDA! Many thanks to all the support you gave me, and much more information/features/support is about to come!
**For developers supporting all the devices that are not using standard Android boot format, feel free to create threads in this section (actually, PLEASE do so) for your favorite devices after v7 is out. As I currently know, Asus devices require signing the boot image before flashing, and is model dependant; Sony devices seems to use ELF kernel that is unpatchable, or some has two ramdisks (inner + outer), both requires different workarounds; LG bootloader locked devices has to manually "BUMP" the boot image after flashing Magisk..... and there may be lots of other crazy boot image formats that haven't come up to my attention yet.
It is impossible for me to support all these non-standard boot images, and I hope the community can collaborate to make Magisk running across all the devices. Overall, community collaboration is what XDA about
The Pixel Phone
Some of you might already know this news, that the next Pixel Phone right around the corner seems like it does not have ramdisk in boot image, which pretty much wrecked Magisk in all ways. However, it pretty much doomed root itself too. Kernel modifications is inevitable IMO, so I'll try to migrate my scripts to C programs that could possibly be included into the kernel itself. Note that I'm not familiar with linux kernel, I'm not even sure if my idea and concept is correct or not. But once the device is available, I think developers will find a way to bypass all the difficulties, and I'll do my best to learn things
Current Progress
In the past month, I've spent quite some time learning SELinux, so that I can avoid using SuperSU's sepolicy patches. Thanks to the helps and tips from @phhusson and @Chainfire, I finally have a much clearer understanding of how SELinux works. The Magisk core parts (the scripts, boot image patches, new features, more supports) are actually done some time ago. What is causing all the delays is the Magisk Manager.
To be completely honest, although I can code in Java without much issues, Magisk Manager is actually my first Android application, I had to reach out for assistance, and fortunately awesome developers like @DVDandroid and @digitalhigh contributed a lot, which makes the current Manager awesome.
After the repo system and module management is mostly done, I was about to do some adjustments and release, but what we really done is decided to add another feature: auto-unroot with per-app settings. I decided to wait for it to be finished, and then do my adjustments. Due to reasons that'll be mentioned later, this feature will likely not be available for the next release (should come in future updates)
Safety Net Disaster
Those who are using Magisk for Safety Net bypass purposes must have known that Google recently updated the detection method of my Systemless Xposed. I still have no idea what Safety Net is detecting, so currently I cannot fix it on my side (also because I'm busy working on the next update). However, suhide developed by @Chainfire is able to hide Xposed and worked fine.
However, only my Systemless Xposed v86.2, which is based on SuperSU's su.d, is supported using that method. v86.2 and v86.5 (latest, Magisk based) have nearly identical binaries, and the only difference is the path where the binaries are stored.
I'm still not sure what's the real issue for it not being supported, I just hope it is not done intentionally.
Conclusion
Due to the fact that my Safety Net bypass is not 100% perfect now, I do not want to spend any more time waiting for auto-unroot to be polished. What I'm doing now is finishing up all the things I'd like to change in Magisk Manager (it has been a while since I last contributed to Manager, my fellow developers are doing all the heavy job), which might take a little more time, after that, packed with tons of information to be announced in Magisk Section, I'll release the long awaited update.
Hope this lengthy post gives you the idea of the whole situation, and again thanks for all your support!!121Ah, some Chainfire bashing, I hope it is not too late for me to exercise additional villainy.
First, let me make clear I have nothing against @topjohnwu, nor against Magisk. Magisk is an interesting project and it certainly displays @topjohnwu ingenuity and persistence. I don't doubt we will see more interesting things from his hands.
-------------------------
What has happened here is not all that dark and complicated, from either end. I returned from holidays, and someone pointed me at Magisk. My first thought: interesting!
Among other things, the thread lists some issues with SuperSU, which in combination with the phrase The developer also requests users to not bug Chainfire with compatibility requests for SuperSU with Magisk from the portal article, raised my left eyebrow by nigh half an inch. The popular systemless xposed mod is apparently now based on it, and apparently it now no longer works with SuperSU, and apparently I'm not supposed to fix that, nor any of the other found issues. I found that a bit weird. So yes, I have told @topjohnwu that I was a bit surprised he was posting about issues with SuperSU without notifying me about them (I can't fix or help fix issues I'm not aware of, after all).
He's also spreading a modified version of the SuperSU package, which is not all that uncommon, nor necessarily a problem. I have not looked into what he modified, I only ran a few quick tests on one of my devices, and found some commonly used commands run as root to be broken. I have informed him of this as well.
It appears the tool of choice for Magisk is phh's Superuser, because of some of the mentioned issues with SuperSU. That's fine by itself, but fixing issues in that superuser by incorporating SuperSU's binaries into it is a somewhat questionable practise. After all, SuperSU is a commercial closed-source package that helps pay for my dinner, and superuser is a direct competitor. I have informed him that I was surprised he did this without asking for permission. I have expressed similar surprise on him spreading a modified version of LiveBoot (which helps pay for a snack now and then).
@topjohnwu has also stated that Magisk's scripts are largely influenced by mine (I have not checked). Scripts based on mine are used all over the place on XDA, some people have crafted amazing things based on them, I have never made an issue of this (otherwise I would have just made them binaries). But yes, I have also stated to him that I don't think it's very nice to base something on one program, and then using that to (almost exclusively) push something directly competing with that program.
tl;dr Towards @topjohnwu, I have:
- expressed surprise he has issues getting Magisk to work with SuperSU, and has chosen not to inform me about those
- expressed surprise he is using SuperSU binaries in a competing superuser without permission
- expressed surprise he is posting a modified LiveBoot without permission
- informed him of issues with the modified SuperSU he has posted
- let him know I thought it wasn't very nice to be applying my scripts to benefit seemingly exclusively that same competing superuser
To be crystal clear:
- I have not asked for an apology
- I have not asked for Magisk to be abandoned, neither the root hiding nor systemless module parts, and certainly not systemless xposed
- I have not made an issue of any of this anywhere, until this post
- I have not even specifically asked for anything to be taken down (though obviously in my opinion the other superuser package mixed with SuperSU's binaries, as well as the LiveBoot package, should go)
- I have not reported this thread to XDA moderators for copyright violations or otherwise
While my conversation with @topjohnwu may not win any awards for being friendly (though it may win some for brevity), I think all things considered my response has been rather mild. To be perfectly honest, until the apology post, I thought this was over with already. I think the apology post was triggered because I haven't replied to his last PM for a while - I was in the zone, it happens.
To emphasize again, I have nothing against @topjohnwu, Magisk, or systemless xposed, and it is certainly not my goal to see any of them go. If it can be made to work together with SuperSU, great.
I get it though: you think of something, you want to see if you can make it work, you finally get it to work, you publish it, it takes off - enthusiasm gets the better of you. Maybe in the rush some mistakes are made. That doesn't mean you have to just drop it and run. None of my stuff would make it past 0.1 if I stopped at the first big mistake
Aside from said being in the zone coding, I usually regret actually responding to these sort of things the day after, which has made me hesitant to reply. Surprise me.76Thread temporarily closed so everyone sees this.
The flood of "SafetyNet isn't working for me either!" posts are not helpful, at all. Please refrain from posting further, it will be looked into. Please do not forget that not passing SafetyNet is 100% NORMAL AND INTENDED when you have an unlocked booloader or running custom firmware. These are workarounds and they will be worked around in turn.
The Flash
Forum Moderator
EDIT: Thread is reopened... I will be cleaning any SafetyNet posts for a while to keep the thread clean for real issues.75Hello everyone!
I am aware that Google has updated Safety Net that makes Magisk itself a no go for Android Pay. In fact, I witnessed the change live while I am developing the new magiskhide, which should hide all Magisk modules and Magisk installed root.
Google is serious about Safety Net now, clearly hunting down all possibility to run Xposed with Safety Net passed. I spend quite some time examining the new security measures last midnight, and fortunately it seems that it is possible to run Magisk and root along with Safety Net if no Xposed is running. I'm glad I removed the old root toggle at the right time lol, that is no longer feasible with the latest detection.
So stay tuned for the next update, it will come with bug fixes, along with the new magiskhide to bypass that Safety Net.
Google, how will a few systemless mods do any harm
