Magisk General Support / Discussion

Search This thread
By:
Advanced…
zgfg

zgfg

Senior Member
Oct 10, 2016
8,962
6,690
Redmi K20 / Xiaomi Mi 9T
Xiaomi Mi 11 Ultra
Robbo.5000 said:
Am I right I assuming?
Blacklist mode = hide apps blacklisted from every other app that asks for an applist
Whitelist mode = do not give an applist (or give an empty applist) to any app in the Whitelist
Click to expand...
Click to collapse
Whitelist (I don't have a template) as on my screenshot

Blacklist, with Blacklist template, as described in the HMA Guide thread (actually, it's OP post #1 now points to the HMA Guide on GitHub)
 
  • Like
Reactions: ipdev
R

Robbo.5000

Senior Member
Dec 8, 2016
1,124
749
Xiaomi Mi Pad 4
Xiaomi Redmi Note 6 Pro
zgfg said:
Whitelist (I don't have a template) as on my screenshot

Blacklist, with Blacklist template, as described in the HMA Guide thread (actually, it's OP post #1 now points to the HMA Guide on GitHub)
Click to expand...
Click to collapse
Ok thanks and thanks to @pndwal also. I've installed it and got it configured. Everything's working fine and no more freezing and unfreezing apps.
 
Spartacus500

Spartacus500

Senior Member
Nov 6, 2014
690
135
pndwal said:
My device:
Xiaomi RN8T stock A11 MIUI
Magisk Canary 25209
Latest Shamiko public release (for proper root hiding]
[LSPosed Hide My AppList, but not needed for this app]

This app is detecting OEM unlocking when enabled in Developer options (even if enabled with developer options disabled)... With the above setup I get:
View attachment 5872335
With OEM unlocking disabled:
View attachment 5872341
... It's not detecting USB debugging or Developer Options itself...

I have disabled OEM unlocking on my device and rebooted and all is fine... While I believe this is normally safe with the important exception of Magisk use with relocked bootloader (ie. with custom keys set to allow relocking with custom mods incl. Magisk etc), I'm not certain of this... Others may like to verify the safety of disabling OEM unlocking with normal (unlocked device) Magisk use...

The App can be used by disabling OEM unlocking before a reboot however, so you can always enable it again before a reboot...

Hope this fixes your issue! 👍 PW
Click to expand...
Click to collapse
OEM Unlocked and OEM Locked on Samsung S7 9.0 nothing helps for Yes bank, it seems to detect invalid certificate 🤔
 

Attachments

  • Screenshot_20230326-195346_YES Bank.jpg
    Screenshot_20230326-195346_YES Bank.jpg
    412.2 KB · Views: 55
  • 20230326_203408.jpg
    20230326_203408.jpg
    175.7 KB · Views: 55
  • Like
Reactions: pndwal
K

kullurumanoj

Senior Member
Aug 10, 2014
53
22
Hyderabad
pndwal said:
My device:
Xiaomi RN8T stock A11 MIUI
Magisk Canary 25209
Latest Shamiko public release (for proper root hiding]
[LSPosed Hide My AppList, but not needed for this app]

This app is detecting OEM unlocking when enabled in Developer options (even if enabled with developer options disabled)... With the above setup I get:
View attachment 5872335
With OEM unlocking disabled:
View attachment 5872341
... It's not detecting USB debugging or Developer Options itself...

I have disabled OEM unlocking on my device and rebooted and all is fine... While I believe this is normally safe with the important exception of Magisk use with relocked bootloader (ie. with custom keys set to allow relocking with custom mods incl. Magisk etc), I'm not certain of this... Others may like to verify the safety of disabling OEM unlocking with normal (unlocked device) Magisk use...

The App can be used by disabling OEM unlocking before a reboot however, so you can always enable it again before a reboot...

Hope this fixes your issue! 👍 PW
Click to expand...
Click to collapse
So, disabling the oem unlocking worked for me. Will that the be an issue if I reboot my device?
zgfg said:
No warning or error whatsoever (Magisk Delta, Zygisk and SuList, App data isolation and Reset sensitive props - with Developer options, OEM Unlocking, USB Debugging and Accessibility enabled)

Cannot proceed (not having the account)
Click to expand...
Click to collapse
Installing safetynet sensitive prop module worked for me. Thanks all for the help!
 
P

pndwal

Senior Member
Jun 23, 2016
6,334
7,129
Sydney
Redmi Note 8
Xiaomi Redmi Note 8 (2021)
J.Michael said:
I believe that is wrong: "/data/adb" isn't mounted, it just is.
Click to expand...
Click to collapse
Magisk Magic Mask (overlay) works when "module files are magic mounted".
https://topjohnwu.github.io/Magisk/details.html#post-fs-data 😉

Modules are mounted as /system overlays to function... Specifically module directories as
system <--- This folder will be mounted if skip_mount does not exist
https://topjohnwu.github.io/Magisk/guides.html#magisk-modules

Other files are mounted too:
https://topjohnwu.github.io/Magisk/details.html#paths-in-magisk-tmpfs-directory

So if content in /data/adb is not mounted, Magisk (Mask) is not working...
J.Michael said:
If you believe that "/data/adb" is mounted, then from where do you believe it is mounted?
Click to expand...
Click to collapse
Use
Magisk --path to print Magisk tmpfs mount path

Incidentally, much refactoring of Magisk mount is being done ATM... We recently got:
Refactor magic mount to support overlayfs
and other commits will ensure better module compatibility incl. proper ability to systemlessly remove directories etc...

🤠PW
 
Last edited:
P

pndwal

Senior Member
Jun 23, 2016
6,334
7,129
Sydney
Redmi Note 8
Xiaomi Redmi Note 8 (2021)
WoKoschekk said:
That's not correct. The folder /data/adb does always exist on all Android distributions. But its content will be "erased" (or will not be mounted) without a Magisk patched boot.img. Booting a stock boot.img will result in a empty /data/adb folder.
Click to expand...
Click to collapse
Some systems (ROMs) may sanitize this location much as they do with/system files at boot time, but most do not AFAIK...

/data/adb content is generally preserved even with stock boot.img loaded, and many of us rely on this for module and configuration survival... Booting a stock boot.img will generally not result in an empty /data/adb folder... 🙃 PW
 
  • Like
Reactions: J.Michael
D

dcarvil

Senior Member
Apr 20, 2016
672
374
J.Michael said:
I believe that is wrong: "/data/adb" isn't mounted, it just is.

If you believe that "/data/adb" is mounted, then from where do you believe it is mounted?
Click to expand...
Click to collapse
~ $ mount | grep adb
adb on /dev/usb-ffs/adb type functionfs (rw,relatime)
/dev/block/dm-0 on /apex/com.android.adbd type ext4 (ro,relatime,seclabel)
/dev/Zcr/.magisk/block/system_root on /system/bin/badblocks type ext4 (ro,relatime,seclabel)
~ $
 
P

pndwal

Senior Member
Jun 23, 2016
6,334
7,129
Sydney
Redmi Note 8
Xiaomi Redmi Note 8 (2021)
zgfg said:
Zero (like not enabled)

I think, it's due to Reset sensitive props module
Click to expand...
Click to collapse
So that would explain it anyway... Something is forcing sys.oem_unlock_allowed = 0 regardless of Developer option setting...

On my device I get sys.oem_unlock_allowed = 1 as soon as OEM unlocking is enabled in Developer options...

As I mentioned, this forced prop was considered for USNF but rejected due to producing misleading Developer option state:
https://github.com/kdrag0n/safetynet-fix/pull/240#issuecomment-1368867689

@huskydg originally cautioned against this, but some module may be doing that, what he suggested here
https://github.com/kdrag0n/safetynet-fix/pull/240#issuecomment-1368497042
or other...

One instance where such a misleading Developer option state could be disastrous is if a user (especially Pixel or OnePlus) re-locks bootloader with custom mods and custom keys, eg using avbroot script w/ Magisk... Whether mislead by false Developer options or not, you know of this case where a member recently hardbricked Pixel 6 Pro with no known way to recover:
https://forum.xda-developers.com/t/...third-party-magisk-fork.4460555/post-88327781

😶 PW
 
zgfg

zgfg

Senior Member
Oct 10, 2016
8,962
6,690
Redmi K20 / Xiaomi Mi 9T
Xiaomi Mi 11 Ultra
Magisk Delta with SuList, no need to prepare anything before testing

Finding only ReVanced YT (module) - first screenshot, second with RV disabled

Edit: Download from Magikisune
 

Attachments

  • Screenshot_2023-03-28-08-54-39-319_io.github.huskydg.memorydetector.jpg
    Screenshot_2023-03-28-08-54-39-319_io.github.huskydg.memorydetector.jpg
    266.7 KB · Views: 95
  • Screenshot_2023-03-28-08-44-51-347_io.github.huskydg.memorydetector.jpg
    Screenshot_2023-03-28-08-44-51-347_io.github.huskydg.memorydetector.jpg
    164 KB · Views: 94
  • Screenshot_2023-03-28-09-53-03-661_org.telegram.messenger.jpg
    Screenshot_2023-03-28-09-53-03-661_org.telegram.messenger.jpg
    673.8 KB · Views: 90
Last edited:
Mrbally123

Mrbally123

New member
Mar 28, 2023
1
0
I use Magisk to hide the rooted status for an app, on my samsung a21s, after the process my sim card shows emergency calls only
 
J

J.Michael

Recognized Contributor
Jan 20, 2018
1,815
2,060
Samsung Galaxy Tab A series
Mrbally123 said:
I use Magisk to hide the rooted status for an app, on my samsung a21s, after the process my sim card shows emergency calls only
Click to expand...
Click to collapse
Is there any way to test whether it can really make an emergency call without actually making an emergency call?

Did you add the name of the app to a list, like Hide List, Deny List,...? Are you using HMA? Did you add the app to HMA's list?

What I am really working towards is, did you maybe add other, especially system, apps to a list? You probably shouldn't.
 
You must log in or register to reply here.

Similar threads

T
  • Locked
  • Sticky
Magisk - The Magic Mask for Android
Replies
56
Views
6M
T
topjohnwu
T
  • Locked
[CLOSED][BETA][2018.7.19] Magisk v16.7 (1671)
Replies
7K
Views
3M
T
topjohnwu
Heisenberg
[Discussion] PokeMon Go Magisk Discussion Thread
Replies
5K
Views
636K
djkrish5610
djkrish5610
Didgeridoohan
[Discussion] Google Pay Magisk Discussion Thread
Replies
3K
Views
533K
T
TurboLed
yochananmarqos
  • Sticky
Collection of Magisk Modules v2
Replies
1K
Views
1M
J
jacomail95

Top Liked Posts

24 Hours 30 Days All time
  • 4
    chazall1
    chazall1
    https://forum.xda-developers.com/t/...r-root-pixel-7-pro-cheetah-safetynet.4502805/

    VERY IMPORTANT - On the Pixel 7/Pro, we use Magisk to patch init_boot.img, NOT boot.img AND we flash the patched init_boot to the init_boot partition - do not flash it to the boot partition.​

    View
    2
    zgfg
    zgfg
    ipdev said:
    "New magisk tmp dir: /debug_ramdisk"
    Magisk - [GitHub] - commit

    Example: Pixel 3a Lineage 19.1
    Code: 
    bonito:/ $ magisk -v
c79bc8327-ip:MAGISK:R
bonito:/ $ magisk -V
26102
bonito:/ $ magisk --path
/debug_ramdisk
bonito:/ $ ls -la debug_ramdisk/
ls: debug_ramdisk/: Permission denied
1|bonito:/ $ su -c ls -la debug_ramdisk/
total 1408
drwx--x--x  5 root root    260 2023-05-30 20:21 .
drwxr-xr-x 26 root root   4096 2023-04-22 18:55 ..
drwxr-xr-x 11 root root    260 2023-05-30 20:21 .magisk
drwxr-xr-x  2 root root     80 2023-05-30 20:21 dex2oat
lrwxrwxrwx  1 root root     10 1974-02-05 10:08 magisk -> ./magisk64
-rwxr-xr-x  1 root root 164200 1974-02-05 10:08 magisk32
-rwxr-xr-x  1 root root 259984 1974-02-05 10:08 magisk64
-rwxr-x---  1 root root 657224 1974-02-05 10:08 magiskinit
-rwxr-xr-x  1 root root 345584 2023-05-30 20:21 magiskpolicy
lrwxrwxrwx  1 root root      8 1974-02-05 10:08 resetprop -> ./magisk
drwxr-xr-x  2 root root     80 2023-05-30 20:21 shamiko
lrwxrwxrwx  1 root root      8 1974-02-05 10:08 su -> ./magisk
lrwxrwxrwx  1 root root     14 1974-02-05 10:08 supolicy -> ./magiskpolicy
bonito:/ $

    Not sure if it helps but, that was the change.
    ¯\_(ツ)_/¯

    Cheers. :cowboy:
    Click to expand...
    Click to collapse
    Apparently, there was also a change in the $MAGISKTMP variable (available during the Installation of Magisk modules):
    In Magisk v26 it points to magisk --path (the new path), in the older Magisk versions it pointed to the subfolder .magisk of the old magisk --path

    Nevertheless, I made the modifications that both AML and JamesDSP modules can now work also on Magisk v26 (zip installations attached in the quoted post):
    https://forum.xda-developers.com/t/jamesdsp-audio-manager-mmt-ex.3607970/post-88598223
    View
  • 8
    P
    pndwal
    Thehaluzer said:
    Hello!
    How do you know?
    You must be an expert or something
    Click to expand...
    Click to collapse

    Nigerian-Meme.jpg 😜 PW
    View
    7
    ipdev
    ipdev
    ephemunch said:
    As I expected in advance, problems with Magisk occurred after the OTA update of LineageOS (Pixel 6a).
    Updated from a 20.0 build to lineage-20.0-20230429-nightly-bluejay

    After the update it was necessary to flash the new boot image again. I have done that. But Magisk simply does not root. Magisk patched the downloaded LineageOS boot-image, saved it in the download folder and that was it.

    Magisk was hidden before I did OTA update.
    Simply very beautiful. All this after setting up LineageOS to my liking.
    And what can I do now except re-flash ROM?
    Click to expand...
    Click to collapse

    You might be interested in this.

    If you are using the current Magisk canary build, addon.d support was fixed.
    A few weeks ago, I tested it on my Pixel 3a and made a post in The Age of Zygisk thread.
    Post #3,128

    Since I did not install Magisk via recovery, I made a module that overlays Magisk's addon.d script into the system/addon.d directory.
    The module is not necessary after the first OTA.
    - The OTA updater will actually restore the Magisk script into system with the others.

    Magisk Survival Module - [GitHub] - Link
    Please read all of the readme if you decide to use it.
    - This only works with addon.d-v2 (A/B slot devices).

    Cheers. :cowboy:

    PS.
    I have updated my 3a using the OTA updater 4/5 times now and Magisk is retained each time.
    No need to manually patch and flash the new boot image after update.
    View
    7
    badabing2003
    badabing2003
    Lughnasadh said:
    Yeah, if I want to run a custom kernel (Pixel 7) then I need to wipe. Should have sideloaded (not booted up), then gone into bootloader and run fastboot flash vbmeta --disable-verity --disable-verification vbmeta.img to that slot. Once booted after sideload/flashing the firmware it's too late as it's enabled after booting. Don't think it matters if you do it before or after flashing the patched image, just as long as you do it before you boot up. Oh well, lol...

    Nothing to do with what we were testing, just custom kernel related. Seems to also help to avoid getting the red eio corrupt message when things may not go as expected.
    Click to expand...
    Click to collapse
    Thanks, I realize it is only needed for custom Kernel cases.
    I should add extracting vbmeta from payload.bin then in addition to boot.img / init_boot.img so that the step can be performed if the options are selected.
    View
    7
    Lughnasadh
    Lughnasadh
    andy242 said:
    So as well as making it easier to keep root with an ota we can have the same firmware on the device one rooted and one not? So if magisk hide/safetynet/etc aren't working we can boot to the non rooted firmware to use wallet/banking apps etc and then boot back to rooted. Or is it a bit more complicated than that? Never had a pixel device before
    Click to expand...
    Click to collapse
    Others have already addressed your question, but for me, the biggest benefit here is to have a safety valve in place where your inactive slot is bootable (without first having to flash the firmware) in case you get into a hairy situation where your active slot becomes unbootable for whatever reason. May be useful in some situations.
    View
    7
    osm0sis
    osm0sis
    J.Michael said:
    If the "issue" is that you have not yet been able to reproduce the Magisk manager app's "Ramdisk: Yes/No":

    Did you try a "wrapper" for the shell script function you found? At the time you reported several script fragments, there was talk of needing to call other functions first to set up environment variables.

    Look up the "echo" command. There is a form that causes the shell to echo all lines as they are executed. Do this, redirect output to a log file, and you can crawl through and maybe spot where it first disappoints you.
    Click to expand...
    Click to collapse

    I believe "needing to call other functions first to set up environment variables" is exactly why he is getting a different result from the app. 👍

    I could gut out all the relevant bits for him to run, but, not trying to offend here, I kind of don't see what the point of all this has been, so I don't think I can justify putting in that amount of effort when I've got my own stuff to be doing... 🫤

    Edit: One final thought. It could also be that he needs to use Magisk's busybox and busybox ash env for some of the commands like Magisk would be to get the intended output.

    badabing2003 said:
    I'm running into an interesting problem that I can't put my fingers on, and am open to ideas / suggestions.
    As you may already know, Magisk embeds the SHA1 of the stock boot image used to create the patch into the patched image, this is great because one can easily determine the source image that was used and validate if it is what it is supposed to be.

    And this is exactly what PF does, it extracts the SHA1 from the patched image.
    Here's the function code
    Python: 
    def extract_sha1(binfile, length = 8):
    with open(binfile, 'rb') as f:
        s = f.read()
        # Find SHA1=
        pos = s.find(b'\x53\x48\x41\x31\x3D')
        # Move to that location
        if pos != -1:
            # move to 5 characters from the found position
            f.seek(pos + 5, 0)
            # read length bytes
            res = f.read(length)
            return res.decode("utf-8")

    Unlike magiskboot and Android Kitchen Tools by @osm0sis which extracts the ramdisk.cpio and performs magiskboot cpio <ramdisk.cpio> sha1 on it, PF (to keep it lightweight) it just looks for the string SHA1= directly on the patched file and then reads the next 8 hex characters and converts them to ascii.
    And this has worked flawlessly so far, until this.
    Basically what is happening is:
    The expected embedded SHA1 is: 40100d6b9512f6dffbb6f6b67c1b878f3bd82d18

    With the exception of the red part of the SHA1, everything matches.
    In one case 0100 part which is expected to be 30 31 30 30 hex it is instead 89 00 FB 33, and in the other case it is 72 00 FC 15

    View attachment 5902493View attachment 5902495


    I don't understand why this is happening, my first guess would be some kind of encoding, but then why now and only with this image, my other guess / fear is that perhaps the writing is not clean which would be a bug in Magisk.
    Obviously I can skip over the first few bytes and do the validation with the remaining bytes, but I'd hate to take a path like that without understanding why this is happening, who's to say that this thing can't happen on the other portions of the SHA1 string.

    If you have any ideas, I'm all ears.
    Click to expand...
    Click to collapse

    The boot.img contains the ramdisk.cpio.gz/.lz4/.lzma/.xz and while text strings may get stored as-is in a compression format, that isn't guaranteed and the compression might find something it thinks it can "optimize" for space savings. That's why `magiskboot cpio <file> sha1` is run on the uncompressed ramdisk.cpio. 🙂
    View
  • 1094
    T
    topjohnwu
    This is the place for general support and discussion regarding "Public Releases", which includes both stable and beta releases.
    All information, including troubleshoot guides and notes, are in the Announcement Thread
    View
    156
    T
    topjohnwu
    Hello, I haven't given much support on XDA lately. It can be resulted from
    • University started and I have limited free time. In fact, I mostly develop during midnight
    • I live in Taiwan, which has large time zone differences between my European/American contributors/testers, which usually forces me to stay up late at night to discuss/test stuffs.
    • The new version is about to come, I don't want to spend effort on supporting old releases
    The planned update is delayed again and again, to some point I think I'll shed some light about what has been happening lately, also along with some announcements.

    New Forum!
    As you might have already discovered, Magisk got its own subforum on XDA! Many thanks to all the support you gave me, and much more information/features/support is about to come!
    **For developers supporting all the devices that are not using standard Android boot format, feel free to create threads in this section (actually, PLEASE do so) for your favorite devices after v7 is out. As I currently know, Asus devices require signing the boot image before flashing, and is model dependant; Sony devices seems to use ELF kernel that is unpatchable, or some has two ramdisks (inner + outer), both requires different workarounds; LG bootloader locked devices has to manually "BUMP" the boot image after flashing Magisk..... and there may be lots of other crazy boot image formats that haven't come up to my attention yet.
    It is impossible for me to support all these non-standard boot images, and I hope the community can collaborate to make Magisk running across all the devices. Overall, community collaboration is what XDA about :D

    The Pixel Phone
    Some of you might already know this news, that the next Pixel Phone right around the corner seems like it does not have ramdisk in boot image, which pretty much wrecked Magisk in all ways. However, it pretty much doomed root itself too. Kernel modifications is inevitable IMO, so I'll try to migrate my scripts to C programs that could possibly be included into the kernel itself. Note that I'm not familiar with linux kernel, I'm not even sure if my idea and concept is correct or not. But once the device is available, I think developers will find a way to bypass all the difficulties, and I'll do my best to learn things ;)

    Current Progress
    In the past month, I've spent quite some time learning SELinux, so that I can avoid using SuperSU's sepolicy patches. Thanks to the helps and tips from @phhusson and @Chainfire, I finally have a much clearer understanding of how SELinux works. The Magisk core parts (the scripts, boot image patches, new features, more supports) are actually done some time ago. What is causing all the delays is the Magisk Manager.
    To be completely honest, although I can code in Java without much issues, Magisk Manager is actually my first Android application, I had to reach out for assistance, and fortunately awesome developers like @DVDandroid and @digitalhigh contributed a lot, which makes the current Manager awesome.
    After the repo system and module management is mostly done, I was about to do some adjustments and release, but what we really done is decided to add another feature: auto-unroot with per-app settings. I decided to wait for it to be finished, and then do my adjustments. Due to reasons that'll be mentioned later, this feature will likely not be available for the next release (should come in future updates)

    Safety Net Disaster
    Those who are using Magisk for Safety Net bypass purposes must have known that Google recently updated the detection method of my Systemless Xposed. I still have no idea what Safety Net is detecting, so currently I cannot fix it on my side (also because I'm busy working on the next update). However, suhide developed by @Chainfire is able to hide Xposed and worked fine.
    However, only my Systemless Xposed v86.2, which is based on SuperSU's su.d, is supported using that method. v86.2 and v86.5 (latest, Magisk based) have nearly identical binaries, and the only difference is the path where the binaries are stored.
    I'm still not sure what's the real issue for it not being supported, I just hope it is not done intentionally.

    Conclusion
    Due to the fact that my Safety Net bypass is not 100% perfect now, I do not want to spend any more time waiting for auto-unroot to be polished. What I'm doing now is finishing up all the things I'd like to change in Magisk Manager (it has been a while since I last contributed to Manager, my fellow developers are doing all the heavy job), which might take a little more time, after that, packed with tons of information to be announced in Magisk Section, I'll release the long awaited update.

    Hope this lengthy post gives you the idea of the whole situation, and again thanks for all your support!!
    View
    121
    Chainfire
    Chainfire
    Ah, some Chainfire bashing, I hope it is not too late for me to exercise additional villainy.

    First, let me make clear I have nothing against @topjohnwu, nor against Magisk. Magisk is an interesting project and it certainly displays @topjohnwu ingenuity and persistence. I don't doubt we will see more interesting things from his hands.

    -------------------------

    What has happened here is not all that dark and complicated, from either end. I returned from holidays, and someone pointed me at Magisk. My first thought: interesting!

    Among other things, the thread lists some issues with SuperSU, which in combination with the phrase The developer also requests users to not bug Chainfire with compatibility requests for SuperSU with Magisk from the portal article, raised my left eyebrow by nigh half an inch. The popular systemless xposed mod is apparently now based on it, and apparently it now no longer works with SuperSU, and apparently I'm not supposed to fix that, nor any of the other found issues. I found that a bit weird. So yes, I have told @topjohnwu that I was a bit surprised he was posting about issues with SuperSU without notifying me about them (I can't fix or help fix issues I'm not aware of, after all).

    He's also spreading a modified version of the SuperSU package, which is not all that uncommon, nor necessarily a problem. I have not looked into what he modified, I only ran a few quick tests on one of my devices, and found some commonly used commands run as root to be broken. I have informed him of this as well.

    It appears the tool of choice for Magisk is phh's Superuser, because of some of the mentioned issues with SuperSU. That's fine by itself, but fixing issues in that superuser by incorporating SuperSU's binaries into it is a somewhat questionable practise. After all, SuperSU is a commercial closed-source package that helps pay for my dinner, and superuser is a direct competitor. I have informed him that I was surprised he did this without asking for permission. I have expressed similar surprise on him spreading a modified version of LiveBoot (which helps pay for a snack now and then).
    @topjohnwu has also stated that Magisk's scripts are largely influenced by mine (I have not checked). Scripts based on mine are used all over the place on XDA, some people have crafted amazing things based on them, I have never made an issue of this (otherwise I would have just made them binaries). But yes, I have also stated to him that I don't think it's very nice to base something on one program, and then using that to (almost exclusively) push something directly competing with that program.

    tl;dr Towards @topjohnwu, I have:
    - expressed surprise he has issues getting Magisk to work with SuperSU, and has chosen not to inform me about those
    - expressed surprise he is using SuperSU binaries in a competing superuser without permission
    - expressed surprise he is posting a modified LiveBoot without permission
    - informed him of issues with the modified SuperSU he has posted
    - let him know I thought it wasn't very nice to be applying my scripts to benefit seemingly exclusively that same competing superuser

    To be crystal clear:
    - I have not asked for an apology
    - I have not asked for Magisk to be abandoned, neither the root hiding nor systemless module parts, and certainly not systemless xposed
    - I have not made an issue of any of this anywhere, until this post
    - I have not even specifically asked for anything to be taken down (though obviously in my opinion the other superuser package mixed with SuperSU's binaries, as well as the LiveBoot package, should go)
    - I have not reported this thread to XDA moderators for copyright violations or otherwise

    While my conversation with @topjohnwu may not win any awards for being friendly (though it may win some for brevity), I think all things considered my response has been rather mild. To be perfectly honest, until the apology post, I thought this was over with already. I think the apology post was triggered because I haven't replied to his last PM for a while - I was in the zone, it happens.

    To emphasize again, I have nothing against @topjohnwu, Magisk, or systemless xposed, and it is certainly not my goal to see any of them go. If it can be made to work together with SuperSU, great.

    I get it though: you think of something, you want to see if you can make it work, you finally get it to work, you publish it, it takes off - enthusiasm gets the better of you. Maybe in the rush some mistakes are made. That doesn't mean you have to just drop it and run. None of my stuff would make it past 0.1 if I stopped at the first big mistake :)

    Aside from said being in the zone coding, I usually regret actually responding to these sort of things the day after, which has made me hesitant to reply. Surprise me.
    View
    76
    nathanchance
    nathanchance
    Thread temporarily closed so everyone sees this.

    The flood of "SafetyNet isn't working for me either!" posts are not helpful, at all. Please refrain from posting further, it will be looked into. Please do not forget that not passing SafetyNet is 100% NORMAL AND INTENDED when you have an unlocked booloader or running custom firmware. These are workarounds and they will be worked around in turn.

    The Flash
    Forum Moderator

    EDIT: Thread is reopened... I will be cleaning any SafetyNet posts for a while to keep the thread clean for real issues.
    View
    75
    T
    topjohnwu
    Hello everyone!

    I am aware that Google has updated Safety Net that makes Magisk itself a no go for Android Pay. In fact, I witnessed the change live while I am developing the new magiskhide, which should hide all Magisk modules and Magisk installed root.

    Google is serious about Safety Net now, clearly hunting down all possibility to run Xposed with Safety Net passed. I spend quite some time examining the new security measures last midnight, and fortunately it seems that it is possible to run Magisk and root along with Safety Net if no Xposed is running. I'm glad I removed the old root toggle at the right time lol, that is no longer feasible with the latest detection.

    So stay tuned for the next update, it will come with bug fixes, along with the new magiskhide to bypass that Safety Net.

    Google, how will a few systemless mods do any harm :p:p
    View

New posts