Magisk General Support / Discussion
- Thread starter topjohnwu
- Start date
DenyList, Magisk Hide module (find the link, etc, among previous posts)For me, the application does not open at all, as if it detects the zygisk process
After updating opened fine for me but on running Play Integrity Check I got:
... Cleared all app data... Seem to get more invasive (annoying) adds now, plus is this new?:
... Selected Don't Allow and ran Play Integrity Check again... All fine now... (Only strongIntegrity and virtualIntegrity red... All green for Root and Xposed checks.)
Suggest clearing data as seems updated app may not play nicely with old config data... PW
Last edited:
Updated yesterday to v2.5.5.... after getting Play Store notification. After a while, just ran the app and everything was okay. (Cleared nothing.)
Attachments
I did everything, TB checker still doesn't work, open error, I found this info in the Cat log
Attachments
But today, got a message saying 'app is not official'. Went to Play Store and updated again to v2.5.7.... All fine now. WTH!
Attachments
Assuming Play Store is still working fine, are you running Hide My Applist, PrivacySpace or similar Xposed/Magisk modules?... Are you hiding Play Store in any templates, in 'apps invisible' or in other hide lists? PWI did everything, TB checker still doesn't work, open error, I found this info in the Cat log
In HMA, I only have 2 apps hidden in the Google Play Store, Lucky Pacher and HManager, nothing else. I completely do not understand why after today's update of TB checker the application does not work at all, error open app ... Yesterday on the previous version it worked normally
I'm not clear what "hidden in the Google Play Store" means... As I asked, do you have Play Store itself in any templates or 'apps invisible' lists?...In HMA, I only have 2 apps hidden in the Google Play Store, Lucky Pacher and HManager, nothing else. I completely do not understand why after today's update of TB checker the application does not work at all, error open app ... Yesterday on the previous version it worked normally
Clearly from your screenshot, TB Checker can't find Play Store... That's why I suspected app hiding... May be some other mod setting or anomaly on your system also... PW
Last edited:
No ads with AdAway
Attachments
I had a suspicion this was going to happen.
This was posted in the Delta Telegram group:
This was posted in the Delta Telegram group:
Last edited:
Now it sees google play store but TB checker still not working
. It remains to wait for the next update, and if there is still an error open TB checker, it remains to completely remove Magisk root and check if this application will start working. Unfortunately, I don't see any other option .
Assuming that the TG message is not an April fool's joke ...
This would be very sad news! Magisk Delta seems to be the most reliable and functional version.
Because of the complexities and headaches involved with trying to use later versions of Magisk and Android, I have been holding off on upgrading beyond Android 11, where I can still run TWRP and Magisk 23.0. However, I have been considering going to Android 12 or 13, and Magisk Delta would have been my Magisk choice.
If this situation remains the same on April 2nd, I will have then lost my desire to upgrade.
Last edited:
Past midnight in Japan, Apr 2 - the post is crossed on TG
Attachments
So april fools then? Lol odd joke.Past midnight in Japan, Apr 2 - the post is crossed on TG
Please explain "2 apps hidden in the Google Play Store".Now it sees google play store but TB checker still not working
The HManager app for the Huawei router and Lucky Patcher is detected as a malicious app in the Google Play store, so I hide these two apps in the HMA for the Google Play store.
I have installed exactly the same version as you, I have open TB checker error all the time... Something is blocking the application from starting, but I have no idea what.
Try without lucky patcher installed it's known to be a factor in root detection (i know it's in HMA but might still be an issue.
I have been visiting with an old friend who lives now in Florida today and didn't even think about the fact that it is indeed, April fool's day, lol!Past midnight in Japan, Apr 2 - the post is crossed on TG
Similar threads
Top Liked Posts
-
2
No, I have no idea.(other than what I answered earlier).
And still no idea which app you tried in DenyList that it crashed
Btw, if you want to access developers (and give them the logs), you will need to submit an Issue to Magisk GitHub2
Tried Canary?...
Strange issue (may be fixed already though)...
However denylist is not really for hiding, rather it's a development/testing tool...
Suggest using a proper hiding solution like Shamiko; uses denylist as hidelist for convenience (with DenyList actually disabled)... Much better hiding (akin to/improved on MagiskHide) and doesn't break Zygisk modules that inject into apps in deny/hidelist...
Personally I'd give Canary a shot first... You can't even make a GitHub issue without trying latest builds (nb. Canary release and Debug debug are synced builds)... PW2
Seems DFU is Device Firmware Upgrade mode in IOS devices... Guess you mean fastboot or download mode?
Checked, and seems nothing's been reported in GitHub issues for your device... Very little for ZTE at all...
If you want to make an official issue, Devs will likely close it if it's related to an unofficial ROM or kernel, so you'd need to have tried latest Magisk builds (they won't bother testing with older builds/logs) w/ clean Magisk configuration on stock (recommend latest available) ROM (I think your Mifavor ROM is custom?).
If you haven't already, I suggest a simple test:
Uninstall any Magisk App/Manager, wipe everything in /data/adb using file explorer in TWRP (to remove possibly corrupted Magisk configuration), dirty flash your current ROM to restore any changed images incl. /boot partition (you can keep or restore TWRP as recovery) then download latest Canary Magisk, change file extension from .apk to .zip and flash this from TWRP, boot to system and check if Magisk App or Magisk stub app has been installed an either open it and follow prompts to complete installation and re-flash Magisk from booted system (now needed to set up selinux/module rules directory), or restore package extension from .zip to .apk, install App and follow prompts to complete installation...
if it doesn't work, flash stock ROM (Preferably back up data an clean install) and try again...
if still no dice, extract the stock boot.img (must be from current ROM), patch this in App and flash using PC/fastboot and complete steps above...
If nothing works, repeat using Debug Magisk (needed for proper verbose logs when making an issue) and take logs, then make an official GitHub issue taking care to follow the prescribed template or issue may be closed...
PW2
As I said it doesn't matter which app you put in denylist. Put there google play services and it will crash over and over after boot (as it's invoked a lot). If you put in there banking app, you can't run it - it will allways crash. Any app in the list crashes every time you run it. The minute you remove it from denylist or stop enforcing it, the apps go back to running fine. I went back to 25.2 and denylist works normaly, nothing crashes.
Hope it's understood.1
Tnx mate for the reply.
1. I have no modules installed.
2. I have put just one app in denylist to demonstrate. Any app (all of them) in denylist will crash, so I can't use denylist at all :-( .
3. Magisk 25.2 works just fine, I don't even need to hide apps to pass safetynet. No crashes at all for apps in denylist!
Any ideas what's wrong ? -
8
Others have already addressed your question, but for me, the biggest benefit here is to have a safety valve in place where your inactive slot is bootable (without first having to flash the firmware) in case you get into a hairy situation where your active slot becomes unbootable for whatever reason. May be useful in some situations.87
Thanks, I realize it is only needed for custom Kernel cases.
I should add extracting vbmeta from payload.bin then in addition to boot.img / init_boot.img so that the step can be performed if the options are selected.7
You are not supposed to "hide all apps", you are generally advised to hide as few apps as possible; hide an app only when necessary.
I don't know whether "hide all apps from google" means "hide from Google all apps" or "hide any app you think was produced by Google", but both are bad ideas.
In particular, hiding some Google processes can cripple Android.
There have been posts about USNF or Shamiko (not necessarily both, I just don't remember the details) removing some Google process from the deny list because it (the module, USNF or Shamiko) handled that process specially. I do not remember reading about those other processes you say are getting unticked.6
Your wish is my commandI think it would be good to support, and I posted disambiguation due to some confusion above.
Rather than being 'highly discouraged' (it's not; it's plum necessary
) patching recovery partition is actually the only option for most A-only devices launched with Android 9 (legacy SAR, circa 2018, 2019) other than Xiaomi models!
Hope you reconsider... PW
Although with one caveat,
Yes I can tell if it is Ramdisk yes or no by running a script, but that requires unpacked Magisk, (for not rooted phone, I would need to unpack)
And although it is true that PF eventually unpacks to create a patch, but within the workflow, that stage is much later, and that stage is dependent on choices a user makes in the above screen.
Of course it could be worked out and workflow changed to automatically offer / not offer the choice.
Considering that the target audience is really minute if at all existent, specially considering that the tool has Pixel in its name, and people who have Pixel phone don't need it, and people who need them wouldn't be looking to tools for Pixel Phones ... lol
I decided the leave it up to the user the choice to have that option visible or not. (no auto detection)
The tooltip on option suggests not to turn it on unless ...
I hope that should be enough. -
1094This is the place for general support and discussion regarding "Public Releases", which includes both stable and beta releases.
All information, including troubleshoot guides and notes, are in the Announcement Thread156Hello, I haven't given much support on XDA lately. It can be resulted from
- University started and I have limited free time. In fact, I mostly develop during midnight
- I live in Taiwan, which has large time zone differences between my European/American contributors/testers, which usually forces me to stay up late at night to discuss/test stuffs.
- The new version is about to come, I don't want to spend effort on supporting old releases
New Forum!
As you might have already discovered, Magisk got its own subforum on XDA! Many thanks to all the support you gave me, and much more information/features/support is about to come!
**For developers supporting all the devices that are not using standard Android boot format, feel free to create threads in this section (actually, PLEASE do so) for your favorite devices after v7 is out. As I currently know, Asus devices require signing the boot image before flashing, and is model dependant; Sony devices seems to use ELF kernel that is unpatchable, or some has two ramdisks (inner + outer), both requires different workarounds; LG bootloader locked devices has to manually "BUMP" the boot image after flashing Magisk..... and there may be lots of other crazy boot image formats that haven't come up to my attention yet.
It is impossible for me to support all these non-standard boot images, and I hope the community can collaborate to make Magisk running across all the devices. Overall, community collaboration is what XDA about
The Pixel Phone
Some of you might already know this news, that the next Pixel Phone right around the corner seems like it does not have ramdisk in boot image, which pretty much wrecked Magisk in all ways. However, it pretty much doomed root itself too. Kernel modifications is inevitable IMO, so I'll try to migrate my scripts to C programs that could possibly be included into the kernel itself. Note that I'm not familiar with linux kernel, I'm not even sure if my idea and concept is correct or not. But once the device is available, I think developers will find a way to bypass all the difficulties, and I'll do my best to learn things
Current Progress
In the past month, I've spent quite some time learning SELinux, so that I can avoid using SuperSU's sepolicy patches. Thanks to the helps and tips from @phhusson and @Chainfire, I finally have a much clearer understanding of how SELinux works. The Magisk core parts (the scripts, boot image patches, new features, more supports) are actually done some time ago. What is causing all the delays is the Magisk Manager.
To be completely honest, although I can code in Java without much issues, Magisk Manager is actually my first Android application, I had to reach out for assistance, and fortunately awesome developers like @DVDandroid and @digitalhigh contributed a lot, which makes the current Manager awesome.
After the repo system and module management is mostly done, I was about to do some adjustments and release, but what we really done is decided to add another feature: auto-unroot with per-app settings. I decided to wait for it to be finished, and then do my adjustments. Due to reasons that'll be mentioned later, this feature will likely not be available for the next release (should come in future updates)
Safety Net Disaster
Those who are using Magisk for Safety Net bypass purposes must have known that Google recently updated the detection method of my Systemless Xposed. I still have no idea what Safety Net is detecting, so currently I cannot fix it on my side (also because I'm busy working on the next update). However, suhide developed by @Chainfire is able to hide Xposed and worked fine.
However, only my Systemless Xposed v86.2, which is based on SuperSU's su.d, is supported using that method. v86.2 and v86.5 (latest, Magisk based) have nearly identical binaries, and the only difference is the path where the binaries are stored.
I'm still not sure what's the real issue for it not being supported, I just hope it is not done intentionally.
Conclusion
Due to the fact that my Safety Net bypass is not 100% perfect now, I do not want to spend any more time waiting for auto-unroot to be polished. What I'm doing now is finishing up all the things I'd like to change in Magisk Manager (it has been a while since I last contributed to Manager, my fellow developers are doing all the heavy job), which might take a little more time, after that, packed with tons of information to be announced in Magisk Section, I'll release the long awaited update.
Hope this lengthy post gives you the idea of the whole situation, and again thanks for all your support!!121Ah, some Chainfire bashing, I hope it is not too late for me to exercise additional villainy.
First, let me make clear I have nothing against @topjohnwu, nor against Magisk. Magisk is an interesting project and it certainly displays @topjohnwu ingenuity and persistence. I don't doubt we will see more interesting things from his hands.
-------------------------
What has happened here is not all that dark and complicated, from either end. I returned from holidays, and someone pointed me at Magisk. My first thought: interesting!
Among other things, the thread lists some issues with SuperSU, which in combination with the phrase The developer also requests users to not bug Chainfire with compatibility requests for SuperSU with Magisk from the portal article, raised my left eyebrow by nigh half an inch. The popular systemless xposed mod is apparently now based on it, and apparently it now no longer works with SuperSU, and apparently I'm not supposed to fix that, nor any of the other found issues. I found that a bit weird. So yes, I have told @topjohnwu that I was a bit surprised he was posting about issues with SuperSU without notifying me about them (I can't fix or help fix issues I'm not aware of, after all).
He's also spreading a modified version of the SuperSU package, which is not all that uncommon, nor necessarily a problem. I have not looked into what he modified, I only ran a few quick tests on one of my devices, and found some commonly used commands run as root to be broken. I have informed him of this as well.
It appears the tool of choice for Magisk is phh's Superuser, because of some of the mentioned issues with SuperSU. That's fine by itself, but fixing issues in that superuser by incorporating SuperSU's binaries into it is a somewhat questionable practise. After all, SuperSU is a commercial closed-source package that helps pay for my dinner, and superuser is a direct competitor. I have informed him that I was surprised he did this without asking for permission. I have expressed similar surprise on him spreading a modified version of LiveBoot (which helps pay for a snack now and then).
@topjohnwu has also stated that Magisk's scripts are largely influenced by mine (I have not checked). Scripts based on mine are used all over the place on XDA, some people have crafted amazing things based on them, I have never made an issue of this (otherwise I would have just made them binaries). But yes, I have also stated to him that I don't think it's very nice to base something on one program, and then using that to (almost exclusively) push something directly competing with that program.
tl;dr Towards @topjohnwu, I have:
- expressed surprise he has issues getting Magisk to work with SuperSU, and has chosen not to inform me about those
- expressed surprise he is using SuperSU binaries in a competing superuser without permission
- expressed surprise he is posting a modified LiveBoot without permission
- informed him of issues with the modified SuperSU he has posted
- let him know I thought it wasn't very nice to be applying my scripts to benefit seemingly exclusively that same competing superuser
To be crystal clear:
- I have not asked for an apology
- I have not asked for Magisk to be abandoned, neither the root hiding nor systemless module parts, and certainly not systemless xposed
- I have not made an issue of any of this anywhere, until this post
- I have not even specifically asked for anything to be taken down (though obviously in my opinion the other superuser package mixed with SuperSU's binaries, as well as the LiveBoot package, should go)
- I have not reported this thread to XDA moderators for copyright violations or otherwise
While my conversation with @topjohnwu may not win any awards for being friendly (though it may win some for brevity), I think all things considered my response has been rather mild. To be perfectly honest, until the apology post, I thought this was over with already. I think the apology post was triggered because I haven't replied to his last PM for a while - I was in the zone, it happens.
To emphasize again, I have nothing against @topjohnwu, Magisk, or systemless xposed, and it is certainly not my goal to see any of them go. If it can be made to work together with SuperSU, great.
I get it though: you think of something, you want to see if you can make it work, you finally get it to work, you publish it, it takes off - enthusiasm gets the better of you. Maybe in the rush some mistakes are made. That doesn't mean you have to just drop it and run. None of my stuff would make it past 0.1 if I stopped at the first big mistake
Aside from said being in the zone coding, I usually regret actually responding to these sort of things the day after, which has made me hesitant to reply. Surprise me.76Thread temporarily closed so everyone sees this.
The flood of "SafetyNet isn't working for me either!" posts are not helpful, at all. Please refrain from posting further, it will be looked into. Please do not forget that not passing SafetyNet is 100% NORMAL AND INTENDED when you have an unlocked booloader or running custom firmware. These are workarounds and they will be worked around in turn.
The Flash
Forum Moderator
EDIT: Thread is reopened... I will be cleaning any SafetyNet posts for a while to keep the thread clean for real issues.75Hello everyone!
I am aware that Google has updated Safety Net that makes Magisk itself a no go for Android Pay. In fact, I witnessed the change live while I am developing the new magiskhide, which should hide all Magisk modules and Magisk installed root.
Google is serious about Safety Net now, clearly hunting down all possibility to run Xposed with Safety Net passed. I spend quite some time examining the new security measures last midnight, and fortunately it seems that it is possible to run Magisk and root along with Safety Net if no Xposed is running. I'm glad I removed the old root toggle at the right time lol, that is no longer feasible with the latest detection.
So stay tuned for the next update, it will come with bug fixes, along with the new magiskhide to bypass that Safety Net.
Google, how will a few systemless mods do any harm
PW
