• We are moving to xdaforums.com!

    Posts made between now and when the migration is complete will not be carried over.
    You will be automatically redirected once the migration is complete.

Magisk General Support / Discussion

Search This thread

karimo22

Member
Apr 2, 2023
7
1
i don't know what i did but the console outputs this when i do "ls" command i think i missed with some busyox settings and i don't rememeber how any help please
1.JPG

it adds ←[1;32m to all directories and files and end each one with a close ←[m
 
  • Like
Reactions: HippoMan

J.Michael

Recognized Contributor
Jan 20, 2018
2,079
2,477
Samsung Galaxy Tab A series
i don't know what i did but the console outputs this when i do "ls" command i think i missed with some busyox settings and i don't rememeber how any help please
View attachment 5880117
it adds ←[1;32m to all directories and files and end each one with a close ←[m
Where are you typing "ls"?

It looks like you have instructed your system that you are using an ANSI terminal (maybe a VT100), but you have not set your terminal to that mode, so it is trying to display the escape sequences that are being output with each line.

Those sequences are coloring the output. There is an option (or a dozen options) on the "ls" command to display different types of files in different colors.

There is very little anyone can do if you disavow any knowledge of exactly with what you messed. If you are running in a terminal emulator, try looking in the menu of the terminal emulator window to see if you can find where to select the type of terminal. Start with "xterm", then try others until it looks better. Or try to find a "restore defaults" option in the terminal emulator window, or in the terminal emulator itself. Or just uninstall and reinstall your terminal emulator. (I don't know where that will leave you if you have created files in the terminal emulator's personal file space -- they might be deleted, or just orphaned because you no longer have permission to access them.)
 

HippoMan

Senior Member
May 5, 2009
2,408
1,129
Hippoland
i don't know what i did but the console outputs this when i do "ls" command i think i missed with some busyox settings and i don't rememeber how any help please
View attachment 5880117
it adds ←[1;32m to all directories and files and end each one with a close ←[m
Those are ANSI codes to colorize the output. The left-pointing arrow represents the ESC character.

I don't know specifically about busybox's ls, but I know that you can make an alias like ls='ls --color=no' in Ubuntu and Debian and most linuxes. Busybox probably accepts something similar.

Try man ls for more info.

Alternatively, if you want the colors, you can do export TERM=xterm-color or export TERM=xterm-256color in your terminal session. If your terminal emulator honors that, then those ANSI sequences will colorize the output of ls.
 
Last edited:
  • Like
Reactions: ipdev

Feduz

Senior Member
Jun 1, 2014
130
18
OnePlus 8T
I don't find references to using it to patch a hosts file. The tutorial I found describes patching an app to make that app stop showing ads -- not quite the same thing.

I'll wait for @Feduz to say whether he ever had Magisk.

The problem was the latest build of Magisk that has some issues with systemloss. With LP can "update" the hosts file (in /etc) to add a blocking list, and also block some ads in the app. (of course you have to enable the module on Magisk)
 

J.Michael

Recognized Contributor
Jan 20, 2018
2,079
2,477
Samsung Galaxy Tab A series
The problem was the latest build of Magisk that has some issues with systemloss. With LP can "update" the hosts file (in /etc) to add a blocking list, and also block some ads in the app. (of course you have to enable the module on Magisk)
Is "LP" "Lucky Patcher"?
What does it have to do with editing the hosts file?

If you have a working copy of Magisk (almost anything before the last few versions), then a trivial module can overlay /system/etc/hosts -- just put the hosts file you want at /data/adb/modules/trivialmodulename/system/etc/hosts and reboot.
 

Feduz

Senior Member
Jun 1, 2014
130
18
OnePlus 8T
Is "LP" "Lucky Patcher"?
What does it have to do with editing the hosts file?

If you have a working copy of Magisk (almost anything before the last few versions), then a trivial module can overlay /system/etc/hosts -- just put the hosts file you want at /data/adb/modules/trivialmodulename/system/etc/hosts and reboot.
I've replaced the latest magisk version with magisk delta and now the module systemless works properly

There is a function on LP that blocks the ads (the same as adaway) updating the hosts file
 
  • Like
Reactions: J.Michael

zgfg

Senior Member
Oct 10, 2016
9,654
7,514
Redmi K20 / Xiaomi Mi 9T
Xiaomi Mi 11
I've replaced the latest magisk version with magisk delta and now the module systemless works properly

There is a function on LP that blocks the ads (the same as adaway) updating the hosts file
You can download some hosts file from Internet, like:

Rename to hosts (with no extension!)

If you have old Android where System is not read-only, use TWRP and copy that downloaded & renamed hosts file over the original /system/etc/hosts
and reboot
(Magisk/root not required)

Otherwise, enable Systemless hosts in Magisk app and reboot.
Then use some root file manager like MiXPlorer and copy the downloaded & renamed hosts file over:
/data/adb/modules/hosts/system/etc/hosts
and reboot

---

But that way you have a 'fixed' hosts file - by using AdAway, AdAway will update the hosts file to stay up-to-date with the new ads sites

Or go to native Settings, Private DNS and switch to:
dns.adguard-dns.com
(root or TWRP not required, just Android 9 or later)
 

Feduz

Senior Member
Jun 1, 2014
130
18
OnePlus 8T
You can download some hosts file from Internet, like:

Rename to hosts (with no extension!)

If you have old Android where System is not read-only, use TWRP and copy that downloaded & renamed hosts file over the original /system/etc/hosts
and reboot
(Magisk/root not required)

Otherwise, enable Systemless hosts in Magisk app and reboot.
Then use some root file manager like MiXPlorer and copy the downloaded & renamed hosts file over:
/data/adb/modules/hosts/system/etc/hosts
and reboot

---

But that way you have a 'fixed' hosts file - by using AdAway, AdAway will update the hosts file to stay up-to-date with the new ads sites

Or go to native Settings, Private DNS and switch to:
dns.adguard-dns.com
(root or TWRP not required, just Android 9 or later)
thanks,
I've found that LP patches the hosts file in both folder, should be used only the one in /data?
 

zgfg

Senior Member
Oct 10, 2016
9,654
7,514
Redmi K20 / Xiaomi Mi 9T
Xiaomi Mi 11
thanks,
I've found that LP patches the hosts file in both folder, should be used only the one in /data?
I don't use that app (btw, it's name is not welcome on XDA) but generally (on the read-only /system), you can not change /system/etc/hosts file

That's what Magisk then does, on every reboot when initializing Magisk, Magisk will mount (it's not copying!) /data/adb/modules/hosts/system/etc/hosts over /system/etc/hosts

Hence, AdAway does just that, it writes to the hosts file on /data and leave it to Magisk to mount over the /system hosts file

I don't know how LP works (btw, Play Protect will complain about the installed LP). It could do the same as AdAway or it could also execute the mount command directly
 
Last edited:

Feduz

Senior Member
Jun 1, 2014
130
18
OnePlus 8T
I don't use that app (btw, it's name is not welcome on XDA) but generally (on the read-only /system), you can not change /system/etc/hosts file

That's what Magisk then does, on every reboot when initializing Magisk, Magisk will mount (it's not copying!) /data/adb/modules/hosts/system/etc/hosts over /system/etc/hosts

Hence, AdAway does just that, it writes to the hosts file on /data and leave it to Magisk to mount over the /system hosts file

I don't know how LP works (btw, Play Protect will complain about the installed LP). It could do the same as AdAway or it could also execute the mount command directly
OK thanks for explanation, didn't know about the second folder. Yes I think that works on the same way as AdAway
 

osm0sis

Senior Recognized Developer / Contributor
Mar 14, 2012
15,670
35,422
Halifax
GT-i9250
Google Nexus 4
Last edited:

pndwal

Senior Member
Latest Canary (+Debug) Magisk:

Magisk (69529ac5) (25211)​

  • [General] Bump minimum supported Android version to Android 6.0
  • [MagiskPolicy] Update rules to support Android U
  • [MagiskBoot] Support amonet microloader devices
  • [MagiskBoot] Always use lz4_legacy compression on v4 boot images. This fixes boot image patching issues on Android U preview.
  • [Zygisk] Rewrite code unloading implementation

Diffs to v25.2​

  • [General] Bump minimum supported Android version to Android 6.0
  • [General] New magic mount backend. It supports loading modules into system with overlayfs files injected
  • [Zygisk] Release new API version 4
  • [Zygisk] Prevent crashing daemon in error
  • [Zygisk] Rewrite zygote code injection with new loader library approach
  • [Zygisk] Rewrite code unloading implementation
  • [MagiskBoot] Support amonet microloader devices
  • [MagiskBoot] Always use lz4_legacy compression on v4 boot images. This fixes boot image patching issues on Android U preview.
  • [MagiskInit] Support replacing existing *.rc files in overlay.d
  • [MagiskInit] Rewrite sepolicy.rules mounting and loading implementation
  • [App] Make stub patching 100% offline
  • [App] Support patching init_boot.img for Samsung ODIN firmware
  • [MagiskPolicy] Fix minor bug in command line argument parsing
  • [MagiskPolicy] Update rules to support Android U
https://github.com/topjohnwu/magisk-files/blob/0283ca1564a8533a10f7f55071211e7b2f0f8de3/notes.md

👍 PW
 
Last edited:

zgfg

Senior Member
Oct 10, 2016
9,654
7,514
Redmi K20 / Xiaomi Mi 9T
Xiaomi Mi 11
Adaway still not working for me with this update
Yeah. I upgraded from Canary v25206 to this brand new v25211 and /data/adb/modules/hosts/system/etc/hosts is again (like in v25210) not mounted to /system/etc/hosts

It's not about AdAway, it's just the Magisk built-in Systemless hosts feature that is still broken
 
Last edited:

osm0sis

Senior Recognized Developer / Contributor
Mar 14, 2012
15,670
35,422
Halifax
GT-i9250
Google Nexus 4
Yeah. I upgraded from Canary v25206 to this brand new v25211 and /data/adb/modules/hosts/system/etc/hosts is again (like in v25210) not mounted to /system/etc/hosts

I really don't understand that all those devs (who commit and approve changes) cannot make a simple regression test for something that was known to be broken, to make sure it will work (again)

It's not about AdAway, it's just the Magisk built-in Systemless hosts feature that is still broken
Interesting... They specifically added workarounds for it:


So you'd think they'd have tested it. 🤔
 

Top Liked Posts

  • 1
    Well that's great we have reached an official conclusion of this after unrooting and factory resetting instead of my speculation but now how do I return it to unlocked status? I don't use Sprint (even if it's merged with T-Mobile).
    Like I mentioned before, no scam services that after I pay them they say "we unfortunately aren't able to do this or that but thanks for the money sucker"
    Just catching up here...

    Ok, starting to understand... Originally you said:
    Updating to Magisk 26.3 disabled my unlocked phone's ability to read my SIM card, so now it gives me Invalid SIM card or SIM card not detected
    Naturally we all thought you meant bootloader unlocked since that's a requirement for rooting (although B/L can be locked again with root in special circumstances)... Since flashing a mismatched boot.img commonly results in users having SIM/mobile network, WiFi, BT and similar issues, that looked like your issue to me...

    It never occurred to me that you had an originally carrier locked device that had been unlocked and had somehow reverted to locked, preventing use of a non-carrier SIM!...

    Also, carrier lock status has nothing to do with root except that some carriers may also disable OEM Unlocking ability (that's bootloader, not carrier) on devices they supply (by applying their modifications to the ROM).
    Really my issue is that it seems Magisk locked my phone or something and I'm trying to figure out how to get it unlocked without paying for a scam service that may or may not work.
    ... I still didn't twig that you meant to carrier-unlock here either... 🤪

    So I think root, modules etc has nothing to do with this issue, assuming device was properly carrier unlocked (using manufacturer method/codes)... But I'm not betting this was done properly...

    Did you apply unlock codes?... Or was some hack solution for unlocking applied by you, someone else, or a seller (perhaps they applied a hack to bypass a mandatory waiting time or payment due for unlocking, or it was preloaded with a modded/unofficial ROM etc)?

    It's unlikely a root update or similar would account for carrier lock reverting unless it wasn't unlocked property or by using official methods in the first place... In that case all bets would be off... 😬 PW
    1
    Where did you buy this phone?

    Was it carrier-locked when you bought it?

    Did you buy a new SIM card?

    How did you carrier-unlock the phone?

    Where did you find the stock ROM? (The one you "must have deleted or something"?)

    Have you located and downloaded the stock ROM a second time?

    Have you ever tried burning a complete stock ROM to see if that restores the ability to use the phone?
    I bought the phone already unlocked and factory refurbished off Amazon and I still have the same SIM card.
    I think the Stock ROM I deleted was the copy of the unpatched IMG file so it's before I patched it with Magisk. I'm also positive I don't have the original IMG unless maybe if I look through File History on my PC.
    Haven't tried burning any kind of ROM.
    Good news though, I actually went back to T Mobile and got a new 5G Stylus 2023. A bit smaller but still awesome. I will think about keeping the old Stylus or selling it to a pawn shop.
    1
    I bought the phone already unlocked and factory refurbished off Amazon and I still have the same SIM card.
    I think the Stock ROM I deleted was the copy of the unpatched IMG file so it's before I patched it with Magisk. I'm also positive I don't have the original IMG unless maybe if I look through File History on my PC.
    Haven't tried burning any kind of ROM.
    Good news though, I actually went back to T Mobile and got a new 5G Stylus 2023. A bit smaller but still awesome. I will think about keeping the old Stylus or selling it to a pawn shop.
    ROM is bigger than image file, ROM typically contains a number of image files. ROM may be a ZIP file, a tar file, or some other container-type file.

    Where did you get the ROM file? Was it given to you with the phone? Were you told from where to download it? Did you find it yourself on some web site?

    If the carrier-unlock process consists of replacing the kernel, or patching the boot image, and you managed to find a carrier-locked boot image, then that explains how you re-locked your phone.

    I still don't understand how your SIM card worked fine in a random phone at the phone store, but is apparently not on the right network for *your* phone.
  • 8
    This illustrates why I always want to be able to use a device upon which TWRP (or perhaps OrangeFox) is functional. As long as I've taken a proper full nandroid backup of a previous working system, I can easily nandroid-restore that working system after an upgrade, if I wish.

    I am not happy with Google for continuing to "enhance" (ha ha!) Android as time goes on,
    Yeah... And Microsoft should have stayed with DOS, and maybe Windows as a DOS add-on!...
    thereby making it more and more difficult to get TWRP and OrangeFox working with newer Android versions.
    That's certainly NOT their intention...

    There's a lot to be said for new innovations and OEM requirements both in the mart of competitive commerce and for the value -added benefits to general Android users...

    Just as a few examples,
    • SAR/2SI enhancements allow for A/B partitioning and 'seamless' (streamed) delta OTA updates,
    • Shared blocks architecture allows for dynamic sup-super partitions which may be RO but are resizable with no unused space, upgradable to larger /system etc in future and space optimised/saving etc,
    • Project Treble (Android 8+)
    https://www.xda-developers.com/goog...ze-android-so-oems-can-update-devices-faster/
    modularised Android so that OEMs can serve Android updates more quickly by reducing OEM dependence on SoC vendors for every single OS update and introduced a new 'vendor interface' and Vendor Test Suite (VTS)... It also facilitated
    • The GSI Project (Android 9+)
    https://developer.android.com/topic/generic-system-image
    which allows app developers to install and run the latest Android Generic System Images to perform app testing on a variety of existing Android devices, and use GSIs from different Android OS release stages... Extra benefits include:
    - Broader test coverage on a greater set of real devices
    - More time to fix app compatibility issues
    - More opportunities to fix compatibility issues in Android that are reported by app developers
    • Project Mainline (Android 10+)
    https://www.xda-developers.com/android-q-project-mainline-security/
    (modules:)
    https://www.xda-developers.com/android-project-mainline-modules-explanation/
    expands on Treble's modularisation to further address fragmentation, adding Android Pony EXpress update packages to allow updating system modules (APEX includes all needed libraries, ART, HALs and precompiled code on addition to apps) through Google Play in Android 10 and 25 new modules with A11, as well as reducing how dependent Google is on OEMs for delivering security updates to key OS components. It also facilitated
    • The GKI Project (Android 11+)
    https://source.android.com/docs/core/architecture/kernel/generic-kernel-image
    with its Generic Kernel Image is an essential change aimed addressing the issue/costs of fragmentation which "has several negative effects on the Android community". GKI/Mainline reductions in fragmentation thus:
    - Make security updates less labor intensive
    - Allow merging Long-Term Supported updates
    - Removes factors that Inhibit Android platform release upgrades
    - Allows easier contribution of kernel changes back to upstream Linux

    So Treble and Mainline, with their GSI and GKI changes/requirements, are initiatives to facilitate easier updates for vendors, give incentive to support devices much longer, etc.

    Google is in the business of promoting it's mobile OS and producing development milestones that reduce costs, improve efficiency, lifecycle, specs etc for OEMs and end users in order to stay competitive, relevant, innovative and appealing... And they make major architectural changes for these reasons...

    They aren't in the game of "making it more and more difficult to get TWRP and OrangeFox working"; they appreciate these efforts but (quite reasonably) have the (different) priorities mentioned above...

    Just as with Magisk injection, there is much pressure on Dee's Troy and team (and other custom recovery teams) to get TWRP functioning properly, let alone to mount and decrypt user data with an ever changing Android architecture, but there are clearly more complex considerations than for simple Magisk injection... Even so, Google allows and even supports such custom mod efforts...

    Moreover it's not Google's fault that community projects like TeamWin find it difficult to devote the time, conscript the Devs or otherwise overcome obstacles needed to properly support new Android iterations... They actually supply clear documentation as part of AOSP for these changes to benefit all Android devs, whether OEMs, app makers or custom modders...

    I don't really know why TWRP has not progressed past Oct 2022 3.7.0 A12 base builds at this time despite the fact that 'Android 13 development had started' already, but the difficulty they have keeping up is not new... I note that everything there is still © 2014 to 2022, also that:
    TWRP development is done by roughly 4 people at this point. We also have a large support community with many people who are willing to answer questions and help people with their devices either through our Zulip channel or on forums like xda-developers.
    https://twrp.me/about/
    and that, just as when Dees Troy lamented that 'real life' was preventing TWRP keeping pace, the four base team members are still appealing for volunteers:
    We need your help! The bulk of TWRP work is done by a handful of people on a volunteer basis. We have pushed most of our device files to our github and we have a gerrit instance. If you have the ability, please help us maintain our official devices and/or add your device to our official device list. Thanks in advance!
    -----​

    Despite the difficulty the TWRP four have keeping up with the Google juggernaut, apparently many devices running A13+ have at least unofficial TWRP support with working decryption. Some won't allow permanent flashing but temp booting TWRP works nonetheless, and some have other issues...

    Re devices launched with Android 13:

    Just on Thursday, Dev @Nebrassy posted a TWRP build for OnePlus 11 which is apparently working despite some niggles:
    https://forum.xda-developers.com/t/recovery-12-unofficial-teamwin-recovery-project.4625181/

    This device has dedicated /recovery_a and /recovery_b partitions and Qualcomm SoC, and the Dev doesn't even own the device...

    For Pixel 7 series, the delay getting TWRP w/ decryption working seems to be Tensor SoC / device tree syncing and possibly StrongBox / KeyMint / Titan chip implementation(?) rather than general Android Architectural changes and initiatives.

    However, just yesterday @Wishmasterflo posted a test build of OrangeFox recovery (this is "synced with the latest Teamwin changes", and originally from a Dev who later joined LineageOS) for the Pixel 7a:
    https://forum.xda-developers.com/t/...g-thats-being-worked-on.4532237/post-88986509
    Nb. The Dev cannot test ATM as his device is still locked...

    Pixel 7a users: If someone tests and this works, I'm sure custom recovery support for Pixel 7 series devices will gain momentum...

    Takers?
    -----​

    ... FWIW, some modders will experiment/toy with the latest devices / Android versions as soon as they arrive... Others will stay with old tech because of affordability but migrate ASAP... Still others will refrain as long as possible, whether out of nostalgia or for other reasons...

    Similarly, some car drivers will migrate to EVs quickly... Others will when the price point is more agreeable... Still others will refrain as long as possible, and some will hanker for the ICE age with the smell of petrol and the roar of engines long after it's gone!

    Personally, despite not being able to afford a Tesla yet, I think auto makers in general have not moved to new tech nearly fast enough!...I expect them to continue to "enhance" transportation options as time goes on however... And I cannot be unhappy when phone market leaders adapt, innovate and move with the times either...

    Just might be able to get me a 2nd hand P7Pro now that the P8's in the wind, and wire a fast-charge outlet into the dash of the ol Ford Perfect... 😜 PW
    8
    I consider it to be unfair to define "modder" or "developer" as "anyone who dumps partitions/nandroid".
    <SNIP>

    <SNIP>
    Since it's not available without unlocking, 'anyone who dumps partitions / performs nandroid' has to agree to modify the device by unlocking which changes original product features including disabling security functions and other features... Then they generally install a custom (modified) recovery...😆
    <SNIP>
    I miss the days when I could just use adb to dump the data partition into an image file and flash it back. 😿️

    Better yet, when I could wipe system, install a different OS version and leave userdata alone.
    [The original Clean/Dirty flash install.] 🙃️

    As for the Cat and Mouse game...

    My money is on the Mice. 😜️
    "Look, sorry - are we talking about the little white furry things with the cheese fixation and women standing on tables screaming in early sixties sit coms?"

    Slartibartfast coughed politely.

    "These creatures you call mice, you see, they are not quite as they appear. They are merely the protrusion into our dimension of vast hyperintelligent pandimensional beings. The whole business with the cheese and the squeaking is just a front."
    ― Douglas Adams, The Hitchhiker's Guide to the Galaxy

    Cheers all. :cowboy:

    PS.
    I miss FlashFire.
    😥️
    5
    ... except the poster did indeed try that, and the SIM card is fine. See above.
    That's not the point. The point is it was an obvious thing to check, I never thought of it, @iruiz2 did, and I would have liked to be able to paste glitter and unicorns all over his post to express how much I Liked it.

    You, on the other hand, can expect coal in your stocking.
    4
    Sorry laughing at side of road comment, not your post in general
    Yeah... in Australia you should be sure to meet Gumtree electronics vendor in the middle of a busy shopping mall!... In Asian countries this is even more imperative... 😆 PW
    4
    Full nandroid backups are for modders...

    Actually, full nandroid backups are quite helpful for non-modders, as well.

    Consider the following ...

    A typical non-modding Android user on a standard, factory, non-rooted ROM on a standard Android-approved device applies standard, approved OTA updates when they are offered.

    But after one such OTA is successfully applied, the user then realizes that the system has been modified in one or more ways that he or she doesn't like, and the user therefore wants to roll back the OTA update.

    If there was a utility which would have allowed the user to have taken a full nandroid-like backup right before initiating the OTA update, he or she could then easily and relatively quickly use that utility to restore the system back to the exact state it was in right before the OTA.

    Again, I'm not saying that Google SHOULD offer a such nandroid-like backup/restore utility, but it certainly would be nice to have. And if such a standard Android utility was offered by Google, this would save countless person-hours of development efforts for the creation of numerous versions of TWRP and OrangeFox for all the various device/OS-version combinations out there.

    But this is little more than a pipe dream, given that Google is extremely unlikely to ever offer such a thing.
  • 1100
    This is the place for general support and discussion regarding "Public Releases", which includes both stable and beta releases.
    All information, including troubleshoot guides and notes, are in the Announcement Thread
    156
    Hello, I haven't given much support on XDA lately. It can be resulted from
    • University started and I have limited free time. In fact, I mostly develop during midnight
    • I live in Taiwan, which has large time zone differences between my European/American contributors/testers, which usually forces me to stay up late at night to discuss/test stuffs.
    • The new version is about to come, I don't want to spend effort on supporting old releases
    The planned update is delayed again and again, to some point I think I'll shed some light about what has been happening lately, also along with some announcements.

    New Forum!
    As you might have already discovered, Magisk got its own subforum on XDA! Many thanks to all the support you gave me, and much more information/features/support is about to come!
    **For developers supporting all the devices that are not using standard Android boot format, feel free to create threads in this section (actually, PLEASE do so) for your favorite devices after v7 is out. As I currently know, Asus devices require signing the boot image before flashing, and is model dependant; Sony devices seems to use ELF kernel that is unpatchable, or some has two ramdisks (inner + outer), both requires different workarounds; LG bootloader locked devices has to manually "BUMP" the boot image after flashing Magisk..... and there may be lots of other crazy boot image formats that haven't come up to my attention yet.
    It is impossible for me to support all these non-standard boot images, and I hope the community can collaborate to make Magisk running across all the devices. Overall, community collaboration is what XDA about :D

    The Pixel Phone
    Some of you might already know this news, that the next Pixel Phone right around the corner seems like it does not have ramdisk in boot image, which pretty much wrecked Magisk in all ways. However, it pretty much doomed root itself too. Kernel modifications is inevitable IMO, so I'll try to migrate my scripts to C programs that could possibly be included into the kernel itself. Note that I'm not familiar with linux kernel, I'm not even sure if my idea and concept is correct or not. But once the device is available, I think developers will find a way to bypass all the difficulties, and I'll do my best to learn things ;)

    Current Progress
    In the past month, I've spent quite some time learning SELinux, so that I can avoid using SuperSU's sepolicy patches. Thanks to the helps and tips from @phhusson and @Chainfire, I finally have a much clearer understanding of how SELinux works. The Magisk core parts (the scripts, boot image patches, new features, more supports) are actually done some time ago. What is causing all the delays is the Magisk Manager.
    To be completely honest, although I can code in Java without much issues, Magisk Manager is actually my first Android application, I had to reach out for assistance, and fortunately awesome developers like @DVDandroid and @digitalhigh contributed a lot, which makes the current Manager awesome.
    After the repo system and module management is mostly done, I was about to do some adjustments and release, but what we really done is decided to add another feature: auto-unroot with per-app settings. I decided to wait for it to be finished, and then do my adjustments. Due to reasons that'll be mentioned later, this feature will likely not be available for the next release (should come in future updates)

    Safety Net Disaster
    Those who are using Magisk for Safety Net bypass purposes must have known that Google recently updated the detection method of my Systemless Xposed. I still have no idea what Safety Net is detecting, so currently I cannot fix it on my side (also because I'm busy working on the next update). However, suhide developed by @Chainfire is able to hide Xposed and worked fine.
    However, only my Systemless Xposed v86.2, which is based on SuperSU's su.d, is supported using that method. v86.2 and v86.5 (latest, Magisk based) have nearly identical binaries, and the only difference is the path where the binaries are stored.
    I'm still not sure what's the real issue for it not being supported, I just hope it is not done intentionally.

    Conclusion
    Due to the fact that my Safety Net bypass is not 100% perfect now, I do not want to spend any more time waiting for auto-unroot to be polished. What I'm doing now is finishing up all the things I'd like to change in Magisk Manager (it has been a while since I last contributed to Manager, my fellow developers are doing all the heavy job), which might take a little more time, after that, packed with tons of information to be announced in Magisk Section, I'll release the long awaited update.

    Hope this lengthy post gives you the idea of the whole situation, and again thanks for all your support!!
    121
    Ah, some Chainfire bashing, I hope it is not too late for me to exercise additional villainy.

    First, let me make clear I have nothing against @topjohnwu, nor against Magisk. Magisk is an interesting project and it certainly displays @topjohnwu ingenuity and persistence. I don't doubt we will see more interesting things from his hands.

    -------------------------

    What has happened here is not all that dark and complicated, from either end. I returned from holidays, and someone pointed me at Magisk. My first thought: interesting!

    Among other things, the thread lists some issues with SuperSU, which in combination with the phrase The developer also requests users to not bug Chainfire with compatibility requests for SuperSU with Magisk from the portal article, raised my left eyebrow by nigh half an inch. The popular systemless xposed mod is apparently now based on it, and apparently it now no longer works with SuperSU, and apparently I'm not supposed to fix that, nor any of the other found issues. I found that a bit weird. So yes, I have told @topjohnwu that I was a bit surprised he was posting about issues with SuperSU without notifying me about them (I can't fix or help fix issues I'm not aware of, after all).

    He's also spreading a modified version of the SuperSU package, which is not all that uncommon, nor necessarily a problem. I have not looked into what he modified, I only ran a few quick tests on one of my devices, and found some commonly used commands run as root to be broken. I have informed him of this as well.

    It appears the tool of choice for Magisk is phh's Superuser, because of some of the mentioned issues with SuperSU. That's fine by itself, but fixing issues in that superuser by incorporating SuperSU's binaries into it is a somewhat questionable practise. After all, SuperSU is a commercial closed-source package that helps pay for my dinner, and superuser is a direct competitor. I have informed him that I was surprised he did this without asking for permission. I have expressed similar surprise on him spreading a modified version of LiveBoot (which helps pay for a snack now and then).
    @topjohnwu has also stated that Magisk's scripts are largely influenced by mine (I have not checked). Scripts based on mine are used all over the place on XDA, some people have crafted amazing things based on them, I have never made an issue of this (otherwise I would have just made them binaries). But yes, I have also stated to him that I don't think it's very nice to base something on one program, and then using that to (almost exclusively) push something directly competing with that program.

    tl;dr Towards @topjohnwu, I have:
    - expressed surprise he has issues getting Magisk to work with SuperSU, and has chosen not to inform me about those
    - expressed surprise he is using SuperSU binaries in a competing superuser without permission
    - expressed surprise he is posting a modified LiveBoot without permission
    - informed him of issues with the modified SuperSU he has posted
    - let him know I thought it wasn't very nice to be applying my scripts to benefit seemingly exclusively that same competing superuser

    To be crystal clear:
    - I have not asked for an apology
    - I have not asked for Magisk to be abandoned, neither the root hiding nor systemless module parts, and certainly not systemless xposed
    - I have not made an issue of any of this anywhere, until this post
    - I have not even specifically asked for anything to be taken down (though obviously in my opinion the other superuser package mixed with SuperSU's binaries, as well as the LiveBoot package, should go)
    - I have not reported this thread to XDA moderators for copyright violations or otherwise

    While my conversation with @topjohnwu may not win any awards for being friendly (though it may win some for brevity), I think all things considered my response has been rather mild. To be perfectly honest, until the apology post, I thought this was over with already. I think the apology post was triggered because I haven't replied to his last PM for a while - I was in the zone, it happens.

    To emphasize again, I have nothing against @topjohnwu, Magisk, or systemless xposed, and it is certainly not my goal to see any of them go. If it can be made to work together with SuperSU, great.

    I get it though: you think of something, you want to see if you can make it work, you finally get it to work, you publish it, it takes off - enthusiasm gets the better of you. Maybe in the rush some mistakes are made. That doesn't mean you have to just drop it and run. None of my stuff would make it past 0.1 if I stopped at the first big mistake :)

    Aside from said being in the zone coding, I usually regret actually responding to these sort of things the day after, which has made me hesitant to reply. Surprise me.
    76
    Thread temporarily closed so everyone sees this.

    The flood of "SafetyNet isn't working for me either!" posts are not helpful, at all. Please refrain from posting further, it will be looked into. Please do not forget that not passing SafetyNet is 100% NORMAL AND INTENDED when you have an unlocked booloader or running custom firmware. These are workarounds and they will be worked around in turn.

    The Flash
    Forum Moderator

    EDIT: Thread is reopened... I will be cleaning any SafetyNet posts for a while to keep the thread clean for real issues.
    75
    Hello everyone!

    I am aware that Google has updated Safety Net that makes Magisk itself a no go for Android Pay. In fact, I witnessed the change live while I am developing the new magiskhide, which should hide all Magisk modules and Magisk installed root.

    Google is serious about Safety Net now, clearly hunting down all possibility to run Xposed with Safety Net passed. I spend quite some time examining the new security measures last midnight, and fortunately it seems that it is possible to run Magisk and root along with Safety Net if no Xposed is running. I'm glad I removed the old root toggle at the right time lol, that is no longer feasible with the latest detection.

    So stay tuned for the next update, it will come with bug fixes, along with the new magiskhide to bypass that Safety Net.

    Google, how will a few systemless mods do any harm :p:p