Magisk General Support / Discussion

[J.Michael]

Question: I am new here, please redirect me to appropriate forum if this isn't where I should post my Q.

I have pixel phones rooted with Magisk, thus no OTA updates for me. So I download them from the Google site when the monthly update arrives, and flash using adb sideload. But it's a PITA wrt Magisk, I usually have to fuss around to get Magisk back running, although it's still worth it.

My Q is: if I update the monthly update zip with the appropriately patched magisk_patched file, will that OTA update install successfully and also preserve Magisk?

Thank you for any advise.
Tim

What you describe has a good chance of working. When it doesn't work, you will have a good chance of recovering by flashing the unmodified "new" ROM, and continuing as you used to.

 

[zgfg]

Please, try to install JamesDSP with Magisk v26 (or Canary 26102):

https://raw.githubusercontent.com/Zackptg5/JamesDSPManager/master/install.zip

Or from the GitHub Readme, View code, download install.zip:
https://github.com/Zackptg5/JamesDSPManager

(Btw, I don't know why he cannot create a Release on GitHub like there are for all other modules from other authors, so that his latest version or an older one can be easily found and downloaded)

If I try to install JDSP when I have Viper4Android and AML, then it complains that there is an incompatible module and that I must use AML (although I do use it)

If I try to install JDSP without having V4A and AML, then it seemingly installs ok, but after reboot, when I open JamesDSP app, it immediately crashes

I tried both with Volume+ ('Huawei', ie, 64bit) and Volume- (not 'Huawei', ie, 32bit)

(Again some oddities - it is known that it's not really about Huawei or not but if 64bit audio drivers are needed or not. So he could have renamed Huawei option to 64bit or so [he released latest JDSP recently and/or his module could find itself are the 64bit drivers needed when installing]. Also that ancient Volume+/- mngmt during the module installation [from the times of installing modules through custom recoveries with no touch screen], where it usually does not detect the button at first and/or on time)

However, with Magisk Delta, JDSP module works perfectly (and together with V4A and AML)

 

[martyfender]

I have now attached a bugreport to my previous report.

 

[martyfender]

As always, it is in my signature. Note that I have 2 of these devices, one with Magisk debug and one with Delta. I have now attached a bugreport.

bug report

 

[badabing2003]

What you describe has a good chance of working. When it doesn't work, you will have a good chance of recovering by flashing the unmodified "new" ROM, and continuing as you used to.

He's talking about OTA, you can't modify OTA, it will fail AVB.

 

[J.Michael]

He's talking about OTA, you can't modify OTA, it will fail AVB.

He said "no OTA updates for me. So I download them from the Google site", which I took to mean he downloaded a full ROM.

I don't understand your reference to "AVB". If he can flash a patched boot image after the system is updated, and if he does indeed have a full ROM corresponding to an updated system, why couldn't the first flash of the updated system be with the boot image patched? (Unless this is one of those systems where Magisk cannot do a complete job of patching unless it is currently running on the target system.)

 

[tim1aust]

He said "no OTA updates for me. So I download them from the Google site", which I took to mean he downloaded a full ROM.

I don't understand your reference to "AVB". If he can flash a patched boot image after the system is updated, and if he does indeed have a full ROM corresponding to an updated system, why couldn't the first flash of the updated system be with the boot image patched? (Unless this is one of those systems where Magisk cannot do a complete job of patching unless it is currently running on the target system.)

J Michael,
My bad, I did in fact mean I download the OTA and flash that because Google knows my phone is rooted or bootloader unlocked or something else, but never pushes updates to my phone. But I am certainly not an expert in all this, I am assuming badabing2003 is referring to a signature check or somesuch failing if I replace the boot image in the OTA zip with the magisk_patched one.

I do appreciate your input, thanks! I'm learning...

 

[pndwal]

J Michael,
My bad, I did in fact mean I download the OTA and flash that because Google knows my phone is rooted or bootloader unlocked or something else, but never pushes updates to my phone. But I am certainly not an expert in all this, I am assuming badabing2003 is referring to a signature check or somesuch failing if I replace the boot image in the OTA zip with the magisk_patched one.

I do appreciate your input, thanks! I'm learning...

Generally, new partition digest checks are what prevents recent delta (incremental/differential) OTA Pixel updates from working with 'Flash Magisk to inactive slot' method (to preserve Magisk) on P6 and P7 series even after restoring unpatched images since the new checking is done by the update engine after reboot, although @Lughnasadh has confirmed that it (inexplicably) still works in some cases...

I suspect @badabing2003 may know this already, but I don't know if newer full ROM downloaded OTAs incorporate the same post reboot checks... Either way, you could try the method as outlined here:
https://github.com/topjohnwu/Magisk/blob/master/docs/ota.md#devices-with-ab-partitions
1) with proper stock delta OTA from 'over to the air' (small chance if you have P6+), or
2) with full downloaded OTA ROM to find out...

If 2) works, I'd be interested to know if you actually need to restore images first too... You probably wouldn't as pre-reboot checks should not really be needed w/ full OTA, and I suspect the post-reboot checks would only have been added if pre-reboot checks exist...

Nb. I have no practical experience with Pixels or A/B, and others may already have determined that this full OTA ROM approach is impossible. PW

 

[shoey63]

. . . I have no practical experience with Pixels or A/B, and others may already have determined that this full OTA ROM approach is impossible. PW

I'm finding of late on the p6 that trying to take an OTA update after restoring images aborts before it even starts. It will only take after restoring images and rebooting.
This makes installing Magisk to inactivate slot after OTA an impossibility on latest firmware.

 

[pndwal]

I'm finding of late on the p6 that trying to take an OTA update after restoring images aborts before it even starts. It will only take after restoring images and rebooting.
This makes installing Magisk to inactivate slot after OTA an impossibility on latest firmware.

Guessing standard delta over the air update?... Sad...

But what I'd like to know is whether it is possible to apply full OTA ROM download before reboot either with or without images restored on Pixels with late updates. PW

 

[shoey63]

Guessing standard delta over the air update?... Sad...

But what I'd like to know is whether it is possible to apply full OTA ROM download before reboot either with or without images restored on Pixels with late updates. PW

You mean on the pc?
Well, yeah, how else are you going to apply it?
You can flash the full factory images ROM zip in fastboot, or sideload the full OTA image zip in stock recovery.
The Magisk patched boot partition will be overwritten without issue.
You then, of course patch the new boot image and fastboot it.
(Or just let @badabing2003 's Pixel Flasher do all the work for you)

 

[badabing2003]

I suspect @badabing2003 may know this already, but I don't know if newer full ROM downloaded OTAs incorporate the same post reboot checks... Either way, you could try the method as outlined here:
https://github.com/topjohnwu/Magisk/blob/master/docs/ota.md#devices-with-ab-partitions
1) with proper stock delta OTA from 'over to the air' (small chance if you have P6+), or
2) with full downloaded OTA ROM to find out...

If 2) works, I'd be interested to know if you actually need to restore images first too... You probably wouldn't as pre-reboot checks should not really be needed w/ full OTA, and I suspect the post-reboot checks would only have been added if pre-reboot checks exist...

My small interests in OTA is primarily for two benefits OTA could offer.
1- Performing it on the phone without needing a PC
2- No phone modification is required (no root)
3- Active partition is kept intact.

1- In the context of your question, I don't know if it is possible and if it is, how it's done, how does one apply a full OTA all on the phone? assuming that you would need to download it and apply it.
Doing so on the PC, would offer no benefit compared to Factory flashing, unless #2

2- If the OTA image is modified in any way, than it will fail, and I'm thinking in the context of injecting a patched boot to gain root access on a phone that has the bootloader locked.

3- I don't know how to interrupt Full OTA sideloading to stop making it boot to system after completion, to gain an opportunity to flash a patched boot image before booting to system (of course bootloader needs to be unlocked for this) but the benefit here is that the previously active slot is not touched and system partition is not overwritten by system-other image as is the case for factory image flashing.

 

[tim1aust]

#1 is what I would love to have also, but have been unable to find any information anywhere how to do this. If one could download the OTA and have the standard "Update is available" process allow you to specify the downloaded OTA image, then the process @pndwal referred to at https://github.com/topjohnwu/Magisk/blob/master/docs/ota.md#devices-with-ab-partitions would allow the OTA update be applied with stock images restored, then use Magisk "install to inactive partition" be used *before* rebooting. In fact, my Moto Z3 is running PixelExperience ROM and I get streaming OTA updates on that phone, and follow @pndwal's referenced process without a hitch, each month.

I can't suss out why Google insists on "streaming" OTA updates, and forbid local OTA updates. I suspect the reasoning is based somewhat on they don't want to encourage rooting. Which I suppose is not unreasonable from their view, but if someone has a rooted phone/unlocked bootloader they have already voided their warranty, so IMHO it should be left to the owner of the phone to make these decisions.

 

[pndwal]

You mean on the pc?
Well, yeah, how else are you going to apply it?
You can flash the full factory images ROM zip in fastboot, or sideload the full OTA image zip in stock recovery.

Actually I meant using updater engine...

On MIUI devices users can select available delta updates or download full latest package or choose one downloaded separately and updater engine flashes... Here are the options:

Does Pixel not have options to flash full OTA ROMs from booted system?

The Magisk patched boot partition will be overwritten without issue.

Yup ... But you're talking about flashing current partition... I was guessing that full OTA from updater engine might write to inactive partition without issues (because blocks from images on active partition are not needed unless OTA is delta) if options available on pixel...

You then, of course patch the new boot image and fastboot it.
(Or just let @badabing2003 's Pixel Flasher do all the work for you)

(Or would patch Magisk to inactive partition if possible...) PW

 

[badabing2003]

Doe Pixel not have options to flash full OTA ROMs from booted system?

I have never seen it, it does not mean it doesn't exist, just that I have never seen it, besides my exposure would be super limited when updated friends' family's phones, my phones have not been going through that for ages.

... So was guess full OTA from updater engine would do the same if options available on pixel...

I would hope and expect not, otherwise it would defeat the purpose of OTA, what if something goes wrong, how would it be able to revert?

(Or would patch Magisk to inactivate partition if possible...)

PF supports that, but am not sure how's we're making use of that if we can't skip the reboot.

 

[shoey63]

Actually I meant using updater engine...

Ah ok, a bit like One Plus.
Yeah nah, no such thing on Pixel devices.
It's Delta OTA or off to the PC/Laptop.

 

[pndwal]

My small interests in OTA is primarily for two benefits OTA could offer.
1- Performing it on the phone without needing a PC
2- No phone modification is required (no root)
3- Active partition is kept intact.

Yup, 1 is ideal...

1- In the context of your question, I don't know if it is possible and if it is, how it's done, how does one apply a full OTA all on the phone? assuming that you would need to download it and apply it.

I don't know what's available on Pixel, but w/ MIUI we can download latest full OTA package within Updater or select others as shown in post above... Though it might be the same...

Nb. In MIUI the extra options are hidden; users must tap MIUI logo in Updater 5 times to get access...

Doing so on the PC, would offer no benefit compared to Factory flashing, unless #2

True...

2- If the OTA image is modified in any way, than it will fail, and I'm thinking in the context of injecting a patched boot to gain root access on a phone that has the bootloader locked.

That's certainly true of delta (streamed incremental) OTAs since they need bit-perfect previous ROM images installed to generate the new images from the tiny quantity of differential data blocks... I wasn't sure if it's true when applying full OTAs or if the same checks are made, but you may be right that AVB will break installation in any case...

3- I don't know how to interrupt Full OTA sideloading to stop making it boot to system after completion, to gain an opportunity to flash a patched boot image before booting to system (of course bootloader needs to be unlocked for this) but the benefit here is that the previously active slot is not touched and system partition is not overwritten by system-other image as is the case for factory image flashing.

Meaning delta (partial, differential only) factory images as opposed to full OTA images here?... Of course both types are still factory images ...

But looks like this should simply work like delta OTAs in Xiaomi A/B devices by following the official doc linked above, and with the advantage of not unrooting the current active partition as you mention.

I can't test this as I have only two A-only Xiaomi devices... PW

 

[Lughnasadh]

3- I don't know how to interrupt Full OTA sideloading to stop making it boot to system after completion, to gain an opportunity to flash a patched boot image before booting to system (of course bootloader needs to be unlocked for this) but the benefit here is that the previously active slot is not touched and system partition is not overwritten by system-other image as is the case for factory image flashing.

It's been a while since I sideloaded an OTA, but if I remember correctly once the sideloading is complete you'll still be in recovery mode and you have to choose "Reboot to system now" (or something like that) before it reboots. But like I said, it's been a while...

 

[pndwal]

I have never seen it, it does not mean it doesn't exist, just that I have never seen it, besides my exposure would be super limited when updated friends' family's phones, my phones have not been going through that for ages.

I would hope and expect not, otherwise it would defeat the purpose of OTA, what if something goes wrong, how would it be able to revert?

Sorry, meant the inactive slot will be written to without issue of course! ... My bad, corrected post... PW

 

[badabing2003]

It's been a while since I sideloaded an OTA, but if I remember correctly once the sideloading is complete you'll still be in recovery mode and you have to choose "Reboot to system now" (or something like that) before it reboots. But like I said, it's been a while...

Right, I had forgotten as well,
I just tested this,
When you sideload OTA, you have the option to reboot to bootloader or system.
And when you successfully reboot to system, the slot is switched.
I will test next to flash a patched image before rebooting and see if it will complain.