Magisk General Support / Discussion

Search This thread

paper88

Senior Member
Oct 17, 2017
143
26
Zurich
OnePlus 10 Pro
Nothing Phone 1
Hello together
If I tick some apps in the denylist and leave magisk app, some apps untick it themself: Android Auto, Cell Broadcast Service, Google Services Framework, Networkmanager and Tethering. If you wondering why I hide this apps, I just hide all Apps from google. Are there any limitation of hide apps in the list?
 

J.Michael

Recognized Contributor
Jan 20, 2018
2,062
2,460
Samsung Galaxy Tab A series
Hello together
If I tick some apps in the denylist and leave magisk app, some apps untick it themself: Android Auto, Cell Broadcast Service, Google Services Framework, Networkmanager and Tethering. If you wondering why I hide this apps, I just hide all Apps from google. Are there any limitation of hide apps in the list?
You are not supposed to "hide all apps", you are generally advised to hide as few apps as possible; hide an app only when necessary.

I don't know whether "hide all apps from google" means "hide from Google all apps" or "hide any app you think was produced by Google", but both are bad ideas.

In particular, hiding some Google processes can cripple Android.

There have been posts about USNF or Shamiko (not necessarily both, I just don't remember the details) removing some Google process from the deny list because it (the module, USNF or Shamiko) handled that process specially. I do not remember reading about those other processes you say are getting unticked.
 

paper88

Senior Member
Oct 17, 2017
143
26
Zurich
OnePlus 10 Pro
Nothing Phone 1
You are not supposed to "hide all apps", you are generally advised to hide as few apps as possible; hide an app only when necessary.

I don't know whether "hide all apps from google" means "hide from Google all apps" or "hide any app you think was produced by Google", but both are bad ideas.

In particular, hiding some Google processes can cripple Android.

There have been posts about USNF or Shamiko (not necessarily both, I just don't remember the details) removing some Google process from the deny list because it (the module, USNF or Shamiko) handled that process specially. I do not remember reading about those other processes you say are getting unticked.
Thanks for feedback, i just heard somewehere that google could recognise root over other google apps. I check again and will untick all unnecessary apps
 

klodfor

New member
Jul 31, 2020
4
0
Guys, can you help me? Post #39854. Magisk 17+ not work on next device:
- ZTE Blade V9
- ZTE Blade V9 Vita
- ZTE Blade A7 Vita
- ZTE Blave V8
- ZTE Blade V8 Mini
- ZTE Blade V8c
- ZTE Blade A6
- ZTE Blade A6 (Claro)
- ZTE Blade A6 (Movistar)
- ZTE Blade A6 Lite
- ZTE Blade A0622 (voyage)
- ZTE Blade A6 MAX
- ZTE Blade A522
- ZTE Blade A520
- ZTE Smart Fresh 5
confirm not work 16.7+ above
 

Nergal di Cuthah

Senior Member
Sep 20, 2013
2,177
1,240
Google Pixel 6 Pro
These posts are from 2020 magisk has evolved greatly since then.
Please layout your question for a modern audience. State your device, magisk version android version and issue clearly.
Thanks it'll be good to provide help to you.

Especially since the first post you quoted refers to a post that at that time hadn't been created
 

Mowca

Senior Member
Mar 31, 2018
74
9
After updating magisk and restarting the phone, the phone goes into bootloop. No update method works... inatall .apk, twrp, directly from the app.Does anyone have a way to update correctly?
Galaxy s10e
Lineage 18.1
Magisk 23.0
 

alexandrew74

Member
Jan 31, 2016
7
1
Hi! I have POCO M3 Pro 5G (Camellian). The only easy way to install Magisk for me is to replace the stock boot image with Magisk's repacked one and flash it together with the new firmware through fastboot (including empty verity file, by editing flash_all_except_data_storage.bat) - tried both stock MIUI 12.5 and the last 14 (Global).
But after this Magisk is continuously asking for an "advanced installation", but the "direct install" option has no effect on the phone: Magisk asks and asks for the "advanced install" and also can never update to newer versions.
Though everything that requires root works fine yet, I'm very curious why Magisk considers it's own installation as inferior and how to overcome this issue.
 
  • Like
Reactions: J.Michael

kullurumanoj

Senior Member
Aug 10, 2014
61
22
Hyderabad
Hello All, Is anyone able to use nfc feature on cred or paytm? In paytm app it says the functionality isn't available due to security reasons. I'm using hml, I'm not a developer, lsposed and xprivacylua setup. Please help me in debugging the issue
 

zgfg

Senior Member
Oct 10, 2016
9,639
7,503
Redmi K20 / Xiaomi Mi 9T
Xiaomi Mi 11
Hello All, Is anyone able to use nfc feature on cred or paytm? In paytm app it says the functionality isn't available due to security reasons. I'm using hml, I'm not a developer, lsposed and xprivacylua setup. Please help me in debugging the issue
Please , for the beginning, find a thread about Google Pay and read about USNF module and Play Integrity attesting (OP posts)

It will not work with XLua. You must even manually remove XLua remaining folder (apps detect it)
 
  • Like
Reactions: J.Michael and ipdev

J.Michael

Recognized Contributor
Jan 20, 2018
2,062
2,460
Samsung Galaxy Tab A series
After updating magisk and restarting the phone, the phone goes into bootloop. No update method works... inatall .apk, twrp, directly from the app.Does anyone have a way to update correctly?
Galaxy s10e
Lineage 18.1
Magisk 23.0
How was Magisk 23 installed? Did it come as part of Lineage 18?

If you were running with Magisk 23, and you have modules installed, it is likely they are not compatible with newer Magisk.

If you can restore your original configuration -- Lineage 18 and Magisk 23 -- I think you should stick with it.

If you are determined to update Magisk, start by uninstalling, or at least dissbling, all modules while you have a working system. Then see if updating Magisk gives you a working system. Then, very slowly, find replacements for your old modules.
 
  • Like
Reactions: ipdev

ipdev

Recognized Contributor
Feb 14, 2016
2,529
1
5,106
Google Nexus 10
Nexus 7 (2013)
After updating magisk and restarting the phone, the phone goes into bootloop. No update method works... inatall .apk, twrp, directly from the app.Does anyone have a way to update correctly?
Galaxy s10e
Lineage 18.1
Magisk 23.0
I have run into it (every now and then) updating Magisk using a previously patch image.
- Magisk patched boot image detected
Bootloop and/or a forever (infinite) boot.

If it is just updating Magisk, use a clean (stock) boot image.
In your case, the stock Lineage 18.1 boot image.

For me, if the update failed..
- I normally flash the stock boot image back and reboot.

Since I still have the newer Magisk app (Manager) installed.
- Push the stock boot image to the device (if it is not already there).
- Use the "Select and Patch a File" option to patch the stock boot image.
- Stock boot image detected
- Pull the new Magisk patched boot image.
- Flash (install) the new patched boot image.

---

To complicate my reply.

Depending on the device..
I use the hardware key-combo to boot into bootloader.
- Flash the current stock boot image to the device.
- Use fastboot to 'boot' a previously patched boot image.
- Then use the "Direct Install" option to install.
- Stock boot image detected

Hope it helps more than confuse. 🙃

Cheers. :cowboy:
 

ipdev

Recognized Contributor
Feb 14, 2016
2,529
1
5,106
Google Nexus 10
Nexus 7 (2013)
Hi! I have POCO M3 Pro 5G (Camellian). The only easy way to install Magisk for me is to replace the stock boot image with Magisk's repacked one and flash it together with the new firmware through fastboot (including empty verity file, by editing flash_all_except_data_storage.bat) - tried both stock MIUI 12.5 and the last 14 (Global).
But after this Magisk is continuously asking for an "advanced installation", but the "direct install" option has no effect on the phone: Magisk asks and asks for the "advanced install" and also can never update to newer versions.
Though everything that requires root works fine yet, I'm very curious why Magisk considers it's own installation as inferior and how to overcome this issue.
I have run into if once or twice.
Sorry I do not remember exactly how I fixed it. 🙃
Might have been fixed in Magisk.


The message comes when the current Magisk (demon) is out of sync with Magisk.
The last time I ran into it, I do not remember what fixed it. 😥

Try clearing cache and data of the Magisk app.
Assuming it is the same version that is patched into your boot image.

Clear the cache and data of the Magisk app and uninstall the app.
Reboot and install the Magisk app again.

Delete /data/adb and let Magisk recreate it.
This will kill all modules and Magisk settings.

Good luck. 👍

Cheers. :cowboy:
 
  • Like
Reactions: J.Michael

m0han

Senior Member
Apr 30, 2012
5,794
2,889
OnePlus 11

Attachments

  • Screenshot_20230605_072236.jpg
    Screenshot_20230605_072236.jpg
    123.8 KB · Views: 53

zgfg

Senior Member
Oct 10, 2016
9,639
7,503
Redmi K20 / Xiaomi Mi 9T
Xiaomi Mi 11
Yeah, I tried that last night... Either the fix is incomplete or I'm missing something as B/L status is still bypassed using LSP TEE Hide module... 🤔 PW
Null pointer exception for me with this latest v1.4.0 and v1.4.1
 

Attachments

  • Screenshot_2023-06-05-08-20-20-390_io.github.vvb2060.keyattestation-edit.jpg
    Screenshot_2023-06-05-08-20-20-390_io.github.vvb2060.keyattestation-edit.jpg
    188.9 KB · Views: 45
Last edited:
  • Like
Reactions: chiteroman

chiteroman

Senior Member
Nov 4, 2019
536
599
22
Oviedo
Samsung Galaxy J7
Xiaomi Mi A2 Lite
Yeah, I tried that last night... Either the fix is incomplete or I'm missing something as B/L status is still bypassed using LSP TEE Hide module... 🤔 PW
The old module TEE Hide just throw an exception in getCertificateChain method, so apps can't know if bootloader is locked or not. I will try to update AttestationSpoofer to bypass (again) the locked bootloader. They are using another cert class, because it doesn't call this method like previous versions.
 
  • Like
Reactions: rodken

Top Liked Posts

  • 2
    My problem with banking apps is that after i updated Magisk Manager app to 26.3 it keeps coming back after i remove the app. 25.2 didn't do that. The app taht appears is not the full Manager, it only links to full app, but the banking apps still recognise it as Magisk Manager.

    How do i keep it unistalled?
    My banking apps work when i remove Magisk Manager.
    Pixel 7 pro.
    1
    My problem with banking apps is that after i updated Magisk Manager app to 26.3 it keeps coming back after i remove the app. 25.2 didn't do that. The app taht appears is not the full Manager, it only links to full app, but the banking apps still recognise it as Magisk Manager.

    How do i keep it unistalled?
    My banking apps work when i remove Magisk Manager.
    Pixel 7 pro.
    Check for hidden magisk apps or multiple magisk installations: https://forum.xda-developers.com/t/...t-pass-safetynet-on-pixel-7-pro-more.4505353/
    OP (post# 1)
    ~ ~ ~ Part II - INSTRUCTIONS ~ ~ ~...
    6. Root/Reroot with Magisk and Pass SafetyNet.
    Patching the init_boot.img - to root/reroot.
    Important Notes
    2. If you hid the Magisk manager app...

    When you were rooted did you use Displax / safetynet-fix magisk module v2.4.0-MOD_1.3?
    2
    My problem with banking apps is that after i updated Magisk Manager app to 26.3 it keeps coming back after i remove the app. 25.2 didn't do that. The app taht appears is not the full Manager, it only links to full app, but the banking apps still recognise it as Magisk Manager.

    How do i keep it unistalled?
    My banking apps work when i remove Magisk Manager.
    Pixel 7 pro.
    I do not know which version, but at some point Magisk started installing a manager if, upon booting, there was no manager.

    If you uninstall the manager and, without rebooting, try to use the banking app, does the banking app still seem to detect the Magisk manager app?

    If you need to clear caches and reboot before the bank app will give you a fair try, try uninstalling the Magisk manager just before running the bank app.

    Try searching the thread for talk about "freezing" an app -- that might be more convenient for you.

    Also, check to see if disabling the Magisk manager app is enough to satisfy the bank app. Then check to see if on the next boot Magisk is satisfied. (I'm not sure what Magisk could install if there is already a manager app but the manager app is disabled, but I've been surprised before.)
    1
    I do not know which version, but at some point Magisk started installing a manager if, upon booting, there was no manager.

    If you uninstall the manager and, without rebooting, try to use the banking app, does the banking app still seem to detect the Magisk manager app?

    If you need to clear caches and reboot before the bank app will give you a fair try, try uninstalling the Magisk manager just before running the bank app.

    Try searching the thread for talk about "freezing" an app -- that might be more convenient for you.

    Also, check to see if disabling the Magisk manager app is enough to satisfy the bank app. Then check to see if on the next boot Magisk is satisfied. (I'm not sure what Magisk could install if there is already a manager app but the manager app is disabled, but I've been surprised before.)
    The banking app works if i uninstall Magisk Manager and dont reboot.

    Manager appears after few days with no reboot.
    1
    The banking app works if i uninstall Magisk Manager and dont reboot.

    Manager appears after few days with no reboot.
    Hiding Magisk Manager is not hiding it from the bank app?
  • 9
    Latest Magisk Stable:
    Release Notes

    2023.9.4 Magisk v26.3​

    v26.3​

    • [General] Fix device information detection script
    • [General] Update BusyBox to 1.36.1
    • [General] Update toolchain that produces broken arm32 executables
    • [App] Fix root service unable to bind on OnePlus devices
    https://topjohnwu.github.io/Magisk/releases/26300.html

    👍 PW
    8
    I consider it to be unfair to define "modder" or "developer" as "anyone who dumps partitions/nandroid".
    <SNIP>

    <SNIP>
    Since it's not available without unlocking, 'anyone who dumps partitions / performs nandroid' has to agree to modify the device by unlocking which changes original product features including disabling security functions and other features... Then they generally install a custom (modified) recovery...😆
    <SNIP>
    I miss the days when I could just use adb to dump the data partition into an image file and flash it back. 😿️

    Better yet, when I could wipe system, install a different OS version and leave userdata alone.
    [The original Clean/Dirty flash install.] 🙃️

    As for the Cat and Mouse game...

    My money is on the Mice. 😜️
    "Look, sorry - are we talking about the little white furry things with the cheese fixation and women standing on tables screaming in early sixties sit coms?"

    Slartibartfast coughed politely.

    "These creatures you call mice, you see, they are not quite as they appear. They are merely the protrusion into our dimension of vast hyperintelligent pandimensional beings. The whole business with the cheese and the squeaking is just a front."
    ― Douglas Adams, The Hitchhiker's Guide to the Galaxy

    Cheers all. :cowboy:

    PS.
    I miss FlashFire.
    😥️
    8
    This illustrates why I always want to be able to use a device upon which TWRP (or perhaps OrangeFox) is functional. As long as I've taken a proper full nandroid backup of a previous working system, I can easily nandroid-restore that working system after an upgrade, if I wish.

    I am not happy with Google for continuing to "enhance" (ha ha!) Android as time goes on,
    Yeah... And Microsoft should have stayed with DOS, and maybe Windows as a DOS add-on!...
    thereby making it more and more difficult to get TWRP and OrangeFox working with newer Android versions.
    That's certainly NOT their intention...

    There's a lot to be said for new innovations and OEM requirements both in the mart of competitive commerce and for the value -added benefits to general Android users...

    Just as a few examples,
    • SAR/2SI enhancements allow for A/B partitioning and 'seamless' (streamed) delta OTA updates,
    • Shared blocks architecture allows for dynamic sup-super partitions which may be RO but are resizable with no unused space, upgradable to larger /system etc in future and space optimised/saving etc,
    • Project Treble (Android 8+)
    https://www.xda-developers.com/goog...ze-android-so-oems-can-update-devices-faster/
    modularised Android so that OEMs can serve Android updates more quickly by reducing OEM dependence on SoC vendors for every single OS update and introduced a new 'vendor interface' and Vendor Test Suite (VTS)... It also facilitated
    • The GSI Project (Android 9+)
    https://developer.android.com/topic/generic-system-image
    which allows app developers to install and run the latest Android Generic System Images to perform app testing on a variety of existing Android devices, and use GSIs from different Android OS release stages... Extra benefits include:
    - Broader test coverage on a greater set of real devices
    - More time to fix app compatibility issues
    - More opportunities to fix compatibility issues in Android that are reported by app developers
    • Project Mainline (Android 10+)
    https://www.xda-developers.com/android-q-project-mainline-security/
    (modules:)
    https://www.xda-developers.com/android-project-mainline-modules-explanation/
    expands on Treble's modularisation to further address fragmentation, adding Android Pony EXpress update packages to allow updating system modules (APEX includes all needed libraries, ART, HALs and precompiled code on addition to apps) through Google Play in Android 10 and 25 new modules with A11, as well as reducing how dependent Google is on OEMs for delivering security updates to key OS components. It also facilitated
    • The GKI Project (Android 11+)
    https://source.android.com/docs/core/architecture/kernel/generic-kernel-image
    with its Generic Kernel Image is an essential change aimed addressing the issue/costs of fragmentation which "has several negative effects on the Android community". GKI/Mainline reductions in fragmentation thus:
    - Make security updates less labor intensive
    - Allow merging Long-Term Supported updates
    - Removes factors that Inhibit Android platform release upgrades
    - Allows easier contribution of kernel changes back to upstream Linux

    So Treble and Mainline, with their GSI and GKI changes/requirements, are initiatives to facilitate easier updates for vendors, give incentive to support devices much longer, etc.

    Google is in the business of promoting it's mobile OS and producing development milestones that reduce costs, improve efficiency, lifecycle, specs etc for OEMs and end users in order to stay competitive, relevant, innovative and appealing... And they make major architectural changes for these reasons...

    They aren't in the game of "making it more and more difficult to get TWRP and OrangeFox working"; they appreciate these efforts but (quite reasonably) have the (different) priorities mentioned above...

    Just as with Magisk injection, there is much pressure on Dee's Troy and team (and other custom recovery teams) to get TWRP functioning properly, let alone to mount and decrypt user data with an ever changing Android architecture, but there are clearly more complex considerations than for simple Magisk injection... Even so, Google allows and even supports such custom mod efforts...

    Moreover it's not Google's fault that community projects like TeamWin find it difficult to devote the time, conscript the Devs or otherwise overcome obstacles needed to properly support new Android iterations... They actually supply clear documentation as part of AOSP for these changes to benefit all Android devs, whether OEMs, app makers or custom modders...

    I don't really know why TWRP has not progressed past Oct 2022 3.7.0 A12 base builds at this time despite the fact that 'Android 13 development had started' already, but the difficulty they have keeping up is not new... I note that everything there is still © 2014 to 2022, also that:
    TWRP development is done by roughly 4 people at this point. We also have a large support community with many people who are willing to answer questions and help people with their devices either through our Zulip channel or on forums like xda-developers.
    https://twrp.me/about/
    and that, just as when Dees Troy lamented that 'real life' was preventing TWRP keeping pace, the four base team members are still appealing for volunteers:
    We need your help! The bulk of TWRP work is done by a handful of people on a volunteer basis. We have pushed most of our device files to our github and we have a gerrit instance. If you have the ability, please help us maintain our official devices and/or add your device to our official device list. Thanks in advance!
    -----​

    Despite the difficulty the TWRP four have keeping up with the Google juggernaut, apparently many devices running A13+ have at least unofficial TWRP support with working decryption. Some won't allow permanent flashing but temp booting TWRP works nonetheless, and some have other issues...

    Re devices launched with Android 13:

    Just on Thursday, Dev @Nebrassy posted a TWRP build for OnePlus 11 which is apparently working despite some niggles:
    https://forum.xda-developers.com/t/recovery-12-unofficial-teamwin-recovery-project.4625181/

    This device has dedicated /recovery_a and /recovery_b partitions and Qualcomm SoC, and the Dev doesn't even own the device...

    For Pixel 7 series, the delay getting TWRP w/ decryption working seems to be Tensor SoC / device tree syncing and possibly StrongBox / KeyMint / Titan chip implementation(?) rather than general Android Architectural changes and initiatives.

    However, just yesterday @Wishmasterflo posted a test build of OrangeFox recovery (this is "synced with the latest Teamwin changes", and originally from a Dev who later joined LineageOS) for the Pixel 7a:
    https://forum.xda-developers.com/t/...g-thats-being-worked-on.4532237/post-88986509
    Nb. The Dev cannot test ATM as his device is still locked...

    Pixel 7a users: If someone tests and this works, I'm sure custom recovery support for Pixel 7 series devices will gain momentum...

    Takers?
    -----​

    ... FWIW, some modders will experiment/toy with the latest devices / Android versions as soon as they arrive... Others will stay with old tech because of affordability but migrate ASAP... Still others will refrain as long as possible, whether out of nostalgia or for other reasons...

    Similarly, some car drivers will migrate to EVs quickly... Others will when the price point is more agreeable... Still others will refrain as long as possible, and some will hanker for the ICE age with the smell of petrol and the roar of engines long after it's gone!

    Personally, despite not being able to afford a Tesla yet, I think auto makers in general have not moved to new tech nearly fast enough!...I expect them to continue to "enhance" transportation options as time goes on however... And I cannot be unhappy when phone market leaders adapt, innovate and move with the times either...

    Just might be able to get me a 2nd hand P7Pro now that the P8's in the wind, and wire a fast-charge outlet into the dash of the ol Ford Perfect... 😜 PW
  • 1100
    This is the place for general support and discussion regarding "Public Releases", which includes both stable and beta releases.
    All information, including troubleshoot guides and notes, are in the Announcement Thread
    156
    Hello, I haven't given much support on XDA lately. It can be resulted from
    • University started and I have limited free time. In fact, I mostly develop during midnight
    • I live in Taiwan, which has large time zone differences between my European/American contributors/testers, which usually forces me to stay up late at night to discuss/test stuffs.
    • The new version is about to come, I don't want to spend effort on supporting old releases
    The planned update is delayed again and again, to some point I think I'll shed some light about what has been happening lately, also along with some announcements.

    New Forum!
    As you might have already discovered, Magisk got its own subforum on XDA! Many thanks to all the support you gave me, and much more information/features/support is about to come!
    **For developers supporting all the devices that are not using standard Android boot format, feel free to create threads in this section (actually, PLEASE do so) for your favorite devices after v7 is out. As I currently know, Asus devices require signing the boot image before flashing, and is model dependant; Sony devices seems to use ELF kernel that is unpatchable, or some has two ramdisks (inner + outer), both requires different workarounds; LG bootloader locked devices has to manually "BUMP" the boot image after flashing Magisk..... and there may be lots of other crazy boot image formats that haven't come up to my attention yet.
    It is impossible for me to support all these non-standard boot images, and I hope the community can collaborate to make Magisk running across all the devices. Overall, community collaboration is what XDA about :D

    The Pixel Phone
    Some of you might already know this news, that the next Pixel Phone right around the corner seems like it does not have ramdisk in boot image, which pretty much wrecked Magisk in all ways. However, it pretty much doomed root itself too. Kernel modifications is inevitable IMO, so I'll try to migrate my scripts to C programs that could possibly be included into the kernel itself. Note that I'm not familiar with linux kernel, I'm not even sure if my idea and concept is correct or not. But once the device is available, I think developers will find a way to bypass all the difficulties, and I'll do my best to learn things ;)

    Current Progress
    In the past month, I've spent quite some time learning SELinux, so that I can avoid using SuperSU's sepolicy patches. Thanks to the helps and tips from @phhusson and @Chainfire, I finally have a much clearer understanding of how SELinux works. The Magisk core parts (the scripts, boot image patches, new features, more supports) are actually done some time ago. What is causing all the delays is the Magisk Manager.
    To be completely honest, although I can code in Java without much issues, Magisk Manager is actually my first Android application, I had to reach out for assistance, and fortunately awesome developers like @DVDandroid and @digitalhigh contributed a lot, which makes the current Manager awesome.
    After the repo system and module management is mostly done, I was about to do some adjustments and release, but what we really done is decided to add another feature: auto-unroot with per-app settings. I decided to wait for it to be finished, and then do my adjustments. Due to reasons that'll be mentioned later, this feature will likely not be available for the next release (should come in future updates)

    Safety Net Disaster
    Those who are using Magisk for Safety Net bypass purposes must have known that Google recently updated the detection method of my Systemless Xposed. I still have no idea what Safety Net is detecting, so currently I cannot fix it on my side (also because I'm busy working on the next update). However, suhide developed by @Chainfire is able to hide Xposed and worked fine.
    However, only my Systemless Xposed v86.2, which is based on SuperSU's su.d, is supported using that method. v86.2 and v86.5 (latest, Magisk based) have nearly identical binaries, and the only difference is the path where the binaries are stored.
    I'm still not sure what's the real issue for it not being supported, I just hope it is not done intentionally.

    Conclusion
    Due to the fact that my Safety Net bypass is not 100% perfect now, I do not want to spend any more time waiting for auto-unroot to be polished. What I'm doing now is finishing up all the things I'd like to change in Magisk Manager (it has been a while since I last contributed to Manager, my fellow developers are doing all the heavy job), which might take a little more time, after that, packed with tons of information to be announced in Magisk Section, I'll release the long awaited update.

    Hope this lengthy post gives you the idea of the whole situation, and again thanks for all your support!!
    121
    Ah, some Chainfire bashing, I hope it is not too late for me to exercise additional villainy.

    First, let me make clear I have nothing against @topjohnwu, nor against Magisk. Magisk is an interesting project and it certainly displays @topjohnwu ingenuity and persistence. I don't doubt we will see more interesting things from his hands.

    -------------------------

    What has happened here is not all that dark and complicated, from either end. I returned from holidays, and someone pointed me at Magisk. My first thought: interesting!

    Among other things, the thread lists some issues with SuperSU, which in combination with the phrase The developer also requests users to not bug Chainfire with compatibility requests for SuperSU with Magisk from the portal article, raised my left eyebrow by nigh half an inch. The popular systemless xposed mod is apparently now based on it, and apparently it now no longer works with SuperSU, and apparently I'm not supposed to fix that, nor any of the other found issues. I found that a bit weird. So yes, I have told @topjohnwu that I was a bit surprised he was posting about issues with SuperSU without notifying me about them (I can't fix or help fix issues I'm not aware of, after all).

    He's also spreading a modified version of the SuperSU package, which is not all that uncommon, nor necessarily a problem. I have not looked into what he modified, I only ran a few quick tests on one of my devices, and found some commonly used commands run as root to be broken. I have informed him of this as well.

    It appears the tool of choice for Magisk is phh's Superuser, because of some of the mentioned issues with SuperSU. That's fine by itself, but fixing issues in that superuser by incorporating SuperSU's binaries into it is a somewhat questionable practise. After all, SuperSU is a commercial closed-source package that helps pay for my dinner, and superuser is a direct competitor. I have informed him that I was surprised he did this without asking for permission. I have expressed similar surprise on him spreading a modified version of LiveBoot (which helps pay for a snack now and then).
    @topjohnwu has also stated that Magisk's scripts are largely influenced by mine (I have not checked). Scripts based on mine are used all over the place on XDA, some people have crafted amazing things based on them, I have never made an issue of this (otherwise I would have just made them binaries). But yes, I have also stated to him that I don't think it's very nice to base something on one program, and then using that to (almost exclusively) push something directly competing with that program.

    tl;dr Towards @topjohnwu, I have:
    - expressed surprise he has issues getting Magisk to work with SuperSU, and has chosen not to inform me about those
    - expressed surprise he is using SuperSU binaries in a competing superuser without permission
    - expressed surprise he is posting a modified LiveBoot without permission
    - informed him of issues with the modified SuperSU he has posted
    - let him know I thought it wasn't very nice to be applying my scripts to benefit seemingly exclusively that same competing superuser

    To be crystal clear:
    - I have not asked for an apology
    - I have not asked for Magisk to be abandoned, neither the root hiding nor systemless module parts, and certainly not systemless xposed
    - I have not made an issue of any of this anywhere, until this post
    - I have not even specifically asked for anything to be taken down (though obviously in my opinion the other superuser package mixed with SuperSU's binaries, as well as the LiveBoot package, should go)
    - I have not reported this thread to XDA moderators for copyright violations or otherwise

    While my conversation with @topjohnwu may not win any awards for being friendly (though it may win some for brevity), I think all things considered my response has been rather mild. To be perfectly honest, until the apology post, I thought this was over with already. I think the apology post was triggered because I haven't replied to his last PM for a while - I was in the zone, it happens.

    To emphasize again, I have nothing against @topjohnwu, Magisk, or systemless xposed, and it is certainly not my goal to see any of them go. If it can be made to work together with SuperSU, great.

    I get it though: you think of something, you want to see if you can make it work, you finally get it to work, you publish it, it takes off - enthusiasm gets the better of you. Maybe in the rush some mistakes are made. That doesn't mean you have to just drop it and run. None of my stuff would make it past 0.1 if I stopped at the first big mistake :)

    Aside from said being in the zone coding, I usually regret actually responding to these sort of things the day after, which has made me hesitant to reply. Surprise me.
    76
    Thread temporarily closed so everyone sees this.

    The flood of "SafetyNet isn't working for me either!" posts are not helpful, at all. Please refrain from posting further, it will be looked into. Please do not forget that not passing SafetyNet is 100% NORMAL AND INTENDED when you have an unlocked booloader or running custom firmware. These are workarounds and they will be worked around in turn.

    The Flash
    Forum Moderator

    EDIT: Thread is reopened... I will be cleaning any SafetyNet posts for a while to keep the thread clean for real issues.
    75
    Hello everyone!

    I am aware that Google has updated Safety Net that makes Magisk itself a no go for Android Pay. In fact, I witnessed the change live while I am developing the new magiskhide, which should hide all Magisk modules and Magisk installed root.

    Google is serious about Safety Net now, clearly hunting down all possibility to run Xposed with Safety Net passed. I spend quite some time examining the new security measures last midnight, and fortunately it seems that it is possible to run Magisk and root along with Safety Net if no Xposed is running. I'm glad I removed the old root toggle at the right time lol, that is no longer feasible with the latest detection.

    So stay tuned for the next update, it will come with bug fixes, along with the new magiskhide to bypass that Safety Net.

    Google, how will a few systemless mods do any harm :p:p