Magisk General Support / Discussion

Search This thread
By:
Advanced…
X

xbgpx

Senior Member
Mar 24, 2016
172
84
0
denpasar
Didgeridoohan said:
Inside the module directory, in the system folder, look for a file named placeholder (or any other file that isn't normally found in the root of your /system directory). Any file like that may cause a bootloop. It's currently under investigation.
Click to expand...
i cant found that file can you give me screenshoot ty advance:eek:
 
SB13X

SB13X

Senior Member
Jun 14, 2010
694
203
0
England, UK
Samsung G935F Samsung S7 Edge on Three UK FW

I've tried using the new method to create patched_boot.img.tar to flash with ODIN.
ODIN flashes successfully but device just hangs at boot animation.
Reboot and flashed stock boot.img and boots fine.

Opened up New Issue on @topjohnwu GitHub here: https://github.com/topjohnwu/Magisk/issues/356

I've seen these quotes from
@Didgeridoohan
Samsung devices are quirky. The normal installation instructions are in the release thread. If you're device requires a special installation process you're probably better off checking in your device's forum.
Click to expand...
@Artim_96
No. You have to unlock the bootloader since you need to be able to fish a modified boot image. Only exception are Samsung devices since these can be flashed with ODIN... Which most likely will exclude the locked down is versions
Click to expand...

With v14.0 and this method being so new I can't find anything on a special installation process as I want to install using new method only. Any advice or anything further I can supply to help Troubleshoot.
 
A

Artim_96

Senior Member
Feb 15, 2013
2,455
729
183
SB13X said:
Samsung G935F Samsung S7 Edge on Three UK FW

I've tried using the new method to create patched_boot.img.tar to flash with ODIN.
ODIN flashes successfully but device just hangs at boot animation.
Reboot and flashed stock boot.img and boots fine.

Opened up New Issue on @topjohnwu GitHub here: https://github.com/topjohnwu/Magisk/issues/356

I've seen these quotes from
@Didgeridoohan

@Artim_96


With v14.0 and this method being so new I can't find anything on a special installation process as I want to install using new method only. Any advice or anything further I can supply to help Troubleshoot.
Click to expand...
Best will be to just wait for topjohnwu to take a look at the images and see if he sees what went wrong.
But you can try something: get the whole .tar.md5 flashable of the firmware version you are running, remove the .md5 from the end of the name and give that tar file Magisk manger, maybe it's able to extract the boot image from there. Make sure that you load the .tar.md5 into Odin before renaming, then it will check if the file is intact.
If it fails again, extract the patched_boot.img, flash it through TWRP and see if ODIN just had a problem flashing it properly
 
Last edited:
SB13X

SB13X

Senior Member
Jun 14, 2010
694
203
0
England, UK
Artim_96 said:
Best will be to just wait for topjohnwu to take a look at the images and see if he sees what went wrong.
But you can try something: get the whole .tar.md5 flashable of the firmware version you are running, remove the .md5 from the end of the name and give that tar file Magisk manger, maybe it's able to extract the boot image from there. Make sure that you load the .tar.md5 into Odin before renaming, then it will check if the file is intact.
If it fails again, extract the patched_boot.img, flash it through TWRP and see if ODIN just had a problem flashing it properly
Click to expand...

Thanks for the fast response and I'll have a look at doing that after couple of good suggestions.

I'm not that desperate for MAGISK that I'd installed TWRP. I've only become reinterested since the new method became available to keep everything else intact.
 
R

rason77

Member
Apr 20, 2014
28
8
0
Im running a Galaxy s7 originally on AOSP and then when i tried to flash my Modules all of the Modules disappeared in the manager even if tried to flash them all in recovery or all in the manager. Inside the manager i get a warning that says "sendfile failed with 2: No such file or directory." And from there nothing on Magisk worked, then i went to a stock rom thinking it was AOSP messing it up and it still doesn't work Please Help. I've tried uninstalling magisk and reinstalling , i've tried different settings in the Manager and nothing fixed it and it doesn't happen when i flash one module it happens to everything i try to flash , and i also get a failed to process error on the repo
Samsung S7 (AOSP and Stock)
Magisk 14
Magisk Manager 5.3.0
 
S

Semela

Member
Sep 3, 2017
13
0
0
I needed to reboot my phone and for some reason now when I launch magisk manager it only shows 3 things at the main page:
Installed Magisk Version v14.0
14.0MAGISKSU(topjohnwu)
Uninstal

SafeteyNet test is gone :))) What gives?


Thanx.


PS ROFL>.. I forgot I didn't have internet connection. active..
 
Last edited:
jenslody

jenslody

Senior Member
Jun 13, 2017
1,389
3,077
138
Semela said:
I needed to reboot my phone and for some reason now when I launch magisk manager it only shows 3 things at the main page:
Installed Magisk Version v14.0
14.0MAGISKSU(topjohnwu)
Uninstal

SafeteyNet test is gone :))) What gives?


Thanx.


PS ROFL>.. I forgot I didn't have internet connection. active..
Click to expand...
No internet, no safetynet.
SafetyNet-test needs an internet connection.
 
You must log in or register to reply here.

Similar threads

noidodroid
Magisk MultiROM Support
Replies
3
Views
357
MoistPicklez
MoistPicklez
D
Magisk supported devices
Replies
2
Views
12K
D
DerEngel
Killua96
[Discussion] Fate Go Magisk Discussion Thread
Replies
50
Views
15K
Me_Ashish_
Me_Ashish_
Heisenberg
[Discussion] PokeMon Go Magisk Discussion Thread
Replies
5K
Views
603K
Z
Zelda mjau
D
Sony Support for Magisk
Replies
0
Views
2K
D
Devo7v

Top Liked Posts

24 Hours 30 Days All time
  • 4
    Didgeridoohan
    Didgeridoohan
    me_droid said:
    Anyone taken the plunge on 22.1, updating within the app by just pressing the update button? TJW refers us to the release notes for 22.0 so assume we have to unhide magisk again?
    Click to expand...
    There's no need to unhide the app if you're already on v22+. That's only necessary when updating from older releases.
    View
    3
    D
    DiamondJohn
    Raptor270 said:
    Hi,

    I installed the new magisk update through magisk and since then my Xiaomi Mi Mix 3 keeps random rebooting.
    Any idea whats causing this?

    Thanks for your help
    Click to expand...
    I didnt read if it was covered in Didgeridoohan 's link,but my normal first port of call for a random reboot or bootlook is the last_kmsg
    View
    2
    I
    ineedroot69
    aryanhington said:
    does anybody know when should /sbin/.magisk/config have keepverity and forceencryption disabled and when should it be enabled?
    Click to expand...
    what are you doing? why you manually changing them?

    anyway here's what they does from the god himself John Wu

    preserve avb 2.0/dm-verity
    fdsfdsf.png

    Preserve force encryption
    fdsfdsf.png

    View
    1
    P
    pndwal

    Latest Debug (Canary)​

    Changelog and Release Notes:​


    Magisk (e136fb3a) (22102)​

    • [General] Remove all pre Android 5.0 support
    • [MagiskPolicy] Remove unnecessary sepolicy rules

    Diffs to v22.1​

    • [General] Remove all pre Android 5.0 support
    • [MagiskPolicy] Remove unnecessary sepolicy rules
    👍 PW
    View
    1
    Didgeridoohan
    Didgeridoohan
    jeffghh said:
    hi guys, which magsik version can i use to root galaxy s7 edge exynos?
    Click to expand...
    Spartacus500 said:
    Upload this version via TWRP, then update to the latest one
    Click to expand...

    Why not use v22.1 directly? Or is there some known incompatibility with the S7 Edge?

    And also, why not link directly to the files on John's Github? Always the safest way...
    View
  • 12
    P
    pndwal

    Latest Public (Stable / Beta)​

    Release Notes and Changelog:​


    2021.4.9 Magisk v22.1​

    This release is focused on fixing regressions and bugs. Check the v22.0 release notes if coming from older releases.

    Note: Magisk v22 is the last major version to support Jellybean and Kitkat. Magisk v23 will only support Android 5.0 and higher.

    Bug Fixes​

    • [App] Prevent multiple installation sessions running in parallel
    • [App] Prevent OutOfMemory crashes when checking boot signature on PXA boot images
    • [General] Proper cgroup migration implementation
    • [General] Rewrite log writer from scratch, should resolve any crashes and deadlocks
    • [General] Many scripts updates fixing regressions
    • [MagiskHide] Prevent possible deadlock when signal arrives
    • [MagiskHide] Partial match process names if necessary
    • [MagiskBoot] Preserve and patch AVB 2.0 structures/headers in boot images
    • [MagiskBoot] Properly strip out data encryption flags
    • [MagiskBoot] Prevent possible integer overflow
    • [MagiskInit] Fix sepolicy.rule mounting strategy
    • [resetprop] Always delete existing ro. props before updating. This will fix bootloops that could be caused by modifying device fingerprint properties.
    🎉 👍 PW
    View
    8
    osm0sis
    osm0sis
    io2345 said:
    @osm0sis
    Thank you for having an eye on that.
    Did the "ls" twice, first from a TWRP-terminal in recovery, second from a terminal while phone is "up and running".
    Click to expand...
    Looks like you have /dev/bootimg as your real partition location and it is still higher in the list in util_functions.sh like how I fixed it in the linked commit, so this is definitely a regression from some other recent change to Magisk.. sigh, I'll look into it. 🤔😕
    View
    6
    P
    pndwal

    Latest Canary Changelog, including Release Notes:​


    Magisk (9c0e1897) (22007)​

    • [General] Fix logic to copy sepolicy.rule during module installation
    • [resetprop] Always delete existing ro. props before updating. This will fix bootloops that could be caused by modifying device fingerprint properties.

    Diffs to v22.0​

    • [App] Prevent multiple installation sessions running in parallel
    • [App] Prevent OutOfMemory crashes when checking boot signature on PXA boot images
    • [General] Proper cgroup migration implementation
    • [General] Rewrite log writer from scratch, should resolve any crashes and deadlock
    • [General] Many scripts updates fixing regressions
    • [MagiskHide] Prevent possible deadlock when signal arrives
    • [MagiskHide] Partial match process names if necessary
    • [MagiskBoot] Preserve and patch AVB 2.0 structures/headers in boot images
    • [MagiskBoot] Properly strip out data encryption flags
    • [MagiskBoot] Prevent possible integer overflow
    • [MagiskInit] Fix sepolicy.rule mounting strategy
    • [resetprop] Always delete existing ro. props before updating. This will fix bootloops that could be caused by modifying device fingerprint properties.
    👍 PW
    View
    6
    osm0sis
    osm0sis
    io2345 said:
    No, the phone is an Estar Takee1.
    ROM is from here: Mikel Android 7 for Takee1
    and is itself a port from this ROM: RidonOS for Micromaxx A311
    Click to expand...

    io2345 said:
    You're right, sorry for that. Now here the installation log for canary-version:

    - Target image: /dev/BOOT
    - Device platform: armeabi-v7a
    - Installing: f152b4c2 (22005)
    nanddump: MEMGETINFO: Not a typewriter
    Parsing boot image: [boot.img]
    - Unpacking boot image
    ! Unsupported/Unknown image format
    ! Installation failed
    Click to expand...

    Didgeridoohan said:
    That was quick... Didn't even have to whisper your name three times in the mirror.

    Boot image is here:
    https://forum.xda-developers.com/t/magisk-general-support-discussion.3432382/post-84688655

    And this is supposedly the install log:
    https://forum.xda-developers.com/t/magisk-general-support-discussion.3432382/post-84686805

    And for good measure there's a Magisk log as well:
    https://forum.xda-developers.com/t/magisk-general-support-discussion.3432382/post-84695083

    And some device info:
    https://forum.xda-developers.com/t/magisk-general-support-discussion.3432382/post-84689305
    Click to expand...
    😛

    /dev/BOOT is known (usually) not an actual boot partition, hence nanddump failing.

    I had originally fixed this back here: https://github.com/topjohnwu/Magisk/commit/2aede97754fec67d393bde0c7725ed84d8c3c112

    So not sure if we're looking at some kind of a regression, or just a further edge case.

    @io2345 what's the actual, correct location of your boot partition? Please give me the output of `ls -alR /dev`
    View
    6
    zgfg
    zgfg
    #Xiaomi.eu, #OTA, #Magisk 22006, #Viper4Android, #sepolicy.rule

    This week, Xiaomi.eu weekly update 21.3.24 (MIUI 12.5, A11) was late a day and a half, hence I upgraded yesterday night

    As usual:
    - I downloaded the zip, extracted boot.img and patched (already from my previous Xiaomi.eu 21.3.18, rooted by Magisk 22006)
    - Flashed the Xiaomi.eu zip from TWRP, wiped Dalwik and Cache and rebooted
    - Then rebooted once again to TWRP and flashed the boot.img that was patched in advance

    I could probably flash its patched boot img right after flashing the 'OTA' zip (saving one time booting to the not-rooted system and rebooting to TWRP), but I rather play the safe and many times proven game

    Upon rebooting with the patched boot img, I have Magisk 22006 root again, with all modules (except V4A), root granted apps snd apps enabled for Magisk hide

    This time the old trick to make V4A did not work. Maybe because of the known sepolicy.rule bug in Magisk 22006, or maybe I was not 'patient' enough and made a mistake in steps

    Anyway, I also wanted to test, hence I modified V4A's post-fs-data.sh in accordance to:
    https://forum.xda-developers.com/t/...-0-viper4android-fx-2-7.3774651/post-84121895
    rebooted, and it did the trick 👍

    The modified post-fs-data.sh for:
    /data/adb/modules/ViPER4AndroidFX
    is zipped and attached

    The zip also contains DDC and Kernel folders to be copied ton Internalmemory: /Android/data/com.pittvandewitt.viperfx/files
    for V4A Convolvers and headphone profiles

    Hence now I have again AML, V4A plus another audio mode (320 kbps bitrate for my phone) and V4A is happilly again Supported and Proccessing (still in the Legacy mode)
    View
  • 1044
    T
    topjohnwu
    This is the place for general support and discussion regarding "Public Releases", which includes both stable and beta releases.
    All information, including troubleshoot guides and notes, are in the Announcement Thread
    View
    155
    T
    topjohnwu
    Hello, I haven't given much support on XDA lately. It can be resulted from
    • University started and I have limited free time. In fact, I mostly develop during midnight
    • I live in Taiwan, which has large time zone differences between my European/American contributors/testers, which usually forces me to stay up late at night to discuss/test stuffs.
    • The new version is about to come, I don't want to spend effort on supporting old releases
    The planned update is delayed again and again, to some point I think I'll shed some light about what has been happening lately, also along with some announcements.

    New Forum!
    As you might have already discovered, Magisk got its own subforum on XDA! Many thanks to all the support you gave me, and much more information/features/support is about to come!
    **For developers supporting all the devices that are not using standard Android boot format, feel free to create threads in this section (actually, PLEASE do so) for your favorite devices after v7 is out. As I currently know, Asus devices require signing the boot image before flashing, and is model dependant; Sony devices seems to use ELF kernel that is unpatchable, or some has two ramdisks (inner + outer), both requires different workarounds; LG bootloader locked devices has to manually "BUMP" the boot image after flashing Magisk..... and there may be lots of other crazy boot image formats that haven't come up to my attention yet.
    It is impossible for me to support all these non-standard boot images, and I hope the community can collaborate to make Magisk running across all the devices. Overall, community collaboration is what XDA about :D

    The Pixel Phone
    Some of you might already know this news, that the next Pixel Phone right around the corner seems like it does not have ramdisk in boot image, which pretty much wrecked Magisk in all ways. However, it pretty much doomed root itself too. Kernel modifications is inevitable IMO, so I'll try to migrate my scripts to C programs that could possibly be included into the kernel itself. Note that I'm not familiar with linux kernel, I'm not even sure if my idea and concept is correct or not. But once the device is available, I think developers will find a way to bypass all the difficulties, and I'll do my best to learn things ;)

    Current Progress
    In the past month, I've spent quite some time learning SELinux, so that I can avoid using SuperSU's sepolicy patches. Thanks to the helps and tips from @phhusson and @Chainfire, I finally have a much clearer understanding of how SELinux works. The Magisk core parts (the scripts, boot image patches, new features, more supports) are actually done some time ago. What is causing all the delays is the Magisk Manager.
    To be completely honest, although I can code in Java without much issues, Magisk Manager is actually my first Android application, I had to reach out for assistance, and fortunately awesome developers like @DVDandroid and @digitalhigh contributed a lot, which makes the current Manager awesome.
    After the repo system and module management is mostly done, I was about to do some adjustments and release, but what we really done is decided to add another feature: auto-unroot with per-app settings. I decided to wait for it to be finished, and then do my adjustments. Due to reasons that'll be mentioned later, this feature will likely not be available for the next release (should come in future updates)

    Safety Net Disaster
    Those who are using Magisk for Safety Net bypass purposes must have known that Google recently updated the detection method of my Systemless Xposed. I still have no idea what Safety Net is detecting, so currently I cannot fix it on my side (also because I'm busy working on the next update). However, suhide developed by @Chainfire is able to hide Xposed and worked fine.
    However, only my Systemless Xposed v86.2, which is based on SuperSU's su.d, is supported using that method. v86.2 and v86.5 (latest, Magisk based) have nearly identical binaries, and the only difference is the path where the binaries are stored.
    I'm still not sure what's the real issue for it not being supported, I just hope it is not done intentionally.

    Conclusion
    Due to the fact that my Safety Net bypass is not 100% perfect now, I do not want to spend any more time waiting for auto-unroot to be polished. What I'm doing now is finishing up all the things I'd like to change in Magisk Manager (it has been a while since I last contributed to Manager, my fellow developers are doing all the heavy job), which might take a little more time, after that, packed with tons of information to be announced in Magisk Section, I'll release the long awaited update.

    Hope this lengthy post gives you the idea of the whole situation, and again thanks for all your support!!
    View
    119
    Chainfire
    Chainfire
    Ah, some Chainfire bashing, I hope it is not too late for me to exercise additional villainy.

    First, let me make clear I have nothing against @topjohnwu, nor against Magisk. Magisk is an interesting project and it certainly displays @topjohnwu ingenuity and persistence. I don't doubt we will see more interesting things from his hands.

    -------------------------

    What has happened here is not all that dark and complicated, from either end. I returned from holidays, and someone pointed me at Magisk. My first thought: interesting!

    Among other things, the thread lists some issues with SuperSU, which in combination with the phrase The developer also requests users to not bug Chainfire with compatibility requests for SuperSU with Magisk from the portal article, raised my left eyebrow by nigh half an inch. The popular systemless xposed mod is apparently now based on it, and apparently it now no longer works with SuperSU, and apparently I'm not supposed to fix that, nor any of the other found issues. I found that a bit weird. So yes, I have told @topjohnwu that I was a bit surprised he was posting about issues with SuperSU without notifying me about them (I can't fix or help fix issues I'm not aware of, after all).

    He's also spreading a modified version of the SuperSU package, which is not all that uncommon, nor necessarily a problem. I have not looked into what he modified, I only ran a few quick tests on one of my devices, and found some commonly used commands run as root to be broken. I have informed him of this as well.

    It appears the tool of choice for Magisk is phh's Superuser, because of some of the mentioned issues with SuperSU. That's fine by itself, but fixing issues in that superuser by incorporating SuperSU's binaries into it is a somewhat questionable practise. After all, SuperSU is a commercial closed-source package that helps pay for my dinner, and superuser is a direct competitor. I have informed him that I was surprised he did this without asking for permission. I have expressed similar surprise on him spreading a modified version of LiveBoot (which helps pay for a snack now and then).
    @topjohnwu has also stated that Magisk's scripts are largely influenced by mine (I have not checked). Scripts based on mine are used all over the place on XDA, some people have crafted amazing things based on them, I have never made an issue of this (otherwise I would have just made them binaries). But yes, I have also stated to him that I don't think it's very nice to base something on one program, and then using that to (almost exclusively) push something directly competing with that program.

    tl;dr Towards @topjohnwu, I have:
    - expressed surprise he has issues getting Magisk to work with SuperSU, and has chosen not to inform me about those
    - expressed surprise he is using SuperSU binaries in a competing superuser without permission
    - expressed surprise he is posting a modified LiveBoot without permission
    - informed him of issues with the modified SuperSU he has posted
    - let him know I thought it wasn't very nice to be applying my scripts to benefit seemingly exclusively that same competing superuser

    To be crystal clear:
    - I have not asked for an apology
    - I have not asked for Magisk to be abandoned, neither the root hiding nor systemless module parts, and certainly not systemless xposed
    - I have not made an issue of any of this anywhere, until this post
    - I have not even specifically asked for anything to be taken down (though obviously in my opinion the other superuser package mixed with SuperSU's binaries, as well as the LiveBoot package, should go)
    - I have not reported this thread to XDA moderators for copyright violations or otherwise

    While my conversation with @topjohnwu may not win any awards for being friendly (though it may win some for brevity), I think all things considered my response has been rather mild. To be perfectly honest, until the apology post, I thought this was over with already. I think the apology post was triggered because I haven't replied to his last PM for a while - I was in the zone, it happens.

    To emphasize again, I have nothing against @topjohnwu, Magisk, or systemless xposed, and it is certainly not my goal to see any of them go. If it can be made to work together with SuperSU, great.

    I get it though: you think of something, you want to see if you can make it work, you finally get it to work, you publish it, it takes off - enthusiasm gets the better of you. Maybe in the rush some mistakes are made. That doesn't mean you have to just drop it and run. None of my stuff would make it past 0.1 if I stopped at the first big mistake :)

    Aside from said being in the zone coding, I usually regret actually responding to these sort of things the day after, which has made me hesitant to reply. Surprise me.
    View
    76
    nathanchance
    nathanchance
    Thread temporarily closed so everyone sees this.

    The flood of "SafetyNet isn't working for me either!" posts are not helpful, at all. Please refrain from posting further, it will be looked into. Please do not forget that not passing SafetyNet is 100% NORMAL AND INTENDED when you have an unlocked booloader or running custom firmware. These are workarounds and they will be worked around in turn.

    The Flash
    Forum Moderator

    EDIT: Thread is reopened... I will be cleaning any SafetyNet posts for a while to keep the thread clean for real issues.
    View
    74
    T
    topjohnwu
    Hello everyone!

    I am aware that Google has updated Safety Net that makes Magisk itself a no go for Android Pay. In fact, I witnessed the change live while I am developing the new magiskhide, which should hide all Magisk modules and Magisk installed root.

    Google is serious about Safety Net now, clearly hunting down all possibility to run Xposed with Safety Net passed. I spend quite some time examining the new security measures last midnight, and fortunately it seems that it is possible to run Magisk and root along with Safety Net if no Xposed is running. I'm glad I removed the old root toggle at the right time lol, that is no longer feasible with the latest detection.

    So stay tuned for the next update, it will come with bug fixes, along with the new magiskhide to bypass that Safety Net.

    Google, how will a few systemless mods do any harm :p:p
    View

New posts

Our Apps
Get our official app!
The best way to access XDA on your phone
Nav Gestures
Add swipe gestures to any Android
One Handed Mode
Eases uses one hand with your phone