---------- Post added at 06:29 PM ---------- Previous post was at 06:28 PM ----------
[/COLOR]
[/COLOR]
Well, It's Huawei Y5 2017
Last edited:
Magisk General Support / Discussion
- Thread starter topjohnwu
- Start date
Thanks for searching it but I have already rooted it and gained Super User rights and I am using TWRP as a custom recovery. I am using Magisk to give superuser rights because SuperSU app doesn't work
I am planning to compile a custom kernel myself but I need source code
Last edited:
Thank you for bothering
there was another problem tho, it seems the app somehow now checks if the bootloader is unlocked or not, if so the loading of the paygo service will fail to load with an unknown error. Still trying to figure out how to workaround this
Ja_som
Senior Member
- Apr 1, 2013
- 3,720
- 2,045
I created a module for you with that kl file, try it please, if it will work I will upload it to the Magisk repo.
Sent from my Nexus 5X using XDA Labs
Last edited:
Hello! I am running an Honor 8 with the Carbon rom and anytime I update Magisk to a version above 15 it removes the fingerprint option (thus rendering anything using it useless) and my lock screen crashes anytime I type in the correct pin. I'm currently sitting at Magisk 14 and everything is fine.
---------- Post added at 09:58 PM ---------- Previous post was at 09:54 PM ----------
This is basically the same problem I am having.
---------- Post added at 09:58 PM ---------- Previous post was at 09:54 PM ----------
Hi folks,
since I didn't find anything about my problem I try to find out what I done wrong - with your help
Context: Honor 8 (frd-l09-c432) running with ResurrectionRemix 5.8.4 made by OpenKirin-Team. Working perfect with magisk 14 and previous.
But I didn't get Magisk 15 and up to work properly. I tried many times in different way and setup. Every version.
Gatekeeperd is crashing. Fingerprint don't work. Lockscreen don't work. And I bet many more don't work - just didn't notice.
I followed these steps:
EDIT3: In case it's important: after successful installation of v15.x, reboot, device behaves like selinux=enforcing. In last_kmesg is shown that the kernel is started with parameter setenforce=1. Usually no problem except for this device. Behavior when switching to enforcing after reboot is exactly the same. I know, if it is like I think, it is primarily a ROM problem but has anyone got an idea to workaround? Since development for Kirin seems to be very hard...
Regards
Sent from my FRD-L09 using XDA Labs
This is basically the same problem I am having.
Thank you, thank you, thank you, you are amazing, dude.
I'll root my phone this week, and will try your module when I do so. This doesn't modify the /system partition, right?
Ja_som
Senior Member
- Apr 1, 2013
- 3,720
- 2,045
Magisk 15.3 can't remember/edit SU for apps on OmniRom 8.1 for OnePlus 3T
This has been reported a while ago and there's been no update to my knowledge but Magisk Manager loves to crash on OmniRom 8.1.0 (any version up to current 20180122-oneplus3-weekly). Every time you open an app that needs SU access, you get multiple prompts and sometimes crashes or failures to get root. Furthermore, you can't edit anything in Manager in the Superuser tab without a crash.
Here was the first report TMK: https://xdaforums.com/apps/magisk/mod-magisk-v1-universal-systemless-t3432382/post75035807#post75035807
And another: https://xdaforums.com/apps/magisk/mod-magisk-v1-universal-systemless-t3432382/post75091530#post75091530
The issue seems to be that Magisk can't write to the SQLite Database to store this request as approved forever and some have suggested that it's F2FS related. It also only effects Magisk 15.x as users report success on 14.x. Here's a short example of it crashing trying to use the Manager app.
More logs are attached. Given this only happens on 15.x, something has changed that it causes a DiskIO error when F2FS is used.
EDIT: Yes, I'm aware of the F2FS bug but even patched kernels are having issues in some cases on Oreo. This is a Magisk side issue. Also, the loopback mod doesn't resolve this either.
This has been reported a while ago and there's been no update to my knowledge but Magisk Manager loves to crash on OmniRom 8.1.0 (any version up to current 20180122-oneplus3-weekly). Every time you open an app that needs SU access, you get multiple prompts and sometimes crashes or failures to get root. Furthermore, you can't edit anything in Manager in the Superuser tab without a crash.
Here was the first report TMK: https://xdaforums.com/apps/magisk/mod-magisk-v1-universal-systemless-t3432382/post75035807#post75035807
And another: https://xdaforums.com/apps/magisk/mod-magisk-v1-universal-systemless-t3432382/post75091530#post75091530
The issue seems to be that Magisk can't write to the SQLite Database to store this request as approved forever and some have suggested that it's F2FS related. It also only effects Magisk 15.x as users report success on 14.x. Here's a short example of it crashing trying to use the Manager app.
More logs are attached. Given this only happens on 15.x, something has changed that it causes a DiskIO error when F2FS is used.
EDIT: Yes, I'm aware of the F2FS bug but even patched kernels are having issues in some cases on Oreo. This is a Magisk side issue. Also, the loopback mod doesn't resolve this either.
Last edited:
D
Deleted member 4463645
Guest
Bug report: I got Magisk Maganer to crash on open. Subsequently works fine.
https://hastebin.com/uvunepinax.txt
https://hastebin.com/uvunepinax.txt
I'm using carbon ROM on honor 8. With magisk 14 the fingerprint works. With new magisk it crashes.
Well, it seems there is a bug. Of you end up with Magisk manger reporting back that Magisk isn't installed again, see if the logs are still available from the logs tab. If not you might want to reboot to twrp and get them there from /cache
Does anyone have any insight regarding resizing magisk.img and/or utilizing magisk_merge on devices with A/B partitions? Modules which should auto-resize the image fail, and I've been subsequently unable to manually resize it via flashable zip or command line. Discussions that I've had in the terminal app systemizer thread have led me to believe that there's a commonality with folks facing similar issues also having A/B devices. I assume I'm probably not the first person to encounter this problem, wondering if there's any workarounds or alternative approaches. Otherwise, I'm willing to assist with diagnostics if need be. I am using an Essential PH-1, Oreo B3 which uses ext4 so I don't believe there to be any f2fs shenanigans occurring.
Specifically, I'm encountering this while attempting to use app systemizing modules in which case after 2 or 3 apps, once the 64MB cap is met or exceeded I am unable to systemize any further apps and am further unable to adjust the image size manually to accommodate additional apks.
Specifically, I'm encountering this while attempting to use app systemizing modules in which case after 2 or 3 apps, once the 64MB cap is met or exceeded I am unable to systemize any further apps and am further unable to adjust the image size manually to accommodate additional apks.
Last edited:
Ahh yes... The dreaded trying to copy to too small an image bug...
You need to over resize your image... Copy the stuff you want in the image... And then resize...
e2fsck in the terminal in TWRP will let you repair your image... And then resize it again...
Sent from my PH-1 using Tapatalk
Just got an update to Samsung Pay and something it triggering a security alert.
Pixel 2 XL Android 8.1 Janauary Security Release, Magisk 15.3
Screenshot:
https://ibb.co/ehBFZG
Pixel 2 XL Android 8.1 Janauary Security Release, Magisk 15.3
Screenshot:
https://ibb.co/ehBFZG
I Install Magisk In LG K7 and Safety Net Wont Pass Any Solution For this Please Let me know this is after the King Root and Everytime When i Flash Magisk is giving me and error Safety Net Won't Pass Any Solution for this
Similar threads
Top Liked Posts
-
1UPDATE: I got it to work by extracting and flashing the stock boot.img and recovery.img via odin. I guess that's a dirty fix and IDK why this worked and flashing the whole stock rom didn't
Ii'll check that folder (if I can install TWRP or something) in order to clean up, but my goal now is to reroot it.
No, but, I did one factory reset from Android's configuration menu in order to clean up, set up the phone and debloat it (I bought it used). It worked afterwards but I screwed up when debloating so then I did the stock rom flash.
I'll keep that in mind when I try to reroot.
Thanks for your response!1
Keep in mind that official instructions still state:
although I know many Sammy users have been able to recover from this mistake without wiping data... Seems you've put your finger on the working method for your device... Not sure if trick would work for any Samsung device however, but may be useful for others...
Take care with upgrades in future!
If goal is to reroot, you can leave configuration as-is... Only modules that become incompatible with later Android versions may cause bootloop, but normally the previous Magisk configuration files are OK... If you want to force a configuration rebuild (restore clean Magisk, no modules, superuser list, DenyList etc) after installation, just delete everything in /data/adb after rooted with a root explorer and reboot; configuration files will then be rebuilt.
PW1
I think you are confused. (I know I am.)
You said you flashed the stock ROM. Then you said you patched and flashed, which implies that the device was running after flashing the stock ROM. So you never mentioned trying to recover from the bootloop by flashing the entire stock ROM. I believe it would have worked, you just didn't do it.
The thing that needed to be fixed was the bootloop after patching and flashing. I listed the first few things that came to mind that would explain why you got a bootloop. Those are the things that you need to be careful of the next time you try to install Magisk.
If you have never had Magisk installed, you can ignore everything that refers to a previous installation of Magisk. Your bootloop was probably a matter of patching and flashing the boot from a different version of the ROM. Or maybe it was patching the boot image when you need to patch the recovery image.
When installing Magisk on a Samsung device, you should "patch" the entire AP.tar file. Magisk will patch three images within the tar file (assuming either the Recovery option is selected by default, or you specifically select it). Then you hand the patched AP.tar to Odin and everything in it gets "flashed". After you've gotten it working, if you're a glutton for punishment you can see if you can patch and flash less than the full AP.tar, but I think you still have to give a tar file to Odin.1
My take: Neither worked...
Flashing stock caused boot to Odin (download) mode with 'red errors' (because something in /data is set to accept patched vbmeta or other)... John W indicates factory reset may be needed to fix this but it ain't always so...
Next, member patched AP (presumably on another device?), then flashed (with other binaries?) which failed... This was likely because selinux/module rule directory will be wrong in modern Magisk unless patching is done on the same device (with system booted)... It probably would have worked if pre 26.0 Magisk had been used for patching however, then simply Direct install taken to update to latest Magisk, but most users won't know this.
Finally, extracting and flashing boot.img independently of AP worked as vbmeta (and/or other?) partition is presumably still patched (and needed) for (some?) Samsung devices (it's not for most other devices since major 2SI init refactoring in 25.0 however) and the previous failed patch/flash attempt (w/ Magisk patched AP) presumably achieved that...
Ie. My best guess is that 1) stock /boot couldn't work with stock /vbmeta without full /data wipe, 2) 26.0+ /boot patched on a different device couldn't work with patched/vbmeta, but the combination of stock /boot and Magisk patched /vbmeta worked as stock /boot uses correct factory set selinux rules directory...
Good luck or good management, this seems to have saved the day.
Well, member did that first, no?...
Don't think so... Said "patched the stock ROM"... I think only patching of current AP / flashing via Odin was attempted(?)
Initial bootloop (or rather, boot failure/soft brick) was clearly caused by "try(ing) to restore either boot... (without) a full Odin restore with data wipe"...
/recovery won't/can't/shouldn't be patched on that device as it launched with Android 10 so is 2SI and definitely has ramdisk in /boot (so Recovery mode option wouldn't even show)... However, maybe when patched on another device (as I presumed), if that happened to be an A-only device launched with Android 9 and Recovery mode was selected when patching, recovery.img in AP may have been patched erroneously and that would likely cause issues...
Please say which 3... I believe only 2, if not 1(?)...
Not doing this is apparently what allowed stock boot image to work on Sammy previously hosting Magisk w/o wiping /data however. (Ie. to get patched /vbmeta + stock /boot and /recovery).
... But yes, I believe patching AP on another device using pre-26.0 Magisk (or any Magisk if it could have been done on the A12 itself) and flashing all binaries via Odin would probably have worked too.
PW -
5
Known issue. A fix has been merged. You can use the Debug app, revert back to 27001 or wait until 27003 is released.
EDIT: Ninja'd
4
Yep, I told you several times that you need Recovery mode (selected) for your Ramdisk=No device; instructions for this are also clear in official Installation Instruction page too, but apparently you have not been trying to follow official instructions, so it's no real surprise you've messed up firmware too... Please take *extra* care when modding as there are simply so many variables and pitfalls!
Are you flashing patched AP (Application Processor binary) along with all the other package binaries (X4?) for your S10+ (also in Magisk Installation page, Samsung section)??
CP is Cellular Processor (Nb. Oft repeated references to CP as 'core processor' may be misleading) binary package (also referred to as Baseband Modem) so that should have fixed mismatched baseband etc... correct CSC (Consumer Software Customization; region, APN and carrier specific software packages/settings) and even BL (Bootloader) are most likely also important...
Nb. BL doesn't always update bootloader version, but if later firmware has been flashed be aware that these can also cause anti-roll back version for bootloader to be incremented (in the event that an update patches serious vulns) so you original firmware may be blocked and you may need to use later packages only...
If flashing latest complete firmware package via Odin doesn't fix your IMEI / baseband issues it may be that you've messed with partitions that contain unique device values in the past... You may need to ask in Galaxy, S10 or S10+ XDA forums for that. PW4
Known problem with 27002, the debug version doesn't have the problem with hiding, read back to see the discussion about it4
Only v27000 is Stable. (and Beta). v27001 and v27002 are Canary or Debug
Set your Update Channel to Stable and you will see (just like you can see also on GitHub) that latest Stable is v27000, there was never Stable v27001 or v27002
Generally, Stable is always Nx100
So, you cannot downgrade to Stable v27001 but Canary v27001 should be just like Stable v27000 (same codebase). That's also the general policy, whenever Nx100 Stable is released, then immediately comes Canary Nx100 +1, on the same code-base
Therefore, downgrade to Stable v27000 instead3
Since Xiaomi eu is a custom ROM, their devs made the injector, 'module' that tricks DroidGuard and injects the spoofs with no need for Magisk/root and Zygisk
And as that, you achieve Device Integrity without the Magisk.
But if you install Magisk, you have to hide Magisk and Zygisk by your own
So yes, you can use Shamiko and it should work (I used that kind of setup at the beginning of this year, for like two weeks, with no problems)
But then ask yourselves - what for do you need Magisk. If using like Viper4Android, useful LSPosed modules - then, yes
If not, better uninstall Magisk and you will only have Xiaomi.eu injector. Btw, yes, it is rather injector than a module, it's full name is XiaomiEUInject
Regarding the prints - there are now no more publicly available working prints, hence a vast majority of rooted users use the prints 'stolen' from the Xiaomi.eu injector. When Google bans them, both sides will be equally affected. And assuming that Xiaomi.eu team quickly publishes their new version of injector, (last time it was in a matter of hours) with the new prints, all those rooted users will jump again to their new prints from tha new injector (new version of PIF was published less than an hour upon the Xiaomi.eu injecto was updated)
But if Google makes a slaughter like last time (now there are about 20 times less working prints than previously) and if Xiaomi.eu team does not come up (quickly) with the new injector (and the new working prints), than better don't think what could happen.
Btw, Wallet can run about half a day on the cached previous Play Integrity pass
Hence, with the Xiaomi.eu injector or with PI Fix (with its built-in prints), PI Fork with the corresponding autopif script, etc, you are equally exposed to the Google's mercy
Therefore, if you really need Magisk, you can also keep using the PI Fix/For with the disabled Xiaomi.eu injector. It will be easier for your maintenance than to struggle with both worlds in parallel (although, that can work as well) -
1103This is the place for general support and discussion regarding "Public Releases", which includes both stable and beta releases.
All information, including troubleshoot guides and notes, are in the Announcement Thread156Hello, I haven't given much support on XDA lately. It can be resulted from
- University started and I have limited free time. In fact, I mostly develop during midnight
- I live in Taiwan, which has large time zone differences between my European/American contributors/testers, which usually forces me to stay up late at night to discuss/test stuffs.
- The new version is about to come, I don't want to spend effort on supporting old releases
New Forum!
As you might have already discovered, Magisk got its own subforum on XDA! Many thanks to all the support you gave me, and much more information/features/support is about to come!
**For developers supporting all the devices that are not using standard Android boot format, feel free to create threads in this section (actually, PLEASE do so) for your favorite devices after v7 is out. As I currently know, Asus devices require signing the boot image before flashing, and is model dependant; Sony devices seems to use ELF kernel that is unpatchable, or some has two ramdisks (inner + outer), both requires different workarounds; LG bootloader locked devices has to manually "BUMP" the boot image after flashing Magisk..... and there may be lots of other crazy boot image formats that haven't come up to my attention yet.
It is impossible for me to support all these non-standard boot images, and I hope the community can collaborate to make Magisk running across all the devices. Overall, community collaboration is what XDA about
The Pixel Phone
Some of you might already know this news, that the next Pixel Phone right around the corner seems like it does not have ramdisk in boot image, which pretty much wrecked Magisk in all ways. However, it pretty much doomed root itself too. Kernel modifications is inevitable IMO, so I'll try to migrate my scripts to C programs that could possibly be included into the kernel itself. Note that I'm not familiar with linux kernel, I'm not even sure if my idea and concept is correct or not. But once the device is available, I think developers will find a way to bypass all the difficulties, and I'll do my best to learn things
Current Progress
In the past month, I've spent quite some time learning SELinux, so that I can avoid using SuperSU's sepolicy patches. Thanks to the helps and tips from @phhusson and @Chainfire, I finally have a much clearer understanding of how SELinux works. The Magisk core parts (the scripts, boot image patches, new features, more supports) are actually done some time ago. What is causing all the delays is the Magisk Manager.
To be completely honest, although I can code in Java without much issues, Magisk Manager is actually my first Android application, I had to reach out for assistance, and fortunately awesome developers like @DVDandroid and @digitalhigh contributed a lot, which makes the current Manager awesome.
After the repo system and module management is mostly done, I was about to do some adjustments and release, but what we really done is decided to add another feature: auto-unroot with per-app settings. I decided to wait for it to be finished, and then do my adjustments. Due to reasons that'll be mentioned later, this feature will likely not be available for the next release (should come in future updates)
Safety Net Disaster
Those who are using Magisk for Safety Net bypass purposes must have known that Google recently updated the detection method of my Systemless Xposed. I still have no idea what Safety Net is detecting, so currently I cannot fix it on my side (also because I'm busy working on the next update). However, suhide developed by @Chainfire is able to hide Xposed and worked fine.
However, only my Systemless Xposed v86.2, which is based on SuperSU's su.d, is supported using that method. v86.2 and v86.5 (latest, Magisk based) have nearly identical binaries, and the only difference is the path where the binaries are stored.
I'm still not sure what's the real issue for it not being supported, I just hope it is not done intentionally.
Conclusion
Due to the fact that my Safety Net bypass is not 100% perfect now, I do not want to spend any more time waiting for auto-unroot to be polished. What I'm doing now is finishing up all the things I'd like to change in Magisk Manager (it has been a while since I last contributed to Manager, my fellow developers are doing all the heavy job), which might take a little more time, after that, packed with tons of information to be announced in Magisk Section, I'll release the long awaited update.
Hope this lengthy post gives you the idea of the whole situation, and again thanks for all your support!!121Ah, some Chainfire bashing, I hope it is not too late for me to exercise additional villainy.
First, let me make clear I have nothing against @topjohnwu, nor against Magisk. Magisk is an interesting project and it certainly displays @topjohnwu ingenuity and persistence. I don't doubt we will see more interesting things from his hands.
-------------------------
What has happened here is not all that dark and complicated, from either end. I returned from holidays, and someone pointed me at Magisk. My first thought: interesting!
Among other things, the thread lists some issues with SuperSU, which in combination with the phrase The developer also requests users to not bug Chainfire with compatibility requests for SuperSU with Magisk from the portal article, raised my left eyebrow by nigh half an inch. The popular systemless xposed mod is apparently now based on it, and apparently it now no longer works with SuperSU, and apparently I'm not supposed to fix that, nor any of the other found issues. I found that a bit weird. So yes, I have told @topjohnwu that I was a bit surprised he was posting about issues with SuperSU without notifying me about them (I can't fix or help fix issues I'm not aware of, after all).
He's also spreading a modified version of the SuperSU package, which is not all that uncommon, nor necessarily a problem. I have not looked into what he modified, I only ran a few quick tests on one of my devices, and found some commonly used commands run as root to be broken. I have informed him of this as well.
It appears the tool of choice for Magisk is phh's Superuser, because of some of the mentioned issues with SuperSU. That's fine by itself, but fixing issues in that superuser by incorporating SuperSU's binaries into it is a somewhat questionable practise. After all, SuperSU is a commercial closed-source package that helps pay for my dinner, and superuser is a direct competitor. I have informed him that I was surprised he did this without asking for permission. I have expressed similar surprise on him spreading a modified version of LiveBoot (which helps pay for a snack now and then).
@topjohnwu has also stated that Magisk's scripts are largely influenced by mine (I have not checked). Scripts based on mine are used all over the place on XDA, some people have crafted amazing things based on them, I have never made an issue of this (otherwise I would have just made them binaries). But yes, I have also stated to him that I don't think it's very nice to base something on one program, and then using that to (almost exclusively) push something directly competing with that program.
tl;dr Towards @topjohnwu, I have:
- expressed surprise he has issues getting Magisk to work with SuperSU, and has chosen not to inform me about those
- expressed surprise he is using SuperSU binaries in a competing superuser without permission
- expressed surprise he is posting a modified LiveBoot without permission
- informed him of issues with the modified SuperSU he has posted
- let him know I thought it wasn't very nice to be applying my scripts to benefit seemingly exclusively that same competing superuser
To be crystal clear:
- I have not asked for an apology
- I have not asked for Magisk to be abandoned, neither the root hiding nor systemless module parts, and certainly not systemless xposed
- I have not made an issue of any of this anywhere, until this post
- I have not even specifically asked for anything to be taken down (though obviously in my opinion the other superuser package mixed with SuperSU's binaries, as well as the LiveBoot package, should go)
- I have not reported this thread to XDA moderators for copyright violations or otherwise
While my conversation with @topjohnwu may not win any awards for being friendly (though it may win some for brevity), I think all things considered my response has been rather mild. To be perfectly honest, until the apology post, I thought this was over with already. I think the apology post was triggered because I haven't replied to his last PM for a while - I was in the zone, it happens.
To emphasize again, I have nothing against @topjohnwu, Magisk, or systemless xposed, and it is certainly not my goal to see any of them go. If it can be made to work together with SuperSU, great.
I get it though: you think of something, you want to see if you can make it work, you finally get it to work, you publish it, it takes off - enthusiasm gets the better of you. Maybe in the rush some mistakes are made. That doesn't mean you have to just drop it and run. None of my stuff would make it past 0.1 if I stopped at the first big mistake
Aside from said being in the zone coding, I usually regret actually responding to these sort of things the day after, which has made me hesitant to reply. Surprise me.76Thread temporarily closed so everyone sees this.
The flood of "SafetyNet isn't working for me either!" posts are not helpful, at all. Please refrain from posting further, it will be looked into. Please do not forget that not passing SafetyNet is 100% NORMAL AND INTENDED when you have an unlocked booloader or running custom firmware. These are workarounds and they will be worked around in turn.
The Flash
Forum Moderator
EDIT: Thread is reopened... I will be cleaning any SafetyNet posts for a while to keep the thread clean for real issues.75Hello everyone!
I am aware that Google has updated Safety Net that makes Magisk itself a no go for Android Pay. In fact, I witnessed the change live while I am developing the new magiskhide, which should hide all Magisk modules and Magisk installed root.
Google is serious about Safety Net now, clearly hunting down all possibility to run Xposed with Safety Net passed. I spend quite some time examining the new security measures last midnight, and fortunately it seems that it is possible to run Magisk and root along with Safety Net if no Xposed is running. I'm glad I removed the old root toggle at the right time lol, that is no longer feasible with the latest detection.
So stay tuned for the next update, it will come with bug fixes, along with the new magiskhide to bypass that Safety Net.
Google, how will a few systemless mods do any harm
