Lord Sithek
Senior Member
Ok then, successfull update on 3 out of 4 my devices
Unable to get root on Huawei Watch 2 (custom rom and boot image). Nor through TWRP, nor by patching boot.img. The device is booting, but unrooted
Magisk General Support / Discussion
- Thread starter topjohnwu
- Start date
Unable to get root on Huawei Watch 2 (custom rom and boot image). Nor through TWRP, nor by patching boot.img. The device is booting, but unrootedFYI
If you extract your update, remove the -w from the end of the flash-all.bat, it won't wipe your phone.
Then just run flash-all.bat with phone in fastboot.
@Newtype14
Would you mind telling me a couple of things:
have you flashed TWRP after complete magisk set-up ?
how did you do the Nandroid backup before rooting? have you used an app?
Thanks
I flashed TWRP before doing anything with Magisk, then booted into Recovery mode and in TWRP, I created a backup by selecting: "Boot", "System", "Cache", "Baseband" and "EFS".
For additional information: I did wipe my phone three weeks ago and used that backup to restore and it worked fine.
daniel_loft
Senior Member
Because every now and then another app needs Magisk hide (latest I noticed was Revolut) I was thinking about this little suggestion:
- When activating Magisk hide, why not set it to hidden to all apps? Or, if possible hidden to all exempt those that were specifically given root access.
or, if the above is not implementable...
- Could it be possible to have a way to export the list of selected apps from MagiskHide?
I happen to have installed Magisk relatively often lately and it's always annoying to repopulate the list in MagiskHide.
Thanks!
- When activating Magisk hide, why not set it to hidden to all apps? Or, if possible hidden to all exempt those that were specifically given root access.
or, if the above is not implementable...
- Could it be possible to have a way to export the list of selected apps from MagiskHide?
I happen to have installed Magisk relatively often lately and it's always annoying to repopulate the list in MagiskHide.
Thanks!
curiousrom
Recognized Contributor
Galaxy S7 TWRP Backup Restore Fail
Many users including me reported fail to boot if you select install the TWRP app when asked in TWRP. That app is fluff, wants to start at boot, run in the background, collect data & is not necessary anyway because the TWRP updates are not frequent & it's easy enough to update manually.
If you did that, go to TWRP > Settings > and disable: Prompt to install TWRP app if not installed.
Is that stock Samsung OS? TWRP version?
You only need to restore System, Boot (which is the kernel in fact & this gets modified by Magisk on your device) & Data. You did not backup the Data partition?
There is no need to backup or restore Cache as it is recreated by the system if needed.
The EFS partition can be restored if you have problems with unknown IMEI or no access to the network after checking the APN settings. No need to fix what is not broken. Don't restore Baseband. Are you sure that it's not labeled Modem?
***
Many users including me reported fail to boot if you select install the TWRP app when asked in TWRP. That app is fluff, wants to start at boot, run in the background, collect data & is not necessary anyway because the TWRP updates are not frequent & it's easy enough to update manually.
If you did that, go to TWRP > Settings > and disable: Prompt to install TWRP app if not installed.
Is that stock Samsung OS? TWRP version?
You only need to restore System, Boot (which is the kernel in fact & this gets modified by Magisk on your device) & Data. You did not backup the Data partition?
There is no need to backup or restore Cache as it is recreated by the system if needed.
The EFS partition can be restored if you have problems with unknown IMEI or no access to the network after checking the APN settings. No need to fix what is not broken. Don't restore Baseband. Are you sure that it's not labeled Modem?
***
Last edited:
Well, you just need to understand that being systemless, actual Magisk is flashed to boot image (assuming ramdisk [in boot image] = yes), so this is what got corrupted by bad flash.
Flashing patched boot image thru fastboot from PC is now the preferred method to flash Magisk, but, if you have TWRP you can generally flash boot partition from this (without PC) also.
The reverse is also true: to remove Magisk root (or corrupted Installation), simply flash back UNPATCHED boot image (download and extract from your current ROM package).
The details are all laid out for you in John's official Installation Instruction on the Magisk main page. Just click the GitHub (cat) symbol on Magisk app main page (or click here: https://github.com/topjohnwu/Magisk ), then Installation Instruction. Please read everything (especially Patching Images). Nb. some of the special instructions for Samsung may be relevant, but largely won't apply as your device did no launch w/ Android 9 or later (ie not SAR device).
Hope this helps. PW
Last edited:
NOW I'M STUCK IN DOWNLOAD MODE!!!
UPDATE: Being on DrKetan ROM, I flashed the BL + CP package in Odin, which allowed me to reboot into TWRP. I still couldn't reboot the system, so I dirty-flashed my current ROM, and it allowed me to start my phone without losing anything. I still want to know what the "like magic" part is about flashing the apk in TRWP, though. /UPDATE
So... the changelog for Magisk v22 said that you can flash the apk as a zip "like magic" so I changed the .apk to .zip and tried to flash it on my Note 9 (Exynos). The process failed in TWRP with ERROR 1 (IIRC), so I tapped Reboot System. The phone rebooted to download mode, and seems to be STUCK THERE. If I hold vol down + power the screen turns off for a second, and goes back to download mode.
I tried flashing my version of TWRP back in Odin with auto reboot turned on, and it succeeds, but still goes back to download mode. Do I really have to flash the stock ROM back to my phone because of this?
Someone please help. I have a business trip tomorrow and need my phone... I guess I shouldn't have tried this. Thanks in advance!
UPDATE: Being on DrKetan ROM, I flashed the BL + CP package in Odin, which allowed me to reboot into TWRP. I still couldn't reboot the system, so I dirty-flashed my current ROM, and it allowed me to start my phone without losing anything. I still want to know what the "like magic" part is about flashing the apk in TRWP, though. /UPDATE
So... the changelog for Magisk v22 said that you can flash the apk as a zip "like magic" so I changed the .apk to .zip and tried to flash it on my Note 9 (Exynos). The process failed in TWRP with ERROR 1 (IIRC), so I tapped Reboot System. The phone rebooted to download mode, and seems to be STUCK THERE. If I hold vol down + power the screen turns off for a second, and goes back to download mode.
I tried flashing my version of TWRP back in Odin with auto reboot turned on, and it succeeds, but still goes back to download mode. Do I really have to flash the stock ROM back to my phone because of this?
Someone please help. I have a business trip tomorrow and need my phone... I guess I shouldn't have tried this. Thanks in advance!
Last edited:
Serious issues with v22 update - MagiskManager shows the new Manager ver as being v. 22 I didn't see any changelogs, so I selected Updatefor Manager app (not Magisk) from MagiskManager - so v22 became the Manager version and Manager showed no Magisk or root, and all crapped out. Using old Xperia Z3 but running Android 10 - CarbonRom (Lineage variant, very nice btw)
Solution: First I downloaded older version of Magisk 21.4, latest Magisk uninstaller, and Manager 8.0.7 Second, unininstalled MagiskManager v22 app. Third reboot to TWRP and uninstalled Magisk with latest Magisk uninstaller. No reboot, directly installed Magisk v 21.4 from TWRP, booted to system, and installed apk for Manager v 8.0.7 and all runs fine - have root.
New development - Manager keeps "Checking for updates . . ." and not showing version installed or available. Guess the Magisk Team is on it. Now shows Manager is up to date.
Galaxy s9 is confused.
Solution: First I downloaded older version of Magisk 21.4, latest Magisk uninstaller, and Manager 8.0.7 Second, unininstalled MagiskManager v22 app. Third reboot to TWRP and uninstalled Magisk with latest Magisk uninstaller. No reboot, directly installed Magisk v 21.4 from TWRP, booted to system, and installed apk for Manager v 8.0.7 and all runs fine - have root.
New development - Manager keeps "Checking for updates . . ." and not showing version installed or available. Guess the Magisk Team is on it. Now shows Manager is up to date.
Galaxy s9 is confused.
Last edited:
Pandemic
Senior Member
Updated from 21.4 to 22.0 and no issues at all on my Xperia 1 with Android 11, updated the magisk manager 1st then updated to magisk 22.0 with the manager with direct install.. So dunno what is wrong with the other people that have issues.
I thought that when I was restoring with my backup, it was also restoring the boot to its pre-Magisk state, since I selected "boot" in TWRP when I created my backup. Am I wrong?
What's the proper way of getting this boot.img? I did some research and everywhere it says that to get the boot.img, you have to download the latest firmware for your phone model/carrier and extract it from those files.
Thanks for sharing your fix / workaround. I'm on an old Xiaomi Mi Mix, Android 9.
Had the same symptoms when I updated to the newest Manager. Also, Magisk / Magisk Manager started crashing. Downgraded to 21.4 and 8.0.7 and everything is fine again. The update to 22.0 is now greyed out in the manager, so I guess I'll wait till a more stable version comes out before trying this one. The Manager is still showing an update for itself (22.0) but that can't be right. I think the repo URLs might have gotten mixed up or something.
You 're right . But Magisk was included in my Custom Pie ROM I've used for 2 years. Until r22 I didn't know that a file magisk.apk was into my system/app folder. Until r21.4 , all the updates didn't detect it. Now everything is back to the normal and it is running fine. Finally not a big issue. Thanks for your help.
That is exactly as it should be. From v22.0 Magisk and the app are now merged into one:
https://topjohnwu.github.io/Magisk/releases/22000.html
Same exact problem on my Redmi Note 8T/willow (MIUI 12.0.2 QCXEUXM, Android 10) with Orangefox 11.0_1. I have to reflash the rom to boot to system again.
HemanthJabalpuri
Recognized Contributor
Someone confirm that issue tracker of Magisk is there or not.
I cannot able to see it in repo.
I cannot able to see it in repo.
John got fed up with the spamming of low quality issue reports (and issue tickets that wasn't actually issues):
curiousrom
Recognized Contributor
You are The Messiah good sir! Thank you, thank you so much. For almost everyone stuck with acquiring the boot.img file, if you are using any custom ROM, check its ZIP, it will have a boot.img file within it without fail. Simply flash it using
fastboot flash boot boot.img and you're good to go.Hi All . . . I posted this in another thread, but it seems that it should have been posted here
If any can please Help . . .
"Quote"
Hi All . . .
I am running a Amlogic X96Air Box with Slimrom-Android 9
Can someone plz guide me on installing Magisk for Safety Net Pass on Uncertified Google Play Store "Uncertified Device"
Firstly i installed the App Manager to access if "ramdisk" is available . . it says "No"
I then uninstalled it . . then tried to go the route to flash the zip (v22) thru TWRP . . after reboot nothing showed up in all apps (no Magisk) . . not sure if I'm doing it correctly !!! . . . However, I then reset the box and also reinstalled the rom to have a clean installation.
Any guidance on installing Magisk for Safety Net Pass on Play Store to have a certified device would be greatly appreciated, if this is at all possible
Thanks
If any can please Help . . .
"Quote"
Hi All . . .
I am running a Amlogic X96Air Box with Slimrom-Android 9
Can someone plz guide me on installing Magisk for Safety Net Pass on Uncertified Google Play Store "Uncertified Device"
Firstly i installed the App Manager to access if "ramdisk" is available . . it says "No"
I then uninstalled it . . then tried to go the route to flash the zip (v22) thru TWRP . . after reboot nothing showed up in all apps (no Magisk) . . not sure if I'm doing it correctly !!! . . . However, I then reset the box and also reinstalled the rom to have a clean installation.
Any guidance on installing Magisk for Safety Net Pass on Play Store to have a certified device would be greatly appreciated, if this is at all possible
Thanks
Similar threads
Top Liked Posts
-
1
Mmm. Not sure that will help either... You can open a GitHub issue if you're prepared to install Debug Magisk build and supply logs; Devs might help further.
PW -
5
Known issue. A fix has been merged. You can use the Debug app, revert back to 27001 or wait until 27003 is released.
EDIT: Ninja'd4
Only v27000 is Stable. (and Beta). v27001 and v27002 are Canary or Debug
Set your Update Channel to Stable and you will see (just like you can see also on GitHub) that latest Stable is v27000, there was never Stable v27001 or v27002
Generally, Stable is always Nx100
So, you cannot downgrade to Stable v27001 but Canary v27001 should be just like Stable v27000 (same codebase). That's also the general policy, whenever Nx100 Stable is released, then immediately comes Canary Nx100 +1, on the same code-base
Therefore, downgrade to Stable v27000 instead4
Known problem with 27002, the debug version doesn't have the problem with hiding, read back to see the discussion about it4
Not pushed yet according to my magisk app.
Luckily i don't hide or need to hide; this is a sad bug and i hope, for others' sake, it's pushed as soon as the developers can. But that's also why it's canary and not beta or release, it's why (or should be why) we use canary, to squash bugs before the rest experience them.4
Not pushed yet... Looks like recent Android Gradle plugin upgrade just didn't build properly... Guess a new build may come once Upgrade AGP is reverted but may not happen till AGP upgrade is redone.
PW -
1103This is the place for general support and discussion regarding "Public Releases", which includes both stable and beta releases.
All information, including troubleshoot guides and notes, are in the Announcement Thread156Hello, I haven't given much support on XDA lately. It can be resulted from
- University started and I have limited free time. In fact, I mostly develop during midnight
- I live in Taiwan, which has large time zone differences between my European/American contributors/testers, which usually forces me to stay up late at night to discuss/test stuffs.
- The new version is about to come, I don't want to spend effort on supporting old releases
New Forum!
As you might have already discovered, Magisk got its own subforum on XDA! Many thanks to all the support you gave me, and much more information/features/support is about to come!
**For developers supporting all the devices that are not using standard Android boot format, feel free to create threads in this section (actually, PLEASE do so) for your favorite devices after v7 is out. As I currently know, Asus devices require signing the boot image before flashing, and is model dependant; Sony devices seems to use ELF kernel that is unpatchable, or some has two ramdisks (inner + outer), both requires different workarounds; LG bootloader locked devices has to manually "BUMP" the boot image after flashing Magisk..... and there may be lots of other crazy boot image formats that haven't come up to my attention yet.
It is impossible for me to support all these non-standard boot images, and I hope the community can collaborate to make Magisk running across all the devices. Overall, community collaboration is what XDA about
The Pixel Phone
Some of you might already know this news, that the next Pixel Phone right around the corner seems like it does not have ramdisk in boot image, which pretty much wrecked Magisk in all ways. However, it pretty much doomed root itself too. Kernel modifications is inevitable IMO, so I'll try to migrate my scripts to C programs that could possibly be included into the kernel itself. Note that I'm not familiar with linux kernel, I'm not even sure if my idea and concept is correct or not. But once the device is available, I think developers will find a way to bypass all the difficulties, and I'll do my best to learn things
Current Progress
In the past month, I've spent quite some time learning SELinux, so that I can avoid using SuperSU's sepolicy patches. Thanks to the helps and tips from @phhusson and @Chainfire, I finally have a much clearer understanding of how SELinux works. The Magisk core parts (the scripts, boot image patches, new features, more supports) are actually done some time ago. What is causing all the delays is the Magisk Manager.
To be completely honest, although I can code in Java without much issues, Magisk Manager is actually my first Android application, I had to reach out for assistance, and fortunately awesome developers like @DVDandroid and @digitalhigh contributed a lot, which makes the current Manager awesome.
After the repo system and module management is mostly done, I was about to do some adjustments and release, but what we really done is decided to add another feature: auto-unroot with per-app settings. I decided to wait for it to be finished, and then do my adjustments. Due to reasons that'll be mentioned later, this feature will likely not be available for the next release (should come in future updates)
Safety Net Disaster
Those who are using Magisk for Safety Net bypass purposes must have known that Google recently updated the detection method of my Systemless Xposed. I still have no idea what Safety Net is detecting, so currently I cannot fix it on my side (also because I'm busy working on the next update). However, suhide developed by @Chainfire is able to hide Xposed and worked fine.
However, only my Systemless Xposed v86.2, which is based on SuperSU's su.d, is supported using that method. v86.2 and v86.5 (latest, Magisk based) have nearly identical binaries, and the only difference is the path where the binaries are stored.
I'm still not sure what's the real issue for it not being supported, I just hope it is not done intentionally.
Conclusion
Due to the fact that my Safety Net bypass is not 100% perfect now, I do not want to spend any more time waiting for auto-unroot to be polished. What I'm doing now is finishing up all the things I'd like to change in Magisk Manager (it has been a while since I last contributed to Manager, my fellow developers are doing all the heavy job), which might take a little more time, after that, packed with tons of information to be announced in Magisk Section, I'll release the long awaited update.
Hope this lengthy post gives you the idea of the whole situation, and again thanks for all your support!!121Ah, some Chainfire bashing, I hope it is not too late for me to exercise additional villainy.
First, let me make clear I have nothing against @topjohnwu, nor against Magisk. Magisk is an interesting project and it certainly displays @topjohnwu ingenuity and persistence. I don't doubt we will see more interesting things from his hands.
-------------------------
What has happened here is not all that dark and complicated, from either end. I returned from holidays, and someone pointed me at Magisk. My first thought: interesting!
Among other things, the thread lists some issues with SuperSU, which in combination with the phrase The developer also requests users to not bug Chainfire with compatibility requests for SuperSU with Magisk from the portal article, raised my left eyebrow by nigh half an inch. The popular systemless xposed mod is apparently now based on it, and apparently it now no longer works with SuperSU, and apparently I'm not supposed to fix that, nor any of the other found issues. I found that a bit weird. So yes, I have told @topjohnwu that I was a bit surprised he was posting about issues with SuperSU without notifying me about them (I can't fix or help fix issues I'm not aware of, after all).
He's also spreading a modified version of the SuperSU package, which is not all that uncommon, nor necessarily a problem. I have not looked into what he modified, I only ran a few quick tests on one of my devices, and found some commonly used commands run as root to be broken. I have informed him of this as well.
It appears the tool of choice for Magisk is phh's Superuser, because of some of the mentioned issues with SuperSU. That's fine by itself, but fixing issues in that superuser by incorporating SuperSU's binaries into it is a somewhat questionable practise. After all, SuperSU is a commercial closed-source package that helps pay for my dinner, and superuser is a direct competitor. I have informed him that I was surprised he did this without asking for permission. I have expressed similar surprise on him spreading a modified version of LiveBoot (which helps pay for a snack now and then).
@topjohnwu has also stated that Magisk's scripts are largely influenced by mine (I have not checked). Scripts based on mine are used all over the place on XDA, some people have crafted amazing things based on them, I have never made an issue of this (otherwise I would have just made them binaries). But yes, I have also stated to him that I don't think it's very nice to base something on one program, and then using that to (almost exclusively) push something directly competing with that program.
tl;dr Towards @topjohnwu, I have:
- expressed surprise he has issues getting Magisk to work with SuperSU, and has chosen not to inform me about those
- expressed surprise he is using SuperSU binaries in a competing superuser without permission
- expressed surprise he is posting a modified LiveBoot without permission
- informed him of issues with the modified SuperSU he has posted
- let him know I thought it wasn't very nice to be applying my scripts to benefit seemingly exclusively that same competing superuser
To be crystal clear:
- I have not asked for an apology
- I have not asked for Magisk to be abandoned, neither the root hiding nor systemless module parts, and certainly not systemless xposed
- I have not made an issue of any of this anywhere, until this post
- I have not even specifically asked for anything to be taken down (though obviously in my opinion the other superuser package mixed with SuperSU's binaries, as well as the LiveBoot package, should go)
- I have not reported this thread to XDA moderators for copyright violations or otherwise
While my conversation with @topjohnwu may not win any awards for being friendly (though it may win some for brevity), I think all things considered my response has been rather mild. To be perfectly honest, until the apology post, I thought this was over with already. I think the apology post was triggered because I haven't replied to his last PM for a while - I was in the zone, it happens.
To emphasize again, I have nothing against @topjohnwu, Magisk, or systemless xposed, and it is certainly not my goal to see any of them go. If it can be made to work together with SuperSU, great.
I get it though: you think of something, you want to see if you can make it work, you finally get it to work, you publish it, it takes off - enthusiasm gets the better of you. Maybe in the rush some mistakes are made. That doesn't mean you have to just drop it and run. None of my stuff would make it past 0.1 if I stopped at the first big mistake
Aside from said being in the zone coding, I usually regret actually responding to these sort of things the day after, which has made me hesitant to reply. Surprise me.76Thread temporarily closed so everyone sees this.
The flood of "SafetyNet isn't working for me either!" posts are not helpful, at all. Please refrain from posting further, it will be looked into. Please do not forget that not passing SafetyNet is 100% NORMAL AND INTENDED when you have an unlocked booloader or running custom firmware. These are workarounds and they will be worked around in turn.
The Flash
Forum Moderator
EDIT: Thread is reopened... I will be cleaning any SafetyNet posts for a while to keep the thread clean for real issues.75Hello everyone!
I am aware that Google has updated Safety Net that makes Magisk itself a no go for Android Pay. In fact, I witnessed the change live while I am developing the new magiskhide, which should hide all Magisk modules and Magisk installed root.
Google is serious about Safety Net now, clearly hunting down all possibility to run Xposed with Safety Net passed. I spend quite some time examining the new security measures last midnight, and fortunately it seems that it is possible to run Magisk and root along with Safety Net if no Xposed is running. I'm glad I removed the old root toggle at the right time lol, that is no longer feasible with the latest detection.
So stay tuned for the next update, it will come with bug fixes, along with the new magiskhide to bypass that Safety Net.
Google, how will a few systemless mods do any harm
PW
