Magisk General Support / Discussion

[dan60]

------update: just managed to get phone detected in fastboot mode.

Congrats! This is the way we find solutions . Best luck for you

 

[pndwal]

@zgfg, @pndwal: It may not be the bootloader that supports initrd. Some manufacturers might go to the trouble of deleting the kernel's ability to use an initrd.

As for the confusion about the meaning of "Ramdisk: No", someone could open an issue requesting that that entire block of information be more clearly labeled "State of system before Magisk tried to patch anything". Maybe also add an indication of where Magisk is installed. But please remember to use the proper template.

My understanding of this is that initrd and initramfs achieve much the same thing, but initramfs at an even earlier early stage, and also takes precedence over initrd.
https://www.linux.com/training-tutorials/kernel-newbie-corner-initrd-and-initramfs-whats/

Both require bootloader support, and even if support is missing from kernel / boot image, this can be restored thru custom modification, eg Magisk actually adds such basic initramfs support where missing.

The very real problem is custom modders generally cannot add such support to bootloader where missing; that's the whole reason for Magisk in Recovery on such devices.

The confusion comes because by design (for good reason) the ramdisk flag (in Magisk app) shows the FACTORY state of support for ramdisk in boot image, and will show 'no' (despite the presence of ramdisk in recovery, and) even after ramdisk is manually added to boot image, and in fact is working on some devices:

Some Type III devices’ bootloader will still accept and provide initramfs that was manually added to the boot image to the kernel (e.g. some Xiaomi phones), but many device don’t (e.g. Samsung S10, Note 10). It solely depends on how the OEM implements its bootloader.

It is literally impossible for Magisk to know whether a device bootloader accepts ramdisk, so the assumption is to always inform the user to use recovery mode

https://github.com/topjohnwu/Magisk/issues/3239

I like your 'issue' suggestions, but I won't be doing this as John is already annoyed with 'bug' reports that are not really bugs, he already addressed the confusion problem in the issue cited above in October, explaining why ramdisk says 'no' even if added, and it seems any changes to this will be a very low priority for him.

Clearly, that clarification from John explains the reason ramdisk = yes ONLY for FACTORY ramdisk (and we just need to understand that); ie, even with ramdisk manually added and ramdisk = yes to indicate this, it will still likely be unusable, whereas ramdisk in recovery will work.

As I said earlier, there is now actually ramdisk in boot image; Magisk adds it! ... But this on its own DOES NOT mean it's usable... so Magisk simply reports if FACTORY ramdisk is present as this is the only one sure to work. (Factory ramdisk indicates compatible bootloader. Manually added ramdisk indicates nothing!) PW

 

[ineedroot69]

So i was avail to install magisk 22.0 and im rooted but sadly my dm-verity is now triggered and i learn my lesson read the changelog

 

[Didgeridoohan]

Does magisk --remove-modules disable the boot scripts in post-fs and service.d? These are a possible source of a bootloop also.

I can't quite remember currently, but I do believe that the adb command does not touch scripts in post-fs-data.d or service.d (I also currently can't remember if Safe Mode does, have to do some reading/testing later). Modules shouldn't be putting stuff there though, since that breaks encapsulation. Unfortunately a lot of modules do...

IMHBCO, since Magisk is such a powerful tool it is up to the module developers to make sure that it is possible for the user to recover if there are any issues. As an example, my MagiskHide Props Config module can be disabled or have it's settings reset by placing a specific file in the root of the device's internal storage. That way you can always recovery, even if the device can't boot with Magisk installed. Details (if anyone's interested):
https://github.com/Magisk-Modules-R...README.md#device-issues-because-of-the-module

I have booted to safe mode using the long press on the reboot from within the ROM, but I have never used or heard of a button combination. It seems like a VERY logical option, but what is the combination? And I do understand it will be different on each phone.

Usually it is something along the lines of holding the power button until the OEM splash screen shows and then switching to holding volume down instead until your device boots into Safe Mode.

 

[pndwal]

i've used this before but now that we have a OnePlus5 we have tried to use it. It seems to work with, for example, Titanium Backup alright. However i can't get "root" access for the ES-FileExplorer application. It goes through the motions and says that "root" access has been granted. Then, a couple of seconds later, it reports that it does not have root access.

i installed Magisk by downloading and using the file manager to find it and to "install" it. No problems reported.

Have a great day and stay safe!

Well, it says "Sorry, test failed. This feature cannot run on your phone", and I agree this seems to be due to inability to see su now, although the same failure used to occur when installed on adopted storage or other external memory.

Seems the problem is:

Some apps may have troubles detecting root when using Magisk. Usually this means the app in question is looking for root in a specific location and needs to be updated to work with MagiskSU or otherwise can’t detect MagiskSU. Contact the developer.

https://www.didgeridoohan.com/magisk/MagiskRootIssues

You could try 'symlinking the su binary to the location where the app is looking' as suggested, or, using another File Manager from store (grant root access and enable r/w) COPY /sbin/su to /system/xbin.

You may need to make a module to do this systemlessly if mounting system rw isn't possible, or to take future OTA updates, but still may fail to pass SafetyNet any longer.

For these reasons (due to lack of current support), and because of serious security implications revealed w/ ES Explorer - mentioned by @curiousrom - , I've also moved to other less obtrusive Root Explorers...

I like Total Commander and Root Explorer. Here's a few more:
https://www.androidauthority.com/file-manager-explorer-apps-android-279800/ PW

 

[ineedroot69]

.

I have question?? When installing magisk and your dm-verity is already trigger I need to uncheck "preserve avb 2.0/dm verity" is that correct??

 

[DiamondJohn]

I can't quite remember currently, but I do believe that the adb command does not touch scripts in post-fs-data.d or service.d (I also currently can't remember if Safe Mode does, have to do some reading/testing later). Modules shouldn't be putting stuff there though, since that breaks encapsulation. Unfortunately a lot of modules do...

the vanced I am running uses a boot script, in post fs data. Its been a while since I checked, but I have a vague memory that each module can contain a script specific to itself. I need to go back and read and re-learn if a module have either or both a post-fs-data and service.d.

IMHBCO, since Magisk is such a powerful tool it is up to the module developers to make sure that it is possible for the user to recover if there are any issues. As an example, my MagiskHide Props Config module can be disabled or have it's settings reset by placing a specific file in the root of the device's internal storage. That way you can always recovery, even if the device can't boot with Magisk installed. Details (if anyone's interested):
https://github.com/Magisk-Modules-R...README.md#device-issues-because-of-the-module

Although a good idea, with some of the cool featiures, its hard to resist trying a module that does not. There is one for my phone that I really wish to use (it has a few features found in Xposed Gravitybox!), and hence my interest in recovering if it triggers a boot-loop. I think I will suggest something along these lines to the dev on the thread. But, I think it will be quicker for me to make my own "boot three times and then uninstall" script. I already have a template that i previously used on another module.

Usually it is something along the lines of holding the power button until the OEM splash screen shows and then switching to holding volume down instead until your device boots into Safe Mode.

I have only gone into safe mode on purpose once, to see what its about. And after all the config I lost, i have only accidentally done so since. But I have never accidentally done so using button combinations, and I have gone through all sorts of button combinations (accidentally). I just rebooted my current device, but backed out as i didn't want to loose my current config. I guess if I do get in a boot-loop, it will be worth a possible look. Maybe a question on my device specific thread/forum.

EDIT: someone just posted on that thread, how it caused their device to stall on boot...

 

[Shady88]

Hi, have a question.
Since my phone probably wouldn't flash new magisk from recovery (i tried yesterday for lineageos 17.1 rom, from official twrp and lineageos' twrp they suggest), when i have the boot file extracted from the rom, i need to patch it from the rom i intend to use it with, or any rom would do, it won't make a difference?

 

[Wolfcity]

I wanted to test Magisk 22 on my old Moto G 2014 running Aosp Extended (Android 7.1.2), unhid Magisk 20.4 and went to direct install. That didn´t work, nothing happened when pressing the button.
As I had no boot.img availabe at the moment I changed the ending of the apk to zip, booted into TWRP and tried to flash it.
I got an error message (sorry, I don´t remember the text) and now the device won´t boot anymore and the TWRP recovery seems to be gone too.
I only get to the Fastboot Flash Mode screen to select between

-Normal Powerup (goes back to Fastboot screen)
-Recovery (goes back to Fastboot screen)
-Factory
-Barcodes
-BP Tools
Underneath is the error message

Invalid boot image header
Fastboot Reason: Fall-through fron mot-charger boot mode
USB conncted

Usb is conncted as I tried to flash or boot into TWRP by fastboot, results in the following error:

C:\Mini ADB and Fastboot>fastboot flash recovery twrp-3.4.0-0-titan.img

(bootloader) has-slot:recovery: not found

(bootloader) is-logical:recovery: not found

Sending 'recovery' (8192 KB)                       OKAY [  0.290s]

Writing 'recovery'                                 OKAY [  0.400s]

Finished. Total time: 0.743s

I´m a bit rusty regarding those errors so any help is appreciated .
As this is my testing device every way would be ok for me, restoring a backup or anything else but as long as I can´t boot or flash into TWRP it seems I´m stuck at the moment.

Edit: Extrcted a boot.img from the AEX firmware I´m running and tried to boot into it, error message:

C:\Mini ADB and Fastboot>fastboot flash boot boot.img

(bootloader) has-slot:boot: not found

(bootloader) is-logical:boot: not found

Sending 'boot' (8592 KB)                           OKAY [  0.310s]

Writing 'boot'                                     OKAY [  0.418s]

Finished. Total time: 0.801s

and see attached screenshot.

 

[pndwal]

Has anyone had the issue where install magisk to inactive slot after OTA no longer shows?

@topjohnwu

It's disabled on newer builds of Magisk, because of issues (I don't have the details, unfortunately).

Some details -

Bootlooping Pixels due to Google changes:
https://github.com/topjohnwu/Magisk/blob/master/docs/ota.md PW

 

[Wolfcity]

I wanted to test Magisk 22 on my old Moto G 2014 running Aosp Extended (Android 7.1.2), unhid Magisk 20.4 and went to direct install. That didn´t work, nothing happened when pressing the button.

........snip

EDIT:
I was able to flash a boot.img , now I can boot into the OS (unrooted). Next step will be patching the boot.img and trying to reflash TWRP I think.

 

[pndwal]

I wanted to test Magisk 22 on my old Moto G 2014 running Aosp Extended (Android 7.1.2), unhid Magisk 20.4 and went to direct install. That didn´t work, nothing happened when pressing the button.
As I had no boot.img availabe at the moment I changed the ending of the apk to zip, booted into TWRP and tried to flash it.
I got an error message (sorry, I don´t remember the text) and now the device won´t boot anymore and the TWRP recovery seems to be gone too.
I only get to the Fastboot Flash Mode screen to select between

-Normal Powerup (goes back to Fastboot screen)
-Recovery (goes back to Fastboot screen)
-Factory
-Barcodes
-BP Tools
Underneath is the error message

Invalid boot image header
Fastboot Reason: Fall-through fron mot-charger boot mode
USB conncted

Usb is conncted as I tried to flash or boot into TWRP by fastboot, results in the following error:

C:\Mini ADB and Fastboot>fastboot flash recovery twrp-3.4.0-0-titan.img

(bootloader) has-slot:recovery: not found

(bootloader) is-logical:recovery: not found

Sending 'recovery' (8192 KB)                       OKAY [  0.290s]

Writing 'recovery'                                 OKAY [  0.400s]

Finished. Total time: 0.743s

I´m a bit rusty regarding those errors so any help is appreciated .
As this is my testing device every way would be ok for me, restoring a backup or anything else but as long as I can´t boot or flash into TWRP it seems I´m stuck at the moment.

Edit: Extrcted a boot.img from the AEX firmware I´m running and tried to boot into it, error message:

C:\Mini ADB and Fastboot>fastboot flash boot boot.img

(bootloader) has-slot:boot: not found

(bootloader) is-logical:boot: not found

Sending 'boot' (8592 KB)                           OKAY [  0.310s]

Writing 'boot'                                     OKAY [  0.418s]

Finished. Total time: 0.801s

and see attached screenshot.

This has happened to a number of us w/ this update. Corruption of boot image occurs when no activity occurs when doing direct update or patching image. Fixed easily by fastboot flashing working boot image (I used a previously used Magisk patched one).
https://xdaforums.com/t/magisk-general-support-discussion.3432382/post-84544473

Later, I tried patching and direct update from 22001 again, and this time it worked fine... Still a bit baffled by that.
https://xdaforums.com/t/magisk-general-support-discussion.3432382/post-84550967

Not sure why your TWRP seems corrupted, but looks like boot.img flashing may fail only due to some corruption (from screenshot)...

Keep trying! PW

Edit: See you succeeded w/ boot image. Great...

You haven't got a previously patched / working boot image to flash from same ROM? - easy way to get root back!

Otherwise, try patching image only. If no freeze now direct update should work also, but you may want to patch / flash manually to avoid a repeat. PW

PW

 

[Wolfcity]

This has happened to a number of us w/ this update. Corruption of boot image occurs when no activity occurs when doing direct update or patching image. Fixed easily by fastboot flashing working boot image (I used a previously used Magisk patched one).
https://xdaforums.com/t/magisk-general-support-discussion.3432382/post-84544473

Later, I tried patching and direct update from 22001 again, and this time it worked fine... Still a bit baffled by that.
https://xdaforums.com/t/magisk-general-support-discussion.3432382/post-84550967

Not sure why your TWRP seems corrupted, but looks like boot.img flashing may fail only due to some corruption (from screenshot)...

Keep trying! PW

Edit: See you succeeded w/ boot image. Great... Did TWRP come right? PW

Just booted into OS and am going to flash the boot.img.
Than I will check the TWRP status.
EDIT: TWRP is back too.
Thx for your help.

 

[pndwal]

I just updated to Magisk 22.0 and now Netflix install but doesn't open. Am I the only one ?
Redmi note 9S rom Xiaomi.EU Android 10 MIUI 12.0.3
I tried to install older version of Netflix without success.
Safetynet pass

Any idea?
Thank you

Working fine for me on 22001 (identical to public 22.0). Redmi Note 8T, stock ROM.

Have you selected app in MagiskHide list also? And check Google Play Services is selected too.

Also check that Playstore Settings Play Protect says Device is certified. If not, clear PlayStore Data.

Next, Toggle MagiskHide off and on again in Magisk app Settings (sometimes helps). Reboot. Check if root is detected now. If still detected, clear App data and check again.

If still detected, many more tips here:
https://www.didgeridoohan.com/magisk/MagiskHide PW

 

[Wolfcity]

This has happened to a number of us w/ this update. Corruption of boot image occurs when no activity occurs when doing direct update or patching image. Fixed easily by fastboot flashing working boot image (I used a previously used Magisk patched one).
https://xdaforums.com/t/magisk-general-support-discussion.3432382/post-84544473

Later, I tried patching and direct update from 22001 again, and this time it worked fine... Still a bit baffled by that.
https://xdaforums.com/t/magisk-general-support-discussion.3432382/post-84550967

Not sure why your TWRP seems corrupted, but looks like boot.img flashing may fail only due to some corruption (from screenshot)...

Keep trying! PW

Edit: See you succeeded w/ boot image. Great...

You haven't got a previously patched / working boot image to flash from same ROM? - easy way to get root back!

Otherwise, try patching image only. If no freeze now direct update should work also, but you may want to patch / flash manually to avoid a repeat. PW

PW

Was able to patch a boot.img with Magisk 22.0 (22000)(18) stable and flash it by fastboot.
Still no root (installed (n/a).....
No older patched img available, was the first time I used this method on that device.
Should I try the procedure with 22001 ?
I could downgrade to 21.4 but I´m curious now.......

C:\Mini ADB and Fastboot>fastboot flash boot magisk_patched_v2LUN.img
(bootloader) has-slot:boot: not found
(bootloader) is-logical:boot: not found
Sending 'boot' (9072 KB)                           OKAY [  0.317s]
Writing 'boot'                                     OKAY [  0.333s]
Finished. Total time: 0.695s

 

[vittorekaos]

Where can I find the latest version of Magisk to download?

 

[Wolfcity]

Where can I find the latest version of Magisk to download?

As ever on GitHub :

GitHub - topjohnwu/Magisk: The Magic Mask for Android

The Magic Mask for Android. Contribute to topjohnwu/Magisk development by creating an account on GitHub.

github.com

 

[pndwal]

Was able to patch a boot.img with Magisk 22.0 (22000)(18) stable and flash it by fastboot.
Still no root (installed (n/a).....
No older patched img available, was the first time I used this method on that device.
Should I try the procedure with 22001 ?
I could downgrade to 21.4 but I´m curious now.......

C:\Mini ADB and Fastboot>fastboot flash boot magisk_patched_v2LUN.img
(bootloader) has-slot:boot: not found
(bootloader) is-logical:boot: not found
Sending 'boot' (9072 KB)                           OKAY [  0.317s]
Writing 'boot'                                     OKAY [  0.333s]
Finished. Total time: 0.695s

Did you have hidden Magisk app when upgrading? See release Notes:
https://xdaforums.com/t/magisk-general-support-discussion.3432382/post-84543421 PW

 

[Caffeinadict]

Hey all, I recently flashed LineageOS 17.1 to my Galaxy S5, (SM-G900W8) and am now attempting to root with Magisk using TWRP (v3.5.0). Upon installing the Magisk manager app I noticed that it now says SAR: yes, whereas when I had rooted previously (Android 6.0.1) it said SAR: no. The official installation page has special instructions for rooting Samsung devices with SAR, so just wondering if I should follow a different procedure than usual or if it doesn't matter since I'm using a custom recovery to flash the root/running Lineage. Thanks!

Update: Decided to just go for it and flash the root since the instructions for Samsung devices with SAR didn't seem to apply to devices with custom ROMs. All went well!

 

[Wolfcity]

Did you have hidden Magisk app when upgrading? See release Notes:
https://xdaforums.com/t/magisk-general-support-discussion.3432382/post-84543421 PW

Yes, I unhid it before. I'm the kind of guy who's looking for changelogs everywhere...
Patched the boot.img several times with stable and canary but without success, device stayed unrooted.
For now everything is back to normal (on 21.4 again) but I'm not through with 22.