Magisk General Support / Discussion
- Thread starter topjohnwu
- Start date
Don't start with other docs, please read official Installation Instruction carefully, then ask here if anything is unclear or doesn't work.
Official Installation Instruction is accessed from Magisk main page on John Wu's GitHub (under Useful Links), where, I hope, you downloaded Magisk App.
From Magisk App, just click GitHub OctoPuss (cat) symbol on home screen.
If you have compatable TWRP (custom Recovery) for your device, you can follow Custom Recovery section (Nb. Magisk in Recovery is something different altogether, and won't apply to your 'legacy' device).
Otherwise, familiarise yourself with Patching Images section before proceeding. Nb. Depending on how your Sammy ROM package archives boot image, some of the information for newer SAR devices in Samsung section may be useful for you if using Patching method.
Read, read, read. Then proceed!
PWEdit: Seems from this:
https://xdaforums.com/t/magisk-22-n...0f-touchwiz-armeabi-v7a.4253113/post-84870675
that you may have actually tried flashing 22100 using TWRP... but it's not clear.
You really need to say what you have tried.
If you did flash (aside from installing App), did you have a previous version? Direct Update within App?
Please give us a clue if you are still facing issues.
PW
Last edited:
Latest Debug (Canary)
Changelog and Release Notes
https://github.com/topjohnwu/magisk-files/blob/56d4ca44e12927217ae761df0874e3cd7d05cea4/notes.md :
May fix sundry issues with Magisk App! PW
Changelog and Release Notes
https://github.com/topjohnwu/magisk-files/blob/56d4ca44e12927217ae761df0874e3cd7d05cea4/notes.md :
Magisk (fb8000b5) (22104)
- [App] Hide annoying errors in logs when hidden as stub
- [App] Update stub implementation
- [App] Some internal code refactoring
- [App] Update snet extension implementation
Diffs to v22.1
- [App] Update snet extension. This fixes SafetyNet API errors.
- [App] Fix a bug in the stub app that causes APK installation to fail
- [App] Hide annoying errors in logs when hidden as stub
- [General] Remove all pre Android 5.0 support
- [MagiskPolicy] Remove unnecessary sepolicy rules
- [General] Fix a C++ bug that causes undefined behavior
- [MagiskHide] Update package and process name validation logic
May fix sundry issues with Magisk App!
PWU can remove magisk directly in magisk itself
First open magisk app
Than click on uninstall magisk button in magisk app
Reboot than magisk is successfully uninstalled
Rename the Magisk APK file to uninstall.zip and flash it in TWRP.
From the official instuctions.
Magisk Installation - github.io - Uninstallation - Link
Personal Note:
You may also need to manually flash your rom's stock boot image.
Cheers.
Hi, Thank you very much for the replied. Please refer to the this here for my feedback:Don't start with other docs, please read official Installation Instruction carefully, then ask here if anything is unclear or doesn't work.
Official Installation Instruction is accessed from Magisk main page on John Wu's GitHub (under Useful Links), where, I hope, you downloaded Magisk App.
From Magisk App, just click GitHub OctoPuss (cat) symbol on home screen.
If you have compatable TWRP (custom Recovery) for your device, you can follow Custom Recovery section (Nb. Magisk in Recovery is something different altogether, and won't apply to your 'legacy' device).
Otherwise, familiarise yourself with Patching Images section before proceeding. Nb. Depending on how your Sammy ROM package archives boot image, some of the information for newer SAR devices in Samsung section may be useful for you if using Patching method.
Read, read, read. Then proceed!
Edit: Seems from this:
https://xdaforums.com/t/magisk-22-n...0f-touchwiz-armeabi-v7a.4253113/post-84870675
that you may have actually tried flashing 22100 using TWRP... but it's not clear.
You really need to say what you have tried.
If you did flash (aside from installing App), did you have a previous version? Direct Update within App?
Please give us a clue if you are still facing issues.
Do let me know where is more appropriate to post my issue so that I won't be consider spamming the forum...tqvm for the help.
Hi. It's fine to post here - this is Magisk General Support / Discussion after all!
Updates there are clear however.
Yes, Latest 2 Canary builds have fix for Magisk SafetyNet check error, which is not actually indicating a failed result, only an evaluation failure. SafetyNet is actually still passing if PlayStore Settings shows PlayProtect Device is certified result. (Read recent posts here.)
Question: When updating to 22.1 App, did you have Manager hidden? Unhiding is critical due to incompatibility between old Manager and new App, as per release notes.
If you didn't do this, you likely have two conflicting Magisk apps installed.
PW
Hi,Hi. It's fine to post here - this is Magisk General Support / Discussion after all!
Updates there are clear however.
Yes, Latest 2 Canary builds have fix for Magisk SafetyNet check error, which is not actually indicating a failed result, only an evaluation failure. SafetyNet is actually still passing if PlayStore Settings shows PlayProtect Device is certified result. (Read recent posts here.)
Question: When updating to 22.1 App, did you have Manager hidden? Unhiding is critical due to incompatibility between old Manager and new App, as per release notes.
If you didn't do this, you likely have two conflicting Magisk apps installed.
Question: When updating to 22.1 App, did you have Manager hidden? Unhiding is critical due to incompatibility between old Manager and new App, as per release notes.
Answer: No, I did not hide the Manager when updating to 22.1 App. After the updated and patched the app-debug.apk (Canary) then got the Installed: N/A.
Thank you.
Install latest debug Canary Magisk (fixed), or wait for next public Stable / Beta.
Nb. Magisk (at least w/ Universal SafetyNet Fix module) is still passing SafetyNet fine.
Latest 2 Canary builds have fix for Magisk SafetyNet check error, which is not actually indicating a failed result, only an evaluation failure. SafetyNet is actually still passing if PlayStore Settings shows PlayProtect Device is certified result. (Read recent posts here.) PW
Ok.
There have been a number of issues raised on Magisk GitHub recently, relating to Android 6 (Marshmallow) problems, some closed due to insufficient information...
The OP of the thread you commented in had opened one for your Samsung Galaxy Note 4. It'ss still open:
https://github.com/topjohnwu/Magisk/issues/4174
You may wish to help /provide information / logs for your device there also if no-one else here has suggestions.
I think there may well be overlooked regressions in recent builds affecting your device, and likely other older devices also.
PW
Last edited:
ok, noted with thanks. Will go read through it and because I'm a new user at github I'm not able to post it.Ok.
There have been a number of issues raised on Magisk GitHub recently, relating to Android 6 (Marshmallow) problems, some closed due to insufficient information...
This one for your Samsung Galaxy Note 4is still open:
https://github.com/topjohnwu/Magisk/issues/4174
You may wish to help /provide information / logs for your device there also if no-one else here has suggestions. I think there may well be overlooked regressions in recent builds affecting you.
Ah, yes; John has recently been frustrated by issues not following his template / instructions, which waste his valuable time. He recently restricted issues to colaborators only, then opened again, but apparently with restrictions.
Since the issue was opened by the OP of the XDA thread you commented in, you may be able to help there...
I'm sure this will get needed attention, as that user is persistent. He's opened new issue (bug) reports regarding this at least three times now! PW
Hello.
After installing the latest canary channel Magisk APK, which helped to pass Safety Net check. But unfortunately I have observed the issue that any of banking apps refuse to authorize using the biometric fingerprint sensor, only the password. Have anyone noticed such strange behavior?
Best regards.
Witek
After installing the latest canary channel Magisk APK, which helped to pass Safety Net check. But unfortunately I have observed the issue that any of banking apps refuse to authorize using the biometric fingerprint sensor, only the password. Have anyone noticed such strange behavior?
Best regards.
Witek
Is that a Samsung device? Universal SafetyNet fix installed? If so:
https://xdaforums.com/t/magisk-general-support-discussion.3432382/post-84746087
Otherwise, please give some details / clues! PW
Yes, I use Samsung S9 device indeed. I must have somehow missed thread about biometric issue. Thank you. I installed the mentioned Safety Net fix 2.0 test4, and biometric authorization began to work on the banking apps again. But Safety Net check in the Magisk app has changed from working basic evaltype into hardware, which doesn't work on rooted devices. Probably I have to wait until developers will be able to deal with all current problems.
Best regards,
Witek
When I updated the magisk app to 22.1, safetynet basic integrity and cts both are false now. Earlier with 22.0, it worked with magisk hide props config with universal safetynet fix. What to do now?
API error? (If yes, did you follow the previous conversation about the need to install Canary 22104 or to test with a third party SN checker)
Similar threads
Top Liked Posts
-
There are no posts matching your filters.
-
5
Known issue. A fix has been merged. You can use the Debug app, revert back to 27001 or wait until 27003 is released.
EDIT: Ninja'd
4
Only v27000 is Stable. (and Beta). v27001 and v27002 are Canary or Debug
Set your Update Channel to Stable and you will see (just like you can see also on GitHub) that latest Stable is v27000, there was never Stable v27001 or v27002
Generally, Stable is always Nx100
So, you cannot downgrade to Stable v27001 but Canary v27001 should be just like Stable v27000 (same codebase). That's also the general policy, whenever Nx100 Stable is released, then immediately comes Canary Nx100 +1, on the same code-base
Therefore, downgrade to Stable v27000 instead4
Yep, I told you several times that you need Recovery mode (selected) for your Ramdisk=No device; instructions for this are also clear in official Installation Instruction page too, but apparently you have not been trying to follow official instructions, so it's no real surprise you've messed up firmware too... Please take *extra* care when modding as there are simply so many variables and pitfalls!
Are you flashing patched AP (Application Processor binary) along with all the other package binaries (X4?) for your S10+ (also in Magisk Installation page, Samsung section)??
CP is Cellular Processor (Nb. Oft repeated references to CP as 'core processor' may be misleading) binary package (also referred to as Baseband Modem) so that should have fixed mismatched baseband etc... correct CSC (Consumer Software Customization; region, APN and carrier specific software packages/settings) and even BL (Bootloader) are most likely also important...
Nb. BL doesn't always update bootloader version, but if later firmware has been flashed be aware that these can also cause anti-roll back version for bootloader to be incremented (in the event that an update patches serious vulns) so you original firmware may be blocked and you may need to use later packages only...
If flashing latest complete firmware package via Odin doesn't fix your IMEI / baseband issues it may be that you've messed with partitions that contain unique device values in the past... You may need to ask in Galaxy, S10 or S10+ XDA forums for that.
PW4
Known problem with 27002, the debug version doesn't have the problem with hiding, read back to see the discussion about it3
Run magisk -c from adb shell and see what version it reports.
Then uninstall every copy of magisk app,
You have more than one (including possibly a hidden one)
Then reboot and install magisk app matching the version reported by magisk -c command. -
1103This is the place for general support and discussion regarding "Public Releases", which includes both stable and beta releases.
All information, including troubleshoot guides and notes, are in the Announcement Thread156Hello, I haven't given much support on XDA lately. It can be resulted from
- University started and I have limited free time. In fact, I mostly develop during midnight
- I live in Taiwan, which has large time zone differences between my European/American contributors/testers, which usually forces me to stay up late at night to discuss/test stuffs.
- The new version is about to come, I don't want to spend effort on supporting old releases
New Forum!
As you might have already discovered, Magisk got its own subforum on XDA! Many thanks to all the support you gave me, and much more information/features/support is about to come!
**For developers supporting all the devices that are not using standard Android boot format, feel free to create threads in this section (actually, PLEASE do so) for your favorite devices after v7 is out. As I currently know, Asus devices require signing the boot image before flashing, and is model dependant; Sony devices seems to use ELF kernel that is unpatchable, or some has two ramdisks (inner + outer), both requires different workarounds; LG bootloader locked devices has to manually "BUMP" the boot image after flashing Magisk..... and there may be lots of other crazy boot image formats that haven't come up to my attention yet.
It is impossible for me to support all these non-standard boot images, and I hope the community can collaborate to make Magisk running across all the devices. Overall, community collaboration is what XDA about
The Pixel Phone
Some of you might already know this news, that the next Pixel Phone right around the corner seems like it does not have ramdisk in boot image, which pretty much wrecked Magisk in all ways. However, it pretty much doomed root itself too. Kernel modifications is inevitable IMO, so I'll try to migrate my scripts to C programs that could possibly be included into the kernel itself. Note that I'm not familiar with linux kernel, I'm not even sure if my idea and concept is correct or not. But once the device is available, I think developers will find a way to bypass all the difficulties, and I'll do my best to learn things
Current Progress
In the past month, I've spent quite some time learning SELinux, so that I can avoid using SuperSU's sepolicy patches. Thanks to the helps and tips from @phhusson and @Chainfire, I finally have a much clearer understanding of how SELinux works. The Magisk core parts (the scripts, boot image patches, new features, more supports) are actually done some time ago. What is causing all the delays is the Magisk Manager.
To be completely honest, although I can code in Java without much issues, Magisk Manager is actually my first Android application, I had to reach out for assistance, and fortunately awesome developers like @DVDandroid and @digitalhigh contributed a lot, which makes the current Manager awesome.
After the repo system and module management is mostly done, I was about to do some adjustments and release, but what we really done is decided to add another feature: auto-unroot with per-app settings. I decided to wait for it to be finished, and then do my adjustments. Due to reasons that'll be mentioned later, this feature will likely not be available for the next release (should come in future updates)
Safety Net Disaster
Those who are using Magisk for Safety Net bypass purposes must have known that Google recently updated the detection method of my Systemless Xposed. I still have no idea what Safety Net is detecting, so currently I cannot fix it on my side (also because I'm busy working on the next update). However, suhide developed by @Chainfire is able to hide Xposed and worked fine.
However, only my Systemless Xposed v86.2, which is based on SuperSU's su.d, is supported using that method. v86.2 and v86.5 (latest, Magisk based) have nearly identical binaries, and the only difference is the path where the binaries are stored.
I'm still not sure what's the real issue for it not being supported, I just hope it is not done intentionally.
Conclusion
Due to the fact that my Safety Net bypass is not 100% perfect now, I do not want to spend any more time waiting for auto-unroot to be polished. What I'm doing now is finishing up all the things I'd like to change in Magisk Manager (it has been a while since I last contributed to Manager, my fellow developers are doing all the heavy job), which might take a little more time, after that, packed with tons of information to be announced in Magisk Section, I'll release the long awaited update.
Hope this lengthy post gives you the idea of the whole situation, and again thanks for all your support!!121Ah, some Chainfire bashing, I hope it is not too late for me to exercise additional villainy.
First, let me make clear I have nothing against @topjohnwu, nor against Magisk. Magisk is an interesting project and it certainly displays @topjohnwu ingenuity and persistence. I don't doubt we will see more interesting things from his hands.
-------------------------
What has happened here is not all that dark and complicated, from either end. I returned from holidays, and someone pointed me at Magisk. My first thought: interesting!
Among other things, the thread lists some issues with SuperSU, which in combination with the phrase The developer also requests users to not bug Chainfire with compatibility requests for SuperSU with Magisk from the portal article, raised my left eyebrow by nigh half an inch. The popular systemless xposed mod is apparently now based on it, and apparently it now no longer works with SuperSU, and apparently I'm not supposed to fix that, nor any of the other found issues. I found that a bit weird. So yes, I have told @topjohnwu that I was a bit surprised he was posting about issues with SuperSU without notifying me about them (I can't fix or help fix issues I'm not aware of, after all).
He's also spreading a modified version of the SuperSU package, which is not all that uncommon, nor necessarily a problem. I have not looked into what he modified, I only ran a few quick tests on one of my devices, and found some commonly used commands run as root to be broken. I have informed him of this as well.
It appears the tool of choice for Magisk is phh's Superuser, because of some of the mentioned issues with SuperSU. That's fine by itself, but fixing issues in that superuser by incorporating SuperSU's binaries into it is a somewhat questionable practise. After all, SuperSU is a commercial closed-source package that helps pay for my dinner, and superuser is a direct competitor. I have informed him that I was surprised he did this without asking for permission. I have expressed similar surprise on him spreading a modified version of LiveBoot (which helps pay for a snack now and then).
@topjohnwu has also stated that Magisk's scripts are largely influenced by mine (I have not checked). Scripts based on mine are used all over the place on XDA, some people have crafted amazing things based on them, I have never made an issue of this (otherwise I would have just made them binaries). But yes, I have also stated to him that I don't think it's very nice to base something on one program, and then using that to (almost exclusively) push something directly competing with that program.
tl;dr Towards @topjohnwu, I have:
- expressed surprise he has issues getting Magisk to work with SuperSU, and has chosen not to inform me about those
- expressed surprise he is using SuperSU binaries in a competing superuser without permission
- expressed surprise he is posting a modified LiveBoot without permission
- informed him of issues with the modified SuperSU he has posted
- let him know I thought it wasn't very nice to be applying my scripts to benefit seemingly exclusively that same competing superuser
To be crystal clear:
- I have not asked for an apology
- I have not asked for Magisk to be abandoned, neither the root hiding nor systemless module parts, and certainly not systemless xposed
- I have not made an issue of any of this anywhere, until this post
- I have not even specifically asked for anything to be taken down (though obviously in my opinion the other superuser package mixed with SuperSU's binaries, as well as the LiveBoot package, should go)
- I have not reported this thread to XDA moderators for copyright violations or otherwise
While my conversation with @topjohnwu may not win any awards for being friendly (though it may win some for brevity), I think all things considered my response has been rather mild. To be perfectly honest, until the apology post, I thought this was over with already. I think the apology post was triggered because I haven't replied to his last PM for a while - I was in the zone, it happens.
To emphasize again, I have nothing against @topjohnwu, Magisk, or systemless xposed, and it is certainly not my goal to see any of them go. If it can be made to work together with SuperSU, great.
I get it though: you think of something, you want to see if you can make it work, you finally get it to work, you publish it, it takes off - enthusiasm gets the better of you. Maybe in the rush some mistakes are made. That doesn't mean you have to just drop it and run. None of my stuff would make it past 0.1 if I stopped at the first big mistake
Aside from said being in the zone coding, I usually regret actually responding to these sort of things the day after, which has made me hesitant to reply. Surprise me.76Thread temporarily closed so everyone sees this.
The flood of "SafetyNet isn't working for me either!" posts are not helpful, at all. Please refrain from posting further, it will be looked into. Please do not forget that not passing SafetyNet is 100% NORMAL AND INTENDED when you have an unlocked booloader or running custom firmware. These are workarounds and they will be worked around in turn.
The Flash
Forum Moderator
EDIT: Thread is reopened... I will be cleaning any SafetyNet posts for a while to keep the thread clean for real issues.75Hello everyone!
I am aware that Google has updated Safety Net that makes Magisk itself a no go for Android Pay. In fact, I witnessed the change live while I am developing the new magiskhide, which should hide all Magisk modules and Magisk installed root.
Google is serious about Safety Net now, clearly hunting down all possibility to run Xposed with Safety Net passed. I spend quite some time examining the new security measures last midnight, and fortunately it seems that it is possible to run Magisk and root along with Safety Net if no Xposed is running. I'm glad I removed the old root toggle at the right time lol, that is no longer feasible with the latest detection.
So stay tuned for the next update, it will come with bug fixes, along with the new magiskhide to bypass that Safety Net.
Google, how will a few systemless mods do any harm
