Magisk General Support / Discussion

Search This thread

535iu

Senior Member
Feb 22, 2016
165
10
You omitted the most important details like model, firmware

Assuming ramdisk.img, you should have Huawei with exactly EMUI 8.x?

Do you still have your ramdisk patched with the old Magisk - to revert if neccessary.
Try (re) patching with the new Magisk that ramdisk img previously (successfully) patched by the old Magisk, instead of patching the stock ramdisk

Try also with Magisk Canary (it's newer than Stable)

Use the appropriate (Stable or Canary) Magisk app
Hi. Yes, I have a Huawei Mate 10 8.0.0.

I have tried patching the original ramdisk and the last patched ramdisk (20.4). Nothing worked. Magisk and Magisk Canary patch the ramdisk wrong.

It's strange, because when Magisk/Canary patches the ramdisk wrong, the size of the file obtained is the same as the original ramdisk: 16 MB. However, in the old ramdisk patched correctly, the size was reduced: from 16 MB to 8 MB.

Is it possible that new versions of Magisk are not compatible with my phone? I currently have v20.4. The latest version of Magisk is 22.1. For example, if my phone was only compatible with version 21.0 (at most), how could I patch the ramdisk to version 21?

(Sorry for my bad English).
 
  • Like
Reactions: J.Michael

zgfg

Senior Member
Oct 10, 2016
10,737
9,325
Redmi K20 / Xiaomi Mi 9T
Xiaomi Mi 11
Hi. Yes, I have a Huawei Mate 10 8.0.0.

I have tried patching the original ramdisk and the last patched ramdisk (20.4). Nothing worked. Magisk and Magisk Canary patch the ramdisk wrong.

It's strange, because when Magisk/Canary patches the ramdisk wrong, the size of the file obtained is the same as the original ramdisk: 16 MB. However, in the old ramdisk patched correctly, the size was reduced: from 16 MB to 8 MB.

Is it possible that new versions of Magisk are not compatible with my phone? I currently have v20.4. The latest version of Magisk is 22.1. For example, if my phone was only compatible with version 21.0 (at most), how could I patch the ramdisk to version 21?

(Sorry for my bad English).
Suggested you to try using Magisk Canary, which is 22104. Not guarantee but worth to try (if nothing else works)

Also, suggested you to try patching your ramdisk img that you previosly (successfully) patched with Magisk 20.4 - if that img was 8 MB, once you repatch by the new Magisk it will likely stay 8 MB

(Although the size should not matter that much - stock images are filled by zero bytes to the full size. Old Magisk cut off the filler bytes, while the new Magisk keeps the full size patched images)

Unfortunately, Magisk guides practically says that Huaweis are no more supported (if I recall correctly) because of troubles with unlocking the Huawei Bootloaders. If so, you are probably on your own to experiment with Stable and Canary, repatching the patched ramdisk instead of the stock one, etc

If nothing would work, you can stay with the old Magisk that happily worked for you - don't be concerned about SafetyNet showing API error and thus failing - you can use a third party SN checker and it should pass. Or just update Magisk app to Canary but stay with the old Magisk (the apk, former Manager, performs SN check and it fails there with the old one because of the old API key, needed for testing and nothing else
 
Last edited:
  • Like
Reactions: 535iu and J.Michael

Tanvir Rezwan

Member
Apr 15, 2021
10
6
If you have Systemless Hosts, disable or remove it from modules.

OTTOMH this is a major cause of instability in kernels with f2fs loopback bug present.

If your kernel has this bug, there may be other causes also, especially other Magisk modules. PW
The problem not fixed. i removed systmless host module but still after 20 - 24 hours pubg stuck and lagged
but all other thing is ok.
 

pndwal

Senior Member
The problem not fixed. i removed systmless host module but still after 20 - 24 hours pubg stuck and lagged
but all other thing is ok.
Seen this?:
https://xdaforums.com/t/pubg-crashing-fixed-on-rooted-phones.4073331/

Seems pubg now detects root, but doesn't Give any error, just crashes.

So you need to hide root from pubg like any security centric bank app. My method:
https://xdaforums.com/t/magisk-general-support-discussion.3432382/post-84936057

Nb. Hide / wipe order.

Additionally, seems you also need to hide Magisk App according to 'pubg-crashing...' thread OP.

Nb.2. OP there may be confused about the need for MagiskHide Props Config module. It shouldn't make ANY difference unless props are also 'configured' (added / altered) through its terminal emulator interface, but OP hasn't indicated any changes to make / configuration. (I could be wrong, but try first without it.)

Hope this one helps! 😛 PW
 

pndwal

Senior Member
Hi. Yes, I have a Huawei Mate 10 8.0.0.

I have tried patching the original ramdisk and the last patched ramdisk (20.4). Nothing worked. Magisk and Magisk Canary patch the ramdisk wrong.

It's strange, because when Magisk/Canary patches the ramdisk wrong, the size of the file obtained is the same as the original ramdisk: 16 MB. However, in the old ramdisk patched correctly, the size was reduced: from 16 MB to 8 MB.

Is it possible that new versions of Magisk are not compatible with my phone? I currently have v20.4. The latest version of Magisk is 22.1. For example, if my phone was only compatible with version 21.0 (at most), how could I patch the ramdisk to version 21?

(Sorry for my bad English).
There have been previous issues where zero padding causes problems, but I don't see any known ones currently.

However, these two issues may (probably) be affecting you (actually seems to be one issue, first running Android 8 EMUI like you, second running Android 9 LOS16.0):
https://github.com/topjohnwu/Magisk/issues/4297

https://github.com/topjohnwu/Magisk/issues/4306

Just been labelled a Regression, and @osmosis appears to be on it. 😛

If the regression is in this commit of 4 May 2020:
https://github.com/topjohnwu/Magisk/commit/0c99c4d93f638d5cde9a232321af791c54be278b
as user indicates (and this is your problem), last working Public Stable Magisk for you will, in fact, be 20.4.

It's surprising it's taken this long to be reported!... Guess there may not be many Huawei users testing Canary. 🙄 PW
 
Last edited:
  • Like
Reactions: 535iu and J.Michael

pndwal

Senior Member
After updating to a.61 from a.59, there was a bootloop ( a.59 was rooted with magisk patched image), but after download a.61 update from realme website and then flashing original boot image, it worked, but my device is no longer rooted and safety net cts profile fails.
Tried rooting a.61 but there is a boot loop (even though performed same earlier method).
Device details attached.View attachment 5301757
I'm guessing you didn't Restore Images to take OTA? - you need unaltered read-only partitons such as /system, /vendor, /recovery, /boot to take stock OTA.

Generally, flash stock Recovery if using TWRP, and Uninstall Magisk using Restore Images function.

Next, seems you flashed boot.img from earlier .59 build? (So you're on .61 w/ old boot image?) ... Patching non-matching boot.img may be causing latest bootloop. You need to patch boot.img for current ROM build.

Sorry if I misunderstood what you've done, but you've given very little away! 😬 PW
 
  • Like
Reactions: J.Michael

SaikiK

Member
May 29, 2019
10
3
Hello, thank you for replying. I don't know how to restore earlier images as phone is updated. My phone is working fine, I restored new a.61 boot.img only. But after patching this file by magisk, I ran into boot loop. Then restored original a 61 boot.img and it works fine. It's just that patched boot.img is not working.
 
  • Like
Reactions: pndwal

Xellerate

Member
Apr 8, 2020
48
8
After patching the entire ap file from stock firmware, and then flashing it, my android boots up without the touchscreen working, this can only be avoided by flashing a patched boot.img even though magic app states that i don't have a ram disk, and when I flash a patched recovery it says vbmeta not verified
 
  • Like
Reactions: J.Michael

535iu

Senior Member
Feb 22, 2016
165
10
Suggested you to try using Magisk Canary, which is 22104. Not guarantee but worth to try (if nothing else works)

Also, suggested you to try patching your ramdisk img that you previosly (successfully) patched with Magisk 20.4 - if that img was 8 MB, once you repatch by the new Magisk it will likely stay 8 MB

(Although the size should not matter that much - stock images are filled by zero bytes to the full size. Old Magisk cut off the filler bytes, while the new Magisk keeps the full size patched images)

Unfortunately, Magisk guides practically says that Huaweis are no more supported (if I recall correctly) because of troubles with unlocking the Huawei Bootloaders. If so, you are probably on your own to experiment with Stable and Canary, repatching the patched ramdisk instead of the stock one, etc

If nothing would work, you can stay with the old Magisk that happily worked for you - don't be concerned about SafetyNet showing API error and thus failing - you can use a third party SN checker and it should pass. Or just update Magisk app to Canary but stay with the old Magisk (the apk, former Manager, performs SN check and it fails there with the old one because of the old API key, needed for testing and nothing else
There have been previous issues where zero padding causes problems, but I don't see any known ones currently.

However, these two issues may (probably) be affecting you (actually seems to be one issue, first running Android 8 EMUI like you, second running Android 9 LOS16.0):
https://github.com/topjohnwu/Magisk/issues/4297

https://github.com/topjohnwu/Magisk/issues/4306

Just been labelled a Regression, and @osmosis appears to be on it. 😛

If the regression is in this commit of 4 May 2020:
https://github.com/topjohnwu/Magisk/commit/0c99c4d93f638d5cde9a232321af791c54be278b
as user indicates (and this is your problem), last working Public Stable Magisk for you will, in fact, be 20.4.

It's surprising it's taken this long to be reported!... Guess there may not be many Huawei users testing Canary. 🙄 PW
Thank you. I have exactly the same problem as in the first link, the only difference is the phone model.

I assume that if the bug in the second link is fixed, it will also work for the problem in the first link.

Does the "regression" tag mean that the problem will be fixed?

Until recently, I had no plans to update Magisk. However, I need to successfully pass the SafetyNet filter. I have read that the latest version of Magisk allows to succeed with SafetyNet. It is possible that SafetyNet is the reason why other users want to upgrade Magisk after such a long time and have taken the time to report it on GitHub.

Do you think the problem will be fixed, maybe in the next release?
 
  • Like
Reactions: pndwal

pndwal

Senior Member
Hello, thank you for replying. I don't know how to restore earlier images as phone is updated. My phone is working fine, I restored new a.61 boot.img only. But after patching this file by magisk, I ran into boot loop. Then restored original a 61 boot.img and it works fine. It's just that patched boot.img is not working.
Ah, got it now. Sorry, misunderstood ' original boot image'.

Done some checking into your model and build numbers. Seems you have Realme C3, and Update was to Android 11.

Looks like you have a now known issue:
https://github.com/topjohnwu/Magisk/issues/4313

User @HemanthJabalpuri posted here too:
https://xdaforums.com/t/magisk-general-support-discussion.3432382/post-84963087

Might just have to watch that one. 😛 PW
 
Last edited:

zgfg

Senior Member
Oct 10, 2016
10,737
9,325
Redmi K20 / Xiaomi Mi 9T
Xiaomi Mi 11
Thank you. I have exactly the same problem as in the first link, the only difference is the phone model.

I assume that if the bug in the second link is fixed, it will also work for the problem in the first link.

Does the "regression" tag mean that the problem will be fixed?

Until recently, I had no plans to update Magisk. However, I need to successfully pass the SafetyNet filter. I have read that the latest version of Magisk allows to succeed with SafetyNet. It is possible that SafetyNet is the reason why other users want to upgrade Magisk after such a long time and have taken the time to report it on GitHub.

Do you think the problem will be fixed, maybe in the next release?
If your 'problem' is Magisk mngr/apk showing API error for SafetyNet - simply don't mind (don't do SN tests from Magisk mngr/apk), use 3rd party SN checkers instead (available on Google Play) or just install the latest Magisk Canary apk (instead of your old Manager) but keep the Magisk that works for you

SN API error is because the SN key has expired. Every app that wants to do SN tests must register a key with Google - and that key has expired in the old Mngr.
But it has nothing with any other app that will do its own SN test (with its own key)
 
Last edited:

pndwal

Senior Member
There have been previous issues where zero padding causes problems, but I don't see any known ones currently.

However, these two issues may (probably) be affecting you (actually seems to be one issue, first running Android 8 EMUI like you, second running Android 9 LOS16.0):
https://github.com/topjohnwu/Magisk/issues/4297

https://github.com/topjohnwu/Magisk/issues/4306

Just been labelled a Regression, and @osmosis appears to be on it. 😛

If the regression is in this commit of 4 May 2020:
https://github.com/topjohnwu/Magisk/commit/0c99c4d93f638d5cde9a232321af791c54be278b
as user indicates (and this is your problem), last working Public Stable Magisk for you will, in fact, be 20.4.

It's surprising it's taken this long to be reported!... Guess there may not be many Huawei users testing Canary. 🙄 PW
Thank you. I have exactly the same problem as in the first link, the only difference is the phone model.

I assume that if the bug in the second link is fixed, it will also work for the problem in the first link.
I think both issues, "I lose root privileges after updating" & "Magisk framework does no longer start up" describe the same problem, so my guess is that the fix will also be the same.
Does the "regression" tag mean that the problem will be fixed?
Means a change caused a reversion of working function(s).
Until recently, I had no plans to update Magisk. However, I need to successfully pass the SafetyNet filter. I have read that the latest version of Magisk allows to succeed with SafetyNet. It is possible that SafetyNet is the reason why other users want to upgrade Magisk after such a long time and have taken the time to report it on GitHub.

Do you think the problem will be fixed,
Yes.
maybe in the next release?
$64 000 question! 😁

Depends on colaborators time, priorities, schedule, access to diagnostic data, on John, holidays planned, covid19, the weather...

Best watch those spaces / contribute if you can! 🤠 PW
 
Last edited:
  • Like
Reactions: J.Michael and 535iu

pndwal

Senior Member
After patching the entire ap file from stock firmware, and then flashing it, my android boots up without the touchscreen working, this can only be avoided by flashing a patched boot.img even though magic app states that i don't have a ram disk, and when I flash a patched recovery it says vbmeta not verified
It's a Sammy? Magisk App says SAR Yes?

A checklist:
- Did you patch AP with Recovery mode selected?
- Did you do full data wipe w/ initial Magisk installation?
- Avoid MTP transfer?
- Flash the other files, not just AP?

Method:

Initial Magisk installation:
- Patch AP tar w/ Recovery mode selected.
- Copy the patched tar file to your PC with ADB (NOT MTP).
- Using Odin, flash magisk_patched.tar as AP, TOGETHER WITH BL, CP, and CSC (NOT HOME_CSC) to flash w/ data wipe.
- Allow Additional setup from Internet.

If updating ROM:
- pre-patch AP w/ Recovery mode selected.
- Copy the patched tar file to your PC with ADB (NOT MTP).
- Using Odin, flash magisk_patched.tar as AP, TOGETHER WITH BL + CP + HOME_CSC to upgrade / keep data.
- Allow any Additional setup from Internet.

... If you did do all that without success, please give details of phone / ROM, and Sammy users may chime in. 😛 PW
 
Last edited:
  • Like
Reactions: J.Michael

pndwal

Senior Member
No it's android 10 only and realme ui 1
Ah, I read this:
https://c.realme.com/in/post-details/1377151834564694016
and assumed again.

Problem with a.61 build is still very likely the same as issue on GitHub (both update privacy/security with latest changes, and both OTAs are incremental updates from RMX2027_11.A.59), so you may wish to comment in that issue thread.

Also, you may still have issues resulting from applying OTA without restoring images (Magisk Installed), but I'd say this is less likely. Boot image was clearly messed up by incremental OTA, but you've replaced that...

You may want to try flashing complete ROM (dirty flash) to check if it helps now that you have a.61 complete ROM package. PW
 
Last edited:
  • Like
Reactions: SaikiK

artyfarty

Senior Member
Nov 20, 2010
1,013
409
47
Brescia
www.fabiopluda.it
Hi, anyone in italy have problem with Credem home banking app? App found root (and close itself) even if magisk Is hidden root ti app and with anonymous package.

I have twrp too, on oneplus nord

Thanks
 

pndwal

Senior Member
  • Like
Reactions: J.Michael

SaikiK

Member
May 29, 2019
10
3
Full stock rom of a.61 is not available on the internet rn.
Also there is no twrp for realme c3 atm iirc. So I can't flash any zips.
 
  • Like
Reactions: J.Michael

ipdev

Recognized Contributor
Feb 14, 2016
2,546
1
5,159
Google Nexus 10
Nexus 7 (2013)
Full stock rom of a.61 is not available on the internet rn.
Also there is no twrp for realme c3 atm iirc. So I can't flash any zips.
Hi.
I am not familiar with Realme.

I did a quick check and see there is TWRP build over in the Realme C3 forums.
[RECOVERY][TWRP][RMX2020] TWRP 3.5.2 [UNOFFICIAL] - xdaThread - Link
Looks like it has only been out for a month and I am the only one who hit the like button so far. ;)

Quite a few custom rom threads but, I did not see a thread for Stock rom / firmware.
Realme C3 - xdaForum - Link

Hope this is the correct TWRP for your device.
Cheers. :cowboy:

Edit:
@SaikiK
I see, you device might have rollback protection.
To be safe, you might want to ask in the C3 TWRP thread before you try it.
 
Last edited:
  • Like
Reactions: J.Michael

Top Liked Posts

  • 1
    Can you show screenshot from the main Magisk app screen, to see what is displayed there (Installed, etc)

    Also, when you click to the dots (top-right) and enable Show System apps - does it list them
  • 5
    I'm now having a problem hiding the TJW Magisk 27002 app ...

    I finally was able to resurrect my old Pixel 5. It's running stock A11 and was running TJW Magisk 26004 with no problem.

    The Magisk manager was showing that the upgrade to 27002 was ready for installation, and so I did the following:

    (1) Unhide Magisk
    (2) Update Magisk (27002 was listed)
    (3) After Magisk manager restarted, I did Direct Update to 27002, including reboot
    (4) Magisk 27002 indeed came up properly after reboot.
    (5) Tried to perform Hide The Magisk App.

    I entered the arbitrary name for hiding, and I clicked "OK". But the hiding never took place.

    I rebooted again, to see if perhaps that's necessary, and I repeated the hiding attempt by adding the same arbitrary name, and I again clicked "OK". But the hiding still didn't take place.

    I searched my device, and there is no app nor shortcut with that arbitrary name. I also tried other, different arbitrary names, but after clicking "OK", the hiding still didn't take place for any name I chose.

    What am I missing?
    Known issue. A fix has been merged. You can use the Debug app, revert back to 27001 or wait until 27003 is released.

    EDIT: Ninja'd 🙃
    4
    Latest canary Update 27002 will not let me hide the Magisk app, get a failed toast, tried opening an issue but need to use the debug version,
    Installed the debug version and it works and hides the magisk app?
    4
    Not sure if the fix has been pushed yet but looking at GitHub it's been sorted
    Not pushed yet according to my magisk app.
    Luckily i don't hide or need to hide; this is a sad bug and i hope, for others' sake, it's pushed as soon as the developers can. But that's also why it's canary and not beta or release, it's why (or should be why) we use canary, to squash bugs before the rest experience them.
    4
    I have always have problems with magisk and bug reports think I have even failed with the debug version lol, although its closed I have added that the bug is not present with the debug version
    Just open another with "version code: 27002" somewhere in first post, explain you tested both but issue is with Canary only, not Debug... Supply logs from broken build and wait for further instructions from Devs... Template requires the version code (or bot closes) + logs (or Devs will often close with comment like "no log no fix")...👍 PW

    Edit: Someone opened proper issue following template just now:
    https://github.com/topjohnwu/Magisk/issues/7921

    Looks to me like this commit has issues:

    Always update stub APK when upgrade

    committed5 days ago
    4
    I'm now having a problem hiding the TJW Magisk 27002 app ...

    I finally was able to resurrect my old Pixel 5. It's running stock A11 and was running TJW Magisk 26004 with no problem.

    The Magisk manager was showing that the upgrade to 27002 was ready for installation, and so I did the following:

    (1) Unhide Magisk
    (2) Update Magisk (27002 was listed)
    (3) After Magisk manager restarted, I did Direct Update to 27002, including reboot
    (4) Magisk 27002 indeed came up properly after reboot.
    (5) Tried to perform Hide The Magisk App.

    I entered the arbitrary name for hiding, and I clicked "OK". But the hiding never took place.

    I rebooted again, to see if perhaps that's necessary, and I repeated the hiding attempt by adding the same arbitrary name, and I again clicked "OK". But the hiding still didn't take place.

    I searched my device, and there is no app nor shortcut with that arbitrary name. I also tried other, different arbitrary names, but after clicking "OK", the hiding still didn't take place for any name I chose.

    What am I missing?
    Known problem with 27002, the debug version doesn't have the problem with hiding, read back to see the discussion about it
  • 1103
    This is the place for general support and discussion regarding "Public Releases", which includes both stable and beta releases.
    All information, including troubleshoot guides and notes, are in the Announcement Thread
    156
    Hello, I haven't given much support on XDA lately. It can be resulted from
    • University started and I have limited free time. In fact, I mostly develop during midnight
    • I live in Taiwan, which has large time zone differences between my European/American contributors/testers, which usually forces me to stay up late at night to discuss/test stuffs.
    • The new version is about to come, I don't want to spend effort on supporting old releases
    The planned update is delayed again and again, to some point I think I'll shed some light about what has been happening lately, also along with some announcements.

    New Forum!
    As you might have already discovered, Magisk got its own subforum on XDA! Many thanks to all the support you gave me, and much more information/features/support is about to come!
    **For developers supporting all the devices that are not using standard Android boot format, feel free to create threads in this section (actually, PLEASE do so) for your favorite devices after v7 is out. As I currently know, Asus devices require signing the boot image before flashing, and is model dependant; Sony devices seems to use ELF kernel that is unpatchable, or some has two ramdisks (inner + outer), both requires different workarounds; LG bootloader locked devices has to manually "BUMP" the boot image after flashing Magisk..... and there may be lots of other crazy boot image formats that haven't come up to my attention yet.
    It is impossible for me to support all these non-standard boot images, and I hope the community can collaborate to make Magisk running across all the devices. Overall, community collaboration is what XDA about :D

    The Pixel Phone
    Some of you might already know this news, that the next Pixel Phone right around the corner seems like it does not have ramdisk in boot image, which pretty much wrecked Magisk in all ways. However, it pretty much doomed root itself too. Kernel modifications is inevitable IMO, so I'll try to migrate my scripts to C programs that could possibly be included into the kernel itself. Note that I'm not familiar with linux kernel, I'm not even sure if my idea and concept is correct or not. But once the device is available, I think developers will find a way to bypass all the difficulties, and I'll do my best to learn things ;)

    Current Progress
    In the past month, I've spent quite some time learning SELinux, so that I can avoid using SuperSU's sepolicy patches. Thanks to the helps and tips from @phhusson and @Chainfire, I finally have a much clearer understanding of how SELinux works. The Magisk core parts (the scripts, boot image patches, new features, more supports) are actually done some time ago. What is causing all the delays is the Magisk Manager.
    To be completely honest, although I can code in Java without much issues, Magisk Manager is actually my first Android application, I had to reach out for assistance, and fortunately awesome developers like @DVDandroid and @digitalhigh contributed a lot, which makes the current Manager awesome.
    After the repo system and module management is mostly done, I was about to do some adjustments and release, but what we really done is decided to add another feature: auto-unroot with per-app settings. I decided to wait for it to be finished, and then do my adjustments. Due to reasons that'll be mentioned later, this feature will likely not be available for the next release (should come in future updates)

    Safety Net Disaster
    Those who are using Magisk for Safety Net bypass purposes must have known that Google recently updated the detection method of my Systemless Xposed. I still have no idea what Safety Net is detecting, so currently I cannot fix it on my side (also because I'm busy working on the next update). However, suhide developed by @Chainfire is able to hide Xposed and worked fine.
    However, only my Systemless Xposed v86.2, which is based on SuperSU's su.d, is supported using that method. v86.2 and v86.5 (latest, Magisk based) have nearly identical binaries, and the only difference is the path where the binaries are stored.
    I'm still not sure what's the real issue for it not being supported, I just hope it is not done intentionally.

    Conclusion
    Due to the fact that my Safety Net bypass is not 100% perfect now, I do not want to spend any more time waiting for auto-unroot to be polished. What I'm doing now is finishing up all the things I'd like to change in Magisk Manager (it has been a while since I last contributed to Manager, my fellow developers are doing all the heavy job), which might take a little more time, after that, packed with tons of information to be announced in Magisk Section, I'll release the long awaited update.

    Hope this lengthy post gives you the idea of the whole situation, and again thanks for all your support!!
    121
    Ah, some Chainfire bashing, I hope it is not too late for me to exercise additional villainy.

    First, let me make clear I have nothing against @topjohnwu, nor against Magisk. Magisk is an interesting project and it certainly displays @topjohnwu ingenuity and persistence. I don't doubt we will see more interesting things from his hands.

    -------------------------

    What has happened here is not all that dark and complicated, from either end. I returned from holidays, and someone pointed me at Magisk. My first thought: interesting!

    Among other things, the thread lists some issues with SuperSU, which in combination with the phrase The developer also requests users to not bug Chainfire with compatibility requests for SuperSU with Magisk from the portal article, raised my left eyebrow by nigh half an inch. The popular systemless xposed mod is apparently now based on it, and apparently it now no longer works with SuperSU, and apparently I'm not supposed to fix that, nor any of the other found issues. I found that a bit weird. So yes, I have told @topjohnwu that I was a bit surprised he was posting about issues with SuperSU without notifying me about them (I can't fix or help fix issues I'm not aware of, after all).

    He's also spreading a modified version of the SuperSU package, which is not all that uncommon, nor necessarily a problem. I have not looked into what he modified, I only ran a few quick tests on one of my devices, and found some commonly used commands run as root to be broken. I have informed him of this as well.

    It appears the tool of choice for Magisk is phh's Superuser, because of some of the mentioned issues with SuperSU. That's fine by itself, but fixing issues in that superuser by incorporating SuperSU's binaries into it is a somewhat questionable practise. After all, SuperSU is a commercial closed-source package that helps pay for my dinner, and superuser is a direct competitor. I have informed him that I was surprised he did this without asking for permission. I have expressed similar surprise on him spreading a modified version of LiveBoot (which helps pay for a snack now and then).
    @topjohnwu has also stated that Magisk's scripts are largely influenced by mine (I have not checked). Scripts based on mine are used all over the place on XDA, some people have crafted amazing things based on them, I have never made an issue of this (otherwise I would have just made them binaries). But yes, I have also stated to him that I don't think it's very nice to base something on one program, and then using that to (almost exclusively) push something directly competing with that program.

    tl;dr Towards @topjohnwu, I have:
    - expressed surprise he has issues getting Magisk to work with SuperSU, and has chosen not to inform me about those
    - expressed surprise he is using SuperSU binaries in a competing superuser without permission
    - expressed surprise he is posting a modified LiveBoot without permission
    - informed him of issues with the modified SuperSU he has posted
    - let him know I thought it wasn't very nice to be applying my scripts to benefit seemingly exclusively that same competing superuser

    To be crystal clear:
    - I have not asked for an apology
    - I have not asked for Magisk to be abandoned, neither the root hiding nor systemless module parts, and certainly not systemless xposed
    - I have not made an issue of any of this anywhere, until this post
    - I have not even specifically asked for anything to be taken down (though obviously in my opinion the other superuser package mixed with SuperSU's binaries, as well as the LiveBoot package, should go)
    - I have not reported this thread to XDA moderators for copyright violations or otherwise

    While my conversation with @topjohnwu may not win any awards for being friendly (though it may win some for brevity), I think all things considered my response has been rather mild. To be perfectly honest, until the apology post, I thought this was over with already. I think the apology post was triggered because I haven't replied to his last PM for a while - I was in the zone, it happens.

    To emphasize again, I have nothing against @topjohnwu, Magisk, or systemless xposed, and it is certainly not my goal to see any of them go. If it can be made to work together with SuperSU, great.

    I get it though: you think of something, you want to see if you can make it work, you finally get it to work, you publish it, it takes off - enthusiasm gets the better of you. Maybe in the rush some mistakes are made. That doesn't mean you have to just drop it and run. None of my stuff would make it past 0.1 if I stopped at the first big mistake :)

    Aside from said being in the zone coding, I usually regret actually responding to these sort of things the day after, which has made me hesitant to reply. Surprise me.
    76
    Thread temporarily closed so everyone sees this.

    The flood of "SafetyNet isn't working for me either!" posts are not helpful, at all. Please refrain from posting further, it will be looked into. Please do not forget that not passing SafetyNet is 100% NORMAL AND INTENDED when you have an unlocked booloader or running custom firmware. These are workarounds and they will be worked around in turn.

    The Flash
    Forum Moderator

    EDIT: Thread is reopened... I will be cleaning any SafetyNet posts for a while to keep the thread clean for real issues.
    75
    Hello everyone!

    I am aware that Google has updated Safety Net that makes Magisk itself a no go for Android Pay. In fact, I witnessed the change live while I am developing the new magiskhide, which should hide all Magisk modules and Magisk installed root.

    Google is serious about Safety Net now, clearly hunting down all possibility to run Xposed with Safety Net passed. I spend quite some time examining the new security measures last midnight, and fortunately it seems that it is possible to run Magisk and root along with Safety Net if no Xposed is running. I'm glad I removed the old root toggle at the right time lol, that is no longer feasible with the latest detection.

    So stay tuned for the next update, it will come with bug fixes, along with the new magiskhide to bypass that Safety Net.

    Google, how will a few systemless mods do any harm :p:p