Magisk General Support / Discussion

[zymphad]

Where is the canary build?

 

[martyfender]

Where is the canary build?

https://github.com/topjohnwu/magisk-files/tree/canary

 

[mermaidkiller]

I use Termux. Sometimes I need a root shell, so I granted root permanently to Termux, so I can use 'sudo bash' in Termux. But, as there is no password prompt, this is actually a security flaw. So I wanted to revoke root access and grant root access only on demand, when I really need it.

Revocation succeeded, but I can only grant root access permanently and not temporarily. The latter only happens when I grant root access to an app for the very first time.

 

[J.Michael]

I use Termux. Sometimes I need a root shell, so I granted root permanently to Termux, so I can use 'sudo bash' in Termux. But, as there is no password prompt, this is actually a security flaw. So I wanted to revoke root access and grant root access only on demand, when I really need it.

Revocation succeeded, but I can only grant root access permanently and not temporarily. The latter only happens when I grant root access to an app for the very first time.

Where does your "sudo" command come from?

I use Jack Palevich's Terminal Emulator. When I installed Magisk, I got an "su", but no "sudo". I defined an alias sudo='su -c' that works most of the time.

I told you all this so I could tell you: when I use "su", there's a pop-up asking me to grant permission. I always OK 10 minutes. I don't remember choosing my Superuser manager.

 

[Didgeridoohan]

I use Termux. Sometimes I need a root shell, so I granted root permanently to Termux, so I can use 'sudo bash' in Termux. But, as there is no password prompt, this is actually a security flaw. So I wanted to revoke root access and grant root access only on demand, when I really need it.

Revocation succeeded, but I can only grant root access permanently and not temporarily. The latter only happens when I grant root access to an app for the very first time.

Can't reproduce. If I revoke superuser access for Termux and then run su I can pick "forever", "once" or one of the set time periods.

 

[Didgeridoohan]

Where is the canary build?

The latest Canary apk is always linked in the main Magisk GitHub repo:
https://github.com/topjohnwu/Magisk

 

[pndwal]

Full stock rom of a.61 is not available on the internet rn.

Did you look?

Scroll down, or search realme C3 in page:
https://www.realme.com/in/support/software-update

Version: RMX2020_11.A.61
Release time: 26/04/2021
Size: 3.05GB
md5: DF9EA46D8595715626C4271D9B60CFA8

Also, typing C3 in search box here gives ROMs by region (for Realme C3 and Realme C3i):
https://realmeupdater.com/downloads/latest/ PW

 

[mermaidkiller]

Can't reproduce. If I revoke superuser access for Termux and then run su I can pick "forever", "once" or one of the set time periods.

Now it worked:
Rather than turning off the switch on the right (which I did), I click long on 'Termux and click on 'Revoke' (on the right). Then it asks me for confirmation.
When I subsequently do a 'su' from Termux, the grant access prompt indeed appears.
So now it works.

 

[DiamondJohn]

I use Termux. Sometimes I need a root shell, so I granted root permanently to Termux, so I can use 'sudo bash' in Termux. But, as there is no password prompt, this is actually a security flaw. So I wanted to revoke root access and grant root access only on demand, when I really need it.

Revocation succeeded, but I can only grant root access permanently and not temporarily. The latter only happens when I grant root access to an app for the very first time.

Where does your "sudo" command come from?

I use Jack Palevich's Terminal Emulator. When I installed Magisk, I got an "su", but no "sudo". I defined an alias sudo='su -c' that works most of the time.

I told you all this so I could tell you: when I use "su", there's a pop-up asking me to grant permission. I always OK 10 minutes. I don't remember choosing my Superuser manager.

Just a guess as I never use Termux. I to use a standard android shell. And sudo is not supported. Its su in an android shell.

As for asking for a password, thats how linux works NOT android. This is android. If anything whatever termux is, thats what would need to wrap a password request. But again, this is android NOT linux.

 

[73sydney]

@pndwal

I haz made my first Magisk related issue, lets see how quickly it gets closed

Born out of testing 4 ROMS this week is this "issue" was driving me nuts

https://github.com/topjohnwu/Magisk/issues/4333

Its not entirely out of bone idle laziness, but having to switch back after each module install was starting to get on my nerves

I dont hover around github enough to know if its been mentioned before

 

[pndwal]

@pndwal

I haz made my first Magisk related issue, lets see how quickly it gets closed

Born out of testing 4 ROMS this week is this "issue" was driving me nuts

https://github.com/topjohnwu/Magisk/issues/4333

Its not entirely out of bone idle laziness, but having to switch back after each module install was starting to get on my nerves

I dont hover around github enough to know if its been mentioned before

Was about to say I think It'll be considered, but see it's more than that already.

Re. idle laziness, I agree with John that Open Source is great!

John Wu, ?

I love the fact that despite being lazy, haven't worked on Magisk for almost a week, quite a few people start creating PRs to fix some regressions, burning down a lot of issues

Gotta say,
Open source sure is quite a nice thing! Maybe I should be lazy more often in the future /jk

Could be no coincidence that Chris is on it though; what's with you compulsive testers / gluttons for punishment? PW

https://twitter.com/i/web/status/1245139248447131649

https://qablog.practitest.com/should-all-testers-have-ocd/ PW

 

[ipdev]

<SNIP>
Could be no coincidence that Chris is on it though; what's with you compulsive testers / gluttons for punishment? PW

https://twitter.com/i/web/status/1245139248447131649

https://qablog.practitest.com/should-all-testers-have-ocd/ PW

It is just good testing.
Does it work.

• No - Try to fix it.
• Yes - Find a way to break it.

The next step is figuring out why it doesn't work on one device when it works on the rest.
This is the difficult step.

Cheers.

 

[pndwal]

It is just good testing.
Does it work.

• No - Try to fix it.
• Yes - Find a way to break it.

The next step is figuring out why it doesn't work on one device when it works on the rest.
This is the difficult step.

Cheers.

Quite.

I had my tongue firmly in my cheek when I said that, but fully appreciate testing efforts / methods / benefits to all of us, yours included!

FWIW, I don't think it's bone idleness or lazy to work for an easier testing setup either. After all, John happily accepted @vvb2060's Auto close issues bot.

... But then, he IS lazy... Said so himself!

Incidentally, I hope I speak for most of us here in saying that we do this largely to entertain ourselves (for fun). Of course, offering help to one another and educating ourselves is the main aim, but I hope we can have a bit of fun in these forums from time to time without being taken too seriously...

I make this comment after just having had a post w/ link to Monty Python's original 'I don't like Spam' sketch (along with others that inspired Python programming code) removed from 'Spam Users' thread. This, to me, is a real irony. PW

 

[ipdev]

Ignore this post.

 

[pndwal]

I don't like SPAM!

I still haven't figured out why some of the Python's bad sketches became so popular.

​

But you HAVE figured it out. It's precisely BECAUSE they're so bad!... And nerds / geeks do still have a sense of humour (of sorts ), at least when they take a break.

But what would I know? I have a real job n just do this for kicks... Better ask likes of Guido van Rossum...

My response in that thread has survived till now, and was appreciated by one XDA mod with a sense of humour / history. (He liked the original sketch links in less than 30 secs, and commented they are 'finally, some worthwhile spam', but his posts were expunged also). Something there may give a clue:
https://xdaforums.com/t/spam-users.306366/post-84980987

EDIT: Too late: Other mod removed it.
Thread:
https://xdaforums.com/t/spam-users.306366/

My post was a bit too dry.

Sometimes I just need to remember to look on the bright side of life.

ALWAYS!

PS.
Sorry all for the OT.

Re. OT: As the man with the wooden leg said, it's a matter of a pinion.

Eg. ONLY Download official Magisk from JOHN Wu's official GitHub! There are some 3300 other Magisk forks on GitHub alone. Some of these are DIRTY!

Surely, the need to beware of a Dirty Fork is very much ON Topic! ... Here's a subtle reminder:

PW

 

[pndwal]

Latest Debug (Canary)
Changelog and Release Notes:

Magisk (6b34ec3a) (22105)​

• [MagiskHide] Some changes that prevents zygote deadlock
• [General] Update BusyBox to use proper libc
• [App] Fix issues when patching ODIN tar files when the app is hidden

Diffs to v22.1​

• [App] Update snet extension. This fixes SafetyNet API errors.
• [App] Fix a bug in the stub app that causes APK installation to fail
• [App] Hide annoying errors in logs when hidden as stub
• [App] Fix issues when patching ODIN tar files when the app is hidden
• [General] Remove all pre Android 5.0 support
• [General] Update BusyBox to use proper libc
• [MagiskPolicy] Remove unnecessary sepolicy rules
• [General] Fix a C++ bug that causes undefined behavior
• [MagiskHide] Update package and process name validation logic
• [MagiskHide] Some changes that prevents zygote deadlock

https://github.com/topjohnwu/magisk-files/tree/9d8ae9c501f3975a9a548a5d2dff440d9ce9b8a2

Don't you just love Mondays!

Flashed fine on RN8T, SafetyNet, modules fine incl. Viper!

Nb. Fix for image patching on Samsung devices.

Thanks to John and colaborators! PW

 

[73sydney]

Was about to say I think It'll be considered, but see it's more than that already.

Re. idle laziness, I agree with John that Open Source is great!

Could be no coincidence that Chris is on it though; what's with you compulsive testers / gluttons for punishment? PW

https://twitter.com/i/web/status/1245139248447131649

https://qablog.practitest.com/should-all-testers-have-ocd/ PW

Awww, i expected some sort of witty comeback after which id have to remind you that i "know where you get your coffee in the morning"

But no....

So disappointed

And yes, it was nice to have my issue greenlit by @osm0sis, its amazing what you can get through the gatekeepers ...all it takes apparently is a cogent argument or report....who knew?

 

[JustinChase]

I think I remember seeing something a while back that Magisk manager merged with the App, but I still have both when I open Magisk. This is fine, but whenever I update the App, the Manager immediately shows an update to the same version, so I think maybe they are both not necessary any more.

Also, whenever Magisk tells me (via notification) there is an update, when I click download, it does, but the resultant file gives an error when I click on it, so I have to update from within the App itself.

Is there anything I should do at this point to consolidate, or is this just how it works now.

thanks for the help/guidance

 

[J.Michael]

I think I remember seeing something a while back that Magisk manager merged with the App, but I still have both when I open Magisk. This is fine, but whenever I update the App, the Manager immediately shows an update to the same version, so I think maybe they are both not necessary any more.

Also, whenever Magisk tells me (via notification) there is an update, when I click download, it does, but the resultant file gives an error when I click on it, so I have to update from within the App itself.

Is there anything I should do at this point to consolidate, or is this just how it works now.

thanks for the help/guidance

I am having trouble understanding what you are reporting.

There used to be an .apk file used to install Magisk Manager on a device. It was just an Android app. There was also a .zip that could be flashed using TWRP to inject Magisk into various parts (partitions) of your system. And a .zip that could be flashed using TWRP to undo the changes to the partitions.

The "merger" was of these files: Now you download a magisk.apk. Use it in Android, and it installs the Magisk Manager app. Rename it to .zip and you can use it in TWRP to install Magisk. Further rename it to "uninstall.zip" and you can use it in TWRP to uninstall Magisk (the real guts of Magisk, not the Magisk Manager app -- that's just an Android app, you uninstall it like any other app).

When you run the Magisk Manager app and it talks about the Manager, it's talking about itself.

Go through your Android Apps drawer and make sure that you do not have more than one Magisk by any name.

Someone else will have to help with the "update Magisk" problem.

 

[pndwal]

I think I remember seeing something a while back that Magisk manager merged with the App, but I still have both when I open Magisk. This is fine, but whenever I update the App, the Manager immediately shows an update to the same version, so I think maybe they are both not necessary any more.

Still 2 components, no longer released separately but both still needed and both require updating.

New single package delivery explained by John in Release Notes:
https://topjohnwu.github.io/Magisk/...agisk-manager-is-deadlong-live-the-magisk-app

Also, whenever Magisk tells me (via notification) there is an update, when I click download, it does, but the resultant file gives an error when I click on it, so I have to update from within the App itself.

Is there anything I should do at this point to consolidate, or is this just how it works now.

thanks for the help/guidance

If working from within App, seems all is as it should be with Magisk. May be a general issue with package installer (settings / other) on device. What is the error? PW