Magisk General Support / Discussion

Search This thread

elhennig

Senior Member
Feb 21, 2011
958
232
Samsung Galaxy A52 4G
Fairphone 4
2021.5.12 Magisk v23.0
This release is focused on fixing regressions and bugs.

Note: Magisk v22 is the last major version to support Jellybean and Kitkat. Magisk v23 only supports Android 5.0 and higher.
When I try to install v23 apk i get only one method to chose the file to be patch and I have no idea how to proceed there. Having renamed apk to zip and ran the installation from the TWRP recovery the app claims the Magisk is not installed. What can I do?
 

pndwal

Senior Member
Installation Instruction update:
John Wu, 41m

I just spent some time rewording parts of the installation instructions. Hopefully this makes it less confusing to newcomers!
https://topjohnwu.github.io/Magisk/install.html

I really want to make things simpler, but as anything that involves Android, it is of course an absolute mess due to fragmentation, so unfortunately the instructions are super verbose 😶
www.twitter.com/topjohnwu/status/1392409550024679426

(Commit, for comparison:
https://github.com/topjohnwu/Magisk/commit/4f73534837bda59fd58ca010fe25d3d66556883e )

Have a look. New look / quite a few clarifications. 👍 PW
 
Last edited:

pndwal

Senior Member
When I try to install v23 apk i get only one method to chose the file to be patch and I have no idea how to proceed there. Having renamed apk to zip and ran the installation from the TWRP recovery the app claims the Magisk is not installed. What can I do?
Please say device (model), what Magisk version, if any, you had working before installing v.23.0, etc. PW
 
  • Like
Reactions: J.Michael

pndwal

Senior Member
Had some issues w the last update:

Oneplus 6T, Elemental Kernel, XXX_NO_LIMITS ROM

After I updated I passed safety net for the 1st time in ages, but my sim cards were not registering.

Uninstalled all my modules, rebooted, phone worked.

No longer passed safety net.

Added my modules back 1 by 1 and rebooted, phone still works.

After I added XXX back I got a weird reboot about a minute in. Couple of odd restarts from OS14 Launcher, but everything is working.

Still don't pass safety net though. Magisk hide is turned on. Magisk Hide props config is installed. Tried all the different configs for the 6t via Termux terminal, none got me to pass safety net.

Really odd that when my phone wasn't working I passed but now I don't....again.

Not a HUGE deal as I have no google account on my phone, but would be nice to have it working.

Thoughts?
For SafetyNet pass, you generally need Universal SafetyNet Fix even with basic attestation reported, due to Google changes.

Nothing else needed for most stock ROMs, but if Chinese uncertified stock, or custom ROMs w/o certified fingerprint spoofing, you'll need MagiskHide Props Config, and a certified fingerprint set up. If using certified stock ROM, best to remove MHPC.

Re. SIM issues:

Try disabling all modules except USNF (and MHPC if needed) and rebooting.

Nb. Mods like OOS Native Call Recording module have been reported to cause symptoms like yours in OnePlus devices, and may no longer be compatable with Android 11 for example.

Nb.2. Some OnePlus users have had issues with USNF module also, especially after Android 11 upgrade. However, surprising success is reported with a test module from the same Dev, eg:
https://github.com/kdrag0n/safetynet-fix/pull/13#issuecomment-792931429

The test SafetyNet Fix module the user above reported fixed his OnePlus Nord w/ A11 ("works flawlessly"), is linked in the same pull request thread. It tests "Shim the keystore service instead of replacing it", and is designed to test the following scenarios and issues:
- 32-bit ARM devices
- Heavy OEM skins
- Samsung One UI
- MIUI
- Broken biometric authentication in apps
- Unstable system (i.e. rebooting and/or crashing)

Download link:
https://github.com/kdrag0n/safetynet-fix/pull/13#issuecomment-767863635

This may well help you especially if running Android 11. PW
 
Last edited:

wtosta

Senior Member
My device is Samsung S9 with the latest Magisk 23.0 installed. I also applied the safetynet-fix-v1.1.1.zip and turned on the MagiskHide option in Magisk settings. SafetyNet passes with the basic integrity check and also I am able to register the payment cards in Google Pay. But when I try to turn on the NFC module to start using contactless payments the Google Pay app says that it can't set up the NFC. I had the same problem with the previous versions of Magisk Canary just before the official version 23.0 was released. Have any of you encountered such a problem before?

Best regards
Witek
 

pndwal

Senior Member
My device is Samsung S9 with the latest Magisk 23.0 installed. I also applied the safetynet-fix-v1.1.1.zip and turned on the MagiskHide option in Magisk settings. SafetyNet passes with the basic integrity check
Do you mean basicIntegrity is checked (ticked), or that SafetyNet Check uses Basic attestation evalType? (Two very different things). Also, can we assume ctsProfile pass as well?
and also I am able to register the payment cards in Google Pay. But when I try to turn on the NFC module to start using contactless payments the Google Pay app says that it can't set up the NFC.
Do you get an error message here? Eg un-secure / modified environment, or root / jailbreak detected?
I had the same problem with the previous versions of Magisk Canary just before the official version 23.0 was released. Have any of you encountered such a problem before?
Likely solution:
Post in thread 'Magisk General Support / Discussion' https://xdaforums.com/t/magisk-general-support-discussion.3432382/post-84790337 PW
 
Last edited:

Alexkidd85

Senior Member
Jun 29, 2010
105
5
Catania
Google Pixel 4 XL
Hi guys

problem: pixel4xl updated to the latest patch and flashed last boot patched.

apps that require root work (probably only the old ones with permissions already granted), magisk passes the safatynet BUT...


on "installed" gives me n / a
obviously I can't hide anything

and, I did not know that now android, seeing the root, also canceled the unlock with my face (or at least I think that is why, it would make sense)

anyone have any ideas?

if I have to format everything, i'm not ready for android 12 yet !! :D :D
 

wtosta

Senior Member
Do you mean basicIntegrity is checked (ticked), or that SafetyNet Check uses Basic attestation evalType? (Two very different things). Also, can we assume ctsProfile pass as well?
After applying safetynet fix (before applying the fix evalType was Hardware and the SafetyNet check didn't pass).
Currently:
SafetyNet check: Succeeded
basicIntegrity: ticked
ctsProfile: ticked
evalType BASIC

Forgive me being imprecise.

Do you get an error message here? Eg un-secure / modified environment, or root / jailbreak detected?
No, it doesn't occur.

Likely solution:
Post in thread 'Magisk General Support / Discussion' https://xdaforums.com/t/magisk-general-support-discussion.3432382/post-84790337 PW
I am trying to test what is written in the solution, but with no avail :-(
 
Last edited:

zgfg

Senior Member
Oct 10, 2016
10,768
9,399
Redmi K20 / Xiaomi Mi 9T
Xiaomi Mi 11
Hi guys

problem: pixel4xl updated to the latest patch and flashed last boot patched.

apps that require root work (probably only the old ones with permissions already granted), magisk passes the safatynet BUT...


on "installed" gives me n / a
obviously I can't hide anything

and, I did not know that now android, seeing the root, also canceled the unlock with my face (or at least I think that is why, it would make sense)

anyone have any ideas?

if I have to format everything, i'm not ready for android 12 yet !! :D :D
Hint (every second day somebody asks the same and it usually helps) - search through the Settings, Apps and uninstall your previous/old Magisk Manager, or old mngr/apk if you did hide it.
If needed, uninstall also the new Magisk app (not the Magisk itself) and install the apk again.
You can basically find the same in Magisk Wiki, available on Github, link from Magisk main window - IMO, users should take time and read to be familiar where to find the answers when something goes wrong)
 

Didgeridoohan

Retired Senior Moderator
May 31, 2012
12,300
1
14,850
Gone
Google Nexus 4
Nexus 6
@pndwal

Is "snet extension" the "SafetyNet Fix" module?

I thought the release note was saying that Magisk now did what was needed to pass SafetyNet. I assumed that meant that the separate module was no longer needed.

No. That has nothing to do with the SafetyNet fix to circumvent hardware backed key attestation. That's just the update to the Magisk app SafetyNet check so that it uses a new API key (since the old one got revoked).
 

zgfg

Senior Member
Oct 10, 2016
10,768
9,399
Redmi K20 / Xiaomi Mi 9T
Xiaomi Mi 11
@pndwal

Is "snet extension" the "SafetyNet Fix" module?

I thought the release note was saying that Magisk now did what was needed to pass SafetyNet. I assumed that meant that the separate module was no longer needed.
That is the same fix (new/valid SN API key) that has previously been applied to Magisk Canary apk - hence to avoid the API error.
Because of that API error the real SN test was not executed and Basic Integrity / CTS profile 'failures' had no meanings

Hence, there is no more need to switch to Canary or to use third party SN checkers - but it doesn't help to pass SN if there are real problems with Basic Integrity or CTS profile
 
  • Like
Reactions: J.Michael

absinth4

Member
Nov 25, 2014
48
4
Edinburgh
Sorry if I am postin on the wrong thread about this, wasnt sure where to do it :( . I have noticed that one of my banking apps (Bank of Scotland) is recognizing that my phone is rooted and wont let me log in. I have tried all the ways to bypass that, like magisk hide , hide props config, hiddin the magisk app itself, rebooting, reinstalling the banking app, but seriously nothing at all seems to work. with other banking apps that ppl had similar issues like Revolut, something from the above seemed to work but not for this. Am i missing any other workarounds for my issue guys? i would be really greatful !
 

whitewallman

Senior Member
May 1, 2010
265
94
Google Pixel 7 Pro
This is probably a stupid question, but what does that last number in parentheses in the version number indicate? In my case, (21)
Screenshot_20210512-120440.png
 
Last edited:
  • Like
Reactions: J.Michael

wafna

Member
Jan 13, 2012
20
6
updated to the latest Android (11) on a Note 10+, using Odin, patched AP file etc. Usual standard method. Got Magisk to start only once. Can boot into recovery while plugging in a USB-C earphone cable.

Magisk itself (framework) only loaded once, all other times Magisk Manager says Magisk is not installed. No clue. Used to be that Magisk needed a Volume Down press together with Power On and then release.

Now if I try that, nothing happens (except the double warning that my phone has been modified). Can boot into recovery by using a Volume Up + Power Key + something plugged in.

Does anyone have any advice? will reflash and probably downgrade back to Android 10 but maybe someone has an idea. Thanks.
 

pndwal

Senior Member
Thanks for the response, and pardon my ignorance... But I don't believe I repackaged the app. I installed the APK that I downloaded from the magisk GitHub link. Is it something I inadvertently did?
Then you didn't Install stub... But that's the included version that will be used if you click 'Hide the Magisk app' in App settings. PW
 

Top Liked Posts

  • 1
    UPDATE: I got it to work by extracting and flashing the stock boot.img and recovery.img via odin. I guess that's a dirty fix and IDK why this worked and flashing the whole stock rom didn't
    If you flashed a stock ROM, you effectively uninstalled Magisk, except for the /data/adb directory.
    Ii'll check that folder (if I can install TWRP or something) in order to clean up, but my goal now is to reroot it.
    Did the flashing of the stock ROM involve doing a "factory reset / wipe data"?
    No, but, I did one factory reset from Android's configuration menu in order to clean up, set up the phone and debloat it (I bought it used). It worked afterwards but I screwed up when debloating so then I did the stock rom flash.
    If you have a problem after trying to reinstall Magisk, the things to check are:
    • did you patch and flash the right file?
    • did you change the version of Magisk?
    • did you change the version of Android?
    I'll keep that in mind when I try to reroot.
    Thanks for your response!
    1
    UPDATE: I got it to work by extracting and flashing the stock boot.img and recovery.img via odin. I guess that's a dirty fix and IDK why this worked and flashing the whole stock rom didn't
    Keep in mind that official instructions still state:

    Important Notes​

    • Never, ever try to restore either boot, init_boot, recovery, or vbmeta partitions back to stock! You can brick your device by doing so, and the only way to recover from this is to do a full Odin restore with data wipe.
    • To upgrade your device with a new firmware, NEVER directly use the stock AP tar file with reasons mentioned above. Always patch AP in the Magisk app and use that instead.
    although I know many Sammy users have been able to recover from this mistake without wiping data... Seems you've put your finger on the working method for your device... Not sure if trick would work for any Samsung device however, but may be useful for others...

    Take care with upgrades in future! 😉

    Ii'll check that folder (if I can install TWRP or something) in order to clean up, but my goal now is to reroot it.
    If goal is to reroot, you can leave configuration as-is... Only modules that become incompatible with later Android versions may cause bootloop, but normally the previous Magisk configuration files are OK... If you want to force a configuration rebuild (restore clean Magisk, no modules, superuser list, DenyList etc) after installation, just delete everything in /data/adb after rooted with a root explorer and reboot; configuration files will then be rebuilt.

    🤠 PW
    1
    UPDATE: I got it to work by extracting and flashing the stock boot.img and recovery.img via odin. I guess that's a dirty fix and IDK why this worked and flashing the whole stock rom didn't

    Ii'll check that folder (if I can install TWRP or something) in order to clean up, but my goal now is to reroot it.

    No, but, I did one factory reset from Android's configuration menu in order to clean up, set up the phone and debloat it (I bought it used). It worked afterwards but I screwed up when debloating so then I did the stock rom flash.

    I'll keep that in mind when I try to reroot.
    Thanks for your response!
    I think you are confused. (I know I am.)

    You said you flashed the stock ROM. Then you said you patched and flashed, which implies that the device was running after flashing the stock ROM. So you never mentioned trying to recover from the bootloop by flashing the entire stock ROM. I believe it would have worked, you just didn't do it.

    The thing that needed to be fixed was the bootloop after patching and flashing. I listed the first few things that came to mind that would explain why you got a bootloop. Those are the things that you need to be careful of the next time you try to install Magisk.

    If you have never had Magisk installed, you can ignore everything that refers to a previous installation of Magisk. Your bootloop was probably a matter of patching and flashing the boot from a different version of the ROM. Or maybe it was patching the boot image when you need to patch the recovery image.

    When installing Magisk on a Samsung device, you should "patch" the entire AP.tar file. Magisk will patch three images within the tar file (assuming either the Recovery option is selected by default, or you specifically select it). Then you hand the patched AP.tar to Odin and everything in it gets "flashed". After you've gotten it working, if you're a glutton for punishment you can see if you can patch and flash less than the full AP.tar, but I think you still have to give a tar file to Odin.
  • 5
    I'm now having a problem hiding the TJW Magisk 27002 app ...

    I finally was able to resurrect my old Pixel 5. It's running stock A11 and was running TJW Magisk 26004 with no problem.

    The Magisk manager was showing that the upgrade to 27002 was ready for installation, and so I did the following:

    (1) Unhide Magisk
    (2) Update Magisk (27002 was listed)
    (3) After Magisk manager restarted, I did Direct Update to 27002, including reboot
    (4) Magisk 27002 indeed came up properly after reboot.
    (5) Tried to perform Hide The Magisk App.

    I entered the arbitrary name for hiding, and I clicked "OK". But the hiding never took place.

    I rebooted again, to see if perhaps that's necessary, and I repeated the hiding attempt by adding the same arbitrary name, and I again clicked "OK". But the hiding still didn't take place.

    I searched my device, and there is no app nor shortcut with that arbitrary name. I also tried other, different arbitrary names, but after clicking "OK", the hiding still didn't take place for any name I chose.

    What am I missing?
    Known issue. A fix has been merged. You can use the Debug app, revert back to 27001 or wait until 27003 is released.

    EDIT: Ninja'd 🙃
    4
    Is the Magisk 27001 APK/zip still available anywhere? I'd like to downgrade, but I can only find 27000 on Github and 27002 via update. I don't want to go to Canary in case the mounting changes break anything, or Debug as I hear the extra logging etc. causes performance issues (correct me if I'm wrong).
    Only v27000 is Stable. (and Beta). v27001 and v27002 are Canary or Debug

    Set your Update Channel to Stable and you will see (just like you can see also on GitHub) that latest Stable is v27000, there was never Stable v27001 or v27002

    Generally, Stable is always Nx100

    So, you cannot downgrade to Stable v27001 but Canary v27001 should be just like Stable v27000 (same codebase). That's also the general policy, whenever Nx100 Stable is released, then immediately comes Canary Nx100 +1, on the same code-base

    Therefore, downgrade to Stable v27000 instead
    4
    Direct Install with recovery mode checked worked for me. You were right.

    After I flashed wrong CSC firmware my baseband and EMEIs disappeared. Now I have updated bootloader and I cant to flash original CSC firmware anymore. Any ideas how to restore baseband, EMEIs or it is too late?
    Yep, I told you several times that you need Recovery mode (selected) for your Ramdisk=No device; instructions for this are also clear in official Installation Instruction page too, but apparently you have not been trying to follow official instructions, so it's no real surprise you've messed up firmware too... Please take *extra* care when modding as there are simply so many variables and pitfalls! 😬

    Are you flashing patched AP (Application Processor binary) along with all the other package binaries (X4?) for your S10+ (also in Magisk Installation page, Samsung section)??

    CP is Cellular Processor (Nb. Oft repeated references to CP as 'core processor' may be misleading) binary package (also referred to as Baseband Modem) so that should have fixed mismatched baseband etc... correct CSC (Consumer Software Customization; region, APN and carrier specific software packages/settings) and even BL (Bootloader) are most likely also important...

    Nb. BL doesn't always update bootloader version, but if later firmware has been flashed be aware that these can also cause anti-roll back version for bootloader to be incremented (in the event that an update patches serious vulns) so you original firmware may be blocked and you may need to use later packages only...

    If flashing latest complete firmware package via Odin doesn't fix your IMEI / baseband issues it may be that you've messed with partitions that contain unique device values in the past... You may need to ask in Galaxy, S10 or S10+ XDA forums for that. 🤠 PW
    4
    I'm now having a problem hiding the TJW Magisk 27002 app ...

    I finally was able to resurrect my old Pixel 5. It's running stock A11 and was running TJW Magisk 26004 with no problem.

    The Magisk manager was showing that the upgrade to 27002 was ready for installation, and so I did the following:

    (1) Unhide Magisk
    (2) Update Magisk (27002 was listed)
    (3) After Magisk manager restarted, I did Direct Update to 27002, including reboot
    (4) Magisk 27002 indeed came up properly after reboot.
    (5) Tried to perform Hide The Magisk App.

    I entered the arbitrary name for hiding, and I clicked "OK". But the hiding never took place.

    I rebooted again, to see if perhaps that's necessary, and I repeated the hiding attempt by adding the same arbitrary name, and I again clicked "OK". But the hiding still didn't take place.

    I searched my device, and there is no app nor shortcut with that arbitrary name. I also tried other, different arbitrary names, but after clicking "OK", the hiding still didn't take place for any name I chose.

    What am I missing?
    Known problem with 27002, the debug version doesn't have the problem with hiding, read back to see the discussion about it
    3
    Thanks for your reply.
    So I stay for the moment at Magisk 26.4 für my Xiaomi 14 Ultra. Because there is xiaomi.eu ROM for my phone available since 2 hours, I will flash this tomorrow und with the Module from Xiaomi.eu Team I do not need Playintegrity anymore.

    So do I understand correct, to hide root I should use Shamiko? Latest Shamiko can be found here https://github.com/LSPosed/LSPosed.github.io/releases correct?
    Since Xiaomi eu is a custom ROM, their devs made the injector, 'module' that tricks DroidGuard and injects the spoofs with no need for Magisk/root and Zygisk

    And as that, you achieve Device Integrity without the Magisk.
    But if you install Magisk, you have to hide Magisk and Zygisk by your own

    So yes, you can use Shamiko and it should work (I used that kind of setup at the beginning of this year, for like two weeks, with no problems)

    But then ask yourselves - what for do you need Magisk. If using like Viper4Android, useful LSPosed modules - then, yes

    If not, better uninstall Magisk and you will only have Xiaomi.eu injector. Btw, yes, it is rather injector than a module, it's full name is XiaomiEUInject

    Regarding the prints - there are now no more publicly available working prints, hence a vast majority of rooted users use the prints 'stolen' from the Xiaomi.eu injector. When Google bans them, both sides will be equally affected. And assuming that Xiaomi.eu team quickly publishes their new version of injector, (last time it was in a matter of hours) with the new prints, all those rooted users will jump again to their new prints from tha new injector (new version of PIF was published less than an hour upon the Xiaomi.eu injecto was updated)

    But if Google makes a slaughter like last time (now there are about 20 times less working prints than previously) and if Xiaomi.eu team does not come up (quickly) with the new injector (and the new working prints), than better don't think what could happen.
    Btw, Wallet can run about half a day on the cached previous Play Integrity pass

    Hence, with the Xiaomi.eu injector or with PI Fix (with its built-in prints), PI Fork with the corresponding autopif script, etc, you are equally exposed to the Google's mercy

    Therefore, if you really need Magisk, you can also keep using the PI Fix/For with the disabled Xiaomi.eu injector. It will be easier for your maintenance than to struggle with both worlds in parallel (although, that can work as well)
  • 1103
    This is the place for general support and discussion regarding "Public Releases", which includes both stable and beta releases.
    All information, including troubleshoot guides and notes, are in the Announcement Thread
    156
    Hello, I haven't given much support on XDA lately. It can be resulted from
    • University started and I have limited free time. In fact, I mostly develop during midnight
    • I live in Taiwan, which has large time zone differences between my European/American contributors/testers, which usually forces me to stay up late at night to discuss/test stuffs.
    • The new version is about to come, I don't want to spend effort on supporting old releases
    The planned update is delayed again and again, to some point I think I'll shed some light about what has been happening lately, also along with some announcements.

    New Forum!
    As you might have already discovered, Magisk got its own subforum on XDA! Many thanks to all the support you gave me, and much more information/features/support is about to come!
    **For developers supporting all the devices that are not using standard Android boot format, feel free to create threads in this section (actually, PLEASE do so) for your favorite devices after v7 is out. As I currently know, Asus devices require signing the boot image before flashing, and is model dependant; Sony devices seems to use ELF kernel that is unpatchable, or some has two ramdisks (inner + outer), both requires different workarounds; LG bootloader locked devices has to manually "BUMP" the boot image after flashing Magisk..... and there may be lots of other crazy boot image formats that haven't come up to my attention yet.
    It is impossible for me to support all these non-standard boot images, and I hope the community can collaborate to make Magisk running across all the devices. Overall, community collaboration is what XDA about :D

    The Pixel Phone
    Some of you might already know this news, that the next Pixel Phone right around the corner seems like it does not have ramdisk in boot image, which pretty much wrecked Magisk in all ways. However, it pretty much doomed root itself too. Kernel modifications is inevitable IMO, so I'll try to migrate my scripts to C programs that could possibly be included into the kernel itself. Note that I'm not familiar with linux kernel, I'm not even sure if my idea and concept is correct or not. But once the device is available, I think developers will find a way to bypass all the difficulties, and I'll do my best to learn things ;)

    Current Progress
    In the past month, I've spent quite some time learning SELinux, so that I can avoid using SuperSU's sepolicy patches. Thanks to the helps and tips from @phhusson and @Chainfire, I finally have a much clearer understanding of how SELinux works. The Magisk core parts (the scripts, boot image patches, new features, more supports) are actually done some time ago. What is causing all the delays is the Magisk Manager.
    To be completely honest, although I can code in Java without much issues, Magisk Manager is actually my first Android application, I had to reach out for assistance, and fortunately awesome developers like @DVDandroid and @digitalhigh contributed a lot, which makes the current Manager awesome.
    After the repo system and module management is mostly done, I was about to do some adjustments and release, but what we really done is decided to add another feature: auto-unroot with per-app settings. I decided to wait for it to be finished, and then do my adjustments. Due to reasons that'll be mentioned later, this feature will likely not be available for the next release (should come in future updates)

    Safety Net Disaster
    Those who are using Magisk for Safety Net bypass purposes must have known that Google recently updated the detection method of my Systemless Xposed. I still have no idea what Safety Net is detecting, so currently I cannot fix it on my side (also because I'm busy working on the next update). However, suhide developed by @Chainfire is able to hide Xposed and worked fine.
    However, only my Systemless Xposed v86.2, which is based on SuperSU's su.d, is supported using that method. v86.2 and v86.5 (latest, Magisk based) have nearly identical binaries, and the only difference is the path where the binaries are stored.
    I'm still not sure what's the real issue for it not being supported, I just hope it is not done intentionally.

    Conclusion
    Due to the fact that my Safety Net bypass is not 100% perfect now, I do not want to spend any more time waiting for auto-unroot to be polished. What I'm doing now is finishing up all the things I'd like to change in Magisk Manager (it has been a while since I last contributed to Manager, my fellow developers are doing all the heavy job), which might take a little more time, after that, packed with tons of information to be announced in Magisk Section, I'll release the long awaited update.

    Hope this lengthy post gives you the idea of the whole situation, and again thanks for all your support!!
    121
    Ah, some Chainfire bashing, I hope it is not too late for me to exercise additional villainy.

    First, let me make clear I have nothing against @topjohnwu, nor against Magisk. Magisk is an interesting project and it certainly displays @topjohnwu ingenuity and persistence. I don't doubt we will see more interesting things from his hands.

    -------------------------

    What has happened here is not all that dark and complicated, from either end. I returned from holidays, and someone pointed me at Magisk. My first thought: interesting!

    Among other things, the thread lists some issues with SuperSU, which in combination with the phrase The developer also requests users to not bug Chainfire with compatibility requests for SuperSU with Magisk from the portal article, raised my left eyebrow by nigh half an inch. The popular systemless xposed mod is apparently now based on it, and apparently it now no longer works with SuperSU, and apparently I'm not supposed to fix that, nor any of the other found issues. I found that a bit weird. So yes, I have told @topjohnwu that I was a bit surprised he was posting about issues with SuperSU without notifying me about them (I can't fix or help fix issues I'm not aware of, after all).

    He's also spreading a modified version of the SuperSU package, which is not all that uncommon, nor necessarily a problem. I have not looked into what he modified, I only ran a few quick tests on one of my devices, and found some commonly used commands run as root to be broken. I have informed him of this as well.

    It appears the tool of choice for Magisk is phh's Superuser, because of some of the mentioned issues with SuperSU. That's fine by itself, but fixing issues in that superuser by incorporating SuperSU's binaries into it is a somewhat questionable practise. After all, SuperSU is a commercial closed-source package that helps pay for my dinner, and superuser is a direct competitor. I have informed him that I was surprised he did this without asking for permission. I have expressed similar surprise on him spreading a modified version of LiveBoot (which helps pay for a snack now and then).
    @topjohnwu has also stated that Magisk's scripts are largely influenced by mine (I have not checked). Scripts based on mine are used all over the place on XDA, some people have crafted amazing things based on them, I have never made an issue of this (otherwise I would have just made them binaries). But yes, I have also stated to him that I don't think it's very nice to base something on one program, and then using that to (almost exclusively) push something directly competing with that program.

    tl;dr Towards @topjohnwu, I have:
    - expressed surprise he has issues getting Magisk to work with SuperSU, and has chosen not to inform me about those
    - expressed surprise he is using SuperSU binaries in a competing superuser without permission
    - expressed surprise he is posting a modified LiveBoot without permission
    - informed him of issues with the modified SuperSU he has posted
    - let him know I thought it wasn't very nice to be applying my scripts to benefit seemingly exclusively that same competing superuser

    To be crystal clear:
    - I have not asked for an apology
    - I have not asked for Magisk to be abandoned, neither the root hiding nor systemless module parts, and certainly not systemless xposed
    - I have not made an issue of any of this anywhere, until this post
    - I have not even specifically asked for anything to be taken down (though obviously in my opinion the other superuser package mixed with SuperSU's binaries, as well as the LiveBoot package, should go)
    - I have not reported this thread to XDA moderators for copyright violations or otherwise

    While my conversation with @topjohnwu may not win any awards for being friendly (though it may win some for brevity), I think all things considered my response has been rather mild. To be perfectly honest, until the apology post, I thought this was over with already. I think the apology post was triggered because I haven't replied to his last PM for a while - I was in the zone, it happens.

    To emphasize again, I have nothing against @topjohnwu, Magisk, or systemless xposed, and it is certainly not my goal to see any of them go. If it can be made to work together with SuperSU, great.

    I get it though: you think of something, you want to see if you can make it work, you finally get it to work, you publish it, it takes off - enthusiasm gets the better of you. Maybe in the rush some mistakes are made. That doesn't mean you have to just drop it and run. None of my stuff would make it past 0.1 if I stopped at the first big mistake :)

    Aside from said being in the zone coding, I usually regret actually responding to these sort of things the day after, which has made me hesitant to reply. Surprise me.
    76
    Thread temporarily closed so everyone sees this.

    The flood of "SafetyNet isn't working for me either!" posts are not helpful, at all. Please refrain from posting further, it will be looked into. Please do not forget that not passing SafetyNet is 100% NORMAL AND INTENDED when you have an unlocked booloader or running custom firmware. These are workarounds and they will be worked around in turn.

    The Flash
    Forum Moderator

    EDIT: Thread is reopened... I will be cleaning any SafetyNet posts for a while to keep the thread clean for real issues.
    75
    Hello everyone!

    I am aware that Google has updated Safety Net that makes Magisk itself a no go for Android Pay. In fact, I witnessed the change live while I am developing the new magiskhide, which should hide all Magisk modules and Magisk installed root.

    Google is serious about Safety Net now, clearly hunting down all possibility to run Xposed with Safety Net passed. I spend quite some time examining the new security measures last midnight, and fortunately it seems that it is possible to run Magisk and root along with Safety Net if no Xposed is running. I'm glad I removed the old root toggle at the right time lol, that is no longer feasible with the latest detection.

    So stay tuned for the next update, it will come with bug fixes, along with the new magiskhide to bypass that Safety Net.

    Google, how will a few systemless mods do any harm :p:p