Magisk General Support / Discussion

Search This thread

ipdev

Recognized Contributor
Feb 14, 2016
2,546
1
5,159
Google Nexus 10
Nexus 7 (2013)
Hi all. :)

A bit OT but..

Since there are a few mentioning SuperSU recently.

SuperSU was only a root solution. Nothing about it was hiding.
Chainfire did create a separate app suhide (later suhide-lite) for hiding the su binary.​

So by removing hide from Magisk, it will actually be more similar to SuperSU.
Save for the awesome overlay implementation that allows the easy use of Modules.
+1,000 points to Magisk. ;)

Chainfire sold SuperSU to CCMT in good faith that they would continue the work..
As far as I know, CCMT only released one update on their own.
It was broken so Chainfire stepped in (took two days for him to fix) and a new release was pushed to PlayStore.
I forgot they put their apology in the SuperSU OP.​

After that, CCMT and support for SuperSU started to disappear.​

Magisk is still fully suported.

Quick highlight of Magisk's growth and development..
  • Magisk was originally just a Magic Mask.
    The systemless overlay that allowed us to modify systemlessly.
    Since it requires root, you had to install a root solution.
    SuperSU or superuser
  • Magisk includes a root solution.
    This starts off basic and grows into what is now the magisk su binary.​
  • Magisk can now hide itself.
    This grows into what is/was MagiskHide.​
  • The next step of growth and development. :unsure:
    Every step along the way has lead to an improvement.
    As someone who used Magisk with SuperSU.
    I am a bit anxious but, more excited to find out. :D

Note:
This was a quick highlight.
I skiped A LOT.
For a while, the official MagiskManager app was installed from PlayStore.
I do not remember.. Did we pay for it?

Cheers all. :cowboy:
 

pndwal

Senior Member
I didn't see any real changes in the denylist additions so I didn't think much of them. It's prep for commits to come.
Yup, WIP, but denylist may simply be a re-badged hidelist and may still be leveraged by hiding solution modules while working out of the box within userspace.
I'm all for giving it a chance but I think it more likely that third parties like kdragon will provide safteynet solution rather then denylist.
Just meant USNF could be that solution. It's a WIP and so far has adapted with TJW changes / commits. It's certainly the most versatile / resilient / comprehensive hiding solution currently available with proper GitHub repos for other devs to contribute too.

I have no reason to believe that the dynamic nature of USNF will change in the near future, so can't see why we'll need some new 'MagiskHide' module while @kdrag0n is adapting to the changes.

He's apparently indicated his intention to utilise upcoming Zygisk (replacing Riru) as soon as is practical which will likely allow more robust hiding methods to be added also (thanks to TJW changes 😜).
I'm not in the "Magisk is dead" camp. It's laughable that such a group even exists.

Magiskhide was designed with the goal of hiding the presence of Magisk and the functionality it provides. The denylist sounds like a way for apps to operate as if Magisk isn't there but not to keep the apps from detecting it's presence.
Exactly, but hidelist did have the effect of hiding Magisk's presence and there are not yet any commits or real reasons to believe denylist won't do the same; just no longer a 'hiding' feature per se.
Total speculation on my part other than deductive reasoning that TJW creating another incarnation of magiskhide would undermines his job is responsiblilties.
With MagiskHide's requisite additional spoofing / subterfuge gone, the emphasis is simply (properly) being placed on denying ability to make privileged modifications rather to hide Magisk from probes... so far. 😛

Of course I don't know for sure that denylist won't change further, but that would be in the realms of speculation also... Time will tell.
I hope chainfire got paid well for his application. He talked a lot about not being able to pursue other projects because of SuperSU and now that it was off his plate he would be able to but to my knowledge, and I could be wrong, I haven't seen him do much of anything.
It was a good time (for him and for others) to let young blood in!

He still maintains some interesting projects.

Liveboot (with Magisk support!) is cool:
https://www.xda-developers.com/chainfire-liveboot-cf-lumen-android-11-support/

😜 PW
 
Last edited:

AndDiSa

Senior Member
Dec 2, 2009
3,705
5,078
Heidelberg
HTC Desire
Nexus 7
I just installed riru and safetynet-fix-2.1.0 on my Pixel 3a, cleared play store data ... but unfortunately safetynet is still failing (cts profile failure) with eval-type "hardware"! I was expecting "basic" as eval-type here ...
Did I miss something?
Edit: my fault - module was installed, but not enabled :-(
 
Last edited:
  • Like
Reactions: jons99

pleasetouchmenot

Senior Member
Nov 12, 2015
543
161
Redmi Note 8 Pro
Goodbye Magiskhide, Hello Enforce DenyList
 

Attachments

  • Screenshot_2021-09-15-22-30-54-016_com.topjohnwu.magisk.jpg
    Screenshot_2021-09-15-22-30-54-016_com.topjohnwu.magisk.jpg
    284.3 KB · Views: 224
  • Screenshot_2021-09-15-22-31-04-805_com.topjohnwu.magisk.jpg
    Screenshot_2021-09-15-22-31-04-805_com.topjohnwu.magisk.jpg
    123.1 KB · Views: 221
  • Screenshot_2021-09-15-22-30-46-152_com.topjohnwu.magisk.jpg
    Screenshot_2021-09-15-22-30-46-152_com.topjohnwu.magisk.jpg
    254 KB · Views: 221

Click Beetle DX

New member
Jul 23, 2018
4
1
If it's available still it'll be in /data and if you have a recent Magisk version it should be in a folder named magisk_backup_<checksum>.

It wasn't. :cry:

Fortunately, after spending a long time searching through various firmware archives, I was lucky enough to find the exact same version of the firmware installed on my phone. Did a "dirty flash" of it, aaaaand... voilà, my phone is up and running again, with all my data intact. Phew!
 
  • Like
Reactions: ipdev

pndwal

Senior Member

alpha update log​

Magisk (b6298f86-alpha)​

  • [General] Based on b6298f86, the content that has been merged upstream is no longer listed
  • [App] Correctly process any data from magiskd
  • [App] Support SharedUserId
  • [App] Delete the backup file after restoring the boot image
  • [App] Built-in current version update log
  • [App] Use the local version when the stub cannot be downloaded, now it can be used completely offline
  • [busybox] Fix the default shell path
  • [App] Allow the log page to be opened when Magisk is not installed. Although there is no content, clicking the save button will save the app log
  • [App] Switch to the modern time API of Java 8
  • [Core] Handling suspicious props
  • [App] Update the SafetyNet extension, update the version of snet.jar to 18
https://github.com/vvb2060/Magisk/b...b8deb1ce5f4/app/src/main/res/raw/changelog.md

👍 PW
 
Last edited:

pndwal

Senior Member
1. Toggle on the enforce denyList
2. Click on Configure denyList
3. Choose "Google Play Service" and checklist on "com.android.gms" and "com.android.gms.unstable"

Should do the trick for safetynet. Hope it helps out with the Hysteria of magiskhide is no more.
Nb. For devices where Magisk resides in /sbin (many pre. Android 11), only com.google.android.gms.unstable in Google Play Services is needed in hidelist / denylist. PW
 

tronderbataljon

Senior Member
Jun 15, 2011
54
3
Oksvoll
1. Toggle on the enforce denyList
2. Click on Configure denyList
3. Choose "Google Play Service" and checklist on "com.android.gms" and "com.android.gms.unstable"

Should do the trick for safetynet. Hope it helps out with the Hysteria of magiskhide is no more.
What am I doing wrong?
Device, Xiaomi Mi 10t
Rom, Evox A11
Modules, RiRu v26. 1.2 + USNF v2. 1.1
 

Attachments

  • Screenshot_20210915-223513_Magisk.png
    Screenshot_20210915-223513_Magisk.png
    68.9 KB · Views: 181
  • Screenshot_20210915-223507_Magisk.png
    Screenshot_20210915-223507_Magisk.png
    148.9 KB · Views: 181
  • Screenshot_20210915-223458_Magisk.png
    Screenshot_20210915-223458_Magisk.png
    150.8 KB · Views: 181
Last edited:

pndwal

Senior Member
@pndwal I think we basically said the same things, just in different ways lol.
I think we're on the same page too.

It was only really this notion that I saw differently:
bobbarker2 said:
... from a practical POV, Magiskhide was/is a required component of rooting and Magisk. Without Magiskhide, a device with Magisk will no longer be able to run a plethora of apps and it will not be Google Play Store Certified.
because rather than suggesting 'devices would lose ability to run apps / not be certified' due to Magisk and root being unable to be hidden, John himself said:
... it is important to me that Magisk is able to “get out of the way”, so a minor subset of the MagiskHide infrastructure will remain. Users will be able to assign a denylist of processes where Magisk denies further modifications and reverts all changes it had done.
and he said it from the getgo.

So far things are shaping up this way. Such devices will still be perfectly (maybe more perfectly) able to run those same apps and be 'certified' w/ new denylist.

I / others have been at pains to dispell the negative idea that traditional MagiskHide functionality has been killed off. This is in part because John himself has as good as said it hasn't, will be trivial to restore, and that he's '10000% sure' some 'hiding module' will also 'pop up as soon as possible'.

It's looking more and more as if denylist is and will likely remain pretty much a change in name only while old MagiskHide overt subterfuge and spoofing functions for working SafetyNet have been offloaded (to be easily restored by 3rd party modules). 😀
OnePlus owners can thank @osm0sis for PR #90. Safetynet fix is v2.1.1 now.
Yeah! 😛 👍
John Wu

The beauty of open source!
PW
 
Last edited:
  • Like
Reactions: duttyend

zgfg

Senior Member
Oct 10, 2016
10,766
9,398
Redmi K20 / Xiaomi Mi 9T
Xiaomi Mi 11
I finally updated my Xiaomi Mi 9T, running Xiaomi.eu_Stable, A11 (MIUI 12.1) to the latest Alpha b6298f86.
Thanks @pndwal for encouraging me

With this ROM and with the old Magisk v23 (incl. the previous Alpha versions) I didn't need any modules, spoofing or so - it was simply passing SafetyNet with MagiskHide enabled (and my SN was not affected by the recent Google move on Sep 2 or so)

Now, cat has changed the color (Deng) but it still catches the mice - with DenyList enforced and the usual two GMS processes enlisted, it happily passes the SN again
 

Attachments

  • Magisk Alpha.jpg
    Magisk Alpha.jpg
    328.6 KB · Views: 99
  • DenyList.jpg
    DenyList.jpg
    324.1 KB · Views: 144
  • Google Play Services.jpg
    Google Play Services.jpg
    308.2 KB · Views: 137
  • SafetyNet .jpg
    SafetyNet .jpg
    182.4 KB · Views: 137
  • Device Certified.jpg
    Device Certified.jpg
    252 KB · Views: 89
  • PlayProtect.jpg
    PlayProtect.jpg
    295.6 KB · Views: 96
Last edited:

73sydney

Account currently disabled
Even i got in on the act and updated to latest Alpha, decided not to be lazy. Enable System Apps, a few ticks for Google Play Services, a list of Samsung gear...my bank.

Look Marvin, I can haz Magisk Deny and SafetyNet:)

safetynet.jpg


Now reinstalling modules...

Updated:

Failed to kill anything, even after a full Magisk uninstall and a data/adb/ wipe...all my wearables and Samsung Pay, and bank and Google Pay still work..happy days
 
Last edited:
  • Like
Reactions: rodken

zgfg

Senior Member
Oct 10, 2016
10,766
9,398
Redmi K20 / Xiaomi Mi 9T
Xiaomi Mi 11
Even i got in on the act and updated to latest Alpha, decided not to be lazy. Enable System Apps, a few ticks for that, a list of Samsung gear...my bank.

Look Marvin, I can haz Magisk Deny and SafetyNet:)

View attachment 5411513

Now reinstalling modules...
Btw, I've slso played with. There is one MIUI app that was not possible to enable for MagiskHide in Magisk v23 official - it was not showing in GUI.
It was only possible through the Terminal, by using magiskhide command line

Ofc, magiskhide applet is no more available (and there is no command-line applet for DenyList), but by enabling OS apps in Filter I was able to see and check-in that Security center app for DenyList

And I tested with MagiskDetector, having the same results as with previous Alpha versions (no better or worse)
And yeah, it says that "Maisk Hide works properly" 🤩
 

Attachments

  • Filter.jpg
    Filter.jpg
    303.2 KB · Views: 80
  • MagiskDetector.jpg
    MagiskDetector.jpg
    421.1 KB · Views: 82
Last edited:
  • Like
Reactions: ipdev and 73sydney

jons99

Senior Member
Nov 5, 2019
355
391
Even i got in on the act and updated to latest Alpha, decided not to be lazy. Enable System Apps, a few ticks for Google Play Services, a list of Samsung gear...my bank.

Look Marvin, I can haz Magisk Deny and SafetyNet:)

View attachment 5411513

Now reinstalling modules...

Updated:

Failed to kill anything, even after a full Magisk uninstall and a data/adb/ wipe...all my wearables and Samsung Pay, and bank and Google Pay still work..happy days
there's already a newer one
in the new one you need to enable zygisk and reboot to pass safetynet
 

Attachments

  • photo_2021-09-16_22-26-20.jpg
    photo_2021-09-16_22-26-20.jpg
    26.8 KB · Views: 83
  • photo_2021-09-16_22-26-26.jpg
    photo_2021-09-16_22-26-26.jpg
    29.9 KB · Views: 81

73sydney

Account currently disabled
there's already a newer one
in the new one you need to enable zygisk and reboot to pass safetynet

Why of course theres a new one, its been 15 minutes :)

Interestingly, on the changelog, the latest alpha has not got the alpha suffix....im going to leave all that muck to Marvin, the resident release tease to post :)

Btw, I've slso played with. There is one MIUI app that was not possible to enable for MagiskHide in Magisk v23 official - it was not showing in GUI.
It was only possible through the Terminal, by using magiskhide command line

Ofc, magiskhide applet is no more availbe (and there is no command-line applet for DenyList), but by enabling OS apps I was able to see that Security center apo for DenyList

And I tested with MagiskDetector, having the same results as with previous Alpha versions (no better or worse)
And yeah, it says that "Maisk Hide works properly" 🤩

Yup, Magisk Detector same same here
 
  • Like
Reactions: jons99

Top Liked Posts

  • 1
    UPDATE: I got it to work by extracting and flashing the stock boot.img and recovery.img via odin. I guess that's a dirty fix and IDK why this worked and flashing the whole stock rom didn't
    If you flashed a stock ROM, you effectively uninstalled Magisk, except for the /data/adb directory.
    Ii'll check that folder (if I can install TWRP or something) in order to clean up, but my goal now is to reroot it.
    Did the flashing of the stock ROM involve doing a "factory reset / wipe data"?
    No, but, I did one factory reset from Android's configuration menu in order to clean up, set up the phone and debloat it (I bought it used). It worked afterwards but I screwed up when debloating so then I did the stock rom flash.
    If you have a problem after trying to reinstall Magisk, the things to check are:
    • did you patch and flash the right file?
    • did you change the version of Magisk?
    • did you change the version of Android?
    I'll keep that in mind when I try to reroot.
    Thanks for your response!
    1
    UPDATE: I got it to work by extracting and flashing the stock boot.img and recovery.img via odin. I guess that's a dirty fix and IDK why this worked and flashing the whole stock rom didn't
    Keep in mind that official instructions still state:

    Important Notes​

    • Never, ever try to restore either boot, init_boot, recovery, or vbmeta partitions back to stock! You can brick your device by doing so, and the only way to recover from this is to do a full Odin restore with data wipe.
    • To upgrade your device with a new firmware, NEVER directly use the stock AP tar file with reasons mentioned above. Always patch AP in the Magisk app and use that instead.
    although I know many Sammy users have been able to recover from this mistake without wiping data... Seems you've put your finger on the working method for your device... Not sure if trick would work for any Samsung device however, but may be useful for others...

    Take care with upgrades in future! 😉

    Ii'll check that folder (if I can install TWRP or something) in order to clean up, but my goal now is to reroot it.
    If goal is to reroot, you can leave configuration as-is... Only modules that become incompatible with later Android versions may cause bootloop, but normally the previous Magisk configuration files are OK... If you want to force a configuration rebuild (restore clean Magisk, no modules, superuser list, DenyList etc) after installation, just delete everything in /data/adb after rooted with a root explorer and reboot; configuration files will then be rebuilt.

    🤠 PW
  • 5
    I'm now having a problem hiding the TJW Magisk 27002 app ...

    I finally was able to resurrect my old Pixel 5. It's running stock A11 and was running TJW Magisk 26004 with no problem.

    The Magisk manager was showing that the upgrade to 27002 was ready for installation, and so I did the following:

    (1) Unhide Magisk
    (2) Update Magisk (27002 was listed)
    (3) After Magisk manager restarted, I did Direct Update to 27002, including reboot
    (4) Magisk 27002 indeed came up properly after reboot.
    (5) Tried to perform Hide The Magisk App.

    I entered the arbitrary name for hiding, and I clicked "OK". But the hiding never took place.

    I rebooted again, to see if perhaps that's necessary, and I repeated the hiding attempt by adding the same arbitrary name, and I again clicked "OK". But the hiding still didn't take place.

    I searched my device, and there is no app nor shortcut with that arbitrary name. I also tried other, different arbitrary names, but after clicking "OK", the hiding still didn't take place for any name I chose.

    What am I missing?
    Known issue. A fix has been merged. You can use the Debug app, revert back to 27001 or wait until 27003 is released.

    EDIT: Ninja'd 🙃
    4
    Is the Magisk 27001 APK/zip still available anywhere? I'd like to downgrade, but I can only find 27000 on Github and 27002 via update. I don't want to go to Canary in case the mounting changes break anything, or Debug as I hear the extra logging etc. causes performance issues (correct me if I'm wrong).
    Only v27000 is Stable. (and Beta). v27001 and v27002 are Canary or Debug

    Set your Update Channel to Stable and you will see (just like you can see also on GitHub) that latest Stable is v27000, there was never Stable v27001 or v27002

    Generally, Stable is always Nx100

    So, you cannot downgrade to Stable v27001 but Canary v27001 should be just like Stable v27000 (same codebase). That's also the general policy, whenever Nx100 Stable is released, then immediately comes Canary Nx100 +1, on the same code-base

    Therefore, downgrade to Stable v27000 instead
    4
    Direct Install with recovery mode checked worked for me. You were right.

    After I flashed wrong CSC firmware my baseband and EMEIs disappeared. Now I have updated bootloader and I cant to flash original CSC firmware anymore. Any ideas how to restore baseband, EMEIs or it is too late?
    Yep, I told you several times that you need Recovery mode (selected) for your Ramdisk=No device; instructions for this are also clear in official Installation Instruction page too, but apparently you have not been trying to follow official instructions, so it's no real surprise you've messed up firmware too... Please take *extra* care when modding as there are simply so many variables and pitfalls! 😬

    Are you flashing patched AP (Application Processor binary) along with all the other package binaries (X4?) for your S10+ (also in Magisk Installation page, Samsung section)??

    CP is Cellular Processor (Nb. Oft repeated references to CP as 'core processor' may be misleading) binary package (also referred to as Baseband Modem) so that should have fixed mismatched baseband etc... correct CSC (Consumer Software Customization; region, APN and carrier specific software packages/settings) and even BL (Bootloader) are most likely also important...

    Nb. BL doesn't always update bootloader version, but if later firmware has been flashed be aware that these can also cause anti-roll back version for bootloader to be incremented (in the event that an update patches serious vulns) so you original firmware may be blocked and you may need to use later packages only...

    If flashing latest complete firmware package via Odin doesn't fix your IMEI / baseband issues it may be that you've messed with partitions that contain unique device values in the past... You may need to ask in Galaxy, S10 or S10+ XDA forums for that. 🤠 PW
    4
    I'm now having a problem hiding the TJW Magisk 27002 app ...

    I finally was able to resurrect my old Pixel 5. It's running stock A11 and was running TJW Magisk 26004 with no problem.

    The Magisk manager was showing that the upgrade to 27002 was ready for installation, and so I did the following:

    (1) Unhide Magisk
    (2) Update Magisk (27002 was listed)
    (3) After Magisk manager restarted, I did Direct Update to 27002, including reboot
    (4) Magisk 27002 indeed came up properly after reboot.
    (5) Tried to perform Hide The Magisk App.

    I entered the arbitrary name for hiding, and I clicked "OK". But the hiding never took place.

    I rebooted again, to see if perhaps that's necessary, and I repeated the hiding attempt by adding the same arbitrary name, and I again clicked "OK". But the hiding still didn't take place.

    I searched my device, and there is no app nor shortcut with that arbitrary name. I also tried other, different arbitrary names, but after clicking "OK", the hiding still didn't take place for any name I chose.

    What am I missing?
    Known problem with 27002, the debug version doesn't have the problem with hiding, read back to see the discussion about it
    3
    Thanks for your reply.
    So I stay for the moment at Magisk 26.4 für my Xiaomi 14 Ultra. Because there is xiaomi.eu ROM for my phone available since 2 hours, I will flash this tomorrow und with the Module from Xiaomi.eu Team I do not need Playintegrity anymore.

    So do I understand correct, to hide root I should use Shamiko? Latest Shamiko can be found here https://github.com/LSPosed/LSPosed.github.io/releases correct?
    Since Xiaomi eu is a custom ROM, their devs made the injector, 'module' that tricks DroidGuard and injects the spoofs with no need for Magisk/root and Zygisk

    And as that, you achieve Device Integrity without the Magisk.
    But if you install Magisk, you have to hide Magisk and Zygisk by your own

    So yes, you can use Shamiko and it should work (I used that kind of setup at the beginning of this year, for like two weeks, with no problems)

    But then ask yourselves - what for do you need Magisk. If using like Viper4Android, useful LSPosed modules - then, yes

    If not, better uninstall Magisk and you will only have Xiaomi.eu injector. Btw, yes, it is rather injector than a module, it's full name is XiaomiEUInject

    Regarding the prints - there are now no more publicly available working prints, hence a vast majority of rooted users use the prints 'stolen' from the Xiaomi.eu injector. When Google bans them, both sides will be equally affected. And assuming that Xiaomi.eu team quickly publishes their new version of injector, (last time it was in a matter of hours) with the new prints, all those rooted users will jump again to their new prints from tha new injector (new version of PIF was published less than an hour upon the Xiaomi.eu injecto was updated)

    But if Google makes a slaughter like last time (now there are about 20 times less working prints than previously) and if Xiaomi.eu team does not come up (quickly) with the new injector (and the new working prints), than better don't think what could happen.
    Btw, Wallet can run about half a day on the cached previous Play Integrity pass

    Hence, with the Xiaomi.eu injector or with PI Fix (with its built-in prints), PI Fork with the corresponding autopif script, etc, you are equally exposed to the Google's mercy

    Therefore, if you really need Magisk, you can also keep using the PI Fix/For with the disabled Xiaomi.eu injector. It will be easier for your maintenance than to struggle with both worlds in parallel (although, that can work as well)
  • 1103
    This is the place for general support and discussion regarding "Public Releases", which includes both stable and beta releases.
    All information, including troubleshoot guides and notes, are in the Announcement Thread
    156
    Hello, I haven't given much support on XDA lately. It can be resulted from
    • University started and I have limited free time. In fact, I mostly develop during midnight
    • I live in Taiwan, which has large time zone differences between my European/American contributors/testers, which usually forces me to stay up late at night to discuss/test stuffs.
    • The new version is about to come, I don't want to spend effort on supporting old releases
    The planned update is delayed again and again, to some point I think I'll shed some light about what has been happening lately, also along with some announcements.

    New Forum!
    As you might have already discovered, Magisk got its own subforum on XDA! Many thanks to all the support you gave me, and much more information/features/support is about to come!
    **For developers supporting all the devices that are not using standard Android boot format, feel free to create threads in this section (actually, PLEASE do so) for your favorite devices after v7 is out. As I currently know, Asus devices require signing the boot image before flashing, and is model dependant; Sony devices seems to use ELF kernel that is unpatchable, or some has two ramdisks (inner + outer), both requires different workarounds; LG bootloader locked devices has to manually "BUMP" the boot image after flashing Magisk..... and there may be lots of other crazy boot image formats that haven't come up to my attention yet.
    It is impossible for me to support all these non-standard boot images, and I hope the community can collaborate to make Magisk running across all the devices. Overall, community collaboration is what XDA about :D

    The Pixel Phone
    Some of you might already know this news, that the next Pixel Phone right around the corner seems like it does not have ramdisk in boot image, which pretty much wrecked Magisk in all ways. However, it pretty much doomed root itself too. Kernel modifications is inevitable IMO, so I'll try to migrate my scripts to C programs that could possibly be included into the kernel itself. Note that I'm not familiar with linux kernel, I'm not even sure if my idea and concept is correct or not. But once the device is available, I think developers will find a way to bypass all the difficulties, and I'll do my best to learn things ;)

    Current Progress
    In the past month, I've spent quite some time learning SELinux, so that I can avoid using SuperSU's sepolicy patches. Thanks to the helps and tips from @phhusson and @Chainfire, I finally have a much clearer understanding of how SELinux works. The Magisk core parts (the scripts, boot image patches, new features, more supports) are actually done some time ago. What is causing all the delays is the Magisk Manager.
    To be completely honest, although I can code in Java without much issues, Magisk Manager is actually my first Android application, I had to reach out for assistance, and fortunately awesome developers like @DVDandroid and @digitalhigh contributed a lot, which makes the current Manager awesome.
    After the repo system and module management is mostly done, I was about to do some adjustments and release, but what we really done is decided to add another feature: auto-unroot with per-app settings. I decided to wait for it to be finished, and then do my adjustments. Due to reasons that'll be mentioned later, this feature will likely not be available for the next release (should come in future updates)

    Safety Net Disaster
    Those who are using Magisk for Safety Net bypass purposes must have known that Google recently updated the detection method of my Systemless Xposed. I still have no idea what Safety Net is detecting, so currently I cannot fix it on my side (also because I'm busy working on the next update). However, suhide developed by @Chainfire is able to hide Xposed and worked fine.
    However, only my Systemless Xposed v86.2, which is based on SuperSU's su.d, is supported using that method. v86.2 and v86.5 (latest, Magisk based) have nearly identical binaries, and the only difference is the path where the binaries are stored.
    I'm still not sure what's the real issue for it not being supported, I just hope it is not done intentionally.

    Conclusion
    Due to the fact that my Safety Net bypass is not 100% perfect now, I do not want to spend any more time waiting for auto-unroot to be polished. What I'm doing now is finishing up all the things I'd like to change in Magisk Manager (it has been a while since I last contributed to Manager, my fellow developers are doing all the heavy job), which might take a little more time, after that, packed with tons of information to be announced in Magisk Section, I'll release the long awaited update.

    Hope this lengthy post gives you the idea of the whole situation, and again thanks for all your support!!
    121
    Ah, some Chainfire bashing, I hope it is not too late for me to exercise additional villainy.

    First, let me make clear I have nothing against @topjohnwu, nor against Magisk. Magisk is an interesting project and it certainly displays @topjohnwu ingenuity and persistence. I don't doubt we will see more interesting things from his hands.

    -------------------------

    What has happened here is not all that dark and complicated, from either end. I returned from holidays, and someone pointed me at Magisk. My first thought: interesting!

    Among other things, the thread lists some issues with SuperSU, which in combination with the phrase The developer also requests users to not bug Chainfire with compatibility requests for SuperSU with Magisk from the portal article, raised my left eyebrow by nigh half an inch. The popular systemless xposed mod is apparently now based on it, and apparently it now no longer works with SuperSU, and apparently I'm not supposed to fix that, nor any of the other found issues. I found that a bit weird. So yes, I have told @topjohnwu that I was a bit surprised he was posting about issues with SuperSU without notifying me about them (I can't fix or help fix issues I'm not aware of, after all).

    He's also spreading a modified version of the SuperSU package, which is not all that uncommon, nor necessarily a problem. I have not looked into what he modified, I only ran a few quick tests on one of my devices, and found some commonly used commands run as root to be broken. I have informed him of this as well.

    It appears the tool of choice for Magisk is phh's Superuser, because of some of the mentioned issues with SuperSU. That's fine by itself, but fixing issues in that superuser by incorporating SuperSU's binaries into it is a somewhat questionable practise. After all, SuperSU is a commercial closed-source package that helps pay for my dinner, and superuser is a direct competitor. I have informed him that I was surprised he did this without asking for permission. I have expressed similar surprise on him spreading a modified version of LiveBoot (which helps pay for a snack now and then).
    @topjohnwu has also stated that Magisk's scripts are largely influenced by mine (I have not checked). Scripts based on mine are used all over the place on XDA, some people have crafted amazing things based on them, I have never made an issue of this (otherwise I would have just made them binaries). But yes, I have also stated to him that I don't think it's very nice to base something on one program, and then using that to (almost exclusively) push something directly competing with that program.

    tl;dr Towards @topjohnwu, I have:
    - expressed surprise he has issues getting Magisk to work with SuperSU, and has chosen not to inform me about those
    - expressed surprise he is using SuperSU binaries in a competing superuser without permission
    - expressed surprise he is posting a modified LiveBoot without permission
    - informed him of issues with the modified SuperSU he has posted
    - let him know I thought it wasn't very nice to be applying my scripts to benefit seemingly exclusively that same competing superuser

    To be crystal clear:
    - I have not asked for an apology
    - I have not asked for Magisk to be abandoned, neither the root hiding nor systemless module parts, and certainly not systemless xposed
    - I have not made an issue of any of this anywhere, until this post
    - I have not even specifically asked for anything to be taken down (though obviously in my opinion the other superuser package mixed with SuperSU's binaries, as well as the LiveBoot package, should go)
    - I have not reported this thread to XDA moderators for copyright violations or otherwise

    While my conversation with @topjohnwu may not win any awards for being friendly (though it may win some for brevity), I think all things considered my response has been rather mild. To be perfectly honest, until the apology post, I thought this was over with already. I think the apology post was triggered because I haven't replied to his last PM for a while - I was in the zone, it happens.

    To emphasize again, I have nothing against @topjohnwu, Magisk, or systemless xposed, and it is certainly not my goal to see any of them go. If it can be made to work together with SuperSU, great.

    I get it though: you think of something, you want to see if you can make it work, you finally get it to work, you publish it, it takes off - enthusiasm gets the better of you. Maybe in the rush some mistakes are made. That doesn't mean you have to just drop it and run. None of my stuff would make it past 0.1 if I stopped at the first big mistake :)

    Aside from said being in the zone coding, I usually regret actually responding to these sort of things the day after, which has made me hesitant to reply. Surprise me.
    76
    Thread temporarily closed so everyone sees this.

    The flood of "SafetyNet isn't working for me either!" posts are not helpful, at all. Please refrain from posting further, it will be looked into. Please do not forget that not passing SafetyNet is 100% NORMAL AND INTENDED when you have an unlocked booloader or running custom firmware. These are workarounds and they will be worked around in turn.

    The Flash
    Forum Moderator

    EDIT: Thread is reopened... I will be cleaning any SafetyNet posts for a while to keep the thread clean for real issues.
    75
    Hello everyone!

    I am aware that Google has updated Safety Net that makes Magisk itself a no go for Android Pay. In fact, I witnessed the change live while I am developing the new magiskhide, which should hide all Magisk modules and Magisk installed root.

    Google is serious about Safety Net now, clearly hunting down all possibility to run Xposed with Safety Net passed. I spend quite some time examining the new security measures last midnight, and fortunately it seems that it is possible to run Magisk and root along with Safety Net if no Xposed is running. I'm glad I removed the old root toggle at the right time lol, that is no longer feasible with the latest detection.

    So stay tuned for the next update, it will come with bug fixes, along with the new magiskhide to bypass that Safety Net.

    Google, how will a few systemless mods do any harm :p:p