Magisk General Support / Discussion

Search This thread

pndwal

Senior Member
Did you try:

- Does it show Update icon based on json

- Does LSposed v1.6.5(6315) (latest from TG, that worked fine with previous Alpha) work with Shamiko (or reports incompatibility), and with which version of Shamiko

- Does the accompanying latest Shamiko v0.3.0(73) (published together today on Alpha TG channel) show the status

Asking for the 'second opinion' - I had all those issues and I had to go back to Alpha 76ddfeb9 (23016) with the accompanying Shamiko v0.2.0(59)
Moved to latest Canary, haven't had a minute today; may not test latest Alpha, sorry... May have misunderstood some of your points earlier... Haven't even played much with new Canary...

Can say w/ 72 Shamiko Mono crashes if in denylist for me too ... I see update button but greyed out / does nothing... May manually update Shamiko later... LSPosed seems to be working fine w/ 72 anyway... PW
 

traversone

Senior Member
Feb 18, 2019
227
85
Moved to latest Canary, haven't had a minute today; may not test latest Alpha, sorry... May have misunderstood some of your points earlier... Haven't even played much with new Canary...

Can say w/ 72 Shamiko Mono crashes if in denylist for me too ... I see update button but greyed out / does nothing... May manually update Shamiko later... LSPosed seems to be working fine w/ 72 anyway... PW
with latest Alpha/Shamiko (yesterday's releases), update button is not there
 
  • Like
Reactions: zgfg

meric57

Senior Member
Oct 2, 2017
359
67
Samsung Galaxy Tab E
Hello, I have tried with magisk canary 5f4cd50c 23017, falsified odin 3.14 with AP correction under android 12 nothing this fact must not be restarted once I had to do a factory reset. re installed magisk and patched a magisk 23017 image, if not if anyone successfully rooted their non 5G s10 G973F on android 12 DBT GVA4 who faced a tutorial thanks
 

Homeboy76

Recognized Contributor
Aug 24, 2012
4,200
2,729
Google Pixel 8 Pro
Curious
I Installed
- Magisk 761a8dde-alpha
- SafetyNet 2.2.1
- Shamiko-v0.3.0-73
It hid the Magisk app. Could this be caused by the denylist being enabled?
When I checked settings, Hide the Magisk app is not enabled.:oops:
It passed SafetyNet and the device is certified.
 
Last edited:

pndwal

Senior Member
FWIW, I gave this response in a TG thread to a user who commented about TJW's recent employment and its implications for current Magisk: "...it was the restrictiveness that alarmed me". It may be of interest to some here. -
But what restrictions?...

John originally envisioned Zygisk as a framework for more powerful hiding in addition to enhanced module capability (some 2+ years ago now?) and he HAS DELIVERED! ...

Google has NOT stymied this, have publicly stated that they NEVER opposed root, only deliberate subversion of their security model (read SafetyNet API, incoming Play Integrity API etc) and have their own weapon that doesn't involve TJW to ensure this inevitably...

They've been strengthening Hardware Key Attestation for many years now - an early form of it predates Android 6 - and, as John has said, this will surely mean the end of hiding root as we know it; we will still have ability to hide root / magisk in userspace, but not unlocked bootloader / spoof Verified Boot Status which is the start of chain-of-trust for HKA.

Until Google swing their 'Big Hammer' (in deference to Devs who want assurance / to allow their code to run only in a TEE) however, we now have the structure to allow more powerful hiding as I said, and as John said 'Its time for others to start doing their job'...

He won't / can't do it, but neither he nor Google are preventing others; note that we already have Universal Safety net Fix, WIP Shamiko and LSPosed (with hiding solutions like Hide My Applist) powered by Zygisk now...

It must be said that John has done very little to strengthen MagiskHide aside from maintaining / adapting basic SafetyNet passing and Hide the Magisk app compatibility in new devices for several years now anyway, and even these have needed 3rd party fixes (MagiskHide Props Config fingerprint prop, force basic HKA fix and so on) for some time; much work was already being done by other Devs / researchers (hiding isolated process leaks, app intent queries, ID detections etc) long before John's Google tenure... And the SN hiding he did maintain is, as he puts it, 'trivial' for others to pick up...

Note also that Google is well aware of these efforts, and while they are bound to end them all w/ HKA at any tick of the clock, they are not meantime wasting time stopping modders beat Safety net etc. as they view these (especially Magisk users) as 'a healthy White Hat community' who's efforts actually benefit Google (help them identify / fix vulns) and not as people with 'nefarious goals' (summary of Reddit comments by Android Hardware-backed security team leader)...

We can thus have fun while the sun shines, and Google is actually facilitating this to the extent that they allow it / turn a blind eye (on purpose), ENCOURAGE modding efforts etc.

The refs for everything stated above are in XDA Magisk General Discussion Thread...

I hope this summary dispells some misinformation and also helps make clear how a symbiotic relationship with a healthy modding community makes Google's Android mobile platform and IOS two completely different animals...

I trust that both modders and corporate Big G value this difference... If either party dont, they're nuts in my book. PW
The way I see it, Google are our benefactors and Android custom modders are theirs... or vice versa... if you prefer... 🙃

...Why else would they employ the likes of John Wu? And there's got to be more in it for him than money! (wait, didn't he say that too?)... Viewed from this perspective there's no conflict of interest either!... (Nb. qualifyer 'from this perspective' before you argue. 😉) PW
 
Last edited:

pndwal

Senior Member
Latest Unofficial Alpha Magisk
(Chinese translated):

# alpha changelog

## Magisk (256d7156-alpha)
- [App] Support SharedUserId
- [App] Delete backup file after restoring boot image
- [App] Built-in current version update log
- [General] no longer automatically unlock device blocks
- [General] Use MagiskHide to hide when Zygisk is closed
- [App] Compatible with Android 12L
- [MagiskInit] Refactor the processing method of two-step startup
- [MagiskBoot] Speed up zopfli compression
- [General] Update to NDK 23

### how to install?
Install and uninstall Magisk through the Magisk application. Generally, it should be done directly in the application. In special cases such as the first installation, you should use the fastboot/odin tool to flash it after patching the image.
By customizing Recovery is not a supported way.

# Upstream changelog

## Magisk (cbe97cdf) (23018)

- [Zygisk] Show warning in app UI to indicate incompatible Zygisk modules
- [App] Allow modules to specify an update URL for in-app update + install

## Diffs to v23.0

- [General] MagiskHide is removed from Magisk
- [General] Support 64-bit only systems
- [General] Support Android 12
- [General] Update BusyBox to 1.34.1
- [Zygisk] Introduce new feature: Zygisk
- [Zygisk] Introduce DenyList feature to revert Magisk features in user selected processes
- [MagiskBoot] Support patching 32-bit kernel zImages
- [MagiskBoot] Support boot image header v4
- [MagiskBoot] Support patching out `skip_initramfs` from dtb bootargs
- [MagiskBoot] Add new env variable `PATCHVBMETAFLAG` to configure whether vbmeta flags should be patched
- [MagiskInit] Support loading fstab from `/system/etc` (required for Pixel 6)
- [MagiskInit] Support `/proc/bootconfig` for loading boot configurations
- [MagiskInit] Better support for some Meizu devices
- [MagiskInit] Better support for some OnePlus/Oppo/Realme devices
- [MagiskInit] Support `init.real` on some Sony devices
- [MagiskInit] Skip loading Magisk when detecting DSU
- [MagiskPolicy] Load `*_compat_cil_file` from system_ext
- [MagiskSU] Use isolated devpts if the kernel supports it
- [MagiskSU] Fix root shell if isolated mount namespace is set
- [resetprop] Deleted properties are now wiped from memory instead of just unlinking
- [App] Build a single APK for all ABIs
- [App] Switch to use standard bottom navigation bar
- [App] Downloading modules from the centralized Magisk-Modules-Repo is removed
- [App] Support user configuration of boot image vbmeta patching
- [App] Restore the ability to install Magisk on the other slot on some A/B devices
- [App] Allow modules to specify an update URL for in-app update + install

👍 PW
 

pndwal

Senior Member
What is shamiko? I do not know what it is. weird
If you're into Manga she's The Demon Girl Next Door, a 15 year old high school student w/ horns and tail...
shamiko.jpeg

Dev explaination:
https://t.me/c/1414270883/37349 🤪

... However I think you want this:
https://xdaforums.com/t/magisk-general-support-discussion.3432382/post-86306355

😜 PW
 
Last edited:
  • Like
Reactions: rodken

pndwal

Senior Member
Latest Shamiko:
(Bit late with this, sorry)

# Shamiko

こっっ… これで勝ったと思うなよ―――!!
[This ... I don't think I won with this --- !!]?​

### Introduction
Shamiko is a Zygisk module to hide Magisk root, Zygisk itself and Zygisk modules like riru hide.
Shamiko read the list of apps to hide from Magisk's denylist for simplicity but it requires denylist to be disabled first.
### Usage
1. Install Shamiko and enable Zygisk and reboot
1. Turn on denylist to configure denylist.
1. Once denylist is configured, disable it to activate Shamiko

### Changelog
#### 0.2.0
1. Support font modules since Android S
1. Fix module's description

#### 0.3.0
1. Support whitelist (enable by creating an empty file `/data/adb/shamiko/whitelist`)
1. Always unshare (useful for old platforms and isolated processes in new platforms)
1. Request Magisk 23017+, which allows us to strip Java daemon and change denylist regardless of enforcement status
1. Temporarily disable showing status in module description (need to find a new way for it)
1. Support module update since Magisk 23017

https://t.me/magiskalpha/411

👍 PW
 

Top Liked Posts

  • 1
    UPDATE: I got it to work by extracting and flashing the stock boot.img and recovery.img via odin. I guess that's a dirty fix and IDK why this worked and flashing the whole stock rom didn't
    If you flashed a stock ROM, you effectively uninstalled Magisk, except for the /data/adb directory.
    Ii'll check that folder (if I can install TWRP or something) in order to clean up, but my goal now is to reroot it.
    Did the flashing of the stock ROM involve doing a "factory reset / wipe data"?
    No, but, I did one factory reset from Android's configuration menu in order to clean up, set up the phone and debloat it (I bought it used). It worked afterwards but I screwed up when debloating so then I did the stock rom flash.
    If you have a problem after trying to reinstall Magisk, the things to check are:
    • did you patch and flash the right file?
    • did you change the version of Magisk?
    • did you change the version of Android?
    I'll keep that in mind when I try to reroot.
    Thanks for your response!
    1
    UPDATE: I got it to work by extracting and flashing the stock boot.img and recovery.img via odin. I guess that's a dirty fix and IDK why this worked and flashing the whole stock rom didn't
    Keep in mind that official instructions still state:

    Important Notes​

    • Never, ever try to restore either boot, init_boot, recovery, or vbmeta partitions back to stock! You can brick your device by doing so, and the only way to recover from this is to do a full Odin restore with data wipe.
    • To upgrade your device with a new firmware, NEVER directly use the stock AP tar file with reasons mentioned above. Always patch AP in the Magisk app and use that instead.
    although I know many Sammy users have been able to recover from this mistake without wiping data... Seems you've put your finger on the working method for your device... Not sure if trick would work for any Samsung device however, but may be useful for others...

    Take care with upgrades in future! 😉

    Ii'll check that folder (if I can install TWRP or something) in order to clean up, but my goal now is to reroot it.
    If goal is to reroot, you can leave configuration as-is... Only modules that become incompatible with later Android versions may cause bootloop, but normally the previous Magisk configuration files are OK... If you want to force a configuration rebuild (restore clean Magisk, no modules, superuser list, DenyList etc) after installation, just delete everything in /data/adb after rooted with a root explorer and reboot; configuration files will then be rebuilt.

    🤠 PW
    1
    UPDATE: I got it to work by extracting and flashing the stock boot.img and recovery.img via odin. I guess that's a dirty fix and IDK why this worked and flashing the whole stock rom didn't

    Ii'll check that folder (if I can install TWRP or something) in order to clean up, but my goal now is to reroot it.

    No, but, I did one factory reset from Android's configuration menu in order to clean up, set up the phone and debloat it (I bought it used). It worked afterwards but I screwed up when debloating so then I did the stock rom flash.

    I'll keep that in mind when I try to reroot.
    Thanks for your response!
    I think you are confused. (I know I am.)

    You said you flashed the stock ROM. Then you said you patched and flashed, which implies that the device was running after flashing the stock ROM. So you never mentioned trying to recover from the bootloop by flashing the entire stock ROM. I believe it would have worked, you just didn't do it.

    The thing that needed to be fixed was the bootloop after patching and flashing. I listed the first few things that came to mind that would explain why you got a bootloop. Those are the things that you need to be careful of the next time you try to install Magisk.

    If you have never had Magisk installed, you can ignore everything that refers to a previous installation of Magisk. Your bootloop was probably a matter of patching and flashing the boot from a different version of the ROM. Or maybe it was patching the boot image when you need to patch the recovery image.

    When installing Magisk on a Samsung device, you should "patch" the entire AP.tar file. Magisk will patch three images within the tar file (assuming either the Recovery option is selected by default, or you specifically select it). Then you hand the patched AP.tar to Odin and everything in it gets "flashed". After you've gotten it working, if you're a glutton for punishment you can see if you can patch and flash less than the full AP.tar, but I think you still have to give a tar file to Odin.
  • 5
    I'm now having a problem hiding the TJW Magisk 27002 app ...

    I finally was able to resurrect my old Pixel 5. It's running stock A11 and was running TJW Magisk 26004 with no problem.

    The Magisk manager was showing that the upgrade to 27002 was ready for installation, and so I did the following:

    (1) Unhide Magisk
    (2) Update Magisk (27002 was listed)
    (3) After Magisk manager restarted, I did Direct Update to 27002, including reboot
    (4) Magisk 27002 indeed came up properly after reboot.
    (5) Tried to perform Hide The Magisk App.

    I entered the arbitrary name for hiding, and I clicked "OK". But the hiding never took place.

    I rebooted again, to see if perhaps that's necessary, and I repeated the hiding attempt by adding the same arbitrary name, and I again clicked "OK". But the hiding still didn't take place.

    I searched my device, and there is no app nor shortcut with that arbitrary name. I also tried other, different arbitrary names, but after clicking "OK", the hiding still didn't take place for any name I chose.

    What am I missing?
    Known issue. A fix has been merged. You can use the Debug app, revert back to 27001 or wait until 27003 is released.

    EDIT: Ninja'd 🙃
    4
    Is the Magisk 27001 APK/zip still available anywhere? I'd like to downgrade, but I can only find 27000 on Github and 27002 via update. I don't want to go to Canary in case the mounting changes break anything, or Debug as I hear the extra logging etc. causes performance issues (correct me if I'm wrong).
    Only v27000 is Stable. (and Beta). v27001 and v27002 are Canary or Debug

    Set your Update Channel to Stable and you will see (just like you can see also on GitHub) that latest Stable is v27000, there was never Stable v27001 or v27002

    Generally, Stable is always Nx100

    So, you cannot downgrade to Stable v27001 but Canary v27001 should be just like Stable v27000 (same codebase). That's also the general policy, whenever Nx100 Stable is released, then immediately comes Canary Nx100 +1, on the same code-base

    Therefore, downgrade to Stable v27000 instead
    4
    Direct Install with recovery mode checked worked for me. You were right.

    After I flashed wrong CSC firmware my baseband and EMEIs disappeared. Now I have updated bootloader and I cant to flash original CSC firmware anymore. Any ideas how to restore baseband, EMEIs or it is too late?
    Yep, I told you several times that you need Recovery mode (selected) for your Ramdisk=No device; instructions for this are also clear in official Installation Instruction page too, but apparently you have not been trying to follow official instructions, so it's no real surprise you've messed up firmware too... Please take *extra* care when modding as there are simply so many variables and pitfalls! 😬

    Are you flashing patched AP (Application Processor binary) along with all the other package binaries (X4?) for your S10+ (also in Magisk Installation page, Samsung section)??

    CP is Cellular Processor (Nb. Oft repeated references to CP as 'core processor' may be misleading) binary package (also referred to as Baseband Modem) so that should have fixed mismatched baseband etc... correct CSC (Consumer Software Customization; region, APN and carrier specific software packages/settings) and even BL (Bootloader) are most likely also important...

    Nb. BL doesn't always update bootloader version, but if later firmware has been flashed be aware that these can also cause anti-roll back version for bootloader to be incremented (in the event that an update patches serious vulns) so you original firmware may be blocked and you may need to use later packages only...

    If flashing latest complete firmware package via Odin doesn't fix your IMEI / baseband issues it may be that you've messed with partitions that contain unique device values in the past... You may need to ask in Galaxy, S10 or S10+ XDA forums for that. 🤠 PW
    4
    I'm now having a problem hiding the TJW Magisk 27002 app ...

    I finally was able to resurrect my old Pixel 5. It's running stock A11 and was running TJW Magisk 26004 with no problem.

    The Magisk manager was showing that the upgrade to 27002 was ready for installation, and so I did the following:

    (1) Unhide Magisk
    (2) Update Magisk (27002 was listed)
    (3) After Magisk manager restarted, I did Direct Update to 27002, including reboot
    (4) Magisk 27002 indeed came up properly after reboot.
    (5) Tried to perform Hide The Magisk App.

    I entered the arbitrary name for hiding, and I clicked "OK". But the hiding never took place.

    I rebooted again, to see if perhaps that's necessary, and I repeated the hiding attempt by adding the same arbitrary name, and I again clicked "OK". But the hiding still didn't take place.

    I searched my device, and there is no app nor shortcut with that arbitrary name. I also tried other, different arbitrary names, but after clicking "OK", the hiding still didn't take place for any name I chose.

    What am I missing?
    Known problem with 27002, the debug version doesn't have the problem with hiding, read back to see the discussion about it
    3
    Thanks for your reply.
    So I stay for the moment at Magisk 26.4 für my Xiaomi 14 Ultra. Because there is xiaomi.eu ROM for my phone available since 2 hours, I will flash this tomorrow und with the Module from Xiaomi.eu Team I do not need Playintegrity anymore.

    So do I understand correct, to hide root I should use Shamiko? Latest Shamiko can be found here https://github.com/LSPosed/LSPosed.github.io/releases correct?
    Since Xiaomi eu is a custom ROM, their devs made the injector, 'module' that tricks DroidGuard and injects the spoofs with no need for Magisk/root and Zygisk

    And as that, you achieve Device Integrity without the Magisk.
    But if you install Magisk, you have to hide Magisk and Zygisk by your own

    So yes, you can use Shamiko and it should work (I used that kind of setup at the beginning of this year, for like two weeks, with no problems)

    But then ask yourselves - what for do you need Magisk. If using like Viper4Android, useful LSPosed modules - then, yes

    If not, better uninstall Magisk and you will only have Xiaomi.eu injector. Btw, yes, it is rather injector than a module, it's full name is XiaomiEUInject

    Regarding the prints - there are now no more publicly available working prints, hence a vast majority of rooted users use the prints 'stolen' from the Xiaomi.eu injector. When Google bans them, both sides will be equally affected. And assuming that Xiaomi.eu team quickly publishes their new version of injector, (last time it was in a matter of hours) with the new prints, all those rooted users will jump again to their new prints from tha new injector (new version of PIF was published less than an hour upon the Xiaomi.eu injecto was updated)

    But if Google makes a slaughter like last time (now there are about 20 times less working prints than previously) and if Xiaomi.eu team does not come up (quickly) with the new injector (and the new working prints), than better don't think what could happen.
    Btw, Wallet can run about half a day on the cached previous Play Integrity pass

    Hence, with the Xiaomi.eu injector or with PI Fix (with its built-in prints), PI Fork with the corresponding autopif script, etc, you are equally exposed to the Google's mercy

    Therefore, if you really need Magisk, you can also keep using the PI Fix/For with the disabled Xiaomi.eu injector. It will be easier for your maintenance than to struggle with both worlds in parallel (although, that can work as well)
  • 1103
    This is the place for general support and discussion regarding "Public Releases", which includes both stable and beta releases.
    All information, including troubleshoot guides and notes, are in the Announcement Thread
    156
    Hello, I haven't given much support on XDA lately. It can be resulted from
    • University started and I have limited free time. In fact, I mostly develop during midnight
    • I live in Taiwan, which has large time zone differences between my European/American contributors/testers, which usually forces me to stay up late at night to discuss/test stuffs.
    • The new version is about to come, I don't want to spend effort on supporting old releases
    The planned update is delayed again and again, to some point I think I'll shed some light about what has been happening lately, also along with some announcements.

    New Forum!
    As you might have already discovered, Magisk got its own subforum on XDA! Many thanks to all the support you gave me, and much more information/features/support is about to come!
    **For developers supporting all the devices that are not using standard Android boot format, feel free to create threads in this section (actually, PLEASE do so) for your favorite devices after v7 is out. As I currently know, Asus devices require signing the boot image before flashing, and is model dependant; Sony devices seems to use ELF kernel that is unpatchable, or some has two ramdisks (inner + outer), both requires different workarounds; LG bootloader locked devices has to manually "BUMP" the boot image after flashing Magisk..... and there may be lots of other crazy boot image formats that haven't come up to my attention yet.
    It is impossible for me to support all these non-standard boot images, and I hope the community can collaborate to make Magisk running across all the devices. Overall, community collaboration is what XDA about :D

    The Pixel Phone
    Some of you might already know this news, that the next Pixel Phone right around the corner seems like it does not have ramdisk in boot image, which pretty much wrecked Magisk in all ways. However, it pretty much doomed root itself too. Kernel modifications is inevitable IMO, so I'll try to migrate my scripts to C programs that could possibly be included into the kernel itself. Note that I'm not familiar with linux kernel, I'm not even sure if my idea and concept is correct or not. But once the device is available, I think developers will find a way to bypass all the difficulties, and I'll do my best to learn things ;)

    Current Progress
    In the past month, I've spent quite some time learning SELinux, so that I can avoid using SuperSU's sepolicy patches. Thanks to the helps and tips from @phhusson and @Chainfire, I finally have a much clearer understanding of how SELinux works. The Magisk core parts (the scripts, boot image patches, new features, more supports) are actually done some time ago. What is causing all the delays is the Magisk Manager.
    To be completely honest, although I can code in Java without much issues, Magisk Manager is actually my first Android application, I had to reach out for assistance, and fortunately awesome developers like @DVDandroid and @digitalhigh contributed a lot, which makes the current Manager awesome.
    After the repo system and module management is mostly done, I was about to do some adjustments and release, but what we really done is decided to add another feature: auto-unroot with per-app settings. I decided to wait for it to be finished, and then do my adjustments. Due to reasons that'll be mentioned later, this feature will likely not be available for the next release (should come in future updates)

    Safety Net Disaster
    Those who are using Magisk for Safety Net bypass purposes must have known that Google recently updated the detection method of my Systemless Xposed. I still have no idea what Safety Net is detecting, so currently I cannot fix it on my side (also because I'm busy working on the next update). However, suhide developed by @Chainfire is able to hide Xposed and worked fine.
    However, only my Systemless Xposed v86.2, which is based on SuperSU's su.d, is supported using that method. v86.2 and v86.5 (latest, Magisk based) have nearly identical binaries, and the only difference is the path where the binaries are stored.
    I'm still not sure what's the real issue for it not being supported, I just hope it is not done intentionally.

    Conclusion
    Due to the fact that my Safety Net bypass is not 100% perfect now, I do not want to spend any more time waiting for auto-unroot to be polished. What I'm doing now is finishing up all the things I'd like to change in Magisk Manager (it has been a while since I last contributed to Manager, my fellow developers are doing all the heavy job), which might take a little more time, after that, packed with tons of information to be announced in Magisk Section, I'll release the long awaited update.

    Hope this lengthy post gives you the idea of the whole situation, and again thanks for all your support!!
    121
    Ah, some Chainfire bashing, I hope it is not too late for me to exercise additional villainy.

    First, let me make clear I have nothing against @topjohnwu, nor against Magisk. Magisk is an interesting project and it certainly displays @topjohnwu ingenuity and persistence. I don't doubt we will see more interesting things from his hands.

    -------------------------

    What has happened here is not all that dark and complicated, from either end. I returned from holidays, and someone pointed me at Magisk. My first thought: interesting!

    Among other things, the thread lists some issues with SuperSU, which in combination with the phrase The developer also requests users to not bug Chainfire with compatibility requests for SuperSU with Magisk from the portal article, raised my left eyebrow by nigh half an inch. The popular systemless xposed mod is apparently now based on it, and apparently it now no longer works with SuperSU, and apparently I'm not supposed to fix that, nor any of the other found issues. I found that a bit weird. So yes, I have told @topjohnwu that I was a bit surprised he was posting about issues with SuperSU without notifying me about them (I can't fix or help fix issues I'm not aware of, after all).

    He's also spreading a modified version of the SuperSU package, which is not all that uncommon, nor necessarily a problem. I have not looked into what he modified, I only ran a few quick tests on one of my devices, and found some commonly used commands run as root to be broken. I have informed him of this as well.

    It appears the tool of choice for Magisk is phh's Superuser, because of some of the mentioned issues with SuperSU. That's fine by itself, but fixing issues in that superuser by incorporating SuperSU's binaries into it is a somewhat questionable practise. After all, SuperSU is a commercial closed-source package that helps pay for my dinner, and superuser is a direct competitor. I have informed him that I was surprised he did this without asking for permission. I have expressed similar surprise on him spreading a modified version of LiveBoot (which helps pay for a snack now and then).
    @topjohnwu has also stated that Magisk's scripts are largely influenced by mine (I have not checked). Scripts based on mine are used all over the place on XDA, some people have crafted amazing things based on them, I have never made an issue of this (otherwise I would have just made them binaries). But yes, I have also stated to him that I don't think it's very nice to base something on one program, and then using that to (almost exclusively) push something directly competing with that program.

    tl;dr Towards @topjohnwu, I have:
    - expressed surprise he has issues getting Magisk to work with SuperSU, and has chosen not to inform me about those
    - expressed surprise he is using SuperSU binaries in a competing superuser without permission
    - expressed surprise he is posting a modified LiveBoot without permission
    - informed him of issues with the modified SuperSU he has posted
    - let him know I thought it wasn't very nice to be applying my scripts to benefit seemingly exclusively that same competing superuser

    To be crystal clear:
    - I have not asked for an apology
    - I have not asked for Magisk to be abandoned, neither the root hiding nor systemless module parts, and certainly not systemless xposed
    - I have not made an issue of any of this anywhere, until this post
    - I have not even specifically asked for anything to be taken down (though obviously in my opinion the other superuser package mixed with SuperSU's binaries, as well as the LiveBoot package, should go)
    - I have not reported this thread to XDA moderators for copyright violations or otherwise

    While my conversation with @topjohnwu may not win any awards for being friendly (though it may win some for brevity), I think all things considered my response has been rather mild. To be perfectly honest, until the apology post, I thought this was over with already. I think the apology post was triggered because I haven't replied to his last PM for a while - I was in the zone, it happens.

    To emphasize again, I have nothing against @topjohnwu, Magisk, or systemless xposed, and it is certainly not my goal to see any of them go. If it can be made to work together with SuperSU, great.

    I get it though: you think of something, you want to see if you can make it work, you finally get it to work, you publish it, it takes off - enthusiasm gets the better of you. Maybe in the rush some mistakes are made. That doesn't mean you have to just drop it and run. None of my stuff would make it past 0.1 if I stopped at the first big mistake :)

    Aside from said being in the zone coding, I usually regret actually responding to these sort of things the day after, which has made me hesitant to reply. Surprise me.
    76
    Thread temporarily closed so everyone sees this.

    The flood of "SafetyNet isn't working for me either!" posts are not helpful, at all. Please refrain from posting further, it will be looked into. Please do not forget that not passing SafetyNet is 100% NORMAL AND INTENDED when you have an unlocked booloader or running custom firmware. These are workarounds and they will be worked around in turn.

    The Flash
    Forum Moderator

    EDIT: Thread is reopened... I will be cleaning any SafetyNet posts for a while to keep the thread clean for real issues.
    75
    Hello everyone!

    I am aware that Google has updated Safety Net that makes Magisk itself a no go for Android Pay. In fact, I witnessed the change live while I am developing the new magiskhide, which should hide all Magisk modules and Magisk installed root.

    Google is serious about Safety Net now, clearly hunting down all possibility to run Xposed with Safety Net passed. I spend quite some time examining the new security measures last midnight, and fortunately it seems that it is possible to run Magisk and root along with Safety Net if no Xposed is running. I'm glad I removed the old root toggle at the right time lol, that is no longer feasible with the latest detection.

    So stay tuned for the next update, it will come with bug fixes, along with the new magiskhide to bypass that Safety Net.

    Google, how will a few systemless mods do any harm :p:p