Magisk General Support / Discussion

Search This thread
By:
Advanced…
zgfg

zgfg

Senior Member
Oct 10, 2016
10,761
9,384
Redmi K20 / Xiaomi Mi 9T
Xiaomi Mi 11
pndwal said:
Could be some module or mod?
Click to expand...
Click to collapse
The only components I upgraded in the last weeks are:
- Magisk Canary
- USNF
- Shamiko (same if using instead Unmount DenyList))
- Momo (but I also downgraded Momo but did not help)
wngraded Momo but did not help)

All the rest, except for apps over Google play are not touched.
I checked Google Play System Update, it's still May 1, 2022 - well before Momo started to detect su

The whole mystery is in Magisk, Zygisk, Shamiko whatever

TG, I don't have any sensitive app on the phone to start complaining about the root but frankly, with every new round of refactoring or revolutionary improvements, root detection becomes more vulnerable - I wonder why people who really want to run sensitive banking apps or so, that frantically follow all upgrades here. Seems that old technologies (eg MagiskHide in Delta) provide more: root but less vulnerable to detections

Pls don't respond that preventing root detection is not TJW's business - we all know that. I'm talking from the users perspective, not from his or his employers perspective
 
Last edited:
  • Like
Reactions: traversone and jakito
B

Bouls

Member
Jun 22, 2022
9
2
pndwal said:
Aside from what I already told you about Direct install (and I believe this applies to custom ROM zip installation also if updating previously installed Magisk rather than flashing over unrooted system) being broken / producing this type of error due to refactored MagiskInit when updating from 24.x or less, I see you have Galaxy Note 9... Despite launching with Android 8.1, since updating to Android 10 you now have 2SI "SAR" device, so you should read and follow Samsung (System-as-root) instructions:
https://topjohnwu.github.io/Magisk/install.html#samsung-system-as-root

- Just ignore the statement "If your Samsung device is NOT launched with Android 9.0 or higher, you are reading the wrong section"...


Is your recovery twrp-3.6.2_9-0-crownlte?... Doesn't it decrypt /data?

🤠 PW
Click to expand...
Click to collapse
That's the same thing I did bro, I got my stock AP and patched it in magisk then flashed the firmware with this patched AP using odin. But my data is still encrypted, I cannot see my internal storage in twrp, yes I have the latest twrp install and it doesn't ask me to decrypt /data, I cannot access data
 
  • Like
Reactions: pndwal
P

pndwal

Senior Member
Jun 23, 2016
7,794
9,616
Sydney
Redmi Note 8
Xiaomi Redmi Note 8 (2021)
zgfg said:
The only components I upgraded in the last weeks are:
- Magisk Canary
- USNF
- Shamiko (same if using instead Unmount DenyList))
- Momo (but I also downgraded Momo but did not help)
wngraded Momo but did not help)

All the rest, except for apps over Google play are not touched.
I checked Google Play System Update, it's still May 1, 2022 - well before Momo started to detect su

The whole mystery is in Magisk, Zygisk, Shamiko whatever.
Click to expand...
Click to collapse
Then difference between our results is probably your Android 11, 2SI, custom XiaoniEU(?)... I have 10, LSAR, stock MIUI...
zgfg said:
TG, I don't have any sensitive app on the phone to start complaining about the root but frankly, with every new round of refactoring or revolutionary improvements, root detection becomes more vulnerable -
Click to expand...
Click to collapse
True... at least every WIP change requires remedial action which can be W...I..............P too! 😜

Also, Zygisk itself is just out of beta... Guess we shouldn't expect hide for Zygisk era Magisk to mature overnight...
zgfg said:
I wonder why people who really want to run sensitive banking apps or so, that frantically follow all upgrades here. Seems that old technologies (eg MagiskHide in Delta) provide more: root but less vulnerable to detections
Click to expand...
Click to collapse
Sure...
zgfg said:
Pls don't respond that preventing root detection is not TJW's business - we all know that. I'm talking from the users perspective, not from his or his employers perspective
Click to expand...
Click to collapse
Why would I say that? 🙄... He's only threatened to force root detection! 😁
www.twitter.com/topjohnwu/status/1452188664780500995

😜 PW
 
rodken

rodken

Senior Member
Jan 11, 2010
2,498
1,175
Bouls said:
That's the same thing I did bro, I got my stock AP and patched it in magisk then flashed the firmware with this patched AP using odin. But my data is still encrypted, I cannot see my internal storage in twrp, yes I have the latest twrp install and it doesn't ask me to decrypt /data, I cannot access data
Click to expand...
Click to collapse
Did you at least attempt to:

-- The first thing to try is if somehow your internal storage became encrypted when using a legacy screen lock method.
-- Go to your Android device’s Settings > Security > Screen Lock, and change your screen lock method to either Pass or Pin.
-- Create a new one.
-- Reboot into TWRP, and it should ask for a password – enter the pass or pin you just created.
-- TWRP will attempt to decrypt your device’s internal storage, and if it succeeds, you should not have further issues.
-- However, if this does not solve your issue of “unable to mount data, internal storage 0mb”, continue with the rest.
-- Reboot your device into TWRP again.
-- Navigate to Wipe > Advance Wipe > Data, and choose Repair or Change File System.
-- Press Repair File System to see if this fixes the issue. If not, continue.
-- Press Change File System, choose Ext2, and swipe to confirm.
-- Now switch back to Ext4 and swipe to confirm.
-- Go back to TWRP main menu, then the Mount menu, and check if your partitions can be mounted now.
-- If you are still unable to mount your partitions, you need to repair Internal partition, which will most likely wipe your storage.
 
  • Like
Reactions: J.Michael
N

n.p.

Senior Member
Jul 25, 2013
127
25
pndwal said:
Seems you have stub app (not original Magisk app) installed... That's what Hide the Magisk app does; uninstalls Magisk App, installs stub, populates its data with "full Magisk" binary...

Updating w/ app 'hidden' is supposed to work, but, as reported here often (and in my experience) it only works 50% of the time in practice w/o issues... If you hid app(s), my bet is that you'll find conflicting renamed stub ('Settings' or whatever you named it) in system settings, Apps... Uninstall these instances and try with correct corresponding full Magisk app...

If this isn't your issue, please give some details about devices... model, OS, Android version... PW
Click to expand...
Click to collapse

I had never done the Hide the Magisk app, but the issue does seem to involve remnants of something. The first time i tried to uninstall it (using Settings / Apps / Magisk), I then attempted to install via adb, and received a warning the app already existed. I then uninstalled via adb, and attempted to install after that (no warnings, but something still not working).

Later, with 25.1 supposedly installed again, I noticed in F-Droid (I have never used F-Droid to install Magistk, but of couse it reports the existence of any app with the same name as one in its repository) that it still reported 24.3 installed. So, I used F-Droid to uninstall Magisk (why not?), but then, after reloading F-Droid, it still reported version "1.0" as installed. So, I uninstalled that as well, and F-Droid no longer reported any Magisk on the system. I searched through System / Apps (even with Show system enabled), and saw nothing that I did not recognize. I installed the 25.1 apk downloaded from github again, flashed the patched boot image again, and... same result (Magisk just shows as N/A).

I do notice that if I attempt to install Magisk 25.1, I get the full app (Settings / Apps shows Magisk as 23.42 MB), but if I install 24.3 (working perfectly until a few hours ago), it initially shows as 22.80 MB, but the first time I attempt to start it, it crashes immediately, and then the icon changes to the generic Android icon, and the size in Settings / Apps changes to 224 KB.

The device (a Teclast T10 tablet with the exact model number of E3C5) has the latest stock firmware (1.05_20180306) built from Android 7.0.
 
Last edited:
N

n.p.

Senior Member
Jul 25, 2013
127
25
I have made some progress here without understanding any reason why.

I randomly noticed this post directed torwards another user, and I had a similar problem with the inability of TWRP to mount data.

rodken said:
Did you at least attempt to:

-- The first thing to try is if somehow your internal storage became encrypted when using a legacy screen lock method.
-- Go to your Android device’s Settings > Security > Screen Lock, and change your screen lock method to either Pass or Pin.
-- Create a new one.
-- Reboot into TWRP, and it should ask for a password – enter the pass or pin you just created.
-- TWRP will attempt to decrypt your device’s internal storage, and if it succeeds, you should not have further issues.
-- However, if this does not solve your issue of “unable to mount data, internal storage 0mb”, continue with the rest.
-- Reboot your device into TWRP again.
-- Navigate to Wipe > Advance Wipe > Data, and choose Repair or Change File System.
-- Press Repair File System to see if this fixes the issue. If not, continue.
-- Press Change File System, choose Ext2, and swipe to confirm.
-- Now switch back to Ext4 and swipe to confirm.
-- Go back to TWRP main menu, then the Mount menu, and check if your partitions can be mounted now.
-- If you are still unable to mount your partitions, you need to repair Internal partition, which will most likely wipe your storage.
Click to expand...
Click to collapse

I have never had a screen lock on this device, but I decided to go through the repair steps, which did completely wipe everything from the system (I do have recent backups of all of the important apps, but might have lost some other things I don't care too much about). So I set up USB debugging again, and installed the Magisk 25.1 apk again. Much to my surprise (without flashing anything additional), it showed Magisk 25.1 as installed, though it did want to reboot to complete the installation. I verified that Magisk remained installed after the reboot (it did), but then In went into settings, enabled Zygisk, and rebooted again. That brough me back to the previous state (no Magisk installed and TWRP could not mount /data). I could only proceed by reformatting /data (again), setting up USB debugging (again), installing Magisk (for about the 20th time today), and noting (again) that the app shows Magisk 25.1 as installed without any additional flashing (though, again, with another reboot required).

Obviously, I will avoid Zygisk for now, but I would appreciate some enlightenment regarding a way to recover from this in the future (without having to reformat data), and guidance on the timing of the ability to use Zygisk safely (I do have an app on this device that I need to hide root from).
 
flostie74

flostie74

Member
Jun 29, 2022
22
1
Samsung Galaxy S23 Ultra
Hi maybe somebody can help me here. I installed magisk on my LOS. I downloaded the 25.1 apk and renamed it to .zip and flashed via recovery. So far so good. But iam unable to see any packages. It just shows "no modules installed". Am i missing something?
 
zgfg

zgfg

Senior Member
Oct 10, 2016
10,761
9,384
Redmi K20 / Xiaomi Mi 9T
Xiaomi Mi 11
flostie74 said:
Hi maybe somebody can help me here. I installed magisk on my LOS. I downloaded the 25.1 apk and renamed it to .zip and flashed via recovery. So far so good. But iam unable to see any packages. It just shows "no modules installed". Am i missing something?
Click to expand...
Click to collapse
Did you have any module installed - it should be showing

On the other side long ago, since Magisk v24, Magisk app does no more connect to Repository. Its in the Changelog and really been asked and answered hundredth of times here

You can install a module if you already have it downloaded (from eg GitHub). Or search back to find about Fox Magisk Module Manager app
 
  • Like
Reactions: loweisounds and J.Michael
rodken

rodken

Senior Member
Jan 11, 2010
2,498
1,175
flostie74 said:
Hi maybe somebody can help me here. I installed magisk on my LOS. I downloaded the 25.1 apk and renamed it to .zip and flashed via recovery. So far so good. But iam unable to see any packages. It just shows "no modules installed". Am i missing something?
Click to expand...
Click to collapse
Maybe, uninstall Magisk by TWRP - then reinstall Magisk again.
 
flostie74

flostie74

Member
Jun 29, 2022
22
1
Samsung Galaxy S23 Ultra
zgfg said:
Did you have any module installed - it should be showing

On the other side long ago, since Magisk v24, Magisk app does no more connect to Repository. Its in the Changelog and really been asked and answered hundredth of times here

You can install a module if you already have it downloaded (from eg GitHub). Or search back to find about Fox Magisk Module Manager app
Click to expand...
Click to collapse
Okay so there is no online installer of modules anymore? Thanks for the clarification.
 
R

razes

Member
Sep 13, 2016
37
1
I've flashed recently CSC file and lost the root. I updated MAgisk app up to 25.1 version (not a zip file just apk) but still no root. I have flashed Magisk 25.1.zip file in TWRP recovery. Now the phone is rooted, but I unable to start Magisk app. It just stuck on the start (The Mask). I tried to uninstall Magisk app via Application manager, and reinstall it following by reboot. Still Magisk unable to start. I don't remember whether MAgisk was unhidden before the update and zip installation. What should I do next?
Should I rename the Magisk.apk to uninstall.zip and run this file in TWRP. Then install Magisk apk and install zip file from within Magisk App? If so, what the best way to install MAgisk App; via TWRP or File Manager?
Samsung Galaxy S5
Marshmallow 6.0.1
 
  • Like
Reactions: Whosondephone
P

pndwal

Senior Member
Jun 23, 2016
7,794
9,616
Sydney
Redmi Note 8
Xiaomi Redmi Note 8 (2021)
razes said:
I've flashed recently CSC file and lost the root.
Click to expand...
Click to collapse
I'm guessing flash CSC = factory reset? Did you do this in Odin w/ other needed binaries incl. AP?...
razes said:
I updated MAgisk app up to 25.1 version (not a zip file just apk) but still no root. I have flashed Magisk 25.1.zip file in TWRP recovery. Now the phone is rooted, but I unable to start Magisk app. It just stuck on the start (The Mask).
Click to expand...
Click to collapse
Strange issue... Do you have issues starting other apps? Tried clearing its app data?...

Also, try deleting everything in /data/adb and rebooting to rebuild Magisk config files... Use TWRP if you can't use a root explorer...
razes said:
I tried to uninstall Magisk app via Application manager, and reinstall it following by reboot. Still Magisk unable to start. I don't remember whether MAgisk was unhidden before the update and zip installation. What should I do next?
Click to expand...
Click to collapse
Hidden app would be gone if did factory reset...

If installed since, check in device settings, Apps for 'Settings' (default name) or whatever you named it. Uninstall if found...
razes said:
Should I rename the Magisk.apk to uninstall.zip and run this file in TWRP. Then install Magisk apk and install zip file from within Magisk App? If so, what the best way to install MAgisk App; via TWRP or File Manager?
Click to expand...
Click to collapse
Install app like any other .apk from 'unknown aources'...
razes said:
Samsung Galaxy S5
Marshmallow 6.0.1
Click to expand...
Click to collapse
👍 PW
 
  • Like
Reactions: Whosondephone, ipdev and J.Michael
zgfg

zgfg

Senior Member
Oct 10, 2016
10,761
9,384
Redmi K20 / Xiaomi Mi 9T
Xiaomi Mi 11
pndwal said:
Also, Zygisk itself is just out of beta... Guess we shouldn't expect hide for Zygisk era Magisk to mature overnight...
Click to expand...
Click to collapse
After having no luck with Shamiko or DenyList Unmount, I now run without of them and with Enforce DenyList enabled

I still have the same Momo detections (su, Zygisk, Magisk) but bystem boots evidently faster and runs (hard to be sure since the phone is fast anyway) maybe even more fluid then with Shamiko
 
  • Like
Reactions: ipdev
dohanin

dohanin

Senior Member
Mar 26, 2011
249
138
Sony Xperia X Compact
Xiaomi Mi Pad 4
Hi all, just some sharing on my experience in the past week.

I updated Magisk from stable 24.3 to 25.1, everything seemed fine.
Then noticed there were updates of USNF and Shamiko, which are the only modules I use, then I updated both.
Then the latest Momo reported nothing found (only bootloader unlocked), so all looked good.

However, in my Work profile, Zimperium zIPS detected ROOT! This is the last thing I want because it will automatically reports to my company that I'm using a rooted device to access company mails, etc. :_(

I reverted USNF and Shamiko to the previous versions, still no luck.
Then a full uninstall of Magisk, followed by installing 24.3. Then latest versions of USNF and Shamiko.

Well, Momo this time reported Zygisk found. Then zIPS only reported App Tampering instead of ROOT.
Ok, reverted Shamiko from 0.5.1 to 0.5.0, then App Tampering is gone too. So, everything back to normal for me (except Momo reporting Zygisk, which I don't care!)

So Magisk 24.3, USNF latest, Shamiko previous (0.5.0) works for my device to defeat zIPS.
Edit: Momo only detects Unlocked Bootloader for me in this setup.

Just some sharing :)
 
Last edited:
  • Like
  • Love
Reactions: amk316, svendsvin, ipdev and 1 other person
P

pndwal

Senior Member
Jun 23, 2016
7,794
9,616
Sydney
Redmi Note 8
Xiaomi Redmi Note 8 (2021)
n.p. said:
I had never done the Hide the Magisk app, but the issue does seem to involve remnants of something. The first time i tried to uninstall it (using Settings / Apps / Magisk), I then attempted to install via adb, and received a warning the app already existed. I then uninstalled via adb, and attempted to install after that (no warnings, but something still not working).

Later, with 25.1 supposedly installed again, I noticed in F-Droid (I have never used F-Droid to install Magistk, but of couse it reports the existence of any app with the same name as one in its repository) that it still reported 24.3 installed. So, I used F-Droid to uninstall Magisk (why not?), but then, after reloading F-Droid, it still reported version "1.0" as installed. So, I uninstalled that as well, and F-Droid no longer reported any Magisk on the system. I searched through System / Apps (even with Show system enabled), and saw nothing that I did not recognize. I installed the 25.1 apk downloaded from github again, flashed the patched boot image again, and... same result (Magisk just shows as N/A).

I do notice that if I attempt to install Magisk 25.1, I get the full app (Settings / Apps shows Magisk as 23.42 MB), but if I install 24.3 (working perfectly until a few hours ago), it initially shows as 22.80 MB, but the first time I attempt to start it, it crashes immediately, and then the icon changes to the generic Android icon, and the size in Settings / Apps changes to 224 KB.
Click to expand...
Click to collapse
Assuming 25.1 binary is installed, this seems to be intended behaviour for 25.1+ daemon:
  • [General] Enforce the Magisk app to always match or be newer than magiskd
(Commit:
Force app version not lower than daemon)

n.p. said:
The device (a Teclast T10 tablet with the exact model number of E3C5) has the latest stock firmware (1.05_20180306) built from Android 7.0.
Click to expand...
Click to collapse
This issue seems strange however, and may warrant a GitHub issue ticket... Do what you can to ensure no stub is installed first however...

Type Magisk -c in terminal emulator to see Magisk binary version installed, or Magisk -v to see daemon version running...

Note that since 16.6 we had
  • [Daemon] Check whether a valid Magisk Manager is installed on boot, if not, install stub APK embedded in magiskinit
This has been working in older Magisk, but seems to be removed / broken in 25.x on my device... I'm guessing you've been getting stub installation on boot after removing full app w/ 24.3 binary installed...

Anyway, check you are installing full app matching installed binary and stub is not present...

Nb. There have be many recent tweaks for app loading, signature checks, stub functions etc, so you are ikely experiencing some regression... More changes are coming too, eg this is already merged in TJW master but not yet built in a release:
Build dynamic stub resource APK at runtime ...
Close #6013
Co-authored-by: vvb2060
topjohnwu and vvb2060 committed 8 days ago

🤠 PW
 
Last edited:
  • Like
Reactions: ipdev and rodken
You must log in or register to reply here.

Similar threads

T
  • Locked
  • Sticky
Magisk - The Magic Mask for Android
Replies
56
Views
6M
T
topjohnwu
T
  • Locked
[CLOSED][BETA][2018.7.19] Magisk v16.7 (1671)
Replies
7K
Views
3M
T
topjohnwu
Heisenberg
[Discussion] PokeMon Go Magisk Discussion Thread
Replies
5K
Views
649K
beneditodragon
beneditodragon
Didgeridoohan
[Discussion] Google Pay Magisk Discussion Thread
Replies
3K
Views
572K
I
ihavenolifee
yochananmarqos
Collection of Magisk Modules v2
Replies
1K
Views
1M
あなたの
あなたの

Top Liked Posts

24 Hours 30 Days All time
  • There are no posts matching your filters.
  • 5
    Lughnasadh
    Lughnasadh
    HippoMan said:
    I'm now having a problem hiding the TJW Magisk 27002 app ...

    I finally was able to resurrect my old Pixel 5. It's running stock A11 and was running TJW Magisk 26004 with no problem.

    The Magisk manager was showing that the upgrade to 27002 was ready for installation, and so I did the following:

    (1) Unhide Magisk
    (2) Update Magisk (27002 was listed)
    (3) After Magisk manager restarted, I did Direct Update to 27002, including reboot
    (4) Magisk 27002 indeed came up properly after reboot.
    (5) Tried to perform Hide The Magisk App.

    I entered the arbitrary name for hiding, and I clicked "OK". But the hiding never took place.

    I rebooted again, to see if perhaps that's necessary, and I repeated the hiding attempt by adding the same arbitrary name, and I again clicked "OK". But the hiding still didn't take place.

    I searched my device, and there is no app nor shortcut with that arbitrary name. I also tried other, different arbitrary names, but after clicking "OK", the hiding still didn't take place for any name I chose.

    What am I missing?
    Click to expand...
    Click to collapse
    Known issue. A fix has been merged. You can use the Debug app, revert back to 27001 or wait until 27003 is released.

    EDIT: Ninja'd 🙃
    View
    4
    zgfg
    zgfg
    Jaitsu said:
    Is the Magisk 27001 APK/zip still available anywhere? I'd like to downgrade, but I can only find 27000 on Github and 27002 via update. I don't want to go to Canary in case the mounting changes break anything, or Debug as I hear the extra logging etc. causes performance issues (correct me if I'm wrong).
    Click to expand...
    Click to collapse
    Only v27000 is Stable. (and Beta). v27001 and v27002 are Canary or Debug

    Set your Update Channel to Stable and you will see (just like you can see also on GitHub) that latest Stable is v27000, there was never Stable v27001 or v27002

    Generally, Stable is always Nx100

    So, you cannot downgrade to Stable v27001 but Canary v27001 should be just like Stable v27000 (same codebase). That's also the general policy, whenever Nx100 Stable is released, then immediately comes Canary Nx100 +1, on the same code-base

    Therefore, downgrade to Stable v27000 instead
    View
    4
    P
    pndwal
    forserg said:
    Direct Install with recovery mode checked worked for me. You were right.

    After I flashed wrong CSC firmware my baseband and EMEIs disappeared. Now I have updated bootloader and I cant to flash original CSC firmware anymore. Any ideas how to restore baseband, EMEIs or it is too late?
    Click to expand...
    Click to collapse
    Yep, I told you several times that you need Recovery mode (selected) for your Ramdisk=No device; instructions for this are also clear in official Installation Instruction page too, but apparently you have not been trying to follow official instructions, so it's no real surprise you've messed up firmware too... Please take *extra* care when modding as there are simply so many variables and pitfalls! 😬

    Are you flashing patched AP (Application Processor binary) along with all the other package binaries (X4?) for your S10+ (also in Magisk Installation page, Samsung section)??

    CP is Cellular Processor (Nb. Oft repeated references to CP as 'core processor' may be misleading) binary package (also referred to as Baseband Modem) so that should have fixed mismatched baseband etc... correct CSC (Consumer Software Customization; region, APN and carrier specific software packages/settings) and even BL (Bootloader) are most likely also important...

    Nb. BL doesn't always update bootloader version, but if later firmware has been flashed be aware that these can also cause anti-roll back version for bootloader to be incremented (in the event that an update patches serious vulns) so you original firmware may be blocked and you may need to use later packages only...

    If flashing latest complete firmware package via Odin doesn't fix your IMEI / baseband issues it may be that you've messed with partitions that contain unique device values in the past... You may need to ask in Galaxy, S10 or S10+ XDA forums for that. 🤠 PW
    View
    4
    bombadier
    bombadier
    HippoMan said:
    I'm now having a problem hiding the TJW Magisk 27002 app ...

    I finally was able to resurrect my old Pixel 5. It's running stock A11 and was running TJW Magisk 26004 with no problem.

    The Magisk manager was showing that the upgrade to 27002 was ready for installation, and so I did the following:

    (1) Unhide Magisk
    (2) Update Magisk (27002 was listed)
    (3) After Magisk manager restarted, I did Direct Update to 27002, including reboot
    (4) Magisk 27002 indeed came up properly after reboot.
    (5) Tried to perform Hide The Magisk App.

    I entered the arbitrary name for hiding, and I clicked "OK". But the hiding never took place.

    I rebooted again, to see if perhaps that's necessary, and I repeated the hiding attempt by adding the same arbitrary name, and I again clicked "OK". But the hiding still didn't take place.

    I searched my device, and there is no app nor shortcut with that arbitrary name. I also tried other, different arbitrary names, but after clicking "OK", the hiding still didn't take place for any name I chose.

    What am I missing?
    Click to expand...
    Click to collapse
    Known problem with 27002, the debug version doesn't have the problem with hiding, read back to see the discussion about it
    View
    3
    badabing2003
    badabing2003
    Elvara said:
    I actually updated the app from the app itself before doing my OTA upgrade so it get the version 27 of magisk, I tried installing that one again I had in my downloaded folder. But I also downloaded again the app from github.

    I do have root, I've modified the boot file with magisk, so I'm not sure what to do now. I'll try installing an older version. But as you see of the screenshot from app manager, I don't know how the app is installed and removed almost immediately. At first I thought it was caused by an android 14 new security change.
    Click to expand...
    Click to collapse
    Run magisk -c from adb shell and see what version it reports.
    Then uninstall every copy of magisk app,
    You have more than one (including possibly a hidden one)
    Then reboot and install magisk app matching the version reported by magisk -c command.
    View
  • 1103
    T
    topjohnwu
    This is the place for general support and discussion regarding "Public Releases", which includes both stable and beta releases.
    All information, including troubleshoot guides and notes, are in the Announcement Thread
    View
    156
    T
    topjohnwu
    Hello, I haven't given much support on XDA lately. It can be resulted from
    • University started and I have limited free time. In fact, I mostly develop during midnight
    • I live in Taiwan, which has large time zone differences between my European/American contributors/testers, which usually forces me to stay up late at night to discuss/test stuffs.
    • The new version is about to come, I don't want to spend effort on supporting old releases
    The planned update is delayed again and again, to some point I think I'll shed some light about what has been happening lately, also along with some announcements.

    New Forum!
    As you might have already discovered, Magisk got its own subforum on XDA! Many thanks to all the support you gave me, and much more information/features/support is about to come!
    **For developers supporting all the devices that are not using standard Android boot format, feel free to create threads in this section (actually, PLEASE do so) for your favorite devices after v7 is out. As I currently know, Asus devices require signing the boot image before flashing, and is model dependant; Sony devices seems to use ELF kernel that is unpatchable, or some has two ramdisks (inner + outer), both requires different workarounds; LG bootloader locked devices has to manually "BUMP" the boot image after flashing Magisk..... and there may be lots of other crazy boot image formats that haven't come up to my attention yet.
    It is impossible for me to support all these non-standard boot images, and I hope the community can collaborate to make Magisk running across all the devices. Overall, community collaboration is what XDA about :D

    The Pixel Phone
    Some of you might already know this news, that the next Pixel Phone right around the corner seems like it does not have ramdisk in boot image, which pretty much wrecked Magisk in all ways. However, it pretty much doomed root itself too. Kernel modifications is inevitable IMO, so I'll try to migrate my scripts to C programs that could possibly be included into the kernel itself. Note that I'm not familiar with linux kernel, I'm not even sure if my idea and concept is correct or not. But once the device is available, I think developers will find a way to bypass all the difficulties, and I'll do my best to learn things ;)

    Current Progress
    In the past month, I've spent quite some time learning SELinux, so that I can avoid using SuperSU's sepolicy patches. Thanks to the helps and tips from @phhusson and @Chainfire, I finally have a much clearer understanding of how SELinux works. The Magisk core parts (the scripts, boot image patches, new features, more supports) are actually done some time ago. What is causing all the delays is the Magisk Manager.
    To be completely honest, although I can code in Java without much issues, Magisk Manager is actually my first Android application, I had to reach out for assistance, and fortunately awesome developers like @DVDandroid and @digitalhigh contributed a lot, which makes the current Manager awesome.
    After the repo system and module management is mostly done, I was about to do some adjustments and release, but what we really done is decided to add another feature: auto-unroot with per-app settings. I decided to wait for it to be finished, and then do my adjustments. Due to reasons that'll be mentioned later, this feature will likely not be available for the next release (should come in future updates)

    Safety Net Disaster
    Those who are using Magisk for Safety Net bypass purposes must have known that Google recently updated the detection method of my Systemless Xposed. I still have no idea what Safety Net is detecting, so currently I cannot fix it on my side (also because I'm busy working on the next update). However, suhide developed by @Chainfire is able to hide Xposed and worked fine.
    However, only my Systemless Xposed v86.2, which is based on SuperSU's su.d, is supported using that method. v86.2 and v86.5 (latest, Magisk based) have nearly identical binaries, and the only difference is the path where the binaries are stored.
    I'm still not sure what's the real issue for it not being supported, I just hope it is not done intentionally.

    Conclusion
    Due to the fact that my Safety Net bypass is not 100% perfect now, I do not want to spend any more time waiting for auto-unroot to be polished. What I'm doing now is finishing up all the things I'd like to change in Magisk Manager (it has been a while since I last contributed to Manager, my fellow developers are doing all the heavy job), which might take a little more time, after that, packed with tons of information to be announced in Magisk Section, I'll release the long awaited update.

    Hope this lengthy post gives you the idea of the whole situation, and again thanks for all your support!!
    View
    121
    Chainfire
    Chainfire
    Ah, some Chainfire bashing, I hope it is not too late for me to exercise additional villainy.

    First, let me make clear I have nothing against @topjohnwu, nor against Magisk. Magisk is an interesting project and it certainly displays @topjohnwu ingenuity and persistence. I don't doubt we will see more interesting things from his hands.

    -------------------------

    What has happened here is not all that dark and complicated, from either end. I returned from holidays, and someone pointed me at Magisk. My first thought: interesting!

    Among other things, the thread lists some issues with SuperSU, which in combination with the phrase The developer also requests users to not bug Chainfire with compatibility requests for SuperSU with Magisk from the portal article, raised my left eyebrow by nigh half an inch. The popular systemless xposed mod is apparently now based on it, and apparently it now no longer works with SuperSU, and apparently I'm not supposed to fix that, nor any of the other found issues. I found that a bit weird. So yes, I have told @topjohnwu that I was a bit surprised he was posting about issues with SuperSU without notifying me about them (I can't fix or help fix issues I'm not aware of, after all).

    He's also spreading a modified version of the SuperSU package, which is not all that uncommon, nor necessarily a problem. I have not looked into what he modified, I only ran a few quick tests on one of my devices, and found some commonly used commands run as root to be broken. I have informed him of this as well.

    It appears the tool of choice for Magisk is phh's Superuser, because of some of the mentioned issues with SuperSU. That's fine by itself, but fixing issues in that superuser by incorporating SuperSU's binaries into it is a somewhat questionable practise. After all, SuperSU is a commercial closed-source package that helps pay for my dinner, and superuser is a direct competitor. I have informed him that I was surprised he did this without asking for permission. I have expressed similar surprise on him spreading a modified version of LiveBoot (which helps pay for a snack now and then).
    @topjohnwu has also stated that Magisk's scripts are largely influenced by mine (I have not checked). Scripts based on mine are used all over the place on XDA, some people have crafted amazing things based on them, I have never made an issue of this (otherwise I would have just made them binaries). But yes, I have also stated to him that I don't think it's very nice to base something on one program, and then using that to (almost exclusively) push something directly competing with that program.

    tl;dr Towards @topjohnwu, I have:
    - expressed surprise he has issues getting Magisk to work with SuperSU, and has chosen not to inform me about those
    - expressed surprise he is using SuperSU binaries in a competing superuser without permission
    - expressed surprise he is posting a modified LiveBoot without permission
    - informed him of issues with the modified SuperSU he has posted
    - let him know I thought it wasn't very nice to be applying my scripts to benefit seemingly exclusively that same competing superuser

    To be crystal clear:
    - I have not asked for an apology
    - I have not asked for Magisk to be abandoned, neither the root hiding nor systemless module parts, and certainly not systemless xposed
    - I have not made an issue of any of this anywhere, until this post
    - I have not even specifically asked for anything to be taken down (though obviously in my opinion the other superuser package mixed with SuperSU's binaries, as well as the LiveBoot package, should go)
    - I have not reported this thread to XDA moderators for copyright violations or otherwise

    While my conversation with @topjohnwu may not win any awards for being friendly (though it may win some for brevity), I think all things considered my response has been rather mild. To be perfectly honest, until the apology post, I thought this was over with already. I think the apology post was triggered because I haven't replied to his last PM for a while - I was in the zone, it happens.

    To emphasize again, I have nothing against @topjohnwu, Magisk, or systemless xposed, and it is certainly not my goal to see any of them go. If it can be made to work together with SuperSU, great.

    I get it though: you think of something, you want to see if you can make it work, you finally get it to work, you publish it, it takes off - enthusiasm gets the better of you. Maybe in the rush some mistakes are made. That doesn't mean you have to just drop it and run. None of my stuff would make it past 0.1 if I stopped at the first big mistake :)

    Aside from said being in the zone coding, I usually regret actually responding to these sort of things the day after, which has made me hesitant to reply. Surprise me.
    View
    76
    nathanchance
    nathanchance
    Thread temporarily closed so everyone sees this.

    The flood of "SafetyNet isn't working for me either!" posts are not helpful, at all. Please refrain from posting further, it will be looked into. Please do not forget that not passing SafetyNet is 100% NORMAL AND INTENDED when you have an unlocked booloader or running custom firmware. These are workarounds and they will be worked around in turn.

    The Flash
    Forum Moderator

    EDIT: Thread is reopened... I will be cleaning any SafetyNet posts for a while to keep the thread clean for real issues.
    View
    75
    T
    topjohnwu
    Hello everyone!

    I am aware that Google has updated Safety Net that makes Magisk itself a no go for Android Pay. In fact, I witnessed the change live while I am developing the new magiskhide, which should hide all Magisk modules and Magisk installed root.

    Google is serious about Safety Net now, clearly hunting down all possibility to run Xposed with Safety Net passed. I spend quite some time examining the new security measures last midnight, and fortunately it seems that it is possible to run Magisk and root along with Safety Net if no Xposed is running. I'm glad I removed the old root toggle at the right time lol, that is no longer feasible with the latest detection.

    So stay tuned for the next update, it will come with bug fixes, along with the new magiskhide to bypass that Safety Net.

    Google, how will a few systemless mods do any harm :p:p
    View

New posts