Yeah, not sure what the problem is (possibly Magisk itself?), but I've noticed as well that after some restarts my fingerprint sensor just wont work. A simple reboot fixes the issue, but I dont know what causes it in the first place
FYI: Almost everything in this mod is available as stand alone modules, as they should be. I don't appreciate you #1 copying the work of others and not giving them credit and #2 not detailing all of the changes your mod makes.
Not one mention has been made about your mod setting DNS to Google's numbers - that has nothing to do with AOD or changing accent colors. Also your mod makes aesthetic changes like increased rounded corners that weren't detailed that I dislike.
Here's everything in the system.prop for Jack's mod.
Here is the standalone module for changing System Accent Colors (which can also be found in Magisk's own repo that jack blatantly copied: System Accent Theme (Colors) for P
The only thing ^ changes is color.
Not one mention has been made about your mod setting DNS to Google's numbers - that has nothing to do with AOD or changing accent colors. Also your mod makes aesthetic changes like increased rounded corners that weren't detailed that I dislike.
Here's everything in the system.prop for Jack's mod.
Code:
# This file will be read by resetprop
# Example: Change dpi
# ro.sf.lcd_density=320
# jacksummers test
persist.sys.overlay.nightmode=true
debug.performance.tuning=1
net.dns1=8.8.8.8
net.dns2=8.8.4.4
ro.ril.enable.amr.wideband=1
persist.cust.tel.eons=1
ro.config.hw_fast_dormancy=1
ro.config.media_vol_steps=15
# enable signal cheating
persist.sys.oem_smooth=1
ro.config.hw_quickpoweron=true
# Property to enable touch optimizations
persist.vendor.qti.inputopts.enable=true
persist.vendor.qti.inputopts.movetouchslop=0.7
net.tethering.noprovisioning=true
ro.wallpapers_loc_request_suw=true
persist.camera.gcam.fd.ensemble=1The only thing ^ changes is color.
I'm glad you don't appreciate it...
Maybe something good will come out of this... Maybe you'll compile something on your own...
But probably not...
G
GuestK00177
Guest
Wow, i am thoroughly amazed/amused at this. I have never plagiarized anything. My main screen name has over 36,000 thanks. I didnt get there by stealing people's work. Not that i owe you any explanation, i rarely give airtime to ignorance, but i made this mod well before any similar mod was posted to the magisk repo.u can look all over the essential and treble forums. I ported these features from treble. Nowhere else. U can easily look around and see me looking around for different mods and features to port amongst my notes about testing various treble roms. I would never use or even partially utilize anyone else's work without giving credit. It is pure coincidence that a magisk mod featuring the accent color change came out. I never tried it or considered it bc i was on my own path seeking my own customizations. So that my Friend is not the case, your assumptions come across as rude, indignant, and completely of zero merit. Take your ungrateful attitude elsewhere, bc you sir are out of bounds.
Secondly...
This does not in any way change the UI at all. If so, there would be a new system UI apk in the mod. There isnt, cuz that isnt going on at all.
And...
This is a mod. Like everything else on xda, u use this at your own risk. If you do not like the build prop edits or anything else in the mod, uninstall it and dont use it. In the op it says there are build prop edits to improve user performance. Thats what they are. Most sensible folks download something, and look at what exactly it is and does before using. I thought that goes without saying. I guess not and unfortunately i will have to be more thorough in describing what each aspect does. A lot of other notes describing the mod are listed in all 3 long pages of discussion.
Oh yeah lastly, where is the rest of the mods at as individual installable magisk mods? I haven't seen any magisk modules that make it so aod works on essential stock... Nonetheless, the attitude you have exhibited here makes a profound opinion of you. Especially in regards to the authors of this mod being people who are known to be helpers of the Android community. Not plagiarizing kangers.
Viciously attacking developers who are not the type of people you presume them to be is completely rude. Please rethink your rhetoric and at least look into whatever your plagiaristic theory is before trying to be condescending to someone you know nothing about and make accusations about something you clearly do not fully understand.
It should go without saying that one does not just post on a thread a bunch of foul stuff without even asking about said "issues" with the developer or messaging them or anything.
The Magisk module that only changes accent color was posted to the Magisk repository before you published this mod. I looked at the code and included APK's/color choices and they're 100% identical.
I felt false advertised to when I saw all this extra stuff that has nothing to do with AOD and accent color included in your mod that I don't consider "optimizations" and was compelled to contribute my thoughts to this forum openly. I don't know what to tell you dude. Sorry you feel attacked as that was a long over-reaction. If you wrote everything yourself, kudos to you and I apologize for accusing you of plagiarizing open code without citing the original authors.
You should still be very clear about what your mod does and cite any additional authors of code you didn't author.
I felt false advertised to when I saw all this extra stuff that has nothing to do with AOD and accent color included in your mod that I don't consider "optimizations" and was compelled to contribute my thoughts to this forum openly. I don't know what to tell you dude. Sorry you feel attacked as that was a long over-reaction. If you wrote everything yourself, kudos to you and I apologize for accusing you of plagiarizing open code without citing the original authors.
You should still be very clear about what your mod does and cite any additional authors of code you didn't author.
G
GuestK00177
Guest
I usually do list everything, but i reluctantly posted from my phone one day just to help a few people out. I usually only share with a few people due to someone kanging my work a few months ago. The color accents will most likely all be exactly the same cuz they are from google. the source is available to everyone. The oem's didnt include this for who knows what reason. Everything else is in the rearview. I was not feeling attacked as much as insulted. That person you insinuated I was, it is not me. All is good.
For the accent colours, it had an option called pixel, which i enabled and got the pixel blue colour instead of Essential's teal. However, after a bit of time, it reverted to teal, and the pixel colour isn't in the list anymore. Please help
G
GuestK00177
Guest
I have pixel and teal in my color list still. Try disabling the module, reboot, then reflash the module
FYI:
V2 of your mod still pushes all the sysui icons up several pixels... And it also seems to drag the status bar down a few pixels as well?
G
GuestK00177
Guest
Can u share some screenshots please? We can adjust the padding to make it work, but we are just guessing cuz there isnt anything essential compiled for our UI..so its kinda wild west..thanks man..
Hope I can help with this. First one is with installed mod, second without. Thanks for your efforts!
G
GuestK00177
Guest
Ooh darn. Ok, we will get it fixed soon as we can. Thanks man
Lol, the v2 was just the first one cleaned up. I'll get it this up morning. Plus those new build props
everything is working great thanks for this and for some reason I don't have the padding issue weird .
Attachments
https://www.androidfilehost.com/?fid=1322778262904023617
Updated the framework rro and added to setprop
#App Memory improvement
ro.vendor.qti.sys.fw.bservice_enable=true
ro.vendor.qti.sys.fw.bservice_limit=5
ro.vendor.qti.sys.fw.bservice_age=5000
#Quota Feature
persist.qua.op=0
#Gesture Boot
vendor.perf.gestureflingboost.enable=true
Updated the framework rro and added to setprop
#App Memory improvement
ro.vendor.qti.sys.fw.bservice_enable=true
ro.vendor.qti.sys.fw.bservice_limit=5
ro.vendor.qti.sys.fw.bservice_age=5000
#Quota Feature
persist.qua.op=0
#Gesture Boot
vendor.perf.gestureflingboost.enable=true
Last edited:
Lol, u funny bruh. Sent you a pmAnd... Padding is fixed...
And fingerprint is broken
And a reboot brought it back
@aer0zer0
The Teal color that should be available according to the mod... For whatever reason... Is not making it into the Display menu...
The teal.apk is slightly larger than the others in the sbin image...
Also... It seems like a lot of the colors are screwy...
Our Apps
Get our official app!
The best way to access XDA on your phone
Nav Gestures
Add swipe gestures to any Android
One Handed Mode
Eases uses one hand with your phone