[Magisk] Root for the Galaxy S10 Series

Search This thread

ZmisiS

Senior Member
Dec 23, 2011
2,592
519
58
Livno
When I flash on ADB magisk_patched recovery.img, and after install Android s magisk patched AP, phone is root, but not have TWRP. When I install TWRP, not have magisk_patched recovery, and not have root. I can only have one, but I can’t have both. I’d love to have both, but on Android 11 One UI 3.1 it doesn’t work.

The May 2021 security update is now live for the Galaxy S10 series​



 
Last edited:

J.Michael

Senior Member
Jan 20, 2018
703
497
Samsung Galaxy Tab A series
I tried open TWRP, but System boot and I not have TWRP.
Yes, when you have Magisk installed, and you do not have TWRP installed, how do you boot?

What buttons do you press to boot? Do you have to let go of the buttons at the right time?

When Magisk is installed in recovery, to boot and have Magisk active, you boot as if you are booting to recovery, but you have to let go of the buttons at the right time, so that Magisk will know that you are not really trying to get to recovery.

TWRP is *a* recovery. If you downloaded a TWRP that has been patched by Magisk, and you install that TWRP into recovery, then to get TWRP you boot to recovery. To get Magisk, you have to start booting to recovery, but let go of the buttons at the right time.

You said you were able to install TWRP, but then you couldn't have Magisk. I think that if you have TWRP patched by Magisk, you would need to boot the same way you did when you just had Magisk: start by booting to recovery, but let go of the buttons soon enough. "Soon enough" is a pain.
 

ZmisiS

Senior Member
Dec 23, 2011
2,592
519
58
Livno
Yes, when you have Magisk installed, and you do not have TWRP installed, how do you boot?

What buttons do you press to boot? Do you have to let go of the buttons at the right time?

When Magisk is installed in recovery, to boot and have Magisk active, you boot as if you are booting to recovery, but you have to let go of the buttons at the right time, so that Magisk will know that you are not really trying to get to recovery.

TWRP is *a* recovery. If you downloaded a TWRP that has been patched by Magisk, and you install that TWRP into recovery, then to get TWRP you boot to recovery. To get Magisk, you have to start booting to recovery, but let go of the buttons at the right time.

You said you were able to install TWRP, but then you couldn't have Magisk. I think that if you have TWRP patched by Magisk, you would need to boot the same way you did when you just had Magisk: start by booting to recovery, but let go of the buttons soon enough. "Soon enough" is a pain.
When I have TWRP I have and Magisk, but phone not root. When I install firmware on Odin, I uncheck Auto Reboot. After install, I press Power and Vol Down buttons, after black screen, I press Vol Up + Bixby + Power button and phone is in Recovery mode. In Recovery mode I restart phone, phone boot in OS, but I have not rooted phone.

When I flashed magisk_patched.img recovery in ADB before install firmware in Odin, I have rooted phone. With TWRP I've not get rooted phone.
 
Last edited:

J.Michael

Senior Member
Jan 20, 2018
703
497
Samsung Galaxy Tab A series
When I have TWRP I have and Magisk, but phone not root. When I install firmware on Odin, I uncheck Auto Reboot. After install, I press Power and Vol Down buttons, after black screen, I press Vol Up + Bixby + Power button and phone is in Recovery mode. In Recovery mode I restart phone, phone boot in OS, but I have not rooted phone.

When I flashed magisk_patched.img recovery in ADB before install firmware in Odin, I have rooted phone. With TWRP I've not get rooted phone.
"When I have TWRP I have and Magisk, but phone not root."
I am having trouble understanding this. If you do not have root, how do you know that you have Magisk?

What do you mean "flashed magisk_patched.img recovery in ADB before install firmware in Odin"?
How do you "flash" in ADB?

When you had Magisk and root, but you did not have TWRP, was it easy to boot?
 
Last edited:

ZmisiS

Senior Member
Dec 23, 2011
2,592
519
58
Livno
"When I have TWRP I have and Magisk, but phone not root."
I am having trouble understanding this. If you do not have root, how do you know that you have Magisk?

What do you mean "flashed magisk_patched.img recovery in ADB before install firmware in Odin"?
How do you "flash" in ADB?

Whem you had Magisk and root, but you did not have TWRP, was it easy to boot?
After boot in OS I installed Magisk. I opened Magisk, but Magisk not in root.

I go in ADB file in C:\adb, open Command prompt in file as Administrator. Use 'adb devices' > 'adb reboot bootloader > fastboot flash recovery magisk_patched.img. I've get notification: Waiting for any device'.

Yes.
 

J.Michael

Senior Member
Jan 20, 2018
703
497
Samsung Galaxy Tab A series
After boot in OS I installed Magisk. I opened Magisk, but Magisk not in root.

I go in ADB file in C:\adb, open Command prompt in file as Administrator. Use 'adb devices' > 'adb reboot bootloader > fastboot flash recovery magisk_patched.img. I've get notification: Waiting for any device'.

Yes.
You need to distinguish between Magisk Manager app and Magisk.

When you have Magisk and root, how do you boot?

I thought that fastboot was not available on Samsungs in general, and this device in particular.

If you really have fastboot available, you should be able to run TWRP without installing it:
Code:
fastboot boot TWRP.img
The way people talked about it, I thought this could be done on the phone, without using a PC, without using adb. (I have never had fastboot, I do not know anything.)
 

ZmisiS

Senior Member
Dec 23, 2011
2,592
519
58
Livno
You need to distinguish between Magisk Manager app and Magisk.

When you have Magisk and root, how do you boot?

I thought that fastboot was not available on Samsungs in general, and this device in particular.

If you really have fastboot available, you should be able to run TWRP without installing it:
Code:
fastboot boot TWRP.img
The way people talked about it, I thought this could be done on the phone, without using a PC, without using adb. (I have never had fastboot, I do not know anything.)
Samsung not have fastboot. Therefore, it is a notice: Waiting for any device. When phone root I have Magisk Manager, when phone not root, I have Magisk. I not have Magisk Manager.

Have you rooted phone and have you installed TWRP on Android 11, One UI 3.1?

My Phone not rooted. I've installed TWRP on OS with Magisk patched AP file. Can I update firmware if patch AP file of new firmware? If I can, how?
 
Last edited:

J.Michael

Senior Member
Jan 20, 2018
703
497
Samsung Galaxy Tab A series
Samsung not have fastboot. Therefore, it is a notice: Waiting for any device. When phone root I have Magisk Manager, when phone not root, I have Magisk. I not have Magisk Manager.
Other way around: Magisk Manager is the app you install with an .apk file. You can always run Magisk Manager. It gives information (like Ramdisk=No"). It is what you use to patch an image file.
Have you rooted phone and have you installed TWRP on Android 11, One UI 3.1?
I have never rooted a phone. I have installed Magisk on a tablet (SM-T290).
I have never installed TWRP.
My Phone not rooted. I've installed TWRP on OS with Magisk patched AP file. Can I update firmware if patch AP file of new firmware? If I can, how?
If you cannot get Magisk to work now, you probably cannot get Magisk to work with new firmware.
There are cases where it was possible to get Magisk to work, but new firmware made it impossible.
There are cases where, once you update the firmware, you cannot go back.

If you can get Magisk installed and working, stop there. Do not install TWRP. Do not update your firmware.
 
  • Like
Reactions: ZmisiS

phpi

Member
Jan 1, 2009
32
9
Hello,
I followed the tutorial to the letter https://topjohnwu.github.io/Magisk/install.html#magisk-in-recovery
but I still have to put the usb cable to restart on magik, and safetynet don't work. Do you have an idea ?

I do not touch the odin options and I let the S10 restart automatically, ramdisk no, sar yes.

thanks a lot.

edit : I finally succeeded, thanks to the twrp image modified and reintegrated into AP. and multidisabler.zip. but now i have a "ctsprofile" error, but is it bothering something? and impossible to update some applications like chrome.

thanks

edit 2 :) : safetynet is good with this https://droidholic.com/safetynet-cts-profile-failed-fix/ but if unfortunately I restart normally, the recovery disappears and I can no longer return to magik. -_-
 
Last edited:

J.Michael

Senior Member
Jan 20, 2018
703
497
Samsung Galaxy Tab A series
Hello,
I followed the tutorial to the letter https://topjohnwu.github.io/Magisk/install.html#magisk-in-recovery
but I still have to put the usb cable to restart on magik, and safetynet don't work. Do you have an idea ?

I do not touch the odin options and I let the S10 restart automatically, ramdisk no, sar yes.

thanks a lot.

edit : I finally succeeded, thanks to the twrp image modified and reintegrated into AP. and multidisabler.zip. but now i have a "ctsprofile" error, but is it bothering something? and impossible to update some applications like chrome.

thanks

edit 2 :) : safetynet is good with this https://droidholic.com/safetynet-cts-profile-failed-fix/ but if unfortunately I restart normally, the recovery disappears and I can no longer return to magik. -_-
I think it is normal that some devices need to be booted with a USB cable plugged in at the right moment. I thought I remembered it being the easiest way for some people to get to the download mode. It is not a sign of you having done something wrong, it is just the way some devices are.

Are you saying that now you are unable to boot to Magisk, even with the USB cable?
 

ZmisiS

Senior Member
Dec 23, 2011
2,592
519
58
Livno

Attachments

  • 1.png
    1.png
    81.1 KB · Views: 17
  • Like
Reactions: phpi and J.Michael

phpi

Member
Jan 1, 2009
32
9
Hello,
I followed the tutorial to the letter https://topjohnwu.github.io/Magisk/install.html#magisk-in-recovery
but I still have to put the usb cable to restart on magik, and safetynet don't work. Do you have an idea ?

I do not touch the odin options and I let the S10 restart automatically, ramdisk no, sar yes.

thanks a lot.

edit : I finally succeeded, thanks to the twrp image modified and reintegrated into AP. and multidisabler.zip. but now i have a "ctsprofile" error, but is it bothering something? and impossible to update some applications like chrome.

thanks

edit 2 :) : safetynet is good with this https://droidholic.com/safetynet-cts-profile-failed-fix/ but if unfortunately I restart normally, the recovery disappears and I can no longer return to magik. -_-

Bonjour, merci beaucoup, en effet, j'ai lu sur un forum samsung que le câble usb est nécessaire pour accéder à la récupération. J'ai tout recommencé,( with auto reboot odin off) without twrp et tout semblait fonctionner.

Donc, si le téléphone est éteint, le premier démarrage se fait avec le câble USB et la combinaison de touches vol up + bixby + power libérée du deuxième message d'avertissement,

et pour le redémarrage, j'utilise le menu de démarrage du gestionnaire magisk et tout va bien.

Translation:
Hello, thank you very much, indeed, I read on a samsung forum that the usb cable is necessary to access the recovery. I started all over again, (with auto reboot odin off) without twrp and everything seemed to work.

So if the phone is turned off, the first boot is done with the USB cable and the key combination vol up + bixby + power released from the second warning message,

and for reboot i use the magisk manager boot menu and everything is fine.
 
Last edited by a moderator:
  • Like
Reactions: J.Michael

ZmisiS

Senior Member
Dec 23, 2011
2,592
519
58
Livno
Hello, thanks a lot, indeed, I read on a samsung forum that the usb cable is necessary for access to recovery. I started all over again, no twrp and everything seemed to work.

So if the phone is off, the first start is done with the usb cable and the key combination vol up + bixby + power released from the second warning message,

and for REboot, I use the start menu of magisk manager and all is ok.
Have you and root phone and TWRP?
 

ZmisiS

Senior Member
Dec 23, 2011
2,592
519
58
Livno
For now no because it seems to me that on my previous attempt, multidisabler could not deactivate vaultkeeper. I will try again soon and I will get back to you.
I tried with this tutorial, but I have not succeed.


 

phpi

Member
Jan 1, 2009
32
9
I am an idiot i completely forgot that knox blocked Spay on phone and watch and health -_- and magisk hide don't work. i can pay with the watch and add cards but only by launching samsung pay from the watch.
 
Last edited:
  • Like
Reactions: J.Michael

phpi

Member
Jan 1, 2009
32
9
yeaah it's work ! twrp and magisk. my phone => s10, ramdisk no, sar yes, stock rom.

- I have follow the tutorial on this post for magik BUT with autoreboot OFF in odin, with bl, ap (patch with magik), cp and csc.

Always with usb connected, the phone is turned off with vol down and power,
as soon as the screen goes black, key combination vol up + bixby + power released from the second warning message,

The system starts on magik, we finish its installation with the apk manager.
I have download this for the safetynet https://droidholic.com/safetynet-cts-profile-failed-fix/
so far everything is fine, fingerprint reader, etc. not yet twrp.

- And restart the same flash with odin but with the last twrp recovery patched with magik and reintegrated into magik AP, no stock ap. (rename and replace only recovery), but with Home CSC.

the phone is turned off with vol down and power,
as soon as the screen goes black, key combination vol up + bixby + power always maintained until twrp recovery appears. i DON'T flash mutlidisabler because useless for me anyway, and bootloop, I thought that because it is indicated here :

https://forum.xda-developers.com/t/...of-stock-recovery-proca-wsm-cass-etc.3919714/
  • Vaultkeeper: Magisk now dynamically disables this during boot, but if you boot outside of Magisk, it will return with a vengeance on some devices.
I have only flash this for bluetooth https://forum.xda-developers.com/t/...s-loss-android-11-10-pie-oreo-nougat.4017735/ and "MagiskHide Props Config" module.

finish.

reboot to magisk from the twrp restart menu (recovery!)

now and i don't know why, i no longer need usb cable or key combination to boot on magisk ! magnificent.

- you can click "shutdown" and start normally with just the "power" button, this return to magisk,
- BUT after several tests, never clic on "reboot" in the android power menu, nor reboot system in twrp.
Otherwise you will have to reboot on twrp (vol up + bixby + power always maintained until twrp recovery appears) with a usb cable and reboot on "recovery".

Only secure folder, and samsung pay does not work (no error message for Spay, but the application no longer reacts after entering the samsung account) Spay Gwatch works fine after a first launch from the Gwatch.
for samsung health, builtprop, tima=O.

sorry for my school english (google traduction :D)

regards.
 
Last edited:

Top Liked Posts

  • There are no posts matching your filters.
  • 2
    Hi!
    Can I root latest Android 11 with One UI 3.1 and security updates from June 1. 2021?
    Yes. I have update on Android patched 1. june 2021.
    1
    Thanks for the tip!

    I am indeed using the AP_* file extracted from the firmware zip. I had been transferring it to the device via FTP, I hadn't thought of using adb for this purpose.

    I've just given it a go and sure enough it is working now. Thank you very much for the assistance cameronkelley28!

    A gold star for you.
    1
    It was this one I'm pretty sure.

    I will just be using adb going forward.
    1
    When you are in Odin try Press buttons Vol Down + Power together, when black screen, press Vol Up + Bixby + Power buttons for open Recoveri. In Recoveri Factori Data reset and retart phone. It do after install firmware in Odin. Phone need be connected with PC on USB cable.
    1
    @topjohnwu advised against only specifying AP in Odin.
    I know, but when i use all the files, i go into bootloop
  • 239
    Here comes official Magisk support for the Galaxy S10!
    Let's get Magisk to kick start the development of these Samsung devices!

    Link to Instructions
    Carefully read through everything in the page linked above! Follow the instructions closely so you don't end up bricking your device

    Technical Details
    Google enforces all devices that ships with Android 9.0 to use system-as-root in part of "Project Treble", so Samsung finally introduced their own "flavor" of the implementation. More details regarding system-as-root can be found in the official Google dev site. Samsung is using the A-only system-as-root setup, meaning that its boot image will only contain the kernel binary without ramdisk included. Similar setup has already been deployed on many new devices, and the solutions for those devices are rather simple: add a new ramdisk section into the boot image and hexpatch the kernel to always use ramdisk as rootfs. However in Samsung's case, the bootloader simply does not load anything other than the kernel binary to the memory, meaning no matter what we do the kernel will always use the system partition as root directory. This leaves us no option but to install Magisk onto the recovery partition.

    Installing to the recovery partition have its own issues: first is that a service called "flash_recovery" will run when the system starts up, which will restore the recovery image back to stock on startup. This is unacceptable because not only does it uninstall Magisk in the process, the data encryption key will also be changed due to fact that Samsung's data encryption keys are tied to the bootloader status and boot/recovery image signatures, and thus causing the device unable to boot in following reboots unless factory reset. The solution to this problem is to simply repack the boot image to remove the binary integrity and also the signature of the partition. The second issue is that since Magisk and recovery shares the same partition, how can we actually boot into recovery? (e.g. to factory reset your device, or have custom recovery co-exist with Magisk) Fortunately a solution that detects button key presses is introduced, which details are already provided in instructions.

    To make matters even worse, Samsung introduced a "VaultKeeper" service, which adds another "lock" on top of the OEM lock of the bootloader. By default the service will "relock" the bootloader after data is wiped. Only after the initial setup will it verify the OEM lock option and changes the bootloader state accordingly. If you are running custom firmware with stock system, DO NOT try to wipe data or else you might end up bricking your device due to vaultkeeper locking your bootloader up, which will eventually lead to bootloader refusing to boot because unofficial partitions are detected.

    For custom ROM developers, the first few things you would want to remove is VaultKeeper to protect your users from bricking their devices. For stock ROM users, just make sure to always boot to Magisk after a data wipe, or never power off your device before finishing the initial setup and verify OEM lock is enabled.
    21
    OK guys, @PillowCake[/MENTI[SIZE="3"][/SIZE]ON] [MENTION=5902940]bininga59 @Norup58
    In the interests of accuracy for everyone, afterall this what XDA is all about isn't it, I am scrubbing previous post and re-worded a new one.

    ---------- Post added at 06:24 PM ---------- Previous post was at 06:14 PM ----------

    Firmware updates and keeping your data,
    for phones Magisk rooted without TWRP.

    Just download new firmware, copy the AP file of the new firmware to your phone.
    Open Magisk Manager, ensure Magisk is up to date, if not, update it.
    When Magisk is up to date, if you have any Magisk Modules running, go into Modules and disable them (no need to uninstall them). Then reboot and go back into Magisk Manager.
    Hit the top INSTALL, select INSTALL again then select 'Select and Patch a File'
    Locate the new AP file from your new firmware and patch it. Then copy the magisk_patched.tar back to your computer, preferably with ADB to minimize corruption during transfer.
    Power off phone and reboot to Download mode.
    Open Odin 3.13.1 on your computer, and
    deselect Reboot under Options tab. Now use the new magisk_patched file in the AP slot, the BL and CP from your new firmware into their respective slots and importantly HOME_CSC into the CSC slot. Press start and let Odin do it's stuff.

    When flashed, do not wipe. Press and hold Vol-down and Power, when screen goes off, quickly change to Vol-up, Bixby button and Power. As soon as screen appears, let go of all buttons.
    Within moments without any further user intervention your phone will reboot into your updated Magisk rooted mode, data intact.
    Just re-enable your previously disabled Magisk modules.
    16
    Hi guys!!
    Got a S10, rooted with magisk, no TWRP installed.
    I want to update to the latest Firmware with magisk, but without wipe everything , is it possible?
    What are the steps please?

    Galaxy S10 Firmware update.
    The Galaxy S10 May firmware update has started to appear and users will be wanting to update their firmware without losing their data and keep their Magisk root.

    For phones with Magisk root only without TWRP.
    The process is similar to when you first rooted your phone but you need all the firmware files and DO NOT wipe.
    Download your new firmwware using Frija or Samfirm, making absolutely sure it is the correct version for your phone model and region (csc), you can use an app such as 'Phone INFO' to help here.
    Unzip the downloaded file to an easy place to find on your computer.
    From this unzipped folder locate the file name beginning AP and copy this file to your phone.
    On your phone open Magisk Manager and hit INSTALL against Magisk, prompt will come up, hit INSTALL, Select Method - Select and Patch a File, then choose the AP file you have just copied to your phone. Let Magisk process complete.
    Copy the new magisk_patched file on your phone back to your computer, preferably the same folder you copied the AP from.
    Open Odin (use Odin3_v3.13.1) On Odin Option tab untick Auto Reboot.
    Power off your phone and connect it to your computer. Press and hold volume-down until Download screen appears then volume-up to continue. On Odin the box below ID:COM should turn blue.
    For the AP option select the magisk_patched file, then select the BL file and the CP file, then the HOME_CSC file.
    Click Start and let the process complete - several minutes.
    Now the nimble fingers bit, remember NO WIPE. Press and hold Bixby button, (Bixby is superfluous but convenient at this first point) Vol-down and Power, when screen goes off, quickly change to Vol-up button whilst still holding Bixby and Power. As soon as screen appears, let go of all buttons.
    Your phone will now reboot into Magisk rooted mode with all your data intact.
    14
    Hi John (@topjohnwu),

    Great job with this find & guide for it. It works flawlessly if all the steps are followed 100%. Thanks!

    I've made a full video tutorial (including ROM downloading and everything), maybe it'll help others who have had problems or just want to see the process while or before they perform it.

    Feel free to post it in the OP if you think it helps in any way.

    The video link is as follows: https://youtu.be/o3a8YnWT3yk

    Thanks!
    12
    Last night, I used Magisk Manager to patch the AP file from the ASD5 firmware. This is actually the first time I have upgraded in this way, and I must say that John has made life extremely easy for all of us.

    I just wanted to give a tip for anyone who is already running TWRP on their device at the time they need to update their firmware.

    Using John's procedure, you'll have to enter download mode a second time to re-install TWRP and re-disable encryption. Since I screw up getting into download mode once in a while, I find it a nerve-racking experience, since failing to boot into download mode at this juncture could initiate a system reboot that would re-encrypt /data.

    So, before you flash the patched AP, you can make a copy of your existing Magisk-rooted TWRP recovery. For example, a quick way to do it is by typing this in a root shell:

    Code:
    # dd if=/dev/block/sda15 of=recovery.img

    Next, replace the stock recovery image in the AP file that you patched using Magisk Manager. On Linux, that would look something like this. Adapt these commands for whichever platform you use.

    Code:
    $ tar f magisk_patched.tar --delete recovery.img
    $ tar rf magisk_patched.tar recovery.img

    Now, when you flash the resulting file in Odin and reboot, all you have to do is hold the recovery combo down until you reach TWRP. Then, simply disable encryption again (e.g. by flashing my own multidisabler zip) and reboot.

    I followed the above procedure myself last night and it worked like a charm.